On Wed, Oct 28, 2020 at 05:48:57PM +0100, Igor Mammedov wrote:
> On Tue, 27 Oct 2020 14:21:19 -0400
> Paolo Bonzini <pbonz...@redhat.com> wrote:
>
> > There is no reason to prevent -preconfig -daemonize. Of course if
> > no monitor is defined there will be no way to start the VM,
> > but that is a user error.
>
> it was related to how libvirt starts QEMU but I don't recall why anymore,
> CCing Daniel
Libvirt didn't request this to best of my knowledge.
We don't even use -daemonize, so have no reason to ask to forbid
-preconfig with -daemonize.
>
> >
> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> > ---
> > softmmu/vl.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/softmmu/vl.c b/softmmu/vl.c
> > index 7f39ebdfee..dbb72e621e 100644
> > --- a/softmmu/vl.c
> > +++ b/softmmu/vl.c
> > @@ -4027,12 +4027,6 @@ void qemu_init(int argc, char **argv, char **envp)
> > }
> >
> > if (is_daemonized()) {
> > - if (!preconfig_exit_requested) {
> > - error_report("'preconfig' and 'daemonize' options are "
> > - "mutually exclusive");
> > - exit(EXIT_FAILURE);
> > - }
> > -
> > /* According to documentation and historically, -nographic
> > redirects
> > * serial port, parallel port and monitor to stdio, which does not
> > work
> > * with -daemonize. We can redirect these to null instead, but
> > since
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
