[PULL 0/2] Error reporting patches for 2020-10-09

2020-10-08 Thread Markus Armbruster
The following changes since commit 497d415d76b9f59fcae27f22df1ca2c3fa4df64e: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20201008-1' into staging (2020-10-08 21:41:20 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/

[PATCH V2 07/14] s390x/: fix some comment spelling errors

2020-10-08 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/s390x. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang Reviewed-by: David Edmondson --- target/s390x/cpu_models.h | 4 ++-- target/s390x/excp_helper.

[PATCH V2 01/14] cris/: fix some comment spelling errors

2020-10-08 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/cris. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang Reviewed-by: David Edmondson --- target/cris/helper.c| 6 +++--- target/cris/op_helper.c | 2 +-

[PATCH V2 03/14] riscv/: fix some comment spelling errors

2020-10-08 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/riscv. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang Reviewed-by: David Edmondson Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 2 +-

[PATCH V2 09/14] sh4/: fix some comment spelling errors

2020-10-08 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/sh4. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang Reviewed-by: David Edmondson Reviewed-by: Philippe Mathieu-Daude --- target/sh4/cpu.h | 2 +- tar

[PATCH 3/5] Fixing Lesser GPL version number [3/5]

2020-10-08 Thread Chetan Pant
There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Also, It came to notice that some of the files that were edite

[PULL 11/14] util/async: Add aio_co_reschedule_self()

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf Add a function that can be used to move the currently running coroutine to a different AioContext (and therefore potentially a different thread). Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Message-Id: <20201005155855.256490-12-kw...@redhat.com> Reviewed-by: Markus

[PATCH V2 05/14] tricore/: fix some comment spelling errors

2020-10-08 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/tricore. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang Reviewed-by: David Edmondson --- target/s390x/ioinst.c | 2 +- target/tricore/csfr.def| 2

[PATCH V2 00/14] fix some comment spelling errors

2020-10-08 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/. I used spellcheck to check the spelling errors and found some errors in the folder. The checkpatch.pl file in the Linux kernel can check spelling errors in patches. I'm trying to add this function to the checkpatch.pl in

[PATCH V2 06/14] mips/: fix some comment spelling errors

2020-10-08 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/mips. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang Reviewed-by: David Edmondson Reviewed-by: Philippe Mathieu-Daude --- target/mips/internal.h

[PULL 08/14] qapi: Add a 'coroutine' flag for commands

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf This patch adds a new 'coroutine' flag to QMP command definitions that tells the QMP dispatcher that the command handler is safe to be run in a coroutine. The documentation of the new flag pretends that this flag is already used as intended, which it isn't yet after this patch.

[PATCH 2/5] Fixing Lesser GPL version number [2/5]

2020-10-08 Thread Chetan Pant
There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Also, It came to notice that some of the files that were edite

[PATCH 4/5] Fixing Lesser GPL version number [4/5]

2020-10-08 Thread Chetan Pant
There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Also, It came to notice that some of the files that were edite

[PULL 14/14] block: Convert 'block_resize' to coroutine

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf block_resize performs some I/O that could potentially take quite some time, so use it as an example for the new 'coroutine': true annotation in the QAPI schema. bdrv_truncate() requires that we're already in the right AioContext for the BlockDriverState if called in coroutine co

[PULL 10/14] hmp: Add support for coroutine command handlers

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf Often, QMP command handlers are not only called to handle QMP commands, but also from a corresponding HMP command handler. In order to give them a consistent environment, optionally run HMP command handlers in a coroutine, too. The implementation is a lot simpler than in QMP bec

[PULL 12/14] block: Add bdrv_co_enter()/leave()

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf Add a pair of functions to temporarily move the current coroutine to the AioContext of a given BlockDriverState. Signed-off-by: Kevin Wolf Message-Id: <20201005155855.256490-13-kw...@redhat.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Markus Armbruster --- include/block/

[PULL 13/14] block: Add bdrv_lock()/unlock()

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf Inside of coroutine context, we can't directly use aio_context_acquire() for the AioContext of a block node because we already own the lock of the current AioContext and we need to avoid double locking to prevent deadlocks. This provides helper functions to lock the AioContext o

[PULL 09/14] qmp: Move dispatcher to a coroutine

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf This moves the QMP dispatcher to a coroutine and runs all QMP command handlers that declare 'coroutine': true in coroutine context so they can avoid blocking the main loop while doing I/O or waiting for other events. For commands that are not declared safe to run in a coroutine,

[PATCH 1/5] Fixing Lesser GPL version number [1/5]

2020-10-08 Thread Chetan Pant
There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Also, It came to notice that some of the files that were edite

[PULL 04/14] hmp: Update current monitor only in handle_hmp_command()

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf The current monitor is updated relatively early in the command handling code even though only the command handler actually needs it. The current monitor will become coroutine-local later, so we can only update it when we know in which coroutine the command will be exectued. Move

[PULL 05/14] qmp: Assert that no other monitor is active

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf monitor_qmp_dispatch() is never supposed to be called in the context of another monitor, so assert that monitor_cur() is NULL instead of saving and restoring it. Signed-off-by: Kevin Wolf Message-Id: <20201005155855.256490-6-kw...@redhat.com> Reviewed-by: Markus Armbruster Rev

[PULL 03/14] monitor: Use getter/setter functions for cur_mon

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf cur_mon really needs to be coroutine-local as soon as we move monitor command handlers to coroutines and let them yield. As a first step, just remove all direct accesses to cur_mon so that we can implement this in the getter function later. Signed-off-by: Kevin Wolf Message-Id:

[PULL 07/14] monitor: Make current monitor a per-coroutine property

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf This way, a monitor command handler will still be able to access the current monitor, but when it yields, all other code code will correctly get NULL from monitor_cur(). This uses a hash table to map the coroutine pointer to the current monitor of that coroutine. Outside of cor

[PULL 00/14] Monitor patches for 2020-10-09

2020-10-08 Thread Markus Armbruster
The following changes since commit 497d415d76b9f59fcae27f22df1ca2c3fa4df64e: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20201008-1' into staging (2020-10-08 21:41:20 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pu

[PULL 06/14] qmp: Call monitor_set_cur() only in qmp_dispatch()

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf The correct way to set the current monitor for a coroutine handler will be different than for a blocking handler, so monitor_set_cur() needs to be called in qmp_dispatch(). Signed-off-by: Kevin Wolf Message-Id: <20201005155855.256490-7-kw...@redhat.com> Reviewed-by: Markus Armb

[PULL 02/14] monitor: Add Monitor parameter to monitor_get_cpu_index()

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf Most callers actually don't have to rely on cur_mon, but already know for which monitor they call monitor_get_cpu_index(). Signed-off-by: Kevin Wolf Message-Id: <20201005155855.256490-3-kw...@redhat.com> Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi Signed-off-b

[PULL 01/14] monitor: Add Monitor parameter to monitor_set_cpu()

2020-10-08 Thread Markus Armbruster
From: Kevin Wolf Most callers actually don't have to rely on cur_mon, but already know for which monitor they call monitor_set_cpu(). Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Message-Id: <20201005155855.256490-2-kw...@redhat.com> Reviewed-by: Markus Armbruster Reviewed-by: Stefan Haj

Re: Emulate Rpi with QEMU fails

2020-10-08 Thread Alex Bennée
Thomas <74cmo...@gmail.com> writes: > Interesting enough is: my top figure reported by perf is like yours: > > Samples: 6M of event 'cycles:u', Event count (approx.): 1936571734942 > Overhead Command Shared Object Symbol >7,95% qemu-system-arm qemu-system-arm

Re: [PATCH v3 45/81] target/arm: Implement SVE2 HISTCNT, HISTSEG

2020-10-08 Thread LIU Zhiwei
On 2020/9/19 2:37, Richard Henderson wrote: From: Stephen Long Signed-off-by: Stephen Long Message-Id: <20200416173109.8856-1-stepl...@quicinc.com> Signed-off-by: Richard Henderson --- v2: Fix overlap between output and input vectors. --- target/arm/helper-sve.h| 7 +++ target/arm

[Bug 1899082] Re: ReplayKernel.test_x86_64_pc fails intermittently

2020-10-08 Thread Pavel Dovgalyuk
I can 100% reproduce it with the following command line: taskset 1 tests/venv/bin/avocado --show=app,console,replay run -t arch:x86_64 ../tests/acceptance/replay_kernel.py -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.

Re: [PATCH v2 0/6] spapr/xive: Activate StoreEOI in P10 compat guests

2020-10-08 Thread Cédric Le Goater
On 10/9/20 2:23 AM, David Gibson wrote: > On Mon, Oct 05, 2020 at 06:51:41PM +0200, Cédric Le Goater wrote: >> Hello, >> >> When an interrupt has been handled, the OS notifies the interrupt >> controller with an EOI sequence. On the XIVE interrupt controller >> (POWER9 and POWER10), this can be don

Re: [PATCH v2 5/5] MAINTAINERS: Remove myself

2020-10-08 Thread Jiaxun Yang
在 2020/10/8 18:21, Philippe Mathieu-Daudé 写道: On 10/8/20 9:21 AM, chen huacai wrote: Hi, Aleksandar, On Thu, Oct 8, 2020 at 4:40 AM Aleksandar Markovic wrote: I have been working on project other than QEMU for some time, and would like to devote myself to that project. It is imposible for

Re: Emulate Rpi with QEMU fails

2020-10-08 Thread Paul Zimmerman
Running 'top -H' (to show individual threads) I see qemu is using 6 to 7 threads while running, and each thread is taking from 15% to 70% or so of cpu time. So probably qemu is not able to spread the work among the threads evenly enough to use all the cpu time available. Might be an interesting ar

[PATCH v3 4/6] nbd: Simplify qemu bitmap context name

2020-10-08 Thread Eric Blake
Each dirty bitmap already knows its name; by reducing the scope of the places where we construct "qemu:dirty-bitmap:NAME" strings, tracking the name is more localized, and there are fewer per-export fields to worry about. This in turn will make it easier for an upcoming patch to export more than o

[PATCH v3 6/6] nbd: Allow export of multiple bitmaps for one device

2020-10-08 Thread Eric Blake
With this, 'qemu-nbd -B b0 -B b1 -f qcow2 img.qcow2' can let you sniff out multiple bitmaps from one server. qemu-img as client can still only read one bitmap per client connection, but other NBD clients (hello libnbd) can now read multiple bitmaps in a single pass. Signed-off-by: Eric Blake ---

[PATCH v3 0/6] Exposing backing-chain allocation over NBD

2020-10-08 Thread Eric Blake
v2 was here: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg10926.html Since then: rebase to master patches 1-3/5 of v2 are in pull request patch 4/5 in v2 (1/6 here) includes improvements from Vladimir patches 3-6/6 here are new (and I hope to have public patches to libnbd's 'nbdinfo --

[PATCH v3 5/6] nbd: Refactor counting of meta contexts

2020-10-08 Thread Eric Blake
Rather than open-code the count of negotiated contexts at several sites, embed it directly into the struct. Signed-off-by: Eric Blake --- nbd/server.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index 6326d6fe3f3a..366

[PATCH v3 2/6] nbd: Add 'qemu-nbd -A' to expose allocation depth

2020-10-08 Thread Eric Blake
Allow the server to expose an additional metacontext to be requested by savvy clients. qemu-nbd adds a new option -A to expose the qemu:allocation-depth metacontext through NBD_CMD_BLOCK_STATUS; this can also be set via QMP when using block-export-add. qemu as client can be hacked into viewing th

[PATCH v3 3/6] nbd: Update qapi to support multiple bitmaps

2020-10-08 Thread Eric Blake
Since 'nbd-server-add' is deprecated, and 'block-export-add' is new to 5.2, we can still tweak the interface. Allowing 'bitmaps':['str'] is nicer than 'bitmap':'str'. This wires up the qapi and qemu-nbd changes to permit passing multiple bitmaps, but the actual support will require a further patc

[PATCH v3 1/6] nbd: Add new qemu:allocation-depth metacontext

2020-10-08 Thread Eric Blake
'qemu-img map' provides a way to determine which extents of an image come from the top layer vs. inherited from a backing chain. This is useful information worth exposing over NBD. There is a proposal to add a QMP command block-dirty-bitmap-populate which can create a dirty bitmap that reflects a

[PATCH] vnc-stubs: Allow -vnc none

2020-10-08 Thread Jason Andryuk
Currently `-vnc none` is fatal when built with `--disable-vnc`. Make vnc_parse accept "none", so QEMU still run without using vnc. Signed-off-by: Jason Andryuk --- ui/vnc-stubs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/vnc-stubs.c b/ui/vnc-stubs.c index 06c4ac6296..c6b737dcec

Re: [PATCH 3/3] tests/acceptance: Test case for detecting -object crashes

2020-10-08 Thread Cleber Rosa
On Thu, Oct 08, 2020 at 04:27:13PM -0400, Eduardo Habkost wrote: > Add a simple test case that will run QEMU directly (without QMP) > just to check for crashes when using `-object`. > > Signed-off-by: Eduardo Habkost > --- > Cc: Cleber Rosa > Cc: "Philippe Mathieu-Daudé" > Cc: Wainer dos Santos

Re: [PATCH v2 0/6] spapr/xive: Activate StoreEOI in P10 compat guests

2020-10-08 Thread David Gibson
On Mon, Oct 05, 2020 at 06:51:41PM +0200, Cédric Le Goater wrote: > Hello, > > When an interrupt has been handled, the OS notifies the interrupt > controller with an EOI sequence. On the XIVE interrupt controller > (POWER9 and POWER10), this can be done with a load or a store > operation on the ES

Re: [PATCH v4 0/5] pseries NUMA distance calculation

2020-10-08 Thread David Gibson
On Wed, Oct 07, 2020 at 02:28:44PM -0300, Daniel Henrique Barboza wrote: > This forth version is based on review comments and suggestion > from David in v3. > > changes from v3: > - patch 4: > * copied the explanation in spapr_numa_define_associativity_domains() > to the commit message >

Re: [PATCH 18/20] python/qemu/qmp.py: re-raise OSError when encountered

2020-10-08 Thread John Snow
On 10/7/20 3:17 PM, John Snow wrote: On 10/7/20 7:30 AM, Kevin Wolf wrote: Am 07.10.2020 um 01:58 hat John Snow geschrieben: Nested if conditions don't change when the exception block fires; we need to explicitly re-raise the error if we didn't intend to capture and suppress it. Signed-off-by:

[PATCH 6/6] hw/gpio: Add GPIO model for Nuvoton NPCM7xx

2020-10-08 Thread Havard Skinnemoen via
The NPCM7xx chips have multiple GPIO controllers that are mostly identical except for some minor differences like the reset values of some registers. Each controller controls up to 32 pins. Each individual pin is modeled as a pair of unnamed GPIOs -- one for emitting the actual pin state, and one

[PATCH 5/6] hw/arm/npcm7xx: Add EHCI and OHCI controllers

2020-10-08 Thread Havard Skinnemoen via
The NPCM730 and NPCM750 chips have a single USB host port shared between a USB 2.0 EHCI host controller and a USB 1.1 OHCI host controller. This adds support for both of them. Testing notes: * With -device usb-kbd, qemu will automatically insert a full-speed hub, and the keyboard becomes con

[PATCH 2/6] Move npcm7xx_timer_reached_zero call out of npcm7xx_timer_pause

2020-10-08 Thread Havard Skinnemoen via
This allows us to reuse npcm7xx_timer_pause for the watchdog timer. Signed-off-by: Havard Skinnemoen --- hw/timer/npcm7xx_timer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/timer/npcm7xx_timer.c b/hw/timer/npcm7xx_timer.c index 5703e43d40..2df9e3e496 100644 ---

[PATCH 4/6] hw/misc: Add npcm7xx random number generator

2020-10-08 Thread Havard Skinnemoen via
The RNG module returns a byte of randomness when the Data Valid bit is set. This implementation ignores the prescaler setting, and loads a new value into RNGD every time RNGCS is read while the RNG is enabled and random data is available. A qtest featuring some simple randomness tests is included

[PATCH 1/6] tests/qtest: Add npcm7xx timer test

2020-10-08 Thread Havard Skinnemoen via
This test exercises the various modes of the npcm7xx timer. In particular, it triggers the bug found by the fuzzer, as reported here: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg02992.html It also found several other bugs, especially related to interrupt handling. The test exercises

[PATCH 3/6] hw/timer: Adding watchdog for NPCM7XX Timer.

2020-10-08 Thread Havard Skinnemoen via
From: Hao Wu The watchdog is part of NPCM7XX's timer module. Its behavior is controlled by the WTCR register in the timer. When enabled, the watchdog issues an interrupt signal after a pre-set amount of cycles, and issues a reset signal shortly after that. Reviewed-by: Tyrone Ting Signed-off-b

[PATCH 0/6] Additional NPCM7xx features, devices and tests

2020-10-08 Thread Havard Skinnemoen via
This is an update to the initial NPCM7xx patch series adding - A timer test that found several issues that were fixed in the final version of the series (see https://www.mail-archive.com/qemu-devel@nongnu.org/msg739516.html). - Watchdog timer support. This makes the reboot command work

Re: [PATCH 2/3] can-host-socketcan: Fix crash when 'if' option is not set

2020-10-08 Thread Pavel Pisa
Thanks for catching missing test On Thursday 08 of October 2020 22:27:12 Eduardo Habkost wrote: > Fix the following crash: > > $ qemu-system-x86_64 -object can-host-socketcan,id=obj0 > Segmentation fault (core dumped) > > Signed-off-by: Eduardo Habkost > --- > Cc: Pavel Pisa > Cc: Vikram Gar

Re: [PULL v2 00/12] target-arm queue

2020-10-08 Thread Peter Maydell
pull-request-2020-10-06' into staging (2020-10-06 > 21:13:34 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20201008-1 > > for you to fetch changes up to d1b6b7017572e8d82f26eb827a1dba0e8c

more findable locations for compiled/generated files in the build tree?

2020-10-08 Thread Peter Maydell
Is it possible to get Meson to put the files that are generated/compiled as part of the build process in more sensibly findable locations? I would generally expect that a file foo.c should generate into foo.o, and foo/bar.c should generate into foo/bar.o, and if we generate a .c file from foo/bar.d

Re: [PATCH v10 08/10] vfio: Set IOMMU page size as per host supported page size

2020-10-08 Thread Alex Williamson
On Thu, 8 Oct 2020 19:15:56 +0200 Jean-Philippe Brucker wrote: > From: Bharat Bhushan > > Set IOMMU supported page size mask same as host Linux supported page > size mask. > > Signed-off-by: Bharat Bhushan > Signed-off-by: Jean-Philippe Brucker > --- > hw/vfio/common.c | 8 > 1 fi

Re: [PATCH v10 10/10] vfio: Don't issue full 2^64 unmap

2020-10-08 Thread Alex Williamson
On Thu, 8 Oct 2020 19:15:58 +0200 Jean-Philippe Brucker wrote: > IOMMUs may declare memory regions spanning from 0 to UINT64_MAX. When > attempting to deal with such region, vfio_listener_region_del() passes a > size of 2^64 to int128_get64() which throws an assertion failure. Even > ignoring t

[Bug 1899082] Re: ReplayKernel.test_x86_64_pc fails intermittently

2020-10-08 Thread Cleber Rosa
I'm actually able to increase the reproducibility to ~ 90% when running 8 of those tests simultaneously (on an 8 core system). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1899082 Title: ReplayKer

Re: [PATCH 1/3] authz-list-file: Fix crash when filename is not set

2020-10-08 Thread Cleber Rosa
On Thu, Oct 08, 2020 at 04:27:11PM -0400, Eduardo Habkost wrote: > Fix the following crash: > > $ qemu-system-x86_64 -object authz-list-file,id=obj0 > qemu-system-x86_64: -object authz-list-file,id=obj0: GLib: > g_file_get_contents: assertion 'filename != NULL' failed > Segmentation fault (

Re: [PATCH v4 6/6] hw/arm/virt: Implement kvm-steal-time

2020-10-08 Thread Andrew Jones
Hi Peter, Thanks for fixing this up and applying! drew On Thu, Oct 08, 2020 at 09:39:59PM +0100, Peter Maydell wrote: > On Thu, 1 Oct 2020 at 07:17, Andrew Jones wrote: > > > > We add the kvm-steal-time CPU property and implement it for machvirt. > > A tiny bit of refactoring was also done to a

Re: Emulate Rpi with QEMU fails

2020-10-08 Thread Paul Zimmerman
Hi Thomas, What does 'top' say while the emulation is running? I have an 8 cpu-thread system, yet 'top' never shows more than about 300% cpu. I would have thought it would get closer to 800% cpu. And running qemu as root with nice -20 doesn't seem to make much difference. - Paul On Thu, Oct 8, 2

Re: does make check now require TCG? Or is it a parallelism issue?

2020-10-08 Thread Claudio Fontana
On 10/8/20 8:24 PM, Paolo Bonzini wrote: > > > Il gio 8 ott 2020, 20:05 Richard Henderson > ha scritto: > > Ah, TARGET_DIRS isn't being pruned anymore when a target is disabled for > lack > of accelerator. > > Paolo, side effect of 8a19980e3f (

[Bug 1899082] [NEW] ReplayKernel.test_x86_64_pc fails intermittently

2020-10-08 Thread Cleber Rosa
Public bug reported: Even though this acceptance test is already skipped on GitLab CI, the intermittent failures can be seen on other environments too. The record phase works fine, but during the replay phase fail to finish booting the kernel (until the expected place): 16:34:47 DEBUG| [0.03

Re: Which qemu change corresponds to RedHat bug 1655408

2020-10-08 Thread Jakob Bohm
(Top posting because previous reply did so): If the bug was closed as "can't reproduce", why was a very similar bug listed as fixed in RHSA-2019:2553-01 ? On 2020-10-08 18:41, Philippe Mathieu-Daudé wrote: Hi Jakob, On 10/8/20 6:32 PM, Jakob Bohm wrote: Red Hat bugzilla bug 1655408 against

RE: [RFC PATCH v3 26/34] Hexagon (target/hexagon) macros referenced in instruction semantics

2020-10-08 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Thursday, October 8, 2020 2:02 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 26/34] Hexagon (ta

[PULL v2 00/12] target-arm queue

2020-10-08 Thread Peter Maydell
in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20201008-1 for you to fetch changes up to d1b6b7017572e8d82f26eb827a1dba0e8cf3cae6: target/arm: Make '-cpu max' have a 48-bit PA (2020-

Re: [PATCH v4 6/6] hw/arm/virt: Implement kvm-steal-time

2020-10-08 Thread Peter Maydell
On Thu, 1 Oct 2020 at 07:17, Andrew Jones wrote: > > We add the kvm-steal-time CPU property and implement it for machvirt. > A tiny bit of refactoring was also done to allow pmu and pvtime to > use the same vcpu device helper functions. > +if (pvtime_size > pvtime_reg_size) { > +

[PATCH 3/3] tests/acceptance: Test case for detecting -object crashes

2020-10-08 Thread Eduardo Habkost
Add a simple test case that will run QEMU directly (without QMP) just to check for crashes when using `-object`. Signed-off-by: Eduardo Habkost --- Cc: Cleber Rosa Cc: "Philippe Mathieu-Daudé" Cc: Wainer dos Santos Moschetta Cc: qemu-devel@nongnu.org --- tests/acceptance/object_option.py | 49

[PATCH 2/3] can-host-socketcan: Fix crash when 'if' option is not set

2020-10-08 Thread Eduardo Habkost
Fix the following crash: $ qemu-system-x86_64 -object can-host-socketcan,id=obj0 Segmentation fault (core dumped) Signed-off-by: Eduardo Habkost --- Cc: Pavel Pisa Cc: Vikram Garhwal Cc: Jason Wang Cc: qemu-devel@nongnu.org --- net/can/can_socketcan.c | 5 + 1 file changed, 5 inserti

[PATCH 0/3] Fix some crashes when using -object

2020-10-08 Thread Eduardo Habkost
Fix two crashes when using `-object` with no extra arguments, and add a acceptance test case to detect similar crashes in the future. Eduardo Habkost (3): authz-list-file: Fix crash when filename is not set can-host-socketcan: Fix crash when 'if' option is not set tests/acceptance: Test case

[PATCH 1/3] authz-list-file: Fix crash when filename is not set

2020-10-08 Thread Eduardo Habkost
Fix the following crash: $ qemu-system-x86_64 -object authz-list-file,id=obj0 qemu-system-x86_64: -object authz-list-file,id=obj0: GLib: g_file_get_contents: assertion 'filename != NULL' failed Segmentation fault (core dumped) Signed-off-by: Eduardo Habkost --- Cc: "Daniel P. Berrangé" C

[PATCH 2/2] cirrus: Enable doc build on msys2/mingw

2020-10-08 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Signed-off-by: Yonggang Luo --- .cirrus.yml | 8 1 file changed, 8 insertions(+) diff --git a/.cirrus.yml b/.cirrus.yml index 77cfd99afe..b1725bd0c1 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -73,6 +73,7

Re:

2020-10-08 Thread Yonggang Luo
Oh, I've fixed it and patch are sent. On Fri, Oct 9, 2020 at 3:24 AM Paolo Bonzini wrote: > > On 08/10/20 20:30, 罗勇刚(Yonggang Luo) wrote: > > > > > > The text files are in tests/qapi-schema. > > "C:/CI-Tools/msys64/mingw64/bin/python3.exe" > > "C:/work/xemu/qemu/meson/meson.py" "--internal" "exe"

[PATCH 1/2] docs: Fixes build docs on msys2/mingw

2020-10-08 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- scripts/rst-sanitize.py | 21 + tests/qapi-schema/meson.build | 5 +++-- 4 files changed, 26 insertions(+), 4 deletions(-) create mode 100644 scripts/rst-sanit

[PATCH 0/2] Fixes docs building on msys2/mingw

2020-10-08 Thread Yonggang Luo
The cirrus are based on non-merged patches Yonggang Luo (2): docs: Fixes build docs on msys2/mingw cirrus: Enable doc build on msys2/mingw .cirrus.yml | 8 docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- scripts/rst-sanitize.py

Re: [RFC PATCH v3 26/34] Hexagon (target/hexagon) macros referenced in instruction semantics

2020-10-08 Thread Richard Henderson
On 10/8/20 1:51 PM, Taylor Simpson wrote: >> How can it have done without doing the merging by hand. Which this >> operation ordering is intended to make unnecessary. >> >> I think you're missing the point. > > Sorry I wasn't clear. We have done the load from memory as it was at the > beginnin

Re: [RFC PATCH 02/21] contrib/gitdm: Add Amazon to the domain map

2020-10-08 Thread Alexander Graf
On 04.10.20 20:04, Philippe Mathieu-Daudé wrote: There is a number of contributors from this domain, add its own entry to the gitdm domain map. Cc: Alexander Graf Cc: Anthony Liguori Cc: Craig Janeczek Cc: Paul Durrant Cc: Hendrik Borghorst Cc: Julien Grall Cc: KarimAllah Ahmed Cc: Sim

[PATCH v4 10/12] tests/9pfs: wipe local 9pfs test directory

2020-10-08 Thread Christian Schoenebeck
Before running the first 9pfs test case, make sure the test directory for running the 9pfs 'local' tests on is entirely empty. For that reason simply delete the test directory (if any) before (re)creating it on test suite startup. Note: The preferable precise behaviour would be the test directory

[PATCH v4 11/12] tests/9pfs: add virtio_9p_test_path()

2020-10-08 Thread Christian Schoenebeck
This new public function virtio_9p_test_path() allows 9pfs 'local' tests to translate a path from guest scope to host scope. For instance by passing an empty string it would return the root path on host of the exported 9pfs tree. Signed-off-by: Christian Schoenebeck --- tests/qtest/libqos/virtio

[PATCH v4 12/12] tests/9pfs: add local Tmkdir test

2020-10-08 Thread Christian Schoenebeck
This test case uses the 9pfs 'local' driver to create a directory and then checks if the expected directory was actually created (as real directory) on host side. This patch introduces a custom split() implementation, because the test code requires non empty array elements as result. For that reas

Re:

2020-10-08 Thread Paolo Bonzini
On 08/10/20 20:30, 罗勇刚(Yonggang Luo) wrote: > > > The text files are in tests/qapi-schema. > "C:/CI-Tools/msys64/mingw64/bin/python3.exe" > "C:/work/xemu/qemu/meson/meson.py" "--internal" "exe" "--capture" > "tests/qapi-schema/doc-good.txt.nocr" "--" "perl" "-pe" "$x = chr 13; > s/$x$//" "tests/q

[PATCH v4 04/12] libqos/qgraph: add qos_dump_graph()

2020-10-08 Thread Christian Schoenebeck
This new function is purely for debugging purposes. It prints the current qos graph to stdout and allows to identify problems in the created qos graph e.g. when writing new qos tests. Coloured output is used to mark available nodes in green colour, whereas unavailable nodes are marked in red colou

[PATCH v4 03/12] libqos/qgraph_internal: add qos_printf() and qos_printf_literal()

2020-10-08 Thread Christian Schoenebeck
These two are macros wrapping regular printf() call. They are intended to be used instead of calling printf() directly in order to avoid breaking TAP output format. TAP output format is enabled by using --tap command line argument. Starting with glib 2.62 it is enabled by default. Unfortunately t

[PATCH v4 08/12] tests/9pfs: change qtest name prefix to synth

2020-10-08 Thread Christian Schoenebeck
All existing 9pfs test cases are using the 'synth' fs driver so far, which means they are not accessing real files, but a purely simulated (in RAM only) file system. Let's make this clear by changing the prefix of the individual qtest case names from 'fs/' to 'synth/'. That way they'll be easily d

[PATCH v4 05/12] tests/qtest/qos-test: dump qos graph if verbose

2020-10-08 Thread Christian Schoenebeck
If qtests were run in verbose mode (i.e. if --verbose CL argument was provided) then dump the generated qos graph (all nodes and edges, along with their current individual availability status) to stdout. See API doc comment on function qos_dump_graph() for details. Signed-off-by: Christian Schoen

[PATCH v4 07/12] tests/qtest/qos-test: dump QEMU command if verbose

2020-10-08 Thread Christian Schoenebeck
If qtests are run in verbose mode (i.e. if --verbose CL argument was provided) then print the assembled qemu command line for each test. Use qos_printf() instead of g_test_message() to avoid the latter cluttering the output. Signed-off-by: Christian Schoenebeck --- tests/qtest/qos-test.c | 3 ++

[PULL 10/10] migration/dirtyrate: present dirty rate only when querying the rate has completed

2020-10-08 Thread Dr. David Alan Gilbert (git)
From: Chuan Zheng Make dirty_rate field optional, present dirty rate only when querying the rate has completed. The qmp results is shown as follow: @unstarted: {"return":{"status":"unstarted","start-time":0,"calc-time":0},"id":"libvirt-12"} @measuring: {"return":{"status":"measuring","start-time"

[PATCH v4 02/12] libqos/qgraph: add qos_node_create_driver_named()

2020-10-08 Thread Christian Schoenebeck
So far the qos subsystem of the qtest framework had the limitation that only one instance of the same official QEMU (QMP) driver name could be created for qtests. That's because a) the created qos node names must always be unique, b) the node name must match the official QEMU driver name being inst

[PATCH v4 01/12] libqos/qgraph: add qemu_name to QOSGraphNode

2020-10-08 Thread Christian Schoenebeck
Add new member variable 'qemu_name' to struct QOSGraphNode. This new member may be optionally set in case a different name for the node (which must always be a unique name) vs. its actually associated QEMU (QMP) device name is required. Signed-off-by: Christian Schoenebeck --- tests/qtest/libqo

[PULL 06/10] migration: Introduce migrate_send_rp_message_req_pages()

2020-10-08 Thread Dr. David Alan Gilbert (git)
From: Peter Xu This is another layer wrapper for sending a page request to the source VM. The new migrate_send_rp_message_req_pages() will be used elsewhere in coming patches. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu Message-Id: <20201002175336.30858-3-pet...@redhat.com> Si

[PULL 08/10] migration: Sync requested pages after postcopy recovery

2020-10-08 Thread Dr. David Alan Gilbert (git)
From: Peter Xu We synchronize the requested pages right after a postcopy recovery happens. This helps to synchronize the prioritized pages on source so that the faulted threads can be served faster. Reported-by: Xiaohui Li Signed-off-by: Peter Xu Message-Id: <20201002175336.30858-5-pet...@redh

[PATCH v4 09/12] tests/9pfs: introduce local tests

2020-10-08 Thread Christian Schoenebeck
This patch introduces 9pfs test cases using the 9pfs 'local' filesystem driver which reads/writes/creates/deletes real files and directories. In this initial version, there is only one local test which actually only checks if the 9pfs 'local' device was created successfully. Before the 9pfs 'loca

[PATCH v4 00/12] 9pfs: add tests using local fs driver

2020-10-08 Thread Christian Schoenebeck
The currently existing 9pfs test cases are all solely using the 9pfs 'synth' fileystem driver, which is a very simple and purely simulated (in RAM only) filesystem. There are issues though where the 'synth' fs driver is not sufficient. For example the following two bugs need test cases running the

[PULL 03/10] virtiofsd: Call qemu_init_exec_dir

2020-10-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Since fcb4f59c879 qemu_get_local_state_pathname relies on the init_exec_dir, and virtiofsd asserts because we never set it. Set it. Reported-by: Alex Bennée Signed-off-by: Dr. David Alan Gilbert Message-Id: <20201002124015.44820-1-dgilb...@redhat.com> Tested-by:

[PULL 04/10] virtiofsd: avoid /proc/self/fd tempdir

2020-10-08 Thread Dr. David Alan Gilbert (git)
From: Stefan Hajnoczi In order to prevent /proc/self/fd escapes a temporary directory is created where /proc/self/fd is bind-mounted. This doesn't work on read-only file systems. Avoid the temporary directory by bind-mounting /proc/self/fd over /proc. This does not affect other processes since w

[PATCH v4 06/12] tests/qtest/qos-test: dump environment variables if verbose

2020-10-08 Thread Christian Schoenebeck
If qtests are run in verbose mode (i.e. if --verbose CL argument was provided) then print all environment variables to stdout before running the individual tests. Use qos_printf() instead of g_test_message() to avoid the latter cluttering the output. Signed-off-by: Christian Schoenebeck --- tes

[PULL 09/10] migration/dirtyrate: record start_time and calc_time while at the measuring state

2020-10-08 Thread Dr. David Alan Gilbert (git)
From: Chuan Zheng Querying could include both the start-time and the calc-time while at the measuring state, allowing a caller to determine when they should expect to come back looking for a result. Signed-off-by: Chuan Zheng Message-Id: <1601350938-128320-2-git-send-email-zhengch...@huawei.c

[PULL 02/10] tools/virtiofsd: add support for --socket-group

2020-10-08 Thread Dr. David Alan Gilbert (git)
From: Alex Bennée If you like running QEMU as a normal user (very common for TCG runs) but you have to run virtiofsd as a root user you run into connection problems. Adding support for an optional --socket-group allows the users to keep using the command line. Signed-off-by: Alex Bennée Reviewe

[PULL 00/10] migration queue

2020-10-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit e64cf4d569f6461d6b9072e00d6e78d0ab8bd4a7: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20201008' into staging (2020-10-08 17:18:46 +0100) are available in the Git repository at: git://githu

[PULL 07/10] migration: Maintain postcopy faulted addresses

2020-10-08 Thread Dr. David Alan Gilbert (git)
From: Peter Xu Maintain a list of faulted addresses on the destination host for which we're waiting on. This is implemented using a GTree rather than a real list to make sure even there're plenty of vCPUs/threads that are faulting, the lookup will still be fast with O(log(N)) (because we'll do t

  1   2   3   4   >