On 10/8/20 8:24 PM, Paolo Bonzini wrote: > > > Il gio 8 ott 2020, 20:05 Richard Henderson <richard.hender...@linaro.org > <mailto:richard.hender...@linaro.org>> ha scritto: > > Ah, TARGET_DIRS isn't being pruned anymore when a target is disabled for > lack > of accelerator. > > Paolo, side effect of 8a19980e3f ("configure: move accelerator logic to > meson")? I guess we should move the setting of TARGET_DIRS to meson as > well. > > > TARGET_DIRS is pruned by Meson, I didn't add any back propagation to make > because it is not really needed; qemu-iotests only every uses the "host > architecture" QEMU binary (see tests/qemu-iotests/common.config), check-block > + --target-list has never worked. > > check-tcg could use the pruned TARGET_DIRS, but it is of limited use anyway > with --disable-tcg. > > At this point it may make sense to establish which config-host.mak variables > are available in the Makefile, because there's probably just a handful. I > won't have much time in the next couple of weeks though. > > Paolo > > > r~ >
qtests are also broken for me now with --disable-tcg build, it _seems_ to me that TCG-only tests are being run for --disable-tcg too. I am not sure if this is a test problem (for example tests/qtest/bios-tables-test.c): data->tcg_only or if it is a build system problem, or some combination. make check-qtest ... Running test qtest-x86_64: device-plug-test Running test qtest-x86_64: drive_del-test Running test qtest-x86_64: tco-test Running test qtest-x86_64: cpu-plug-test Running test qtest-x86_64: q35-test Running test qtest-x86_64: vmgenid-test Running test qtest-x86_64: migration-test Running test qtest-x86_64: test-x86-cpuid-compat Running test qtest-x86_64: numa-test Running test qtest-x86_64: cdrom-test Running test qtest-x86_64: device-introspect-test Running test qtest-x86_64: machine-none-test Running test qtest-x86_64: qmp-test Running test qtest-x86_64: qmp-cmd-test Running test qtest-x86_64: qom-test Running test qtest-x86_64: test-hmp Running test qtest-x86_64: qos-test qemu-system-x86_64: -accel tcg: invalid accelerator tcg qemu-system-x86_64: falling back to QTest ERROR:../tests/qtest/boot-sector.c:161:boot_sector_test: assertion failed (signature == SIGNATURE): (0x00000000 == 0x0000dead) ERROR qtest-x86_64: bios-tables-test - too few tests run (expected 23, got 22) make: *** [Makefile.mtest:1298: run-test-183] Error 1 make: *** Waiting for unfinished jobs....
