On Thu, Oct 08, 2020 at 04:27:11PM -0400, Eduardo Habkost wrote: > Fix the following crash: > > $ qemu-system-x86_64 -object authz-list-file,id=obj0 > qemu-system-x86_64: -object authz-list-file,id=obj0: GLib: > g_file_get_contents: assertion 'filename != NULL' failed > Segmentation fault (core dumped) > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > --- > Cc: "Daniel P. Berrangé" <berra...@redhat.com> > Cc: qemu-devel@nongnu.org
Out of curiosity, are those notes intended for git-publish? (If so, I
didn't realize it would read them).
> ---
> authz/listfile.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/authz/listfile.c b/authz/listfile.c
> index cd6163aa40..aaf930453d 100644
> --- a/authz/listfile.c
> +++ b/authz/listfile.c
> @@ -122,6 +122,11 @@ qauthz_list_file_complete(UserCreatable *uc, Error
> **errp)
> QAuthZListFile *fauthz = QAUTHZ_LIST_FILE(uc);
> gchar *dir = NULL, *file = NULL;
>
> + if (!fauthz->filename) {
> + error_setg(errp, "filename not provided");
Nitpick: all other similar error messages start capitalized.
- Cleber.
signature.asc
Description: PGP signature
