Re: [PATCH v2 08/13] configure: Add USB U2F key device

2020-08-24 Thread Gerd Hoffmann
Hi, > +# check for u2f support > +if test "$u2f" != "no"; then > +if $pkg_config --atleast-version=0.0.0 u2f-emu; then > +u2f_emu_cflags=$($pkg_config --cflags u2f-emu) > +u2f_emu_libs=$($pkg_config --libs u2f-emu) > +u2f="yes" > +else > +if test "$u2f" =

[PATCH] meson: set colorout to auto

2020-08-24 Thread Gerd Hoffmann
Dunno why the default is set to "always". IMHO it should be "auto", i.e. only colorize in case stdout goes to a terminal. Cluttering logfiles and confusing compiler message parsers with terminal control sequences is not nice ... Signed-off-by: Gerd Hoffmann --- meson.build | 3 ++- 1 file chan

Re: [PATCH v7 3/4] qapi: add filter-node-name to block-stream

2020-08-24 Thread Markus Armbruster
Andrey Shinkevich writes: > Provide the possibility to pass the 'filter-node-name' parameter to the > block-stream job as it is done for the commit block job. > > Signed-off-by: Andrey Shinkevich > Reviewed-by: Vladimir Sementsov-Ogievskiy [...] > diff --git a/qapi/block-core.json b/qapi/block-

Re: [PATCH 1/1] spapr_vscsi: do not allow device hotplug

2020-08-24 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Cc'ing Markus > > On 8/20/20 9:06 PM, Daniel Henrique Barboza wrote: >> We do not implement hotplug in the vscsi bus, but we forgot to >> tell qdev about it. The result is that users are able to hotplug >> devices in the vscsi bus, the devices appear in qdev, but

[PULL 1/3] meson: drop keymaps symlink

2020-08-24 Thread Gerd Hoffmann
We are building the keymaps by default now. Drop the keymaps symlink so the generated files are actually written to the build tree not the source tree. Signed-off-by: Gerd Hoffmann Reviewed-by: Alistair Francis Tested-by: Klaus Jensen Tested-by: Bin Meng Message-id: 20200824074057.3673-1-kra.

[PULL 3/3] meson: avoid compiling qemu-keymap by default

2020-08-24 Thread Gerd Hoffmann
From: Laurent Vivier qemu-keymap is not needed with linux-user, so disable it by default if tools and system are disabled (tools are disabled by default with linux-user). Avoid this error with statically linked binaries: Linking target qemu-keymap /usr/bin/ld: cannot find -lxkbcommon S

[PULL 2/3] meson: move xkbcommon to meson

2020-08-24 Thread Gerd Hoffmann
From: Laurent Vivier Signed-off-by: Laurent Vivier Message-id: 20200824152430.1844159-2-laur...@vivier.eu Signed-off-by: Gerd Hoffmann --- configure | 29 - meson_options.txt | 1 + meson.build | 11 ++- ui/meson.build| 2 +- 4 files chan

[PULL 0/3] Fixes 20200825 patches

2020-08-24 Thread Gerd Hoffmann
The following changes since commit 30aa19446d82358a30eac3b556b4d6641e00b7c1: Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20200812' into staging (2020-08-24 16:39:53 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/fixes-20200825-pull-request

Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations

2020-08-24 Thread Markus Armbruster
Rohit Shinde writes: > Added fallthrough comment on line 270 to prevent the compiler from > throwing an error while compiling with the -Wimplicit-fallthrough flag None of the compilers I know warns there. Which one are you using? Commit message style tip: use the imperative mood https://chris.

Re: [PATCH v2 00/21] aspeed: cleanups and some extensions

2020-08-24 Thread Joel Stanley
On Wed, 19 Aug 2020 at 10:10, Cédric Le Goater wrote: > > Hello, > > This series includes various fixes improving the support of Aspeed > machines. Extra attention was given to the robustness of the ftgmac100 > model. A small kernel module tester was created for this purpose : > >https://githu

Re: [PATCH] tests: fix a memory in test_socket_unix_abstract_good

2020-08-24 Thread Markus Armbruster
Li Qiang writes: > Hi Daniel, > It seems this patch still not in the upstream. Cc: qemu-trivial, hope this helps.

Re: meson.build files are missing copyright/license headers

2020-08-24 Thread Thomas Huth
On 24/08/2020 20.46, Peter Maydell wrote: On Mon, 24 Aug 2020 at 19:29, Marc-André Lureau wrote: On Mon, Aug 24, 2020 at 1:44 PM Peter Maydell wrote: It looks like the new meson.build files are missing the usual copyright-and-license header comment. Could somebody add them, please? scripts

Re: [PATCH v2 08/21] aspeed/sdhci: Fix reset sequence

2020-08-24 Thread Joel Stanley
On Wed, 19 Aug 2020 at 10:10, Cédric Le Goater wrote: > > BIT(0) of the ASPEED_SDHCI_INFO register is set by SW and polled until > the bit is cleared by HW. > > Use the number of supported slots to define the default value of this > register (The AST2600 eMMC Controller only has one). Fix the rese

Re: Contributor wanting to get started with simple contributions

2020-08-24 Thread Thomas Huth
On 25/08/2020 04.26, Rohit Shinde wrote: Hey John, I sent this email a couple of weeks ago to the qemu mailing list since I didn't really know who to approach. Hi Rohit, The qemu-devel mailing list is very high traffic. So I'm sorry, but you might need to be a little bit more specific with

Re: [PATCH 6/6] virtio-vga: Use typedef name for instance_size

2020-08-24 Thread Gerd Hoffmann
On Mon, Aug 24, 2020 at 05:59:36PM -0400, Eduardo Habkost wrote: > This makes the code consistent with the rest of QOM code in QEMU, > and will make automated conversion to type declaration macros > simpler. > > Signed-off-by: Eduardo Habkost Reviewed-by: Gerd Hoffmann

Re: [PATCH] usb: fix setup_len init (CVE-2020-14364)

2020-08-24 Thread Li Qiang
Gerd Hoffmann 于2020年8月25日周二 下午1:37写道: > > Store calculated setup_len in a local variable, verify it, and only > write it to the struct (USBDevice->setup_len) in case it passed the > sanity checks. > > This prevents other code (do_token_{in,out} functions specifically) > from working with invalid U

Re: [PATCH] configure: default to PIE disabled on Windows platforms

2020-08-24 Thread Thomas Huth
On 24/08/2020 18.31, Daniel P. Berrangé wrote: If Windows EXE files are built with -pie/-fpie they will fail to launch. Historically QEMU defaulted to disabling PIE for Windows, but this setting was accidentally lost when the configure summary text was removed in commit f9332757898a764d85e19d

[PATCH] usb: fix setup_len init (CVE-2020-14364)

2020-08-24 Thread Gerd Hoffmann
Store calculated setup_len in a local variable, verify it, and only write it to the struct (USBDevice->setup_len) in case it passed the sanity checks. This prevents other code (do_token_{in,out} functions specifically) from working with invalid USBDevice->setup_len values and overrunning the USBDe

Re: [PATCH 2/2] nbd: disable signals and forking on Windows builds

2020-08-24 Thread Thomas Huth
On 24/08/2020 19.02, Daniel P. Berrangé wrote: Disabling these parts are sufficient to get the qemu-nbd program compiling in a Windows build. Maybe add: "This also enables compilation of qemu-nbd on macOS again (which got disabled by accident during the conversion to the meson build system)"

RE: Known issue? qemu is much slower when built with clang vs gcc

2020-08-24 Thread Brian Cain
Taylor, I can report that the performance looks to be in the ballpark of parity with gcc when we move from clang 8.0 to 11.0 rc2. Perhaps we can attribute this to a since-fixed defect in clang? -Brian From: Taylor Simpson Sent: Monday, August 24, 2020 11:54 AM To: qemu-devel@nongnu.org Cc:

[PATCH v2 1/2] QSLIST: add atomic replace operation

2020-08-24 Thread wanghonghao
Replace a queue with another atomicly. It's useful when we need to transfer queues between threads. Signed-off-by: wanghonghao --- include/qemu/queue.h | 4 1 file changed, 4 insertions(+) diff --git a/include/qemu/queue.h b/include/qemu/queue.h index 456a5b01ee..62efad2438 100644 --- a/in

[PATCH v2 2/2] coroutine: take exactly one batch from global pool at a time

2020-08-24 Thread wanghonghao
This patch replace the global coroutine queue with a lock-free stack of which the elements are coroutine queues. Threads can put coroutine queues into the stack or take queues from it and each coroutine queue has exactly POOL_BATCH_SIZE coroutines. Note that the stack is not strictly LIFO, but it's

Re: [External] Re: [PATCH 1/2] QSLIST: add atomic replace operation

2020-08-24 Thread 王洪浩
This function is indeed a bit vague in semantics. I'll modify this function to make it more in line with `replace`. Stefan Hajnoczi 于2020年8月24日周一 下午11:27写道: > > On Mon, Aug 24, 2020 at 12:31:20PM +0800, wanghonghao wrote: > > Replace a queue with another atomicly. It's useful when we need to tran

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-24 Thread David Gibson
On Mon, Aug 24, 2020 at 08:45:12AM -0300, Daniel Henrique Barboza wrote: > > > On 8/24/20 3:08 AM, David Gibson wrote: > > On Fri, Aug 21, 2020 at 09:47:47AM -0300, Daniel Henrique Barboza wrote: > > > > > > > > > On 8/21/20 5:55 AM, Igor Mammedov wrote: > > > > On Thu, 20 Aug 2020 12:51:03 -04

Re: Contributor wanting to get started with simple contributions

2020-08-24 Thread Rohit Shinde
Hey John, I sent this email a couple of weeks ago to the qemu mailing list since I didn't really know who to approach. I am interested in contributing to the python-qemu package. I have quite a bit of experience in Python, but no experience in packaging libraries. Whatever you mentioned in the re

[PATCH v5 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug

2020-08-24 Thread Chuan Zheng
Add trace_calls to make it easier to debug Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 7 +++ migration/trace-events | 8 2 files changed, 15 insertions(+) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 08c46d3..3513ef3 100644 --- a/migration/dirtyrat

[PATCH v5 09/12] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period()

2020-08-24 Thread Chuan Zheng
Implement get_sample_page_period() and set_sample_page_period() to sleep specific time between sample actions. Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/dirtyrate.c | 24 migration/dirtyrate.h | 2 ++ 2 files changed, 26 insertions(+)

[PATCH v5 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function

2020-08-24 Thread Chuan Zheng
Implement calculate_dirtyrate() function. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index d1c

[PATCH v5 07/12] migration/dirtyrate: Compare page hash results for recorded sampled page

2020-08-24 Thread Chuan Zheng
Compare page hash results for recorded sampled page. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 64 +++ 1 file changed, 64 insertions(+) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 66

[PATCH v5 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status

2020-08-24 Thread Chuan Zheng
add DirtyRateStatus to denote calculating status. Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 22 ++ qapi/migration.json | 17 + 2 files changed, 39 insertions(+) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 366f4e9..91987c5 1

[PATCH v5 06/12] migration/dirtyrate: Record hash results for each sampled page

2020-08-24 Thread Chuan Zheng
Record hash results for each sampled page, crc32 is taken to calculate hash results for each sampled 4K-page. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 136 ++ migration/dirtyrate.h | 15 ++ 2 files

[PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

2020-08-24 Thread Chuan Zheng
Add RamlockDirtyInfo to store sampled page info of each ramblock. Signed-off-by: Chuan Zheng --- migration/dirtyrate.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h index 33669b7..dc45419 100644 --- a/migration/dirtyrate.h +

[PATCH v5 05/12] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h

2020-08-24 Thread Chuan Zheng
RAMBLOCK_FOREACH_MIGRATABLE is need in dirtyrate measure, move the existing definition up into migration/ram.h Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/dirtyrate.c | 1 + migration/ram.c | 11 +-- migration/ram.h | 10 ++ 3 files

[PATCH v5 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE

2020-08-24 Thread Chuan Zheng
In order to sample real RAM, skip ramblock with size below MIN_RAMBLOCK_SIZE which is set as 128M. Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 24 migration/dirtyrate.h | 10 ++ 2 files changed, 34 insertions(+) diff --git a/migration/dirtyrate.c b/mi

[PATCH v5 00/12] *** A Method for evaluating dirty page rate ***

2020-08-24 Thread Chuan Zheng
v4 -> v5: fix git apply failed due to meson-build add review-by for patches in v3 v3 -> v4: use crc32 to get hash result instead of md5 add DirtyRateStatus to denote calculation status add some trace_calls to make it easier to debug fix some comments accroding to review v2

[PATCH v5 01/12] migration/dirtyrate: setup up query-dirtyrate framwork

2020-08-24 Thread Chuan Zheng
Add get_dirtyrate_thread() functions to setup query-dirtyrate framework. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 39 +++ migration/dirtyrate.h | 32 migration/meson.build | 1 + 3

[PATCH v5 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-08-24 Thread Chuan Zheng
Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be called Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 45 + qapi/migration.json | 44 2 files changed, 89 insertions(+)

[PATCH v5 04/12] migration/dirtyrate: Add dirtyrate statistics series functions

2020-08-24 Thread Chuan Zheng
Add dirtyrate statistics to record/update dirtyrate info. Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 29 + migration/dirtyrate.h | 10 ++ 2 files changed, 39 insertions(+) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 91987c5..0

[PATCH v8 11/14] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-08-24 Thread Havard Skinnemoen via
This allows these NPCM7xx-based boards to boot from a flash image, e.g. one built with OpenBMC. For example like this: IMAGE=${OPENBMC}/build/tmp/deploy/images/gsj/image-bmc qemu-system-arm -machine quanta-gsj -nographic \ -drive file=${IMAGE},if=mtd,bus=0,unit=0,format=raw,snapshot=on Re

[PATCH v8 08/14] hw/nvram: NPCM7xx OTP device model

2020-08-24 Thread Havard Skinnemoen via
This supports reading and writing OTP fuses and keys. Only fuse reading has been tested. Protection is not implemented. Reviewed-by: Avi Fishman Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Havard Skinnemoen --- include/hw/arm/npcm7xx.h | 3 + include/hw/nvram/npcm7xx_otp.h | 79

Re: [PATCH 2/2] target/i386: Add missed features to Cooperlake CPU model

2020-08-24 Thread Xiaoyao Li
On 8/25/2020 6:07 AM, Eduardo Habkost wrote: On Wed, Dec 25, 2019 at 02:30:18PM +0800, Xiaoyao Li wrote: It lacks VMX features and two security feature bits (disclosed recently) in MSR_IA32_ARCH_CAPABILITIES in current Cooperlake CPU model, so add them. Fixes: 22a866b6166d ("i386: Add new CPU m

[PATCH v8 14/14] tests/acceptance: console boot tests for quanta-gsj

2020-08-24 Thread Havard Skinnemoen via
This adds two acceptance tests for the quanta-gsj machine. One test downloads a lightly patched openbmc flash image from github and verifies that it boots all the way to the login prompt. The other test downloads a kernel, initrd and dtb built from the same openbmc source and verifies that the ke

[PATCH v8 12/14] hw/arm/npcm7xx: add board setup stub for CPU and UART clocks

2020-08-24 Thread Havard Skinnemoen via
When booting directly into a kernel, bypassing the boot loader, the CPU and UART clocks are not set up correctly. This makes the system appear very slow, and causes the initrd boot test to fail when optimization is off. The UART clock must run at 24 MHz. The default 25 MHz reference clock cannot a

[PATCH v8 06/14] roms: Add virtual Boot ROM for NPCM7xx SoCs

2020-08-24 Thread Havard Skinnemoen via
This is a minimalistic boot ROM written specifically for use with QEMU. It supports loading the second-stage loader from SPI flash into RAM, SMP boot, and not much else. Signed-off-by: Havard Skinnemoen --- Makefile| 1 + .gitmodules | 3 +++ MAINTAINERS

[PATCH v8 07/14] hw/arm: Load -bios image as a boot ROM for npcm7xx

2020-08-24 Thread Havard Skinnemoen via
If a -bios option is specified on the command line, load the image into the internal ROM memory region, which contains the first instructions run by the CPU after reset. If -bios is not specified, the vbootrom included with qemu is loaded by default. Reviewed-by: Tyrone Ting Reviewed-by: Cédric

[PATCH v8 04/14] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-08-24 Thread Havard Skinnemoen via
The Nuvoton NPCM7xx SoC family are used to implement Baseboard Management Controllers in servers. While the family includes four SoCs, this patch implements limited support for two of them: NPCM730 (targeted for Data Center applications) and NPCM750 (targeted for Enterprise applications). This pat

[PATCH v8 13/14] docs/system: Add Nuvoton machine documentation

2020-08-24 Thread Havard Skinnemoen via
Reviewed-by: Cédric Le Goater Signed-off-by: Havard Skinnemoen --- docs/system/arm/nuvoton.rst | 90 + docs/system/target-arm.rst | 1 + 2 files changed, 91 insertions(+) create mode 100644 docs/system/arm/nuvoton.rst diff --git a/docs/system/arm/nuvoton.r

[PATCH v8 09/14] hw/mem: Stubbed out NPCM7xx Memory Controller model

2020-08-24 Thread Havard Skinnemoen via
This just implements the bare minimum to cause the boot block to skip memory initialization. Reviewed-by: Tyrone Ting Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Havard Skinnemoen --- include/hw/arm/npcm7xx.h| 2 + include/hw/mem/npcm7xx_mc.h | 36 +++

[PATCH v8 05/14] hw/arm: Add two NPCM7xx-based machines

2020-08-24 Thread Havard Skinnemoen via
This adds two new machines, both supported by OpenBMC: - npcm750-evb: Nuvoton NPCM750 Evaluation Board. - quanta-gsj: A board with a NPCM730 chip. They rely on the NPCM7xx SoC device to do the heavy lifting. They are almost completely identical at the moment, apart from the SoC type, which cu

[PATCH v8 02/14] hw/misc: Add NPCM7xx Clock Controller device model

2020-08-24 Thread Havard Skinnemoen via
Enough functionality to boot the Linux kernel has been implemented. This includes: - Correct power-on reset values so the various clock rates can be accurately calculated. - Clock enables stick around when written. In addition, a best effort attempt to implement SECCNT and CNTR25M was mad

[PATCH v8 10/14] hw/ssi: NPCM7xx Flash Interface Unit device model

2020-08-24 Thread Havard Skinnemoen via
This implements a device model for the NPCM7xx SPI flash controller. Direct reads and writes, and user-mode transactions have been tested in various modes. Protection features are not implemented yet. All the FIU instances are available in the SoC's address space, regardless of whether or not the

[PATCH v8 01/14] hw/misc: Add NPCM7xx System Global Control Registers device model

2020-08-24 Thread Havard Skinnemoen via
Implement a device model for the System Global Control Registers in the NPCM730 and NPCM750 BMC SoCs. This is primarily used to enable SMP boot (the boot ROM spins reading the SCRPAD register) and DDR memory initialization; other registers are best effort for now. The reset values of the MDLR and

[PATCH v8 03/14] hw/timer: Add NPCM7xx Timer device model

2020-08-24 Thread Havard Skinnemoen via
The NPCM730 and NPCM750 SoCs have three timer modules each holding five timers and some shared registers (e.g. interrupt status). Each timer runs at 25 MHz divided by a prescaler, and counts down from a configurable initial value to zero. When zero is reached, the interrupt flag for the timer is s

[PATCH v8 00/14] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

2020-08-24 Thread Havard Skinnemoen via
I also pushed this and the previous patchsets to my qemu fork on github. The branches are named npcm7xx-v[1-8]. https://github.com/hskinnemoen/qemu This patch series models enough of the Nuvoton NPCM730 and NPCM750 SoCs to boot an OpenBMC image built for quanta-gsj. This includes device models

[PATCH] meson: Mingw64 gcc doesn't recognize system include_type for sdl2

2020-08-24 Thread luoyonggang
From: Yonggang Luo --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.build b/meson.build index df5bf728b5..a3585881e1 100644 --- a/meson.build +++ b/meson.build @@ -224,8 +224,7 @@ if 'CONFIG_BRLAPI' in config_host brlapi = declare_dependency(link_arg

Re: [PATCH v6 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-24 Thread Thiago Jung Bauermann
Philippe Mathieu-Daudé writes: > On 8/22/20 10:59 AM, Cédric Le Goater wrote: >> Hello, >> >> On 8/19/20 6:43 PM, Thiago Jung Bauermann wrote: >>> Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use >>> the start-powered-off property which makes cpu_common_reset() initiali

Re: [PATCH v6 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-24 Thread Thiago Jung Bauermann
David Gibson writes: > On Sat, Aug 22, 2020 at 10:59:56AM +0200, Cédric Le Goater wrote: >> Hello, >> >> On 8/19/20 6:43 PM, Thiago Jung Bauermann wrote: >> > Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use >> > the start-powered-off property which makes cpu_common_res

[PATCH 2/2] fixes relpath may fail on win32.

2020-08-24 Thread luoyonggang
From: Yonggang Luo --- scripts/mtest2make.py | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/scripts/mtest2make.py b/scripts/mtest2make.py index bdb257bbd9..d7a51bf97e 100644 --- a/scripts/mtest2make.py +++ b/scripts/mtest2make.py @@ -53,9 +53,16 @@ i = 0 for tes

[PATCH 1/2] SIMPLE_PATH_RE should match the full path token. Maybe also apply to others such as STRING_RE and TOPLEVEL_RE, not for sure

2020-08-24 Thread luoyonggang
From: Yonggang Luo --- scripts/ninjatool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ninjatool.py b/scripts/ninjatool.py index cc77d51aa8..6ca8be6f10 100755 --- a/scripts/ninjatool.py +++ b/scripts/ninjatool.py @@ -55,7 +55,7 @@ else: PATH_RE = r"[^$\s:|]+|\

[PATCH v2 1/2] linux-user: Add support for ppoll_time64() and pselect6_time64()

2020-08-24 Thread Filip Bozuta
This patch introduces functionality for following time64 syscalls: *ppoll_time64 This is a year 2038 safe variant of: int poll(struct pollfd *fds, nfds_t nfds, int timeout) -- wait for some event on a file descriptor -- man page: https://man7.org/linux/man-pages/man2/ppoll.2.html

Re: [PATCH] meson: drop keymaps symlink

2020-08-24 Thread Alistair Francis
On Mon, Aug 24, 2020 at 12:42 AM Gerd Hoffmann wrote: > > We are building the keymaps by default now. Drop the keymaps symlink > so the generated files are actually written to the build tree not the > source tree. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Alistair Francis Alistair > ---

[PATCH v2 0/2] linux-user: Adding support for a group of 4 time64 syscalls

2020-08-24 Thread Filip Bozuta
This two patch series introduces functionality for following Year 2038 safe syscalls: --Introduced in first patch-- *ppoll_time64() *pselect6_time64() --Introduced in second patch-- *utimensat_time64() *semtimedop_time64() Testing notes: The implementations of these time64 syscalls was teste

Re: [PATCH 4/6] xilinx_axienet: Use typedef name for instance_size

2020-08-24 Thread Alistair Francis
On Mon, Aug 24, 2020 at 3:02 PM Eduardo Habkost wrote: > > This makes the code consistent with the rest of QOM code in QEMU, > and will make automated conversion to type declaration macros > simpler. > > Signed-off-by: Eduardo Habkost Reviewed-by: Alistair Francis Alistair > --- > Cc: "Edgar

[PATCH v2 2/2] linux-user: Add support for utimensat_time64() and semtimedop_time64()

2020-08-24 Thread Filip Bozuta
This patch introduces functionality for following time64 syscalls: *utimensat_time64() int utimensat(int dirfd, const char *pathname, const struct timespec times[2], int flags); -- change file timestamps with nanosecond precision -- man page: https://man7.org/linux/m

Re: [PATCH V1 18/32] osdep: import MADV_DOEXEC

2020-08-24 Thread Alex Williamson
On Wed, 19 Aug 2020 17:52:26 -0400 Steven Sistare wrote: > On 8/17/2020 10:42 PM, Alex Williamson wrote: > > On Mon, 17 Aug 2020 15:44:03 -0600 > > Alex Williamson wrote: > > > >> On Mon, 17 Aug 2020 17:20:57 -0400 > >> Steven Sistare wrote: > >> > >>> On 8/17/2020 4:48 PM, Alex Williamson

Re: [PATCH 1/6] xilinx_axidma: Use typedef name for instance_size

2020-08-24 Thread Alistair Francis
On Mon, Aug 24, 2020 at 2:58 PM Eduardo Habkost wrote: > > This makes the code consistent with the rest of QOM code in QEMU, > and will make automated conversion to type declaration macros > simpler. > > Signed-off-by: Eduardo Habkost Reviewed-by: Alistair Francis Alistair > --- > Cc: "Edgar

[PATCH 5/6] vhost-user-vga: Use typedef name for instance_size

2020-08-24 Thread Eduardo Habkost
This makes the code consistent with the rest of QOM code in QEMU, and will make automated conversion to type declaration macros simpler. Signed-off-by: Eduardo Habkost --- Cc: "Michael S. Tsirkin" Cc: "Marc-André Lureau" Cc: Gerd Hoffmann Cc: qemu-devel@nongnu.org --- hw/display/vhost-user-vg

Re: [PATCH 2/2] target/i386: Add missed features to Cooperlake CPU model

2020-08-24 Thread Eduardo Habkost
On Wed, Dec 25, 2019 at 02:30:18PM +0800, Xiaoyao Li wrote: > It lacks VMX features and two security feature bits (disclosed recently) in > MSR_IA32_ARCH_CAPABILITIES in current Cooperlake CPU model, so add them. > > Fixes: 22a866b6166d ("i386: Add new CPU model Cooperlake") > Signed-off-by: Xiaoy

[PATCH 3/6] lpc_ich9: Use typedef name for instance_size

2020-08-24 Thread Eduardo Habkost
This makes the code consistent with the rest of QOM code in QEMU, and will make automated conversion to type declaration macros simpler. Signed-off-by: Eduardo Habkost --- Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: qemu-devel@nongnu.org --- hw/isa/lpc_ich9.c | 2 +- 1 file changed, 1 in

Re: [PATCH 1/4] configure: Use discovered make for in-source build

2020-08-24 Thread Roman Bolshakov
On Mon, Aug 24, 2020 at 09:37:07AM -0500, Eric Blake wrote: > On 8/22/20 4:21 PM, Roman Bolshakov wrote: > > @@ -38,6 +38,8 @@ then > > # This file is auto-generated by configure to support in-source tree > > # 'make' command invocation > > +include build/config-host.mak > > Should this use '-

[PATCH 2/6] omap_intc: Use typedef name for instance_size

2020-08-24 Thread Eduardo Habkost
This makes the code consistent with the rest of QOM code in QEMU, and will make automated conversion to type declaration macros simpler. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/intc/omap_intc.c | 2 +- 1 file changed, 1 inser

[REPORT] Nightly Performance Tests - Monday, August 24, 2020

2020-08-24 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-08-24 21:30:01 End Time (UTC) : 2020-08-24 22:02:34 Execution Time : 0:32:33.288312 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%. -

[PATCH 1/6] xilinx_axidma: Use typedef name for instance_size

2020-08-24 Thread Eduardo Habkost
This makes the code consistent with the rest of QOM code in QEMU, and will make automated conversion to type declaration macros simpler. Signed-off-by: Eduardo Habkost --- Cc: "Edgar E. Iglesias" Cc: Alistair Francis Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/d

[PATCH 6/6] virtio-vga: Use typedef name for instance_size

2020-08-24 Thread Eduardo Habkost
This makes the code consistent with the rest of QOM code in QEMU, and will make automated conversion to type declaration macros simpler. Signed-off-by: Eduardo Habkost --- Cc: "Michael S. Tsirkin" Cc: Gerd Hoffmann Cc: qemu-devel@nongnu.org --- hw/display/virtio-vga.c | 6 +++--- 1 file change

[PATCH 4/6] xilinx_axienet: Use typedef name for instance_size

2020-08-24 Thread Eduardo Habkost
This makes the code consistent with the rest of QOM code in QEMU, and will make automated conversion to type declaration macros simpler. Signed-off-by: Eduardo Habkost --- Cc: "Edgar E. Iglesias" Cc: Alistair Francis Cc: Peter Maydell Cc: Jason Wang Cc: qemu-...@nongnu.org Cc: qemu-devel@nong

[PATCH 0/6] qom: Use typedefs instead of struct names on instance_size/class_size

2020-08-24 Thread Eduardo Habkost
This changes existing QOM boilerplate to use existing typedef names when setting instance_size and class_size on TypeInfo variables. This makes the code more consistent and will make future conversion to QOM type declaration macros easier. Cc: "Michael S. Tsirkin" Cc: "Marc-André Lureau" Cc: Ge

Re: [PATCH v1 1/1] core/register: Specify instance_size in the TypeInfo

2020-08-24 Thread Eduardo Habkost
On Fri, Aug 21, 2020 at 10:33:06PM -0700, Alistair Francis wrote: > Reported-by: Eduardo Habkost > Signed-off-by: Alistair Francis > --- > hw/core/register.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/hw/core/register.c b/hw/core/register.c > index d

[PATCH 0/6] qom: Use typedefs instead of struct names on instance_size/class_size

2020-08-24 Thread Eduardo Habkost
This changes existing QOM boilerplate to use existing typedef names when setting instance_size and class_size on TypeInfo variables. This makes the code more consistent and will make future conversion to QOM type declaration macros easier. Cc: "Michael S. Tsirkin" Cc: "Marc-André Lureau" Cc: Ge

[PATCH 1/6] xilinx_axidma: Use typedef name for instance_size

2020-08-24 Thread Eduardo Habkost
This makes the code consistent with the rest of QOM code in QEMU, and will make automated conversion to type declaration macros simpler. Signed-off-by: Eduardo Habkost --- Cc: "Edgar E. Iglesias" Cc: Alistair Francis Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/d

Re: [PULL v2 00/24] target/xtensa updates for 5.2

2020-08-24 Thread Max Filippov
On Mon, Aug 24, 2020 at 2:33 PM Peter Maydell wrote: > On Sat, 22 Aug 2020 at 20:48, Max Filippov wrote: > > On Sat, Aug 22, 2020 at 3:20 AM Philippe Mathieu-Daudé > > wrote: > > > > > > Where does that come from? > > > > Generated by xtensa processor generator, as one of many output artifacts.

Re: [PULL v2 00/24] target/xtensa updates for 5.2

2020-08-24 Thread Peter Maydell
On Sat, 22 Aug 2020 at 20:48, Max Filippov wrote: > > On Sat, Aug 22, 2020 at 3:20 AM Philippe Mathieu-Daudé > wrote: > > On 8/21/20 10:50 PM, Max Filippov wrote: > > > please pull the following batch of updates for target/xtensa. > > > > 3.12MiB of generated data... > > > > Where does that come

Re: unknown fs driver type 'virtiofs'

2020-08-24 Thread Pedro Serrano
Dave   Thanks for your attention.   I have gone as far forward upgrading qemu and libvirt packages without going beyond stable+backports.   I believe it is now a waiting game for Debian Buster backports to catch up with the release of newer versions that work with QEMU 5.0.0.   If you have any

Re: [PATCH v3 2/2] linux-user: Add support for 'mq_timedsend_time64()' and 'mq_timedreceive_time64()'

2020-08-24 Thread Laurent Vivier
Le 24/08/2020 à 21:37, Filip Bozuta a écrit : > This patch implements functionality for following time64 syscalls: > > *mq_timedsend_time64() > > This is a year 2038 safe vairant of syscall: > > int mq_timedsend(mqd_t mqdes, const char *msg_ptr, > size_t msg_len, uns

Re: [PATCH v3 1/2] linux-user: Add support for 'clock_nanosleep_time64()' and 'clock_adjtime64()'

2020-08-24 Thread Laurent Vivier
Le 24/08/2020 à 21:21, Filip Bozuta a écrit : > This patch implements functionality for following time64 syscall: > > *clock_nanosleep_time64() > > This is a year 2038 safe vairant of syscall: > int clock_nanosleep(clockid_t clockid, int flags, > const struct times

Re: [PATCH v3 2/2] linux-user: Add support for 'rt_sigtimedwait_time64()' and 'sched_rr_get_interval_time64()'

2020-08-24 Thread Laurent Vivier
Le 24/08/2020 à 21:21, Filip Bozuta a écrit : > This patch implements functionality for following time64 syscalls: > > *rt_sigtimedwait_time64() > > This is a year 2038 safe variant of syscall: > > int rt_sigtimedwait(const sigset_t *set, siginfo_t *info, > const

Re: [PATCH v3 1/2] linux-user: Fix 'mq_timedsend()' and 'mq_timedreceive()'

2020-08-24 Thread Laurent Vivier
Le 24/08/2020 à 21:37, Filip Bozuta a écrit : > Implementations of syscalls 'mq_timedsend()' and 'mq_timedreceive()' > in 'syscall.c' use functions 'target_to_host_timespec()' and > 'host_to_target_timespec()' to transfer the value of 'struct timespec' > between target and host. However, the implem

Re: [PATCH v4 5/5] linux-user: Add strace support for printing arguments of some clock and time functions

2020-08-24 Thread Laurent Vivier
Le 11/08/2020 à 18:45, Filip Bozuta a écrit : > This patch implements strace argument printing functionality for following > syscalls: > > * clock_getres, clock_gettime, clock_settime - clock and time functions > > int clock_getres(clockid_t clockid, struct timespec *res) > i

Re: msys2/mingw meson building fixes

2020-08-24 Thread Yonggang Luo
After this fixes, the configure succeed, but the make -j10 failed with ``` $ make -j10 python3 -B /e/CI-Cor-Ready/xemu/qemu.org/meson/meson.py introspect --tests | python3 -B scripts/mtest2make.py > Makefile.mtest ./ninjatool -t ninja2make --omit clean dist uninstall < build.ninja > Makefile.ninja

Fwd: msys2/mingw meson building fixes

2020-08-24 Thread Yonggang Luo
-- Forwarded message - From: 罗勇刚(Yonggang Luo) Date: Tue, Aug 25, 2020 at 4:50 AM Subject: msys2/mingw meson building fixes To: qemu-level I've create a pull request for fixes python ninja detection and usage on msys2/mingw at https://github.com/mesonbuild/meson/pull/7637 --

Re: [PATCH v2] linux-user: detect mismatched ELF ABI in qemu-mips[n32][el]

2020-08-24 Thread Laurent Vivier
Le 23/08/2020 à 12:17, Carlo Marcelo Arenas Belón a écrit : > MIPS provides 2 ILP32 ABIs, and therefore 4 possible qemu-mips binaries > with 2 pairs using the same endianess and bitness. > > This could lead to an O32 image loading in the N32 binary or vice versa > and in cryptic errors (if lucky t

msys2/mingw meson building fixes

2020-08-24 Thread Yonggang Luo
I've create a pull request for fixes python ninja detection and usage on msys2/mingw at https://github.com/mesonbuild/meson/pull/7637 -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v2 3/3] linux-user: Add strace support for printing arguments for ioctls used for terminals and serial lines

2020-08-24 Thread Laurent Vivier
Le 23/07/2020 à 23:02, Filip Bozuta a écrit : > Functions "print_ioctl()" and "print_syscall_ret_ioctl()" are used > to print arguments of "ioctl()" with "-strace". These functions > use "thunk_print()", which is defined in "thunk.c", to print the > contents of ioctl's third arguments that are not

Re: [PATCH v4 4/5] linux-user: Add an api to print enumareted argument values with strace

2020-08-24 Thread Laurent Vivier
Le 11/08/2020 à 18:45, Filip Bozuta a écrit : > This patch introduces a type 'struct enums' and function 'print_enums()' > that can be used to print enumerated argument values of some syscalls > in strace. This can be used in future strace implementations. > > Also, macros 'ENUM_GENERIC()', 'ENUM_

Re: [PATCH v4 3/5] linux-user: Add strace support for printing arguments of syscalls used to lock and unlock memory

2020-08-24 Thread Laurent Vivier
Le 11/08/2020 à 18:45, Filip Bozuta a écrit : > This patch implements strace argument printing functionality for following > syscalls: > > * mlock, munlock, mlockall, munlockall - lock and unlock memory > >int mlock(const void *addr, size_t len) >int munlock(const void *addr,

Re: [PATCH v4 2/5] linux-user: Add strace support for printing arguments of truncate()/ftruncate() and getsid()

2020-08-24 Thread Laurent Vivier
Le 11/08/2020 à 18:45, Filip Bozuta a écrit : > This patch implements strace argument printing functionality for following > syscalls: > > * truncate, ftruncate - truncate a file to a specified length > > int truncate/truncate64(const char *path, off_t length) > int ftruncate

Re: [PATCH v4 1/5] linux-user: Make cpu_env accessible in strace.c

2020-08-24 Thread Laurent Vivier
Le 11/08/2020 à 18:45, Filip Bozuta a écrit : > Variable "cpu_env" is used in file "syscall.c" to store > the information about the cpu environment. This variable > is used because values of some syscalls can vary between > cpu architectures. This patch makes the "cpu_env" accessible > in "strace.c

Re: [PATCH v2 2/3] linux-user: Add missing termbits types and values definitions

2020-08-24 Thread Laurent Vivier
Le 23/07/2020 à 23:02, Filip Bozuta a écrit : > This patch introduces missing target types ('target_flag_t', 'target_cc_t', > 'target_speed_t') in a few 'termibts.h' header files. Also, two missing > values ('TARGET_IUTF8' and 'TARGET_EXTPROC') were also added. These values > were also added in fil

Re: [PATCH v2 1/3] linux-user: Add generic 'termbits.h' for some archs

2020-08-24 Thread Laurent Vivier
Le 23/07/2020 à 23:02, Filip Bozuta a écrit : > This patch introduces a generic 'termbits.h' file for following > archs: 'aarch64', 'arm', 'i386, 'm68k', 'microblaze', 'nios2', > 'openrisc', 'riscv', 's390x', 'x86_64'. > > Since all of these archs have the same termios flag values and > same ioctl

Re: [PATCH v2] linux-user: syscall: ioctls: support DRM_IOCTL_I915_GETPARAM

2020-08-24 Thread Laurent Vivier
Le 02/08/2020 à 15:39, cheng...@emindsoft.com.cn a écrit : > From: Chen Gang > > Another DRM_IOCTL_I915 patches will be sent next. > > Signed-off-by: Chen Gang > --- > linux-user/ioctls.h| 3 +++ > linux-user/syscall.c | 35 +++ > linux-user/sysca

Re: [PATCH] linux-user: Fix 'clock_nanosleep()' implementation

2020-08-24 Thread Laurent Vivier
Le 27/07/2020 à 22:13, Filip Bozuta a écrit : > Implementation of syscall 'clock_nanosleep()' in 'syscall.c' uses > functions 'target_to_host_timespec()' and 'host_to_target_timespec()' > to transfer the value of 'struct timespec' between target and host. > However, the implementation doesn't check

  1   2   3   4   >