David Gibson <da...@gibson.dropbear.id.au> writes:
> On Sat, Aug 22, 2020 at 10:59:56AM +0200, Cédric Le Goater wrote: >> Hello, >> >> On 8/19/20 6:43 PM, Thiago Jung Bauermann wrote: >> > Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use >> > the start-powered-off property which makes cpu_common_reset() initialize it >> > to 1 in common code. >> > >> > Also change creation of CPU object from cpu_create() to object_new() and >> > qdev_realize_and_unref() because cpu_create() realizes the CPU and it's not >> > possible to set a property after the object is realized. >> > >> > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> > Signed-off-by: Thiago Jung Bauermann <bauer...@linux.ibm.com> >> >> >> This is breaking make check : >> >> tests/qtest/libqtest.c:175: kill_qemu() detected QEMU death from signal >> 11 (Segmentation fault) (core dumped) >> ERROR boot-serial-test - too few tests run (expected 7, got 0) >> make: *** >> [/home/legoater/work/qemu/qemu-powernv-5.2.git/tests/Makefile.include:650: >> check-qtest-ppc64] Error 1 >> make: *** Waiting for unfinished jobs.... >> >> >> gdb --args build/ppc64-softmmu/qemu-system-ppc64 -display none -M >> ppce500 >> ... >> Thread 1 "qemu-system-ppc" received signal SIGSEGV, Segmentation fault. >> 0x000055555596ebf2 in ppce500_init (machine=0x5555567aa6e0) >> at /home/legoater/work/qemu/qemu-powernv-5.2.git/hw/ppc/e500.c:880 >> 880 irqs[i].irq[OPENPIC_OUTPUT_INT] = >> input[PPCE500_INPUT_INT]; >> >> >> AFAIUI, 'input is not initialized since the CPU is not yet >> realized. > > Sigh. For future reference, Thiago, running an all-targets make check > is pretty much a minimum bar to test before posting. Sorry for the breakage. I'm working on it. -- Thiago Jung Bauermann IBM Linux Technology Center
