Re: [PATCH v2] .mailmap: Update Paul Burton email address

2020-08-08 Thread Paul Burton
Hi Philippe, On Thu, Aug 6, 2020 at 6:50 AM Philippe Mathieu-Daudé wrote: > ping, as I'm still receiving "The recipient email address is > incorrect or does not exist in this domain." from wavecomp.com... > > On 7/16/20 8:56 AM, Philippe Mathieu-Daudé wrote: > > Hi Paul, > > > > Do you mind Ackin

[PATCH v4 08/12] Revert "hw/display/artist: Avoid drawing line when nothing to display"

2020-08-08 Thread Helge Deller
This reverts commit b0f6455feac97e41045ee394e11c24d92c370f6e. It's wrong. A line could even be a dot. Signed-off-by: Helge Deller --- hw/display/artist.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index 47de17b9e9..f37aa9eb49 100644 --- a/hw/d

[PATCH v4 05/12] hw/hppa/lasi: Don't abort on invalid IMR value

2020-08-08 Thread Helge Deller
NetBSD initializes the LASI IMR value with 0x to disable all LASI interrupts. This triggered an assert() and stopped the emulation. By replacing the check with a warning in the guest log we now allow NetBSD to boot again. Signed-off-by: Helge Deller --- hw/hppa/lasi.c | 7 +-- 1 fil

[PATCH v4 12/12] hw/display/artist: Fix invalidation of lines near screen border

2020-08-08 Thread Helge Deller
From: Sven Schnelle If parts of the invalidated screen lines are outside of the VRAM buffer, the code skips the whole invalidate. This is incorrect when only parts of the buffer are invisble - which is the case when the mouse cursor is located near the screen border. Signed-off-by: Sven Schnelle

[PATCH v4 11/12] hw/display/artist: Fix invalidation of lines in artist_draw_line()

2020-08-08 Thread Helge Deller
From: Sven Schnelle The old code didn't invalidate correctly when vertical lines were drawn. Fix this and move the invalidation out of the loop. Signed-off-by: Sven Schnelle Signed-off-by: Helge Deller --- hw/display/artist.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --g

[PATCH v4 09/12] hw/display/artist: Prevent out of VRAM buffer accesses

2020-08-08 Thread Helge Deller
Simplify various bounds checks by changing parameters like row and column numbers to become unsigned instead of signed. With that we can check if the calculated offset is bigger than the size of the VRAM region and bail out if not. Reported-by: LLVM libFuzzer Reported-by: Alexander Bulekov Buglin

[PATCH v4 10/12] hw/display/artist: Unbreak size mismatch memory accesses

2020-08-08 Thread Helge Deller
Commit 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid") broke the artist driver in a way that the dtwm window manager on HP-UX rendered wrong. Fixes: 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid") Sign

[PATCH v4 04/12] hw/display/artist.c: fix out of bounds check

2020-08-08 Thread Helge Deller
From: Sven Schnelle Fix the following runtime warning with artist framebuffer: "write outside bounds: wants 1256x1023, max size 1280x1024" Reviewed-by: Richard Henderson Signed-off-by: Sven Schnelle Signed-off-by: Helge Deller --- hw/display/artist.c | 24 +++- 1 file cha

[PATCH v4 06/12] hw/display/artist: Check offset in draw_line to avoid buffer over-run

2020-08-08 Thread Helge Deller
From: Philippe Mathieu-Daudé Invalid I/O writes can craft an offset out of the vram_buffer range. We avoid: Program terminated with signal SIGSEGV, Segmentation fault. 284 *dst &= ~plane_mask; (gdb) bt #0 0x55d5dccdc5c0 in artist_rop8 (s=0x55d5defee510, dst=0x7f8e84ed82

[PATCH v4 07/12] hw/display/artist: Refactor artist_rop8() to avoid buffer over-run

2020-08-08 Thread Helge Deller
From: Philippe Mathieu-Daudé Invalid I/O writes can craft an offset out of the vram_buffer range. Instead of passing an unsafe pointer to artist_rop8(), pass the vram_buffer and the offset. We can now check if the offset is in range before accessing it. We avoid: Program terminated with signa

[PATCH v4 01/12] hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources

2020-08-08 Thread Helge Deller
The hppa_hardware.h file is shared with SeaBIOS. Sync it. Acked-by: Richard Henderson Signed-off-by: Helge Deller --- hw/hppa/hppa_hardware.h | 6 ++ hw/hppa/lasi.c | 2 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/hppa/hppa_hardware.h b/hw/hppa/hppa_hardwar

[PATCH v4 03/12] hw/hppa: Implement proper SeaBIOS version check

2020-08-08 Thread Helge Deller
It's important that the SeaBIOS hppa firmware is at least at a minimal level to ensure proper interaction between qemu and firmware. Implement a proper firmware version check by telling SeaBIOS via the fw_cfg interface which minimal SeaBIOS version is required by this running qemu instance. If the

[PATCH v4 00/12] target-hppa fixes v4

2020-08-08 Thread Helge Deller
A few late fixes for target-hppa: * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian * Fix the SeaBIOS-hppa firmware to boot NetBSD again * Fix many artist framebuffer out-of-bounds accesses as found by Alexander Bulekov * Fix artist memory access bugs due to commit 5d971f9e6725 ("mem

Re: [PATCH v3 7/8] hw/display/artist: Refactor artist_rop8() to avoid buffer over-run

2020-08-08 Thread Helge Deller
Hello Alexander, On 06.08.20 17:46, Alexander Bulekov wrote: > On 200805 2244, Helge Deller wrote: >> * Alexander Bulekov : >>> On 200804 2320, Helge Deller wrote: * Alexander Bulekov : > I applied this series and it fixes most of the problems I saw before. > I still see a few crashes

Re: [PATCH 2/4] qom: provide convenient macros for declaring and defining types

2020-08-08 Thread Eduardo Habkost
There are implicit requirements in the macros that will be a problem in some existing type definitions: On Thu, Jul 23, 2020 at 07:14:08PM +0100, Daniel P. Berrangé wrote: [...] > +/** > + * OBJECT_DECLARE_TYPE: > + * @ModuleObjName: the object name with initial capitalization > + * @module_obj_n

Re: [PATCH v2 5/7] target/riscv: Check nanboxed inputs in trans_rvf.inc.c

2020-08-08 Thread LIU Zhiwei
On 2020/8/8 22:18, LIU Zhiwei wrote: On 2020/8/8 4:24, Chih-Min Chao wrote: On Fri, Jul 24, 2020 at 8:28 AM Richard Henderson mailto:richard.hender...@linaro.org>> wrote: If a 32-bit input is not properly nanboxed, then the input is replaced with the default qnan.  The only in

Re: usb-wacom-tablet failing to register

2020-08-08 Thread Michael Nazzareno Trimarchi
Hi On Sat, Aug 8, 2020 at 6:06 PM Michael Nazzareno Trimarchi wrote: > > Hi Markus > > I have seen that you are a committer there so what I have seen that > > This request is not implement > switch (request) { > case InterfaceRequest | USB_REQ_GET_DESCRIPTOR: > > When linux probe it fail her

Re: usb-wacom-tablet failing to register

2020-08-08 Thread Michael Nazzareno Trimarchi
Hi Markus I have seen that you are a committer there so what I have seen that This request is not implement switch (request) { case InterfaceRequest | USB_REQ_GET_DESCRIPTOR: When linux probe it fail here ret = hid_get_class_descriptor(dev, interface->desc.bInterfaceNumber, >

Re: [PATCH 1/1] os_find_datadir: search as in version 4.2

2020-08-08 Thread Peter Maydell
On Sat, 8 Aug 2020 at 02:35, Brian Norris wrote: > > Hello! > > On Wed, Jul 15, 2020 at 11:57:14PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Wed, Jul 15, 2020 at 11:37 PM Peter Maydell > > wrote: > > > > > > On Tue, 16 Jun 2020 at 10:19, Peter Maydell > > > wrote: > > > > > > > > On Tu

Re: usb-wacom-tablet failing to register

2020-08-08 Thread Michael Nazzareno Trimarchi
Hi What I have seen is that the parse fail to execute hid ll_driver parse fai for ret = hid_get_class_descriptor(dev, interface->desc.bInterfaceNumber, HID_DT_REPORT, rdesc, rsize); Now this is not implemented in hw/dev-wacom.c . What am I missing? #!/bin/sh IMAGE_DIR="

Re: [PATCH v2 5/7] target/riscv: Check nanboxed inputs in trans_rvf.inc.c

2020-08-08 Thread LIU Zhiwei
On 2020/8/8 4:24, Chih-Min Chao wrote: On Fri, Jul 24, 2020 at 8:28 AM Richard Henderson mailto:richard.hender...@linaro.org>> wrote: If a 32-bit input is not properly nanboxed, then the input is replaced with the default qnan.  The only inline expansion is for the sign-changing

[PATCH 4/4] Add a config option for ePMP.

2020-08-08 Thread Hongzheng-Li
From: Hou Weiying Add a config option to enable experimental support for ePMP. This is disabled by default and can be enabled with 'x-epmp=true'. Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/cpu.c | 9 + target/riscv/cpu.h | 3

[PATCH] riscv: Fix bug in setting pmpcfg CSR for RISCV64

2020-08-08 Thread Hou Weiying
First, sizeof(target_ulong) equals to 4 on riscv32, so this change does not change the function on riscv32. Second, sizeof(target_ulong) equals to 8 on riscv64, and 'reg_index * 8 + i' is not a legal pmp_index (we will explain later), which should be 'reg_index * 4 + i'. If the parameter reg_index

[PATCH 2/4] Implementation of enhanced PMP(ePMP) support

2020-08-08 Thread Hongzheng-Li
From: Hou Weiying The ePMP can be found in: https://docs.google.com/document/d/1Mh_aiHYxemL0umN3GTTw8vsbmzHZ_nxZXgjgOUzbvc8/edit#heading=h.9wsr1lnxtwe2 Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/pmp.c| 134 +++

[PATCH] riscv: Fix bug in setting pmpcfg CSR for RISCV64

2020-08-08 Thread Hou Weiying
First, sizeof(target_ulong) equals to 4 on riscv32, so this change does not change the function on riscv32. Second, sizeof(target_ulong) equals to 8 on riscv64, and 'reg_index * 8 + i' is not a legal pmp_index (we will explain later), which should be 'reg_index * 4 + i'. If the parameter reg_index

[PATCH 1/4] Define ePMP mseccfg

2020-08-08 Thread Hou Weiying
Currently using 0x390 and 0x391 for x-epmp (experimental). This may change in the future spec. Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/cpu_bits.h | 3 +++ target/riscv/gdbstub.c | 2 ++ 2 files changed, 5 insertions(+) diff --git

[PATCH 1/4] Define ePMP mseccfg

2020-08-08 Thread Hongzheng-Li
From: Hou Weiying Currently using 0x390 and 0x391 for x-epmp (experimental). This may change in the future spec. Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/cpu_bits.h | 3 +++ target/riscv/gdbstub.c | 2 ++ 2 files changed, 5 inser

[PATCH 1/4] Define ePMP mseccfg

2020-08-08 Thread Hou Weiying
Currently using 0x390 and 0x391 for x-epmp (experimental). This may change in the future spec. Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/cpu_bits.h | 3 +++ target/riscv/gdbstub.c | 2 ++ 2 files changed, 5 insertions(+) diff --git

Re: [PATCH 1/1] os_find_datadir: search as in version 4.2

2020-08-08 Thread Brian Norris
Hello! On Wed, Jul 15, 2020 at 11:57:14PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Jul 15, 2020 at 11:37 PM Peter Maydell > wrote: > > > > On Tue, 16 Jun 2020 at 10:19, Peter Maydell > > wrote: > > > > > > On Tue, 16 Jun 2020 at 00:00, Joe Slater wrote: > > > > > > > > Always look fo

[PATCH 3/4] Add ePMP CSR accesses

2020-08-08 Thread Hongzheng-Li
From: Hou Weiying Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/csr.c | 18 ++ target/riscv/pmp.c | 40 2 files changed, 58 insertions(+) diff --git a/target/riscv/csr.c b/target/

[PATCH 3/4] Add ePMP CSR accesses

2020-08-08 Thread Hou Weiying
Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/csr.c | 18 ++ target/riscv/pmp.c | 40 2 files changed, 58 insertions(+) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 11

[PATCH 2/4] Implementation of enhanced PMP(ePMP) support

2020-08-08 Thread Hou Weiying
The ePMP can be found in: https://docs.google.com/document/d/1Mh_aiHYxemL0umN3GTTw8vsbmzHZ_nxZXgjgOUzbvc8/edit#heading=h.9wsr1lnxtwe2 Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/pmp.c| 134 ++

[PATCH 4/4] Add a config option for ePMP.

2020-08-08 Thread Hou Weiying
Add a config option to enable experimental support for ePMP. This is disabled by default and can be enabled with 'x-epmp=true'. Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/cpu.c | 9 + target/riscv/cpu.h | 3 +++ 2 files changed

[PATCH 0/4] riscv: Add enhanced PMP support

2020-08-08 Thread Hou Weiying
The ePMP can be found in: https://docs.google.com/document/d/1Mh_aiHYxemL0umN3GTTw8vsbmzHZ_nxZXgjgOUzbvc8/edit#heading=h.9wsr1lnxtwe2 Hou Weiying (4): Define ePMP mseccfg Implementation of enhanced PMP(ePMP) support Add ePMP CSR accesses Add a config option for ePMP. target/riscv/cpu.c

[PATCH 0/4] riscv: Add enhanced PMP support

2020-08-08 Thread Hongzheng-Li
From: Hou Weiying The ePMP can be found in: https://docs.google.com/document/d/1Mh_aiHYxemL0umN3GTTw8vsbmzHZ_nxZXgjgOUzbvc8/edit#heading=h.9wsr1lnxtwe2 Hou Weiying (4): Define ePMP mseccfg Implementation of enhanced PMP(ePMP) support Add ePMP CSR accesses Add a config option for ePMP.

[PATCH 0/4] riscv: Add enhanced PMP support

2020-08-08 Thread Hou Weiying
The ePMP can be found in: https://docs.google.com/document/d/1Mh_aiHYxemL0umN3GTTw8vsbmzHZ_nxZXgjgOUzbvc8/edit#heading=h.9wsr1lnxtwe2 Hou Weiying (4): Define ePMP mseccfg Implementation of enhanced PMP(ePMP) support Add ePMP CSR accesses Add a config option for ePMP. target/riscv/cpu.c

[PATCH 3/4] Add ePMP CSR accesses

2020-08-08 Thread Hou Weiying
Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/csr.c | 18 ++ target/riscv/pmp.c | 40 2 files changed, 58 insertions(+) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 11

[PATCH 2/4] Implementation of enhanced PMP(ePMP) support

2020-08-08 Thread Hou Weiying
The ePMP can be found in: https://docs.google.com/document/d/1Mh_aiHYxemL0umN3GTTw8vsbmzHZ_nxZXgjgOUzbvc8/edit#heading=h.9wsr1lnxtwe2 Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/pmp.c| 134 ++

[PATCH 4/4] Add a config option for ePMP.

2020-08-08 Thread Hou Weiying
Add a config option to enable experimental support for ePMP. This is disabled by default and can be enabled with 'x-epmp=true'. Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/cpu.c | 9 + target/riscv/cpu.h | 3 +++ 2 files changed

[Bug 812398] Re: powerpc 7450 MMU initialization broken

2020-08-08 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/812398 Title: powerpc 7450 MMU initialization broken Status in QEMU: Triaged Bug descripti

[Bug 811683] Re: 7400, 7410, 7450 cpus vector have wrong exception prefix at reset

2020-08-08 Thread Thomas Huth
Ok, thanks for checking! I'll keep the bug open, though, in case someone wants to have a look at the segfault with the "none" machine. ** Changed in: qemu Status: Incomplete => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Bug 811683] Re: 7400, 7410, 7450 cpus vector have wrong exception prefix at reset

2020-08-08 Thread BALATON Zoltan
Please don't close ticket if there's a known problem just to at least document there's a problem. Is this a CPU feature or board specific? Doesn't these CPUs have some way to select the exception vectors base and could that be set wrong? I've also seen some problems with these CPUs but last ti

Re: [PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

2020-08-08 Thread Paolo Bonzini
On 08/08/20 00:18, Robert Foley wrote: > 2) Another perhaps cleaner option is to add a new cpu class function > ->do_interrupt_locked. >This lets callers like *_cpu_exec_interrupt call to ->do_interrupt_locked >with lock held and solves the issue without resorting to conditional > locking.

[Bug 811683] Re: 7400, 7410, 7450 cpus vector have wrong exception prefix at reset

2020-08-08 Thread till
I no longer have the test readily available. So I tried to print the initial MSR and IP register contents from the QEMU monitor: qemu-system-ppc -machine none -cpu 7400 -S -monitor stdio QEMU 5.0.93 monitor - type 'help' for more information (qemu) info registers NIP LR CTR 000

[Bug 812398] Re: powerpc 7450 MMU initialization broken

2020-08-08 Thread till
>From looking at the source code of 5.1.0-rc3 (target/ppc/translate_init.inc.c) it seems that this is still an issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/812398 Title: powerpc 7450 MMU in

Re: [PATCH v3 for-5.2 2/3] ppc/xive: Introduce dedicated kvm_irqchip_in_kernel() wrappers

2020-08-08 Thread Cédric Le Goater
Some more comments, because I still think there are some shortcuts. My feeling is that all the kvmppc_xive* could be part of a QOM interface defining how to use a kernel device backend. When the kernel IRQ device is not available, under TCG or under an hypervisor not advertising support at the K

[Bug 1667613] Re: Qemu 2.8 on PPC64 issue with input

2020-08-08 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. h

[Bug 584146] Re: Virtual fat breaks with -snapshot

2020-08-08 Thread Thomas Huth
** Changed in: qemu-kvm (Debian) Importance: Unknown => Undecided ** Changed in: qemu-kvm (Debian) Status: Confirmed => New ** Changed in: qemu-kvm (Debian) Remote watch: Debian Bug tracker #504049 => None ** Package changed: qemu-kvm (Debian) => qemu-kvm ** Changed in: qemu-kvm

[Bug 1860610] Re: cap_disas_plugin leaks memory

2020-08-08 Thread Thomas Huth
** Changed in: qemu Assignee: Alex Bennée (ajbennee) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1860610 Title: cap_disas_plugin leaks memory Status in QEMU: Incomplete B

[Bug 1869073] Re: qemu-arm-static crashes "segmentation fault" when running "git clone -s"

2020-08-08 Thread Thomas Huth
Let's assume that this is fixed. Please open a new bug if it happens again. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1869073 Title:

[Bug 1423528] Re: setting unsupported timeout for i6300esb watchdog causes hw reset

2020-08-08 Thread Michael Tokarev
** Changed in: qemu Status: Incomplete => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1423528 Title: setting unsupported timeout for i6300esb watchdog causes hw reset Status in

[Bug 1415181] Re: Access raw partitions from Windows

2020-08-08 Thread Thomas Huth
Ok, thanks for your answer! Apparently no developer looked into this during the past 5 years, so it likely won't happen in the future, and since you don't need it anymore, let's simply close this ticket. ** Changed in: qemu Status: Incomplete => Won't Fix -- You received this bug notifica

[Bug 1500265] Re: nested 9p filesystem with security_model=mapped-xattr

2020-08-08 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1500265 Title: nested 9p filesystem with security_model=mapped-xattr Status in QEMU: Triage

[Bug 1503031] Re: 32-to-64-bit call gate unsupported in IA32e mode

2020-08-08 Thread Thomas Huth
That looks like the corresponding fix, indeed. Let's close this ticket. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1503031 Title: 3

[Bug 1423528] Re: setting unsupported timeout for i6300esb watchdog causes hw reset

2020-08-08 Thread Michael Tokarev
There's nothing changed in i6300esb about this issue. I can reproduce it exactly the same way with current qemu 5.1-tobe -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1423528 Title: setting unsupp