[Bug 1873032] Re: After upgrade qemu to 5.0.0-0.3.rc2.fc33 the virtual machine with Windows 10 after a while starts to work very slowly

2020-05-12 Thread Mikhail Gavrilov
I confirm that with patches https://lists.gnu.org/archive/html/qemu- devel/2020-05/msg02728.html Win 10 in QEMU working already more than 24 hours without issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.n

Re: [PATCH v2 5/5] vhost: add device started check in migration set log

2020-05-12 Thread Jason Wang
On 2020/5/13 下午12:15, Michael S. Tsirkin wrote: On Tue, May 12, 2020 at 12:35:30PM +0300, Dima Stepanov wrote: On Tue, May 12, 2020 at 11:32:50AM +0800, Jason Wang wrote: On 2020/5/11 下午5:25, Dima Stepanov wrote: On Mon, May 11, 2020 at 11:15:53AM +0800, Jason Wang wrote: On 2020/4/30 下午9:3

RE: [PATCH v5 08/12] net: cadence_gem: Add support for jumbo frames

2020-05-12 Thread Sai Pavan Boddu
Thanks for review edgar! Regards, Sai pavan > -Original Message- > From: Edgar E. Iglesias > Sent: Tuesday, May 12, 2020 8:50 PM > To: Sai Pavan Boddu > Cc: Alistair Francis ; Peter Maydell > ; Jason Wang ; Markus > Armbruster ; Philippe Mathieu-Daudé > ; Tong Ho ; Ramon Fried > ; qemu-

[Bug 1657538] Re: qemu 2.7.x 2.8 softmmu dont work on BE machine

2020-05-12 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1657538 Title: qemu 2.7.x

Re: [PATCH v2 5/5] vhost: add device started check in migration set log

2020-05-12 Thread Michael S. Tsirkin
On Tue, May 12, 2020 at 12:35:30PM +0300, Dima Stepanov wrote: > On Tue, May 12, 2020 at 11:32:50AM +0800, Jason Wang wrote: > > > > On 2020/5/11 下午5:25, Dima Stepanov wrote: > > >On Mon, May 11, 2020 at 11:15:53AM +0800, Jason Wang wrote: > > >>On 2020/4/30 下午9:36, Dima Stepanov wrote: > > >>>If

[PATCH qemu v9] spapr: Implement Open Firmware client interface

2020-05-12 Thread Alexey Kardashevskiy
The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of the firmware (RTAS) has been implemented as a 2

[PATCH] qom/container: remove .instance_size initializer from container_info

2020-05-12 Thread Masahiro Yamada
You can omit .instance_size if it is the same as that of the parent. .class_size = sizeof(ObjectClass) ... is omitted here, so removing .instance_size is more consistent. Signed-off-by: Masahiro Yamada --- qom/container.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qom/container.c

Re: [PATCH v2 5/5] vhost: add device started check in migration set log

2020-05-12 Thread Jason Wang
On 2020/5/12 下午5:35, Dima Stepanov wrote: On Tue, May 12, 2020 at 11:32:50AM +0800, Jason Wang wrote: On 2020/5/11 下午5:25, Dima Stepanov wrote: On Mon, May 11, 2020 at 11:15:53AM +0800, Jason Wang wrote: On 2020/4/30 下午9:36, Dima Stepanov wrote: If vhost-user daemon is used as a backend for

[Bug 1878323] [NEW] Assertion-failure in usb_detach

2020-05-12 Thread Alexander Bulekov
Public bug reported: Hello, While fuzzing, I found an input that triggers an assertion-failure in usb_detach /home/alxndr/Development/qemu/hw/usb/core.c:69: void usb_detach(USBPort *): Assertion `dev->state != USB_STATE_NOTATTACHED' failed. #3 0x76866092 in __GI___assert_fail (assertion

Re: [PATCH v2 4/5] vhost: check vring address before calling unmap

2020-05-12 Thread Jason Wang
On 2020/5/12 下午5:08, Dima Stepanov wrote: On Tue, May 12, 2020 at 11:26:11AM +0800, Jason Wang wrote: On 2020/5/11 下午5:11, Dima Stepanov wrote: On Mon, May 11, 2020 at 11:05:58AM +0800, Jason Wang wrote: On 2020/4/30 下午9:36, Dima Stepanov wrote: Since disconnect can happen at any time durin

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

2020-05-12 Thread Alexey Kardashevskiy
The following changes since commit 83b700a441ef8303983eed16c244adde8e40e808: target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate() (2020-05-11 11:44:03 +1000) are available in the Git repository at: g...@github.com:aik/qemu.git tags/qemu-slof-20200513 for you to fetch changes u

Re: [RFC PATCH 0/3] hw/net/tulip: Fix LP#1874539

2020-05-12 Thread Jason Wang
On 2020/5/12 下午3:13, Philippe Mathieu-Daudé wrote: Hi Jason, On 4/27/20 5:32 AM, Jason Wang wrote: On 2020/4/26 下午3:57, Peter Maydell wrote: On Sun, 26 Apr 2020 at 03:50, Jason Wang  wrote: Looks good to me. Would you please send a formal patch and cc Peter. Consider we are about to rele

[Bug 1525123] Re: USB assert failure on hcd-uhci.c

2020-05-12 Thread Alexander Bulekov
Hello, While fuzzing, I found an input that triggers this assertion-failure in usb_ep_get /home/alxndr/Development/qemu/hw/usb/core.c:723: struct USBEndpoint *usb_ep_get(USBDevice *, int, int): Assertion `pid == USB_TOKEN_IN || pid == USB_TOKEN_OUT' failed. #3 0x76866092 in __GI___asse

Re: [PATCH v3 02/16] target/arm: Create gen_gvec_{u,s}{rshr,rsra}

2020-05-12 Thread Richard Henderson
On 5/12/20 6:51 AM, Peter Maydell wrote: >> +tcg_gen_gvec_dup_imm(vece, rd_ofs, opr_sz, max_sz, 0); > > Knew I'd forgotten a review comment -- should this "dup_imm to clear > to zeroes" be using a fixed element size rather than 'vece' to avoid > the "dup_imm doesn't handle 128 bits" issue?

Re: [PATCH v3 02/16] target/arm: Create gen_gvec_{u,s}{rshr,rsra}

2020-05-12 Thread Richard Henderson
On 5/12/20 6:46 AM, Peter Maydell wrote: > +void gen_gvec_srshr(unsigned vece, uint32_t rd_ofs, uint32_t rm_ofs, > +int64_t shift, uint32_t opr_sz, uint32_t max_sz) > +{ > +static const TCGOpcode vecop_list[] = { > +INDEX_op_shri_vec, INDEX_op_sari_vec, INDEX_op_add_

[PATCH v4 7/9] qcow2: Expose bitmaps' size during measure

2020-05-12 Thread Eric Blake
It's useful to know how much space can be occupied by qcow2 persistent bitmaps, even though such metadata is unrelated to the guest-visible data. Report this value as an additional QMP field, present when measuring an existing image and output format that both support bitmaps. Update iotest 178 a

[PATCH v4 4/9] blockdev: Promote several bitmap functions to non-static

2020-05-12 Thread Eric Blake
The next patch will split blockdev.c, which will require accessing some previously-static functions from more than one .c file. But part of promoting a function to public is picking a naming scheme that does not reek of exposing too many internals (two of the three functions were named starting wi

[PATCH v4 5/9] blockdev: Split off basic bitmap operations for qemu-img

2020-05-12 Thread Eric Blake
Upcoming patches want to add some basic bitmap manipulation abilities to qemu-img. But blockdev.o is too heavyweight to link into qemu-img (among other things, it would drag in block jobs and transaction support - qemu-img does offline manipulation, where atomicity is less important because there

[PATCH v4 8/9] qemu-img: Add convert --bitmaps option

2020-05-12 Thread Eric Blake
Make it easier to copy all the persistent bitmaps of (the top layer of) a source image along with its guest-visible contents, by adding a boolean flag for use with qemu-img convert. This is basically shorthand, as the same effect could be accomplished with a series of 'qemu-img bitmap --add' and '

[PATCH v4 3/9] block: Make it easier to learn which BDS support bitmaps

2020-05-12 Thread Eric Blake
Upcoming patches will enhance bitmap support in qemu-img, but in doing so, it turns out to be nice to suppress output when persistent bitmaps make no sense (such as on a qcow2 v2 image). Add a hook to make this easier to query. This patch adds a new callback .bdrv_supports_persistent_dirty_bitmap

[PATCH v4 9/9] iotests: Add test 291 to for qemu-img bitmap coverage

2020-05-12 Thread Eric Blake
Add a new test covering the 'qemu-img bitmap' subcommand, as well as 'qemu-img convert --bitmaps', both added in recent patches. Signed-off-by: Eric Blake Reviewed-by: Max Reitz --- tests/qemu-iotests/291 | 112 + tests/qemu-iotests/291.out | 78

[PATCH v4 1/9] docs: Sort sections on qemu-img subcommand parameters

2020-05-12 Thread Eric Blake
We already list the subcommand summaries alphabetically, we should do the same for the documentation related to subcommand-specific parameters. Signed-off-by: Eric Blake Reviewed-by: Max Reitz --- docs/tools/qemu-img.rst | 48 - 1 file changed, 24 inserti

[PATCH v4 0/9] qemu-img: Add convert --bitmaps

2020-05-12 Thread Eric Blake
v3 was here: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg02139.html original cover letter here: https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg03464.html Since then: - add R-b where appropriate - patch 3: rename new driver hook [Max] - patch 6: typo and grammar fix [Max] - p

[PATCH v4 6/9] qemu-img: Add bitmap sub-command

2020-05-12 Thread Eric Blake
Include actions for --add, --remove, --clear, --enable, --disable, and --merge (note that --clear is a bit of fluff, because the same can be accomplished by removing a bitmap and then adding a new one in its place, but it matches what QMP commands exist). Listing is omitted, because it does not re

[PATCH v4 2/9] qemu-img: Fix stale comments on doc location

2020-05-12 Thread Eric Blake
Missed in commit e13c59fa. Signed-off-by: Eric Blake Reviewed-by: Max Reitz --- qemu-img.c | 2 +- qemu-img-cmds.hx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 6a4327aaba56..b6e8af9202a5 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -

Re: [PATCH for QEMU v2] hw/vfio: Add VMD Passthrough Quirk

2020-05-12 Thread Derrick, Jonathan
Hi Alex, I'm probably not getting the translation technical details correct. On Mon, 2020-05-11 at 16:59 -0600, Alex Williamson wrote: > On Mon, 11 May 2020 15:01:27 -0400 > Jon Derrick wrote: > > > The VMD endpoint provides a real PCIe domain to the guest, including > > Please define VMD. I'

Re: [PATCH v4 00/15] Apply COR-filter to the block-stream permanently

2020-05-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1589302245-893269-1-git-send-email-andrey.shinkev...@virtuozzo.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. =

Re: [PATCH v4 00/15] Apply COR-filter to the block-stream permanently

2020-05-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1589302245-893269-1-git-send-email-andrey.shinkev...@virtuozzo.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT B

Re: [PATCH v4 00/15] Apply COR-filter to the block-stream permanently

2020-05-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1589302245-893269-1-git-send-email-andrey.shinkev...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally.

Re: [PATCH v2 00/17] target/arm: Convert rest of Neon 3-reg-same to decodetree

2020-05-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200512163904.10918-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200512163904.10918-1-peter.mayd...@linaro.org Subject: [PATCH v2 00/17] target/arm: Convert res

Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size

2020-05-12 Thread Stefano Stabellini
On Tue, 12 May 2020, Christian Schoenebeck wrote: > On Dienstag, 12. Mai 2020 00:09:46 CEST Stefano Stabellini wrote: > > On Sun, 10 May 2020, Christian Schoenebeck wrote: > > > Commit SHA-1 16724a173049ac29c7b5ade741da93a0f46edff7 introduced > > > truncating the response to the currently available

[Bug 1877794] Re: Constant Folding on 64-bit Subtraction causes SIGILL on linux-user glxgears ppc64le to x86_64 by way of generating bad shift instruction with c=-1

2020-05-12 Thread Catherine A. Frederick
I'm marking this invalid and moving on because it isn't replicable on upstream due to the lack of DRM support and because I'll probably just figure it out myself. (if anyone has somewhere better than tcg/README.md to learn TCG implementation details, I would appreciate it. ** Changed in: qemu

[Bug 1872644] Re: MacOS host qemu-system-x86_64 -cpu host not working

2020-05-12 Thread Roman Bolshakov
** Tags added: hvf -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1872644 Title: MacOS host qemu-system-x86_64 -cpu host not working Status in QEMU: New Bug description: MacOS: 10.15.4 uname

[Bug 1844946] Re: macOS HVF broken with WinXP after Aug 21 2018 92d5f1a414

2020-05-12 Thread Roman Bolshakov
*** This bug is a duplicate of bug 1823831 *** https://bugs.launchpad.net/bugs/1823831 ** Tags added: hvf ** Changed in: qemu Status: New => Fix Released ** This bug has been marked a duplicate of bug 1823831 BSD bootloader halts with hypervisor.framework -- You received this bug

[Bug 1823831] Re: BSD bootloader halts with hypervisor.framework

2020-05-12 Thread Roman Bolshakov
** Changed in: qemu Assignee: (unassigned) => Roman Bolshakov (roolebo) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1823831 Title: BSD bootloader halts with hypervisor.framework Status in Q

Re: QEMU + HVF Fails to start OVMF.fd (hang before displaying logo)

2020-05-12 Thread Roman Bolshakov
On Mon, May 11, 2020 at 12:38:26PM +0200, Philippe Mathieu-Daudé wrote: > Hi Olivier, > > Cc'ing the HVF maintainers. > > On 5/11/20 12:26 PM, LAHAYE Olivier wrote: > > Hi, > > > > I’m facing a similar problem to this one, but I’m unable to find any > > solution via google. > > > > https://www.

Re: [PATCH Kernel v18 5/7] vfio iommu: Update UNMAP_DMA ioctl to get dirty bitmap before unmap

2020-05-12 Thread Alex Williamson
On Wed, 13 May 2020 02:00:54 +0530 Kirti Wankhede wrote: > On 5/7/2020 3:55 AM, Alex Williamson wrote: > > On Mon, 4 May 2020 21:28:57 +0530 > > Kirti Wankhede wrote: > > > >> DMA mapped pages, including those pinned by mdev vendor drivers, might > >> get unpinned and unmapped while migration

Re: [PATCH 1/2] linux-user: add do_setsockopt SOL_CAN_RAW CAN_RAW_FILTER support

2020-05-12 Thread Tomas Krcka
Am Di., 12. Mai 2020 um 22:09 Uhr schrieb Laurent Vivier : > > Le 06/05/2020 à 15:21, Tomas Krcka a écrit : > > Signed-off-by: Tomas Krcka > > --- > > linux-user/syscall.c | 34 ++ > > 1 file changed, 34 insertions(+) > > > > diff --git a/linux-user/syscall.c b/lin

Re: [PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-12 Thread Eric Blake
On 5/12/20 3:35 PM, Nir Soffer wrote: First, a usage question: would you rather that 'qemu-img convert --bitmaps' silently succeeds even when the image being converted has no bitmaps, or would you rather that it fails loudly when there are no bitmaps to be copied over? I think the meaning of -

回复: [PATCH 0/2] use unsigned type for MegasasState fields

2020-05-12 Thread Ding, Ren
Hi all, To clarify, the bug has been reported 6 months ago with the commit version of 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d, which was the upstream back then. The reproducing driver along with the ASAN log we provided was for that version specifically. Thanks, Ren 发件人: P J P

Re: [PATCH 0/2] use unsigned type for MegasasState fields

2020-05-12 Thread Alexander Bulekov
On 200512 2259, Philippe Mathieu-Daudé wrote: > On 5/12/20 9:48 PM, Alexander Bulekov wrote: > > Oops I realized I posted a bad stacktrace and a bad reproducer :) > > Fixed stacktrace: > > > > ==20527==ERROR: AddressSanitizer: heap-buffer-overflow on address > > 0x7f79f968a5e0 at pc 0x55b6bb84ce2

Re: [PATCH 0/2] use unsigned type for MegasasState fields

2020-05-12 Thread Philippe Mathieu-Daudé
On 5/12/20 9:48 PM, Alexander Bulekov wrote: Oops I realized I posted a bad stacktrace and a bad reproducer :) Fixed stacktrace: ==20527==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7f79f968a5e0 at pc 0x55b6bb84ce28 bp 0x7ffcbca04eb0 sp 0x7ffcbca04ea8 READ of size 8 at 0x7f79f968

Re: 回复: [PATCH 0/2] use unsigned type for MegasasState fields

2020-05-12 Thread Philippe Mathieu-Daudé
Hi Ren, On 5/12/20 8:49 PM, Ding, Ren wrote: Hi all, To clarify, the bug has been reported 6 months ago with the commit version of 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d, which was the upstream back then. The reproducing driver along with the ASAN log we provided was for that version speci

Re: [PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-12 Thread Nir Soffer
On Tue, May 12, 2020 at 10:39 PM Eric Blake wrote: > > On 5/12/20 6:10 AM, Max Reitz wrote: > > > >> This does not break old code since previously we always reported only > >> guest visible content > >> here, but it changes the semantics, and now you cannot allocate > >> "required" size, you need

Re: [PATCH Kernel v18 5/7] vfio iommu: Update UNMAP_DMA ioctl to get dirty bitmap before unmap

2020-05-12 Thread Kirti Wankhede
On 5/7/2020 3:55 AM, Alex Williamson wrote: On Mon, 4 May 2020 21:28:57 +0530 Kirti Wankhede wrote: DMA mapped pages, including those pinned by mdev vendor drivers, might get unpinned and unmapped while migration is active and device is still running. For example, in pre-copy phase while gu

[PATCH v4 0/4] Introduce Xilinx ZynqMP CAN controller

2020-05-12 Thread Vikram Garhwal
Example for single CAN: -object can-bus,id=canbus0 \ -global driver=xlnx.zynqmp-can,property=canbus0,value=canbus0 \ -object can-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0 Example for connecting both CAN: -object can-bus,id=canbus0 -object can-bus,id=canbus1 \

Re: [PATCH 2/2] linux-user: add do_setsockopt CAN_RAW_FD_FRAMES support

2020-05-12 Thread Laurent Vivier
Le 06/05/2020 à 15:21, Tomas Krcka a écrit : > Signed-off-by: Tomas Krcka > --- > linux-user/syscall.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 88d4c85b70..f751ed8b37 100644 > --- a/linux-user/syscall.c > +++ b/li

[PATCH v4 3/4] tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller

2020-05-12 Thread Vikram Garhwal
The QTests perform five tests on the Xilinx ZynqMP CAN controller: Tests the CAN controller in loopback, sleep and snoop mode. Tests filtering of incoming CAN messages. Signed-off-by: Vikram Garhwal --- tests/qtest/Makefile.include | 2 + tests/qtest/xlnx-can-test.c | 367

[PATCH v4 4/4] MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN controller

2020-05-12 Thread Vikram Garhwal
Reviewed-by: Edgar E. Iglesias Signed-off-by: Vikram Garhwal --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8cbc1fa..b53d75e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1433,6 +1433,14 @@ F: hw/net/opencores_eth.c Devices --

[PATCH v4 2/4] xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers

2020-05-12 Thread Vikram Garhwal
Connect CAN0 and CAN1 on the ZynqMP. Reviewed-by: Edgar E. Iglesias Signed-off-by: Vikram Garhwal --- hw/arm/xlnx-zynqmp.c | 26 ++ include/hw/arm/xlnx-zynqmp.h | 3 +++ 2 files changed, 29 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c

[PATCH v4 1/4] hw/net/can: Introduce Xilinx ZynqMP CAN controller

2020-05-12 Thread Vikram Garhwal
XlnxCAN is developed based on SocketCAN, QEMU CAN bus implementation. Bus connection and socketCAN connection for each CAN module can be set through command lines. Signed-off-by: Vikram Garhwal --- hw/net/can/Makefile.objs |1 + hw/net/can/xlnx-zynqmp-can.c | +++

Re: [PATCH 3/3] plugins: avoid failing plugin when CPU is inited several times

2020-05-12 Thread Alex Bennée
Emilio G. Cota writes: > On Mon, May 11, 2020 at 18:53:19 +0300, Nikolay Igotti wrote: >> Attached to the mail counter.c when running with attached test.c compiled >> to Linux standalone binary shows failing assert, unless the patch is >> applied. > > I didn't get the attachment. Can you paste

Re: [PATCH 1/2] linux-user: add do_setsockopt SOL_CAN_RAW CAN_RAW_FILTER support

2020-05-12 Thread Laurent Vivier
Le 06/05/2020 à 15:21, Tomas Krcka a écrit : > Signed-off-by: Tomas Krcka > --- > linux-user/syscall.c | 34 ++ > 1 file changed, 34 insertions(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 05f03919ff..88d4c85b70 100644 > --- a/linux-user

[Bug 1878255] Re: Assertion failure in bdrv_aio_cancel, through ide

2020-05-12 Thread Philippe Mathieu-Daudé
(gdb) fr 4 #4 0x56378b63e3aa in ide_reset (s=0x56378d64d730) at hw/ide/core.c:1318 1318blk_aio_cancel(s->pio_aiocb); (gdb) p *s->pio_aiocb $1 = {aiocb_info = 0x56378bb55520 , bs = 0x0, cb = 0x56378b63d9f8 , opaque = 0x56378d64d730, refcnt = 2} void bdrv_aio_cancel(BlockAIOCB *acb

[PATCH] hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer

2020-05-12 Thread Philippe Mathieu-Daudé
Handlers don't need to modify the IDEDMA structure. Make it const. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ide/internal.h | 12 ++-- hw/ide/ahci.c | 18 +- hw/ide/core.c | 6 +++--- hw/ide/macio.c| 6 +++--- hw/ide/pci.c

Re: [PATCH 0/2] use unsigned type for MegasasState fields

2020-05-12 Thread Alexander Bulekov
Oops I realized I posted a bad stacktrace and a bad reproducer :) Fixed stacktrace: ==20527==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7f79f968a5e0 at pc 0x55b6bb84ce28 bp 0x7ffcbca04eb0 sp 0x7ffcbca04ea8 READ of size 8 at 0x7f79f968a5e0 thread T0 #0 0x55fbeb2bdafc in megasas_lo

Re: [PATCH 0/5] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-05-12 Thread Lukas Straub
On Tue, 12 May 2020 10:43:37 +0100 Daniel P. Berrangé wrote: > On Tue, May 12, 2020 at 11:32:06AM +0200, Lukas Straub wrote: > > ... > > > > Good Idea. We could name the connections (/yank callbacks) in the > > form "nbd:", "chardev:" and "migration" > > (and add "netdev:...", etc. in the futur

Re: [PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-12 Thread Eric Blake
On 5/12/20 6:10 AM, Max Reitz wrote: This does not break old code since previously we always reported only guest visible content here, but it changes the semantics, and now you cannot allocate "required" size, you need to allocate "required" size with "bitmaps" size. Only if you copy the bitm

[Bug 1823831] Re: BSD bootloader halts with hypervisor.framework

2020-05-12 Thread Roman Bolshakov
Yes, I've verified. It boots after countdown and responds to keyboard events. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1823831 Title: BSD bootloader halts with hypervisor.framework Status in

Re: [PATCH 3/3] plugins: avoid failing plugin when CPU is inited several times

2020-05-12 Thread Alex Bennée
Nikolay Igotti writes: > --- counter.c > > #include > #include > #include > #include > #include > #include > > #include > > #include > > QEMU_PLUGIN_EXPORT int qemu_plugin_version = QEMU_PLUGIN_VERSION; > > // Files with descriptors after this one are intercepted for instruction > count

[PATCH v6 8/9] tests/vm: change scripts to use self._config

2020-05-12 Thread Robert Foley
This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Robert Foley R

[PATCH v6 7/9] tests/vm: Added a new script for centos.aarch64.

2020-05-12 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm/centos.aarch64 | 227

[PATCH v6 3/9] tests/vm: Pass --debug through for vm-boot-ssh.

2020-05-12 Thread Robert Foley
This helps debug issues that occur during the boot sequence. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include index 78a2de1f82..4e041103b7 100644 --- a/tes

[PATCH v6 9/9] tests/vm: Add workaround to consume console

2020-05-12 Thread Robert Foley
The ConsoleSocket object provides a socket interface which will consume all arriving characters on the socket, but will provide those chars via recv() as would a regular socket. This is a workaround we found was needed since there is a known issue where QEMU will hang waiting for console characters

[PATCH v6 6/9] tests/vm: Added a new script for ubuntu.aarch64.

2020-05-12 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- configure | 16

[PATCH v6 4/9] tests/vm: Add ability to select QEMU from current build.

2020-05-12 Thread Robert Foley
Added a new special variable QEMU_LOCAL=1, which will indicate to take the QEMU binary from the current build. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 31 ++- 2 files changed, 30 insert

[PATCH v6 2/9] tests/vm: Added configuration file support

2020-05-12 Thread Robert Foley
Changes to tests/vm/basevm.py to allow accepting a configuration file as a parameter. Allows for specifying VM options such as cpu, machine, memory, and arbitrary qemu arguments for specifying options such as NUMA configuration. Also added an example conf_example_aarch64.yml and conf_example_x86.ym

[PATCH v6 5/9] tests/vm: allow wait_ssh() to specify command

2020-05-12 Thread Robert Foley
This allows for waiting for completion of arbitrary commands. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 1c

[PATCH v6 1/9] tests/vm: Add configuration to basevm.py

2020-05-12 Thread Robert Foley
Added use of a configuration to tests/vm/basevm.py. The configuration provides parameters used to configure a VM. This allows for providing alternate configurations to the VM being created/launched. cpu, machine, memory, and NUMA configuration are all examples of configuration which we might want t

[PATCH v6 0/9] tests/vm: Add support for aarch64 VMs

2020-05-12 Thread Robert Foley
This is version 6 of the patch series to add support for aarch64 VMs in the vm-build infrastructure. - Ubuntu 18.04 aarch64 VM - CentOS 8 aarch64 VM v5: https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg05692.html Changes in v6 - Removed the use of the BOOT_CONSOLE option. We were think

Re: [RFC PATCH 2/3] block: Allow bdrv_run_co() from different AioContext

2020-05-12 Thread Kevin Wolf
Am 12.05.2020 um 18:02 hat Thomas Lamprecht geschrieben: > On 5/12/20 4:43 PM, Kevin Wolf wrote: > > Coroutine functions that are entered through bdrv_run_co() are already > > safe to call from synchronous code in a different AioContext because > > bdrv_coroutine_enter() will schedule them in the c

Re: [PATCH v8 74/74] cputlb: queue async flush jobs without the BQL

2020-05-12 Thread Robert Foley
On Tue, 12 May 2020 at 12:27, Alex Bennée wrote: > Robert Foley writes: > > > From: "Emilio G. Cota" > > > > This yields sizable scalability improvements, as the below results show. > > > > Host: Two Intel E5-2683 v3 14-core CPUs at 2.00 GHz (Haswell) > > > > Workload: Ubuntu 18.04 ppc64 compili

Re: [PATCH 0/2] use unsigned type for MegasasState fields

2020-05-12 Thread Alexander Bulekov
Hello Prasad, I noticed this since I found a similar issue recently, using a fuzzer. I applied your patches, but I can still reproduce the heap-overflow, unless I'm missing something: ==20527==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7f79f968a5e0 at pc 0x55b6bb84ce28 bp 0x7ffcbc

Re: [PATCH v2] linux-user: support of semtimedop syscall

2020-05-12 Thread Laurent Vivier
Le 12/05/2020 à 09:45, Matus Kysel a écrit : > We should add support of semtimedop syscall as new version of > glibc 2.31 uses semop based on semtimedop (commit: > https://gitlab.com/freedesktop-sdk/mirrors/sourceware/glibc/-/commit/765cdd0bffd77960ae852104fc4ea5edcdb8aed3 > ). > > Signed-off-by

Re: [PATCH 0/5] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-05-12 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, May 12, 2020 at 11:32:06AM +0200, Lukas Straub wrote: > > On Mon, 11 May 2020 16:46:45 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > ... > > > > That way if QEMU does g

Re: [PATCH 2/2] megasas: use unsigned type for positive numeric fields

2020-05-12 Thread Peter Maydell
On Thu, 7 May 2020 at 12:02, P J P wrote: > > From: Prasad J Pandit > > Use unsigned type for the MegasasState fields which hold positive > numeric values. > > Signed-off-by: Prasad J Pandit > --- > @@ -2259,9 +2259,9 @@ static const VMStateDescription vmstate_megasas_gen1 = { > VMSTAT

Re: [PATCH 1/2] megasas: use unsigned type for reply_queue_head

2020-05-12 Thread Peter Maydell
On Thu, 7 May 2020 at 12:03, P J P wrote: > > From: Prasad J Pandit > > A guest user may set 's->reply_queue_head' MegasasState field to > a negative value. Later in 'megasas_lookup_frame' it is used to > index into s->frames[] array. Use unsigned type to avoid OOB > access issue. > > Reported-by

[Bug 1878263] [NEW] Assertion-failure in scsi_dma_complete, with megasas

2020-05-12 Thread Alexander Bulekov
Public bug reported: Hello, While fuzzing, I found an input that triggers an assertion-failure in scsi_dma_complete, with megasas: qemu-system-i386: /home/alxndr/Development/qemu/hw/scsi/scsi-disk.c:292: void scsi_dma_complete(void *, int): Assertion `r->req.aiocb != NULL' failed. #3 0x7ff

Re: [PATCH v2 3/4] mirror: Make sure that source and target size match

2020-05-12 Thread Kevin Wolf
Am 12.05.2020 um 19:15 hat Vladimir Sementsov-Ogievskiy geschrieben: > 11.05.2020 16:58, Kevin Wolf wrote: > > If the target is shorter than the source, mirror would copy data until > > it reaches the end of the target and then fail with an I/O error when > > trying to write past the end. > > > >

Re: [PATCH 0/3] plugins: Move declarations around and rename 'hwaddr' argument

2020-05-12 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Rename qemu_plugin_hwaddr_is_io() 'hwaddr' argument to later > allow declaration of the 'hwaddr' type to be poisoned (see [*]). > > [*] https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg02254.html > "exec/cpu: Poison 'hwaddr' type in user-mode emulati

Re: [PATCH 0/3] account for NVDIMM nodes during SRAT generation

2020-05-12 Thread Verma, Vishal L
On Mon, 2020-04-27 at 19:28 -0600, Vishal Verma wrote: > On the command line, one can specify a NUMA node for NVDIMM devices. If > we set up the topology to give NVDIMMs their own nodes, i.e. not > containing any CPUs or regular memory, qemu doesn't populate SRAT memory > affinity structures for th

Re: Infinite loop in bus_unparent(), qdev bug or qdev misuse?

2020-05-12 Thread Paolo Bonzini
On 12/05/20 17:58, Markus Armbruster wrote: > > Moving "put on qbus" from qdev_create() (and its wrappers) to > qdev_init_nofail() means we put on bus by realizing. No use to > recursive realization then, ... for qdev_init_nofail; it may still be useful to *replace* qdev_init_nofail with object_

[Bug 1878259] [NEW] Null-pointer dereference in megasas_handle_frame

2020-05-12 Thread Alexander Bulekov
Public bug reported: Hello, While fuzzing, I found an input that triggers a null-pointer dereference in megasas_handle_frame: ==1595==ERROR: AddressSanitizer: SEGV on unknown address 0x (pc 0x55e3e83e6e08 bp 0x7ffdb04c63b0 sp 0x7ffd ==1595==The signal is caused by a READ memory acce

Re: Problem with QEMU usermode + jemalloc

2020-05-12 Thread Peter Maydell
On Tue, 12 May 2020 at 19:16, Michael Goffioul wrote: > I'm running into a problem using QEMU in usermode and jemalloc (this is in > the context of an ARM-to-x86 translation layer for Android). The issue is > discussed here: > > https://github.com/jemalloc/jemalloc/issues/1844 > > In a nutshell,

Re: [PATCH v8 74/74] cputlb: queue async flush jobs without the BQL

2020-05-12 Thread Alex Bennée
Robert Foley writes: > From: "Emilio G. Cota" > > This yields sizable scalability improvements, as the below results show. > > Host: Two Intel E5-2683 v3 14-core CPUs at 2.00 GHz (Haswell) > > Workload: Ubuntu 18.04 ppc64 compiling the linux kernel with > "make -j N", where N is the number of

Re: [PATCH 0/2] use unsigned type for MegasasState fields

2020-05-12 Thread P J P
+-- On Tue, 12 May 2020, Philippe Mathieu-Daudé wrote --+ | Cc'ing Marc-André our signed/unsigned conversion expert (with Paolo). megasas_init_firmware pa_lo = le32_to_cpu(initq->pi_addr_lo); pa_hi = le32_to_cpu(initq->pi_addr_hi); s->producer_pa = ((uint64_t) pa_hi << 32) | pa_lo;

Re: [PATCH] qom/object: pass (Object *) to object_initialize_with_type()

2020-05-12 Thread Masahiro Yamada
On Wed, May 13, 2020 at 3:17 AM Philippe Mathieu-Daudé wrote: > > On 5/12/20 7:31 PM, Masahiro Yamada wrote: > > object_new_with_type() already passes (Object *) pointer. > > Avoid casting back and forth. > > But object_initialize() doesn't... That is no problem. A caller can pass an opaque poin

[Bug 1878255] [NEW] Assertion failure in bdrv_aio_cancel, through ide

2020-05-12 Thread Alexander Bulekov
Public bug reported: Hello, While fuzzing, I found an input that triggers an assertion failure in bdrv_aio_cancel, through ide: #1 0x7685755b in __GI_abort () at abort.c:79 #2 0x56a8d396 in bdrv_aio_cancel (acb=0x60761290) at /home/alxndr/Development/qemu/block/io.c:2746 #

Re: [PULL v3 0/1] Merge tpm 2020/05/08 v3

2020-05-12 Thread Peter Maydell
On Tue, 12 May 2020 at 16:55, Stefan Berger wrote: > > This PR submits a fix that changes improperly used 'FALSE' to 'false'. > >Stefan > > The following changes since commit c88f1ffc19e38008a1c33ae039482a860aa7418c: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into sta

[PATCH] qom/object: simplify type_initialize_interface()

2020-05-12 Thread Masahiro Yamada
iface_impl->class is the same as new_iface. Make it more readable. Signed-off-by: Masahiro Yamada --- qom/object.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index 9d1a918e42..75c628591d 100644 --- a/qom/object.c +++ b/qom/object.c @@ -262,

Re: [PATCH v3 00/15] Apply COR-filter to the block-stream permanently

2020-05-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1589295196-773454-1-git-send-email-andrey.shinkev...@virtuozzo.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. =

Re: [PATCH v3 00/15] Apply COR-filter to the block-stream permanently

2020-05-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1589295196-773454-1-git-send-email-andrey.shinkev...@virtuozzo.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT B

[Bug 1878253] [NEW] null-ptr dereference in address_space_to_flatview through ide

2020-05-12 Thread Alexander Bulekov
Public bug reported: Hello, While fuzzing, I found an input that triggers a null-ptr dereference in address_space_to_flatview through ide: ==31699==ERROR: AddressSanitizer: SEGV on unknown address 0x0020 (pc 0x55e0f562bafd bp 0x7ffee92355b0 sp 0x7ffee92354e0 T0) ==31699==The signal is ca

Re: [PATCH v3 00/15] Apply COR-filter to the block-stream permanently

2020-05-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1589295196-773454-1-git-send-email-andrey.shinkev...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally.

Re: [PATCH] MAINTAINERS: Update Radoslaw Biernacki email address

2020-05-12 Thread Philippe Mathieu-Daudé
On Tue, May 12, 2020 at 8:18 PM Philippe Mathieu-Daudé wrote: > > On 5/12/20 7:07 PM, Radoslaw Biernacki wrote: > > My Linaro account is no longer active and stop forwarding emails to me. > > Changing it to my current employer domain. > > > > Signed-off-by: Radoslaw Biernacki > > --- > > .mailm

Re: [PATCH] MAINTAINERS: Update Radoslaw Biernacki email address

2020-05-12 Thread Philippe Mathieu-Daudé
On 5/12/20 7:07 PM, Radoslaw Biernacki wrote: My Linaro account is no longer active and stop forwarding emails to me. Changing it to my current employer domain. Signed-off-by: Radoslaw Biernacki --- .mailmap| 1 + MAINTAINERS | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH] qom/object: pass (Object *) to object_initialize_with_type()

2020-05-12 Thread Philippe Mathieu-Daudé
On 5/12/20 7:31 PM, Masahiro Yamada wrote: object_new_with_type() already passes (Object *) pointer. Avoid casting back and forth. But object_initialize() doesn't... Signed-off-by: Masahiro Yamada --- qom/object.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qo

Problem with QEMU usermode + jemalloc

2020-05-12 Thread Michael Goffioul
Hi, I'm running into a problem using QEMU in usermode and jemalloc (this is in the context of an ARM-to-x86 translation layer for Android). The issue is discussed here: https://github.com/jemalloc/jemalloc/issues/1844 In a nutshell, the lack of madvise implementation is making jemalloc return no

[PATCH v2 1/1] vfio-ccw: allow non-prefetch ORBs

2020-05-12 Thread Jared Rossi
Remove the explicit prefetch check when using vfio-ccw devices. This check does not trigger in practice as all Linux channel programs are intended to use prefetch. It is no longer required to force the PFCH flag when using vfio-ccw devices. Signed-off-by: Jared Rossi --- hw/vfio/ccw.c | 13 +++-

[PATCH v2 0/1] vfio-ccw: Enable transparent CCW IPL from DASD [QEMU]

2020-05-12 Thread Jared Rossi
Remove the explicit prefetch check when using vfio-ccw devices. This check does not trigger in practice as all Linux channel programs are intended to use prefetch. QEMU part to make use of the corresponding kernel patch posted here: https://lore.kernel.org/kvm/20200506212440.31323-1-jro...@linux.

  1   2   3   4   >