On Thu, 7 May 2020 at 12:02, P J P <ppan...@redhat.com> wrote:
>
> From: Prasad J Pandit <p...@fedoraproject.org>
>
> Use unsigned type for the MegasasState fields which hold positive
> numeric values.
>
> Signed-off-by: Prasad J Pandit <p...@fedoraproject.org>
> ---
> @@ -2259,9 +2259,9 @@ static const VMStateDescription vmstate_megasas_gen1 = {
> VMSTATE_PCI_DEVICE(parent_obj, MegasasState),
> VMSTATE_MSIX(parent_obj, MegasasState),
>
> - VMSTATE_INT32(fw_state, MegasasState),
> - VMSTATE_INT32(intr_mask, MegasasState),
> - VMSTATE_INT32(doorbell, MegasasState),
> + VMSTATE_UINT32(fw_state, MegasasState),
> + VMSTATE_UINT32(intr_mask, MegasasState),
> + VMSTATE_UINT32(doorbell, MegasasState),
> VMSTATE_UINT64(reply_queue_pa, MegasasState),
> VMSTATE_UINT64(consumer_pa, MegasasState),
> VMSTATE_UINT64(producer_pa, MegasasState),
> @@ -2278,9 +2278,9 @@ static const VMStateDescription vmstate_megasas_gen2 = {
> VMSTATE_PCI_DEVICE(parent_obj, MegasasState),
> VMSTATE_MSIX(parent_obj, MegasasState),
>
> - VMSTATE_INT32(fw_state, MegasasState),
> - VMSTATE_INT32(intr_mask, MegasasState),
> - VMSTATE_INT32(doorbell, MegasasState),
> + VMSTATE_UINT32(fw_state, MegasasState),
> + VMSTATE_UINT32(intr_mask, MegasasState),
> + VMSTATE_UINT32(doorbell, MegasasState),
> VMSTATE_UINT64(reply_queue_pa, MegasasState),
> VMSTATE_UINT64(consumer_pa, MegasasState),
> VMSTATE_UINT64(producer_pa, MegasasState),
Does an INT32->UINT32 change in vmstate break migration compat?
I forget, but this is the kind of detail it's worth calling out
in the commit message if you've checked and it really is still
compatible.
thanks
-- PMM
