[PATCH v2] qxl: introduce hardware revision 5

2020-02-05 Thread Gerd Hoffmann
The only difference to hardware revision 4 is that the device doesn't switch to VGA mode in case someone happens to touch a VGA register, which should make things more robust in configurations with multiple vga devices. Swtiching back to VGA mode happens on reset, either full machine reset or qxl

Re: [PATCH v5 00/26] nvme: support NVMe v1.3d, SGLs and multiple namespaces

2020-02-05 Thread Klaus Birkelund Jensen
On Feb 5 01:47, Keith Busch wrote: > On Tue, Feb 04, 2020 at 10:51:42AM +0100, Klaus Jensen wrote: > > Hi, > > > > > > Changes since v4 > > - Changed vendor and device id to use a Red Hat allocated one. For > >backwards compatibility add the 'x-use-intel-id' nvme device > >parameter. Th

Re: [PATCH v5 24/26] nvme: change controller pci id

2020-02-05 Thread Klaus Birkelund Jensen
On Feb 5 01:35, Keith Busch wrote: > On Tue, Feb 04, 2020 at 10:52:06AM +0100, Klaus Jensen wrote: > > There are two reasons for changing this: > > > > 1. The nvme device currently uses an internal Intel device id. > > > > 2. Since commits "nvme: fix write zeroes offset and count" and "nvme:

Re: [PATCH v5 22/26] nvme: support multiple namespaces

2020-02-05 Thread Klaus Birkelund Jensen
On Feb 5 01:31, Keith Busch wrote: > On Tue, Feb 04, 2020 at 10:52:04AM +0100, Klaus Jensen wrote: > > This adds support for multiple namespaces by introducing a new 'nvme-ns' > > device model. The nvme device creates a bus named from the device name > > ('id'). The nvme-ns devices then connect to

Re: [PATCH v5 26/26] nvme: make lba data size configurable

2020-02-05 Thread Klaus Birkelund Jensen
On Feb 5 01:43, Keith Busch wrote: > On Tue, Feb 04, 2020 at 10:52:08AM +0100, Klaus Jensen wrote: > > Signed-off-by: Klaus Jensen > > --- > > hw/block/nvme-ns.c | 2 +- > > hw/block/nvme-ns.h | 4 +++- > > hw/block/nvme.c| 1 + > > 3 files changed, 5 insertions(+), 2 deletions(-) > > > > d

Re: [PATCH 2/3] m25p80: Improve command handling for Jedec and unsupported commands

2020-02-05 Thread Joel Stanley
On Wed, 5 Feb 2020 at 17:43, Guenter Roeck wrote: > > On Wed, Feb 05, 2020 at 11:08:07AM +0100, Cédric Le Goater wrote: > > > > ok. we will need to model SFDP one day. > > > > Are you using the OpenBMC images or do you have your own ? > > > > I am running images built from upstream/stable kernel b

Re: [PATCH] qemu-img: Place the '-i aio' option in alphabetical order

2020-02-05 Thread Stefan Hajnoczi
On Wed, Feb 05, 2020 at 05:30:08PM +0100, Julia Suvorova wrote: > The '-i AIO' option was accidentally placed after '-n' and '-t'. Move it > after '--flush-interval'. > > Signed-off-by: Julia Suvorova > --- > docs/interop/qemu-img.rst | 8 > qemu-img-cmds.hx | 4 ++-- > 2 files

Re: [PATCH for-5.0 3/4] Remove the core bluetooth code

2020-02-05 Thread Thomas Huth
On 05/02/2020 19.53, Aleksandar Markovic wrote: > On Wed, Feb 5, 2020 at 7:03 PM Aleksandar Markovic > wrote: >> >>> The deprecation policy is primarily intended for notifying of changes >>> to QEMU's stable interfaces ( CLI, HMP, QMP) which affect behaviour >>> and usage of QEMU at runtime & are

Re: [PATCH 2/2] ppc/pnv: Fix PCI_EXPRESS dependency

2020-02-05 Thread Thomas Huth
On 06/02/2020 00.17, Laurent Vivier wrote: > On 05/02/2020 22:20, Greg Kurz wrote: >> On Wed, 5 Feb 2020 21:41:15 +0100 >> Laurent Vivier wrote: >> >>> When PHB4 bridge has been added, the dependencies to PCIE_PORT has been >>> added to XIVE_SPAPR and indirectly to PSERIES. >>> The build of the P

Re: [PATCH] virtio: clean up when virtio_queue_set_rings() fails

2020-02-05 Thread Michael S. Tsirkin
On Wed, Feb 05, 2020 at 02:56:57PM +, Stefan Hajnoczi wrote: > On Wed, Feb 05, 2020 at 01:13:37AM -0500, Michael S. Tsirkin wrote: > > On Tue, Feb 04, 2020 at 03:16:18PM +, Stefan Hajnoczi wrote: > > > hw/virtio.c checks vq->vring.desc != NULL to see if the vring has been > > > set up succe

Re: [PATCH] Add support for a helper with 7 arguments

2020-02-05 Thread Richard Henderson
On 2/5/20 10:41 PM, Taylor Simpson wrote: > Currently, helpers can only take up to 6 arguments. This patch adds the > capability for up to 7 arguments. I have tested it with the Hexagon port > that I am preparing for submission. This is not safe, in general, without other changes. >From include

Re: [PATCH] i386: pass CLZERO to guests with EPYC CPU model on AMD ZEN platform

2020-02-05 Thread Ani Sinha
> On Feb 6, 2020, at 11:16 AM, Ani Sinha wrote: > > > >> On Feb 6, 2020, at 5:30 AM, Moger, Babu wrote: >> >> Ani, I am already working on it. > > Wow, I see a whole new AMD-Rome CPU model with it’s own cache info data : > > https://lore.kernel.org/qemu-devel/157314966312.23828.176848216

Re: [PATCH] i386: pass CLZERO to guests with EPYC CPU model on AMD ZEN platform

2020-02-05 Thread Ani Sinha
> On Feb 6, 2020, at 5:30 AM, Moger, Babu wrote: > > Ani, I am already working on it. Wow, I see a whole new AMD-Rome CPU model with it’s own cache info data : https://lore.kernel.org/qemu-devel/157314966312.23828.17684821666338093910.st...@naples-babu.amd.com/ Thanks! ani

[Bug 1862110] Re: qemu in script is not parsing properly

2020-02-05 Thread Chris Hoy
EDIT: The backslash under the ovmf setting was commented -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1862110 Title: qemu in script is not parsing properly Status in QEMU: New Bug description:

[Bug 1862110] [NEW] qemu in script is not parsing properly

2020-02-05 Thread Chris Hoy
Public bug reported: Bug Report: >>qemu-system-x86_64 --version: QEMU emulator version 4.2.0 >>Arch-linux version 2020.02.01 I was following a tutorial on how to make a windows vm and i have encountered and issue in the settings of my script I have listed below. The commented code directly abov

Re: [PATCH v2 0/3] vhost-user: Lift Max Ram Slots Limitation

2020-02-05 Thread Raphael Norwitz
Ping On Wed, Jan 15, 2020 at 09:57:03PM -0500, Raphael Norwitz wrote: > > In QEMU today, a VM with a vhost-user device can hot add memory a > maximum of 8 times. See these threads, among others: > > [1] https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01046.html > https://lists.gnu

Re: VW ELF loader

2020-02-05 Thread David Gibson
On Wed, Feb 05, 2020 at 10:28:30AM +0100, Cornelia Huck wrote: > On Wed, 5 Feb 2020 17:06:34 +1100 > David Gibson wrote: > > > On Tue, Feb 04, 2020 at 12:26:32AM +0100, Paolo Bonzini wrote: > > > > You can generalize and reuse the s390 code. All you have to write is the > > > PCI scan and virtio

[PATCH] aspeed/i2c:fix uninitialized variable warning

2020-02-05 Thread kuhn.chenqun
From: Chen Qun Fix warning: hw/i2c/aspeed_i2c.c: In function ‘aspeed_i2c_bus_write’: glib/glib-autocleanups.h:28:3: warning: ‘cmd_flags’ may be used uninitialized in this function [-Wmaybe-uninitialized] g_free (*pp); ^~~~ hw/i2c/aspeed_i2c.c:403:22: note: ‘cmd_flags’ was declared h

Re: [PATCH v2 1/2] qtest: Fix rtas dependencies

2020-02-05 Thread David Gibson
On Thu, Feb 06, 2020 at 12:20:15AM +0100, Laurent Vivier wrote: > qtest "rtas" command is only available with pseries not all ppc64 targets, > so if I try to compile only powernv machine, the build fails with: > > /usr/bin/ld: qtest.o: in function `qtest_process_command': > .../qtest.c:645: un

Re: [PATCH v2 0/2] ppc/pnv: fix build dependencies

2020-02-05 Thread David Gibson
On Thu, Feb 06, 2020 at 12:20:14AM +0100, Laurent Vivier wrote: > Building only POWERNV machine without PSERIES machine > fails because of a couple of reasons: > > - qtest uses rtas function only provided by PSERIES, > - the dependency to PCI Express has been added to XIVE_SPAPR > rather than to

Re: [PATCH] tcg: gdbstub: Fix missing breakpoint issue

2020-02-05 Thread Changbin Du
On Wed, Feb 05, 2020 at 11:03:23AM +, Richard Henderson wrote: > On 1/24/20 2:17 AM, Changbin Du wrote: > > When inserting breakpoints, we need to invalidate related TBs to apply > > helper call. This is done by breakpoint_invalidate(). But many users > > found the BPs sometimes never hit. > >

Re: [PATCH v3 1/1] qemu-img: Add --target-is-zero to convert

2020-02-05 Thread Eric Blake
On 2/4/20 8:21 AM, David Edmondson wrote: On Tuesday, 2020-02-04 at 07:31:52 -06, Eric Blake wrote: On 2/4/20 3:52 AM, David Edmondson wrote: In many cases the target of a convert operation is a newly provisioned target that the user knows is blank (filled with zeroes). In this 'filled with

Re: [PATCH v4 1/1] qemu-img: Add --target-is-zero to convert

2020-02-05 Thread Eric Blake
On 2/5/20 5:02 AM, David Edmondson wrote: In many cases the target of a convert operation is a newly provisioned target that the user knows is blank (reads as zero). In this situation there is no requirement for qemu-img to wastefully zero out the entire device. Add a new option, --target-is-zer

Re: [RFC v2 00/14] Add SDEI support for arm64

2020-02-05 Thread Heyi Guo
Hi Marc, On 2020/2/5 21:15, Marc Zyngier wrote: Hi Heyi, On 2020-02-04 08:26, Heyi Guo wrote: Update Marc's email address. +cc Gavin as he is posting a RFC for ARM NMI. Hi Marc, Really sorry for missing to update your email address, for the initial topic was raised long time ago and I forgo

Re: [PATCH v1 08/13] util/mmap-alloc: Prepare for resizable mmaps

2020-02-05 Thread Murilo Opsfelder Araújo
Hello, David. On Monday, February 3, 2020 3:31:20 PM -03 David Hildenbrand wrote: > When shrinking a mmap we want to re-reserve the already populated area. > When growing a memory region, we want to populate starting with a given > fd_offset. Prepare by allowing to pass these parameters. > > Also

[PATCH v2 28/30] tests/acceptance: Count Raspberry Pi logos displayed on framebuffer

2020-02-05 Thread Philippe Mathieu-Daudé
Add a test that verifies that each core properly displays the Raspberry Pi logo on the framebuffer device. We simply follow the OpenCV "Template Matching with Multiple Objects" tutorial, replacing Lionel Messi by a raspberrry: https://docs.opencv.org/4.2.0/d4/dc6/tutorial_py_template_matching.html

[PATCH v2 26/30] python/qemu/machine: Allow to use other serial consoles than default

2020-02-05 Thread Philippe Mathieu-Daudé
Currently the QEMU Python module limits the QEMUMachine class to use the first serial console. Some machines/guest might use another console than the first one as the 'boot console'. For example the Raspberry Pi uses the second (AUX) console. To be able to use the Nth console as default, we simpl

[NOTFORMERGE PATCH v2 29/30] hw/arm/bcm2836: Add the BCM2838 (ARMv8)

2020-02-05 Thread Philippe Mathieu-Daudé
Setup the GICv2. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/bcm2836.h | 3 + hw/arm/bcm2836.c | 206 +++ 2 files changed, 209 insertions(+) diff --git a/include/hw/arm/bcm2836.h b/include/hw/arm/bcm2836.h index 3d46469a73..7c1f79911c 1

[PATCH v2 25/30] tests/acceptance/boot_linux_console: Test the raspi0 console

2020-02-05 Thread Philippe Mathieu-Daudé
$ avocado --show=app,console run -t machine:raspi0 tests/acceptance/ JOB ID : af8e017486290758bff39c986934134199af3556 JOB LOG: avocado/job-results/job-2020-02-05T23.53-af8e017/job.log (1/1) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_raspi0_uart0: console:

[PATCH v2 27/30] tests/acceptance/boot_linux_console: Test the raspi1 AUX console

2020-02-05 Thread Philippe Mathieu-Daudé
$ avocado --show=app,console run -t device:bcm2835_aux tests/acceptance/ JOB ID : a8846d69d52da701681b1d17f80ef299009fd078 JOB LOG: avocado/job-results/job-2020-02-05T23.44-a8846d6/job.log (1/3) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_raspi0_uart1: conso

[PATCH v2 22/30] tests/acceptance/boot_linux_console: Use raspi console model as key

2020-02-05 Thread Philippe Mathieu-Daudé
Python dictionary are not that expensive. Use a key makes the code easier to review. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/boot_linux_console.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/acceptance/boot_linux_console.py b/tests/accept

[PATCH v2 23/30] tests/acceptance/boot_linux_console: Add raspi version=2 parameter

2020-02-05 Thread Philippe Mathieu-Daudé
We want to tests different Raspberry Pi machines. Refactor to take the board version as argument. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/boot_linux_console.py | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/tests/acceptance/boot_linu

[PATCH v2 24/30] tests/acceptance/boot_linux_console: Test the raspi1 console

2020-02-05 Thread Philippe Mathieu-Daudé
$ avocado --show=app,console run -t machine:raspi1 tests/acceptance/ JOB ID : c49310d4a21444f03789cd2c443d8c54a29ffd0a JOB LOG: avocado/job-results/job-2020-02-05T23.52-c49310d/job.log (1/1) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_raspi1_uart0: console:

[NOTFORMERGE PATCH v2 30/30] hw/arm/raspi: Add the Raspberry Pi 4

2020-02-05 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 47cc250883..8a0309933b 100644 --- a/hw/arm/raspi.c +++ b/hw/arm/raspi.c @@ -88,7 +88,7 @@ static int board_version(uint32_t b

[PATCH v2 21/30] hw/arm/raspi: Add the Raspberry Pi B+ machine

2020-02-05 Thread Philippe Mathieu-Daudé
$ qemu-system-arm -M raspi1 -serial stdio \ -kernel raspberrypi/firmware/boot/kernel.img \ -dtb raspberrypi/firmware/boot/bcm2708-rpi-b.dtb \ -append 'printk.time=0 earlycon=pl011,0x20201000 console=ttyAMA0' [0.00] Booting Linux on physical CPU 0x0 [0.00] Lin

[PATCH v2 14/30] hw/arm/bcm2836: Restrict BCM283XClass declaration to C source

2020-02-05 Thread Philippe Mathieu-Daudé
No code out of bcm2836.c uses (or requires) this declarations. Move it locally to the C source file. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/bcm2836.h | 12 hw/arm/bcm2836.c | 14 ++ 2 files changed, 14 insertions(+), 12 deletions(-) diff --git

[PATCH v2 20/30] hw/arm/raspi: Add the Raspberry Pi Zero machine

2020-02-05 Thread Philippe Mathieu-Daudé
Add a Raspberry Pi Zero machine. $ qemu-system-arm -M raspi0 -serial stdio \ -kernel raspberrypi/firmware/boot/kernel.img \ -dtb raspberrypi/firmware/boot/bcm2708-rpi-zero-w.dtb \ -append 'printk.time=0 earlycon=pl011,0x20201000 console=ttyAMA0' [0.00] Booting Linux o

[PATCH v2 11/30] hw/arm/raspi: Extract the board model from the board revision

2020-02-05 Thread Philippe Mathieu-Daudé
The board revision encode the model type. Add a helper to extract the model, and use it. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 43f8b1d677..a104393cb2 1

[PATCH v2 19/30] hw/arm/bcm2836: Introduce the BCM2835 SoC

2020-02-05 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/bcm2836.h | 1 + hw/arm/bcm2836.c | 40 2 files changed, 41 insertions(+) diff --git a/include/hw/arm/bcm2836.h b/include/hw/arm/bcm2836.h index acc75bf553..3d46469a73 100644 --- a/include/

[PATCH v2 18/30] hw/arm/bcm2836: Split out common realize() code

2020-02-05 Thread Philippe Mathieu-Daudé
The realize() function is clearly composed of two parts, each described by a comment: void realize() { /* common peripherals from bcm2835 */ ... /* bcm2836 interrupt controller (and mailboxes, etc.) */ ... } Split the two part, so we can reuse the common part with other

[PATCH v2 12/30] hw/arm/raspi: Use a unique raspi_machine_class_init() method

2020-02-05 Thread Philippe Mathieu-Daudé
With the exception of the ignore_memory_transaction_failures flag set for the raspi2, both machine_class_init() methods are now identical. Merge them to keep a unique method. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 31 ++- 1 file changed, 6 insertio

[PATCH v2 16/30] hw/arm/bcm2836: Introduce BCM283XClass::core_count

2020-02-05 Thread Philippe Mathieu-Daudé
The BCM2835 has only one core. Introduce the core_count field to be able to use values different than BCM283X_NCPUS (4). Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/bcm2836.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c index

[PATCH v2 09/30] hw/arm/raspi: Let class_init() directly call raspi_machine_init()

2020-02-05 Thread Philippe Mathieu-Daudé
raspi_machine_init() access to board_rev via RaspiMachineClass. raspi2_init() and raspi3_init() do nothing. Call raspi_machine_init directly. Signed-off-by: Philippe Mathieu-Daudé --- Squash with previous? --- hw/arm/raspi.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-)

[PATCH v2 17/30] hw/arm/bcm2836: Only provide "enabled-cpus" property to multicore SoCs

2020-02-05 Thread Philippe Mathieu-Daudé
It makes no sense to set enabled-cpus=0 on single core SoCs. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/bcm2836.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c index 3b95ad11e9..caaa4b625e 100644 --- a/hw/arm/bcm2836

[PATCH v2 10/30] hw/arm/raspi: Set default RAM size to size encoded in board revision

2020-02-05 Thread Philippe Mathieu-Daudé
We added a helper to extract the RAM size from the board revision, and made board_rev a field of RaspiMachineClass. The class_init() can now use the helper to extract from the board revision the board-specific amount of RAM. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 4 ++-- 1 fi

[PATCH v2 15/30] hw/arm/bcm2836: QOM'ify more by adding class_init() to each SoC type

2020-02-05 Thread Philippe Mathieu-Daudé
Remove usage of TypeInfo::class_data. Instead fill the fields in the corresponding class_init(). Cc: Igor Mammedov Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/bcm2836.c | 109 ++- 1 file changed, 51 insertions(+), 58 deletions(-) diff --git a/hw

[PATCH v2 08/30] hw/arm/raspi: Make board_rev a field of RaspiMachineClass

2020-02-05 Thread Philippe Mathieu-Daudé
We want to have a common class_init(). The only value that matters (and changes) is the board revision. Pass the board_rev as class_data to class_init(). Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git

[PATCH v2 06/30] hw/arm/raspi: Trivial code movement

2020-02-05 Thread Philippe Mathieu-Daudé
There is no point in creating the SoC object before allocating the RAM. Move the call to keep all the SoC-related calls together. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c inde

[PATCH v2 03/30] hw/arm/raspi: Extract the version from the board revision

2020-02-05 Thread Philippe Mathieu-Daudé
The board revision encode the board version. Add a helper to extract the version, and use it. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Alistair Francis hw/arm/raspi.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/hw/arm/raspi.c b/hw/a

[PATCH v2 07/30] hw/arm/raspi: Make machines children of abstract RaspiMachineClass

2020-02-05 Thread Philippe Mathieu-Daudé
QOM'ify RaspiMachineState. Now machines inherite of RaspiMachineClass. Cc: Igor Mammedov Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 56 +++--- 1 file changed, 49 insertions(+), 7 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi

[PATCH v2 13/30] hw/arm/raspi: Extract the cores count from the board revision

2020-02-05 Thread Philippe Mathieu-Daudé
The board revision encode the count of ARM cores. Add a helper to extract the number of cores, and use it. This will be helpful when we add the Raspi0/1 that have a single core. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 19 --- 1 file changed, 16 insertions(+), 3

[PATCH v2 05/30] hw/arm/raspi: Extract the processor type from the board revision

2020-02-05 Thread Philippe Mathieu-Daudé
The board revision encode the processor type. Add a helper to extract the type, and use it. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 2f5cd32c5e..20195227e

[PATCH v2 02/30] hw/arm/raspi: Correct the board descriptions

2020-02-05 Thread Philippe Mathieu-Daudé
We hardcode the board revision as 0xa21041 for the raspi2, and 0xa02082 for the raspi3: 166 static void raspi_init(MachineState *machine, int version) 167 { ... 194 int board_rev = version == 3 ? 0xa02082 : 0xa21041; These revision codes are for the 2B and 3B models, see: https://www.

[PATCH v2 04/30] hw/arm/raspi: Extract the RAM size from the board revision

2020-02-05 Thread Philippe Mathieu-Daudé
The board revision encode the amount of RAM. Add a helper to extract the RAM size, and use it. Since the amount of RAM is fixed (it is impossible to physically modify to have more or less RAM), do not allow sizes different than the one anounced by the manufacturer. Acked-by: Igor Mammedov Signed-

[PATCH v2 01/30] hw/arm/raspi: Use BCM2708 machine type with pre Device Tree kernels

2020-02-05 Thread Philippe Mathieu-Daudé
When booting without device tree, the Linux kernels uses the $R1 register to determine the machine type. The list of values is registered at [1]. There are two entries for the Raspberry Pi: - https://www.arm.linux.org.uk/developer/machines/list.php?mid=3138 name: MACH_TYPE_BCM2708 value: 0xc4

[PATCH v2 00/30] hw/arm/raspi: Dynamically create machines based on the board revision

2020-02-05 Thread Philippe Mathieu-Daudé
Hi, These patches simplify adding the raspi0/raspi1/raspi4 boards. Igor has been working in his "refactor main RAM allocation to use hostmem backend" series, and now v4 [1] is almost reviewed. His raspi patch [2] clashes with my work, Since it is easier for him to apply his on top of mine, I am

Re: [PATCH 0/3] delay timer_new to avoid memleaks

2020-02-05 Thread Pan Nengyuan
On 2/5/2020 9:16 PM, Philippe Mathieu-Daudé wrote: > On 2/5/20 8:06 AM, pannengy...@huawei.com wrote: >> From: Pan Nengyuan >> >> This series delay timer_new into realize() to fix some memleaks when we call >> 'device-list-properties'. >> >> Pan Nengyuan (3): >>    armv7m_systick: delay timer_

RE: [PATCH] i386: pass CLZERO to guests with EPYC CPU model on AMD ZEN platform

2020-02-05 Thread Moger, Babu
[AMD Official Use Only - Internal Distribution Only] > -Original Message- > From: Eduardo Habkost > Sent: Wednesday, February 5, 2020 4:38 PM > To: Ani Sinha > Cc: Paolo Bonzini ; r...@twiddle.net; qemu- > de...@nongnu.org; Singh, Brijesh ; Moger, Babu > > Subject: Re: [PATCH] i386: pas

Re: [PATCH v2 4/5] python/qemu: qmp: Make QEMUMonitorProtocol a context manager

2020-02-05 Thread John Snow
On 2/4/20 9:11 AM, Wainer dos Santos Moschetta wrote: > This implement the __enter__ and __exit__ functions on > QEMUMonitorProtocol class so that it can be used on 'with' > statement and the resources will be free up on block end: > > with QEMUMonitorProtocol(socket_path) as qmp: > qmp.con

Re: [PATCH v2 26/33] block: Use child_of_bds in remaining places

2020-02-05 Thread Eric Blake
On 2/4/20 11:08 AM, Max Reitz wrote: Replace child_file by child_of_bds in all remaining places (excluding tests). Signed-off-by: Max Reitz --- +++ b/block/raw-format.c @@ -444,6 +444,7 @@ static int raw_open(BlockDriverState *bs, QDict *options, int flags, BDRVRawState *s = bs->opaqu

Re: [PATCH v2 3/5] python/qemu: qmp: Make accept()'s timeout configurable

2020-02-05 Thread John Snow
On 2/4/20 9:11 AM, Wainer dos Santos Moschetta wrote: > Currently the timeout of QEMUMonitorProtocol.accept() is > hard-coded to 15.0 seconds. This added the parameter `timeout` > so the value can be configured by the user. > > Signed-off-by: Wainer dos Santos Moschetta > Reviewed-by: Philippe

Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups

2020-02-05 Thread John Snow
On 1/28/20 11:47 AM, Dr. David Alan Gilbert wrote: > * John Snow (js...@redhat.com) wrote: >> >> >> On 1/27/20 3:43 PM, Peter Krempa wrote: >>> On Mon, Jan 27, 2020 at 14:39:02 -0500, John Snow wrote: On 1/27/20 5:36 AM, Maxim Levitsky wrote: > This patch series is bunch of cl

[PATCH v2 1/2] qtest: Fix rtas dependencies

2020-02-05 Thread Laurent Vivier
qtest "rtas" command is only available with pseries not all ppc64 targets, so if I try to compile only powernv machine, the build fails with: /usr/bin/ld: qtest.o: in function `qtest_process_command': .../qtest.c:645: undefined reference to `qtest_rtas_call' We fix this by enabling rtas comma

[PATCH v2 0/2] ppc/pnv: fix build dependencies

2020-02-05 Thread Laurent Vivier
Building only POWERNV machine without PSERIES machine fails because of a couple of reasons: - qtest uses rtas function only provided by PSERIES, - the dependency to PCI Express has been added to XIVE_SPAPR rather than to POWERNV v2: remove PCI already selected by PCI_EXPRESS remove PCIE_POR

[PATCH v2 2/2] ppc/pnv: Fix PCI_EXPRESS dependency

2020-02-05 Thread Laurent Vivier
When PHB4 bridge has been added, the dependencies to PCIE_PORT has been added to XIVE_SPAPR and indirectly to PSERIES. The build of the PowerNV machine is fine while we also build the PSERIES machine. If we disable the PSERIES machine, the PowerNV build fails because the PCI Express files are not b

Re: [PATCH 2/2] ppc/pnv: Fix PCI_EXPRESS dependency

2020-02-05 Thread Laurent Vivier
On 05/02/2020 22:20, Greg Kurz wrote: > On Wed, 5 Feb 2020 21:41:15 +0100 > Laurent Vivier wrote: > >> When PHB4 bridge has been added, the dependencies to PCIE_PORT has been >> added to XIVE_SPAPR and indirectly to PSERIES. >> The build of the PowerNV machine is fine while we also build the PSE

Re: [PATCH v2 25/33] block: Make filter drivers use child_of_bds

2020-02-05 Thread Eric Blake
On 2/4/20 11:08 AM, Max Reitz wrote: Note that some filters have secondary children, namely blkverify (the image to be verified) and blklogwrites (the log). This patch does not touch those children. I would have guessed blkdebug; but I guess that's not quite a filter for other reasons, so it

Re: [PATCH v2 24/33] block: Make format drivers use child_of_bds

2020-02-05 Thread Eric Blake
On 2/4/20 11:08 AM, Max Reitz wrote: Commonly, they need to pass the BDRV_CHILD_IMAGE set as the BdrvChildRole; but there are exceptions for drivers with external data files (qcow2 and vmdk). Signed-off-by: Max Reitz --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red

Re: [PATCH v2 23/33] block: Drop child_backing

2020-02-05 Thread Eric Blake
On 2/4/20 11:08 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- block.c | 62 +++ include/block/block_int.h | 1 - 2 files changed, 4 insertions(+), 59 deletions(-) More code deletion. diff --git a/block.c b/block.c index 6b705ee2

Re: [PATCH 2/5] ui/gtk: implement show-cursor option

2020-02-05 Thread Ján Tomko
On Wed, Feb 05, 2020 at 12:03:53PM +0100, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 3/5] ui/sdl: implement show-cursor option

2020-02-05 Thread Ján Tomko
On Wed, Feb 05, 2020 at 12:03:54PM +0100, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 1/5] ui: add show-cursor option

2020-02-05 Thread Ján Tomko
On Wed, Feb 05, 2020 at 12:03:52PM +0100, Gerd Hoffmann wrote: When enabled forces showing a the mouse cursor, i.e. do nowallow the guest to hide it. Defaults to off. Signed-off-by: Gerd Hoffmann --- qapi/ui.json | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Ján Tomko Jano signatu

Re: [PATCH v2 22/33] block: Make backing files child_of_bds children

2020-02-05 Thread Eric Blake
On 2/4/20 11:08 AM, Max Reitz wrote: Signed-off-by: Max Reitz Another sparse commit message (a recurring theme of this series). The subject line says 'what', and the patch appears to be faithful to that, but if a future bisection lands here, even a one-sentence 'why' would be handy; maybe:

Re: [PATCH 4/5] ui: wire up legacy -show-cursor option

2020-02-05 Thread Ján Tomko
On Wed, Feb 05, 2020 at 12:03:55PM +0100, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- include/sysemu/sysemu.h | 1 - vl.c| 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index 24951b51a94b..0db0aa0fa040 100644 --- a/vl.c +++ b/vl

[PATCH] Add support for a helper with 7 arguments

2020-02-05 Thread Taylor Simpson
Currently, helpers can only take up to 6 arguments. This patch adds the capability for up to 7 arguments. I have tested it with the Hexagon port that I am preparing for submission. Signed-off-by: Taylor Simpson --- include/exec/helper-gen.h | 13 + include/exec/helper-head.h |

Re: [PATCH] i386: pass CLZERO to guests with EPYC CPU model on AMD ZEN platform

2020-02-05 Thread Eduardo Habkost
Hi, Sorry for the delayed reply. I was away from work for the whole month of January. On Mon, Jan 20, 2020 at 10:56:43AM +, Ani Sinha wrote: > Sorry Eduardo, it took a little while for me to get to this thread again. > > > On Dec 18, 2019, at 8:41 PM, Eduardo Habkost wrote: > > > > On Wed

RE: [PATCH v2 4/4] linux-user: fix use of SIGRTMIN

2020-02-05 Thread Taylor Simpson
Reviewed-by: Taylor Simson > -Original Message- > From: Laurent Vivier > Sent: Tuesday, February 4, 2020 11:11 AM > To: qemu-devel@nongnu.org > Cc: Peter Maydell ; Josh Kunz > ; Laurent Vivier ; Aleksandar > Markovic ; Matus Kysel > ; Riku Voipio ; Taylor Simpson > ; milos.stojano...@rt-

Re: [PATCH v2 2/2] qemu-nbd: Removed deprecated --partition option

2020-02-05 Thread Ján Tomko
On Thu, Jan 23, 2020 at 10:46:50AM -0600, Eric Blake wrote: The option was deprecated in 4.0.0 (commit 0ae2d546); it's now been long enough with no complaints to follow through with that process. Signed-off-by: Eric Blake --- docs/interop/qemu-nbd.rst | 15 ++--- qemu-deprecated.texi | 49

Re: [PATCH v2 1/2] docs: Fix typo in qemu-nbd -P replacement

2020-02-05 Thread Ján Tomko
On Thu, Jan 23, 2020 at 10:46:49AM -0600, Eric Blake wrote: The suggested replacement for the deprecated 'qemu-nbd -P' referw to s/referw/refer/ 'file.backing.opt' instead of 'file.file.opt'; using the example verbatim results in: qemu-nbd: Failed to blk_new_open 'driver=raw,offset=1m,size=

Re: [PATCH 1/5] ui: add show-cursor option

2020-02-05 Thread Eric Blake
On 2/5/20 5:03 AM, Gerd Hoffmann wrote: When enabled forces showing a the mouse cursor, i.e. do When enabled, this forces showing the mouse... nowallow the guest to hide it. Defaults to off. s/nowallow/not allow/ Signed-off-by: Gerd Hoffmann --- qapi/ui.json | 2 ++ 1 file changed,

Re: [PATCH v2 21/33] block: Drop child_format

2020-02-05 Thread Eric Blake
On 2/4/20 11:08 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- Sparse message, but the diffstat makes it obvious that it is ripping out now-unused code, so there's not much more to say. block.c | 29 - include/block/block_int.h | 1 - 2

Re: [PATCH v2 20/33] block: Switch child_format users to child_of_bds

2020-02-05 Thread Eric Blake
On 2/4/20 11:08 AM, Max Reitz wrote: Both users (quorum and blkverify) use child_format for not-really-filtered children, so the appropriate BdrvChildRole in both cases is DATA. (Note that this will cause bdrv_inherited_options() to force-allow format probing.) Signed-off-by: Max Reitz --- b

Re: [PATCH v2 19/33] raw-format: Split raw_read_options()

2020-02-05 Thread Eric Blake
On 2/4/20 11:08 AM, Max Reitz wrote: Split raw_read_options() into one function that actually just reads the options, and another that applies them. This will allow us to detect whether the user has specified any options before attaching the file child (so we can decide on its role based on the

Re: [PATCH v2 18/33] block: Add bdrv_default_perms()

2020-02-05 Thread Eric Blake
On 2/4/20 11:08 AM, Max Reitz wrote: This callback can be used by BDSs that use child_of_bds with the appropriate BdrvChildRole for their children. Also, make bdrv_format_default_perms() use it for child_of_bds children (just a temporary solution until we can drop bdrv_format_default_perms() alt

[PATCH v1 13/14] tests/vm: Added a new script for centos.aarch64.

2020-02-05 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm/centos.aarch64 | 221 ++

[PATCH v1 12/14] tests/vm: Added a new script for ubuntu.aarch64.

2020-02-05 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley --- tests/vm/Makefile.include | 3 +- tests/vm/aarch64vm.py

[PATCH v1 10/14] tests/vm: Add ability to select QEMU from current build.

2020-02-05 Thread Robert Foley
Added a new special variable QEMU_LOCAL=1, which will indicate to take the QEMU binary from the current build. Signed-off-by: Robert Foley --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 28 2 files changed, 28 insertions(+), 4 deletions(-) diff

[PATCH v1 14/14] tests/vm: change scripts to use self._config

2020-02-05 Thread Robert Foley
This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Robert Foley -

[PATCH v1 08/14] tests/vm: Added configuration file support

2020-02-05 Thread Robert Foley
Changes to tests/vm/basevm.py to allow accepting a configuration file as a parameter. Allows for specifying VM options such as cpu, machine, memory, and arbitrary qemu arguments for specifying options such as NUMA configuration. Also added an example conf_example_aarch64.yml and conf_example_x86.ym

[PATCH v1 11/14] tests/vm: allow wait_ssh() to specify command

2020-02-05 Thread Robert Foley
This allows for waiting for completion of arbitrary commands. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 97d55f8030..ebedbce4ae 100755 --- a/tests/vm/basevm.py

[PATCH v1 09/14] tests/vm: add --boot-console switch

2020-02-05 Thread Robert Foley
Added ability to view console during boot via --boot-console switch to basevm.py. This helps debug issues that occur during the boot sequence. Also added a new special variable to vm-build: BOOT_CONSOLE=1 will cause this new --boot-console switch to be set. Signed-off-by: Robert Foley --- tests/

[PATCH v1 06/14] tests/vm: Add logging of console to file.

2020-02-05 Thread Robert Foley
This adds logging of the char device used by the console to a file. The basevm.py then uses this file to read chars from the console. One reason to add this is to aid with debugging. But another is because there is an issue where the QEMU might hang if the characters from the character device are

[PATCH v1 04/14] tests/vm: give wait_ssh() option to wait for root

2020-02-05 Thread Robert Foley
Allow wait_ssh to wait for root user to be ready. This solves the issue where we perform a wait_ssh() successfully, but the root user is not yet ready to be logged in. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/t

[PATCH v1 07/14] tests/vm: Add configuration to basevm.py

2020-02-05 Thread Robert Foley
Added use of a configuration to tests/vm/basevm.py. The configuration provides parameters used to configure a VM. This allows for providing alternate configurations to the VM being created/launched. cpu, machine, memory, and NUMA configuration are all examples of configuration which we might want t

[PATCH v1 00/14] tests/vm: Add support for aarch64 VMs

2020-02-05 Thread Robert Foley
This is version 1 of the patch series to add support for 2 aarch64 VMs. - Ubuntu 18.04 aarch64 VM - CentOS 8 aarch64 VM Changes in version 1 - Added environment variable QEMU_LOCAL=1 which means use the appropriate QEMU binary from the current build. - Improved support of aarch64 VMs to be

[PATCH v1 02/14] tests/vm: Debug mode shows ssh output.

2020-02-05 Thread Robert Foley
Add changes to tests/vm/basevm.py so that during debug mode we show ssh output. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- tests/vm/basevm.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py

[PATCH v1 05/14] tests/vm: Added gen_cloud_init_iso() to basevm.py

2020-02-05 Thread Robert Foley
This method was located in both centos and ubuntu.i386. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 40 tests/vm/centos | 33 + tests/vm/ubuntu.i386 | 37 + 3 files change

[PATCH v1 01/14] tests/vm: use $(PYTHON) consistently

2020-02-05 Thread Robert Foley
Change Makefile.include to use $(PYTHON) so for vm-boot-ssh to be consistent with other cases like vm-build. Signed-off-by: Robert Foley --- tests/vm/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include index 9

[PATCH v1 03/14] tests/vm: increased max timeout for vm boot.

2020-02-05 Thread Robert Foley
Add change to increase timeout waiting for VM to boot. Needed for some emulation cases where it can take longer than 5 minutes to boot. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 9911

Re: [PATCH 0/9] linux-user: Update syscall numbers to kernel 5.5 level

2020-02-05 Thread Stafford Horne
On Tue, Feb 04, 2020 at 01:07:29PM +0100, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > This series also doesn't cover following files (since I can't find > corresponding kernel code - and I am also asking corresponding > target maintainers or Lauren to update them, if possible, befo

  1   2   3   4   >