On Thu, Feb 06, 2020 at 12:20:15AM +0100, Laurent Vivier wrote:
> qtest "rtas" command is only available with pseries not all ppc64 targets,
> so if I try to compile only powernv machine, the build fails with:
>
> /usr/bin/ld: qtest.o: in function `qtest_process_command':
> .../qtest.c:645: undefined reference to `qtest_rtas_call'
>
> We fix this by enabling rtas command only with pseries machine.
>
> Fixes: eeddd59f5962 ("tests: add RTAS command in the protocol")
> Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
> ---
> qtest.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/qtest.c b/qtest.c
> index 12432f99cf44..587dcbb4b515 100644
> --- a/qtest.c
> +++ b/qtest.c
> @@ -27,7 +27,8 @@
> #include "qemu/error-report.h"
> #include "qemu/module.h"
> #include "qemu/cutils.h"
> -#ifdef TARGET_PPC64
> +#include "config-devices.h"
> +#ifdef CONFIG_PSERIES
> #include "hw/ppc/spapr_rtas.h"
> #endif
>
> @@ -628,7 +629,7 @@ static void qtest_process_command(CharBackend *chr, gchar
> **words)
> #else
> qtest_sendf(chr, "OK little\n");
> #endif
> -#ifdef TARGET_PPC64
> +#ifdef CONFIG_PSERIES
> } else if (strcmp(words[0], "rtas") == 0) {
> uint64_t res, args, ret;
> unsigned long nargs, nret;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
