Re: [Qemu-devel] [PATCH v2 02/11] monitor: Split monitor_init in HMP and QMP function

2019-06-11 Thread Markus Armbruster
Markus Armbruster writes: [...] > Much clearer overall. Forgot: Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 01/11] monitor: Remove unused password prompting fields

2019-06-11 Thread Markus Armbruster
Kevin Wolf writes: > Commit 788cf9f8c removed the code for password prompting from the > monitor. Since then, the Monitor fields password_completion_cb and > password_opaque have been unused. Remove them. > > Signed-off-by: Kevin Wolf > Reviewed-by: Dr. David Alan Gilbert > --- > monitor.c | 2

Re: [Qemu-devel] [PATCH v12 2/7] virtio-pmem: Add virtio pmem driver

2019-06-11 Thread Cornelia Huck
Hi Pankaj, On Tue, 11 Jun 2019 23:34:50 -0400 (EDT) Pankaj Gupta wrote: > Hi Cornelia, > > > On Tue, 11 Jun 2019 22:07:57 +0530 > > Pankaj Gupta wrote: > > > + err1 = virtqueue_kick(vpmem->req_vq); > > > + spin_unlock_irqrestore(&vpmem->pmem_lock, flags); > > > + /* > > > + * virtqueue_add_

Re: [Qemu-devel] [RFC PATCH v4 5/5] target/ppc: support single stepping with KVM HV

2019-06-11 Thread Alexey Kardashevskiy
Are you reposting this any time soon? In meanwhile I hit a problem when I cannot step over the "stdu" instruction. I basically put this: stdur1,-368(r1) and "ni" in gdb does not stop on the next instruction which is quite confusing. Ideas? On 20/03/2019 12:42, Alexey Kardashevskiy wrote: >

Re: [Qemu-devel] spapr_pci: Advertise BAR reallocation capability

2019-06-11 Thread David Gibson
On Thu, Jun 06, 2019 at 02:09:19PM +1000, Alexey Kardashevskiy wrote: > The pseries guests do not normally allocate PCI resouces and rely on > the system firmware doing so. Furthermore at least at some point in > the past the pseries guests won't even be allowed to change BARs, probably > it is sti

Re: [Qemu-devel] [PATCH v2 02/11] monitor: Split monitor_init in HMP and QMP function

2019-06-11 Thread Markus Armbruster
Kevin Wolf writes: > Instead of mixing HMP and QMP monitors in the same function, separate > the monitor creation function for both. > > Signed-off-by: Kevin Wolf > Reviewed-by: Dr. David Alan Gilbert > --- > monitor.c | 86 +++ > 1 file chan

Re: [Qemu-devel] [PATCH qemu REPOST] spapr/rtas: Force big endian compile for rtas

2019-06-11 Thread David Gibson
On Wed, Jun 12, 2019 at 12:07:23PM +1000, Alexey Kardashevskiy wrote: > At the moment the rtas's Makefile uses generic QEMU rules which means > that when QEMU is compiled on a little endian system, the spapr-rtas.bin > is compiled as little endian too which is incorrect as it is always > executed i

[Qemu-devel] [PULL 06/13] spapr: Clean up spapr_drc_populate_dt()

2019-06-11 Thread David Gibson
This makes some minor cleanups to spapr_drc_populate_dt(), renaming it to the shorter and more idiomatic spapr_dt_drc() along the way. Signed-off-by: David Gibson Reviewed-by: Greg Kurz Acked-by: Michael S. Tsirkin --- hw/ppc/spapr.c | 7 +++ hw/ppc/spapr_drc.c | 13 ++

[Qemu-devel] [PULL 05/13] spapr: Clean up dt creation for PCI buses

2019-06-11 Thread David Gibson
Device nodes for PCI bridges (both host and P2P) describe both the bridge device itself and the bus hanging off it, handling of this is a bit of a mess. spapr_dt_pci_device() has a few things it only adds for non-bridges, but always adds #address-cells and #size-cells which should only appear for

[Qemu-devel] [PULL 10/13] spapr: Allow hot plug/unplug of PCI bridges and devices under PCI bridges

2019-06-11 Thread David Gibson
The pseries machine type already allows PCI hotplug and unplug via the PAPR mechanism, but only on the root bus of each PHB. This patch extends this to allow PCI to PCI bridges to be hotplugged, and devices to be hotplugged or unplugged under P2P bridges. For now we disallow hot unplugging P2P br

[Qemu-devel] [PULL 04/13] spapr: Clean up device tree construction for PCI devices

2019-06-11 Thread David Gibson
spapr_create_pci_child_dt() is a trivial wrapper around spapr_populate_pci_child_dt(), but is the latter's only caller. So fold them together into spapr_dt_pci_device(), which closer matches our modern naming convention. While there, make a number of cleanups to the function itself. This is most

[Qemu-devel] [PULL 12/13] ppc/pnv: activate the "dumpdtb" option on the powernv machine

2019-06-11 Thread David Gibson
From: Cédric Le Goater This is a good way to debug the DT creation for current PowerNV machines and new ones to come. Signed-off-by: Cédric Le Goater Message-Id: <20190606174732.13051-1-...@kaod.org> Reviewed-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/pnv.c | 2 ++ 1 file changed,

[Qemu-devel] [PULL 13/13] ppc/xive: Make XIVE generate the proper interrupt types

2019-06-11 Thread David Gibson
From: Benjamin Herrenschmidt It should be generic Hypervisor Virtualization interrupts for HV directed rings and traditional External Interrupts for the OS directed ring. Don't generate anything for the user ring as it isn't actually supported. Signed-off-by: Benjamin Herrenschmidt Signed-off-

[Qemu-devel] [PULL 01/13] spapr_pci: Improve error message

2019-06-11 Thread David Gibson
From: Greg Kurz Every PHB must have a unique index. This is checked at realize but when a duplicate index is detected, an error message mentioning BUIDs is printed. This doesn't help much, especially since BUID is an internal concept that is no longer exposed to the user. Fix the message to ment

[Qemu-devel] [PULL 09/13] spapr: Direct all PCI hotplug to host bridge, rather than P2P bridge

2019-06-11 Thread David Gibson
A P2P bridge will attempt to handle the hotplug with SHPC, which doesn't work in the PAPR environment. Instead we want to direct all PCI hotplug actions to the PAPR specific host bridge which will use the PAPR hotplug mechanism. Signed-off-by: David Gibson Acked-by: Michael S. Tsirkin --- hw/p

[Qemu-devel] [PULL 08/13] spapr: Don't use bus number for building DRC ids

2019-06-11 Thread David Gibson
DRC ids are more or less arbitrary, as long as they're consistent. For PCI, we notionally build them from the phb's index along with PCI bus number, slot and function number. Using bus number is broken, however, because it can change if the guest re-enumerates the PCI topology for whatever reason

[Qemu-devel] [PULL 07/13] spapr: Clean up DRC index construction

2019-06-11 Thread David Gibson
spapr_pci.c currently has several confusingly similarly named functions for various conversions between representations of DRCs. Make things clearer by renaming things in a more consistent XXX_from_YYY() manner and remove some called-only-once variants in favour of open coding. While we're at it,

[Qemu-devel] [PULL 00/13] ppc-for-4.1 queue 20190612

2019-06-11 Thread David Gibson
The following changes since commit 219dca61ebf41625831d4f96a720852baf44b762: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2019-06-11 16:02:07 +0100) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-4.1-2019061

[Qemu-devel] [PULL 11/13] target/ppc: Use tcg_gen_gvec_bitsel

2019-06-11 Thread David Gibson
From: Richard Henderson Replace the target-specific implementation of XXSEL. Signed-off-by: Richard Henderson Message-Id: <20190603164927.8336-1-richard.hender...@linaro.org> Signed-off-by: David Gibson --- target/ppc/translate/vsx-impl.inc.c | 24 ++-- 1 file changed, 2 i

[Qemu-devel] [PULL 02/13] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-06-11 Thread David Gibson
From: Anton Blanchard During the conversion these instructions were incorrectly treated as stores. We need to use set_cpu_vsr* and not get_cpu_vsr*. Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}() helpers for VSR register access") Signed-off-by: Anton Blanchard Review

[Qemu-devel] [PULL 03/13] spapr: Clean up device node name generation for PCI devices

2019-06-11 Thread David Gibson
spapr_populate_pci_child_dt() adds a 'name' property to the device tree node for PCI devices. This is never necessary for a flattened device tree, it is implicit in the name added when the node is constructed. In fact anything we do add to a 'name' property will be overwritten with something deri

Re: [Qemu-devel] [PATCH 3/5] tricore: fix RRPW_INSERT instruction

2019-06-11 Thread Brenken, David (EFS-GH2)
Thank you for your hint. Would anyone mind, if keep my insert implementation anyway? If I compare the pseudo code of the instruction manual to the insert implementation it looks nearly the same whereas it seems kind of difficult to directly map the pseudo code of the instruction manual to the gen

Re: [Qemu-devel] [PATCH v2 04/15] target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions

2019-06-11 Thread David Gibson
On Tue, Jun 11, 2019 at 09:22:15PM -0700, Richard Henderson wrote: > On 6/11/19 6:52 PM, David Gibson wrote: > > On Sun, Jun 02, 2019 at 12:08:52PM +0100, Mark Cave-Ayland wrote: > >> Rather than perform the VSR register decoding within the helper itself, > >> introduce a new VSX_CMP macro which pe

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] spapr: Do not re-read the clock on pre_save handler on migration

2019-06-11 Thread David Gibson
On Wed, Jun 05, 2019 at 04:39:27PM -0300, Maxiwell S. Garcia wrote: > On Thu, May 30, 2019 at 11:13:41AM +1000, David Gibson wrote: > > On Thu, May 23, 2019 at 05:18:51PM -0300, Maxiwell S. Garcia wrote: > > > On Thu, May 23, 2019 at 09:29:52AM +1000, David Gibson wrote: > > > > On Mon, May 20, 201

Re: [Qemu-devel] [PATCH v2] hw: misc: Add Aspeed XDMA device

2019-06-11 Thread Markus Armbruster
Nitpicking your subject: "hw/misc:" like the directory, please. You could even use the file, like "hw/misc/aspeed_xdma: New device".

Re: [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-11 Thread Ramon Fried
On Tue, Jun 11, 2019 at 7:21 PM Laurent Vivier wrote: > Le 11/06/2019 à 16:55, Ramon Fried a écrit : > > defining CADENCE_GEM_ERR_DEBUG causes compilation > > errors, fix that. > > > > Signed-off-by: Ramon Fried > > --- > > v2: change %lx to HWADDR_PRIx and %lx to %zdx > > HWADDR_PRIx is to use

Re: [Qemu-devel] [PATCH v2 04/15] target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions

2019-06-11 Thread Richard Henderson
On 6/11/19 6:52 PM, David Gibson wrote: > On Sun, Jun 02, 2019 at 12:08:52PM +0100, Mark Cave-Ayland wrote: >> Rather than perform the VSR register decoding within the helper itself, >> introduce a new VSX_CMP macro which performs the decode based upon xT, xA >> and xB at translation time. >> >> Su

Re: [Qemu-devel] [PATCH v12 2/7] virtio-pmem: Add virtio pmem driver

2019-06-11 Thread Pankaj Gupta
Hi Cornelia, > On Tue, 11 Jun 2019 22:07:57 +0530 > Pankaj Gupta wrote: > > > This patch adds virtio-pmem driver for KVM guest. > > > > Guest reads the persistent memory range information from > > Qemu over VIRTIO and registers it on nvdimm_bus. It also > > creates a nd_region object with the

Re: [Qemu-devel] [PATCH v12 4/7] dm: enable synchronous dax

2019-06-11 Thread Pankaj Gupta
> On Tue, Jun 11 2019 at 12:37pm -0400, > Pankaj Gupta wrote: > > > This patch sets dax device 'DAXDEV_SYNC' flag if all the target > > devices of device mapper support synchrononous DAX. If device > > mapper consists of both synchronous and asynchronous dax devices, > > we don't set 'DAXDEV_SY

Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature

2019-06-11 Thread Tiwei Bie
On Tue, Jun 11, 2019 at 03:22:47PM +0800, Jason Wang wrote: > > On 2019/6/11 下午2:51, Tiwei Bie wrote: > > The VIRTIO_NET_F_CTRL_VLAN feature requires the support of > > vhost-user backend. But it will be advertised to guest driver > > as long as it's enabled by users in QEMU, while it's not > > su

Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature

2019-06-11 Thread Tiwei Bie
On Tue, Jun 11, 2019 at 10:10:14AM -0400, Michael S. Tsirkin wrote: > On Tue, Jun 11, 2019 at 02:51:37PM +0800, Tiwei Bie wrote: > > The VIRTIO_NET_F_CTRL_VLAN feature requires the support of > > vhost-user backend. But it will be advertised to guest driver > > as long as it's enabled by users in Q

[Qemu-devel] [PATCH qemu REPOST] spapr/rtas: Force big endian compile for rtas

2019-06-11 Thread Alexey Kardashevskiy
At the moment the rtas's Makefile uses generic QEMU rules which means that when QEMU is compiled on a little endian system, the spapr-rtas.bin is compiled as little endian too which is incorrect as it is always executed in big endian mode. This enforces -mbig by defining %.o:%.S rule as spapr-rtas

Re: [Qemu-devel] [PATCH] spapr: Don't use the "dual" interrupt controller mode with an old hypervisor

2019-06-11 Thread David Gibson
On Fri, Jun 07, 2019 at 11:49:50AM +0200, Greg Kurz wrote: 65;5603;1c> On Fri, 7 Jun 2019 10:17:58 +0200 > Cédric Le Goater wrote: > > > On 07/06/2019 02:19, David Gibson wrote: > > > On Thu, Jun 06, 2019 at 07:08:59PM +0200, Greg Kurz wrote: > > >> If KVM is too old to support XIVE native expl

Re: [Qemu-devel] [PATCH v2 04/15] target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions

2019-06-11 Thread David Gibson
On Sun, Jun 02, 2019 at 12:08:52PM +0100, Mark Cave-Ayland wrote: > Rather than perform the VSR register decoding within the helper itself, > introduce a new VSX_CMP macro which performs the decode based upon xT, xA > and xB at translation time. > > Subsequent commits will make the same changes fo

Re: [Qemu-devel] [PATCH 06/19] aspeed: introduce a configurable number of CPU per machine

2019-06-11 Thread Joel Stanley
On Sat, 25 May 2019 at 15:13, Cédric Le Goater wrote: > > The current models of the Aspeed SoCs only have one CPU but future > ones will support SMP. Introduce a way to configure the maximum number > of CPU per machine. SMP support will be activated when models for such > SoCs are implemented. > >

Re: [Qemu-devel] [PATCH 14/19] aspeed: remove the "ram" link

2019-06-11 Thread Joel Stanley
On Sat, 25 May 2019 at 15:14, Cédric Le Goater wrote: > > It has never been used as far as I can tell from the git history. > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley

Re: [Qemu-devel] [PATCH 13/19] aspeed/smc: add a 'sdram_base' propertie

2019-06-11 Thread Joel Stanley
On Sat, 25 May 2019 at 15:14, Cédric Le Goater wrote: > > The DRAM address of a DMA transaction depends on the DRAM base address > of the SoC. Inform the SMC controller model of this value. > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley Nit: s/propertie/property/ in the patch su

Re: [Qemu-devel] [PATCH 16/19] aspeed/smc: add support for DMAs

2019-06-11 Thread Joel Stanley
On Sat, 25 May 2019 at 15:14, Cédric Le Goater wrote: > > The FMC controller on the Aspeed SoCs support DMA to access the flash > modules. It can operate in a normal mode, to copy to or from the flash > module mapping window, or in a checksum calculation mode, to evaluate > the best clock settings

[Qemu-devel] [Bug 1832422] [NEW] SSE CMP ops with 8bit immediate throw sigill with oversized byte

2019-06-11 Thread sonicadvan...@gmail.com
Public bug reported: The SSE comparison ops that use an 8bit immediate as a comparison type selector throws a sigill when the immediate is oversized. Test op that I found this on is here `66 0f c2 c0 d1 cmppd xmm0,xmm0,0xd1` According to the x86-64 documentation only bits [2:0] are use

Re: [Qemu-devel] [PATCH 15/19] aspeed: add a RAM memory region container

2019-06-11 Thread Joel Stanley
On Sat, 25 May 2019 at 15:14, Cédric Le Goater wrote: > > The RAM memory region is defined after the SoC is realized when the > SDMC controller has cheched that the defined RAM size for the machine checked > is correct. This is problematic for controller models requiring a link > on the RAM regi

Re: [Qemu-devel] [PATCH 18/19] aspeed/smc: inject errors in DMA checksum

2019-06-11 Thread Joel Stanley
On Sat, 25 May 2019 at 15:14, Cédric Le Goater wrote: > > Emulate read errors in the DMA Checksum Register for high frequencies > and optimistic settings of the Read Timing Compensation Register. This > will help in tuning the SPI timing calibration algorithm. > > The values below are those to exp

Re: [Qemu-devel] [PATCH 17/19] aspeed/smc: add DMA calibration settings

2019-06-11 Thread Joel Stanley
On Sat, 25 May 2019 at 15:14, Cédric Le Goater wrote: > > When doing calibration, the SPI clock rate in the CE0 Control Register > and the read delay cycles in the Read Timing Compensation Register are > set using bit[11:4] of the DMA Control Register. > > Signed-off-by: Cédric Le Goater Acked-b

Re: [Qemu-devel] [PATCH 19/19] aspeed/smc: Calculate checksum on normal DMA

2019-06-11 Thread Joel Stanley
On Sat, 25 May 2019 at 15:15, Cédric Le Goater wrote: > > From: Christian Svensson > > This patch adds the missing checksum calculation on normal DMA transfer. > According to the datasheet this is how the SMC should behave. > > Verified on AST1250 that the hardware matches the behaviour. > > Sign

[Qemu-devel] [PATCH] migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS

2019-06-11 Thread Wei Yang
On receiving RAM_SAVE_FLAG_EOS, multifd_recv_sync_main() is called to synchronize receive threads. Current synchronization mechanism is to wait for each channel's sem_sync semaphore. This semaphore is triggered by a packet with MULTIFD_FLAG_SYNC flag. While in current implementation, we don't do mu

Re: [Qemu-devel] [PATCH 2/2] migration/xbzrle: make xbzrle_encode_buffer little easier to read

2019-06-11 Thread Wei Yang
On Tue, Jun 11, 2019 at 06:59:26PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> The encoding process could be described below: >> >> for [content] >> get length of a run >> encode this run >> >> By refactoring the code with this lo

Re: [Qemu-devel] [PATCH qemu] spapr/rtas: Force big endian compile for rtas

2019-06-11 Thread David Gibson
On Wed, Jun 12, 2019 at 10:29:55AM +1000, Alexey Kardashevskiy wrote: > > > On 14/02/2019 14:30, David Gibson wrote: > > On Wed, Feb 13, 2019 at 05:00:50PM +1100, Alexey Kardashevskiy wrote: > >> > >> > >> On 01/02/2019 11:40, Alexey Kardashevskiy wrote: > >>> At the moment the rtas's Makefile us

Re: [Qemu-devel] [PATCH v2 02/15] target/ppc: remove getVSR()/putVSR() from mem_helper.c

2019-06-11 Thread David Gibson
On Sun, Jun 02, 2019 at 12:08:50PM +0100, Mark Cave-Ayland wrote: > Since commit 8a14d31b00 "target/ppc: switch fpr/vsrl registers so all VSX > registers are in host endian order" functions getVSR() and putVSR() which used > to convert the VSR registers into host endian order are no longer required

[Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs

2019-06-11 Thread Raphael Norwitz
Of the 3 virtqueues, seabios only sets cmd, leaving ctrl and event without a physical address. This can cause vhost_verify_ring_part_mapping to return ENOMEM, causing the following logs: qemu-system-x86_64: Unable to map available ring for ring 0 qemu-system-x86_64: Verify ring failure on region 0

Re: [Qemu-devel] [PATCH 2/2] migration/xbzrle: make xbzrle_encode_buffer little easier to read

2019-06-11 Thread Wei Yang
On Tue, Jun 11, 2019 at 06:59:26PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> The encoding process could be described below: >> >> for [content] >> get length of a run >> encode this run >> >> By refactoring the code with this lo

Re: [Qemu-devel] [PATCH qemu] spapr/rtas: Force big endian compile for rtas

2019-06-11 Thread Alexey Kardashevskiy
On 14/02/2019 14:30, David Gibson wrote: > On Wed, Feb 13, 2019 at 05:00:50PM +1100, Alexey Kardashevskiy wrote: >> >> >> On 01/02/2019 11:40, Alexey Kardashevskiy wrote: >>> At the moment the rtas's Makefile uses generic QEMU rules which means >>> that when QEMU is compiled on a little endian s

Re: [Qemu-devel] [PATCH 1/2] cutils: remove one unnecessary pointer operation

2019-06-11 Thread Wei Yang
On Tue, Jun 11, 2019 at 06:49:54PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> Since we will not operate on the next address pointed by out, it is not >> necessary to do addition on it. >> >> After removing the operation, the function size reduced 16/

Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks

2019-06-11 Thread Eduardo Habkost
On Fri, Jun 07, 2019 at 02:45:01PM +0200, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 07/06/19 10:25, Markus Armbruster wrote: > >> Paolo Bonzini writes: > >> > >>> On 23/05/19 18:14, Markus Armbruster wrote: > * Machine core (Eduardo, Marcel) > > query-machines,

[Qemu-devel] [PATCH v2] hw: misc: Add Aspeed XDMA device

2019-06-11 Thread Eddie James
The XDMA engine embedded in the Aspeed SOCs performs PCI DMA operations between the SOC (acting as a BMC) and a host processor in a server. The XDMA engine exists on the AST2400, AST2500, and AST2600 SOCs, so enable it for all of those. Add trace events on the important register writes in the XDMA

[Qemu-devel] [PATCH] i386: Don't print warning if phys-bits was set automatically

2019-06-11 Thread Eduardo Habkost
If cpu->host_phys_bits_limit is set, QEMU will make cpu->phys_bits be lower than host_phys_bits on some cases. This triggers a warning that was supposed to be printed only if phys-bits was explicitly set in the command-line. Reorder the code so the value of cpu->phys_bits is validated before the

Re: [Qemu-devel] [PATCH 00/13] linux-user: path, clone, sparc, shmat fixes

2019-06-11 Thread Richard Henderson
Laurent has merged the final two patches, but ping for the first 11. I see there are trivial patch conflicts with master, but I'd rather respin with substantive review if possible. r~ On 5/19/19 1:19 PM, Richard Henderson wrote: > This is an omnibus patchset of: > > v2: util/path: Do not ca

Re: [Qemu-devel] [PATCH 1/2] Implement Floating Point flag Fraction Rounded

2019-06-11 Thread Richard Henderson
On 5/24/19 7:20 PM, John Arbuckle wrote: > Signed-off-by: John Arbuckle > --- > fpu/softfloat.c | 15 --- > include/fpu/softfloat-types.h | 1 + > 2 files changed, 13 insertions(+), 3 deletions(-) There are additional places that need changing within this file, even if

Re: [Qemu-devel] [PATCH v21 4/7] target/avr: Add instruction translation

2019-06-11 Thread Michael Rolnik
I am using this one https://github.com/seharris/qemu-avr-tests/blob/master/free-rtos/Demo /AVR_ATMega2560_GCC/demo.elf it fails within __divmodsi4 function, there is rcall right after sbrc. Thanks for helping. On Tue, Jun 11, 2019 at 11:47 PM Richard Henderson < richard.hender...@linaro.org> wrot

Re: [Qemu-devel] [PATCH v21 4/7] target/avr: Add instruction translation

2019-06-11 Thread Richard Henderson
On 6/11/19 1:21 PM, Michael Rolnik wrote: > I merged all you fixes and I get an assert(use_icount) in cpu_loop_exec_tb > function, it happens on an instruction following SBRC. > what might cause it? No idea. What is your test case? And your tree, just in case there was an error in the merging.

Re: [Qemu-devel] [PATCH v21 4/7] target/avr: Add instruction translation

2019-06-11 Thread Michael Rolnik
Hi Richard. I merged all you fixes and I get an assert(use_icount) in cpu_loop_exec_tb function, it happens on an instruction following SBRC. what might cause it? On Tue, Jun 11, 2019 at 12:20 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 6/6/19 12:30 PM, Michael Rolnik wrote:

Re: [Qemu-devel] [PATCH v3] vfio/common: Introduce vfio_set_irq_signaling helper

2019-06-11 Thread Alex Williamson
On Tue, 11 Jun 2019 17:47:25 +0200 Eric Auger wrote: > The code used to assign an interrupt index/subindex to an > eventfd is duplicated many times. Let's introduce an helper that > allows to set/unset the signaling for an ACTION_TRIGGER, > ACTION_MASK or ACTION_UNMASK action. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v5] vfio-ccw: support async command subregion

2019-06-11 Thread Farhan Ali
On 06/11/2019 07:37 AM, Cornelia Huck wrote: On Fri, 7 Jun 2019 11:19:09 -0400 Farhan Ali wrote: On 06/07/2019 11:09 AM, Cornelia Huck wrote: On Fri, 7 Jun 2019 11:02:36 -0400 Farhan Ali wrote: On 06/07/2019 10:53 AM, Cornelia Huck wrote: diff --git a/hw/s390x/css.c b/hw/s390x/css

Re: [Qemu-devel] [PATCH v5] vfio-ccw: support async command subregion

2019-06-11 Thread Farhan Ali
On 06/07/2019 10:53 AM, Cornelia Huck wrote: A vfio-ccw device may provide an async command subregion for issuing halt/clear subchannel requests. If it is present, use it for sending halt/clear request to the device; if not, fall back to emulation (as done today). Signed-off-by: Cornelia Huck

[Qemu-devel] [PULL v2 00/12] Miscellaneous patches for 2019-06-11

2019-06-11 Thread Markus Armbruster
The following changes since commit a578cdfbdd8f9beff5ced52b7826ddb1669abbbf: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190610' into staging (2019-06-10 16:09:19 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-misc-2019-06-11-v2 for

[Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

2019-06-11 Thread Andrey Shinkevich
The Valgrind tool reports about an uninitialised memory usage when the initialization is actually not needed. For example, the buffer 'buf' instantiated on a stack of the function guess_disk_lchs(). Let's use the Valgrind technology to suppress the unwanted reports by adding the Valgrind specific f

[Qemu-devel] [PATCH v2 4/7] iotests: extended timeout under Valgrind

2019-06-11 Thread Andrey Shinkevich
As the iotests run longer under the Valgrind, the QEMU_COMM_TIMEOUT is to be increased in the test cases 028, 183 and 192 when running under the Valgrind. Suggested-by: Roman Kagan Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/028 | 6 +- tests/qemu-iotests/183 | 9 - test

[Qemu-devel] [PATCH v2 5/7] iotests: extend sleeping time under Valgrind

2019-06-11 Thread Andrey Shinkevich
To synchronize the time when QEMU is running longer under the Valgrind, increase the sleeping time int the test 247. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/247 | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/247 b/tests/qemu-iotests/24

[Qemu-devel] [PATCH v2 2/7] iotests: exclude killed processes from running under Valgrind

2019-06-11 Thread Andrey Shinkevich
The Valgrind tool fails to manage its termination when QEMU raises the signal SIGKILL. Lets exclude such test cases from running under the Valgrind because there is no sense to check memory issues that way. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/039 | 5 + tests/qemu-iotests

[Qemu-devel] [PATCH v2 1/7] iotests: allow Valgrind checking all QEMU processes

2019-06-11 Thread Andrey Shinkevich
With the '-valgrind' option, let all the QEMU processes be run under the Valgrind tool. The Valgrind own parameters may be set with its environment variable VALGRIND_OPTS, e.g. VALGRIND_OPTS="--leak-check=yes" ./check -qcow2 -valgrind or they may be listed in the Valgrind checked file ./.valgrindr

[Qemu-devel] [PATCH v2 0/7] Allow Valgrind checking all QEMU processes

2019-06-11 Thread Andrey Shinkevich
In the current implementation of the QEMU bash iotests, only qemu-io processes may be run under the Valgrind, which is a useful tool for finding memory usage issues. Let's allow the common.rc bash script runing all the QEMU processes, such as qemu-kvm, qemu-img, qemu-ndb and qemu-vxhs, under the Va

[Qemu-devel] [PATCH v2 3/7] iotests: Valgrind fails to work with nonexistent directory

2019-06-11 Thread Andrey Shinkevich
The Valgrind uses the exported variable TMPDIR and fails if the directory does not exist. Let us exclude such a test case from being run under the Valgrind. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/051 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/051 b/te

[Qemu-devel] [PATCH v2 6/7] iotests: amend QEMU NBD process synchronization

2019-06-11 Thread Andrey Shinkevich
Processes are dying harder under the Valgring. It results in counting the dying process as a newborn one. Make it sure that old NBD job get finished before starting a new one. Suggested-by: Roman Kagan Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/common.nbd | 6 ++ 1 file changed

Re: [Qemu-devel] [PATCH 2/2] migration/xbzrle: make xbzrle_encode_buffer little easier to read

2019-06-11 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > The encoding process could be described below: > > for [content] > get length of a run > encode this run > > By refactoring the code with this logic, it maybe a little easier to > understand. > > Signed-off-by: Wei Yang > -

Re: [Qemu-devel] [PATCH 1/2] cutils: remove one unnecessary pointer operation

2019-06-11 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > Since we will not operate on the next address pointed by out, it is not > necessary to do addition on it. > > After removing the operation, the function size reduced 16/18 bytes. For me with a -O3 it didn't make any difference - the compiler was

Re: [Qemu-devel] Sketch of a transition of QEMU docs to Sphinx

2019-06-11 Thread John Snow
On 6/11/19 3:29 AM, Markus Armbruster wrote: > Peter Maydell writes: > >> On Tue, 21 May 2019 at 19:56, Peter Maydell wrote: >>> >>> Currently we have a vague plan that we should migrate our >>> documentation away from Texinfo to using Sphinx, plus some isolated >>> bits of documentation alre

[Qemu-devel] [RFC] virtio-rng: add a watchdog

2019-06-11 Thread Laurent Vivier
The virtio-rng linux driver can be stuck in virtio_read() on a wait_for_completion_killable() call if the virtio-rng device in QEMU doesn't provide data. It's a problem, because virtio_read() is called from rng_get_data() with reading_mutex() held. The same mutex is taken by add_early_randomness(

[Qemu-devel] [PULL 5/6] BootLinuxConsoleTest: Run kerneltests BusyBox on Malta

2019-06-11 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé This tests boots a Linux kernel on a Malta machine up to a busybox shell on the serial console. Few commands are executed before halting the machine (via reboot). We use the initrd cpio image from the kerneltests project: https://kerneltests.org/ If MIPS is a target

[Qemu-devel] [PULL 2/6] BootLinuxConsoleTest: Do not log empty lines

2019-06-11 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Avoid to log empty lines in console debug logs. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190520220635.10961-2-f4...@amsat.org> Reviewed-by: Alistair Francis Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Acked-by: Aleksandar Markovic Signed-off-by:

[Qemu-devel] [PULL 6/6] travis: Make check-acceptance job more verbose

2019-06-11 Thread Eduardo Habkost
It will help us debug issues when tests fail. Signed-off-by: Eduardo Habkost --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index b053a836a3..a08a7b7278 100644 --- a/.travis.yml +++ b/.travis.yml @@ -225,7 +225,7 @@ matrix: # Ac

[Qemu-devel] [PULL 1/6] tests/boot_linux_console: Let extract_from_deb handle various compressions

2019-06-11 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Debian binary package format supports various compressions. Per man deb(5): NAME deb - Debian binary package format FORMAT ... The third, last required member is named data.tar. It contains the filesystem as a tar archive, either not compressed

[Qemu-devel] [PULL 3/6] BootLinuxConsoleTest: Test the SmartFusion2 board

2019-06-11 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Similar to the x86_64/pc test, it boots a Linux kernel on an Emcraft board and verify the serial is working. If ARM is a target being built, "make check-acceptance" will automatically include this test by the use of the "arch:arm" tags. Alternatively, this test can

[Qemu-devel] [PULL 4/6] BootLinuxConsoleTest: Test nanoMIPS kernels on the I7200 CPU

2019-06-11 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Similar to the x86_64/pc test, it boots a Linux kernel on a Malta machine and verify the serial is working. Use the documentation added in commit f7d257cb4a17 to test nanoMIPS kernels and the I7200 CPU. This test can be run using: $ avocado --show=console run -t

[Qemu-devel] [PULL 0/6] Python queue, 2019-06-11

2019-06-11 Thread Eduardo Habkost
Changes from 2019-06-07: Python 2 deprecation and Python 3 check for 3.5+ were removed. The following changes since commit 219dca61ebf41625831d4f96a720852baf44b762: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2019-06-11 16:02:07 +0100) are availabl

Re: [Qemu-devel] [PATCH v12 4/7] dm: enable synchronous dax

2019-06-11 Thread Mike Snitzer
On Tue, Jun 11 2019 at 12:37pm -0400, Pankaj Gupta wrote: > This patch sets dax device 'DAXDEV_SYNC' flag if all the target > devices of device mapper support synchrononous DAX. If device > mapper consists of both synchronous and asynchronous dax devices, > we don't set 'DAXDEV_SYNC' flag. > > '

[Qemu-devel] [PATCH v12 1/7] libnvdimm: nd_region flush callback support

2019-06-11 Thread Pankaj Gupta
This patch adds functionality to perform flush from guest to host over VIRTIO. We are registering a callback based on 'nd_region' type. virtio_pmem driver requires this special flush function. For rest of the region types we are registering existing flush function. Report error returned by host fsy

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

2019-06-11 Thread Eduardo Habkost
On Tue, Jun 11, 2019 at 05:07:55PM +0100, Peter Maydell wrote: > On Tue, 11 Jun 2019 at 17:03, Eduardo Habkost wrote: > > > > On Tue, Jun 11, 2019 at 04:50:34PM +0100, Peter Maydell wrote: > > > On Mon, 10 Jun 2019 at 13:58, Peter Maydell > > > wrote: > > > > Hi. This fails to build on one of my

Re: [Qemu-devel] [PATCH v12 2/7] virtio-pmem: Add virtio pmem driver

2019-06-11 Thread Cornelia Huck
On Tue, 11 Jun 2019 22:07:57 +0530 Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range infor

Re: [Qemu-devel] [PATCH v3 8/8] multifd: rest of zlib compression

2019-06-11 Thread Juan Quintela
Wei Yang wrote: > On Wed, May 15, 2019 at 02:15:44PM +0200, Juan Quintela wrote: >>This is still a work in progress, but get everything sent as expected >>and it is faster than the code that is already there. > > Generally, I prefer to merge this one with previous one. Done, sir O:-) For the WIP

[Qemu-devel] [PATCH v12 7/7] xfs: disable map_sync for async flush

2019-06-11 Thread Pankaj Gupta
Dont support 'MAP_SYNC' with non-DAX files and DAX files with asynchronous dax_device. Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and xfs. Signed-off-by: Pankaj Gupta Reviewed-by: Darrick J. Wong --- fs/xfs/xfs_file.c | 9

[Qemu-devel] [PATCH v12 0/7] virtio pmem driver

2019-06-11 Thread Pankaj Gupta
This patch series is ready to be merged via nvdimm tree as discussed with Dan. We have ack/review on XFS, EXT4 & VIRTIO patches. Device mapper change is also reviewed. Mike, Can you please provide ack for device mapper change i.e patch4. This version has changed implementation for patch 4

[Qemu-devel] [PATCH v12 3/7] libnvdimm: add dax_dev sync flag

2019-06-11 Thread Pankaj Gupta
This patch adds 'DAXDEV_SYNC' flag which is set for nd_region doing synchronous flush. This later is used to disable MAP_SYNC functionality for ext4 & xfs filesystem for devices don't support synchronous flush. Signed-off-by: Pankaj Gupta --- drivers/dax/bus.c| 2 +- drivers/dax/sup

[Qemu-devel] [PATCH v12 2/7] virtio-pmem: Add virtio pmem driver

2019-06-11 Thread Pankaj Gupta
This patch adds virtio-pmem driver for KVM guest. Guest reads the persistent memory range information from Qemu over VIRTIO and registers it on nvdimm_bus. It also creates a nd_region object with the persistent memory range information so that existing 'nvdimm/pmem' driver can reserve this into sy

[Qemu-devel] [PATCH v12 4/7] dm: enable synchronous dax

2019-06-11 Thread Pankaj Gupta
This patch sets dax device 'DAXDEV_SYNC' flag if all the target devices of device mapper support synchrononous DAX. If device mapper consists of both synchronous and asynchronous dax devices, we don't set 'DAXDEV_SYNC' flag. 'dm_table_supports_dax' is refactored to pass 'iterate_devices_fn' as arg

[Qemu-devel] [PATCH v12 5/7] dax: check synchronous mapping is supported

2019-06-11 Thread Pankaj Gupta
This patch introduces 'daxdev_mapping_supported' helper which checks if 'MAP_SYNC' is supported with filesystem mapping. It also checks if corresponding dax_device is synchronous. Virtio pmem device is asynchronous and does not not support VM_SYNC. Suggested-by: Jan Kara Signed-off-by: Pankaj Gup

Re: [Qemu-devel] [PATCH v3 7/8] multifd: Add zlib compression support

2019-06-11 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> --- >> hw/core/qdev-properties.c | 2 +- >> migration/migration.c | 9 >> migration/migration.h | 1 + >> migration/ram.c | 47 +

[Qemu-devel] [PATCH v12 6/7] ext4: disable map_sync for async flush

2019-06-11 Thread Pankaj Gupta
Dont support 'MAP_SYNC' with non-DAX files and DAX files with asynchronous dax_device. Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and ext4. Signed-off-by: Pankaj Gupta Reviewed-by: Jan Kara --- fs/ext4/file.c | 10 ++

Re: [Qemu-devel] [PULL 00/12] Miscellaneous patches for 2019-06-11

2019-06-11 Thread Peter Maydell
On Tue, 11 Jun 2019 at 17:37, Peter Maydell wrote: > > On Tue, 11 Jun 2019 at 16:44, Markus Armbruster wrote: > > > > The following changes since commit a578cdfbdd8f9beff5ced52b7826ddb1669abbbf: > > > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190610' into > > staging (2019-06

Re: [Qemu-devel] [PATCH v3 7/8] multifd: Add zlib compression support

2019-06-11 Thread Juan Quintela
Wei Yang wrote: > On Wed, May 15, 2019 at 02:15:43PM +0200, Juan Quintela wrote: >> >> #define MULTIFD_FLAG_SYNC (1 << 0) >>+#define MULTIFD_FLAG_ZLIB (1 << 1) >> > > If no one use this in this patch, prefer to put it where it will be used. Oops, you are right, I have to use it. >>@@ -1253,6

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

2019-06-11 Thread Peter Maydell
On Tue, 11 Jun 2019 at 17:03, Eduardo Habkost wrote: > > On Tue, Jun 11, 2019 at 04:50:34PM +0100, Peter Maydell wrote: > > On Mon, 10 Jun 2019 at 13:58, Peter Maydell > > wrote: > > > Hi. This fails to build on one of my buildtest machines: > > > > > > ERROR: Cannot use 'python3', Python 2 >= 2

Re: [Qemu-devel] [PULL 00/12] Miscellaneous patches for 2019-06-11

2019-06-11 Thread Peter Maydell
On Tue, 11 Jun 2019 at 16:44, Markus Armbruster wrote: > > The following changes since commit a578cdfbdd8f9beff5ced52b7826ddb1669abbbf: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190610' into > staging (2019-06-10 16:09:19 +0100) > > are available in the Git repository at: >

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

2019-06-11 Thread Peter Maydell
On Mon, 10 Jun 2019 at 13:58, Peter Maydell wrote: > Hi. This fails to build on one of my buildtest machines: > > ERROR: Cannot use 'python3', Python 2 >= 2.7 or Python 3 >= 3.5 is required. >Use --python=/path/to/python to specify a supported Python. > > The machine has python 2.7.6 and 3

  1   2   3   >