[Qemu-devel] [PATCH v2 1/2] linux-user: Add ELF_PLATFORM for arm

2019-02-11 Thread Richard Henderson
The 32-bit kernel has strings for v4, v5, v6, v7, v7m. The 64-bit kernel, in compat mode, has strings for v8. Fixes: https://bugs.launchpad.net/bugs/1813034 Signed-off-by: Richard Henderson --- v2: Include v8. --- linux-user/elfload.c | 31 +++ 1 file changed, 31 inse

[Qemu-devel] [PATCH v2 0/2] linux-user: Fix AT_PLATFORM for arm

2019-02-11 Thread Richard Henderson
With 5 minutes more thought I would have checked the values that the 64-bit kernel supplies for arm32 in compat mode. In the process I noticed that we don't get the right string for arm64 in big-endian mode. r~ Richard Henderson (2): linux-user: Add ELF_PLATFORM for arm linux-user: Fix ELF_

[Qemu-devel] [PATCH v2 2/2] linux-user: Fix ELF_PLATFORM for aarch64_be-linux-user

2019-02-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/elfload.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index d796d51ec6..5aa0628ae9 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -537,7 +537,11 @@ static cons

[Qemu-devel] [PATCH] linux-user: Add AT_PLATFORM for arm

2019-02-11 Thread Richard Henderson
Fixes: https://bugs.launchpad.net/bugs/1813034 Signed-off-by: Richard Henderson --- linux-user/elfload.c | 29 + 1 file changed, 29 insertions(+) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 775a36ccdd..dde640a2ea 100644 --- a/linux-user/elfload.c ++

Re: [Qemu-devel] [PATCH 11/13] spapr: check for the activation of the KVM IRQ device

2019-02-11 Thread Cédric Le Goater
On 2/12/19 2:01 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 07:39:44PM +0100, Cédric Le Goater wrote: >> The activation of the KVM IRQ device depends on the interrupt mode >> chosen at CAS time by the machine and some methods used at reset or by >> the migration need to be protected. >> >> Si

Re: [Qemu-devel] [PULL 00/25] pci, pc, virtio: fixes, cleanups, features

2019-02-11 Thread Peter Xu
On Tue, Feb 05, 2019 at 11:06:42AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 05, 2019 at 12:41:55PM +, Peter Maydell wrote: > > On Tue, 5 Feb 2019 at 01:52, Michael S. Tsirkin wrote: > > > So I think I fixed the build errors. And who knows maybe > > > that will fix the runtime ones someho

Re: [Qemu-devel] [PATCH v12 00/25] Fixing record/replay and adding reverse debugging

2019-02-11 Thread Markus Armbruster
"Pavel Dovgalyuk" writes: > Ping? Are you pinging for more review, or for someone to merge this?

Re: [Qemu-devel] [PATCH] monitor: Add whitelist support for QMP commands

2019-02-11 Thread Markus Armbruster
Julia Suvorova via Qemu-devel writes: > On 01.02.2019 12:14, Markus Armbruster wrote: >> Julia Suvorova via Qemu-devel writes: >> >>> The whitelist option allows to run a reduced monitor with a subset of >>> QMP commands. This allows the monitor to run in secure mode, which is >> >> For a value

Re: [Qemu-devel] [PATCH 13/13] spapr: add KVM support to the 'dual' machine

2019-02-11 Thread Cédric Le Goater
On 2/12/19 2:11 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 07:39:46PM +0100, Cédric Le Goater wrote: >> The interrupt mode is chosen by the CAS negotiation process and >> activated after a reset to take into account the required changes in >> the machine. This brings new constraints on how t

Re: [Qemu-devel] [PATCH v12 00/25] Fixing record/replay and adding reverse debugging

2019-02-11 Thread dovgaluk
Markus Armbruster писал 2019-02-12 10:14: "Pavel Dovgalyuk" writes: Ping? Are you pinging for more review, or for someone to merge this? From my point of view this patch set is ready. Pavel Dovgalyuk

Re: [Qemu-devel] [PATCH v1 2/9] hw/rdma: Introduce locked qlist

2019-02-11 Thread Yuval Shaia
On Mon, Feb 11, 2019 at 10:10:56AM +0200, Marcel Apfelbaum wrote: > > > On 2/10/19 12:45 PM, Yuval Shaia wrote: > > To make code more readable move handling of locked list to a generic > > functions. > > > > Signed-off-by: Yuval Shaia > > --- > > hw/rdma/rdma_backend.c | 20 +

Re: [Qemu-devel] [PATCH 12/13] spapr/xics: ignore the lower 4K in the IRQ number space

2019-02-11 Thread Cédric Le Goater
On 2/12/19 2:06 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 07:39:45PM +0100, Cédric Le Goater wrote: >> The IRQ number space of the XIVE and XICS interrupt mode are aligned >> when using the dual interrupt mode for the machine. This means that >> the ICS offset is set to zero in QEMU and tha

Re: [Qemu-devel] Is IOThread for virtio-net a good idea?

2019-02-11 Thread Jason Wang
On 2019/2/12 下午2:48, Jason Wang wrote: On 2019/2/11 下午9:40, Anton Kuchin wrote: As far as I can see currently IOThread offloading is used only for block devices and all others are emulated by main thread. I expect that network devices can also benefit from processing in separate thread but

Re: [Qemu-devel] [PATCH] cuda: decrease time delay before raising VIA SR interrupt

2019-02-11 Thread Mark Cave-Ayland
On 11/02/2019 23:35, Philippe Mathieu-Daudé wrote: > Hi Mark, > > On 2/10/19 6:44 PM, Mark Cave-Ayland wrote: >> In order to handle a race condition in MacOS 9, a delay was introduced when >> raising the VIA SR interrupt inspired by similar code in MacOnLinux. >> >> During original testing of the

Re: [Qemu-devel] Is IOThread for virtio-net a good idea?

2019-02-11 Thread Jason Wang
On 2019/2/12 上午11:55, Stefan Hajnoczi wrote: On Mon, Feb 11, 2019 at 09:52:01AM -0500, Michael S. Tsirkin wrote: On Mon, Feb 11, 2019 at 04:40:44PM +0300, Anton Kuchin wrote: As far as I can see currently IOThread offloading is used only for block devices and all others are emulated by main t

Re: [Qemu-devel] [PATCH 06/13] spapr/xive: fix migration of the XiveTCTX under TCG

2019-02-11 Thread Cédric Le Goater
On 2/12/19 1:22 AM, David Gibson wrote: > On Fri, Feb 08, 2019 at 08:12:12AM +0100, Cédric Le Goater wrote: >> On 2/8/19 6:36 AM, David Gibson wrote: >>> On Mon, Jan 07, 2019 at 07:39:39PM +0100, Cédric Le Goater wrote: When the thread interrupt management state is retrieved from the KVM

Re: [Qemu-devel] Is IOThread for virtio-net a good idea?

2019-02-11 Thread Jason Wang
On 2019/2/11 下午9:40, Anton Kuchin wrote: As far as I can see currently IOThread offloading is used only for block devices and all others are emulated by main thread. I expect that network devices can also benefit from processing in separate thread but I couldn't find any recent work in this

Re: [Qemu-devel] [RFC v1 3/3] intel_iommu: add scalable-mode option to make scalable mode work

2019-02-11 Thread Peter Xu
On Wed, Jan 30, 2019 at 01:09:13PM +0800, Yi Sun wrote: > This patch adds an option to provide flexibility for user to expose > Scalable Mode to guest. User could expose Scalable Mode to guest by > the config as below: > > "-device intel-iommu,caching-mode=on,scalable-mode=on" > > The Linux iommu

Re: [Qemu-devel] Is IOThread for virtio-net a good idea?

2019-02-11 Thread Jason Wang
On 2019/2/11 下午10:52, Michael S. Tsirkin wrote: On Mon, Feb 11, 2019 at 04:40:44PM +0300, Anton Kuchin wrote: As far as I can see currently IOThread offloading is used only for block devices and all others are emulated by main thread. I expect that network devices can also benefit from proces

Re: [Qemu-devel] [RFC v1 2/3] intel_iommu: add 256 bits qi_desc support

2019-02-11 Thread Peter Xu
On Wed, Jan 30, 2019 at 01:09:12PM +0800, Yi Sun wrote: > From: "Liu, Yi L" > > Per Intel(R) VT-d 3.0, the qi_desc is 256 bits in Scalable > Mode. This patch adds emulation of 256bits qi_desc. > > [Yi Sun is co-developer to rebase and refine the patch.] > Signed-off-by: Yi Sun > Signed-off-by:

Re: [Qemu-devel] [PATCH 06/19] target/ppc: Remove some #if 0'ed code

2019-02-11 Thread David Gibson
On Mon, Jan 28, 2019 at 10:46:12AM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Some debug stuff we don't need to keep there > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Cédric Le Goater This looks a good idea independent of the rest of the series, so I've a

Re: [Qemu-devel] [PATCH 05/19] ppc/pnv: add XIVE support

2019-02-11 Thread David Gibson
On Mon, Jan 28, 2019 at 10:46:11AM +0100, Cédric Le Goater wrote: > This is simple model of the POWER9 XIVE interrupt controller for the > PowerNV machine. XIVE for baremetal is a complex controller and the > model only addresses the needs of the skiboot firmware. > > The PowerNV model reuses the

Re: [Qemu-devel] [PATCH 03/19] xive: extend the XiveRouter get_tctx() method with the page offset

2019-02-11 Thread David Gibson
On Mon, Jan 28, 2019 at 10:46:09AM +0100, Cédric Le Goater wrote: > The PowerNV machine can perform indirect loads and stores on the TIMA > on behalf of another CPU. The PIR of the CPU is controlled by a set of > 4 registers, one per TIMA page. To know which page is being accessed, > we need to inf

[Qemu-devel] [PATCH v2] virtio-blk: set correct config size for the host driver

2019-02-11 Thread Changpeng Liu
Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features support" introduced extra fields to existing struct virtio_blk_config, when migration was executed from older QEMU version to current head, it will break the migration. While here, set the correct config size when initializing the

Re: [Qemu-devel] [PATCH] virtio-blk: set correct config size for the host driver

2019-02-11 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 05:24:25AM +, Liu, Changpeng wrote: > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Tuesday, February 12, 2019 12:31 PM > > To: Liu, Changpeng > > Cc: qemu-devel@nongnu.org; stefa...@redhat.com; sgarz...@redhat.com; >

Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi

2019-02-11 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: > On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: > >There are several functions/variable which are not used anymore. > > > >This serials just remove those without functional change. > > > >v3: add ack and repost in a new thread >

Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi

2019-02-11 Thread Wei Yang
On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >There are several functions/variable which are not used anymore. > >This serials just remove those without functional change. > >v3: add ack and repost in a new thread >v2: change commit log from "is now used in no place" to "in not used an

[Qemu-devel] [PATCH v3 1/2] target/s390x: Split out s390-tod.h

2019-02-11 Thread Richard Henderson
We will need these from CONFIG_USER_ONLY as well, which cannot access include/hw/. Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- include/hw/s390x/tod.h | 16 +--- target/s390x/s390-tod.h | 29 + 2 files cha

Re: [Qemu-devel] [PATCH] virtio-blk: set correct config size for the host driver

2019-02-11 Thread Liu, Changpeng
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, February 12, 2019 12:31 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; stefa...@redhat.com; sgarz...@redhat.com; > dgilb...@redhat.com; ldok...@redhat.com > Subject: Re: [PATCH] virtio-blk: s

[Qemu-devel] [PATCH v3 0/2] target/s390x: Implement STCK et al for CONFIG_USER_ONLY

2019-02-11 Thread Richard Henderson
Changes since v2: * Fix botched subject line, include r-b tags. Changes since v1: * Move more of hw/s390x/tod.h to a new header. * Use time2tod. r~ Richard Henderson (2): target/s390x: Split out s390-tod.h target/s390x: Implement STCK et al for CONFIG_USER_ONLY include/hw/s390x/tod

[Qemu-devel] [PATCH v3 2/2] target/s390x: Implement STCK et al for CONFIG_USER_ONLY

2019-02-11 Thread Richard Henderson
This is a non-privileged instruction that was only implemented for system mode. However, the stck instruction is used by glibc, so this was causing SIGILL for programs run under debian stretch. Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- target

[Qemu-devel] [PULL 11/24] target/hppa: Convert shift, extract, deposit insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 215 ++- target/hppa/insns.decode | 15 +++ 2 files changed, 94 insertions(+), 136 deletions(-) diff --git a/target/hppa/translate.c b/target/hp

[Qemu-devel] [PULL 18/24] target/hppa: Convert fp operate insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 791 --- target/hppa/insns.decode | 175 + 2 files changed, 507 insertions(+), 459 deletions(-) diff --git a/target/hppa/translate.c b/ta

[Qemu-devel] [PULL 13/24] target/hppa: Convert arithmetic immediate insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 168 +-- target/hppa/insns.decode | 21 + 2 files changed, 96 insertions(+), 93 deletions(-) diff --git a/target/hppa/translate.c b/target/h

[Qemu-devel] [PULL 23/24] target/hppa: fix dcor instruction

2019-02-11 Thread Richard Henderson
From: Sven Schnelle It looks like the operands where exchanged. HP bootrom tests the following sequence: 0xf0004064: ldil L%-6800,r7 0xf0004068: addi 19f,r7,r7 0xf000406c: addi -1,r0,rp 0xf0004070: addi f,r0,r4 0xf0004074: addi 1,r4,r5 0xf

[Qemu-devel] [PULL 14/24] target/hppa: Convert offset memory insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 215 +-- target/hppa/insns.decode | 49 + 2 files changed, 99 insertions(+), 165 deletions(-) diff --git a/target/hppa/translate.c b/tar

[Qemu-devel] [PULL 22/24] target/hppa: Fix addition '

2019-02-11 Thread Richard Henderson
From: Sven Schnelle These conditions include the signed overflow bit. See page 5-3 of the Parisc 1.1 Architecture Reference Manual for details. Signed-off-by: Sven Schnelle [rth: More changes for c == 3, to compute (N^V)|Z properly.] Signed-off-by: Richard Henderson --- target/hppa/translate

[Qemu-devel] [PULL 17/24] target/hppa: Convert fp fused multiply-add insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 77 +--- target/hppa/insns.decode | 12 +++ 2 files changed, 36 insertions(+), 53 deletions(-) diff --git a/target/hppa/translate.c b/target/

[Qemu-devel] [PULL 20/24] target/hppa: move GETPC to HELPER() functions

2019-02-11 Thread Richard Henderson
From: Sven Schnelle When QEMU is compiled with -O0, these functions are inlined which will cause a wrong restart address generated for the TB. Signed-off-by: Sven Schnelle Message-Id: <20190211181907.2219-2-sv...@stackframe.org> Signed-off-by: Richard Henderson --- target/hppa/op_helper.c | 1

[Qemu-devel] [PULL 01/24] target/hppa: Use DisasContextBase.is_jmp

2019-02-11 Thread Richard Henderson
Instead of returning DisasJumpType, immediately store it. Return true in preparation for conversion to the decodetree script. Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 1011 --- 1 file cha

[Qemu-devel] [PULL 12/24] target/hppa: Convert direct and indirect branches

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 131 +-- target/hppa/insns.decode | 34 +- 2 files changed, 63 insertions(+), 102 deletions(-) diff --git a/target/hppa/translate.c b/ta

[Qemu-devel] [PULL 16/24] target/hppa: Convert halt/reset insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 49 target/hppa/insns.decode | 5 2 files changed, 20 insertions(+), 34 deletions(-) diff --git a/target/hppa/translate.c b/target/hpp

[Qemu-devel] [PULL 05/24] target/hppa: Unify specializations of OR

2019-02-11 Thread Richard Henderson
With decodetree.py, the specializations would conflict so we must have a single entry point for all variants of OR. Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 108 ++-- 1 file changed, 59 i

[Qemu-devel] [PULL 04/24] target/hppa: Convert remainder of system insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 99 ++-- target/hppa/insns.decode | 12 + 2 files changed, 56 insertions(+), 55 deletions(-) diff --git a/target/hppa/translate.c b/target/hp

[Qemu-devel] [PULL 08/24] target/hppa: Convert indexed memory insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 169 +-- target/hppa/insns.decode | 24 ++ 2 files changed, 60 insertions(+), 133 deletions(-) diff --git a/target/hppa/translate.c b/target

[Qemu-devel] [PULL 19/24] target/hppa: Merge translate_one into hppa_tr_translate_insn

2019-02-11 Thread Richard Henderson
Now that the implementation is entirely within the generated decode function, eliminate the wrapper. Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/tar

[Qemu-devel] [PULL 03/24] target/hppa: Convert move to/from system registers

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 61 +--- target/hppa/insns.decode | 15 ++ 2 files changed, 41 insertions(+), 35 deletions(-) diff --git a/target/hppa/translate.c b/targ

[Qemu-devel] [PULL 15/24] target/hppa: Convert fp indexed memory insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 93 target/hppa/insns.decode | 21 + 2 files changed, 21 insertions(+), 93 deletions(-) diff --git a/target/hppa/translate.c b/targe

[Qemu-devel] [PULL 10/24] target/hppa: Convert conditional branches

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 221 +-- target/hppa/insns.decode | 30 ++ 2 files changed, 124 insertions(+), 127 deletions(-) diff --git a/target/hppa/translate.c b/targe

[Qemu-devel] [PULL 07/24] target/hppa: Convert arithmetic/logical insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 326 ++- target/hppa/insns.decode | 42 + 2 files changed, 195 insertions(+), 173 deletions(-) diff --git a/target/hppa/translate.c b/target

[Qemu-devel] [PULL 09/24] target/hppa: Convert fp multiply-add

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 69 +++- target/hppa/insns.decode | 12 +++ 2 files changed, 52 insertions(+), 29 deletions(-) diff --git a/target/hppa/translate.c b/target/

[Qemu-devel] [PULL 06/24] target/hppa: Convert memory management insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 162 --- target/hppa/insns.decode | 38 + 2 files changed, 89 insertions(+), 111 deletions(-) diff --git a/target/hppa/translate.c b/tar

[Qemu-devel] [PULL 24/24] hw/hppa: forward requests to CPU HPA

2019-02-11 Thread Richard Henderson
From: Sven Schnelle HP-UX 10.20 uses busmaster writes to the CPU EIR to signal interrupts from the SCSI constroller. (Similar to what is known as MSI on x86) Signed-off-by: Sven Schnelle Message-Id: <20190211192039.5457-1-sv...@stackframe.org> Signed-off-by: Richard Henderson --- hw/hppa/dino

[Qemu-devel] [PULL 21/24] target/hppa: Rearrange log conditions

2019-02-11 Thread Richard Henderson
We will be fixing do_cond vs signed overflow, which requires that do_log_cond not rely on do_cond. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 56 +++-- 1 file changed, 49 insertions(+), 7 deletions(-) diff --git a/target/hppa/translate.c b

[Qemu-devel] [PULL 02/24] target/hppa: Begin using scripts/decodetree.py

2019-02-11 Thread Richard Henderson
Convert the BREAK instruction to start. Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 24 +++- target/hppa/Makefile.objs | 8 target/hppa/insns.decode | 24 3 files chang

[Qemu-devel] [PULL 00/24] target/hppa patch queue

2019-02-11 Thread Richard Henderson
The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into staging (2019-02-11 17:04:57 +) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-hppa-201

Re: [Qemu-devel] [PATCH] target/hppa: forward requests to CPU HPA

2019-02-11 Thread Richard Henderson
On 2/11/19 11:20 AM, Sven Schnelle wrote: > HP-UX 10.20 uses busmaster writes to the CPU EIR to signal > interrupts from the SCSI constroller. (Similar to what is known > as MSI on x86) > > Signed-off-by: Sven Schnelle > --- > hw/hppa/dino.c | 8 +++- > 1 file changed, 7 insertions(+), 1 del

Re: [Qemu-devel] Is IOThread for virtio-net a good idea?

2019-02-11 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 11:55:05AM +0800, Stefan Hajnoczi wrote: > On Mon, Feb 11, 2019 at 09:52:01AM -0500, Michael S. Tsirkin wrote: > > On Mon, Feb 11, 2019 at 04:40:44PM +0300, Anton Kuchin wrote: > > > As far as I can see currently IOThread offloading is used only for block > > > devices and a

Re: [Qemu-devel] [PATCH] virtio-blk: set correct config size for the host driver

2019-02-11 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 12:25:16PM +0800, Changpeng Liu wrote: > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features support" > introduced extra fields to existing struct virtio_blk_config, when > migration was executed from older QEMU version to current head, it > will break the mig

Re: [Qemu-devel] [RFC PATCH 4/4] spapr: Add Hcalls to support PAPR NVDIMM device

2019-02-11 Thread David Gibson
On Tue, Feb 05, 2019 at 11:26:41PM -0600, Shivaprasad G Bhat wrote: > This patch implements few of the necessary hcalls for the nvdimm support. > > PAPR semantics is such that each NVDIMM device is comprising of multiple > SCM(Storage Class Memory) blocks. The guest requests the hypervisor to bind

Re: [Qemu-devel] [PATCH 5/5] target/hppa: fix dcor instruction

2019-02-11 Thread Richard Henderson
On 2/11/19 10:19 AM, Sven Schnelle wrote: > It looks like the operands where exchanged. HP bootrom tests the > following sequence: > > 0xf0004064: ldil L%-6800,r7 > 0xf0004068: addi 19f,r7,r7 > 0xf000406c: addi -1,r0,rp > 0xf0004070: addi f,r0,r4 > 0x000

Re: [Qemu-devel] [PATCH 3/5] target/hppa: fix log conditions

2019-02-11 Thread Richard Henderson
On 2/11/19 10:19 AM, Sven Schnelle wrote: > switch (cf >> 1) { > -case 4: case 5: case 6: > -cf &= 1; > +case 0: /* never */ > +cond = cond_make_f(); > +break; > +case 1: /* = all bits are zero */ > +cond = cond_make_0(TCG_COND_EQ, res); > +b

Re: [Qemu-devel] [PATCH 4/5] target/hppa: fix sed conditions

2019-02-11 Thread Richard Henderson
On 2/11/19 10:19 AM, Sven Schnelle wrote: > -f = (orig & 4) / 4; > - > -return do_log_cond(c * 2 + f, res); Given that this used to reference do_log_cond, and you've fixed do_log_cond, why is there any reason for a change here? r~

Re: [Qemu-devel] [PATCH 2/5] target/hppa: fix '

2019-02-11 Thread Richard Henderson
On 2/11/19 10:19 AM, Sven Schnelle wrote: > case 3: /* <= / >(N | Z / !N & !Z) */ > -cond = cond_make_0(TCG_COND_LE, res); > +tmp = tcg_temp_new(); > +tcg_gen_xor_reg(tmp, res, sv); > +cond = cond_make_0(TCG_COND_LE, tmp); > +tcg_temp_free(tmp);

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2019 at 05:38:29PM +0100, Paolo Bonzini wrote: > +The Kconfig language > + > + > +Kconfig defines configurable components in files named ``hw/*/Kconfig``. > +Note that configurable components are _not_ visible in C code as > preprocessor symbols; > +they are onl

[Qemu-devel] [PULL 2/3] qemugdb/coroutine: fix arch_prctl has unknown return type

2019-02-11 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy qemu coroutine command results in following error output: Python Exception 'arch_prctl' has unknown return type; cast the call to its declared return type: Error occurred in Python command: 'arch_prctl' has unknown return type; cast the call to its declared re

[Qemu-devel] [PATCH] virtio-blk: set correct config size for the host driver

2019-02-11 Thread Changpeng Liu
Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features support" introduced extra fields to existing struct virtio_blk_config, when migration was executed from older QEMU version to current head, it will break the migration. While here, set the correct config size when initializing the

[Qemu-devel] [PULL 3/3] virtio-blk: cleanup using VirtIOBlock *s and VirtIODevice *vdev

2019-02-11 Thread Stefan Hajnoczi
From: Stefano Garzarella In several part we still using req->dev or VIRTIO_DEVICE(req->dev) when we have already defined s and vdev pointers: VirtIOBlock *s = req->dev; VirtIODevice *vdev = VIRTIO_DEVICE(s); Signed-off-by: Stefano Garzarella Reviewed-by: Liam Merwick Message-id: 201902

[Qemu-devel] [PULL 0/3] Block patches

2019-02-11 Thread Stefan Hajnoczi
The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into staging (2019-02-11 17:04:57 +) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/block-pull-re

[Qemu-devel] [PULL 1/3] iothread: fix iothread hang when stop too soon

2019-02-11 Thread Stefan Hajnoczi
From: Peter Xu Lukas reported an hard to reproduce QMP iothread hang on s390 that QEMU might hang at pthread_join() of the QMP monitor iothread before quitting: Thread 1 #0 0x03ffad10932c in pthread_join #1 0x000109e95750 in qemu_thread_join at /home/thuth/devel/qemu/util/q

Re: [Qemu-devel] Is IOThread for virtio-net a good idea?

2019-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2019 at 09:52:01AM -0500, Michael S. Tsirkin wrote: > On Mon, Feb 11, 2019 at 04:40:44PM +0300, Anton Kuchin wrote: > > As far as I can see currently IOThread offloading is used only for block > > devices and all others are emulated by main thread. > > > > I expect that network dev

Re: [Qemu-devel] [Qemu-block] [PULL 0/9] Block patches

2019-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2019 at 11:42:14AM +, Peter Maydell wrote: > On Mon, 11 Feb 2019 at 05:50, Stefan Hajnoczi wrote: > > > > The following changes since commit e47f81b617684c4546af286d307b69014a83538a: > > > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > > stagin

[Qemu-devel] [Bug 1815413] Re: compile with vhost-vsock support on osx

2019-02-11 Thread Stefan Hajnoczi
vhost devices are not available on macOS hosts, they are a Linux feature. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815413 Title: compile wit

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] coroutines: generate wrapper code

2019-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2019 at 09:38:37AM +, Vladimir Sementsov-Ogievskiy wrote: > 11.02.2019 6:42, Stefan Hajnoczi wrote: > > On Fri, Feb 08, 2019 at 05:11:22PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > >> Hi all! > >> > >> We have a very frequent pattern of wrapping a coroutine_fn function >

Re: [Qemu-devel] virtio-blk io bar size changed

2019-02-11 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 01:59:38AM +, Liu, Changpeng wrote: > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Tuesday, February 12, 2019 1:23 AM > > To: Dr. David Alan Gilbert > > Cc: qemu-devel@nongnu.org; Liu, Changpeng ; > > stefa...@redhat

Re: [Qemu-devel] [regression] Clock jump on VM migration

2019-02-11 Thread Stefan Hajnoczi
Hi Neil, I'll return to this issue on Monday. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH v3 00/17] block: local qiov helper

2019-02-11 Thread Stefan Hajnoczi
On Thu, Feb 07, 2019 at 01:24:28PM +0300, Vladimir Sementsov-Ogievskiy wrote: > v3: Will you send a v4 based on Eric's comments or do you want to keep the series as it is? Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH v3 00/17] block: local qiov helper

2019-02-11 Thread Stefan Hajnoczi
On Thu, Feb 07, 2019 at 01:24:28PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a new simple helper for a very often patter > around qemu_iovec_init_external, when we need simple qiov with only > one iov, initialized from external buffer. > > v3: > 01-02: tiny improvements,

[Qemu-devel] [PATCH] hostmem-file: reject invalid pmem file sizes

2019-02-11 Thread Stefan Hajnoczi
Guests started with NVDIMMs larger than the underlying host file produce confusing errors inside the guest. This happens because the guest accesses pages beyond the end of the file. Check the pmem file size on startup and print a clear error message if the size is invalid. Fixes: https://bugzill

Re: [Qemu-devel] virtio-blk io bar size changed

2019-02-11 Thread Liu, Changpeng
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, February 12, 2019 1:23 AM > To: Dr. David Alan Gilbert > Cc: qemu-devel@nongnu.org; Liu, Changpeng ; > stefa...@redhat.com; ldok...@redhat.com > Subject: Re: virtio-blk io bar size changed > > On M

Re: [Qemu-devel] [RFC PATCH 3/4] spapr: Add NVDIMM device support

2019-02-11 Thread David Gibson
On Tue, Feb 05, 2019 at 11:26:27PM -0600, Shivaprasad G Bhat wrote: > Add support for NVDIMM devices for sPAPR. Piggyback on existing nvdimm > device interface in QEMU to support virtual NVDIMM devices for Power (May have > to re-look at this later). Create the required DT entries for the > device

Re: [Qemu-devel] [PATCH 12/13] spapr/xics: ignore the lower 4K in the IRQ number space

2019-02-11 Thread David Gibson
On Mon, Jan 07, 2019 at 07:39:45PM +0100, Cédric Le Goater wrote: > The IRQ number space of the XIVE and XICS interrupt mode are aligned > when using the dual interrupt mode for the machine. This means that > the ICS offset is set to zero in QEMU and that the KVM XICS device > should be informed of

Re: [Qemu-devel] [PATCH 11/13] spapr: check for the activation of the KVM IRQ device

2019-02-11 Thread David Gibson
On Mon, Jan 07, 2019 at 07:39:44PM +0100, Cédric Le Goater wrote: > The activation of the KVM IRQ device depends on the interrupt mode > chosen at CAS time by the machine and some methods used at reset or by > the migration need to be protected. > > Signed-off-by: Cédric Le Goater > --- > hw/int

Re: [Qemu-devel] [PATCH 10/13] spapr: introduce routines to delete the KVM IRQ device

2019-02-11 Thread David Gibson
On Mon, Jan 07, 2019 at 07:39:43PM +0100, Cédric Le Goater wrote: > If a new interrupt mode is chosen by CAS, the machine generates a > reset to reconfigure. At this point, the connection with the previous > KVM device needs to be closed and a new connection needs to opened > with the KVM device op

Re: [Qemu-devel] [PATCH 06/13] spapr/xive: fix migration of the XiveTCTX under TCG

2019-02-11 Thread David Gibson
On Fri, Feb 08, 2019 at 08:12:12AM +0100, Cédric Le Goater wrote: > On 2/8/19 6:36 AM, David Gibson wrote: > > On Mon, Jan 07, 2019 at 07:39:39PM +0100, Cédric Le Goater wrote: > >> When the thread interrupt management state is retrieved from the KVM > >> VCPU, word2 is saved under the QEMU XIVE th

Re: [Qemu-devel] [PATCH 13/13] spapr: add KVM support to the 'dual' machine

2019-02-11 Thread David Gibson
On Mon, Jan 07, 2019 at 07:39:46PM +0100, Cédric Le Goater wrote: > The interrupt mode is chosen by the CAS negotiation process and > activated after a reset to take into account the required changes in > the machine. This brings new constraints on how the associated KVM IRQ > device is initialized

[Qemu-devel] [Bug 1808928] Re: Bitmap Extra data is not supported

2019-02-11 Thread John Snow
Hi, bitmap extensions have a field that allows us to attach extra/arbitrary data to them. It is not currently used by QEMU. If this field is set, it means something corrupted your qcow2. Please make a backup of your qcow2 file first (because attempting to repair a broken qcow2 can sometimes make i

[Qemu-devel] [PATCH v2 2/3] s390x/cpumodel: default enable mepoch for z14 and later

2019-02-11 Thread Collin Walling
Latest systems and host kernels support mepoch, which is a feature that was meant to be supported for z14 GA1 from the get-go. Let's copy it to the z14 GA1 default CPU model. Machines s390-ccw-virtio-3.1 and older will retain the old CPU models and will not provide this bit nor the extended PTFF f

[Qemu-devel] [PATCH v2 3/3] s390x/cpumodel: add z14 GA2 model

2019-02-11 Thread Collin Walling
Introduce the z14 GA2 cpu model for QEMU. There are no new features introduced with this model, and will inherit the same feature set as z14 GA1. Signed-off-by: Collin Walling Acked-by: Christian Borntraeger Reviewed-by: David Hildenbrand --- target/s390x/cpu_models.c | 1 + target/s390x/gen

[Qemu-devel] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init

2019-02-11 Thread Collin Walling
The extended PTFF features (qsie, qtoue, stoe, stoue) are dependent on the multiple-epoch facility (mepoch). Let's print a warning if these features are enabled without mepoch. While we're at it, let's move the FEAT_GROUP_INIT for mepochptff down the s390_feature_groups list so it can be properly

Re: [Qemu-devel] [Bug 1814418] [NEW] persistent bitmap will be inconsistent when qemu crash,

2019-02-11 Thread John Snow
On 2/4/19 11:22 AM, Vladimir Sementsov-Ogievskiy wrote: > 04.02.2019 17:55, Eric Blake wrote: >> On 2/2/19 11:52 PM, Cheng Chen wrote: >>> Public bug reported: >>> >>> Follow these steps to reappear the bug: >>> >>> 1. start qemu >>> 2. add persistent bitmap: '{ "execute": "block-dirty-bitmap-ad

[Qemu-devel] [PATCH 5/5] block/dirty-bitmaps: unify qmp_locked and user_locked calls

2019-02-11 Thread John Snow
These mean the same thing now. Unify them and rename the merged call bdrv_dirty_bitmap_busy to indicate semantically what we are describing, as well as help disambiguate from the various _locked and _unlocked versions of bitmap helpers that refer to mutex locks. --- block/dirty-bitmap.c

[Qemu-devel] [PATCH 4/5] block/dirty-bitmap: explicitly lock bitmaps with successors

2019-02-11 Thread John Snow
Instead of implying a locked status, make it explicit. Now, bitmaps in use by migration, NBD or backup operations are all treated the same way with the same code paths. --- block/dirty-bitmap.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/dirty-bitmap.c b/bloc

[Qemu-devel] [PATCH 3/5] block/dirty-bitmap: change semantics of enabled predicate

2019-02-11 Thread John Snow
Currently, enabled means something like "the status of the bitmap is ACTIVE." After this patch, it should mean exclusively: "This bitmap is recording guest writes, and is allowed to do so." In many places, this is how this predicate was already used. We'll allow users to call user_locked if they'r

[Qemu-devel] [PATCH 2/5] block/dirty-bitmaps: rename frozen predicate helper

2019-02-11 Thread John Snow
"Frozen" was a good description a long time ago, but it isn't adequate now. Rename the frozen predicate to has_successor to make the semantics of the predicate more clear to outside callers. In the process, remove some calls to frozen() that no longer semantically make sense. For enabled and disab

[Qemu-devel] [PATCH 1/5] block/dirty-bitmap: add recording and busy properties

2019-02-11 Thread John Snow
The current API allows us to report a single status, which we've defined as: Frozen: has a successor, treated as qmp_locked, may or may not be enabled. Locked: no successor, qmp_locked. may or may not be enabled. Disabled: Not frozen or locked, disabled. Active: Not frozen, locked, or disabled. T

[Qemu-devel] [PATCH 0/5] dirty-bitmaps: deprecate @status field

2019-02-11 Thread John Snow
The current internal meanings of "locked", "user_locked", "qmp_locked", "frozen", "enabled", and "disabled" are all a little muddled. Deprecate the @status field in favor of two new booleans that carry very specific meanings. Then, rename and rework some of the internal semantics to help make the

Re: [Qemu-devel] [PATCH 1/4] hw/pci-host/bonito.c: Add PCI mem region mapped at the correct address

2019-02-11 Thread Philippe Mathieu-Daudé
On 2/11/19 5:01 AM, BALATON Zoltan wrote: > Stop using system memory as PCI memory otherwise devices such as VGA > that have regions mapped to PCI memory clash with RAM. Use a separate > memory region for PCI memory and map it to the correct address in > system memory which allows PCI mem regions t

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-11 Thread Philippe Mathieu-Daudé
Hi Zoltan, On 2/11/19 4:19 AM, BALATON Zoltan wrote: > At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI > gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and > guests running on these and the PMON2000 firmware of the fulong2e > expect this to be available. Fortunate

Re: [Qemu-devel] [PATCH v2] pc-dimm: use same mechanism for [get|set]_addr

2019-02-11 Thread Wei Yang
On Mon, Feb 11, 2019 at 03:43:07PM +0100, Igor Mammedov wrote: >On Mon, 11 Feb 2019 14:46:29 +0800 >Wei Yang wrote: > >> [get|set]_addr are two counterpart to access PCDIMMDevice.addr. >> >> Since we have already set up a property PC_DIMM_ADDR_PROP for this >> field and use this mechanism in set_

  1   2   3   4   >