On Tue, Feb 12, 2019 at 01:59:38AM +0000, Liu, Changpeng wrote: > > > > -----Original Message----- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Tuesday, February 12, 2019 1:23 AM > > To: Dr. David Alan Gilbert <dgilb...@redhat.com> > > Cc: qemu-devel@nongnu.org; Liu, Changpeng <changpeng....@intel.com>; > > stefa...@redhat.com; ldok...@redhat.com > > Subject: Re: virtio-blk io bar size changed > > > > On Mon, Feb 11, 2019 at 04:58:19PM +0000, Dr. David Alan Gilbert wrote: > > > Hi, > > > Lukáš reported that there's a migration breakage between 3.1 and > > > current head with virtio-blk; it looks like the io bar changes from 64 > > > to 128 bytes and my bisect suggests it's: > > > > > > commit caa1ee43131c060347b32893abd41fe4865eaa2e (HEAD, refs/bisect/bad) > > > Author: Changpeng Liu <changpeng....@intel.com> > > > Date: Wed Jan 16 13:19:30 2019 +0800 > > > > > > vhost-user-blk: add discard/write zeroes features support > > > > > > > > > How do we fix that? > > > > > > Dave > > > > Quickly :) > > > > See the logic around virtio_net_set_config_size > > and static VirtIOFeature feature_sizes - we need to > > add something similar to virtio blk now. > Correct, after this commit the BAR config size is changed, I will submit a > patch to fix this.
Thanks! > > > > > > > -- > > > Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
