Re: [Qemu-devel] [PATCH] s390x/pci: add common fmb

2018-09-28 Thread Yi Min Zhao
在 2018/9/19 下午3:53, Thomas Huth 写道: On 2018-09-19 09:08, Yi Min Zhao wrote: No comment? Since the zPCI spec is not available to the public, it's quite hard to give any valuable comments here... I'll try anyway... 在 2018/9/4 下午5:15, Yi Min Zhao 写道: Common function measurement block is used

Re: [Qemu-devel] [PATCH v8 2/6] monitor: resume the monitor earlier if needed

2018-09-28 Thread Peter Xu
On Fri, Sep 28, 2018 at 04:06:30PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Sep 5, 2018 at 10:24 AM Peter Xu wrote: > > > > Currently when QMP request queue full we won't resume the monitor until > > we have completely handled the current command. It's not necessary > > since even before

Re: [Qemu-devel] [PATCH v8 1/6] monitor: Suspend monitor instead dropping commands

2018-09-28 Thread Peter Xu
On Fri, Sep 28, 2018 at 03:53:18PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Sep 5, 2018 at 10:24 AM Peter Xu wrote: > > > > When a QMP client sends in-band commands more quickly that we can > > process them, we can either queue them without limit (QUEUE), drop > > commands when the queue

[Qemu-devel] [PATCH v4 2/2] intel_iommu: better handling of dmar state switch

2018-09-28 Thread Peter Xu
QEMU is not handling the global DMAR switch well, especially when from "on" to "off". Let's first take the example of system reset. Assuming that a guest has IOMMU enabled. When it reboots, we will drop all the existing DMAR mappings to handle the system reset, however we'll still keep the exist

[Qemu-devel] [PATCH v4 0/2] intel_iommu: better handling of dmar state switch

2018-09-28 Thread Peter Xu
v4: - add a patch to introduce vtd_reset_caches() - reset the caches in the two places where GCMD update happens [Eric] Please review, thanks. Peter Xu (2): intel_iommu: introduce vtd_reset_caches() intel_iommu: better handling of dmar state switch hw/i386/intel_iommu.c | 34 +++

[Qemu-devel] [PATCH v4 1/2] intel_iommu: introduce vtd_reset_caches()

2018-09-28 Thread Peter Xu
Provide the function and use it in vtd_init(). Used to reset both context entry cache and iotlb cache for the whole IOMMU unit. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/int

Re: [Qemu-devel] [PATCH v3] intel_iommu: better handling of dmar state switch

2018-09-28 Thread Peter Xu
On Fri, Sep 28, 2018 at 12:47:08PM +0200, Auger Eric wrote: > Hi Peter, Hi, Eric, [...] > > +static void vtd_address_space_refresh_all(IntelIOMMUState *s) > > +{ > > +vtd_address_space_unmap_all(s); > What about internal context and iotlb caches? Shouldn't they be also > invalidated at the s

Re: [Qemu-devel] [PATCH RFC v4 7/7] qemu_thread_create: propagate the error to callers to handle

2018-09-28 Thread Fam Zheng
On Wed, Sep 26, 2018 at 7:13 PM Fei Li wrote: > > > > On 09/26/2018 06:36 PM, Fam Zheng wrote: > > On Wed, 09/26 18:02, Fei Li wrote: > >> diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c > >> index 289af4fab5..8b044e2798 100644 > >> --- a/util/qemu-thread-posix.c > >> +++ b/util/q

[Qemu-devel] [Bug 1795100] [NEW] unix-domain socket unlink()ed prematurely

2018-09-28 Thread LukeShu
Public bug reported: With qemu 3.0.0 (I don't believe this happened with previous versions), if I tell it `-vnc unix:/path/to/vnc.sock`, qemu will unlink() that file when the first client disconnects, meaning that once I disconnect, I can't ever reconnect without restarting the VM. A stupid testc

Re: [Qemu-devel] [Qemu-stable] [PATCH] block-backend: Set werror/rerror defaults in blk_new()

2018-09-28 Thread Fam Zheng
On Fri, Sep 28, 2018 at 5:32 PM Kevin Wolf wrote: > > Currently, the default values for werror and rerror have to be set > explicitly with blk_set_on_error() by the callers of blk_new(). The only > caller actually doing this is blockdev_init(), which is called for > BlockBackends created using -dr

[Qemu-devel] [PATCH 1/1] tests: Add migration test for aarch64

2018-09-28 Thread Wei Huang
This patch adds migration test support for aarch64. The test code, which implements the same functionality as x86, is booted as a kernel in qemu. Here are the design choices we make for aarch64: * We choose this -kernel approach because aarch64 QEMU doesn't provide a built-in fw like x86 does.

Re: [Qemu-devel] [PULL 00/16] migration queue

2018-09-28 Thread Peter Maydell
On 26 September 2018 at 18:12, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit c5e4e49258e9b89cb34c085a419dd9f862935c48: > > Merge remote-tracking branch 'remotes/xanclic/tags/pull-block-2018-09-25' > into staging (2018-09-25 16:47:35

Re: [Qemu-devel] [PULL 00/42] Block patches

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 15:36, Peter Maydell wrote: > On 25 September 2018 at 18:09, Peter Maydell wrote: >> On 25 September 2018 at 16:14, Max Reitz wrote: >>> The following changes since commit 506e4a00de01e0b29fa83db5cbbc3d154253b4ea: >>> >>> Merge remote-tracking branch 'remotes/dgibson/ta

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-28 Thread Tony Krowiak
On 09/27/2018 08:29 AM, Thomas Huth wrote: On 2018-09-27 00:54, Tony Krowiak wrote: From: Tony Krowiak Introduces the base object model for virtualizing AP devices. Signed-off-by: Tony Krowiak --- [...] diff --git a/hw/s390x/ap-bridge.c b/hw/s390x/ap-bridge.c new file mode 100644 index 000

Re: [Qemu-devel] [PATCH v5 2/8] target/mips: Support R5900 specific three-operand MULT and MULTU

2018-09-28 Thread Maciej W. Rozycki
On Fri, 28 Sep 2018, Philippe Mathieu-Daudé wrote: > > What's wrong with `gen_mul_r5900' anyway? > > I plan to use this function (adding MADD/MADDU) for R3900 based cores > (which don't seemt related to Emotion Engine). Fair enough. I reached for documentation and these instructions seem to

[Qemu-devel] [RFC PATCH 0/3] acceptance tests: Test firmware checking debug console output

2018-09-28 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 28/09/2018 12:51, Laszlo Ersek wrote: > Hi Phil, > > (+Daniel, +Kashyap) > > On 09/28/18 02:30, Philippe Mathieu-Daudé wrote: >> Hi, >> >> This RFC series add simple acceptance tests which boot SeaBIOS and >> EDK2 on Q35 and virt/aarch64. >> >> It is more of a proof of concept (to

Re: [Qemu-devel] [PATCH 1/1] qmp, hmp: add PCI subsystem id and vendor id to PCI info

2018-09-28 Thread Denis V. Lunev
On 09/28/2018 07:34 PM, Denis V. Lunev wrote: > On 09/28/2018 07:23 PM, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >>> This is now commit 5383a705207. Sorry for being late with my comments. >>> >>> "Denis V. Lunev" writes: >>> This is a long story. RedHat

Re: [Qemu-devel] [PATCH v3 1/3] qapi: add x-debug-query-block-graph

2018-09-28 Thread Eric Blake
On 9/28/18 11:31 AM, Max Reitz wrote: On 23.08.18 17:46, Vladimir Sementsov-Ogievskiy wrote: Add a new command, returning block nodes (and their users) graph. Drive-by comment without actually reading the patch yet: +++ b/block.c @@ -4003,6 +4003,135 @@ BlockDeviceInfoList *bdrv_named_nodes

Re: [Qemu-devel] [PATCH v5 2/8] target/mips: Support R5900 specific three-operand MULT and MULTU

2018-09-28 Thread Philippe Mathieu-Daudé
On Fri, Sep 28, 2018 at 5:59 PM Maciej W. Rozycki wrote: > > On Fri, 28 Sep 2018, Philippe Mathieu-Daudé wrote: > > > > > Note, these instructions are also valid on the R3900 (which also has > > > > MADD/MADDU). > > > > > > > > Would gen_mul_toshiba() be a better common name? I don't like it but >

Re: [Qemu-devel] [PATCH 1/1] qmp, hmp: add PCI subsystem id and vendor id to PCI info

2018-09-28 Thread Denis V. Lunev
On 09/28/2018 07:23 PM, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: >> This is now commit 5383a705207. Sorry for being late with my comments. >> >> "Denis V. Lunev" writes: >> >>> This is a long story. RedHat has relicensed Windows KVM device drivers >>> in 2018

Re: [Qemu-devel] [PATCH v2 9/9] target/arm: Convert v8.2-fp16 from feature bit to pfr0 test

2018-09-28 Thread Philippe Mathieu-Daudé
On 27/09/2018 23:13, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 17 +++- > target/arm/translate-a64.h | 1 + > target/arm/translate.h | 1 + > linux-user/elfload.c | 6 +- > target/arm/cpu64.c | 13 ++--

Re: [Qemu-devel] [PATCH v3 1/3] qapi: add x-debug-query-block-graph

2018-09-28 Thread Max Reitz
On 23.08.18 17:46, Vladimir Sementsov-Ogievskiy wrote: > Add a new command, returning block nodes (and their users) graph. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 91 +++ > include/block/block.h | 1 + > include/sys

[Qemu-devel] Problem translating very high virtual addresses to physical on x86

2018-09-28 Thread Aldo Mazzeo
I was trying to translate a very high virtual address (like 0x0011) to physical on x86-64 with *paging disabled*. The problem is that the obtained physical page is 0 because PG_ADDRESS_MASK is applied to the pte in the virtual to physical to translation (see target/i386/helper.c:842 in

Re: [Qemu-devel] [PATCH 1/1] qmp, hmp: add PCI subsystem id and vendor id to PCI info

2018-09-28 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > This is now commit 5383a705207. Sorry for being late with my comments. > > "Denis V. Lunev" writes: > > > This is a long story. RedHat has relicensed Windows KVM device drivers > > in 2018 and there was an agreement that to avoid WHQL driver conf

Re: [Qemu-devel] [PATCH v2 8/9] target/arm: Convert sve from feature bit to pfr0 test

2018-09-28 Thread Philippe Mathieu-Daudé
On 27/09/2018 23:13, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/cpu.h| 16 +++- > target/arm/translate-a64.h | 1 + > linux-user/aarch64/signal.c | 4 ++-- > linux-user/elfload.c| 2 +- >

Re: [Qemu-devel] [PULL 0/1] seccomp branch queue

2018-09-28 Thread Peter Maydell
On 26 September 2018 at 14:24, Eduardo Otubo wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git repository a

Re: [Qemu-devel] [PATCH v2 6/9] target/arm: Convert jazelle from feature bit to isar1 test

2018-09-28 Thread Peter Maydell
On 27 September 2018 at 22:13, Richard Henderson wrote: > Having V6 alone imply jazelle was wrong for cortex-m0. True, but harmless, because the only place we tested the ARM_FEATURE_JAZELLE was for the 'bxj' in disas_arm(), which is unreachable for M-profile cores. thanks -- PMM

Re: [Qemu-devel] [PATCH V9 4/4] tests: Add migration test for aarch64

2018-09-28 Thread Dr. David Alan Gilbert
* Wei Huang (w...@redhat.com) wrote: > > > On 09/28/2018 10:20 AM, Dr. David Alan Gilbert wrote: > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > >> * Wei Huang (w...@redhat.com) wrote: > >>> > >>> > >>> On 09/28/2018 09:04 AM, Dr. David Alan Gilbert wrote: > * Wei Huang (w...@red

Re: [Qemu-devel] [PATCH v5 2/8] target/mips: Support R5900 specific three-operand MULT and MULTU

2018-09-28 Thread Maciej W. Rozycki
On Fri, 28 Sep 2018, Philippe Mathieu-Daudé wrote: > > > Note, these instructions are also valid on the R3900 (which also has > > > MADD/MADDU). > > > > > > Would gen_mul_toshiba() be a better common name? I don't like it but > > > can't think of another. > > > > I propose gen_mul_3op, since its d

Re: [Qemu-devel] [PATCH v2 6/9] target/arm: Convert jazelle from feature bit to isar1 test

2018-09-28 Thread Philippe Mathieu-Daudé
On 27/09/2018 23:13, Richard Henderson wrote: > Having V6 alone imply jazelle was wrong for cortex-m0. > Change to an assertion for V6 & !M. Correct. > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/cpu.h | 6 +- > target/arm/translate.h |

Re: [Qemu-devel] [PATCH 08/11] net: smc91c111: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 16:10, Cédric Le Goater wrote: > On 9/28/18 4:45 PM, Peter Maydell wrote: >> On 28 September 2018 at 14:50, Cédric Le Goater wrote: >>> void smc91c111_init(NICInfo *nd, uint32_t base, qemu_irq irq) >>> { >>> -DeviceState *dev; >>> -SysBusDevice *s; >>> +Objec

Re: [Qemu-devel] [PATCH v5 6/8] target/mips: Define the R5900 CPU

2018-09-28 Thread Philippe Mathieu-Daudé
On Thu, Sep 27, 2018 at 7:11 PM Fredrik Noring wrote: > > Thank you for your reviews, Philippe, > > > Fredrik: maybe you can simply name the C790 in the comment pointing to > > the DS documentation. > > Sure, I will do that for v6! I am also adding some of Maciej's notes on the > differences betwe

Re: [Qemu-devel] [PATCH V9 4/4] tests: Add migration test for aarch64

2018-09-28 Thread Wei Huang
On 09/28/2018 10:20 AM, Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >> * Wei Huang (w...@redhat.com) wrote: >>> >>> >>> On 09/28/2018 09:04 AM, Dr. David Alan Gilbert wrote: * Wei Huang (w...@redhat.com) wrote: > > > On 09/26/2018 11:31

Re: [Qemu-devel] [PATCH v5 0/8] target/mips: Support R5900 GCC programs in user mode

2018-09-28 Thread Philippe Mathieu-Daudé
On Wed, Sep 19, 2018 at 8:14 PM Fredrik Noring wrote: ... > The Toshiba TX System RISC TX79 Core Architecture manual describes the > R5900 processor: > > http://www.lukasz.dk/files/tx79architecture.pdf I'd like to mirror this DS (and few others) here: https://wiki.qemu.org/Documentation/Hardware

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-28 Thread Thomas Huth
On 2018-09-28 16:22, Halil Pasic wrote: > > > On 09/27/2018 02:29 PM, Thomas Huth wrote: >>> +static void vfio_ap_bus_class_init(ObjectClass *klass, void *data) >>> +{ >>> +BusClass *k = BUS_CLASS(klass); >> I think calling the variable "oc" (or something similar) instead of >> "klass" is pre

Re: [Qemu-devel] [PATCH v5 2/8] target/mips: Support R5900 specific three-operand MULT and MULTU

2018-09-28 Thread Philippe Mathieu-Daudé
On Fri, Sep 28, 2018 at 5:16 PM Fredrik Noring wrote: > > Hi Philippe, > > > Can you copy/paste some info regarding those instructions from the ISA > > here, to note how they differ? ... > > Yes. Other corresponding functions typically do not seem to have such ISA > notes, but I can certainly writ

Re: [Qemu-devel] [PATCH v2 7/9] target/arm: Convert t32ee from feature bit to isar3 test

2018-09-28 Thread Philippe Mathieu-Daudé
On 27/09/2018 23:13, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/cpu.h | 6 +- > linux-user/elfload.c | 2 +- > target/arm/cpu.c | 4 > target/arm/helper.c | 2 +- > target/arm/machine.c | 3 +-- > 5 files

Re: [Qemu-devel] [PATCH V9 4/4] tests: Add migration test for aarch64

2018-09-28 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Wei Huang (w...@redhat.com) wrote: > > > > > > On 09/28/2018 09:04 AM, Dr. David Alan Gilbert wrote: > > > * Wei Huang (w...@redhat.com) wrote: > > >> > > >> > > >> On 09/26/2018 11:31 AM, Dr. David Alan Gilbert wrote: > > >>> * Wei Huang

Re: [Qemu-devel] [PATCH v2 5/9] target/arm: Convert division from feature bits to isar0 tests

2018-09-28 Thread Philippe Mathieu-Daudé
On 27/09/2018 23:13, Richard Henderson wrote: > Both arm and thumb2 division are controlled by the same ISAR field, > which takes care of the arm implies thumb case. Having M imply > thumb2 division was wrong for cortex-m0, which is v6m and does not > have thumb2 at all, much less thumb2 division.

Re: [Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
On 9/28/18 4:49 PM, Peter Maydell wrote: > On 28 September 2018 at 14:49, Cédric Le Goater wrote: >> Cc: Michael Walle >> Signed-off-by: Cédric Le Goater >> --- >> hw/net/milkymist-minimac2.c | 9 +++-- >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/hw/net/milkymist-m

Re: [Qemu-devel] [PATCH 02/11] net: etraxfs_eth: add a reset method

2018-09-28 Thread Cédric Le Goater
On 9/28/18 4:47 PM, Peter Maydell wrote: > On 28 September 2018 at 14:49, Cédric Le Goater wrote: >> Cc: Edgar E. Iglesias >> Signed-off-by: Cédric Le Goater >> --- >> hw/net/etraxfs_eth.c | 10 -- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/hw/net/etraxfs_eth.

Re: [Qemu-devel] [PATCH 11/11] net: xgmac: convert SysBus init method to a realize method

2018-09-28 Thread Philippe Mathieu-Daudé
On 28/09/2018 15:50, Cédric Le Goater wrote: > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: Rob Herring > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/xgmac.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/net/

Re: [Qemu-devel] [PATCH] linux-user: Suppress address-of-packed-member warnings in __get/put_user_e

2018-09-28 Thread Liam Merwick
On 28/09/18 15:25, Peter Maydell wrote: Our __get_user_e() and __put_user_e() macros cause newer versions of clang to generate false-positive -Waddress-of-packed-member warnings if they are passed the address of a member of a packed struct (see https://bugs.llvm.org/show_bug.cgi?id=39113). Supp

Re: [Qemu-devel] [PATCH 07/11] net: opencores_eth: convert SysBus init method to a realize method

2018-09-28 Thread Philippe Mathieu-Daudé
On 28/09/2018 15:49, Cédric Le Goater wrote: > Cc: Max Filippov > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/opencores_eth.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.

Re: [Qemu-devel] [PATCH 10/11] net: stellaris_enet: add a reset method

2018-09-28 Thread Philippe Mathieu-Daudé
On 28/09/2018 15:50, Cédric Le Goater wrote: > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/stellaris_enet.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/net/stellaris_en

Re: [Qemu-devel] [PATCH v5 2/8] target/mips: Support R5900 specific three-operand MULT and MULTU

2018-09-28 Thread Fredrik Noring
Hi Philippe, > Can you copy/paste some info regarding those instructions from the ISA > here, to note how they differ? ... Yes. Other corresponding functions typically do not seem to have such ISA notes, but I can certainly write one for it. > Since we have acc = 0 we can directly use cpu_LO[0]

Re: [Qemu-devel] [PATCH 03/11] net: lan9118: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
On 9/28/18 4:48 PM, Peter Maydell wrote: > On 28 September 2018 at 14:49, Cédric Le Goater wrote: >> Signed-off-by: Cédric Le Goater >> --- >> hw/net/lan9118.c | 24 ++-- >> 1 file changed, 10 insertions(+), 14 deletions(-) >> >> diff --git a/hw/net/lan9118.c b/hw/net/lan9118

Re: [Qemu-devel] [PATCH 09/11] net: stellaris_enet: convert SysBus init method to a realize method

2018-09-28 Thread Philippe Mathieu-Daudé
On 28/09/2018 15:50, Cédric Le Goater wrote: > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/stellaris_enet.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/hw/net/stellaris_e

Re: [Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus init method to a realize method

2018-09-28 Thread Philippe Mathieu-Daudé
On 28/09/2018 15:49, Cédric Le Goater wrote: > Cc: Michael Walle > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/milkymist-minimac2.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/net/milkymist-minimac2.c b/hw/net/mi

Re: [Qemu-devel] [PATCH 04/11] net: lance: convert SysBus init method to a realize method

2018-09-28 Thread Philippe Mathieu-Daudé
On 28/09/2018 15:49, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/lance.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/hw/net/lance.c b/hw/net/lance.c > index a08d5ac6a848..f987b2fd180f 100644

Re: [Qemu-devel] [PATCH 06/11] net: mipsnet: convert SysBus init method to a realize method

2018-09-28 Thread Philippe Mathieu-Daudé
On 28/09/2018 15:49, Cédric Le Goater wrote: > Cc: Aleksandar Markovic > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/mipsnet.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/net/mipsnet.c b/hw/net/mipsnet.c > index

Re: [Qemu-devel] [PATCH 08/11] net: smc91c111: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
On 9/28/18 4:45 PM, Peter Maydell wrote: > On 28 September 2018 at 14:50, Cédric Le Goater wrote: >> Signed-off-by: Cédric Le Goater >> --- >> hw/net/smc91c111.c | 22 +- >> 1 file changed, 9 insertions(+), 13 deletions(-) >> >> diff --git a/hw/net/smc91c111.c b/hw/net/smc91c

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-28 Thread Cornelia Huck
On Fri, 28 Sep 2018 16:22:12 +0200 Halil Pasic wrote: > On 09/27/2018 02:29 PM, Thomas Huth wrote: > >> +static void vfio_ap_bus_class_init(ObjectClass *klass, void *data) > >> +{ > >> +BusClass *k = BUS_CLASS(klass); > > I think calling the variable "oc" (or something similar) instead of >

Re: [Qemu-devel] [PATCH] i386: correct cpu_x86_cpuid(0xd)

2018-09-28 Thread Eduardo Habkost
On Fri, Sep 28, 2018 at 12:43:19PM +0200, Sebastian Andrzej Siewior wrote: > Intel SDM says for CPUID function 0DH, sub-function 0: > > | • ECX enumerates the size (in bytes) required by the XSAVE instruction for > an > | XSAVE area containing all the user state components supported by this > |

Re: [Qemu-devel] [PATCH] linux-user: Suppress address-of-packed-member warnings in __get/put_user_e

2018-09-28 Thread Laurent Vivier
Le 28/09/2018 à 16:25, Peter Maydell a écrit : > Our __get_user_e() and __put_user_e() macros cause newer versions > of clang to generate false-positive -Waddress-of-packed-member > warnings if they are passed the address of a member of a packed > struct (see https://bugs.llvm.org/show_bug.cgi?id=3

Re: [Qemu-devel] [PATCH 07/11] net: opencores_eth: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Cc: Max Filippov > Signed-off-by: Cédric Le Goater > --- > hw/net/opencores_eth.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 06/11] net: mipsnet: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Cc: Aleksandar Markovic > Signed-off-by: Cédric Le Goater > --- > hw/net/mipsnet.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-28 Thread Tony Krowiak
On 09/28/2018 09:57 AM, Halil Pasic wrote: On 09/27/2018 12:54 AM, Tony Krowiak wrote: From: Tony Krowiak Introduces the base object model for virtualizing AP devices. [..] + +static char *vfio_ap_bus_get_dev_path(DeviceState *dev) Cover letter states you want to remove vifo_ap refere

Re: [Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Cc: Michael Walle > Signed-off-by: Cédric Le Goater > --- > hw/net/milkymist-minimac2.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c > index 3e

Re: [Qemu-devel] [PATCH 04/11] net: lance: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/net/lance.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 03/11] net: lan9118: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/net/lan9118.c | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) > > diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c > index b9032dac595f..d99c6127b938 100644 > --

Re: [Qemu-devel] [PATCH 01/11] net: etraxfs_eth: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Cc: Edgar E. Iglesias > Signed-off-by: Cédric Le Goater > --- > hw/net/etraxfs_eth.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 02/11] net: etraxfs_eth: add a reset method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:49, Cédric Le Goater wrote: > Cc: Edgar E. Iglesias > Signed-off-by: Cédric Le Goater > --- > hw/net/etraxfs_eth.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c > index 64ab3df1ae38..552

Re: [Qemu-devel] [PATCH 08/11] net: smc91c111: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:50, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/net/smc91c111.c | 22 +- > 1 file changed, 9 insertions(+), 13 deletions(-) > > diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c > index d2fd2040e81c..5a43afc0d3c2 100644 >

Re: [Qemu-devel] [PATCH 11/11] net: xgmac: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:50, Cédric Le Goater wrote: > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: Rob Herring > Signed-off-by: Cédric Le Goater > --- > hw/net/xgmac.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 10/11] net: stellaris_enet: add a reset method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:50, Cédric Le Goater wrote: > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Signed-off-by: Cédric Le Goater > --- > hw/net/stellaris_enet.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 09/11] net: stellaris_enet: convert SysBus init method to a realize method

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 14:50, Cédric Le Goater wrote: > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Signed-off-by: Cédric Le Goater > --- > hw/net/stellaris_enet.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH] block-backend: Set werror/rerror defaults in blk_new()

2018-09-28 Thread Eric Blake
On 9/28/18 4:18 AM, Kevin Wolf wrote: Currently, the default values for werror and rerror have to be set explicitly with blk_set_on_error() by the callers of blk_new(). The only caller actually doing this is blockdev_init(), which is called for BlockBackends created using -drive. In particular,

Re: [Qemu-devel] [PATCH 7/7] qcow2: async scheme for qcow2_co_pwritev

2018-09-28 Thread Max Reitz
On 07.08.18 19:43, Vladimir Sementsov-Ogievskiy wrote: > Start several async requests instead of read chunk by chunk. > > Iotest 026 output is changed, as because of async io error path has > changed. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.c | 4

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-28 Thread Halil Pasic
On 09/27/2018 02:29 PM, Thomas Huth wrote: >> +static void vfio_ap_bus_class_init(ObjectClass *klass, void *data) >> +{ >> +BusClass *k = BUS_CLASS(klass); > I think calling the variable "oc" (or something similar) instead of > "klass" is prefered nowadays. > >> +k->get_dev_path = vfio_

Re: [Qemu-devel] [PATCH 5/7] qcow2: refactor qcow2_co_pwritev: split out qcow2_co_do_pwritev

2018-09-28 Thread Max Reitz
On 07.08.18 19:43, Vladimir Sementsov-Ogievskiy wrote: > Split out block which will be reused in async scheme. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.c | 138 > -- > 1 file changed, 86 insertions(+), 52 deletio

Re: [Qemu-devel] [PULL 00/42] Block patches

2018-09-28 Thread Peter Maydell
On 25 September 2018 at 18:09, Peter Maydell wrote: > On 25 September 2018 at 16:14, Max Reitz wrote: >> The following changes since commit 506e4a00de01e0b29fa83db5cbbc3d154253b4ea: >> >> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-3.1-20180925' >> into staging (2018-09-25 13:30

[Qemu-devel] [PATCH] linux-user: Suppress address-of-packed-member warnings in __get/put_user_e

2018-09-28 Thread Peter Maydell
Our __get_user_e() and __put_user_e() macros cause newer versions of clang to generate false-positive -Waddress-of-packed-member warnings if they are passed the address of a member of a packed struct (see https://bugs.llvm.org/show_bug.cgi?id=39113). Suppress these using the _Pragma() operator. To

Re: [Qemu-devel] [PATCH 6/7] qcow2: refactor qcow2_co_pwritev locals scope

2018-09-28 Thread Max Reitz
On 07.08.18 19:43, Vladimir Sementsov-Ogievskiy wrote: > Move local variables related to individual loop iteration into while > block. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH V9 4/4] tests: Add migration test for aarch64

2018-09-28 Thread Dr. David Alan Gilbert
* Wei Huang (w...@redhat.com) wrote: > > > On 09/28/2018 09:04 AM, Dr. David Alan Gilbert wrote: > > * Wei Huang (w...@redhat.com) wrote: > >> > >> > >> On 09/26/2018 11:31 AM, Dr. David Alan Gilbert wrote: > >>> * Wei Huang (w...@redhat.com) wrote: > This patch adds migration test support f

Re: [Qemu-devel] [PATCH V9 4/4] tests: Add migration test for aarch64

2018-09-28 Thread Wei Huang
On 09/28/2018 09:04 AM, Dr. David Alan Gilbert wrote: > * Wei Huang (w...@redhat.com) wrote: >> >> >> On 09/26/2018 11:31 AM, Dr. David Alan Gilbert wrote: >>> * Wei Huang (w...@redhat.com) wrote: This patch adds migration test support for aarch64. The test code, which implements the s

Re: [Qemu-devel] [PATCH v2 2/9] target/arm: Convert v8 extensions from feature bits to isar tests

2018-09-28 Thread Philippe Mathieu-Daudé
On 27/09/2018 23:13, Richard Henderson wrote: > Most of the v8 extensions are self-contained within the ISAR > registers and are not implied by other feature bits, which > makes them the easiest to convert. Lovely! > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH v9 3/6] s390x/kvm: enable AP instruction interpretation for guest

2018-09-28 Thread Tony Krowiak
On 09/27/2018 03:52 AM, David Hildenbrand wrote: On 27/09/2018 00:54, Tony Krowiak wrote: From: Tony Krowiak Let's use the KVM_SET_DEVICE_ATTR ioctl to enable hardware interpretation of AP instructions executed on the guest. If the S390_FEAT_AP feature is switched on for the guest, AP instruct

Re: [Qemu-devel] [PATCH v3 6/9] x86_iommu/amd: Add interrupt remap support when VAPIC is not enabled

2018-09-28 Thread Michael S. Tsirkin
On Fri, Sep 28, 2018 at 11:12:37AM +0800, Peter Xu wrote: > On Thu, Sep 27, 2018 at 12:28:42PM +, Singh, Brijesh wrote: > > >> +static bool amdvi_validate_int_remap(AMDVIState *s, uint64_t *dte) > > >> +{ > > >> +/* Check if IR is enabled in DTE */ > > >> +if (!(dte[2] & AMDVI_IR_REMAP_

Re: [Qemu-devel] [PATCH v2 1/9] target/arm: Define fields of ISAR registers

2018-09-28 Thread Philippe Mathieu-Daudé
On 27/09/2018 23:13, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 80 > 1 file changed, 80 insertions(+) > > diff --git a/target/arm/cpu.h b/target/arm/cpu.h > index 65c0fa0a65..e1b9270b8c 100644 > --- a/t

Re: [Qemu-devel] [PATCH V9 4/4] tests: Add migration test for aarch64

2018-09-28 Thread Dr. David Alan Gilbert
* Wei Huang (w...@redhat.com) wrote: > > > On 09/26/2018 11:31 AM, Dr. David Alan Gilbert wrote: > > * Wei Huang (w...@redhat.com) wrote: > >> This patch adds migration test support for aarch64. The test code, which > >> implements the same functionality as x86, is booted as a kernel in qemu. > >

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-28 Thread Halil Pasic
On 09/27/2018 12:54 AM, Tony Krowiak wrote: > From: Tony Krowiak > > Introduces the base object model for virtualizing AP devices. > [..] > + > +static char *vfio_ap_bus_get_dev_path(DeviceState *dev) Cover letter states you want to remove vifo_ap references form the bus. Sane thing to do

[Qemu-devel] [PATCH 10/11] net: stellaris_enet: add a reset method

2018-09-28 Thread Cédric Le Goater
Cc: Peter Maydell Cc: qemu-...@nongnu.org Signed-off-by: Cédric Le Goater --- hw/net/stellaris_enet.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c index 3ee1e0f8a43f..b3375ebb459c 100644 --- a/hw/net/stellaris_enet.c

[Qemu-devel] [PATCH 09/11] net: stellaris_enet: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Cc: Peter Maydell Cc: qemu-...@nongnu.org Signed-off-by: Cédric Le Goater --- hw/net/stellaris_enet.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c index 165562d7886a..3ee1e0f8a43f 100644 --- a/hw/net/stellaris_enet.

[Qemu-devel] [PATCH 06/11] net: mipsnet: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Cc: Aleksandar Markovic Signed-off-by: Cédric Le Goater --- hw/net/mipsnet.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/net/mipsnet.c b/hw/net/mipsnet.c index 5a63df7ccb91..03b310427860 100644 --- a/hw/net/mipsnet.c +++ b/hw/net/mipsnet.c @@ -236,9 +236,9 @@

[Qemu-devel] [PATCH 03/11] net: lan9118: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/net/lan9118.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c index b9032dac595f..d99c6127b938 100644 --- a/hw/net/lan9118.c +++ b/hw/net/lan9118.c @@ -1320,9 +1320,9 @@ stati

[Qemu-devel] [PATCH 08/11] net: smc91c111: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/net/smc91c111.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c index d2fd2040e81c..5a43afc0d3c2 100644 --- a/hw/net/smc91c111.c +++ b/hw/net/smc91c111.c @@ -766,9 +766,9 @@

Re: [Qemu-devel] [PATCH V9 4/4] tests: Add migration test for aarch64

2018-09-28 Thread Wei Huang
On 09/26/2018 11:31 AM, Dr. David Alan Gilbert wrote: > * Wei Huang (w...@redhat.com) wrote: >> This patch adds migration test support for aarch64. The test code, which >> implements the same functionality as x86, is booted as a kernel in qemu. >> Here are the design choices we make for aarch64:

[Qemu-devel] [PATCH 07/11] net: opencores_eth: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Cc: Max Filippov Signed-off-by: Cédric Le Goater --- hw/net/opencores_eth.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.c index d42b79c08c6a..d6f54f8d8208 100644 --- a/hw/net/opencores_eth.c +++ b/hw/net/opencores_eth.

[Qemu-devel] [PATCH 04/11] net: lance: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/net/lance.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/net/lance.c b/hw/net/lance.c index a08d5ac6a848..f987b2fd180f 100644 --- a/hw/net/lance.c +++ b/hw/net/lance.c @@ -97,9 +97,9 @@ static const VMStateDescription vmstat

[Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Cc: Michael Walle Signed-off-by: Cédric Le Goater --- hw/net/milkymist-minimac2.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c index 3eaa19dfde92..5e7304a26a50 100644 --- a/hw/net/milkymist-minimac2.c +++ b

[Qemu-devel] [PATCH 11/11] net: xgmac: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: Rob Herring Signed-off-by: Cédric Le Goater --- hw/net/xgmac.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/net/xgmac.c b/hw/net/xgmac.c index fa001563d3de..63f5a62ebf1b 100644 --- a/hw/net/xgmac.c +++ b/hw/net/xgm

[Qemu-devel] [PATCH 01/11] net: etraxfs_eth: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Cc: Edgar E. Iglesias Signed-off-by: Cédric Le Goater --- hw/net/etraxfs_eth.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c index a6932432b164..64ab3df1ae38 100644 --- a/hw/net/etraxfs_eth.c +++ b/hw/net/etraxfs_eth

[Qemu-devel] [PATCH 00/11] net: convert SysBus init method to a realize method

2018-09-28 Thread Cédric Le Goater
Hello, Here is my take to the SysBus init to realize method conversion. I picked the /net directory and did them all. Also added a couple of reset methods in separate patches. make check tested Thanks, C. Cédric Le Goater (11): net: etraxfs_eth: convert SysBus init method to a realize method

[Qemu-devel] [PATCH 02/11] net: etraxfs_eth: add a reset method

2018-09-28 Thread Cédric Le Goater
Cc: Edgar E. Iglesias Signed-off-by: Cédric Le Goater --- hw/net/etraxfs_eth.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c index 64ab3df1ae38..552a18c7c730 100644 --- a/hw/net/etraxfs_eth.c +++ b/hw/net/etraxfs_eth.c

Re: [Qemu-devel] [PULL 0/5] Block and testing patches

2018-09-28 Thread Peter Maydell
On 26 September 2018 at 03:55, Fam Zheng wrote: > The following changes since commit c5e4e49258e9b89cb34c085a419dd9f862935c48: > > Merge remote-tracking branch 'remotes/xanclic/tags/pull-block-2018-09-25' > into staging (2018-09-25 16:47:35 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v2 4/9] target/arm: Fix cortex-a7 id_isar0

2018-09-28 Thread Philippe Mathieu-Daudé
On 27/09/2018 23:13, Richard Henderson wrote: > The incorrect value advertised only thumb2 div without arm div. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/cpu.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/targe

Re: [Qemu-devel] [PATCH] hw/scsi/mptendian: Avoid taking address of fields in packed structs

2018-09-28 Thread Peter Maydell
On 28 September 2018 at 13:04, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 27/09/2018 15:48, Peter Maydell wrote: >> Taking the address of a field in a packed struct is a bad idea, because >> it might not be actually aligned enough for that pointer type (and >> thus cause a crash on dereferen

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-28 Thread Halil Pasic
On 09/27/2018 02:52 PM, Cornelia Huck wrote: > On Thu, 27 Sep 2018 14:29:01 +0200 > Thomas Huth wrote: > >> On 2018-09-27 00:54, Tony Krowiak wrote: >>> From: Tony Krowiak >>> >>> Introduces the base object model for virtualizing AP devices. >>> >>> Signed-off-by: Tony Krowiak >>> --- > >

Re: [Qemu-devel] [PATCH qemu v2] hw/char/sh_serial: Add timeout handling to unbreak serial input

2018-09-28 Thread Geert Uytterhoeven
Hi Paolo, On Tue, Sep 11, 2018 at 3:11 PM Paolo Bonzini wrote: > On 05/09/2018 15:11, Geert Uytterhoeven wrote: > > As of commit 18e8cf159177100e ("serial: sh-sci: increase RX FIFO trigger > > defaults for (H)SCIF") in Linux v4.11-rc1, the serial console on the > > QEMU SH4 target is broken: it d

  1   2   >