Re: [Qemu-devel] [PATCH 0/7] memory: address_space_to_flatview needs RCU lock

2018-03-05 Thread Alexey Kardashevskiy
On 05/03/18 19:36, Paolo Bonzini wrote: > I noticed that the introduction of flatview_{read,write} placed > address_space_to_flatview outside the RCU lock. This is wrong and has > to be fixed, because address_space_to_flatview does an atomic_rcu_read. > These patches fix this one function at a tim

Re: [Qemu-devel] [PATCH v1 1/1] iotests: bypass s390x for case 200

2018-03-05 Thread Christian Borntraeger
Nack. This will be fixed by s390/ipl: only print boot menu error if -boot menu=on was specified On 03/06/2018 08:54 AM, QingFeng Hao wrote: > In s390x, the case 200 failed as: > === Starting QEMU VM === > > +QEMU_PROG: boot menu is not supported for this device type. > {"return": {}} > > ==

Re: [Qemu-devel] [PATCH 7/7] address_space_rw: address_space_to_flatview needs RCU lock

2018-03-05 Thread Alexey Kardashevskiy
On 05/03/18 19:36, Paolo Bonzini wrote: > address_space_rw is calling address_space_to_flatview but it can > be called outside the RCU lock. To fix it, transform flatview_rw > into address_space_rw, since flatview_rw is otherwise unused. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Paolo Bonzi

[Qemu-devel] [PATCH v1 1/1] iotests: bypass s390x for case 200

2018-03-05 Thread QingFeng Hao
In s390x, the case 200 failed as: === Starting QEMU VM === +QEMU_PROG: boot menu is not supported for this device type. {"return": {}} === Sending stream/cancel, checking for SIGSEGV only === Failures: 200 Failed 1 of 1 tests It was caused by the command which isn't supported by s390x now: qe

Re: [Qemu-devel] [PATCH 6/7] address_space_map: address_space_to_flatview needs RCU lock

2018-03-05 Thread Alexey Kardashevskiy
On 05/03/18 19:36, Paolo Bonzini wrote: > address_space_map is calling address_space_to_flatview but it can > be called outside the RCU lock. The function itself is calling > rcu_read_lock/rcu_read_unlock, just in the wrong place, so the > fix is easy. > > Cc: qemu-sta...@nongnu.org > Signed-off-

Re: [Qemu-devel] [PATCH 5/7] address_space_access_valid: address_space_to_flatview needs RCU lock

2018-03-05 Thread Alexey Kardashevskiy
On 05/03/18 19:36, Paolo Bonzini wrote: > address_space_access_valid is calling address_space_to_flatview but it can > be called outside the RCU lock. To fix it, push the rcu_read_lock/unlock > pair up from flatview_access_valid to address_space_access_valid. > > Cc: qemu-sta...@nongnu.org > Sign

Re: [Qemu-devel] [PATCH 4/7] address_space_read: address_space_to_flatview needs RCU lock

2018-03-05 Thread Alexey Kardashevskiy
On 05/03/18 19:36, Paolo Bonzini wrote: > address_space_read is calling address_space_to_flatview but it can > be called outside the RCU lock. To fix it, push the rcu_read_lock/unlock > pair up from flatview_read_full to address_space_read's constant size > fast path and address_space_read_full. >

Re: [Qemu-devel] [PATCH 2/7] memory: inline some performance-sensitive accessors

2018-03-05 Thread Alexey Kardashevskiy
On 05/03/18 19:36, Paolo Bonzini wrote: > These accessors are called from inlined functions, and the call sequence > is much more expensive than just inlining the access. Move the > struct declaration to memory-internal.h so that exec.c and memory.c > can both use an inline function. > > Cc: qemu

Re: [Qemu-devel] [PATCH v3 00/12] Introduce new iommu notifier framework for virt-SVA

2018-03-05 Thread Liu, Yi L
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Tuesday, March 6, 2018 2:56 PM > Subject: Re: [PATCH v3 00/12] Introduce new iommu notifier framework for > virt-SVA > > On Thu, Mar 01, 2018 at 06:33:23PM +0800, Liu, Yi L wrote: > > This patchset is to introduce a notifier framework for virt-S

[Qemu-devel] [PATCH 7/7] audio/sdl: build as module

2018-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure | 2 +- audio/Makefile.objs | 9 ++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 3abee54cfc..b1930cd828 100755 --- a/configure +++ b/configure @@ -5983,7 +5983,7 @@ echo "CONFIG_AUDIO_DRIVERS

Re: [Qemu-devel] [PATCH 3/7] address_space_write: address_space_to_flatview needs RCU lock

2018-03-05 Thread Alexey Kardashevskiy
On 05/03/18 19:36, Paolo Bonzini wrote: > address_space_write is calling address_space_to_flatview but it can > be called outside the RCU lock. To fix it, push the rcu_read_lock/unlock > pair up from flatview_write to address_space_write. > > Cc: qemu-sta...@nongnu.org Reviewed-by: Alexey Kardas

[Qemu-devel] [PATCH 1/7] audio: add driver registry

2018-03-05 Thread Gerd Hoffmann
Add registry for audio drivers, using the existing audio_driver struct. Make all drivers register themself. The old list of audio_driver struct pointers is now a list of audio driver names, specifying the priority (aka probe order) in case no driver is explicitly asked for. Signed-off-by: Gerd Ho

Re: [Qemu-devel] [PATCH 1/7] openpic_kvm: drop address_space_to_flatview call

2018-03-05 Thread Alexey Kardashevskiy
On 05/03/18 19:36, Paolo Bonzini wrote: > The MemoryListener is registered on address_space_memory, there is > not much to assert. This currently works because the callback > is invoked only once when the listener is registered, but section->fv > is the _new_ FlatView, not the old one on later cal

[Qemu-devel] [PATCH 4/7] audio/alsa: build as module

2018-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure | 7 ++- audio/Makefile.objs | 7 +-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 27d3f66bd5..46274301bd 100755 --- a/configure +++ b/configure @@ -5982,7 +5982,12 @@ fi echo "CONFIG_AUDI

[Qemu-devel] [PATCH 3/7] build: enable audio modules

2018-03-05 Thread Gerd Hoffmann
Add audio/ to common-obj-m variable. Also run both audio and ui variables through unnest-vars. This avoids sdl.mo (exists in both audio/ and ui/) name clashes. Signed-off-by: Gerd Hoffmann --- Makefile | 4 Makefile.objs | 1 + 2 files changed, 5 insertions(+) diff --git a/Makefile b

[Qemu-devel] [PATCH 0/7] audio: modularize

2018-03-05 Thread Gerd Hoffmann
Add audio driver (host backend) registry. Add audio module support. Enable module builds for alsa, oss, pulse and sdl. Gerd Hoffmann (7): audio: add driver registry audio: add module loading support build: enable audio modules audio/alsa: build as module audio/oss: build as module aud

[Qemu-devel] [PATCH 2/7] audio: add module loading support

2018-03-05 Thread Gerd Hoffmann
Make audio_driver_lookup() try load the module in case it doesn't find the driver in the registry. Also load all modules for -audio-help, so the help output includes the help text for modular audio drivers. Signed-off-by: Gerd Hoffmann --- include/qemu/module.h | 1 + audio/audio.c | 2

[Qemu-devel] [PATCH 6/7] audio/pulseaudio: build as module

2018-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure | 2 +- audio/Makefile.objs | 7 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 5014c900bd..3abee54cfc 100755 --- a/configure +++ b/configure @@ -5983,7 +5983,7 @@ echo "CONFIG_AUDIO_DRIVERS=$

[Qemu-devel] [PATCH 5/7] audio/oss: build as module

2018-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure | 2 +- audio/Makefile.objs | 7 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 46274301bd..5014c900bd 100755 --- a/configure +++ b/configure @@ -5983,7 +5983,7 @@ echo "CONFIG_AUDIO_DRIVERS=$

Re: [Qemu-devel] [PATCH v3 21/29] vhost+postcopy: Add vhost waker

2018-03-05 Thread Peter Xu
On Mon, Mar 05, 2018 at 08:16:44PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Fri, Feb 16, 2018 at 01:16:17PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Register a waker function in vhost-user code to b

Re: [Qemu-devel] [PATCH v3 11/29] vhost+postcopy: Transmit 'listen' to client

2018-03-05 Thread Peter Xu
On Mon, Mar 05, 2018 at 05:42:42PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Fri, Feb 16, 2018 at 01:16:07PM +, Dr. David Alan Gilbert (git) > > wrote: > > > > [...] > > > > > typedef struct VuVirtqElement { > > > diff --git a/docs/interop/vhost-use

[Qemu-devel] [PATCH v4] scripts/checkpatch.pl: add check for `while` and `for`

2018-03-05 Thread Su Hang
Adding check for `while` and `for` statements, which condition has more than one line. The former checkpatch.pl can check `if` statement, which condition has more than one line, whether block misses brace round, like this: ''' if (cond1 || cond2) statement; ''' But it doesn't do the same c

Re: [Qemu-devel] [PATCH v3 00/12] Introduce new iommu notifier framework for virt-SVA

2018-03-05 Thread Peter Xu
On Thu, Mar 01, 2018 at 06:33:23PM +0800, Liu, Yi L wrote: > This patchset is to introduce a notifier framework for virt-SVA. > You may find virt-SVA design details from the link below. > > https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg04925.html > > SVA is short for Shared Virtual Add

Re: [Qemu-devel] [PATCH 3/3] vfio/pci: Add ioeventfd support

2018-03-05 Thread kbuild test robot
Hi Alex, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.16-rc4 next-20180306] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/c

Re: [Qemu-devel] [PATCH v3 07/12] vfio/pci: register sva notifier

2018-03-05 Thread Peter Xu
On Thu, Mar 01, 2018 at 06:33:30PM +0800, Liu, Yi L wrote: > This patch shows how sva notifier is registered. And provided > an example by registering notify func for tlb flush propagation. > > Signed-off-by: Liu, Yi L > --- > hw/vfio/pci.c | 55 ++

[Qemu-devel] [PATCH risu 3/3] risu_reginfo_ppc64.c: Fix register name prefix

2018-03-05 Thread Sandipan Das
Use 'f' instead of 'r' as the prefix when dumping the values of floating-point registers. Signed-off-by: Sandipan Das --- risu_reginfo_ppc64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/risu_reginfo_ppc64.c b/risu_reginfo_ppc64.c index eb9c12b..5f33648 100644 --- a/r

[Qemu-devel] [PATCH risu 2/3] ppc64.risu: Fix pattern for load qword

2018-03-05 Thread Sandipan Das
The pattern for the Load Quadword (lq) instruction is fixed. If rtp is 0 or 12, the instruction will overwrite r0, r1 or r12, r13 respectively. However, r1 is the stack frame pointer and r13 is the thread pointer. So, overwriting them can cause a crash. This is avoided by putting a constraint to p

[Qemu-devel] [PATCH risu 1/3] ppc64.risu: Add missing byte and dword loads

2018-03-05 Thread Sandipan Das
The patterns for the following instructions are added: * Load Byte and Zero (lbz) * Load Byte and Zero with Update (lbzu) * Load Byte and Zero Indexed (lbzx) * Load Byte and Zero with Update Indexed (lbzux) * Load Doubleword (ld) Signed-off-by: Sandipan Das --- ppc64.risu | 25 +

Re: [Qemu-devel] [BUG] I/O thread segfault for QEMU on s390x

2018-03-05 Thread Martin Schwidefsky
On Mon, 5 Mar 2018 20:08:45 +0100 Christian Borntraeger wrote: > Do you happen to run with a recent host kernel that has > > commit 7041d28115e91f2144f811ffe8a195c696b1e1d0 > s390: scrub registers on kernel entry and KVM exit > > Can you run with this on top > diff --git a/arch/s390/kernel

[Qemu-devel] [PATCH v2] pc-bios/s390-ccw: Move string arrays from bootmap header to .c file

2018-03-05 Thread Thomas Huth
bootmap.h can currently only be included once - otherwise the linker complains about multiple definitions of the "magic" strings. It's a bad style to define string arrays in header files, so let's better move these to the bootmap.c file instead where they are used. Signed-off-by: Thomas Huth ---

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: Move string arrays from bootmap header to .c file

2018-03-05 Thread Thomas Huth
On 05.03.2018 20:32, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. [...] > /var/tmp/patchew-tester-tmp-tbi65_5t/src/pc-bios/s390-ccw/bootmap.c:51:22: > error: ‘vol_desc_magic’ defined but not used [-Werror=unused-const-variable=]

[Qemu-devel] [PATCH v2 7/9] chardev: tcp: postpone async connection setup

2018-03-05 Thread Peter Xu
This patch allows the socket chardev async connection be setup with non-default gcontext. We do it by postponing the setup to machine done, since until then we can know which context we should run the async operation on. Reviewed-by: Paolo Bonzini Signed-off-by: Peter Xu --- chardev/char-socke

[Qemu-devel] [PATCH v2 9/9] chardev: tcp: postpone TLS work until machine done

2018-03-05 Thread Peter Xu
TLS handshake may create background GSource tasks, while we won't know the correct GMainContext until the whole chardev (including frontend) inited. Let's postpone the initial TLS handshake until machine done. For dynamically created tcp chardev, we don't postpone that by checking the init_machin

[Qemu-devel] [PATCH v2 6/9] chardev: use chardev's gcontext for async connect

2018-03-05 Thread Peter Xu
Generalize the function to create the async QIO task connection. Also, fix the context pointer to use the chardev's gcontext. Reviewed-by: Paolo Bonzini Signed-off-by: Peter Xu --- chardev/char-socket.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --g

[Qemu-devel] [PATCH v2 5/9] chardev: introduce chr_machine_done hook

2018-03-05 Thread Peter Xu
Introduce ChardevClass.chr_machine_done() hook so that chardevs can run customized procedures after machine init. There was an existing mux user already that did similar thing but used a raw machine done notifier. Generalize it into a framework, and let the mux chardevs provide such a class-speci

[Qemu-devel] [PATCH v2 1/9] vl: export machine_init_done

2018-03-05 Thread Peter Xu
We have that variable but not exported. Export that so modules can have a way to poke on whether machine init has finished. Meanwhile, set that up even before calling the notifiers, so that notifiers who may depend on this field will get a correct answer. Suggested-by: Paolo Bonzini Reviewed-by

[Qemu-devel] [PATCH v2 8/9] chardev: tcp: let TLS run on chardev context

2018-03-05 Thread Peter Xu
Now qio_channel_tls_handshake() is ready to receive the context. Let socket chardev use it, then the TLS handshake of chardev will always be with the chardev's context. Signed-off-by: Peter Xu --- chardev/char-socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/

[Qemu-devel] [PATCH v2 4/9] chardev: allow telnet gsource to switch gcontext

2018-03-05 Thread Peter Xu
It was originally created by qio_channel_add_watch() so it's always assigning the task to main context. Now we use the new API called qio_channel_add_watch_source() so that we get the GSource handle rather than the tag ID. Meanwhile, caching the gsource and TCPChardevTelnetInit (which holds the h

[Qemu-devel] [PATCH v2 0/9] chardev: qio related non-default context support

2018-03-05 Thread Peter Xu
Based-on: <20180305064324.9238-1-pet...@redhat.com> This series is based on the QIO part: [PATCH v3 0/6] qio: general non-default GMainContext support v2: - fix the reported problem by patchew in patch 5 - added some r-bs from Marc-Andre Please review, thanks. Peter Xu (9): vl: export machi

[Qemu-devel] [PATCH v2 2/9] chardev: fix leak in tcp_chr_telnet_init_io()

2018-03-05 Thread Peter Xu
Need to free TCPChardevTelnetInit when session established. Since at it, switch to use G_SOURCE_* macros. Reviewed-by: Daniel P. Berrange Reviewed-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Signed-off-by: Peter Xu --- chardev/char-socket.c | 10 +++--- 1 file changed, 7 insertions(

[Qemu-devel] [PATCH v2 3/9] chardev: update net listener gcontext

2018-03-05 Thread Peter Xu
TCP chardevs can be using QIO network listeners working in the background when in listening mode. However the network listeners are always running in main context. This can race with chardevs that are running in non-main contexts. To solve this, we need to re-setup the net listeners in tcp_chr_u

Re: [Qemu-devel] [PATCH 5/9] chardev: introduce chr_machine_done hook

2018-03-05 Thread Peter Xu
On Mon, Mar 05, 2018 at 11:54:22AM +0100, Marc-André Lureau wrote: > Hi > > On Mon, Mar 5, 2018 at 7:50 AM, Peter Xu wrote: > > Introduce ChardevClass.chr_machine_done() hook so that chardevs can run > > customized procedures after machine init. > > > > There was an existing mux user already that

Re: [Qemu-devel] [PATCH 1/9] vl: export machine_init_done

2018-03-05 Thread Peter Xu
On Mon, Mar 05, 2018 at 12:48:27PM +0100, Marc-André Lureau wrote: > Hi > > On Mon, Mar 5, 2018 at 7:50 AM, Peter Xu wrote: > > We have that variable but not exported. Export that so modules can have > > a way to poke on whether machine init has finished. > > Which modules? E.g., the mux code

[Qemu-devel] [PATCH] tap: delete tap(net client) if net_init_tap_one failed

2018-03-05 Thread linzhecheng
If net_init_tap_one failed but net_tap_fd_init succeeded, we should delete the TAPState *s without vhostforce and has_vhostforce flag. Signed-off-by: linzhecheng diff --git a/net/tap.c b/net/tap.c index 2b3a36f9b5..1cb8eaf31f 100644 --- a/net/tap.c +++ b/net/tap.c @@ -651,7 +651,7 @@ static void

Re: [Qemu-devel] [PULL 00/30] ppc-for-2.12 queue 20180306

2018-03-05 Thread David Gibson
On Mon, Mar 05, 2018 at 08:30:40PM -0800, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20180306040154.3669-1-da...@gibson.dropbear.id.au > Subject: [Qemu-devel] [PULL 00/30] ppc-

Re: [Qemu-devel] [RFC PATCH v2 12/22] hw/isa/superio: Add a keyboard/mouse controller (8042)

2018-03-05 Thread David Gibson
On Mon, Mar 05, 2018 at 06:19:18PM -0300, Philippe Mathieu-Daudé wrote: > Since the PC87312 inherits this abstract model, we remove the I8042 > instance in the PREP machine. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson > --- > include/hw/isa/superio.h | 1 + > hw/isa/isa-s

Re: [Qemu-devel] [PATCH v3] scripts/checkpatch.pl: add check for `while` and `for`

2018-03-05 Thread Su Hang
As too many emails overwhelmed my email box, I am very sorry for not seeing your reply until this morning. I will fix wrong using of git right now! "Stefan Hajnoczi" wrote: > On Wed, Feb 28, 2018 at 11:31:29AM +0800, Su Hang wrote: > > Adding check for `while` and `for` statements, which conditi

[Qemu-devel] [PULL 23/30] ppc/spapr-caps: Convert cap-cfpc to custom spapr-cap

2018-03-05 Thread David Gibson
From: Suraj Jitindar Singh Convert cap-cfpc (cache flush on privilege change) to a custom spapr-cap type. Signed-off-by: Suraj Jitindar Singh [dwg: Don't explicitly list "?"/help option, trusting convention] [dwg: Strip no-longer-necessary ATTRIBUTE_UNUSED back off] [dwg: Fix some minor style p

[Qemu-devel] [PULL 28/30] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-03-05 Thread David Gibson
From: David Engraf This patch fixes an incorrect behavior when the -kernel argument has been specified without -bios. In this case the kernel was loaded twice. At address 32M as a raw image and afterwards by load_elf/load_uimage at the corresponding load address. In this case the region for the d

[Qemu-devel] [PULL 11/30] heathrow: QOMify heathrow PIC

2018-03-05 Thread David Gibson
From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: David Gibson --- hw/intc/heathrow_pic.c | 126 +++-- include/hw/intc/heathrow_pic.h | 49 2 files changed, 119 insertions(+), 56 deletions(-) create mode 100644

[Qemu-devel] [PULL 06/30] ppc: Add aCube Sam460ex board

2018-03-05 Thread David Gibson
From: BALATON Zoltan Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. This is not a complete implementation yet with a lot of components still missing but enough for the U-Boot firmware to start and to boot a Linux kernel or AROS. Signed-off-by: François Revol Signed-off-

[Qemu-devel] [PULL 21/30] target/ppc: Check mask when setting cap_ppc_safe_indirect_branch

2018-03-05 Thread David Gibson
From: Suraj Jitindar Singh Check the character and character_mask field when setting cap_ppc_safe_indirect_branch based on the hypervisor response to KVM_PPC_GET_CPU_CHAR. Previously the mask field wasn't checked which was incorrect. Fixes: 8acc2ae5 (target/ppc/kvm: Add cap_ppc_safe_[cache/boun

[Qemu-devel] [PULL 19/30] macio: move setting of CUDA timebase frequency to macio_common_realize()

2018-03-05 Thread David Gibson
From: Mark Cave-Ayland This removes the last of the functionality from macio_init() in preparation for its subsequent removal. Signed-off-by: Mark Cave-Ayland Reviewed-by: David Gibson Signed-off-by: David Gibson --- hw/misc/macio/macio.c | 7 ++- 1 file changed, 2 insertions(+), 5 delet

[Qemu-devel] [PULL 17/30] openpic: move OpenPIC state and related definitions to openpic.h

2018-03-05 Thread David Gibson
From: Mark Cave-Ayland This is to faciliate access to OpenPICState when wiring up the PIC to the macio controller. Signed-off-by: Mark Cave-Ayland Reviewed-by: David Gibson Signed-off-by: David Gibson --- hw/intc/openpic.c| 157 -- include/

[Qemu-devel] [PULL 16/30] openpic: move KVM-specific declarations into separate openpic_kvm.h file

2018-03-05 Thread David Gibson
From: Mark Cave-Ayland This is needed before the next patch because the target-dependent kvm stub uses the existing kvm_openpic_connect_vcpu() declaration, making it impossible to move the device-specific declarations into the same file without breaking ppc-linux-user compilation. Signed-off-by:

Re: [Qemu-devel] [Xen-devel] [RFC QEMU PATCH v4 00/10] Implement vNVDIMM for Xen HVM guest

2018-03-05 Thread Haozhong Zhang
On 03/02/18 12:03 +, Anthony PERARD wrote: > On Wed, Feb 28, 2018 at 05:36:59PM +0800, Haozhong Zhang wrote: > > On 02/27/18 17:22 +, Anthony PERARD wrote: > > > On Thu, Dec 07, 2017 at 06:18:02PM +0800, Haozhong Zhang wrote: > > > > This is the QEMU part patches that works with the associa

[Qemu-devel] [PULL 24/30] ppc/spapr-caps: Convert cap-sbbc to custom spapr-cap

2018-03-05 Thread David Gibson
From: Suraj Jitindar Singh Convert cap-sbbc (speculation barrier bounds checking) to a custom spapr-cap type. Signed-off-by: Suraj Jitindar Singh [dwg: Removed trailing whitespace] [dwg: Don't explicitly list "?"/help option, trust convention] [dwg: Fix some minor style problems] Signed-off-by:

[Qemu-devel] [PULL 12/30] heathrow: convert to trace-events

2018-03-05 Thread David Gibson
From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: David Gibson --- hw/intc/heathrow_pic.c | 32 +++- hw/intc/trace-events | 5 + 2 files changed, 16 insertions(+), 21 deletions(-) diff --git a/hw/intc/heathrow_pic.c b/hw/intc/heathrow_pic

[Qemu-devel] [PULL 22/30] ppc/spapr-caps: Add support for custom spapr_capabilities

2018-03-05 Thread David Gibson
From: Suraj Jitindar Singh There are currently 2 implemented types of spapr-caps, boolean and tristate. However there may be a need for caps which don't fit either of these options. Add a custom capability type for which a list of custom valid strings can be specified and implement the get/set fu

[Qemu-devel] [PULL 29/30] adb: add trace-events for monitoring keyboard/mouse during bus enumeration

2018-03-05 Thread David Gibson
From: Mark Cave-Ayland This is useful to help diagnose problems related to address clashes during MacOS 9 boot. Signed-off-by: Mark Cave-Ayland Signed-off-by: David Gibson --- hw/input/adb-kbd.c| 4 hw/input/adb-mouse.c | 5 + hw/input/trace-events | 5 + 3 files changed, 14

[Qemu-devel] [PULL 20/30] macio: remove macio_init() function

2018-03-05 Thread David Gibson
From: Mark Cave-Ayland Move the remaining comment into macio.c for reference, then remove the macio_init() function and instantiate the macio devices for both Old World and New World machines via qdev_init_nofail() directly. Signed-off-by: Mark Cave-Ayland Signed-off-by: David Gibson --- hw/m

[Qemu-devel] [PULL 18/30] mac_newworld: use object link to pass OpenPIC object to macio

2018-03-05 Thread David Gibson
From: Mark Cave-Ayland Also switch macio_newworld_realize() over to use it rather than using the pic_mem memory region directly. Now that both Old World and New World macio devices no longer make use of the pic_mem memory region directly, we can remove it. Signed-off-by: Mark Cave-Ayland Revi

[Qemu-devel] [PULL 25/30] ppc/spapr-caps: Convert cap-ibs to custom spapr-cap

2018-03-05 Thread David Gibson
From: Suraj Jitindar Singh Convert cap-ibs (indirect branch speculation) to a custom spapr-cap type. All tristate caps have now been converted to custom spapr-caps, so remove the remaining support for them. Signed-off-by: Suraj Jitindar Singh [dwg: Don't explicitly list "?"/help option, trust

[Qemu-devel] [PULL 14/30] macio: move macio related structures and defines into separate macio.h file

2018-03-05 Thread David Gibson
From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Reviewed-by: David Gibson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- hw/misc/macio/macio.c | 43 + hw/ppc/mac.h | 3 -- hw/ppc/mac_newworld.c | 1 + hw/p

[Qemu-devel] [PULL 26/30] ppc/spapr-caps: Define the pseries-2.12-sxxm machine type

2018-03-05 Thread David Gibson
From: Suraj Jitindar Singh The sxxm (speculative execution exploit mitigation) machine type is a variant of the 2.12 machine type with workarounds for speculative execution vulnerabilities enabled by default. Signed-off-by: Suraj Jitindar Singh Signed-off-by: David Gibson --- hw/ppc/spapr.c

[Qemu-devel] [PULL 00/30] ppc-for-2.12 queue 20180306

2018-03-05 Thread David Gibson
The following changes since commit f2bb2d14c2958f3f5aef456bd2cdb1ff99f4a562: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2018-03-05 16:41:20 +) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.12-20180306

[Qemu-devel] [PULL 27/30] hw/ppc/spapr, e500: Use new property "stdout-path" for boot console

2018-03-05 Thread David Gibson
From: Nikunj A Dadhania Linux kernel commit 2a9d832cc9aae21ea827520fef635b6c49a06c6d (of: Add bindings for chosen node, stdout-path) deprecated chosen property "linux,stdout-path" and "stdout". Introduce the new property "stdout-path" and continue supporting the older property to remain compatib

[Qemu-devel] [PULL 30/30] PowerPC: Add TS bits into msr_mask

2018-03-05 Thread David Gibson
From: Simon Guo During migration, after MSR bits is synced, cpu_post_load() will use msr_mask to determine which PPC MSR bits will be applied into the target side. Hardware Transaction Memory(HTM) has been supported since Power8, but TS0/TS1 bit was not in msr_mask yet. That will prevent target K

[Qemu-devel] [PULL 10/30] macio: move ESCC device within the macio device

2018-03-05 Thread David Gibson
From: Mark Cave-Ayland Now that the ESCC device is instantiated directly via qdev, move it to within the macio device and wire up the IRQs and memory regions using the sysbus API. This enables to remove the now-obsolete escc_mem parameter to the macio_init() function. (Note this patch also cont

[Qemu-devel] [PULL 04/30] roms: Added git submodule for u-boot-sam460 (firmware for sam460ex)

2018-03-05 Thread David Gibson
From: BALATON Zoltan Signed-off-by: BALATON Zoltan Signed-off-by: David Gibson --- .gitmodules | 3 +++ roms/Makefile| 7 +++ roms/u-boot-sam460ex | 1 + 3 files changed, 11 insertions(+) create mode 16 roms/u-boot-sam460ex diff --git a/.gitmodules b/.gitmodules inde

[Qemu-devel] [PULL 13/30] heathrow: change heathrow_pic_init() to return the heathrow device

2018-03-05 Thread David Gibson
From: Mark Cave-Ayland This enables the device to be made available during the setup of the Old World machine. In order to pass back the previous set of IRQs we temporarily introduce a new pic_irqs parameter until it can be removed. An additional benefit of this change is that it is also possibl

[Qemu-devel] [PULL 09/30] macio: embed DBDMA device directly within macio

2018-03-05 Thread David Gibson
From: Mark Cave-Ayland The current recommendation is to embed subdevices directly within their container device, so do this for the DBDMA device. Signed-off-by: Mark Cave-Ayland Signed-off-by: David Gibson --- hw/misc/macio/macio.c | 13 +++-- 1 file changed, 7 insertions(+), 6 delet

[Qemu-devel] [PULL 02/30] ppc440_uc: Fix unintialized variable warning with older gcc

2018-03-05 Thread David Gibson
From: BALATON Zoltan Signed-off-by: BALATON Zoltan Signed-off-by: David Gibson --- hw/ppc/ppc440_uc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c index 4e2523a64f..976ab2b5d8 100644 --- a/hw/ppc/ppc440_uc.c +++ b/hw/ppc/ppc440_uc.c @@ -1050,6

[Qemu-devel] [PULL 15/30] mac_oldworld: use object link to pass heathrow PIC object to macio

2018-03-05 Thread David Gibson
From: Mark Cave-Ayland Also switch macio_oldworld_realize() over to use it rather than using the pic_mem memory region directly. Signed-off-by: Mark Cave-Ayland Reviewed-by: David Gibson Signed-off-by: David Gibson --- hw/misc/macio/macio.c | 14 ++ hw/ppc/mac_oldworld.c

[Qemu-devel] [PULL 01/30] spapr: fix missing CPU core nodes in DT when running with TCG

2018-03-05 Thread David Gibson
From: Greg Kurz Commit 5d0fb1508e2d "spapr: consolidate the VCPU id numbering logic in a single place" introduced a helper to detect thread0 of a virtual core based on its VCPU id. This is used to create CPU core nodes in the DT, but it is broken in TCG. $ qemu-system-ppc64 -nographic -accel tcg

[Qemu-devel] [PULL 07/30] spapr: register dummy ICPs later

2018-03-05 Thread David Gibson
From: Greg Kurz Some older machine types create more ICPs than needed. We hence need to register up to xics_max_server_number() dummy ICPs to accomodate the migration of these machine types. Recent VSMT rework changed xics_max_server_number() to return DIV_ROUND_UP(max_cpus * spapr->vsmt, s

[Qemu-devel] [PULL 03/30] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs

2018-03-05 Thread David Gibson
From: BALATON Zoltan This is the PCIX controller found in newer 440 core SoCs e.g. the AMMC 460EX. The device tree refers to this as plb-pcix compared to the plb-pci controller in older 440 SoCs. Signed-off-by: BALATON Zoltan [dwg: Remove hwaddr from trace-events, that doesn't work with some t

[Qemu-devel] [PULL 08/30] spapr: harden code that depends on VSMT

2018-03-05 Thread David Gibson
From: Greg Kurz VSMT must be set in order to compute VCPU ids. This means that the following functions must not be called before spapr_set_vsmt_mode() was called: - spapr_vcpu_id() - spapr_is_thread0_in_vcore() - xics_max_server_number() We had a recent regression where the latter would be calle

Re: [Qemu-devel] [PATCHv1 00/14] Translation loop conversion for sh4/sparc/mips/s390x/openrisc targets

2018-03-05 Thread Michael Clark
On Tue, 6 Mar 2018 at 3:57 PM, Emilio G. Cota wrote: > On Tue, Mar 06, 2018 at 12:57:13 +1300, Michael Clark wrote: > > On Fri, Mar 2, 2018 at 11:53 AM, Emilio G. Cota wrote: > > > > > [ What is this all about? See this message: > > > http://lists.gnu.org/archive/html/qemu-devel/2018-02/msg047

Re: [Qemu-devel] [PATCH v3 20/29] postcopy: postcopy_notify_shared_wake

2018-03-05 Thread Peter Xu
On Mon, Mar 05, 2018 at 07:55:13PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Fri, Feb 16, 2018 at 01:16:16PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Add a hook to allow a client userfaultfd to be 'w

Re: [Qemu-devel] [edk2] [PATCH 3/7] HACK: HobLib: workaround infinite loop

2018-03-05 Thread Brian J. Johnson
On 03/05/2018 12:22 PM, Laszlo Ersek wrote: PEIMs generally "execute in place" (XIP), i.e. they run from flash, not RAM. In this status they use "temporary RAM" (e.g. CPU caches configured like RAM) for stack & heap; whatever HOBs they produce are stored in "temp RAM" as well. Then one of the PEI

Re: [Qemu-devel] [edk2] [PATCH 3/7] HACK: HobLib: workaround infinite loop

2018-03-05 Thread Gao, Liming
Laszlo: I also suggest to check the generated ProcessLibraryConstructorList () function. It is in the driver build output AutoGen.c code. You can check what library function be called in this function. Then, further add debug message in the library function. I suspect some function does the wr

Re: [Qemu-devel] [PATCH v2] PowerPC: Add TS bits into msr_mask

2018-03-05 Thread David Gibson
On Mon, Mar 05, 2018 at 06:53:48PM +0800, wei.guo.si...@gmail.com wrote: > From: Simon Guo > > During migration, after MSR bits is synced, cpu_post_load() will use > msr_mask to determine which PPC MSR bits will be applied into the target > side. Hardware Transaction Memory(HTM) has been supporte

Re: [Qemu-devel] [PATCH] adb: add trace-events for monitoring keyboard/mouse during bus enumeration

2018-03-05 Thread David Gibson
On Mon, Mar 05, 2018 at 09:51:13PM +, Mark Cave-Ayland wrote: > This is useful to help diagnose problems related to address clashes during > MacOS 9 boot. > > Signed-off-by: Mark Cave-Ayland Applied, thanks. > --- > hw/input/adb-kbd.c| 4 > hw/input/adb-mouse.c | 5 + > hw/in

[Qemu-devel] question about "warning: TCG doesn't support requested feature: CPUID.01H:ECX.f16c "

2018-03-05 Thread Wangjintang
Hi all, We run application with qemu, get the below error, the reason is that " TCG doesn't support requested feature: CPUID.01H:ECX.f16c ". Does TCG in qemu support " CPUID.01H:ECX.f16c "? If TCG in qemu support, then how to use? Thanks. $ sudo ./qemu-2.11.1_bin/bin/qemu-system-x86_6

Re: [Qemu-devel] [PATCHv1 00/14] Translation loop conversion for sh4/sparc/mips/s390x/openrisc targets

2018-03-05 Thread Emilio G. Cota
On Tue, Mar 06, 2018 at 12:57:13 +1300, Michael Clark wrote: > On Fri, Mar 2, 2018 at 11:53 AM, Emilio G. Cota wrote: > > > [ What is this all about? See this message: > > http://lists.gnu.org/archive/html/qemu-devel/2018-02/msg04785.html ] (snip) > > You can fetch this series from: > > https

[Qemu-devel] [PATCH] README: Fix typo 'git-publish'

2018-03-05 Thread Fam Zheng
Reported-by: Alberto Garcia Signed-off-by: Fam Zheng --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index 7833b97365..49a9fd09cd 100644 --- a/README +++ b/README @@ -73,7 +73,7 @@ The QEMU website is also maintained under source control. git clo

Re: [Qemu-devel] [PATCH v3 2/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-05 Thread Michael S. Tsirkin
On Tue, Mar 06, 2018 at 09:54:49AM +0800, Wei Wang wrote: > On 03/05/2018 10:09 PM, Michael S. Tsirkin wrote: > > On Mon, Mar 05, 2018 at 11:36:15AM +0800, Wei Wang wrote: > > > On 03/03/2018 02:37 AM, Michael S. Tsirkin wrote: > > > > On Fri, Mar 02, 2018 at 04:47:29PM +0800, Wei Wang wrote: > > >

Re: [Qemu-devel] [PATCH v3 2/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-05 Thread Wei Wang
On 03/05/2018 10:09 PM, Michael S. Tsirkin wrote: On Mon, Mar 05, 2018 at 11:36:15AM +0800, Wei Wang wrote: On 03/03/2018 02:37 AM, Michael S. Tsirkin wrote: On Fri, Mar 02, 2018 at 04:47:29PM +0800, Wei Wang wrote: diff --git a/include/sysemu/balloon.h b/include/sysemu/balloon.h index af49e19

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8

2018-03-05 Thread Michael Clark
On Tue, Mar 6, 2018 at 12:10 PM, Michael Clark wrote: > > > On Sun, Mar 4, 2018 at 11:52 AM, Peter Maydell > wrote: > >> On 3 March 2018 at 02:46, Michael Clark wrote: >> > On Sat, Mar 3, 2018 at 3:22 AM, Peter Maydell > > >> > wrote: >> >> Please don't send pull requests until after patches ha

Re: [Qemu-devel] [PATCH v3 2/5] qmp: distinguish PC-DIMM and NVDIMM in MemoryDeviceInfoList

2018-03-05 Thread Haozhong Zhang
On 03/05/18 13:14 -0600, Eric Blake wrote: > On 03/05/2018 12:57 AM, Haozhong Zhang wrote: > > It may need to treat PC-DIMM and NVDIMM differently, e.g., when > > deciding the necessity of non-volatile flag bit in SRAT memory > > affinity structures. > > > > NVDIMMDeviceInfo, which inherits from P

Re: [Qemu-devel] [RFC PATCH v2 03/22] hw/input/i8042: Extract declarations from i386/pc.h into input/i8042.h

2018-03-05 Thread David Gibson
On Mon, Mar 05, 2018 at 06:19:09PM -0300, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé hw/ppc part Acked-by: David Gibson > --- > include/hw/i386/pc.h | 9 - > include/hw/input/i8042.h | 24 > hw/alpha/dp264.c | 3 ++- > h

Re: [Qemu-devel] [RFC PATCH v2 04/22] hw/isa/pc87312: Rename the device type as TYPE_PC87312_SUPERIO

2018-03-05 Thread David Gibson
On Mon, Mar 05, 2018 at 06:19:10PM -0300, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé hw/ppc part Acked-by: David Gibson > --- > include/hw/isa/pc87312.h | 4 ++-- > hw/isa/pc87312.c | 2 +- > hw/ppc/prep.c| 2 +- > 3 files changed, 4 insertions(+)

Re: [Qemu-devel] [PATCH 1/7] openpic_kvm: drop address_space_to_flatview call

2018-03-05 Thread David Gibson
On Mon, Mar 05, 2018 at 09:36:49AM +0100, Paolo Bonzini wrote: > The MemoryListener is registered on address_space_memory, there is > not much to assert. This currently works because the callback > is invoked only once when the listener is registered, but section->fv > is the _new_ FlatView, not t

Re: [Qemu-devel] [PATCHv1 00/14] Translation loop conversion for sh4/sparc/mips/s390x/openrisc targets

2018-03-05 Thread Michael Clark
On Fri, Mar 2, 2018 at 11:53 AM, Emilio G. Cota wrote: > [ What is this all about? See this message: > http://lists.gnu.org/archive/html/qemu-devel/2018-02/msg04785.html ] > > Merged the separate patchsets I sent in the last couple of weeks into > one set. This will be easier to merge since it

Re: [Qemu-devel] [patches] Re: [PULL] RISC-V QEMU Port Submission

2018-03-05 Thread Michael Clark
On Tue, Mar 6, 2018 at 8:00 AM, Emilio G. Cota wrote: > On Sat, Mar 03, 2018 at 02:26:12 +1300, Michael Clark wrote: > > It was qemu-2.7.50 (late 2016). The benchmarks were generated mid last > year. > > > > I can run the benchmarks again... Has it doubled in speed? > > It depends on the benchmar

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8

2018-03-05 Thread Michael Clark
On Sun, Mar 4, 2018 at 11:52 AM, Peter Maydell wrote: > On 3 March 2018 at 02:46, Michael Clark wrote: > > On Sat, Mar 3, 2018 at 3:22 AM, Peter Maydell > > wrote: > >> Please don't send pull requests until after patches have been put > >> on list and been reviewed. A minor update to a pullreq

Re: [Qemu-devel] [PATCH v2 1/2] ipmi: Use proper struct reference for KCS vmstate

2018-03-05 Thread Corey Minyard
On 03/05/2018 08:09 AM, Dr. David Alan Gilbert wrote: * miny...@acm.org (miny...@acm.org) wrote: From: Corey Minyard The vmstate for isa_ipmi_kcs was referencing into the kcs structure, instead create a kcs structure separate and use that. There were also some issues in the state transfer. T

Re: [Qemu-devel] [PATCHv1 00/14] Translation loop conversion for sh4/sparc/mips/s390x/openrisc targets

2018-03-05 Thread Emilio G. Cota
On Mon, Mar 05, 2018 at 21:58:52 +, Mark Cave-Ayland wrote: > I don't have enough knowledge of TCG internals to review this myself, > however I can run it through my complete set of OpenBIOS test images for > qemu-system-sparc and qemu-system-sparc64 if that helps? That would be appreciated --

Re: [Qemu-devel] [PATCH v8 03/23] RISC-V CPU Core Definition

2018-03-05 Thread Michael Clark
On Mon, Mar 5, 2018 at 10:44 PM, Igor Mammedov wrote: > On Sat, 3 Mar 2018 02:51:31 +1300 > Michael Clark wrote: > > > Add CPU state header, CPU definitions and initialization routines > > > > Reviewed-by: Richard Henderson > > Signed-off-by: Sagar Karandikar > > Signed-off-by: Michael Clark

  1   2   3   4   >