On Mon, Mar 05, 2018 at 11:54:22AM +0100, Marc-André Lureau wrote: > Hi > > On Mon, Mar 5, 2018 at 7:50 AM, Peter Xu <pet...@redhat.com> wrote: > > Introduce ChardevClass.chr_machine_done() hook so that chardevs can run > > customized procedures after machine init. > > > > There was an existing mux user already that did similar thing but used a > > raw machine done notifier. Generalize it into a framework, and let the > > mux chardevs provide such a class-specific hook to achieve the same > > thing. Then we can move the mux related code to the char-mux.c file. > > > > Since at it, replace the mux_realized variable with the global > > machine_init_done varible. > > > > This notifier framework will be further leverged by other type of > > chardevs soon. > > > > Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> > > Signed-off-by: Peter Xu <pet...@redhat.com> > > patchew caught that: > tests/test-char.o: In function `char_mux_test': > /tmp/qemu-test/src/tests/test-char.c:169: undefined reference to > `muxes_realized'
Yeh, I replied to patchew mail with a fix to be squashed. I was planning to repost some days later, but let me repost now in case that it may ease the reviewers a bit. Thanks, -- Peter Xu
