On 05/03/18 19:36, Paolo Bonzini wrote:
> The MemoryListener is registered on address_space_memory, there is
> not much to assert. This currently works because the callback
> is invoked only once when the listener is registered, but section->fv
> is the _new_ FlatView, not the old one on later calls and that
> would break.
>
> This confines address_space_to_flatview to exec.c and memory.c.
>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Alexey Kardashevskiy <a...@ozlabs.ru>
> ---
> hw/intc/openpic_kvm.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/hw/intc/openpic_kvm.c b/hw/intc/openpic_kvm.c
> index fa83420254..39a6f369c5 100644
> --- a/hw/intc/openpic_kvm.c
> +++ b/hw/intc/openpic_kvm.c
> @@ -124,10 +124,6 @@ static void kvm_openpic_region_add(MemoryListener
> *listener,
> uint64_t reg_base;
> int ret;
>
> - if (section->fv != address_space_to_flatview(&address_space_memory)) {
> - abort();
> - }
> -
> /* Ignore events on regions that are not us */
> if (section->mr != &opp->mem) {
> return;
>
--
Alexey
