Signed-off-by: Paolo Bonzini
---
accel/tcg/cpu-exec.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 4318441e4c..18c1a2aedb 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -146,8 +146,10 @@ static inline
We know that only one bit (in addition to SO) is going to be set in
the condition register, so do two movconds instead of three setconds,
three shifts and two ORs.
For ppc64-linux-user, the code size reduction is around 5% and the
performance improvement slightly less than 10%. For softmmu, the
i
Sense keys have nice #defines in scsi/constants.h, use them.
Reported-by: Dr. David Alan Gilbert
Signed-off-by: Paolo Bonzini
---
scsi/utils.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/scsi/utils.c b/scsi/utils.c
index 61bc1a8e2b..ddae650a99 100644
--- a
Extract the common parts of scsi_sense_buf_to_errno, scsi_convert_sense
and scsi_target_send_command's REQUEST SENSE handling into two new
functions scsi_parse_sense_buf and scsi_build_sense_buf.
Fix a bug in scsi_target_send_command along the way; the length was
written in buf[10] rather than buf
On 12/16/2017 07:28 PM, Tetsuo Handa wrote:
Wei Wang wrote:
On 12/16/2017 02:42 AM, Matthew Wilcox wrote:
On Tue, Dec 12, 2017 at 07:55:55PM +0800, Wei Wang wrote:
+int xb_preload_and_set_bit(struct xb *xb, unsigned long bit, gfp_t gfp);
I'm struggling to understand when one would use this.
Hi,
This series failed build test on s390x host. Please find the details below.
Message-id: 20171215033015.738-1-f4...@amsat.org
Subject: [Qemu-devel] [PATCH v4 00/43] remove i386/pc dependency from non-PC
world (part 1)
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will b
Hi Hervé,
On 12/16/2017 06:30 PM, Hervé Poussineau wrote:
> Other piix4 parts are already named piix4-ide and piix4-usb-uhci.
>
> Signed-off-by: Hervé Poussineau
> ---
> hw/isa/piix4.c | 2 +-
> hw/mips/mips_malta.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --gi
On 12/16/2017 07:57 PM, BALATON Zoltan wrote:
> These were forgotten when adding panel layer support.
... in ffd39257018.
>
> Signed-off-by: BALATON Zoltan
with reference to commit:
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/display/sm501.c | 13 +
> 1 file changed, 13 inse
On Fri, Dec 15, 2017 at 2:15 AM, Philippe Mathieu-Daudé wrote:
> Hi Andrey,
>
> On 12/14/2017 11:52 AM, Andrey Smirnov wrote:
>> Frame truncation length, TRUNC_FL, is determined by the contents of
>> ENET_FTRL register, so convert the code to use it instead of a
>> hardcoded constant.
>>
>> To avo
On Sat, Dec 16, 2017 at 5:41 AM, Peter Maydell wrote:
> On 15 December 2017 at 19:21, Andrey Smirnov wrote:
>> On Fri, Dec 15, 2017 at 6:56 AM, Peter Maydell
>> wrote:
>>> Is there a board which needs this device? We usually
>>> only add devices together with whatever's using them.
>
>> It's a
On Fri, Dec 15, 2017 at 12:15 PM, Philippe Mathieu-Daudé
wrote:
> Hi Andrey,
>
>>> I rather disagree with this patch, however I applied it on top of my
>>> current tree and plan to refactor it. But if it is applied before, I can
>>> survive :) Not a strong NACK.
>>>
>>
>> Umm, Philippe, I didn't r
These were forgotten when adding panel layer support.
Signed-off-by: BALATON Zoltan
---
hw/display/sm501.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 7f18224..b9b6111 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@
Two simple patches to add some more registers that were found to be
accessed by some guests.
BALATON Zoltan (3):
sm501: Add panel hardware cursor registers also to read function
sm501: Add some more unimplemented registers
These are not really implemented (just return zero or default values)
but add these so guests accessing them can run.
Signed-off-by: BALATON Zoltan
---
hw/display/sm501.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index b9b6111.
Enough to please U-Boot and make it able to detect SDRAM SPD EEPROMs
Signed-off-by: François Revol
Signed-off-by: BALATON Zoltan
Reviewed-by: David Gibson
---
v2:
- Removed DPRINTFs, no other change
- R-b from: http://lists.nongnu.org/archive/html/qemu-ppc/2017-08/msg00193.html
hw/i2c/ppc4xx_
This is a common generic PCI SATA controller that is also used in PCs
but more importantly guests running on the Sam460ex board prefer this
card and have a driver for it (unlike for other SATA controllers
already emulated).
Signed-off-by: BALATON Zoltan
---
v2: Addressed review comments:
- Replac
Remove mc146818rtc instanciated in malta board, to not have it twice.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 12
hw/mips/mips_malta.c | 4
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index ada8c12979..637b
Remove i8254 instanciated in malta board, to not have it twice.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 4
hw/mips/mips_malta.c | 3 ---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index 66fdfe25e2..c215bee1ff 100644
---
Remove i8257 instanciated in malta board, to not have it twice.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 3 +++
hw/mips/mips_malta.c | 1 -
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index eb2f730fff..66fdfe25e2 100644
--- a/hw
Note that the PIC master can't be connected to CPU using the command line, but
it's not necessary to have a working ISA bus (for I/O, memory and DMA).
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index
Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 gpio out.
Remove i8259 instanciated in malta board, to not have it twice.
We can also remove the now unused piix4_init() function.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 40 +---
Other piix4 parts are already named piix4-ide and piix4-usb-uhci.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 2 +-
hw/mips/mips_malta.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index dc7146ee14..8bf260594f 100644
--- a
The RCR I/O port (0xcf9) is used to generate a hard reset or a soft reset.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index 4f476dc7e6..7c83e7c23d 100644
--- a/hw/isa/
Remove their instanciation from malta board, to not have them twice.
Automatically create serial/parallel ports in PIIX4 if not provided.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 67
hw/mips/mips_malta.c | 41
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index 637bec9b3a..dc7146ee14 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -30,6 +30,7 @@
#include "hw/isa/isa.h"
#include "hw/char/
We are not required anymore to use rtc_init() function.
Signed-off-by: Hervé Poussineau
---
hw/timer/mc146818rtc.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
index 73d1ce21de..1b6847b803 100644
--- a/hw/timer/
Remove i8042 instanciated in malta board, to not have it twice.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 3 +++
hw/mips/mips_malta.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index c215bee1ff..cf134b01ee 100644
--- a
We are now able to embed serial/parallel ports in another object.
Signed-off-by: Hervé Poussineau
---
hw/char/parallel.c | 31 +-
hw/char/serial-isa.c | 13 +
hw/ppc/pnv.c | 2 +-
include/hw/char/isa.h| 50 +++
PIIX4 structure is now 's'
PCI device is now 'pci'
DeviceState is now 'dev'
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index 6b8bc3faf0..4f476dc7e6 100644
--- a/hw/isa/piix4.
We are now able to embed floppy controllers in another object.
Signed-off-by: Hervé Poussineau
---
hw/block/fdc.c | 102
include/hw/block/fdc.h | 103 +
2 files changed, 103 insertions(+), 10
We are now able to embed a timer in another object.
Signed-off-by: Hervé Poussineau
---
hw/timer/mc146818rtc.c | 30 --
include/hw/timer/mc146818rtc.h | 29 +
2 files changed, 29 insertions(+), 30 deletions(-)
diff --git a/hw/timer
Hi,
This patchset is a cleanup of the PIIX4 PCI-ISA bridge. Lots of devices
are moved from MIPS Malta board (which has a PIIX4) to PIIX4, where devices
belong. This lets us reuse PIIX4 in other machines, while not loosing any
functionality.
Last patch allows adding a new PIIX4 device directly fro
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 1513327555-17520-1-git-send-email-jianjay.z...@huawei.com
Subject: [Qemu-devel] [PATCH v2 0/2] vhost: two fixes
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(g
Yes, new bug please, that's definitely a different symptom and likely an
unrelated issue.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1696353
Title:
golang binaries fail to start under linux-user
If the requested buffer size of the frontend is smaller than the fixed
buffer size of the host's TPM, fail the startup_tpm() interface function,
which will make the device unusable. We fail it because the backend TPM
could produce larger packets than what the frontend could pass to the OS.
The cur
Convert the tpm_emulator backend to get the current buffer size
of the external device and set it to the buffer size that the
frontend (TIS) requests.
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
backends/tpm.c | 4 +--
hw/tpm/tpm_emulator.c| 79 +++
Rather than hard coding the buffer size in the tpm_passthrough
backend read the TPM I/O buffer size from the host device.
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
hw/tpm/tpm_int.h | 9
hw/tpm/tpm_passthrough.c | 11 -
hw/tpm/tpm_util.c| 115 +++
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
hw/tpm/tpm_util.c | 40 +++-
1 file changed, 31 insertions(+), 9 deletions(-)
diff --git a/hw/tpm/tpm_util.c b/hw/tpm/tpm_util.c
index daf1faa..b852f53 100644
--- a/hw/tpm/tpm_util.c
+++ b/hw/tpm
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index db101b6..97cd7f5 100644
--- a/hw/tp
From: Marc-André Lureau
Query object classes that implements TPMIf instead.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 1 -
include/sysemu/tpm_backend.h | 2 --
tpm.c| 20 ++
From: Marc-André Lureau
The device should be exposed if present. It shouldn't have an
undefined version (or else backend init failed, and device should fail
too). Finally, make the fields specific to TIS device model.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: S
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index 0a23203..db101b6 100644
--- a/hw/tpm/tpm_tis.c
+++ b/hw/tpm/
From: Marc-André Lureau
The reported error message is already prefixed with the -device
name & arguments.
Before:
qemu-system-x86_64: -device tpm-tis,id=foo,tpmdev=foo,irq=21: tpm_tis: IRQ 21
is outside valid range of 0 to 15
After:
qemu-system-x86_64: -device tpm-tis,id=foo,tpmdev=foo,irq=21:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index a780167..81b23b7 100644
--- a/hw/tp
From: Marc-André Lureau
find_tpm() will be introduced to lookup the TPM device.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 2 +-
include/sysemu/tpm_backend.h | 2 +-
tpm.c| 2 +-
3 files
From: Marc-André Lureau
Do not hardcode TPM device model to lookup version, use an interface
instead.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 5 +++--
include/sysemu/tpm.h | 5 ++---
2 files changed, 5 insertions(+),
From: Marc-André Lureau
The TPM backend processing thread has common shared variable race
issues. (they should not be so easy to reach since guest interaction
with the device is slow compared to host emulation)
An obvious one is setting op_cancelled from device thread after
calling write(cancel_
From: Marc-André Lureau
Use a similar code as tpm_emulator_create(), call handle_opts() and
handle failure cleanup with object_unref() in create().
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_passthrough.c | 36 ++---
Rather than setting the size of the TPM buffer in the front-end,
query the backend for the size of the buffer. In this patch we
just move the hard-coded buffer size of 4096 to the backends.
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
backends/tpm.c | 7 +++
From: Marc-André Lureau
The value is later unneeded, and may leak if the free visitor doesn't
consider it since has_cancel_path is false. And for consistency with
"path" it shouldn't be returned in get_tpm_options().
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: St
From: Marc-André Lureau
Check fds values before closing, to avoid close(-1).
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_passthrough.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/tpm/tpm_passthroug
From: Marc-André Lureau
A property to lookup a tpm backend.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/core/qdev-properties-system.c | 64
include/hw/qdev-properties.h | 3 ++
2 files changed,
From: Marc-André Lureau
Now that there is an interface instead.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 4 ++--
include/sysemu/tpm.h | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/tpm/tpm_t
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_emulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c
index 94e6660..24cb611 100644
--- a/hw/tpm/tpm_emulator.
From: Marc-André Lureau
QEMU code doesn't generally have assert() for mandatory
callbacks/function pointers, probably because the crash is pretty
obvious. Document the methods instead of going into the code.
Make get_tpm_options() mandatory to implement (since all
backend implementation have it)
From: Marc-André Lureau
Lift from the backend implementation the responsability to call the
request_completed() callback outside of thread context. This also
simplify frontend/interface work, as they no longer need to care
whether the callback is called from a different thread.
Signed-off-by: Ma
From: Marc-André Lureau
The function is generally useful and used in the following patches.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 3 ++-
hw/tpm/tpm_util.h | 8 +++-
2 files changed, 9 insertions(+), 2 deletions(-)
From: Marc-André Lureau
It doesn't need TPMBackend. Also reorder arguments for consistency.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_passthrough.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/tpm/t
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_emulator.c| 12 +++-
hw/tpm/tpm_passthrough.c | 9 +++--
include/sysemu/tpm_backend.h | 2 +-
tpm.c| 3 ++-
4 file
From: Marc-André Lureau
This is a better location than hw/tpm, since we are going to use the
interface from outside hw/tpm.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
backends/tpm.c | 1 -
hw/tpm/tpm_int.h | 22 +---
From: Marc-André Lureau
No need to store the mode in the backend, or to let the frontend set
it itself.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
backends/tpm.c | 4 ++--
hw/tpm/tpm_tis.c | 3 +--
include/sysemu/tpm
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
backends/tpm.c | 42 --
include/sysemu/tpm_backend.h | 12
tpm.c| 6 --
3 files
From: Marc-André Lureau
This will allow to introduce new devices implementing TPM.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/i386/acpi-build.c | 2 +-
include/sysemu/tpm.h | 25 +++--
2 files changed, 16 insertions(+)
From: Marc-André Lureau
This field slipped in commit 5086bf9784.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index 42d647d..880ca1a 100644
From: Marc-André Lureau
Store the TPM interface, the actual object may be different from
TPMState. Keep a reference on the interface, and check the backend
wasn't already initialized.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
backends/tpm.c
The following patch series refactors the TPM TIS and backend drivers for
easier addition of new front-end devices. Further, the TPM buffer sizes
are read from the backend and the backend's buffer size can be adjusted
by the frontend, if necessary.
The following changes since commit 0ef0583d5adceb
From: Marc-André Lureau
Backend can give more accurate error description, and lift out the job
from the frontend.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
backends/tpm.c | 3 ++-
hw/tpm/tpm_tis.c | 4 +---
include/
Public bug reported:
Go binaries panic with "mmap errno 9" on qemu-user.
root@nofan:/# cat hello.go
package main
import "fmt"
func main() {
fmt.Println("hello world")
}
root@nofan:/# gccgo-7 hello.go -o hello
root@nofan:/# ./hello
mmap errno 9
fatal error: mmap
runtime stack:
mmap errno
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Message-id: 20171214152246.17503-1-h...@suse.de
Subject: [Qemu-devel] [PATCH 0/2] scsi: Simple ALUA support
Type: series
===
I just gave it a test with qemu-arm and Go binaries still crash for me,
albeit differently:
root@nofan:/# cat hello.go
package main
import "fmt"
func main() {
fmt.Println("hello world")
}
root@nofan:/# gccgo-7 hello.go -o hello
root@nofan:/# ./hello
mmap errno 9
fatal error: mmap
runtime
Public bug reported:
I am using qemu-2.10.1, or actually libvirt, to create a virtual machine,
running microsoft windows 10 pro operating system.
It installed fine and was actually working, however sometimes when trying to
boot the vm, the whole boot process gets stuck.
For some reason, it seeme
** Attachment added: "log of libvirt's domain containing qemu command line
arguments passed"
https://bugs.launchpad.net/qemu/+bug/1738507/+attachment/5023251/+files/libvirt-log.txt
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
On 15 December 2017 at 20:37, Wei Huang wrote:
> This patch adds the migration test support for aarch64. The test code,
> which implements the same functionality as x86, is compiled into a binary
> and booted as a kernel to qemu. Here are the design ideas:
>
> * We choose this -kernel design becau
On 15 December 2017 at 19:21, Andrey Smirnov wrote:
> On Fri, Dec 15, 2017 at 6:56 AM, Peter Maydell
> wrote:
>> Is there a board which needs this device? We usually
>> only add devices together with whatever's using them.
> It's a pretty popular PMIC used on majority on i.MX reference designs,
Wei Wang wrote:
> On 12/16/2017 02:42 AM, Matthew Wilcox wrote:
> > On Tue, Dec 12, 2017 at 07:55:55PM +0800, Wei Wang wrote:
> >> +int xb_preload_and_set_bit(struct xb *xb, unsigned long bit, gfp_t gfp);
> > I'm struggling to understand when one would use this. The xb_ API
> > requires you to han
On 12/15/2017 12:29 AM, Tetsuo Handa wrote:
Wei Wang wrote:
I used the example of xb_clear_bit_range(), and xb_find_next_bit() is
the same fundamentally. Please let me know if anywhere still looks fuzzy.
I don't think it is the same for xb_find_next_bit() with set == 0.
+ if (rad
On 12/16/2017 02:42 AM, Matthew Wilcox wrote:
On Tue, Dec 12, 2017 at 07:55:55PM +0800, Wei Wang wrote:
+int xb_preload_and_set_bit(struct xb *xb, unsigned long bit, gfp_t gfp);
I'm struggling to understand when one would use this. The xb_ API
requires you to handle your own locking. But spec
On 12/15/2017 09:24 PM, Matthew Wilcox wrote:
On Fri, Dec 15, 2017 at 07:05:07PM +0800, kbuild test robot wrote:
21 struct radix_tree_node *node;
22 void **slot;
^^^
missing __rcu annotation here.
Wei, could you fold that change into your
Signed-off-by: Greg Kurz
---
tests/virtio-9p-test.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/virtio-9p-test.c b/tests/virtio-9p-test.c
index ebd24b20f657..00f00f7246e9 100644
--- a/tests/virtio-9p-test.c
+++ b/tests/virtio-9p-test.c
@@ -75,6 +75,9 @@ static QVirtIO9P *qvirt
On Sat, Dec 16, 2017 at 03:17:06PM +0800, Peter Xu wrote:
> On Thu, Dec 14, 2017 at 11:41:36AM +, Stefan Hajnoczi wrote:
> > On Tue, Dec 05, 2017 at 01:51:52PM +0800, Peter Xu wrote:
> > > Set maximum QMP request queue length to 8. If queue full, instead of
> > > queue the command, we directly
On Sat, Dec 16, 2017 at 02:37:03PM +0800, Peter Xu wrote:
> On Wed, Dec 13, 2017 at 08:09:38PM +, Stefan Hajnoczi wrote:
> > On Tue, Dec 05, 2017 at 01:51:50PM +0800, Peter Xu wrote:
> > > @@ -3956,12 +3968,122 @@ static void handle_qmp_command(JSONMessageParser
> > > *parser, GQueue *tokens,
Other piix4 parts are already named piix4-ide and piix4-usb-uhci.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 2 +-
hw/mips/mips_malta.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index 7358d7f5db..2e9aca6659 100644
--- a
Remove their instanciation from malta board, to not have them twice.
Also, always create a parallel port in Malta board, as requested by PIIX4.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 56
hw/mips/mips_malta.c | 32 ++
PIIX4 structure is now 's'
PCI device is now 'pci'
DeviceState is now 'dev'
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index 6b8bc3faf0..4f476dc7e6 100644
--- a/hw/isa/piix4.
Remove i8254 instanciated in malta board, to not have it twice.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 4
hw/mips/mips_malta.c | 3 ---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index 66fdfe25e2..c215bee1ff 100644
---
On Sat, Dec 16, 2017 at 02:12:11PM +0800, Peter Xu wrote:
> On Wed, Dec 13, 2017 at 06:43:58PM +, Stefan Hajnoczi wrote:
> > On Tue, Dec 05, 2017 at 01:51:49PM +0800, Peter Xu wrote:
> > > Monitor code now can be run in more than one thread. Let it be thread
> > > safe when accessing suspend_c
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index 82890f0712..7358d7f5db 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -30,6 +30,7 @@
#include "hw/isa/isa.h"
#include "hw/char/
Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 gpio out.
Remove i8259 instanciated in malta board, to not have it twice.
We can also remove the now unused piix4_init() function.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 40 +---
We are now able to embed floppy controllers in another object.
Signed-off-by: Hervé Poussineau
---
hw/block/fdc.c | 101
include/hw/block/fdc.h | 103 +
2 files changed, 103 insertions(+), 10
The RCR I/O port (0xcf9) is used to generate a hard reset or a soft reset.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index 4f476dc7e6..7c83e7c23d 100644
--- a/hw/isa/
We are now able to embed a timer in another object.
Signed-off-by: Hervé Poussineau
---
hw/timer/mc146818rtc.c | 30 --
include/hw/timer/mc146818rtc.h | 29 +
2 files changed, 29 insertions(+), 30 deletions(-)
diff --git a/hw/timer
Remove mc146818rtc instanciated in malta board, to not have it twice.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 12
hw/mips/mips_malta.c | 4
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index bc13169a00..8289
Remove i8042 instanciated in malta board, to not have it twice.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 3 +++
hw/mips/mips_malta.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index c215bee1ff..cf134b01ee 100644
--- a
We are not required anymore to use rtc_init() function.
Signed-off-by: Hervé Poussineau
---
hw/timer/mc146818rtc.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
index 73d1ce21de..1b6847b803 100644
--- a/hw/timer/
Hi,
This patchset is a cleanup of the PIIX4 PCI-ISA bridge. Lots of devices
are moved from MIPS Malta board (which has a PIIX4) to PIIX4, where devices
belong. This lets us reuse PIIX4 in other machines, while not loosing any
functionality.
Last patch allows adding a new PIIX4 device directly fro
We are now able to embed serial/parallel ports in another object.
Signed-off-by: Hervé Poussineau
---
hw/char/parallel.c | 31 +-
hw/char/serial-isa.c | 13 +
hw/ppc/pnv.c | 2 +-
include/hw/char/isa.h| 50 +++
Remove i8257 instanciated in malta board, to not have it twice.
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 3 +++
hw/mips/mips_malta.c | 1 -
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index eb2f730fff..66fdfe25e2 100644
--- a/hw
Note that the PIC master can't be connected to CPU using the command line, but
it's not necessary to have a working ISA bus (for I/O, memory and DMA).
Signed-off-by: Hervé Poussineau
---
hw/isa/piix4.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index
On Sat, Dec 16, 2017 at 11:52:28AM +0800, Peter Xu wrote:
> On Fri, Dec 15, 2017 at 12:47:11PM +, Stefan Hajnoczi wrote:
> > On Fri, Dec 15, 2017 at 04:11:41PM +0800, Peter Xu wrote:
> > > On Wed, Dec 13, 2017 at 03:48:06PM +, Stefan Hajnoczi wrote:
> > > > On Tue, Dec 05, 2017 at 01:51:41P
99 matches
Mail list logo
