On 15 December 2017 at 19:21, Andrey Smirnov <andrew.smir...@gmail.com> wrote: > On Fri, Dec 15, 2017 at 6:56 AM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> Is there a board which needs this device? We usually >> only add devices together with whatever's using them.
> It's a pretty popular PMIC used on majority on i.MX reference designs, > but I am not sure how many of those boards truly need it in QEMU. I > ended up having to implement this code for a custom i.MX7 board that > used one of PFUZE3000's output as a power supply for USB. I am not > sure if I'm ever going to submit patches for that mystery board > upstream. Looking at imx6qdl-sabresd.dtsi, in Linux source tree I > think this emulation code would also be needed for USB emulation on > i.MX6 SabreSD board, but I haven't verified it in practice. > > Is this enough of a case to justify the patch's inclusion, or should I > go back and find a board QEMU supports that actually needs this > (either answer is perfectly fine with me)? I think what I'd like to see is some board model in QEMU actually creating this device. (I assume it's not intended as a "user creates it with -device" pluggable device.) Otherwise it's just dead code from upstream's point of view. thanks -- PMM
