Re: [Qemu-devel] [PATCH] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-10-19 Thread Gerd Hoffmann
Hi, > > commit message says: > > > > > >  It turns out that some 32 bit windows guests crash > >  if 64 bit PCI hole size is >2G. > > > > > > Why this suddenly isn't a problem any more? > > > > I suppose it is, so we need a way to turn it "off". Or have machine types behave differ

Re: [Qemu-devel] [PATCH v9 0/8] Optimize VMDK I/O by allocating multiple clusters

2017-10-19 Thread Ashijeet Acharya
On Fri, Oct 20, 2017 at 11:58 Fam Zheng wrote: > On Mon, 10/09 22:12, Fam Zheng wrote: > > On Mon, 10/09 18:29, Ashijeet Acharya wrote: > > > Optimization test results: > > > > > > This patch series improves 128 KB sequential write performance to an > > > empty VMDK file by 54% > > > > > > Benchm

Re: [Qemu-devel] [PULL 07/11] tools: add qemu-keymap

2017-10-19 Thread Thomas Huth
On 20.10.2017 00:12, Eric Blake wrote: > On 10/19/2017 05:09 PM, Eric Blake wrote: >> On 10/16/2017 08:16 AM, Gerd Hoffmann wrote: >>> qemu-keymap generates qemu reverse keymaps from xkb keymaps, >>> which can be used with the qemu "-k" command line switch. >>> >>> Signed-off-by: Gerd Hoffmann >>>

Re: [Qemu-devel] unknown keycodes `(unnamed)'

2017-10-19 Thread Thomas Huth
On 19.10.2017 21:23, Spaceboy Ross wrote: > unknown keycodes `(unnamed)', please report to qemu-devel@nongnu.org > > uname -a returns: > > Linux spaceboyross-Latitude-D630 4.13.0-16-generic #19-Ubuntu SMP Wed > Oct 11 18:35:14 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux > Please be more specific: W

[Qemu-devel] [PULL 5/5] docker: Fix PATH for ccache

2017-10-19 Thread Fam Zheng
Before bcd7f06f57fb6f780a3e2f7a46c22b6f6c8238aa we source /etc/profile so the PATH included the right paths to ccache binaries. Now we need to update $PATH explicitly from run script. Keep the old /usr/lib around just so that in the future, ccache from 32 bit images will just work. Signed-off-by:

[Qemu-devel] [PULL 1/5] docker: Don't allocate tty unless DEBUG=1

2017-10-19 Thread Fam Zheng
The existence of tty in the container seems to urge gcc into colorizing the errors, but the escape chars will clutter the report once turned into email replies on patchew. Move -t to debug mode. Reported-by: Eric Blake Signed-off-by: Fam Zheng Message-Id: <20171013011954.9975-1-f...@redhat.com>

[Qemu-devel] [PULL 2/5] docker: cleanup temp directory after test

2017-10-19 Thread Fam Zheng
From: Peter Xu There are temp directories named "docker-src.*" after doing docker tests. I don't see much point in keeping that (it only contains the qemu.tar which is exactly current tree, and the copied "run" file). Let's remove it after test finished. CC: "Alex Bennée" CC: Fam Zheng CC: "P

[Qemu-devel] [PULL 3/5] docker: allow running from srcdir != builddir build

2017-10-19 Thread Fam Zheng
From: Paolo Bonzini The new script uses "git submodule", which is picky about being invoked from the top of the git checkout. Invoke the script from $(SRC_PATH) to avoid git's wrath. Fixes: b7f404201e45e99da23b9764dec27ce5f965cdcd Cc: Fam Zheng Signed-off-by: Paolo Bonzini Message-Id: <15083

[Qemu-devel] [PULL 4/5] docker: fix out-of-tree 'make docker-test-build@debian-powerpc-cross'

2017-10-19 Thread Fam Zheng
From: Greg Kurz Without this patch, it fails with: IOError: [Errno 2] No such file or directory: 'tests/docker/dockerfiles/debian-apt-fake.sh' Signed-off-by: Greg Kurz Message-Id: <150841324224.31292.4012464539983692364.st...@bahia.lan> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

[Qemu-devel] [PULL 0/5] Docker patches

2017-10-19 Thread Fam Zheng
The following changes since commit 063833a6ec2a6747e27c5f9866bb44c7e8de1265: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into staging (2017-10-19 18:42:51 +0100) are available in the git repository at: git://github.com/famz/qemu.git tags/docker-pull-request for y

Re: [Qemu-devel] [PATCH v5 1/8] aspeed: use a ROM memory region to catch invalid writes

2017-10-19 Thread Cédric Le Goater
On 10/20/2017 05:10 AM, Philippe Mathieu-Daudé wrote: > On 10/19/2017 12:44 PM, Peter Maydell wrote: >> On 19 October 2017 at 16:12, Cédric Le Goater wrote: >>> Some legacy firmwares access unimplemented addresses on the Aspeed SoC >>> (old U-Boot code using variables in the bss when it shouldn't

Re: [Qemu-devel] [PATCH v9 0/8] Optimize VMDK I/O by allocating multiple clusters

2017-10-19 Thread Fam Zheng
On Mon, 10/09 22:12, Fam Zheng wrote: > On Mon, 10/09 18:29, Ashijeet Acharya wrote: > > Optimization test results: > > > > This patch series improves 128 KB sequential write performance to an > > empty VMDK file by 54% > > > > Benchmark command: ./qemu-img bench -w -c 1024 -s 128K -d 1 -t none -

Re: [Qemu-devel] [PATCH v3 42/46] util: Replace fprintf(stderr, "*\n" with error_report()

2017-10-19 Thread Thomas Huth
On 19.10.2017 21:47, Stefan Weil wrote: > Am 19.10.2017 um 19:53 schrieb Thomas Huth: >> On 19.10.2017 18:18, Alistair Francis wrote: >>> Replace a large number of the fprintf(stderr, "*\n" calls with >>> error_report(). The functions were renamed with these commands and then >>> compiler issues wh

Re: [Qemu-devel] [PATCH v6 8/8] aspeed: add the pc9552 chips to the witherspoon machine

2017-10-19 Thread Cédric Le Goater
On 10/20/2017 04:59 AM, Philippe Mathieu-Daudé wrote: > On 10/19/2017 01:35 PM, Cédric Le Goater wrote: >> The pca9552 LED blinkers on the Witherspoon machine are used for leds >> but also as GPIOs to control fans and GPUs. >> >> Signed-off-by: Cédric Le Goater >> Reviewed-by: Andrew Jeffery >> -

Re: [Qemu-devel] [PATCH v6 7/8] misc: add pca9552 LED blinker model

2017-10-19 Thread Cédric Le Goater
On 10/20/2017 04:58 AM, Philippe Mathieu-Daudé wrote: > Hi Cédric, > > On 10/19/2017 01:35 PM, Cédric Le Goater wrote: >> Specs are available here : >> >> https://www.nxp.com/docs/en/application-note/AN264.pdf >> >> This is a simple model supporting the basic registers for led and GPIO >> mode

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-19 Thread ChristianEhrhardt
** Description changed: + [Impact] + + * A change in qemu 2.8 (83d768b virtio: set ISR on dataplane +notifications) broke virtio handling on platforms without a +controller. Those encounter flaky networking due to missed IRQs + + * Fix is a backport of the upstream fix b4b9862b: virt

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-19 Thread ChristianEhrhardt
Ok, driving that into an SRU then - thanks for verifying. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1719196 Title: [arm64 ocata] newly created instances are unable to raise network interfaces

Re: [Qemu-devel] [RFC v2 15/22] monitor: send event when request queue full

2017-10-19 Thread Peter Xu
On Thu, Oct 19, 2017 at 03:11:50PM +0200, Stefan Hajnoczi wrote: > On Thu, Oct 19, 2017 at 03:16:11PM +0800, Peter Xu wrote: > > On Wed, Oct 18, 2017 at 05:28:04PM +0200, Stefan Hajnoczi wrote: > > > On Mon, Oct 16, 2017 at 04:11:58PM +0800, Peter Xu wrote: > > > > On Thu, Oct 12, 2017 at 01:56:20P

Re: [Qemu-devel] [PATCH 2/2] target/arm: Don't set INSN_ARM_BE32 for CONFIG_USER_ONLY

2017-10-19 Thread Philippe Mathieu-Daudé
On 10/19/2017 06:21 PM, Richard Henderson wrote: > This matches translator behaviour in arm_lduw_code. > > Fixes: https://bugs.launchpad.net/qemu/+bug/1724485 > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/cpu.c | 9 +++-- > 1 file changed, 7 ins

Re: [Qemu-devel] [PATCH v3 08/46] hw/char: Replace fprintf(stderr, "*\n" with error_report()

2017-10-19 Thread Philippe Mathieu-Daudé
On 10/19/2017 01:16 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. [...] > --- > V2: > - Split hw patch into individual directories > >

Re: [Qemu-devel] [PATCH v3 46/46] target: Replace fprintf(stderr, "*\n" with error_report()

2017-10-19 Thread Philippe Mathieu-Daudé
On 10/19/2017 01:18 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. [...] > Signed-off-by: Alistair Francis > Cc: "Edgar E. Iglesias" > Cc

Re: [Qemu-devel] [PATCH v3 10/46] hw/cris: Replace fprintf(stderr, "*\n" with error_report()

2017-10-19 Thread Philippe Mathieu-Daudé
On 10/19/2017 01:16 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N; {s|

Re: [Qemu-devel] [PATCH] net: add print link status of nics in print_net_client function

2017-10-19 Thread Philippe Mathieu-Daudé
On 10/19/2017 11:58 PM, ZhiPeng Lu wrote: > We can directly know the information of vm by executing "info network" > command, > including the link state of nics, without excuting other commands again. "executing" > > Signed-off-by: ZhiPeng Lu > Reviewed-by: Jiyun Fan Reviewed-by: Philippe M

Re: [Qemu-devel] [PATCH v5 1/8] aspeed: use a ROM memory region to catch invalid writes

2017-10-19 Thread Philippe Mathieu-Daudé
On 10/19/2017 12:44 PM, Peter Maydell wrote: > On 19 October 2017 at 16:12, Cédric Le Goater wrote: >> Some legacy firmwares access unimplemented addresses on the Aspeed SoC >> (old U-Boot code using variables in the bss when it shouldn't do). >> Let's use a ROM memory region to catch the invalid

Re: [Qemu-devel] [PATCH v6 8/8] aspeed: add the pc9552 chips to the witherspoon machine

2017-10-19 Thread Philippe Mathieu-Daudé
On 10/19/2017 01:35 PM, Cédric Le Goater wrote: > The pca9552 LED blinkers on the Witherspoon machine are used for leds > but also as GPIOs to control fans and GPUs. > > Signed-off-by: Cédric Le Goater > Reviewed-by: Andrew Jeffery > --- > hw/arm/aspeed.c | 4 > 1 file changed, 4 insertion

[Qemu-devel] [PATCH] net: add print link status of nics in print_net_client function

2017-10-19 Thread ZhiPeng Lu
We can directly know the information of vm by executing "info network" command, including the link state of nics, without excuting other commands again. Signed-off-by: ZhiPeng Lu Reviewed-by: Jiyun Fan --- net/net.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/n

Re: [Qemu-devel] [PATCH v6 7/8] misc: add pca9552 LED blinker model

2017-10-19 Thread Philippe Mathieu-Daudé
Hi Cédric, On 10/19/2017 01:35 PM, Cédric Le Goater wrote: > Specs are available here : > > https://www.nxp.com/docs/en/application-note/AN264.pdf > > This is a simple model supporting the basic registers for led and GPIO > mode. The device also supports two blinking rates but not the model

Re: [Qemu-devel] [PATCH v3 0/7] migration: pause-before-switchover

2017-10-19 Thread Peter Xu
On Thu, Oct 19, 2017 at 12:21:23PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Wed, Oct 18, 2017 at 06:40:06PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > > [...] > > > > > The precopy flow is: > > > active->pre-switchover->device->completed > > >

Re: [Qemu-devel] [PATCH v4 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-10-19 Thread Liu, Changpeng
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Friday, October 20, 2017 10:12 AM > To: Liu, Changpeng > Cc: Paolo Bonzini ; qemu-devel@nongnu.org; > stefa...@gmail.com; marcandre.lur...@redhat.com; fel...@nutanix.com; Harris, > James R > Subject: Re: [P

Re: [Qemu-devel] [PATCH v6 38/50] translate-all: use a binary search tree to track TBs in TBContext

2017-10-19 Thread Richard Henderson
On 10/18/2017 11:19 AM, Emilio G. Cota wrote: > On Wed, Oct 18, 2017 at 09:41:43 +0200, Paolo Bonzini wrote: >> On 16/10/2017 19:25, Richard Henderson wrote: >>> * Translation Cache-related fields of a TB. >>> + * This struct exists just for convenience; we keep track of TB's in a >>> binary >>>

Re: [Qemu-devel] [PATCH v6 25/50] tcg: Include CF_COUNT_MASK in CF_HASH_MASK

2017-10-19 Thread Richard Henderson
On 10/17/2017 09:31 PM, Emilio G. Cota wrote: > On Mon, Oct 16, 2017 at 10:25:44 -0700, Richard Henderson wrote: >> Signed-off-by: Richard Henderson > > Does this patch work with icount for you? On my end, aarch64 > stops booting with -icount 1. Found it -- cpu_io_recompile needs the same sort o

Re: [Qemu-devel] [PATCH] translate-all: exit from tb_phys_invalidate if qht_remove fails

2017-10-19 Thread Richard Henderson
On 10/19/2017 01:31 PM, Emilio G. Cota wrote: > Two or more threads might race while invalidating the same TB. We currently > do not check for this at all despite taking tb_lock, which means we would > wrongly invalidate the same TB more than once. This bug has actually been > hit by users: I recen

Re: [Qemu-devel] [PATCH v4 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-10-19 Thread Michael S. Tsirkin
On Fri, Oct 20, 2017 at 01:55:20AM +, Liu, Changpeng wrote: > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Friday, October 20, 2017 8:28 AM > > To: Paolo Bonzini > > Cc: Liu, Changpeng ; qemu-devel@nongnu.org; > > stefa...@gmail.com; marcan

Re: [Qemu-devel] [PATCH v4 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-10-19 Thread Liu, Changpeng
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Friday, October 20, 2017 8:28 AM > To: Paolo Bonzini > Cc: Liu, Changpeng ; qemu-devel@nongnu.org; > stefa...@gmail.com; marcandre.lur...@redhat.com; fel...@nutanix.com; Harris, > James R > Subject: Re: [PA

Re: [Qemu-devel] [Block-io] qemu virtual machine get stuck during startup

2017-10-19 Thread Wahaha Huang
Sorry for the late reply. Unfortunately, when it gets stuck(block at the windows welcome screen), there are no any error messages print out, with cpu usage 9%. I'm not quite sure whether the QEMU monitor is still work Here is some more infomation: 1. QEMU command-line: qemu-system-x86_64 -enable-

[Qemu-devel] [PATCH] implement strnlen for systems that need it

2017-10-19 Thread John Arbuckle
Signed-off-by: John Arbuckle --- Makefile.dtc | 3 ++- libfdt/Makefile.libfdt | 2 +- libfdt/libfdt_env.h| 12 libfdt/strnlen.h | 14 ++ strnlen.c | 25 + 5 files changed, 54 insertions(+), 2 deletions(-) create

Re: [Qemu-devel] [PATCH v4 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

2017-10-19 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Thursday, October 19, 2017 11:18 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; m...@redhat.com; > marcandre.lur...@redhat.com; fel...@nutanix.com; Harris, James R > > Subject: Re

Re: [Qemu-devel] [PATCH v4 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application

2017-10-19 Thread Liu, Changpeng
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, October 19, 2017 7:44 PM > To: Liu, Changpeng ; qemu-devel@nongnu.org > Cc: stefa...@gmail.com; m...@redhat.com; marcandre.lur...@redhat.com; > fel...@nutanix.com; Harris, James R > Subject: Re: [PA

Re: [Qemu-devel] [PATCH v4 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

2017-10-19 Thread Liu, Changpeng
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, October 19, 2017 7:33 PM > To: Liu, Changpeng ; qemu-devel@nongnu.org > Cc: stefa...@gmail.com; m...@redhat.com; marcandre.lur...@redhat.com; > fel...@nutanix.com; Harris, James R > Subject: Re: [PA

Re: [Qemu-devel] [RFC 0/6] enable numa configuration before machine_init() from HMP/QMP

2017-10-19 Thread David Gibson
On Thu, Oct 19, 2017 at 02:23:04PM +0200, Paolo Bonzini wrote: > On 19/10/2017 13:49, David Gibson wrote: > > Note that describing socket/core/thread tuples as arch independent (or > > even machine independent) is.. debatable. I mean it's flexible enough > > that most platforms can be fit to that

Re: [Qemu-devel] [RFC 4/6] CLI: add -paused option

2017-10-19 Thread David Gibson
On Thu, Oct 19, 2017 at 10:15:48PM -0200, Eduardo Habkost wrote: > On Thu, Oct 19, 2017 at 09:42:18PM +1100, David Gibson wrote: > > On Mon, Oct 16, 2017 at 02:59:16PM -0200, Eduardo Habkost wrote: > > > On Mon, Oct 16, 2017 at 06:22:54PM +0200, Igor Mammedov wrote: > > > > Signed-off-by: Igor Mamm

Re: [Qemu-devel] [PATCH] docker: Fix PATH for ccache

2017-10-19 Thread Fam Zheng
On Wed, 10/18 15:38, Fam Zheng wrote: > Before bcd7f06f57fb6f780a3e2f7a46c22b6f6c8238aa we source /etc/profile > so the PATH included the right paths to ccache binaries. Now we need to > update $PATH explicitly from run script. > > Keep the old /usr/lib around just so that in the future, ccache fr

Re: [Qemu-devel] [PATCH v3 33/46] hw/scsi: Replace fprintf(stderr, "*\n" with error_report()

2017-10-19 Thread David Gibson
On Thu, Oct 19, 2017 at 09:17:40AM -0700, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;

Re: [Qemu-devel] [PATCH qemu v3] RFC: ppc/spapr: Receive and store device tree blob from SLOF

2017-10-19 Thread Alexey Kardashevskiy
On 19/10/17 17:24, David Gibson wrote: > On Tue, Oct 17, 2017 at 04:55:03PM +1100, Alexey Kardashevskiy wrote: >> On 16/10/17 20:36, David Gibson wrote: >>> On Mon, Oct 16, 2017 at 04:20:04PM +1100, Alexey Kardashevskiy >> wrote: > [snip] >>> || >>> >>> Yeah.. this is all a bit complicated, I'm rea

Re: [Qemu-devel] [PATCH v4 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-10-19 Thread Michael S. Tsirkin
On Thu, Oct 19, 2017 at 11:04:48PM +0200, Paolo Bonzini wrote: > On 19/10/2017 19:43, Michael S. Tsirkin wrote: > > On Thu, Oct 19, 2017 at 05:43:18PM +0200, Paolo Bonzini wrote: > >> On 19/10/2017 17:39, Michael S. Tsirkin wrote: > Add VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG messages whic

Re: [Qemu-devel] [RFC 4/6] CLI: add -paused option

2017-10-19 Thread Eduardo Habkost
On Thu, Oct 19, 2017 at 09:42:18PM +1100, David Gibson wrote: > On Mon, Oct 16, 2017 at 02:59:16PM -0200, Eduardo Habkost wrote: > > On Mon, Oct 16, 2017 at 06:22:54PM +0200, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > > include/sysemu/sysemu.h | 1 + > > > qemu-options

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-19 Thread Sean Feole
I've testing with the same packages listed in comment #28, Confirmed that this now works.. See attached log ** Attachment added: "novaout.txt" https://bugs.launchpad.net/libvirt/+bug/1719196/+attachment/4977254/+files/novaout.txt -- You received this bug notification because you are a memb

Re: [Qemu-devel] [PATCH 00/42] TPM: code cleanup & CRB device

2017-10-19 Thread Stefan Berger
On 10/19/2017 01:00 PM, Marc-André Lureau wrote: Hi - Original Message - On 10/19/2017 10:44 AM, Stefan Berger wrote: On 10/19/2017 10:33 AM, Marc-André Lureau wrote: Hi Stefan - Original Message - On 10/09/2017 06:55 PM, Marc-André Lureau wrote: Hi, I accumulated a series

Re: [Qemu-devel] [PATCH 24/42] tpm-be: call request_completed() out of thread

2017-10-19 Thread Stefan Berger
On 10/19/2017 06:02 PM, Stefan Berger wrote: On 10/09/2017 06:56 PM, Marc-André Lureau wrote: Lift from the backend implementation the responsability to call the request_completed() callback outside of thread context. This also I don't think this is what you are doing here. It's still in threa

Re: [Qemu-devel] [PATCH] hw/alpha/typhoon: simplify using the "unimplemented" sysbus device

2017-10-19 Thread Richard Henderson
On 10/17/2017 03:50 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/alpha/alpha_sys.h | 1 - > hw/alpha/pci.c | 26 -- > hw/alpha/typhoon.c | 6 ++ > 3 files changed, 2 insertions(+), 31 deletions(-) Reviewed-by: Richard

[Qemu-devel] [PATCH v5 06/11] nbd: Minimal structured read for server

2017-10-19 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Minimal implementation of structured read: one structured reply chunk, no segmentation. Minimal structured error implementation: no text message. Support DF flag, but just ignore it, as there is no segmentation any way. Signed-off-by: Vladimir Sementsov-Ogievsk

[Qemu-devel] [PATCH v5 11/11] nbd: Minimal structured read for client

2017-10-19 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Minimal implementation: for structured error only error_report error message. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Eric Blake --- v5: fix payload_advance[32,64], return correct negative error on structured error, rearrange size checks t

[Qemu-devel] [PATCH v5 09/11] nbd/client: prepare nbd_receive_reply for structured reply

2017-10-19 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy In following patch nbd_receive_reply will be used both for simple and structured reply header receiving. NBDReply is altered into union of simple reply header and structured reply chunk header, simple error translation moved to block/nbd-client to be consistent

[Qemu-devel] [PATCH v5 08/11] nbd/client: refactor nbd_receive_starttls

2017-10-19 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Split out nbd_request_simple_option to be reused for structured reply option. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Eric Blake --- v5: only check length for ACK responses v4: reduce redundant traces, typo fix in commit message --- nbd/c

[Qemu-devel] [PATCH v5 05/11] nbd/server: Refactor zero-length option check

2017-10-19 Thread Eric Blake
Consolidate the check for a zero-length payload to an option into a new function, nbd_check_zero_length(); this check will also be used when introducing support for structured replies. By sticking a catch-all check at the end of the loop for processing options, we can simplify several of the inter

[Qemu-devel] [PATCH v5 01/11] nbd: Include error names in trace messages

2017-10-19 Thread Eric Blake
NBD errors were originally sent over the wire based on Linux errno values; but not all the world is Linux, and not all platforms share the same values. Since a number isn't very easy to decipher on all platforms, update the trace messages to include the name of NBD errors being sent/received over

[Qemu-devel] [PATCH v5 07/11] nbd/server: Include human-readable message in structured errors

2017-10-19 Thread Eric Blake
The NBD spec permits including a human-readable error string if structured replies are in force, so we might as well send the client the message that we logged on any error. Signed-off-by: Eric Blake --- v5: allow NULL msg, cast away const for ease of use [Vladimir]; send correct length over the

[Qemu-devel] [PATCH v5 10/11] nbd: Move nbd_read() to common header

2017-10-19 Thread Eric Blake
An upcoming change to block/nbd-client.c will want to read the tail of a structured reply chunk directly from the wire. Move this function to make it easier. Based on a patch from Vladimir Sementsov-Ogievskiy. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- include/blo

[Qemu-devel] [PATCH v5 04/11] nbd/server: Report error for write to read-only export

2017-10-19 Thread Eric Blake
When the server is read-only, we were already reporting an error message for NBD_CMD_WRITE_ZEROES, but failed to set errp for a similar NBD_CMD_WRITE. This will matter more once structured replies allow the server to propagate the errp information back to the client. While at it, use an error mes

[Qemu-devel] [PATCH v5 03/11] nbd: Expose constants and structs for structured read

2017-10-19 Thread Eric Blake
Upcoming patches will implement the NBD structured reply extension [1] for both client and server roles. Declare the constants, structs, and lookup routines that will be valuable whether the server or client code is backported in isolation. This includes moving one constant from an internal heade

[Qemu-devel] [PATCH v5 00/11] nbd minimal structured read

2017-10-19 Thread Eric Blake
I've incorporated a few more tweaks since v4: https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg03305.html I tried to call out the biggest changes in the various commits, but it includes bug fixes from my testing, and fixing places spotted by Vladimir. I still haven't validated the behavio

[Qemu-devel] [PATCH v5 02/11] nbd: Move nbd_errno_to_system_errno() to public header

2017-10-19 Thread Eric Blake
This is needed in preparation for structured reply handling, as we will be performing the translation from NBD error to system errno value higher in the stack at block/nbd-client.c. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 13 + n

Re: [Qemu-devel] [PULL 07/11] tools: add qemu-keymap

2017-10-19 Thread Eric Blake
On 10/19/2017 05:09 PM, Eric Blake wrote: > On 10/16/2017 08:16 AM, Gerd Hoffmann wrote: >> qemu-keymap generates qemu reverse keymaps from xkb keymaps, >> which can be used with the qemu "-k" command line switch. >> >> Signed-off-by: Gerd Hoffmann >> Message-id: 20171005153330.19210-2-kra...@redh

Re: [Qemu-devel] [PULL 07/11] tools: add qemu-keymap

2017-10-19 Thread Eric Blake
On 10/16/2017 08:16 AM, Gerd Hoffmann wrote: > qemu-keymap generates qemu reverse keymaps from xkb keymaps, > which can be used with the qemu "-k" command line switch. > > Signed-off-by: Gerd Hoffmann > Message-id: 20171005153330.19210-2-kra...@redhat.com > --- > configure | 23 ++ > Ma

Re: [Qemu-devel] [PATCH 24/42] tpm-be: call request_completed() out of thread

2017-10-19 Thread Stefan Berger
On 10/09/2017 06:56 PM, Marc-André Lureau wrote: Lift from the backend implementation the responsability to call the request_completed() callback outside of thread context. This also I don't think this is what you are doing here. It's still in thread context. Something is breaking the TIS inte

Re: [Qemu-devel] [PATCH v4 5/8] nbd/server: Include human-readable message in structured errors

2017-10-19 Thread Eric Blake
On 10/14/2017 08:01 PM, Eric Blake wrote: > The NBD spec permits including a human-readable error string if > structured replies are in force, so we might as well send the > client the message that we logged on any error. > > Signed-off-by: Eric Blake > --- > nbd/server.c | 22 ++

[Qemu-devel] [PATCH 1/2] target/arm: Move BE32 disassembler fixup

2017-10-19 Thread Richard Henderson
The Capstone disassembler has its own big-endian fixup. Doing this twice does not work, of course. Move our current fixup from target/arm/cpu.c to disas/arm.c. This makes read_memory_inner_func unused and can be removed. Signed-off-by: Richard Henderson --- include/disas/bfd.h | 7 --- di

[Qemu-devel] [PATCH 0/2] Fix armeb-linux-user disassembly

2017-10-19 Thread Richard Henderson
Reported in https://bugs.launchpad.net/qemu/+bug/1724485 There's one existing bug here, wrt setting INSN_ARM_BE32, and another when it comes to the capstone disassembler patch set. r~ Richard Henderson (2): target/arm: Move BE32 disassembler fixup target/arm: Don't set INSN_ARM_BE32 for

[Qemu-devel] [PATCH 2/2] target/arm: Don't set INSN_ARM_BE32 for CONFIG_USER_ONLY

2017-10-19 Thread Richard Henderson
This matches translator behaviour in arm_lduw_code. Fixes: https://bugs.launchpad.net/qemu/+bug/1724485 Signed-off-by: Richard Henderson --- target/arm/cpu.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index bc9d70df04..a0ed11c

Re: [Qemu-devel] [PATCH] don't hardcode EL1 in extended_addresses_enabled

2017-10-19 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Peter Maydell wrote: > On 18 October 2017 at 23:41, Stefano Stabellini > wrote: > > extended_addresses_enabled calls arm_el_is_aa64, hardcoding exception > > level 1. Instead, retrieve the current el calling arm_current_el. > > > > Signed-off-by: Stefano Stabellini > > > > d

Re: [Qemu-devel] [PATCH v4 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-10-19 Thread Paolo Bonzini
On 19/10/2017 19:43, Michael S. Tsirkin wrote: > On Thu, Oct 19, 2017 at 05:43:18PM +0200, Paolo Bonzini wrote: >> On 19/10/2017 17:39, Michael S. Tsirkin wrote: Add VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG messages which can be used for live migration of vhost user devices, also vhost

Re: [Qemu-devel] [PATCH v5 03/10] qemu-iotests: automatically clean up bash protocol servers

2017-10-19 Thread Paolo Bonzini
On 19/10/2017 16:52, Jeff Cody wrote: > On Thu, Oct 19, 2017 at 12:23:39PM +0200, Paolo Bonzini wrote: >> On 18/10/2017 19:27, Jeff Cody wrote: >>> On final exit, yes, a test needs not remember to remove all of its mouse >>> droppings. But as far as not needing to remove images in intermediate >>>

[Qemu-devel] unknown keycodes `(unnamed)'

2017-10-19 Thread Spaceboy Ross
unknown keycodes `(unnamed)', please report to qemu-devel@nongnu.org uname -a returns: Linux spaceboyross-Latitude-D630 4.13.0-16-generic #19-Ubuntu SMP Wed Oct 11 18:35:14 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Re: [Qemu-devel] [PATCH] fix WFI/WFE length in syndrome register

2017-10-19 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Peter Maydell wrote: > On 18 October 2017 at 23:03, Stefano Stabellini > wrote: > > WFI/E are 4 bytes long: set ARM_EL_IL_SHIFT in the syndrome. > > > > Signed-off-by: Stefano Stabellini > > > > diff --git a/target/arm/internals.h b/target/arm/internals.h > > index 1f6efef..

Re: [Qemu-devel] Running Qemu in discrete time/step by step

2017-10-19 Thread Emilio G. Cota
On Thu, Oct 19, 2017 at 14:14:12 +0900, Matt wrote: (snip) > - VMSimint does nearly that, it runs Qemu in discrete time but > interface it with a JAVA simulator > http://www.ikr.uni-stuttgart.de/Content/Publications/Archive/We_SIMUTools_2014_40209.pdf > (with the code http://www.ikr.uni-stuttgart.d

Re: [Qemu-devel] [PATCH v4 RFC 9/8] nbd: Minimal structured read for client

2017-10-19 Thread Eric Blake
On 10/17/2017 04:17 PM, Eric Blake wrote: > On 10/17/2017 07:57 AM, Vladimir Sementsov-Ogievskiy wrote: >> Minimal implementation: for structured error only error_report error >> message. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- > But in the client, I then perform 'w 0 0' (a zero-

Re: [Qemu-devel] [PATCH v6 0/9] Support the Capstone disassembler

2017-10-19 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20171019155146.30434-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v6 0/9] Support the

[Qemu-devel] [PATCH] translate-all: exit from tb_phys_invalidate if qht_remove fails

2017-10-19 Thread Emilio G. Cota
Two or more threads might race while invalidating the same TB. We currently do not check for this at all despite taking tb_lock, which means we would wrongly invalidate the same TB more than once. This bug has actually been hit by users: I recently saw a report on IRC, although I have yet to see th

Re: [Qemu-devel] [PATCH v6 00/50] tcg tb_lock removal

2017-10-19 Thread Emilio G. Cota
On Thu, Oct 19, 2017 at 15:05:17 +0200, Paolo Bonzini wrote: > On 19/10/2017 00:45, Emilio G. Cota wrote: > > I have just pushed a branch on top of this series that includes > > 10 patches that further pave the way for the removal of tb_lock: > > > > https://github.com/cota/qemu/tree/multi-tcg-v

[Qemu-devel] [PATCH] build: Don't force preserving permissions on config-devices.mak.old

2017-10-19 Thread Aaron Lindsay
I get the following error when building on an NFSv3 filesystem: % make -j8 GEN aarch64-softmmu/config-devices.mak.tmp GEN config-host.h [snip] GEN qmp-marshal.c GEN aarch64-softmmu/config-devices.mak cp: preserving permissions for ‘aarch64-softmmu/config-devices.mak.old’:

Re: [Qemu-devel] [RFC 0/6] enable numa configuration before machine_init() from HMP/QMP

2017-10-19 Thread Eduardo Habkost
On Thu, Oct 19, 2017 at 04:28:59PM +0100, Daniel P. Berrange wrote: > On Thu, Oct 19, 2017 at 11:21:22AM -0400, Igor Mammedov wrote: > > - Original Message - > > > From: "Daniel P. Berrange" > > > To: "Igor Mammedov" > > > Cc: "peter maydell" , pkre...@redhat.com, > > > ehabk...@redhat.c

Re: [Qemu-devel] [PATCH v4 RFC 9/8] nbd: Minimal structured read for client

2017-10-19 Thread Eric Blake
On 10/17/2017 07:57 AM, Vladimir Sementsov-Ogievskiy wrote: > Minimal implementation: for structured error only error_report error > message. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > +static int nbd_co_request(BlockDriverState *bs, NBDRequest *request, > +

Re: [Qemu-devel] [PATCH v3 42/46] util: Replace fprintf(stderr, "*\n" with error_report()

2017-10-19 Thread Stefan Weil
Am 19.10.2017 um 19:53 schrieb Thomas Huth: > On 19.10.2017 18:18, Alistair Francis wrote: >> Replace a large number of the fprintf(stderr, "*\n" calls with >> error_report(). The functions were renamed with these commands and then >> compiler issues where manually fixed. > [...] >> diff --git a/ut

Re: [Qemu-devel] [PATCH v2] arm: Adding makefile for Kinetis K64 MK64FN1M0

2017-10-19 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1508417485-31911-1-git-send-email-gabriel291...@gmail.com Subject: [Qemu-devel] [PATCH v2] arm: Addin

Re: [Qemu-devel] [PATCH v4 6/8] nbd/client: refactor nbd_receive_starttls

2017-10-19 Thread Eric Blake
On 10/14/2017 08:01 PM, Eric Blake wrote: > From: Vladimir Sementsov-Ogievskiy > > Split out nbd_request_simple_option to be reused for structured reply > option. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Eric Blake > > +static int nbd_request_simple_option(QIOChannel

Re: [Qemu-devel] [PATCH v2] arm: Adding makefile for Kinetis K64 MK64FN1M0

2017-10-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1508417485-31911-1-git-send-email-gabriel291...@gmail.com Subject: [Qemu-devel] [PATCH v2] arm: Adding makefile for Kinetis K64 MK64FN1M0 === TEST SCRIPT BEGIN === #!/bin/bas

Re: [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK64FN1M0

2017-10-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1508417443-31849-1-git-send-email-gabriel291...@gmail.com Subject: [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK64FN1M0 === TEST SCRIPT BEGIN === #!/bi

[Qemu-devel] [PATCH] configure: disable qemu-keymap for linux-user qemu

2017-10-19 Thread Laurent Vivier
We don't need qemu-keymap when we build only linux-user qemu. When we compile in static mode, the libxkbcommon is detected by configure if the shared one is available, but cannot be linked if the static version is not available. As we don't need it for qemu-linux-user, and we generally need a sta

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-19 Thread Andrew McLeod
I've tested with the packages from the ppa: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/2995 qemu: Installed: 1:2.8+dfsg-3ubuntu2.7~ppa5cloud qemu-system-arm: Installed: 1:2.8+dfsg-3ubuntu2.7~ppa5cloud qemu-system-aarch64: Installed: 1:2.8+dfsg-3ubuntu2.7~ppa5cloud Reboot

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-19 Thread Sean Feole
will test these and report back shortly. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1719196 Title: [arm64 ocata] newly created instances are unable to raise network interfaces Status in Ubunt

Re: [Qemu-devel] [PATCH v3 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-10-19 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20171016222315.407-1-mdr...@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH v3 0/3] qdev/vfio: defer

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2017-10-19 Thread Mark Cave-Ayland
On 19/10/17 19:18, Peter Maydell wrote: > On 19 October 2017 at 08:10, Mark Cave-Ayland > wrote: >> Hi Peter, >> >> Here are the latest set of updates for OpenBIOS which should be pulled after >> the sun4u >> patches have been applied due to breaking changes in the sun4u machine. >> >> >> ATB, >

Re: [Qemu-devel] [PATCH v3 0/7] migration: pause-before-switchover

2017-10-19 Thread Dr. David Alan Gilbert
* Jiri Denemark (jdene...@redhat.com) wrote: > The libvirt changes which will make use of this new migration capability > can be found in migration-pause branch of my gitlab repository: > > git fetch https://gitlab.com/jirkade/libvirt.git migration-pause > > It's not properly split into patch

Re: [Qemu-devel] [PATCH v4 RFC 9/8] nbd: Minimal structured read for client

2017-10-19 Thread Eric Blake
On 10/17/2017 07:57 AM, Vladimir Sementsov-Ogievskiy wrote: > Minimal implementation: for structured error only error_report error > message. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- and I replied: > > But in the client, I then perform 'w 0 0' (a zero-byte write, which > should fai

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-19 Thread Dan Williams
On Thu, Oct 19, 2017 at 1:01 AM, Christoph Hellwig wrote: > On Wed, Oct 18, 2017 at 08:51:37AM -0700, Dan Williams wrote: >> This use case is not "Persistent Memory". Persistent Memory is >> something you can map and make persistent with CPU instructions. >> Anything that requires a driver call is

Re: [Qemu-devel] [PULL] qemu-sparc updates

2017-10-19 Thread Peter Maydell
On 19 October 2017 at 07:58, Mark Cave-Ayland wrote: > Hi Peter, > > Here are my sun4u patches for 2.11. Note that because of the machine changes > there is an openbios-sparc64 binary update included in the first patch to > maintain bisectability. There will be a follow-up patch for OpenBIOS which

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2017-10-19 Thread Peter Maydell
On 19 October 2017 at 08:10, Mark Cave-Ayland wrote: > Hi Peter, > > Here are the latest set of updates for OpenBIOS which should be pulled after > the sun4u > patches have been applied due to breaking changes in the sun4u machine. > > > ATB, > > Mark. > > > The following changes since commit 861

[Qemu-devel] [PULL v1 02/21] tpm-tis: remove RAISE_STS_IRQ

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau This look like temporary hacking code. It shouldn't be necessary in release code, or there should be a runtime option for it. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 24 +--- 1

[Qemu-devel] [PULL v1 14/21] tpm: add TPMBackendCmd to hold the request state

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau This simplifies a bit locality handling, and argument passing, and could pave the way to queuing requests (if that makes sense). Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- backends/tpm.c | 6 +++--- hw/t

[Qemu-devel] [PULL v1 19/21] tpm-tis: fold TPMTISEmuState in TPMState

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 336 ++- 1 file changed, 157 insertions(+), 179 deletions(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_

  1   2   3   4   >