Am 19.10.2017 um 19:53 schrieb Thomas Huth:
> On 19.10.2017 18:18, Alistair Francis wrote:
>> Replace a large number of the fprintf(stderr, "*\n" calls with
>> error_report(). The functions were renamed with these commands and then
>> compiler issues where manually fixed.
> [...]
>> diff --git a/util/aio-posix.c b/util/aio-posix.c
>> index 5946ac09f0..29fff51fcf 100644
>> --- a/util/aio-posix.c
>> +++ b/util/aio-posix.c
>> @@ -15,6 +15,7 @@
>>
>> #include "qemu/osdep.h"
>> #include "qemu-common.h"
>> +#include "qemu/error-report.h"
>> #include "block/block.h"
>> #include "qemu/rcu_queue.h"
>> #include "qemu/sockets.h"
>> @@ -703,8 +704,8 @@ void aio_context_setup(AioContext *ctx)
>> {
>> /* TODO remove this in final patch submission */
>> if (getenv("QEMU_AIO_POLL_MAX_NS")) {
>> - fprintf(stderr, "The QEMU_AIO_POLL_MAX_NS environment variable has "
>> - "been replaced with -object iothread,poll-max-ns=NUM\n");
>> + error_report("The QEMU_AIO_POLL_MAX_NS environment variable has "
>> + "been replaced with -object iothread,poll-max-ns=NUM");
>> exit(1);
>> }
>
> The comment in front of this code block indicates that this should
> rather be removed completely. Stefan, do you agree?
I assume you asked the other Stefan, but I think he'll agree as I do,
because it is obvious that such random debug code does not belong
into the QEMU code base.
Stefan
