Re: [Qemu-devel] [PATCH v3 0/2] virtio-iommu: VFIO integration

2017-08-23 Thread Bharat Bhushan
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Wednesday, August 23, 2017 10:12 PM > To: Bharat Bhushan ; > eric.auger@gmail.com; peter.mayd...@linaro.org; > alex.william...@redhat.com; m...@redhat.com; qemu-...@nongnu.org; > qemu-devel@nongnu.o

Re: [Qemu-devel] [PATCH for-2.11] hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false

2017-08-23 Thread Paolo Bonzini
On 24/08/2017 05:03, Thomas Huth wrote: > QEMU currently aborts with an assertion message when the user is trying > to remove a dscm1 again: > > $ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic > QEMU 2.9.93 monitor - type 'help' for more information > (qemu) device_add dscm

Re: [Qemu-devel] make check speed

2017-08-23 Thread Thomas Huth
On 23.08.2017 14:20, Cornelia Huck wrote: > On Wed, 23 Aug 2017 10:35:43 +0200 > Thomas Huth wrote: > >> True. And I just learned that you can also already set the SPEED >> variable to either "quick" or "slow" and that we're already using >> g_test_quick() and g_test_slow() in a couple of places

Re: [Qemu-devel] [PATCH 0/4] four zpci patches

2017-08-23 Thread Yi Min Zhao
Why can't I receive [Qemu-devel] prefixed patches? 在 2017/8/23 下午3:26, Yi Min Zhao 写道: This patch set contains four small zpci patches to fixup different issues. 1) fixup calculation of msix boundary 2) remove zpci idx from msix message, instead we could use PCIDevice's id to find zpci devi

[Qemu-devel] [PATCH for-2.11] tests/test-hmp: Remove puv3 and tricore_testboard from the blacklist

2017-08-23 Thread Thomas Huth
The problem with puv3 has been fixed with 0ac241bcf9f9d99a252a352a162f ('unicore32: abort when entering "x 0" on the monitor') and the problem with tricore_testboard has been fixed with b190f477e29c7cd03a8fee49c96d ('qemu-system-tricore: segfault when entering "x 0" on the monitor'). Signed-off-by

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-23 Thread David Gibson
On Thu, Aug 24, 2017 at 02:15:01PM +1000, Paul Mackerras wrote: > On Thu, Aug 24, 2017 at 02:02:43PM +1000, David Gibson wrote: > > On Thu, Aug 24, 2017 at 12:54:48PM +1000, Paul Mackerras wrote: > > > On Mon, Aug 21, 2017 at 05:00:36PM -0300, Thiago Jung Bauermann wrote: > > > > LoPAPR says: > > >

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-23 Thread Paul Mackerras
On Thu, Aug 24, 2017 at 02:02:43PM +1000, David Gibson wrote: > On Thu, Aug 24, 2017 at 12:54:48PM +1000, Paul Mackerras wrote: > > On Mon, Aug 21, 2017 at 05:00:36PM -0300, Thiago Jung Bauermann wrote: > > > LoPAPR says: > > > > > > “ibm,processor-storage-keys” > > > > > > property name

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-23 Thread David Gibson
On Thu, Aug 24, 2017 at 12:54:48PM +1000, Paul Mackerras wrote: > On Mon, Aug 21, 2017 at 05:00:36PM -0300, Thiago Jung Bauermann wrote: > > LoPAPR says: > > > > “ibm,processor-storage-keys” > > > > property name indicating the number of virtual storage keys supported > > by the proce

Re: [Qemu-devel] [PATCH v2 for-2.11] hw/ppc/spapr_cpu_core: Add a proper check for spapr machine

2017-08-23 Thread David Gibson
On Thu, Aug 24, 2017 at 05:52:32AM +0200, Thomas Huth wrote: > QEMU currently crashes when the user tries to add a spapr-cpu-core > on a non-pseries machine: > > $ qemu-system-ppc64 -S -machine ppce500,accel=tcg \ > -device POWER5+_v2.1-spapr-cpu-core > hw/ppc/spapr_cpu_core.c:

[Qemu-devel] [PATCH v2 for-2.11] hw/ppc/spapr_cpu_core: Add a proper check for spapr machine

2017-08-23 Thread Thomas Huth
QEMU currently crashes when the user tries to add a spapr-cpu-core on a non-pseries machine: $ qemu-system-ppc64 -S -machine ppce500,accel=tcg \ -device POWER5+_v2.1-spapr-cpu-core hw/ppc/spapr_cpu_core.c:178:spapr_cpu_core_realize_child: Object 0x55cee1f55160 is not an instanc

Re: [Qemu-devel] make check speed

2017-08-23 Thread David Gibson
On Wed, Aug 23, 2017 at 11:33:55AM +0200, Paolo Bonzini wrote: > On 23/08/2017 10:35, Thomas Huth wrote: > >> If you have a many-core machine, of course, there's no simpler solution > >> than throwing more CPUs at it. :) > > Is it safe nowadays to run "make check -j4" for example? Last time I > > t

Re: [Qemu-devel] [Bug 1711828] Re: lock mov non generated #UD

2017-08-23 Thread li
sorry i english poor: intel manual say: The LOCK prefix can be prepended only to the following instructions and only to those forms of the instructions where the destination operand is a memory operand: ADD, ADC, AND, BTC, BTR, BTS, CMPXCHG, CMPXCH8B, CMPXCHG16B, DEC, INC, NEG, NOT, OR, SBB, SU

[Qemu-devel] anyone seen or heard of large delays/stalls running qemu with kvm support?

2017-08-23 Thread Chris Friesen
Hi all, I need to apologize up front, this is going to be a long email. Basically the executive summary is that we're seeing issues where a VM is apparently not making forward progress in the guest, while at the same time spinning in a busy loop on the host. I'm looking for any pointers/sug

[Qemu-devel] [PATCH for-2.11] hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false

2017-08-23 Thread Thomas Huth
QEMU currently aborts with an assertion message when the user is trying to remove a dscm1 again: $ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic QEMU 2.9.93 monitor - type 'help' for more information (qemu) device_add dscm1,id=xyz (qemu) device_del xyz ** ERROR:qemu/qde

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-23 Thread David Gibson
On Wed, Aug 23, 2017 at 01:12:06PM +0200, BALATON Zoltan wrote: > On Wed, 23 Aug 2017, David Gibson wrote: > > On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > > > Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. > > > This is not a full implementation yet wi

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-23 Thread David Gibson
On Wed, Aug 23, 2017 at 02:47:42PM +0200, BALATON Zoltan wrote: > On Wed, 23 Aug 2017, François Revol wrote: > > Le 23/08/2017 à 13:12, BALATON Zoltan a écrit : > > > > What's the connection with mips_malta? > > > > > > The board's firmware wants to see SPD EEPROMs of the connected memory > > > wh

Re: [Qemu-devel] [PATCH 13/15] ppc4xx: Add more PLB registers

2017-08-23 Thread David Gibson
On Wed, Aug 23, 2017 at 12:16:24PM +0200, BALATON Zoltan wrote: > On Wed, 23 Aug 2017, David Gibson wrote: > > On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > > > These registers are present in 440 SoCs (and maybe in others too) and > > > U-Boot accesses them when printing registe

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-23 Thread Paul Mackerras
On Mon, Aug 21, 2017 at 05:00:36PM -0300, Thiago Jung Bauermann wrote: > LoPAPR says: > > “ibm,processor-storage-keys” > > property name indicating the number of virtual storage keys supported > by the processor described by this node. > > prop-encoded-array: Consists of two cell

Re: [Qemu-devel] [PATCH 06/27] vhost-user-scsi: code style fixes

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/23/2017 01:19 PM, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- contrib/vhost-user-scsi/vhost-user-scsi.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/contrib/vhost-user-scsi/vhost-user

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-23 Thread David Gibson
On Wed, Aug 23, 2017 at 01:43:56PM +0200, François Revol wrote: > Le 23/08/2017 à 13:12, BALATON Zoltan a écrit : > >> What's the connection with mips_malta? > > > > The board's firmware wants to see SPD EEPROMs of the connected memory > > while initialising the memory controller. This is why we n

Re: [Qemu-devel] [PATCH for-2.11 08/27] sparc: replace cpu_sparc_init() with cpu_generic_init()

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/21/2017 08:11 AM, Igor Mammedov wrote: Philippe Mathieu-Daudé wrote: I succeed booting a SPARC image once applying 1 to 8 (this commit), so not being able to boot the image previously is probably due to patch order, which mean current order is not bisect-able. I repeated patch by patch

Re: [Qemu-devel] [PATCH for-2.11 08/27] sparc: replace cpu_sparc_init() with cpu_generic_init()

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/18/2017 07:08 AM, Igor Mammedov wrote: it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- CC: Fabien Chouteau CC: Mark Cave-Ayland CC: Artyom Tarasenko --- targe

Re: [Qemu-devel] [PATCH for-2.11 04/27] sparc: move adhoc CPUSPARCState initialization to realize time

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/18/2017 07:08 AM, Igor Mammedov wrote: SPARCCPU::env was initialized from previosuly set properties "previously" (with help of sparc_cpu_parse_features) in cpu_sparc_register(). However there is not reason to keep it there as this task is typically done at realize time. So move post pro

Re: [Qemu-devel] [PATCH for-2.11 02/27] sparc: embed sparc_def_t into CPUSPARCState

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/18/2017 07:08 AM, Igor Mammedov wrote: Make CPUSPARCState::def embedded so it would be allocated as part of cpu instance and we won't have to worry about cleaning def pointer up mannualy on cpu destruction. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Tested-by: Phi

Re: [Qemu-devel] [PATCH for-2.11 01/27] sparc: convert cpu models to SPARC cpu subclasses

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/22/2017 10:12 PM, Philippe Mathieu-Daudé wrote: On 08/18/2017 07:08 AM, Igor Mammedov wrote: QOMfy cpu models handling introducing propper cpu types for each cpu model. Signed-off-by: Igor Mammedov --- with this and conversion of features to properties, it would be possible to replace cp

Re: [Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

2017-08-23 Thread Dou Liyang
Hi Igor, At 08/24/2017 01:47 AM, Igor Mammedov wrote: On Wed, 23 Aug 2017 21:35:29 +0800 Dou Liyang wrote: Hi Igor, At 08/23/2017 08:45 PM, Igor Mammedov wrote: On Wed, 23 Aug 2017 20:12:51 +0800 Dou Liyang wrote: Hi Igor, At 08/23/2017 04:40 PM, Igor Mammedov wrote: On Tue, 22 Aug 201

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-23 Thread David Gibson
On Wed, Aug 23, 2017 at 08:14:32PM -0300, Thiago Jung Bauermann wrote: > > Hello David, > > Thank you for your input. > > David Gibson writes: > > > On Mon, Aug 21, 2017 at 05:00:36PM -0300, Thiago Jung Bauermann wrote: > >> LoPAPR says: > >> > >> “ibm,processor-storage-keys” > >> > >>

Re: [Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

2017-08-23 Thread Dou Liyang
Hi Eduardo, At 08/24/2017 01:25 AM, Eduardo Habkost wrote: On Wed, Aug 23, 2017 at 09:35:29PM +0800, Dou Liyang wrote: Hi Igor, At 08/23/2017 08:45 PM, Igor Mammedov wrote: On Wed, 23 Aug 2017 20:12:51 +0800 Dou Liyang wrote: Hi Igor, At 08/23/2017 04:40 PM, Igor Mammedov wrote: On Tue,

Re: [Qemu-devel] [PATCH v5 2/9] kvm: remove hard dependency on pci

2017-08-23 Thread Thomas Huth
On 23.08.2017 17:54, Cornelia Huck wrote: > The msi routing code in kvm calls some pci functions: provide > some stubs to enable builds without pci. > > Also, to make this more obvious, guard them via a pci_available boolean > (which also can be reused in other places). > > Fixes: e1d4fb2de ("kvm

[Qemu-devel] qemu wowlan support

2017-08-23 Thread Shahar Matityahu
hello, I am using qemu and I want to know if it is possible to to use wowlan under qemu I assigned my NIC to the qemu with pci-pass-through and I couldn't get it to work with wowlan Thanks in advance, Shahar S Matityahu

[Qemu-devel] [PATCH] qemu-doc: Add UUID support in initiator name

2017-08-23 Thread Fred Rolland
Update doc with the usage of UUID for initiator name. Related-To: https://bugzilla.redhat.com/1006468 Signed-off-by: Fred Rolland --- qemu-doc.texi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index 9811476..4076226 100644 --- a/qemu-doc.

Re: [Qemu-devel] [PATCH 00/27] vhost-user-scsi: code clean-up

2017-08-23 Thread Liu, Changpeng
Thanks for helping the example code clean-up. I can rebase the vhost-user-blk patch set after your commits. For the issue you mentioned below, I think the vhost-user-scsi example can only support 1 LUN, so LUN0 is exist, LUN1 reported error should be okay. > -Original Message- > From: Ma

Re: [Qemu-devel] [PATCH] multiboot: make tests work with clang

2017-08-23 Thread Philippe Mathieu-Daudé
Hi Anatol, Next time use 'v2' for an updated patch (for the automated tracking tools), also no need to link it to the previous Message-Id it looks more messy and can get lost. On 08/23/2017 09:01 PM, Anatol Pomozov wrote: * clang 3.8 enables SSE even for 32bit code. Generate code for penti

Re: [Qemu-devel] [PATCH 16/27] vhost-user-scsi: remove VUS_MAX_LUNS

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/23/2017 01:19 PM, Marc-André Lureau wrote: There is no code to support more than 1 yet, no need for that today. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- contrib/vhost-user-scsi/vhost-user-scsi.c | 8 +++- 1 file changed, 3 insertions(+), 5 delet

Re: [Qemu-devel] [PATCH 19/27] vhost-user-scsi: avoid use of iscsi_ namespace

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/23/2017 01:19 PM, Marc-André Lureau wrote: It is confusing and could easily conflict with future versions. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- contrib/vhost-user-scsi/vhost-user-scsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH 27/27] vhost-user-scsi: remove server_sock from VusDev

2017-08-23 Thread Philippe Mathieu-Daudé
Hi Marc-André, On 08/23/2017 01:20 PM, Marc-André Lureau wrote: It is unneeded in the VusDev device structure, and also simplify a bit the code. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-scsi/vhost-user-scsi.c | 52 ++- 1 file changed, 23 insertions

Re: [Qemu-devel] [PATCH] multiboot: make tests work with clang

2017-08-23 Thread Anatol Pomozov
On Wed, Aug 23, 2017 at 4:44 PM, Philippe Mathieu-Daudé wrote: > Hi Anatol, > > On 08/23/2017 04:22 PM, Anatol Pomozov wrote: >> >> * explicitly disable SSE as clang enables it by default for 32bit code >> * add memset() implementation. Clang complains that the function is >> absent, gcc s

[Qemu-devel] [PATCH] multiboot: make tests work with clang

2017-08-23 Thread Anatol Pomozov
* clang 3.8 enables SSE even for 32bit code. Generate code for pentium CPU to make sure no new instructions are used. * add memset() implementation. Clang implements array zeroing in print_num() via memset() function call. --- tests/multiboot/Makefile| 2 +- tests/multiboot/libc.c

Re: [Qemu-devel] [PATCH 23/27] vhost-user-scsi: use glib logging

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/23/2017 01:20 PM, Marc-André Lureau wrote: - PLOG is unused - code is compiled out unless debug is enabled - logging is too verbose - you can pipe to ts to have timestamp if needed, or use structured logging with more recent glib Signed-off-by: Marc-André Lureau Reviewed-by: Philippe

Re: [Qemu-devel] [PATCH 21/27] vhost-user-scsi: drop extra callback pointer

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/23/2017 01:19 PM, Marc-André Lureau wrote: Use the one from the source with casting, like any other glib source. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-scsi/vhost-user-scsi.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/contrib/vhost

Re: [Qemu-devel] [PATCH] multiboot: make tests work with clang

2017-08-23 Thread Philippe Mathieu-Daudé
Hi Anatol, On 08/23/2017 04:22 PM, Anatol Pomozov wrote: * explicitly disable SSE as clang enables it by default for 32bit code * add memset() implementation. Clang complains that the function is absent, gcc seems provides default built-in. --- tests/multiboot/Makefile | 2 +- tests/m

Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

2017-08-23 Thread Fam Zheng
On Wed, 08/23 18:44, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Introducing this new parameter for QMP commands in general to mark out > > when the command does not need BQL. Normally QMP command executions are > > done with the protection of BQL in QEMU. However th

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-23 Thread Thiago Jung Bauermann
Hello David, Thank you for your input. David Gibson writes: > On Mon, Aug 21, 2017 at 05:00:36PM -0300, Thiago Jung Bauermann wrote: >> LoPAPR says: >> >> “ibm,processor-storage-keys” >> >> property name indicating the number of virtual storage keys supported >> by the processor

[Qemu-devel] [PATCH 5/5] pci: Validate interfaces on base_class_init

2017-08-23 Thread Eduardo Habkost
Make sure we don't forget to add the legacy-PCI or PCIe interface names on PCI device classes in the future. Signed-off-by: Eduardo Habkost --- hw/pci/pci.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index baa3429..7ac5cc6 100644 --- a/hw/pci/pc

Re: [Qemu-devel] Number of usable slots in PCIe Root Port / PCIe Switch Downstream Port

2017-08-23 Thread Eduardo Habkost
On Wed, Aug 23, 2017 at 11:16:27PM +0300, Marcel Apfelbaum wrote: > On 23/08/2017 19:46, Andrea Bolognani wrote: > > AFAIK some PCI controllers, particularly: > > > >* PCIe Root Port (pcie-root-port, ioh3420) > >* PCIe Switch Downstream Port (xio3130-downstream) > > > > only have a single

[Qemu-devel] [PATCH 4/5] pci: Add INTERFACE_LEGACY_PCI_DEVICE to legacy PCI devices

2017-08-23 Thread Eduardo Habkost
Add INTERFACE_LEGACY_PCI_DEVICE to all direct subtypes of TYPE_PCI_DEVICE, except: 1) The ones that already have INTERFACE_PCIE_DEVICE set: * base-xhci * e1000e * nvme * pvscsi * vfio-pci * virtio-pci * vmxnet3 2) base-pci-bridge Not all PCI bridges are legacy PCI devices, so INTERFACE_LEGACY_P

[Qemu-devel] [PATCH 3/5] pci: Add INTERFACE_PCIE_DEVICE to all PCIe devices

2017-08-23 Thread Eduardo Habkost
Change all devices that set is_express=1 to implement INTERFACE_PCIE_DEVICE. Signed-off-by: Eduardo Habkost --- hw/block/nvme.c| 4 hw/net/e1000e.c| 4 hw/pci-bridge/pcie_root_port.c | 4 hw/pci-bridge/xio3130_downstream.c | 4 hw/p

[Qemu-devel] [PATCH 1/5] pci: INTERFACE_LEGACY_PCI_DEVICE and INTERFACE_PCIE_DEVICE interfaces

2017-08-23 Thread Eduardo Habkost
Those two interfaces will be used to indicate which device types support legacy PCI or PCI-express buses. Management software will be able to use the qom-list-types QMP command to query that information. Signed-off-by: Eduardo Habkost --- include/hw/pci/pci.h | 6 ++ hw/pci/pci.c |

[Qemu-devel] [PATCH 2/5] pci: Add interface names to hybrid PCI devices

2017-08-23 Thread Eduardo Habkost
The following devices support both PCIe and legacy PCI, by including special code to handle the QEMU_PCI_CAP_EXPRESS flag: * vfio-pci (is_express=1, but legacy PCI handled by vfio_populate_device()) * vmxnet3 (is_express=0, but PCIe handled by vmxnet3_realize()) * pvscsi (is_express=0, but PCIe

[Qemu-devel] [PATCH 0/5] Mark legacy/PCIe/hybrid PCI devices using interface names

2017-08-23 Thread Eduardo Habkost
This series is a reimplementation of one portion of an old RFC: Subject: [RFC v2 00/20] qmp: Report bus information on 'query-machines' Specifically, this reimplements the portion that marks each PCI device type as legacy/PCIe/hybrid. It uses two new QOM interface names to do that: I

Re: [Qemu-devel] [Qemu-block] [PATCH v5 08/13] tests: Rely more on global_qtest

2017-08-23 Thread Paolo Bonzini
On 23/08/2017 23:30, Eric Blake wrote: >> Well, whatever is assigning to global_qtest should be using the long form. > Question - what about going the other way, and switching ALL callers to > always use the explicit form? I'd really like to maintain only one > form, but if we think maintaining th

Re: [Qemu-devel] [Qemu-block] [PATCH v5 08/13] tests: Rely more on global_qtest

2017-08-23 Thread Eric Blake
On 08/23/2017 03:02 PM, Paolo Bonzini wrote: > On 23/08/2017 21:26, Eric Blake wrote: >>> I agree with using the short form where possible, but I disagree on >>> removing the long forms. Rather, global_qtest in my opinion should have >>> been static (though I'm not proposing that you do this); inl

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-23 Thread ChristianEhrhardt
Yes, with all the series of [1] on top it finally works. Saw it already being merged on master. Expecting a late rc4 or early release tag and then wrap all it up. Thanks everybody involved! [1]: http://lists.nongnu.org/archive/html/qemu- devel/2017-08/msg04513.html ** Changed in: qemu Sta

Re: [Qemu-devel] [PULL 0/6] NBD pull request for 2.10-rc4

2017-08-23 Thread Christian Ehrhardt
On Wed, Aug 23, 2017 at 6:33 PM, Eric Blake wrote: [...] > > > nbd patches for 2017-08-23 > > - Fam Zheng: 0/4 block: Fix non-shared storage migration > - Stefan Hajnoczi: qemu-iotests: add 194 non-shared storage migration test > - S

[Qemu-devel] [PATCH] hw/ppc: CAS reset on early device hotplug

2017-08-23 Thread Daniel Henrique Barboza
This patch is a follow up on the discussions made in patch "hw/ppc: disable hotplug before CAS is completed" that can be found at [1]. At this moment, we do not support CPU/memory hotplug in early boot stages, before CAS. When a hotplug occurs, the event is logged in an internal rtas event log que

Re: [Qemu-devel] [PATCH] audio: intel-hda: do not use old_mmio accesses

2017-08-23 Thread Matt Parker
On 22 August 2017 at 09:44, Peter Maydell wrote: > On 21 August 2017 at 22:13, Matt Parker wrote: >> intel-hda is still using the old_mmio accessors for io. >> This updates the device to use .read and .write accessors instead. > > Hi; thanks for this patch. > > It looks like you forgot to provide

Re: [Qemu-devel] [PATCH v2 2/2] Add a unique ID in the virt machine to be used as device ID

2017-08-23 Thread Edgar E. Iglesias
On Tue, Aug 22, 2017 at 10:04:25PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 22, 2017 at 03:13:57PM +, Diana Madalina Craciun wrote: > > On 08/11/2017 06:50 PM, Edgar E. Iglesias wrote: > > > On Fri, Aug 11, 2017 at 02:35:28PM +, Diana Madalina Craciun wrote: > > >> Hi Edgar, > > >> >

Re: [Qemu-devel] RFC: qemu RISC-V

2017-08-23 Thread Paolo Bonzini
On 23/08/2017 21:25, KONRAD Frederic wrote: > Hi all, > > I found somes slides about RISC-V at the KVM forum 2016. > > Seems the upstreaming process should have started in september 2016 but > I didn't see anything. > > Is that still planed? We're waiting from the privileged interface specifica

Re: [Qemu-devel] A use-after-free in slirp

2017-08-23 Thread Samuel Thibault
Hello, P J P, on jeu. 03 août 2017 17:45:06 +0530, wrote: > ==31922==ERROR: AddressSanitizer: heap-use-after-free on address > 0x6141ff8c at pc 0x56485de28ea0 bp 0x7f00f44fc950 sp 0x7f00f44fc940 > READ of size 4 at 0x6141ff8c thread T2 > #0 0x56485de28e9f in if_start slirp/if.c:230 >

Re: [Qemu-devel] Number of usable slots in PCIe Root Port / PCIe Switch Downstream Port

2017-08-23 Thread Marcel Apfelbaum
On 23/08/2017 19:46, Andrea Bolognani wrote: AFAIK some PCI controllers, particularly: * PCIe Root Port (pcie-root-port, ioh3420) * PCIe Switch Downstream Port (xio3130-downstream) only have a single usable slot. libvirt knows about this fact, and will prevent you from adding more than on

Re: [Qemu-devel] [PATCH v2] audio: intel-hda: do not use old_mmio accesses

2017-08-23 Thread Matt Parker
I've just noticed the suggested changes from the v1 patch regarding using MAKE_64BIT_MASK. This patch is can be ignored for now. On 23 August 2017 at 20:37, Matt Parker wrote: > intel-hda is currently using the old_mmio accessors for io. > This updates the device to use .read and .write accessors

Re: [Qemu-devel] [Qemu-block] [PATCH v5 08/13] tests: Rely more on global_qtest

2017-08-23 Thread Paolo Bonzini
On 23/08/2017 21:26, Eric Blake wrote: >> I agree with using the short form where possible, but I disagree on >> removing the long forms. Rather, global_qtest in my opinion should have >> been static (though I'm not proposing that you do this); inlining the >> wrappers is not needed for performanc

[Qemu-devel] [PATCH v2] audio: intel-hda: do not use old_mmio accesses

2017-08-23 Thread Matt Parker
intel-hda is currently using the old_mmio accessors for io. This updates the device to use .read and .write accessors instead. Signed-off-by: Matt Parker --- hw/audio/intel-hda.c | 57 +--- 1 file changed, 10 insertions(+), 47 deletions(-) diff --

Re: [Qemu-devel] [PATCH v2] qcow2: allocate cluster_cache/cluster_data on demand

2017-08-23 Thread Eric Blake
On 08/21/2017 08:55 AM, Stefan Hajnoczi wrote: > Most qcow2 files are uncompressed so it is wasteful to allocate (32 + 1) > * cluster_size + 512 bytes upfront. Allocate s->cluster_cache and > s->cluster_data when the first read operation is performance on a > compressed cluster. > > The buffers a

Re: [Qemu-devel] [PATCH] hw/misc/auxbus.c: Mark the aux-to-i2c-bridge device as non-hotpluggable

2017-08-23 Thread KONRAD Frederic
On 08/23/2017 07:22 AM, Thomas Huth wrote: On 22.08.2017 20:15, KONRAD Frederic wrote: Hi Thomas, Looking to this seems there is a second issue: The aux-to-i2c-bridge device should connect on a TYPE_AUX_BUS. I don't think there isn't any on integratorcp.. Anyway the patch you sent fix this

Re: [Qemu-devel] [Qemu-block] [PATCH v5 08/13] tests: Rely more on global_qtest

2017-08-23 Thread Eric Blake
On 08/19/2017 11:34 AM, Paolo Bonzini wrote: > On 18/08/2017 23:33, John Snow wrote: >>> Before the next few patches >>> get rid of the qtest_* layer, we first need to update the remaining >>> few spots that were using the long form where we can instead rely >>> on the short form. >>> >> Not a big

[Qemu-devel] RFC: qemu RISC-V

2017-08-23 Thread KONRAD Frederic
Hi all, I found somes slides about RISC-V at the KVM forum 2016. Seems the upstreaming process should have started in september 2016 but I didn't see anything. Is that still planed? Thanks, Fred

[Qemu-devel] [PATCH] multiboot: make tests work with clang

2017-08-23 Thread Anatol Pomozov
* explicitly disable SSE as clang enables it by default for 32bit code * add memset() implementation. Clang complains that the function is absent, gcc seems provides default built-in. --- tests/multiboot/Makefile | 2 +- tests/multiboot/libc.c | 9 + tests/multiboot/libc.h | 2 ++

Re: [Qemu-devel] [RFC PATCH] osdep.h: Prohibit disabling assert() in supported builds

2017-08-23 Thread Eric Blake
On 08/22/2017 06:19 AM, Halil Pasic wrote: > OTOH I do think this is to some degree institutionalizing a bad practice > (you say we do not want to do that, but IMHO refusing to build with > NDEBUG makes only sense if we want to alter the semantic of assert so > that once bad becomes acceptable). I

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-23 Thread ChristianEhrhardt
Yeah seems to be slightly different than the former assert. 2017-08-23 18:41:54.556+: initiating migration bdrv_inactivate_recurse: entry for drive-virtio-disk0 bdrv_inactivate_recurse: entry for #block133 bdrv_inactivate_recurse: entry for #block329 bdrv_inactivate_recurse: entry for #block20

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-23 Thread Dr. David Alan Gilbert
just tested current head - 1eed33994e28d4a0437ba6e944bbc3ec5e4a29a0 - seems to work for me. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1711602 Title: --copy-storage-all failing with qemu 2.10 S

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc3 is now available

2017-08-23 Thread Peter Maydell
On 22 August 2017 at 17:50, Michael Roth wrote: > Quoting Peter Maydell (2017-08-22 11:20:18) >> We've had a few late-breaking PPC host bugs that we need >> to fix, so we'll tag rc3 either today or more likely tomorrow >> and then have the final release next week. > > Ok, thanks for the heads up.

Re: [Qemu-devel] [PATCH 8/8] tcg/i386: Add vector operations

2017-08-23 Thread Richard Henderson
On 08/22/2017 06:15 AM, Alex Bennée wrote: >> +#ifndef have_avx2 >> +/* There are a number of things we must check before we can be >> + sure of not hitting invalid opcode. */ >> +if (c & bit_OSXSAVE) { >> +unsigned xcrl, xcrh; >> +asm ("xgetbv" :

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-23 Thread Dr. David Alan Gilbert
Looks good here, just retested: here's teh top of my git: f89f59fad5119f878aaedf711af90802ddcb99c7 nbd-client: avoid spurious qio_channel_yield() re-entry cf26039a2b50f078b4ad90b88eea5bb28971c0d8 block: Update open_flags after ->inactivate() callback 8ccc527d84ec9a5052cfae19edbc44abb5ac03ae mir

Re: [Qemu-devel] [PULL 0/6] NBD pull request for 2.10-rc4

2017-08-23 Thread Peter Maydell
On 23 August 2017 at 17:33, Eric Blake wrote: > The following changes since commit 3da2bd8c4a80178fb115c70b858cecbfb1eb1067: > > numa: Move numa_legacy_auto_assign_ram to pc-i440fx-2.9 (2017-08-23 > 13:53:15 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/ericb.gi

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-08-23 Thread Vladimir Sementsov-Ogievskiy
23.08.2017 21:04, Vladimir Sementsov-Ogievskiy wrote: 23.08.2017 11:59, Vladimir Sementsov-Ogievskiy wrote: 22.08.2017 22:07, John Snow wrote: Well, we knew we'd want this sooner or later. I've got some pings downstream over whether or not we support persistent bitmaps for non-qcow2 formats. C

Re: [Qemu-devel] [PATCH 3/3] multiboot: load elf sections and section headers

2017-08-23 Thread Anatol Pomozov
Hi On Wed, Aug 23, 2017 at 10:22 AM, Anatol Pomozov wrote: > Multiboot may load section headers and all sections (even those that are > not part of any segment) to target memory. > > Tested with an ELF application that uses data from strings table > section. > > Signed-off-by: Anatol Pomozov > -

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-23 Thread Dr. David Alan Gilbert
I need to recheck with that combo - I'd seen that error but only when I'd commented out 'if (!blk->dev && !blk_name(blk)[0]) {' when debugging earlier. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-08-23 Thread Vladimir Sementsov-Ogievskiy
23.08.2017 11:59, Vladimir Sementsov-Ogievskiy wrote: 22.08.2017 22:07, John Snow wrote: Well, we knew we'd want this sooner or later. I've got some pings downstream over whether or not we support persistent bitmaps for non-qcow2 formats. Currently: no, we don't. We tried two different ideas f

Re: [Qemu-devel] [RFC v2 8/8] migration: add incoming mgmt lock

2017-08-23 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Now at least migrate_incoming can be run in parallel. Let's provide a > migration lock to protect it. > > Signed-off-by: Peter Xu > --- > migration/migration.c | 6 ++ > migration/migration.h | 3 +++ > 2 files changed, 9 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH] hw/arm/allwinner-a10: Mark the allwinner-a10 device with user_creatable = false

2017-08-23 Thread Eduardo Habkost
On Wed, Aug 23, 2017 at 06:51:28PM +0100, Peter Maydell wrote: > On 23 August 2017 at 18:21, Eduardo Habkost wrote: > > On Tue, Aug 22, 2017 at 05:46:29PM +0200, Thomas Huth wrote: > >> QEMU currently exits unexpectedly when the user accidentially > >> tries to do something like this: > >> > >> $

Re: [Qemu-devel] [PATCH 18/27] vhost-user-scsi: rename VUS types

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/23/2017 01:19 PM, Marc-André Lureau wrote: - use Vus prefix consistently - use CamelCase, since that's glib & libvhost-user style - avoid _t postfix, usually for system headers Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- contrib/vhost-user-scsi/vhost-us

Re: [Qemu-devel] [PATCH for-2.11 06/27] x86: extract legacy cpu features format parser

2017-08-23 Thread Eduardo Habkost
On Wed, Aug 23, 2017 at 07:37:39PM +0200, Igor Mammedov wrote: > On Wed, 23 Aug 2017 13:46:38 -0300 > Eduardo Habkost wrote: > > > On Wed, Aug 23, 2017 at 06:29:02PM +0200, Igor Mammedov wrote: > > > On Wed, 23 Aug 2017 11:34:14 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Fri, Aug 18, 2

Re: [Qemu-devel] [PATCH 15/27] vhost-user-scsi: remove vdev_scsi_add_iscsi_lun()

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/23/2017 01:19 PM, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- contrib/vhost-user-scsi/vhost-user-scsi.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/contrib/vhost-user-scsi/vhost-user-scsi

Re: [Qemu-devel] [PATCH 14/27] vhost-user-scsi: assert() in iscsi_add_lun()

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/23/2017 01:19 PM, Marc-André Lureau wrote: Instead of a preliminary check, add an assert to the function that has the pre-condition. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-scsi/vhost-user-scsi.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/c

Re: [Qemu-devel] [PATCH 07/27] vhost-user-scsi: use glib allocation

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/23/2017 01:19 PM, Marc-André Lureau wrote: Use g_new/g_free instead of plain malloc. This simplify a bit memory handling since glib will abort if it cannot allocate. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-scsi/vhost-user-scsi.c | 35 --- 1 f

Re: [Qemu-devel] [PATCH] hw/arm/allwinner-a10: Mark the allwinner-a10 device with user_creatable = false

2017-08-23 Thread Peter Maydell
On 23 August 2017 at 18:21, Eduardo Habkost wrote: > On Tue, Aug 22, 2017 at 05:46:29PM +0200, Thomas Huth wrote: >> QEMU currently exits unexpectedly when the user accidentially >> tries to do something like this: >> >> $ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic >> QEMU 2

Re: [Qemu-devel] [PATCH 04/27] vhost-user-scsi: use g_strdup()

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/23/2017 01:19 PM, Marc-André Lureau wrote: Since vhost-user-scsi uses glib. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- contrib/vhost-user-scsi/vhost-user-scsi.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/contrib/v

Re: [Qemu-devel] [PATCH 12/27] vhost-user-scsi: use NULL pointer

2017-08-23 Thread Philippe Mathieu-Daudé
On Wed, Aug 23, 2017 at 1:19 PM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé > --- > contrib/vhost-user-scsi/vhost-user-scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c

Re: [Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

2017-08-23 Thread Igor Mammedov
On Wed, 23 Aug 2017 21:35:29 +0800 Dou Liyang wrote: > Hi Igor, > > At 08/23/2017 08:45 PM, Igor Mammedov wrote: > > On Wed, 23 Aug 2017 20:12:51 +0800 > > Dou Liyang wrote: > > > >> Hi Igor, > >> > >> At 08/23/2017 04:40 PM, Igor Mammedov wrote: > >>> On Tue, 22 Aug 2017 11:24:10 +0800 > >>> D

Re: [Qemu-devel] [RFC v2 5/8] hmp: support "without_bql"

2017-08-23 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Introducing new option "without_bql" for HMP commands. It works just > like QMP "without-bql", but for HMP commands. > > Signed-off-by: Peter Xu It's going to be interesting when we have hmp commands that just call their qmp equivalent that we need to che

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-08-23 Thread John Snow
On 08/23/2017 01:31 PM, Max Reitz wrote: > On 2017-08-22 21:07, John Snow wrote: > > [...] > >> (3) Add either a new flag that turns qcow2's backing file into a full >> R/W backing file, or add a new extension to qcow2 entirely (bypassing >> the traditional backing file mechanism to avoid confu

Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

2017-08-23 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Introducing this new parameter for QMP commands in general to mark out > when the command does not need BQL. Normally QMP command executions are > done with the protection of BQL in QEMU. However the truth is that not > all the QMP commands require the BQL.

Re: [Qemu-devel] [PATCH for-2.11 06/27] x86: extract legacy cpu features format parser

2017-08-23 Thread Igor Mammedov
On Wed, 23 Aug 2017 13:46:38 -0300 Eduardo Habkost wrote: > On Wed, Aug 23, 2017 at 06:29:02PM +0200, Igor Mammedov wrote: > > On Wed, 23 Aug 2017 11:34:14 -0300 > > Eduardo Habkost wrote: > > > > > On Fri, Aug 18, 2017 at 12:08:38PM +0200, Igor Mammedov wrote: > > > > Move cpu_model +-feat par

Re: [Qemu-devel] [PATCH 16/26] qapi: add conditions to VNC type/commands/events on the schema

2017-08-23 Thread Eduardo Habkost
On Wed, Aug 23, 2017 at 05:07:12PM +0200, Gerd Hoffmann wrote: > On Thu, 2017-08-17 at 10:56 +0200, Markus Armbruster wrote: > > Gerd, can we delete the vnc_init_func() stub?  Things still compile > > for > > me when I do. > > > > diff --git a/include/ui/console.h b/include/ui/console.h > > index

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

2017-08-23 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Firstly, introduce Monitor.use_thread, and set it for monitors that are > using non-mux typed backend chardev. We only do this for monitors, so > mux-typed chardevs are not suitable (when it connects to, e.g., serials > and the monitor together). > > When u

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-08-23 Thread Max Reitz
On 2017-08-22 21:07, John Snow wrote: [...] > (3) Add either a new flag that turns qcow2's backing file into a full > R/W backing file, or add a new extension to qcow2 entirely (bypassing > the traditional backing file mechanism to avoid confusion for older > tooling) that adds a new read-write b

Re: [Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

2017-08-23 Thread Eduardo Habkost
On Wed, Aug 23, 2017 at 09:35:29PM +0800, Dou Liyang wrote: > Hi Igor, > > At 08/23/2017 08:45 PM, Igor Mammedov wrote: > > On Wed, 23 Aug 2017 20:12:51 +0800 > > Dou Liyang wrote: > > > > > Hi Igor, > > > > > > At 08/23/2017 04:40 PM, Igor Mammedov wrote: > > > > On Tue, 22 Aug 2017 11:24:10 +

[Qemu-devel] [PATCH 1/3] multiboot: Change multiboot_info from array of bytes to a C struct

2017-08-23 Thread Anatol Pomozov
Using C structs makes the code more readable and prevents type conversion errors. Borrow multiboot1 header from GRUB project. Signed-off-by: Anatol Pomozov --- hw/i386/multiboot.c | 124 + hw/i386/multiboot_header.h | 254

[Qemu-devel] [PATCH 3/3] multiboot: load elf sections and section headers

2017-08-23 Thread Anatol Pomozov
Multiboot may load section headers and all sections (even those that are not part of any segment) to target memory. Tested with an ELF application that uses data from strings table section. Signed-off-by: Anatol Pomozov --- hw/core/loader.c | 8 ++-- hw/i386/multiboot.c |

  1   2   3   4   >