On Fri, 05/20 10:46, Jason Wang wrote:
>
>
> On 2016年05月13日 11:48, Jason Wang wrote:
> >
> >
> > On 2016年05月12日 16:16, Zhang Chen wrote:
> > >
> > >
> > > On 05/12/2016 04:01 PM, Jason Wang wrote:
> > > >
> > > >
> > > > On 2016年05月12日 14:49, Zhang Chen wrote:
> > > > >
> > > > >
> > > >
On Mi, 2016-05-18 at 12:40 -0400, Cole Robinson wrote:
> Give users a hint if their config is wrong.
>
> Signed-off-by: Cole Robinson
> ---
> If virgl support is built into qemu, virgl=on is the default, so this
> could be noisy in cases where people don't even care about virgl. So
> I won't obje
On Do, 2016-05-19 at 12:25 +0200, marcandre.lur...@redhat.com wrote:
> Here is a small series improving a bit the scanout limit handling. The
> first patch was sent previously but is also included in this series
> for convenience.
Doesn't apply cleanly to master, does this depend on unmerged patch
> From: Dong Jia [mailto:bjsdj...@linux.vnet.ibm.com]
> Sent: Thursday, May 19, 2016 3:28 PM
>
> On Fri, 13 May 2016 02:05:01 -0700
> Neo Jia wrote:
>
> ...snip...
>
> >
> > Hi Dong,
> >
> > We should definitely be mindful about the data structure performance
> > especially
> > dealing with ke
On 2016年05月13日 11:48, Jason Wang wrote:
On 2016年05月12日 16:16, Zhang Chen wrote:
On 05/12/2016 04:01 PM, Jason Wang wrote:
On 2016年05月12日 14:49, Zhang Chen wrote:
On 05/09/2016 06:49 PM, Zhang Chen wrote:
+
+s->chr_sec_in = qemu_chr_find(s->sec_indev);
+if (s->chr_sec_in ==
在 2016年05月19日 21:45, mich...@walle.cc 写道:
Am 2016-05-19 13:32, schrieb Paolo Bonzini:
Michael, can you test patches 3 and 4?
Doesn't work for me:
$ qemu-system-lm32 -kernel serial.bin -serial vc -serial vc
Unexpected error in parse_chr() at
/home/mwalle/repos/qemu/hw/core/qdev-properties-
On 2016年05月20日 02:14, Jean-Christophe DUBOIS wrote:
Le 19/05/2016 05:48, Jason Wang a écrit :
On 2016年05月19日 06:23, Jean-Christophe Dubois wrote:
The ENET device (present in i.MX6) is "derived" from FEC and backward
compatible with it.
This patch adds the necessary support of the added fea
Public bug reported:
When connecting with websocket and tls to a vnc-ws port I get segfault
==15252== Process terminating with default action of signal 11 (SIGSEGV):
dumping core
==15252== Access not within mapped region at address 0x0
==15252==at 0x1: ???
==15252==by 0x56E1E2: qio_task
On 2016年05月19日 14:10, Jean-Christophe DUBOIS wrote:
Le 19/05/2016 05:28, Jason Wang a écrit :
On 2016年05月19日 06:23, Jean-Christophe Dubois wrote:
This is to prepare for the ENET Gb device of the i.MX6.
Signed-off-by: Jean-Christophe Dubois
---
Changes since v1:
* Not present on v1.
Ch
Oh, I should post my hardware:
i7-5820K (also) (4/6 cores (8/12 threads) being passed to VMs)
12GB RAM (also) (8GB being passed to VMs)
MSI X99 SLI Plus (though I don't use SLI)
NVidia GTX 960 2GB pass-thru (also had this problem on a GTX 660 before that
died)
GT 740 host card, using nouveau when
On 05/17/2016 02:20 AM, Denis V. Lunev wrote:
> Pls note, trace_init_backends() must be called in the final process, i.e.
s/Pls/Please/
> after daemonization. This is necessary to keep tracing thread in the
> proper process.
>
> Signed-off-by: Denis V. Lunev
> CC: Paolo Bonzini
> CC: Stefan Ha
On 05/17/2016 02:20 AM, Denis V. Lunev wrote:
> Moving trace_init_backends() into trace_opt_parse() is not possible. This
> should be called after daemonize() in vl.c.
>
> Signed-off-by: Denis V. Lunev
> CC: Paolo Bonzini
> CC: Stefan Hajnoczi
> CC: Kevin Wolf
> ---
> qemu-io.c | 13 +
On 05/17/2016 02:20 AM, Denis V. Lunev wrote:
> The patch also creates trace_opt_parse() helper in trace/control.c to reuse
> this code in next patches for qemu-nbd and qemu-io.
>
> The patch also makes trace_init_events() static, as this call is not used
> outside the module anymore.
>
> Signed-
I was thrown by the fact that the public type BlockRequest had
an anonymous union, but no obvious discriminator. Turns out
that the only client of the second branch of the union was code
internal to io.c, now that commit 91c6e4b killed public
multiwrite, so move it into io.c and improve the commen
thank you very much serge=)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1583775
Title:
Feature Request: qemu 2.6.0
Status in QEMU:
New
Bug description:
Qemu 2.6.0 just got released, and acc
From: "Edgar E. Iglesias"
The way we currently model the RPU subsystem is of quite
limited use. In addition to that, it causes problems for
KVM and for GDB debugging.
Make the RPU optional by adding a has_rpu property and
default to having it disabled.
Signed-off-by: Edgar E. Iglesias
---
hw/
From: "Edgar E. Iglesias"
Delay the realization of the GIC until after CPUs are
realized. This is needed for KVM as the in-kernel GIC
model will fail if it is realized with no available CPUs.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xlnx-zynqmp.c | 56 +--
From: "Edgar E. Iglesias"
Break out RPU setup into a separate function. This is in
preparation for making the RPU optional.
No functional change.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xlnx-zynqmp.c | 53 ++--
1 file changed, 31 insertions(
From: "Edgar E. Iglesias"
Break out RPU setup into a separate function. This is in
preparation for making the RPU optional.
No functional change.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xlnx-zynqmp.c | 53 ++--
1 file changed, 31 insertions(
From: "Edgar E. Iglesias"
(This is a resend of the same v1, I managed to typo my own work email
address in CC in the first send-email :-))
This series fixes a bunch of issues with KVM runs using the ZynqMP
machine.
When using KVM, we don't have support for TrustZone, the RPU subsystem
with Cort
From: "Edgar E. Iglesias"
Use the in kernel GIC model when running with KVM enabled.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xlnx-zynqmp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
index 0648028..c3878da 100644
--- a/
From: "Edgar E. Iglesias"
Add a secure prop to en/disable ARM Security Extensions.
This is particulary useful for KVM runs.
Default to disabled to match the behavior of KVM.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xlnx-zynqmp.c | 3 +++
include/hw/arm/xlnx-zynqmp.h | 3 +++
2 file
From: "Edgar E. Iglesias"
Use the in kernel GIC model when running with KVM enabled.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xlnx-zynqmp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
index 0648028..c3878da 100644
--- a/
From: "Edgar E. Iglesias"
The way we currently model the RPU subsystem is of quite
limited use. In addition to that, it causes problems for
KVM and for GDB debugging.
Make the RPU optional by adding a has_rpu property and
default to having it disabled.
Signed-off-by: Edgar E. Iglesias
---
hw/
From: "Edgar E. Iglesias"
This series fixes a bunch of issues with KVM runs using the ZynqMP
machine.
When using KVM, we don't have support for TrustZone, the RPU subsystem
with Cortex R5s and we also need to use the in-kernel GIC model.
This adds a set of properties to the ZynqMP allowing the
From: "Edgar E. Iglesias"
Delay the realization of the GIC until after CPUs are
realized. This is needed for KVM as the in-kernel GIC
model will fail if it is realized with no available CPUs.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xlnx-zynqmp.c | 56 +--
From: "Edgar E. Iglesias"
Add a secure prop to en/disable ARM Security Extensions.
This is particulary useful for KVM runs.
Default to disabled to match the behavior of KVM.
Signed-off-by: Edgar E. Iglesias
---
hw/arm/xlnx-zynqmp.c | 3 +++
include/hw/arm/xlnx-zynqmp.h | 3 +++
2 file
Now that the common functions are in place, we can call it
instead of duplicating code.
Signed-off-by: Bandan Das
---
cpus.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/cpus.c b/cpus.c
index eb34b4f..ead4e3f 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1693,21 +1
If caller has errp, set it appropriately in case of
an error and pass it along.
Signed-off-by: Bandan Das
---
hw/core/nmi.c | 4 ++--
hw/watchdog/watchdog.c | 2 +-
include/hw/nmi.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/core/nmi.c b/hw/core/nmi.
nmi_monitor_handle is wired to call the x86 nmi
handler now. So, we can call it here. Note that
this also reverts changes made by commit 33c11879
Signed-off-by: Bandan Das
---
hw/core/nmi.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/hw/core/nmi.c b/hw/core/nmi.c
inde
Instead of having x86 ifdefs in core nmi code, this
change adds a arch specific handler that the nmi common
code can call.
Signed-off-by: Bandan Das
---
hw/i386/pc.c | 20
1 file changed, 20 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 99437e0..e29ccc8 10064
The primary change is a arch specific x86 nmi function
which can be called by the core nmi handler.
Bandan Das (4):
target-i386: add a generic x86 nmi handler
nmi: remove x86 specific nmi handling
nmi: add errp function parameter to inject_nmi()
cpus: call the core nmi injection function
On 05/20/2016 12:25 AM, Stefan Hajnoczi wrote:
On Sat, May 14, 2016 at 03:45:49PM +0300, Denis V. Lunev wrote:
diff --git a/block/io.c b/block/io.c
index cd6d71a..88af10c 100644
--- a/block/io.c
+++ b/block/io.c
@@ -1828,8 +1828,8 @@ int bdrv_is_allocated_above(BlockDriverState *top,
retur
On Sat, May 14, 2016 at 03:45:49PM +0300, Denis V. Lunev wrote:
> diff --git a/block/io.c b/block/io.c
> index cd6d71a..88af10c 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -1828,8 +1828,8 @@ int bdrv_is_allocated_above(BlockDriverState *top,
> return 0;
> }
>
> -int bdrv_write_compres
I'm testing a merge of it right now.
On Thu, May 19, 2016 at 9:13 PM, Launchpad Bug Tracker
<1583...@bugs.launchpad.net> wrote:
> You have been subscribed to a public bug:
>
> Qemu 2.6.0 just got released, and according to changelogs it has quite
> some enhancements...
>
> would it be possible to
** Project changed: inkscape => qemu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1583775
Title:
Feature Request: qemu 2.6.0
Status in QEMU:
New
Bug description:
Qemu 2.6.0 just got released
You have been subscribed to a public bug:
Qemu 2.6.0 just got released, and according to changelogs it has quite
some enhancements...
would it be possible to have someone who has a qemu ppa on launchpad to
migrate this into his ppa?
thanks in advance
** Affects: qemu
Importance: Undecided
On Thu, May 19, 2016 at 02:48:01PM +0200, Peter Lieven wrote:
> this adds support for the upcoming libnfs cachepage to Qemu.
> While at it neglect to use readahead if cache.direct is on.
>
> v1->v2: - move the readahead fix to Patch 1 and CC qemu-stable
> - check for changed cache settings
On Thu, May 19, 2016 at 02:48:01PM +0200, Peter Lieven wrote:
> this adds support for the upcoming libnfs cachepage to Qemu.
> While at it neglect to use readahead if cache.direct is on.
>
> v1->v2: - move the readahead fix to Patch 1 and CC qemu-stable
> - check for changed cache settings
On Wed, May 18, 2016 at 04:24:07PM +0800, Fam Zheng wrote:
> We are ready to get rid of dataplane's op blockers altogether. Most operations
> are already unblocked in virtio-blk, and those remained for virtio-scsi only
> because we haven't got around to add counterpart unblocking code.
>
> The fir
On Wed, May 18, 2016 at 04:24:08PM +0800, Fam Zheng wrote:
> If the BDS is attached, it will want to stay on the AioContext where its
> BlockBackend is. Don't call bdrv_set_aio_context in this case.
What should the user do when they hit this error?
> Signed-off-by: Fam Zheng
> ---
> blockdev.c
On Wed, May 18, 2016 at 04:24:07PM +0800, Fam Zheng wrote:
> We are ready to get rid of dataplane's op blockers altogether. Most operations
> are already unblocked in virtio-blk, and those remained for virtio-scsi only
> because we haven't got around to add counterpart unblocking code.
>
> The fir
On 05/19/2016 12:04 PM, Igor Mammedov wrote:
On Wed, 18 May 2016 17:22:43 +0300
Marcel Apfelbaum wrote:
On 05/18/2016 04:53 PM, Igor Mammedov wrote:
On Sun, 15 May 2016 22:23:30 +0300
Marcel Apfelbaum wrote:
Hi,
First two patches allocate (max_reserved_ram - max_addr_cpu_addressable) rang
On 05/19/2016 10:52 AM, Eric Blake wrote:
> Let the caller decide whether output must be strict JSON (and
> raise an error on an attempt to output an encoding error or
> non-finite number), vs. the status quo of relaxed (encoding
> errors are rewritten to use substitute U+fffd characters,
> and non
** Also affects: fedora
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1580459
Title:
Windows (10?) guest freezes entire host on shutdown if using PCI
p
I am seeing this issue on arch also. I also tried Fedora24 to see if it
was a Arch only issue.
If I start a VM and stop it shortly after everything works fine.
If I start a VM and game for a while, on VM shutdown the host will
totally lock. Tailing the journal to see if anything gets logged sho
On 19/05/2016 19:54, Peter Maydell wrote:
> ...there seem to be some travis build failures:
> https://travis-ci.org/qemu/qemu/builds/131457562
>
> TCI seems to be broken
Missing cpu.h includes (though for disas/tci.c, hopefully one can stop
including exec/exec-all.h instead).
> as is hw/time
On 19 May 2016 at 19:14, Jean-Christophe DUBOIS wrote:
> Le 19/05/2016 05:48, Jason Wang a écrit :
>> On 2016年05月19日 06:23, Jean-Christophe Dubois wrote:
>>
>> It's ok to decide with "is-fec", but is it better to use a new type for
>> that?
>
>
> Well, there is a lot of common code between FEC and
Le 19/05/2016 05:48, Jason Wang a écrit :
On 2016年05月19日 06:23, Jean-Christophe Dubois wrote:
The ENET device (present in i.MX6) is "derived" from FEC and backward
compatible with it.
This patch adds the necessary support of the added feature in the ENET
device to allow Linux to use it (on su
On 19 May 2016 at 16:53, Peter Maydell wrote:
> On 19 May 2016 at 15:43, Paolo Bonzini wrote:
>> The following changes since commit 8ec4fe0a4bed4fa27e6f28a746bcf77b27cd05a3:
>>
>> Merge remote-tracking branch
>> 'remotes/mjt/tags/pull-trivial-patches-2016-05-18' into staging (2016-05-19
>> 09
John Snow writes:
> On 05/18/2016 01:36 AM, Markus Armbruster wrote:
>> Fam Zheng writes:
>>
>>> On Tue, 05/17 20:42, John Snow wrote:
If you use HMP's eject but the CDROM tray is locked, you may get a
confusing error message informing you that the "tray isn't open."
As this
Meant to inquire about the next batch, but of course you beat me to the
punch :)
I'll be on vacation next week, so review will be delayed.
Let the caller decide whether output must be strict JSON (and
raise an error on an attempt to output an encoding error or
non-finite number), vs. the status quo of relaxed (encoding
errors are rewritten to use substitute U+fffd characters,
and non-finite numbers are output).
Adjust the testsuite t
On 19 May 2016 at 16:21, Kevin Wolf wrote:
> The following changes since commit 8ec4fe0a4bed4fa27e6f28a746bcf77b27cd05a3:
>
> Merge remote-tracking branch
> 'remotes/mjt/tags/pull-trivial-patches-2016-05-18' into staging (2016-05-19
> 09:27:28 +0100)
>
> are available in the git repository at:
On 19 May 2016 at 15:43, Paolo Bonzini wrote:
> The following changes since commit 8ec4fe0a4bed4fa27e6f28a746bcf77b27cd05a3:
>
> Merge remote-tracking branch
> 'remotes/mjt/tags/pull-trivial-patches-2016-05-18' into staging (2016-05-19
> 09:27:28 +0100)
>
> are available in the git repository
This update just fixes some style issues found by checkpatch.pl,
which I should have checked to see if it existed, but Markus
introduced me to.
-corey
From: Corey Minyard
Add an IPMI table entry to the SMBIOS.
Signed-off-by: Corey Minyard
Acked-by: Michael S. Tsirkin
---
hw/smbios/Makefile.objs | 2 +
hw/smbios/ipmi.c | 114 +++
hw/smbios/noipmi.c | 14 ++
hw/smbios/smbios.c
From: Eric Blake
Commit 770e0e0e [*] tried to add 'writev -f', but didn't tweak
the getopt() call to actually let it work. Likewise, commit
c2e001c missed implementing 'aio_write -u -z'. The latter commit
also introduced a leak of ctx.
[*] does it sound "ech0e" in here? :)
Signed-off-by: Eric
From: Corey Minyard
This will let things in other files (like IPMI) build SMBIOS tables.
Signed-off-by: Corey Minyard
---
hw/smbios/smbios.c | 70 ---
hw/smbios/smbios_build.h | 77
2 files changed,
From: Eric Blake
For some time now, qemu-img compare has been able to compare
unaligned images. So we no longer need test 109's hack of
resizing to sector boundaries before invoking compare.
Signed-off-by: Eric Blake
Reviewed-by: Max Reitz
Message-id: 1463416983-28318-3-git-send-email-ebl...@
This covers some more write_zeroes cases which are relevant for the
recent qcow2 optimisations that check the allocation status of the
backing file for partial cluster write_zeroes requests.
This needs to be separate from 034 because we can only support qcow2 in
this test case for multiple reasons
This patch removes the remaining users of bs->blk, which will allow us
to have multiple BBs on top of a single BDS. In the meantime, all checks
that are currently in place to prevent the user from creating such
setups can be switched to bdrv_has_blk() instead of accessing BDS.blk.
Future patches c
From: Corey Minyard
Use the new ACPI table construction tools to create an ACPI
entry for IPMI. This adds a function called from build_dsdt
to add an DSDT entry for IPMI if IPMI is compiled in and has
registered firmware. It also adds a dummy function if IPMI
is not compiled in.
This conforms
In many cases we just want to know whether a BDS has at least one BB
attached, without needing to know the exact BB that is attached. In
contrast to bs->blk, this is still a valid question when more than one
BB can be attached, so just answer it by checking the parents list.
Signed-off-by: Kevin W
We need to introduce a separate BdrvNextIterator struct that can keep
more state than just the current BDS in order to avoid using the bs->blk
pointer.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
block.c| 40 +++
block/block-backend.c
From: Corey Minyard
Instead of scanning IPMI devices from a fwinfo list, allow
the fwinfo to be fetched from the IPMI interface class.
Then the code looking for IPMI fwinfo can scan devices on a
bus and look for ones that implement the IPMI class.
This will let the ACPI scope be defined by the c
In order to correctly check whether a given cluster is read as zero, we
don't only need to check whether bdrv_get_block_status_above() sets
BDRV_BLOCK_ZERO, but also if all sectors for the whole cluster have the
same status.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Denis V.
From: "Denis V. Lunev"
We should check for (res & BDRV_BLOCK_ZERO) only. The situation when we
will have !(res & BDRV_BLOCK_DATA) and will not have BDRV_BLOCK_ZERO is
not possible for images with bdi.unallocated_blocks_are_zero == true.
For those images where it's false, however, it can happen a
From: Eric Blake
Commit 093ea232 removed the ability for aio_read and aio_write
to artificially inflate the invalid statistics counters for
block devices, since it no longer flags unaligned offset or
length. Add 'aio_read -i' and 'aio_write -i' to restore
the ability, and update test 136 to use
From: John Snow
If you use HMP's eject but the CDROM tray is locked, you may get a
confusing error message informing you that the "tray isn't open."
As this is the point of eject, we can do a little better and help
clarify that the tray was locked and that it (might) open up later,
so try again.
query-named-block-nodes should not return information that is related
to the attached BlockBackend rather than the node itself, so throttling
information needs to be removed from it.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
block/qapi.c | 6 +++---
tests/qemu-iotests/096 |
From: Corey Minyard
This is the same place that the ACPI SSDT table gets added, so that
devices can add themselves to the SMBIOS table.
Signed-off-by: Corey Minyard
---
hw/i386/pc.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
inde
From: Max Reitz
Instead of propagating any change of a BDS's AioContext only to its file
and backing children and letting driver-specific code do the rest, just
propagate it to all and drop the thus superfluous implementations of
bdrv_{at,de}tach_aio_context() in Quorum, blkverify and VMDK.
Sign
When block job errors were introduced, we assigned the iostatus of the
target BDS "just in case". The field has never been accessible for the
user because the target isn't listed in query-block.
Before we can allow the user to have a second BlockBackend on the
target, we need to clean this up. If
bdrv_move_feature_fields() and swap_feature_fields() are empty now, they
can be removed.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
Acked-by: Stefan Hajnoczi
---
block.c | 30 --
1 file changed, 30 deletions(-)
diff --git a/block.
Since virtio-blk implements request merging itself these days, the only
remaining users are test cases for the function. That doesn't make the
function exactly useful any more.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
---
block/block-backend.c | 14 ---
We want to get rid of BlockDriverState.blk in order to allow multiple
BlockBackends per BDS. Converting the device callbacks in block.c (which
assume a single BlockBackend) to per-child callbacks gets us rid of the
first few instances.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
block.
Block jobs don't actually make use of the iostatus for their BDSes, but
they manage a separate block job iostatus. Still, they require that it
is enabled for the source BDS and they enable it automatically for the
target and set the error handling mode - which ends up never being used
by the job.
So far, bdrv_parent_drained_begin/end() was called for the duration of
the actual bdrv_drain() at the beginning of a drained section, but we
really should keep parents quiesced until the end of the drained
section.
This does not actually change behaviour at this point because the only
user of the
In order to get rid of bs->blk for bdrv_get_device_name() and
bdrv_get_device_or_node_name(), ask all parents for their name and
simply pick the first one.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
block.c | 22 --
block/block-backend.c | 6
This reverts commit 76b223200ef4fb09dd87f0e213159795eb68e7a5.
Now that I/O throttling is fully done on the BlockBackend level, there
is no reason any more to block I/O throttling for nodes with multiple
parents as the parents don't influence each other any more.
Conflicts:
block.c
Signed
Checking whether there are throttled requests requires going to the
associated BlockBackend, which we want to avoid.
All users of bdrv_requests_pending() in block/io.c already call
bdrv_parent_drained_begin() first, which restarts all throttled
requests, so no throttled requests can be left here a
As a first step towards moving I/O throttling to the BlockBackend level,
this patch changes all pointers in struct ThrottleGroup from referencing
a BlockDriverState to referencing a BlockBackend.
This change is valid because we made sure that throttling can only be
enabled on BDSes which have a BB
Signed-off-by: Kevin Wolf
Reviewed-by: Alberto Garcia
Acked-by: Stefan Hajnoczi
---
block.c | 2 +-
block/block-backend.c | 43 +++--
block/io.c | 41 ---
block/qapi.c
Some features, like I/O throttling, are implemented outside
block-backend.c, but still want to keep information in BlockBackend,
e.g. list entries that allow keeping a list of BlockBackends.
In order to avoid exposing the whole struct layout in the public header
file, this patch introduces an embe
This patch changes where the throttling state is stored (used to be the
BlockDriverState, now it is the BlockBackend), but it doesn't actually
make it a BB level feature yet. For example, throttling is still
disabled when the BDS is detached from the BB.
Signed-off-by: Kevin Wolf
Acked-by: Stefan
BlockBackends use it to get a back pointer from BdrvChild to
BlockBackend in any BdrvChildRole callbacks.
Signed-off-by: Kevin Wolf
Reviewed-by: Alberto Garcia
Acked-by: Stefan Hajnoczi
---
block/block-backend.c | 2 ++
include/block/block_int.h | 1 +
2 files changed, 3 insertions(+)
dif
Signed-off-by: Kevin Wolf
Reviewed-by: Alberto Garcia
Acked-by: Stefan Hajnoczi
---
block/block-backend.c | 10 ++
block/io.c | 10 --
block/throttle-groups.c | 5 ++---
include/block/throttle-groups.h | 2 +-
4 files changed, 13 insertio
This moves the throttling related part of the BDS life cycle management
to BlockBackend. The throttling group reference is now kept even when no
medium is inserted.
With this commit, throttling isn't disabled and then re-enabled any more
during graph reconfiguration. This fixes the temporary break
It was already true in principle that a throttled BDS always has a BB
attached, except that the order of operations while attaching or
detaching a BDS to/from a BB wasn't careful enough.
This commit breaks graph manipulations while I/O throttling is enabled.
It would have been possible to keep thi
The following changes since commit 8ec4fe0a4bed4fa27e6f28a746bcf77b27cd05a3:
Merge remote-tracking branch
'remotes/mjt/tags/pull-trivial-patches-2016-05-18' into staging (2016-05-19
09:27:28 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
Signed-off-by: Kevin Wolf
Reviewed-by: Alberto Garcia
Acked-by: Stefan Hajnoczi
---
block/block-backend.c | 2 +-
block/io.c | 2 +-
block/qapi.c| 2 +-
block/throttle-groups.c | 12 ++--
include/block/throttle-groups.h | 2
This removes the last part of I/O throttling from block/io.c and moves
it to the BlockBackend.
Instead of having knowledge about throttling inside io.c, we can call a
BdrvChild callback .drained_begin/end, which happens to drain the
throttled requests for BlockBackend parents.
Signed-off-by: Kevi
Hi
On Wed, May 18, 2016 at 6:40 PM, Cole Robinson wrote:
> Give users a hint if their config is wrong.
>
> Signed-off-by: Cole Robinson
> ---
> If virgl support is built into qemu, virgl=on is the default, so this
> could be noisy in cases where people don't even care about virgl. So
> I won't o
Hi
On Wed, May 18, 2016 at 6:40 PM, Cole Robinson wrote:
> The user explicitly requested spice GL, so if we know it isn't
> going to work we should exit
>
> Signed-off-by: Cole Robinson
> ---
> For example, trying to use spice GL with libvirt qemu:///system will
> fail here, since the the VM wil
Hi
On Wed, May 18, 2016 at 6:40 PM, Cole Robinson wrote:
> Signed-off-by: Cole Robinson
> ---
> ui/egl-helpers.c | 27 ++-
> 1 file changed, 14 insertions(+), 13 deletions(-)
>
> diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c
> index 558edfd..6555f5f 100644
> --- a/ui/
From: Vadim Rozenfeld
Signed-off-by: Vadim Rozenfeld
Signed-off-by: Paolo Bonzini
---
block/iscsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index 10f3906..2ca8e72 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -761,6 +761,7 @@ iscsi_aio_ioctl_cb(str
On 19/05/2016 17:11, Eric Blake wrote:
>> > @@ -339,14 +354,16 @@ static void scsi_do_read(SCSIDiskReq *r, int ret)
>> > if (r->req.sg) {
>> > dma_acct_start(s->qdev.conf.blk, &r->acct, r->req.sg,
>> > BLOCK_ACCT_READ);
>> > r->req.resid -= r->req.sg->size;
>> > -r
On 05/11/2016 05:41 AM, Paolo Bonzini wrote:
> These are replacements for blk_aio_readv and blk_aio_writev that allow
> customization of the data path. They reuse the DMA helpers' DMAIOFunc
> callback type, so that the same function can be used in either the
> QEMUSGList or the bounce-buffered cas
On 05/18/2016 10:40 PM, Eric Blake wrote:
> Hard prerequisites (for all patches to apply):
> Markus' qjson movement:
> https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg00471.html
>
> Soft prerequisites (for valgrind to be happy with all touched tests):
> My fix for memleak in range.h:
> ht
1 - 100 of 215 matches
Mail list logo
