On 05/17/2016 02:20 AM, Denis V. Lunev wrote:
> The patch also creates trace_opt_parse() helper in trace/control.c to reuse
> this code in next patches for qemu-nbd and qemu-io.
>
> The patch also makes trace_init_events() static, as this call is not used
> outside the module anymore.
>
> Signed-off-by: Denis V. Lunev <d...@openvz.org>
> CC: Paolo Bonzini <pbonz...@redhat.com>
> CC: Stefan Hajnoczi <stefa...@redhat.com>
> CC: Kevin Wolf <kw...@redhat.com>
> ---
> trace/control.c | 44 +++++++++++++++++++++++++++++++++++++++++++-
> trace/control.h | 24 +++++++++++++-----------
> vl.c | 37 +------------------------------------
> 3 files changed, 57 insertions(+), 48 deletions(-)
>
>
> +QemuOptsList qemu_trace_opts = {
> + .name = "trace",
> + .implied_opt_name = "enable",
> + .head = QTAILQ_HEAD_INITIALIZER(qemu_trace_opts.head),
> + .desc = {
> + {
> + .name = "enable",
> + .type = QEMU_OPT_STRING,
> + },
> + {
> + .name = "events",
> + .type = QEMU_OPT_STRING,
> + },{
I know this is straight code motion, but we aren't very consistent on
spacing between elements. Might be worth the extra newline here while
touching it?
> + .name = "file",
> + .type = QEMU_OPT_STRING,
> + },
> + { /* end of list */ }
> + },
> +};
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
