Hi
On Wed, May 18, 2016 at 6:40 PM, Cole Robinson <crobi...@redhat.com> wrote:
> The user explicitly requested spice GL, so if we know it isn't
> going to work we should exit
>
> Signed-off-by: Cole Robinson <crobi...@redhat.com>
> ---
> For example, trying to use spice GL with libvirt qemu:///system will
> fail here, since the the VM will lack permissions to access
> /dev/dir/renderD*
>
> ui/spice-core.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 61db3c1..da05054 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -833,9 +833,11 @@ void qemu_spice_init(void)
> "incompatible with -spice port/tls-port");
> exit(1);
> }
> - if (egl_rendernode_init() == 0) {
> - display_opengl = 1;
> + if (egl_rendernode_init() != 0) {
> + error_report("Failed to initialize EGL render node for SPICE
> GL");
> + exit(1);
> }
> + display_opengl = 1;
> }
> #endif
> }
> --
> 2.7.4
>
>
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
--
Marc-André Lureau
