Re: [Qemu-devel] [PATCH for-2.6?] qemu-iotests: iotests: fail hard if not run via "check"

2016-04-19 Thread Markus Armbruster
Max Reitz writes: > On 19.04.2016 14:22, Sascha Silbe wrote: >> Dear Max, >> >> Max Reitz writes: >> >>> On 14.04.2016 13:32, Sascha Silbe wrote: >> [tests/qemu-iotests/iotests.py] >> [...] def main(supported_fmts=[], supported_oses=['linux']): '''Run tests''' +

Re: [Qemu-devel] [PATCH for-2.6 1/2] block/mirror: Revive dead yielding code

2016-04-19 Thread Fam Zheng
On Wed, 04/20 00:59, Max Reitz wrote: > mirror_iteration() is supposed to wait if the current chunk is subject > to a still in-flight mirroring operation. However, it mixed checking > this conflict situation with checking the dirty status of a chunk. A > simplification for the latter condition (the

Re: [Qemu-devel] [PATCH 0/5] migration: ensure hotplug and migration work together

2016-04-19 Thread David Gibson
On Fri, Apr 15, 2016 at 01:33:00PM -0700, Jianjun Duan wrote: > To make guest device (PCI, CPU and memory) hotplug work together > with guest migration, spapr drc state needs be transmitted in > migration. This patch defines the VMStateDescription struct for > spapr drc state to enable it. > > To

Re: [Qemu-devel] [PATCH for-2.6 v2 0/3] Bug fixes for gluster

2016-04-19 Thread Raghavendra Gowdappa
- Original Message - > From: "Jeff Cody" > To: "Ric Wheeler" > Cc: qemu-bl...@nongnu.org, qemu-devel@nongnu.org, kw...@redhat.com, > pkara...@redhat.com, rgowd...@redhat.com, > nde...@redhat.com, "Rik van Riel" > Sent: Tuesday, April 19, 2016 7:39:17 PM > Subject: Re: [PATCH for-2.6 v

Re: [Qemu-devel] [PATCH 4/5] Migration: migrate ccs_list in spapr state

2016-04-19 Thread David Gibson
On Fri, Apr 15, 2016 at 01:33:04PM -0700, Jianjun Duan wrote: > ccs_list in spapr state maintains the device tree related > information on the rtas side for hotplugged devices. In racing > situations between hotplug events and migration operation, a rtas > hotplug event could be migrated from the s

Re: [Qemu-devel] [PATCH 1/5] spapr: ensure device trees are always associated with DRC

2016-04-19 Thread David Gibson
On Fri, Apr 15, 2016 at 01:33:01PM -0700, Jianjun Duan wrote: > There are possible racing situations involving hotplug events and > guest migration. For cases where a hotplug event is migrated, or > the guest is in the process of fetching device tree at the time of > migration, we need to ensure th

Re: [Qemu-devel] [PATCH 2/5] Migration: Defined VMStateDescription struct for spapr_drc

2016-04-19 Thread David Gibson
On Fri, Apr 15, 2016 at 01:33:02PM -0700, Jianjun Duan wrote: > To manage hotplug/unplug of dynamic resources such as PCI cards, > memory, and CPU on sPAPR guests, a firmware abstraction known as > a Dynamic Resource Connector (DRC) is used to assign a particular > dynamic resource to the guest, an

Re: [Qemu-devel] Move autoconverge out of experimental?

2016-04-19 Thread Amit Shah
On (Tue) 19 Apr 2016 [09:28:34], Jason J. Herne wrote: > On 04/19/2016 02:39 AM, Amit Shah wrote: > >Hi Jason, > > > >We've had the new autoconverge features enabled for a full release > >now, what are your thoughts on dropping the x- ? > > > >Some factors I consider are direct user feedback, chang

[Qemu-devel] [PATCH 1/3] memory: drop find_ram_block()

2016-04-19 Thread Gonglei
On the one hand, we have already qemu_get_ram_block() whose function is similar. On the other hand, we can directly use mr->ram_block but searching RAMblock by ram_addr which is a kind of waste. Signed-off-by: Gonglei --- exec.c| 37 + incl

[Qemu-devel] [PATCH 3/3] memory: pass RAMBlock as a agrument

2016-04-19 Thread Gonglei
In this way, we can avoid to invoke qemu_get_ram_block() at most time, which can save cpu cycle. Signed-off-by: Gonglei --- exec.c | 48 ++-- hw/misc/ivshmem.c | 6 -- hw/virtio/vhost-user.c | 11 ++- include/exec/r

[Qemu-devel] [PATCH 2/3] exec: adjuest rcu_read_lock requiement

2016-04-19 Thread Gonglei
qemu_ram_unset_idstr() don't need rcu lock anymore, meanwhile adjuest the range of rcu lock in qemu_ram_set_idstr() as small as possible. Signed-off-by: Gonglei --- exec.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/exec.c b/exec.c index 101f0f4..b0ecbcd 100644 --- a

[Qemu-devel] [PATCH 0/3] memory: some little optimzation

2016-04-19 Thread Gonglei
Please see the details in each patch. Gonglei (3): memory: drop find_ram_block() exec: adjuest rcu_read_lock requiement memory: pass RAMBlock as a agrument exec.c| 89 +-- hw/misc/ivshmem.c | 6 ++-- hw/virtio/vhost-u

Re: [Qemu-devel] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-04-19 Thread Changlong Xie
ping... On 04/13/2016 04:33 PM, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 8 +++--- block/quorum.c| 78

Re: [Qemu-devel] [PATCH v4 0/1] Introduce "xen-load-devices-state"

2016-04-19 Thread Changlong Xie
ping... On 04/11/2016 11:56 AM, Changlong Xie wrote: Changelog v4: 1. Rebased to the lastest code v3: 1. Addressed on David's commets, fix a bug v2: 1. Rebased to the lastest code 2. Addressed on Eric's comments, fixed coding style Wen Congyang (1): Introduce "xen-load-devices-state" migr

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-04-19 Thread Li, Liang Z
> Subject: Re: [RFC Design Doc]Speed up live migration by skipping free pages > > * Li, Liang Z (liang.z...@intel.com) wrote: > > Hi Dave, > > > > I am now working on how to benefit post-copy by skipping the free > > pages, and I remember you have said we should let the destination know > > the in

[Qemu-devel] [PATCH for-2.6 v2 3/3] iotests: Test case for drive-mirror with unaligned image size

2016-04-19 Thread Fam Zheng
This is the regression test for the virtual size mismatch issue between target and source images. Reviewed-by: Max Reitz Signed-off-by: Fam Zheng --- tests/qemu-iotests/152 | 51 ++ tests/qemu-iotests/152.out | 5 + tests/qemu-iotests/group

[Qemu-devel] [PATCH for-2.6 v2 1/3] mirror: Don't extend the last sub-chunk

2016-04-19 Thread Fam Zheng
The last sub-chunk is rounded up to the copy granularity in the target image, resulting in a larger size than the source. Add a function to clip the copied sectors to the end. This undoes the "wrong" changes to tests/qemu-iotests/109.out in e5b43573e28. The remaining two offset changes are okay.

[Qemu-devel] [PATCH for-2.6 v2 0/3] block: Fix drive-mirror with image size unaligned with granularity

2016-04-19 Thread Fam Zheng
v2: Move the mirror_clip_sectors() to mirror_iteration. [Max] This fixes the bug introduced in e5b43573e28 and lately noticed by Kevin. Fam Zheng (3): mirror: Don't extend the last sub-chunk iotests: Add iotests.image_size iotests: Test case for drive-mirror with unaligned image size bloc

[Qemu-devel] [PATCH for-2.6 v2 2/3] iotests: Add iotests.image_size

2016-04-19 Thread Fam Zheng
This retrieves the virtual size of the image out of qemu-img info. Reviewed-by: Max Reitz Signed-off-by: Fam Zheng --- tests/qemu-iotests/iotests.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index d9ef60e..56f988a 100

[Qemu-devel] [RFC for-2.7 10/11] pseries: Consolidate construction of /rtas device tree node

2016-04-19 Thread David Gibson
For historical reasons construction of the /rtas node in the device tree (amongst others) is split into several places. In particular it's split between spapr_build_fdt() and spapr_rtas_device_tree_setup(). In fact, as well as adding the actual RTAS tokens to the device tree, spapr_rtas_device_tr

[Qemu-devel] [RFC for-2.7 06/11] pseries: Consolidate RTAS loading

2016-04-19 Thread David Gibson
At each system reset, the pseries machine needs to load RTAS, the run time portion of the guest firmware, into the VM. This means copying the actual RTAS code into guest memory, and also updating the device tree so that the guest OS and boot firmware can locate it. For historical reasons the copy

[Qemu-devel] [RFC for-2.7 01/11] qdt: IEEE1275-style device tree utility code

2016-04-19 Thread David Gibson
A number of guests supported by qemu use IEEE12750 (Open Firmware) style device trees for hardware discovery. In some cases (mac99, pseries) they get this device tree via calls to an in-guest Open Firmware implementation, in others (many ppc and arm embedded machines) they consume the flattened ("

[Qemu-devel] [RFC for-2.7 08/11] pseries: Start using qdt library for building device tree

2016-04-19 Thread David Gibson
This starts the process of converting the pseries machine type to use the qdt library code to build the guest's device tree instead of working directly and awkwardly with the flattened device tree format. For now we just convert the first section of spapr_build_fdt() which creates a tree sequentia

[Qemu-devel] [RFC for-2.7 02/11] pseries: Split device tree construction from device tree load

2016-04-19 Thread David Gibson
spapr_finalize_fdt() both finishes building the device tree for the guest and loads it into guest memory. For future cleanups, it's going to be more convenient to do these two things separately, so split them apart. The loading portion is pretty trivial, so we move it inline into the caller, ppc_s

[Qemu-devel] [RFC for-2.7 11/11] pseries: Remove unused callbacks from sPAPR VIO bus state

2016-04-19 Thread David Gibson
The VIOsPAPRBus structure has some callback pointers in it which aren't used anywhere in the code. It's not clear exactly why they were there in the first place, but they certainly have no function now. Signed-off-by: David Gibson --- include/hw/ppc/spapr_vio.h | 2 -- 1 file changed, 2 deletio

[Qemu-devel] [RFC for-2.7 00/11] A new infrastructure for guest device trees

2016-04-19 Thread David Gibson
This RFC series suggests a new approach to constructing IEE1275 or "fdt" style device trees for use by guests. At the moment we generally do that with libfdt which works, but as the amount of device tree manipulation we need in qemu grows, it becomes an increasingly poor choice. This introduces a

[Qemu-devel] [RFC for-2.7 07/11] pseries: Move adding of fdt reserve map entries

2016-04-19 Thread David Gibson
The flattened device tree passed to pseries guests contains a list of reserved memory areas. Currently we construct this list early in spapr_build_fdt() as we sequentially write out the fdt. This will be inconvenient for upcoming cleanups, so this patch moves the reserve map changes to the end of

[Qemu-devel] [RFC for-2.7 05/11] pseries: Build device tree only at reset time

2016-04-19 Thread David Gibson
Currently the pseries code builds a "skeleton" device tree at machine init time, then adds a bunch of stuff to it at reset. Over time, more and more logic has had to be moved from init to reset time, and there's really no advantage to doing any of it at init time. This patch removes the init time

[Qemu-devel] [RFC for-2.7 09/11] pseries: Consolidate construction of /chosen device tree node

2016-04-19 Thread David Gibson
For historical reasons construction of the /chosen node in the device tree (amongst others) is split into several places. This patch brings these pieces back together to make things clearer. Signed-off-by: David Gibson --- hw/ppc/spapr.c | 59

[Qemu-devel] [RFC for-2.7 04/11] pseries: Make spapr_create_fdt_skel() get information from machine state

2016-04-19 Thread David Gibson
Currently spapr_create_fdt_skel() takes a bunch of individual parameters for various things it will put in the device tree. Some of these can already be taken directly from sPAPRMachineState. This patch alters it so that all of them can be taken from there, which will allow this code to be moved

[Qemu-devel] [RFC for-2.7 03/11] pseries: Remove rtas_addr and fdt_addr fields from machinestate

2016-04-19 Thread David Gibson
These values are used only within ppc_spapr_reset(), so just change them to local variables. Signed-off-by: David Gibson --- hw/ppc/spapr.c | 14 +++--- include/hw/ppc/spapr.h | 1 - 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c i

Re: [Qemu-devel] I/O errors reported to guest for raw-image-file backed /dev/vda - but host sees no I/O errors

2016-04-19 Thread Fam Zheng
On Tue, 04/19 19:47, Lutz Vieweg wrote: > The guest drive parameters are: > > -drive > > "file=image.raw,if=virtio,format=raw,media=disk,cache=unsafe,werror=report,rerror=report" Given this implies aio=threads... > Can you provide any hint on how to pursue the cause of these errors? > (I thought

Re: [Qemu-devel] [PATCH for-2.6 v2 0/3] Bug fixes for gluster

2016-04-19 Thread Ric Wheeler
On 04/19/2016 10:09 AM, Jeff Cody wrote: On Tue, Apr 19, 2016 at 08:18:39AM -0400, Ric Wheeler wrote: On 04/19/2016 08:07 AM, Jeff Cody wrote: Bug fixes for gluster; third patch is to prevent a potential data loss when trying to recover from a recoverable error (such as ENOSPC). Hi Jeff, Just

Re: [Qemu-devel] [PATCH kernel 1/2] mm: add the related functions to build the free page bitmap

2016-04-19 Thread Li, Liang Z
> Cc: Rik van Riel; v...@zeniv.linux.org.uk; linux-ker...@vger.kernel.org; > quint...@redhat.com; amit.s...@redhat.com; pbonz...@redhat.com; > dgilb...@redhat.com; linux...@kvack.org; k...@vger.kernel.org; qemu- > de...@nongnu.org; ag...@suse.de; borntrae...@de.ibm.com > Subject: Re: [PATCH kernel

Re: [Qemu-devel] [PATCH 1/3] mirror: Don't extend the last sub-chunk

2016-04-19 Thread Fam Zheng
On Tue, 04/19 22:33, Max Reitz wrote: > On 19.04.2016 12:09, Fam Zheng wrote: > > The last sub-chunk is rounded up to the copy granularity in the target > > image, resulting in a larger size than the source. > > > > Add a function to clip the copied sectors to the end. > > > > This undoes the "wr

Re: [Qemu-devel] [PATCH kernel 1/2] mm: add the related functions to build the free page bitmap

2016-04-19 Thread Li, Liang Z
> On Tue, 2016-04-19 at 15:02 +, Li, Liang Z wrote: > > > > > > On Tue, 2016-04-19 at 22:34 +0800, Liang Li wrote: > > > > > > > > The free page bitmap will be sent to QEMU through virtio interface > > > > and used for live migration optimization. > > > > Drop the cache before building the free

Re: [Qemu-devel] [RFC v3] virtio-crypto specification

2016-04-19 Thread Gonglei (Arei)
Hi Michael, > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Subject: Re: [RFC v3] virtio-crypto specification > > On Tue, Apr 19, 2016 at 08:37:13AM +, Gonglei (Arei) wrote: > > Hi all, > > > > This is the specification (version 3) about a new virtio crypto device. > > > > Changes from

[Qemu-devel] [Bug 1570134] Re: While committing snapshot qemu crashes with SIGABRT

2016-04-19 Thread Matthew Schumacher
Max, Qemu still crashes for me, but the debug is again very different. When I attach to the qemu process from gdb, it is unable to provide a backtrace when it crashes. The log file is different too. Any ideas? qemu-system-x86_64: block.c:2307: bdrv_replace_in_backing_chain: Assertion `!bdrv_re

[Qemu-devel] [PATCH for-2.6 2/2] block/mirror: Refresh stale bitmap iterator cache

2016-04-19 Thread Max Reitz
If the drive's dirty bitmap is dirtied while the mirror operation is running, the cache of the iterator used by the mirror code may become stale and not contain all dirty bits. This only becomes an issue if we are looking for contiguously dirty chunks on the drive. In that case, we can easily dete

[Qemu-devel] [Bug 1572329] [NEW] ARM emulation: r0 != 0 on boot

2016-04-19 Thread Sylvain
Public bug reported: # arm-softmmu/qemu-system-arm -M raspi2 -m 1024 -smp 4 -kernel kernel.bin -serial stdio -dtb rpi2.dtb My code shows r0 = 0x31 while it should be 0. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a memb

Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags

2016-04-19 Thread Emilio G. Cota
On Thu, Apr 07, 2016 at 13:19:22 -0400, Emilio G. Cota wrote: > We are inconsistent with the type of tb->flags: usage varies loosely > between int and uint64_t. Settle to uint32_t everywhere, which is > superior to both: at least one target (aarch64) uses the most significant > bit in the u32, and

[Qemu-devel] [PATCH for-2.6 1/2] block/mirror: Revive dead yielding code

2016-04-19 Thread Max Reitz
mirror_iteration() is supposed to wait if the current chunk is subject to a still in-flight mirroring operation. However, it mixed checking this conflict situation with checking the dirty status of a chunk. A simplification for the latter condition (the first chunk encountered is always dirty) led

[Qemu-devel] [PATCH v3 07/11] tb hash: hash phys_pc, pc, and flags with xxhash

2016-04-19 Thread Emilio G. Cota
For some workloads such as arm bootup, tb_phys_hash is performance-critical. The is due to the high frequency of accesses to the hash table, originated by (frequent) TLB flushes that wipe out the cpu-private tb_jmp_cache's. More info: https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg05

[Qemu-devel] [PATCH v3 06/11] exec: add tb_hash_func5, derived from xxhash

2016-04-19 Thread Emilio G. Cota
This will be used by upcoming changes for hashing the tb hash. Add this into a separate file to include the copyright notice from xxhash. Signed-off-by: Emilio G. Cota --- include/exec/tb-hash-xx.h | 94 +++ 1 file changed, 94 insertions(+) create mo

[Qemu-devel] [PATCH v3 00/11] tb hash improvements

2016-04-19 Thread Emilio G. Cota
See v2 here: https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg01307.html Changes from v2: - Dropped "add missing fold of tb_ctx into tcg_ctx", already merged upstream as commit 7e6bd36d611. - Added reviewed-by tags from Alex and Richard - xxhash: + use rol32 from qemu/bitops.h +

[Qemu-devel] [PATCH v3 04/11] include/processor.h: define cpu_relax()

2016-04-19 Thread Emilio G. Cota
Taken from the linux kernel. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- include/qemu/processor.h | 28 1 file changed, 28 insertions(+) create mode 100644 include/qemu/processor.h diff --git a/include/qemu/processor.h b/include/qemu/processor

[Qemu-devel] [PATCH v3 09/11] qht: add test program

2016-04-19 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- tests/.gitignore | 1 + tests/Makefile | 6 ++- tests/test-qht.c | 139 +++ 3 files changed, 145 insertions(+), 1 deletion(-) create mode 100644 tests/test-qht.c diff --git a/tests/.gitignore b/tests/.gi

[Qemu-devel] [PATCH v3 08/11] qht: QEMU's fast, resizable and scalable Hash Table

2016-04-19 Thread Emilio G. Cota
This is a hash table with optional auto-resizing and MRU promotion for reads and writes. Its implementation goal is to stay fast while scaling for read-mostly workloads. A hash table with these features will be necessary for the scalability of the ongoing MTTCG work; before those changes arrive we

[Qemu-devel] [PATCH v3 01/11] compiler.h: add QEMU_ALIGNED() to enforce struct alignment

2016-04-19 Thread Emilio G. Cota
Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- include/qemu/compiler.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index 8f1cc7b..1978ddc 100644 --- a/include/qemu/compiler.h +++ b/include/qemu/compiler.h @@ -41,6 +41,

[Qemu-devel] [PATCH v3 11/11] translate-all: add tb hash bucket info to 'info jit' dump

2016-04-19 Thread Emilio G. Cota
Suggested-by: Richard Henderson Signed-off-by: Emilio G. Cota --- translate-all.c | 5 + 1 file changed, 5 insertions(+) diff --git a/translate-all.c b/translate-all.c index 617a572..769bffc 100644 --- a/translate-all.c +++ b/translate-all.c @@ -1664,6 +1664,8 @@ void dump_exec_info(FILE *f

[Qemu-devel] [PATCH v3 05/11] qemu-thread: add simple test-and-set spinlock

2016-04-19 Thread Emilio G. Cota
From: Guillaume Delbergue Signed-off-by: Guillaume Delbergue [Rewritten. - Paolo] Signed-off-by: Paolo Bonzini [Emilio's additions: call cpu_relax() while spinning; optimize for uncontended locks by acquiring the lock with xchg+test instead of test+xchg+test.] Signed-off-by: Emilio G. Cota -

[Qemu-devel] [PATCH v3 03/11] seqlock: rename write_lock/unlock to write_begin/end

2016-04-19 Thread Emilio G. Cota
It is a more appropriate name, now that the mutex embedded in the seqlock is gone. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- cpus.c | 28 ++-- include/qemu/seqlock.h | 4 ++-- 2 files changed, 16 insertion

[Qemu-devel] [PATCH v3 10/11] tb hash: track translated blocks with qht

2016-04-19 Thread Emilio G. Cota
Having a fixed-size hash table for keeping track of all translation blocks is suboptimal: some workloads are just too big or too small to get maximum performance from the hash table. The MRU promotion policy helps improve performance when the hash table is a little undersized, but it cannot make up

[Qemu-devel] [PATCH v3 02/11] seqlock: remove optional mutex

2016-04-19 Thread Emilio G. Cota
This option is unused; besides, it bloats the struct when not needed. Let's just let writers define their own locks elsewhere. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- cpus.c | 2 +- include/qemu/seqlock.h | 10 +- 2 fil

Re: [Qemu-devel] [PATCH 08/10] qht: QEMU's fast, resizable and scalable Hash Table

2016-04-19 Thread Emilio G. Cota
Hi Alex, I'm sending a v3 in a few minutes. I've addressed all your comments there, so I won't duplicate them here; please find inline my replies to some questions you raised. On Fri, Apr 08, 2016 at 11:27:19 +0100, Alex Bennée wrote: > Emilio G. Cota writes: (snip) > > +/* call only when there

Re: [Qemu-devel] [PATCH 09/10] qht: add test program

2016-04-19 Thread Emilio G. Cota
On Fri, Apr 08, 2016 at 11:45:41 +0100, Alex Bennée wrote: (snip the entire patch) > A couple of notes: > > - these should use the gtester boiler plate for reporting results Done in v3. > - AFAICT they are not exercising the multi-element hashing we actually > use in the main code > -

[Qemu-devel] [PATCH for-2.6 0/2] block/mirror: Fix mirroring with guest I/O load

2016-04-19 Thread Max Reitz
Bug report: https://bugs.launchpad.net/qemu/+bug/1570134 If you are doing a mirror operation (I just tested with block-commit on the active layer, but I guess any mirroring will do) while the guest has rather heavy I/O load (or light I/O also, you just need to be more unlucky) will lead to the cac

[Qemu-devel] [PULL for-2.6 0/1] qemu-ga patch queue for 2.6

2016-04-19 Thread Michael Roth
The following changes since commit 1f7685fafa6ba1354731a59822e5cc43323d6989: Update language files for QEMU 2.6.0 (2016-04-19 18:41:25 +0100) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2016-04-19-tag for you to fetch changes up to fb91f30bb9716c39

[Qemu-devel] [PULL 1/1] qemu-ga: do not run qga test when guest agent disabled

2016-04-19 Thread Michael Roth
From: Yang Hongyang When configure with --disable-guest-agent, make check will fail with: ERROR:tests/test-qga.c:74:fixture_setup: assertion failed (error == NULL): Failed to execute child process "/home/xx/qemu/qemu-ga" (No such file or directory) (g-exec-error-quark, 8) make: *** [check-tests/

Re: [Qemu-devel] [PATCH] qemu-ga: do not run qga test when guest agent disabled

2016-04-19 Thread Michael Roth
Quoting Peter Maydell (2016-04-19 17:08:03) > On 19 April 2016 at 23:01, Michael Roth wrote: > > Quoting Yang Hongyang (2016-04-19 02:39:13) > >> When configure with --disable-guest-agent, make check will fail with: > >> ERROR:tests/test-qga.c:74:fixture_setup: assertion failed (error == NULL): >

[Qemu-devel] [Bug 1570134] Re: While committing snapshot qemu crashes with SIGABRT

2016-04-19 Thread Max Reitz
Hi Matthew, I now reproduced the issue myself, and it appears the second patch just missed one little thing. The attached patch (together with patch 1 from above) fixes the problem for me. (Also available from https://github.com/XanClic/qemu.git, branch lp-1570134-pl2; archive: https://github.com

Re: [Qemu-devel] [PATCH] qemu-ga: do not run qga test when guest agent disabled

2016-04-19 Thread Peter Maydell
On 19 April 2016 at 23:01, Michael Roth wrote: > Quoting Yang Hongyang (2016-04-19 02:39:13) >> When configure with --disable-guest-agent, make check will fail with: >> ERROR:tests/test-qga.c:74:fixture_setup: assertion failed (error == NULL): >> Failed to execute child process "/home/xx/qemu/qem

Re: [Qemu-devel] [PATCH] qemu-ga: do not run qga test when guest agent disabled

2016-04-19 Thread Michael Roth
Quoting Yang Hongyang (2016-04-19 02:39:13) > When configure with --disable-guest-agent, make check will fail with: > ERROR:tests/test-qga.c:74:fixture_setup: assertion failed (error == NULL): > Failed to execute child process "/home/xx/qemu/qemu-ga" (No such file or > directory) (g-exec-error-qua

[Qemu-devel] run qemu with x86_64 arch (host arch)

2016-04-19 Thread Marwa Hamza
hello i'm trying to run qemu with x86_64 arch i prepared file system with busybox i got that elf file _install/bin/busybox: format de fichier elf64-x86-64 architecture: i386:x86-64, fanions 0x0102: EXEC_P, D_PAGED adresse de départ 0x00522024 and i compiled linux kernel make ARCH=x8

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-19 Thread Andy Lutomirski
On Tue, Apr 19, 2016 at 1:54 PM, Michael S. Tsirkin wrote: > On Tue, Apr 19, 2016 at 01:27:29PM -0700, Andy Lutomirski wrote: >> On Tue, Apr 19, 2016 at 1:16 PM, Michael S. Tsirkin wrote: >> > On Tue, Apr 19, 2016 at 11:01:38AM -0700, Andy Lutomirski wrote: >> >> On Tue, Apr 19, 2016 at 10:49 AM,

Re: [Qemu-devel] [PATCH 3/3] iotests: Test case for drive-mirror with unaligned image size

2016-04-19 Thread Max Reitz
On 19.04.2016 12:09, Fam Zheng wrote: > This is the regression test for the virtual size mismatch issue between > target and source images. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/152 | 51 > ++ > tests/qemu-iotests/152.out | 5 ++

Re: [Qemu-devel] [PATCH 2/3] iotests: Add iotests.image_size

2016-04-19 Thread Max Reitz
On 19.04.2016 12:09, Fam Zheng wrote: > This retrieves the virtual size of the image out of qemu-img info. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/iotests.py | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signa

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-19 Thread Michael S. Tsirkin
On Tue, Apr 19, 2016 at 01:27:29PM -0700, Andy Lutomirski wrote: > On Tue, Apr 19, 2016 at 1:16 PM, Michael S. Tsirkin wrote: > > On Tue, Apr 19, 2016 at 11:01:38AM -0700, Andy Lutomirski wrote: > >> On Tue, Apr 19, 2016 at 10:49 AM, Michael S. Tsirkin > >> wrote: > >> > On Tue, Apr 19, 2016 at

Re: [Qemu-devel] [PATCH 1/3] mirror: Don't extend the last sub-chunk

2016-04-19 Thread Max Reitz
On 19.04.2016 12:09, Fam Zheng wrote: > The last sub-chunk is rounded up to the copy granularity in the target > image, resulting in a larger size than the source. > > Add a function to clip the copied sectors to the end. > > This undoes the "wrong" changes to tests/qemu-iotests/109.out in > e5b4

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-19 Thread Andy Lutomirski
On Tue, Apr 19, 2016 at 1:16 PM, Michael S. Tsirkin wrote: > On Tue, Apr 19, 2016 at 11:01:38AM -0700, Andy Lutomirski wrote: >> On Tue, Apr 19, 2016 at 10:49 AM, Michael S. Tsirkin wrote: >> > On Tue, Apr 19, 2016 at 12:26:44PM -0400, David Woodhouse wrote: >> >> On Tue, 2016-04-19 at 19:20 +030

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-19 Thread Michael S. Tsirkin
On Tue, Apr 19, 2016 at 11:01:38AM -0700, Andy Lutomirski wrote: > On Tue, Apr 19, 2016 at 10:49 AM, Michael S. Tsirkin wrote: > > On Tue, Apr 19, 2016 at 12:26:44PM -0400, David Woodhouse wrote: > >> On Tue, 2016-04-19 at 19:20 +0300, Michael S. Tsirkin wrote: > >> > > >> > > I thought that PLATF

[Qemu-devel] [PATCH for-2.7 v3 10/12] vl: Make display_type a local variable

2016-04-19 Thread Eduardo Habkost
Now display_type is only used inside main(), and don't need to be a global variable. Signed-off-by: Eduardo Habkost --- include/sysemu/sysemu.h | 1 - vl.c| 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h i

[Qemu-devel] [PATCH for-2.7 v3 12/12] vl: Make display_remote a local variable

2016-04-19 Thread Eduardo Habkost
The variable is used only inside main(), so it can be local. Signed-off-by: Eduardo Habkost --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index cc9cf65..d09b7fb 100644 --- a/vl.c +++ b/vl.c @@ -129,7 +129,6 @@ const char *bios_name = NULL; enum vga_ret

[Qemu-devel] [PATCH for-2.7 v3 08/12] milkymist: Move DT_NOGRAPHIC check outside milkymist_tmu2_create()

2016-04-19 Thread Eduardo Habkost
DT_NOGRAPHIC handling will be moved to a MachineState field, and it will be easier to change milkymist_init() to check that field. Cc: Michael Walle Signed-off-by: Eduardo Habkost --- hw/lm32/milkymist-hw.h | 4 hw/lm32/milkymist.c| 4 +++- 2 files changed, 3 insertions(+), 5 deletions

[Qemu-devel] [PATCH for-2.7 v3 11/12] vl: Move DisplayType typedef to vl.c

2016-04-19 Thread Eduardo Habkost
Now the type is only used inside vl.c and doesn't need to be in a header file. Signed-off-by: Eduardo Habkost --- Change v1 -> v2: * Coding style fix (open brace '{' following enum go on the same line) --- include/sysemu/sysemu.h | 10 -- vl.c| 9 + 2 files

[Qemu-devel] [PATCH for-2.7 v3 07/12] spice: Initialization stubs on qemu-spice.h

2016-04-19 Thread Eduardo Habkost
This reduces the number of CONFIG_SPICE #ifdefs in vl.c. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Move stubs to qemu-spice.h, as the header file already had a separate section for !CONFIG_SPICE --- include/ui/qemu-spice.h | 13 ++

[Qemu-devel] [PATCH for-2.7 v3 09/12] vl: Replace DT_NOGRAPHIC with machine option

2016-04-19 Thread Eduardo Habkost
All DisplayType values are just UI options that don't affect any hardware emulation code, except for DT_NOGRAPHIC. Replace DT_NOGRAPHIC with DT_NONE plus a new "-machine graphics=on|off" option, so hardware emulation code don't need to use the display_type variable. Cc: Michael Walle Cc: Blue Swi

[Qemu-devel] [PATCH for-2.7 v3 06/12] gtk: Initialization stubs

2016-04-19 Thread Eduardo Habkost
This reduces the number of CONFIG_GTK #ifdefs in vl.c. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Move stub file to stubs/ui/ Changes v2 -> v3: * Add early_gtk_display_init() stub * Move stubs to header file --- include/ui/console.h | 17 + vl.c | 7

[Qemu-devel] [PATCH for-2.7 v3 02/12] vnc: Initialization stubs

2016-04-19 Thread Eduardo Habkost
This reduces the number of CONFIG_VNC #ifdefs in the vl.c code. The only user-visible difference is that this will make QEMU complain about syntax when using "-display vnc" ("VNC requires a display argument vnc=") even if CONFIG_VNC is disabled. Signed-off-by: Eduardo Habkost --- Changes v1 -> v

[Qemu-devel] [PATCH for-2.7 v3 01/12] vl: Add DT_COCOA DisplayType value

2016-04-19 Thread Eduardo Habkost
Instead of reusing DT_SDL for Cocoa, use DT_COCOA to indicate that a Cocoa display was requested. configure already ensures CONFIG_COCOA and CONFIG_SDL are never set at the same time. The only case where DT_SDL is used outside a #ifdef CONFIG_SDL block is in the no_frame/alt_grab/ctrl_grab check.

[Qemu-devel] [PATCH for-2.7 v3 00/12] vl: graphics stubs + #ifdef cleanup + DT_NOGRAPHIC cleanup

2016-04-19 Thread Eduardo Habkost
* Clean up the graphics initialization code to reduce the number of #ifdefs; * Remove the display_type == DT_NOGRAPHIC checks from hardware emulation code; * Make the display_type global variable a local variable on main(); * Make the display_remote static variable a local variable on main(

[Qemu-devel] [PATCH for-2.7 v3 05/12] cocoa: cocoa_display_init() stub

2016-04-19 Thread Eduardo Habkost
One less #ifdef in vl.c. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Move stub file to stubs/ui/ Changes v2 -> v3: * Fix typo (CONFIG_COCA) on comment * Move stub to header file --- include/ui/console.h | 9 + vl.c | 2 -- 2 files changed, 9 insertions(+), 2 d

[Qemu-devel] [PATCH for-2.7 v3 04/12] sdl: Initialization stubs

2016-04-19 Thread Eduardo Habkost
This reduces the number of CONFIG_SDL #ifdefs in vl.c. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Move stub file to stubs/ui/ Changes v2 -> v3: * Move stubs to header file --- include/ui/console.h | 16 vl.c | 6 ++ 2 files changed, 18 insertion

[Qemu-devel] [PATCH for-2.7 v3 03/12] curses: curses_display_init() stub

2016-04-19 Thread Eduardo Habkost
One less #ifdef in vl.c. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Move stub file to stubs/ui/ Changes v2 -> v3: * Move stub to header file --- include/ui/console.h | 9 + vl.c | 2 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/include/ui

Re: [Qemu-devel] [for-2.6] Re: [PATCH] qmp-commands.hx: document minimum speed for block jobs

2016-04-19 Thread Sascha Silbe
Dear Eric, Eric Blake writes: [...] > Ultimately, we want to make qmp-commands.hx go away, and have everything > generated from qapi/*.json. Marc-Andre has proposed some patches along > those lines (back in the 2.5 timeframe, but dependent on other qapi > patches that are still pending review).

[Qemu-devel] [PATCH for-2.6? v2] qemu-iotests: iotests: fail hard if not run via "check"

2016-04-19 Thread Sascha Silbe
Running an iotests-based Python test directly might appear to work, but may fail in subtle ways and is insecure: - It creates files with predictable file names in a world-writable location (/var/tmp). - Tests expect the environment to be set up by check. E.g. 041 and 055 may take the wrong co

Re: [Qemu-devel] [PATCH for-2.6?] qemu-iotests: iotests: fail hard if not run via "check"

2016-04-19 Thread Sascha Silbe
Dear Max, Max Reitz writes: > On 19.04.2016 14:22, Sascha Silbe wrote: [...] >> # We are using TEST_DIR and QEMU_DEFAULT_MACHINE as proxies to >> # indicate that we're not being run via "check". There may be >> # other things set up by "check" that individual test cases rely >> #

Re: [Qemu-devel] [for-2.6] Re: [PATCH] qmp-commands.hx: document minimum speed for block jobs

2016-04-19 Thread Eric Blake
On 04/19/2016 01:05 PM, Sascha Silbe wrote: > Dear Kevin, > > Kevin Wolf writes: > > [...] >> Isn't the JSON schema (qapi/block-core.json) considered the >> authoritative source for interface specifications these days? I think if >> we want to document the shortcomings for the time being, we sho

Re: [Qemu-devel] [PATCH for-2.7 v2 04/17] block: Introduce image file locking

2016-04-19 Thread Max Reitz
On 18.04.2016 07:34, Denis V. Lunev wrote: > On 04/18/2016 04:33 AM, Fam Zheng wrote: >> On Sun, 04/17 01:29, Max Reitz wrote: >>> On 15.04.2016 05:27, Fam Zheng wrote: Block drivers can implement this new operation .bdrv_lockf to actually lock the image in the protocol specific way.

Re: [Qemu-devel] [PATCH for-2.7 v2 04/17] block: Introduce image file locking

2016-04-19 Thread Max Reitz
On 18.04.2016 03:33, Fam Zheng wrote: > On Sun, 04/17 01:29, Max Reitz wrote: >> On 15.04.2016 05:27, Fam Zheng wrote: >>> Block drivers can implement this new operation .bdrv_lockf to actually lock >>> the >>> image in the protocol specific way. >>> >>> Signed-off-by: Fam Zheng >>> --- >>> bloc

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-04-19 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Mon, Apr 18, 2016 at 11:08:31AM +, Li, Liang Z wrote: > > Hi Dave, > > > > I am now working on how to benefit post-copy by skipping the free pages, > > and I remember you have said we should let the destination know the info > > of free pages

Re: [Qemu-devel] [PATCH for-2.6?] qemu-iotests: iotests: fail hard if not run via "check"

2016-04-19 Thread Max Reitz
On 19.04.2016 14:22, Sascha Silbe wrote: > Dear Max, > > Max Reitz writes: > >> On 14.04.2016 13:32, Sascha Silbe wrote: > [tests/qemu-iotests/iotests.py] > [...] >>> def main(supported_fmts=[], supported_oses=['linux']): >>> '''Run tests''' >>> >>> +if test_dir is None or qemu_defau

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-04-19 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > Hi Dave, > > I am now working on how to benefit post-copy by skipping the free pages, > and I remember you have said we should let the destination know the info > of free pages so as to avoid request the free pages from the source. > > We have two s

Re: [Qemu-devel] [for-2.6] Re: [PATCH] qmp-commands.hx: document minimum speed for block jobs

2016-04-19 Thread Sascha Silbe
Dear Kevin, Kevin Wolf writes: [...] > Isn't the JSON schema (qapi/block-core.json) considered the > authoritative source for interface specifications these days? I think if > we want to document the shortcomings for the time being, we should > document it in both places. Interesting. What exac

[Qemu-devel] [PATCH v2] QMP: document minimum speed for block jobs

2016-04-19 Thread Sascha Silbe
The current rate limit implementation for block jobs is ineffective below a certain minimum rate. It will permit writes at least once per time slice. The resulting minimum write speed (assuming source and sink are fast enough in the first place) is high enough that it may surprise some users, so do

Re: [Qemu-devel] [PATCH for-2.6] Update language files for QEMU 2.6.0

2016-04-19 Thread Peter Maydell
On 19 April 2016 at 18:36, Stefan Weil wrote: > Am 19.04.2016 um 11:43 schrieb Peter Maydell: >> Update translation files (change created via 'make -C po update'). >> >> Signed-off-by: Peter Maydell >> --- >> po/de_DE.po| 36 ++-- >> po/fr_FR.po| 36 ++

[Qemu-devel] [PATCH 1/2] target-arm: Unify AArch32 exception return generating functions

2016-04-19 Thread Sergey Sorokin
There is a duplicating code in AArch32 exception return implementation. The patch rearranges the code to avoid this. Signed-off-by: Sergey Sorokin --- target-arm/translate.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/target-arm/tran

[Qemu-devel] [PATCH 0/2] Unify and fix exception return in AArch32 state

2016-04-19 Thread Sergey Sorokin
There is a duplicating code in AArch32 exception return implementation. Also there is a missed exception return on AArch32 instruction ADDS r15. The patches rearrange the code and fix these issues. Sergey Sorokin (2): target-arm: Unify AArch32 exception return generating functions target-arm:

[Qemu-devel] [PATCH 2/2] target-arm: Fix an exception return on AArch32 instruction ADDS

2016-04-19 Thread Sergey Sorokin
In AArch32 instruction ADDS r15, ... is used for exception return. Signed-off-by: Sergey Sorokin --- target-arm/translate.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 68671b7..3e64ba9 100644 --- a/tar

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-19 Thread Andy Lutomirski
On Tue, Apr 19, 2016 at 10:49 AM, Michael S. Tsirkin wrote: > On Tue, Apr 19, 2016 at 12:26:44PM -0400, David Woodhouse wrote: >> On Tue, 2016-04-19 at 19:20 +0300, Michael S. Tsirkin wrote: >> > >> > > I thought that PLATFORM served that purpose. Woudn't the host >> > > advertise PLATFORM suppor

  1   2   3   >