Re: [Qemu-devel] [PATCHv2 for-2.6] ivshmem: fix ivshmem-{plain, doorbell} crash without arg

2016-04-12 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > "qemu -device ivshmem-{plain,doorbell}" will crash, because the device > doesn't check that the required argument is provided. Suggest to add "Screwed up in commit 5400c02." > Signed-off-by: Marc-André Lureau Reviewed-by: Marku

Re: [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions that are named *_exit or *_exitfn in hw/char from int to void

2016-04-12 Thread Markus Armbruster
Paolo Bonzini writes: > On 12/04/2016 20:17, Nutan Shinde wrote: >> >> -static int console_exit(SCLPEvent *event) >> +static console_exit(SCLPEvent *event) >> { >> -return 0; > > This patch doesn't even compile: > > CChw/char/sclpconsole.o > /home/pbonzini/work/upstream/qemu/hw/char/s

Re: [Qemu-devel] [PATCH v2 12/13] intel_iommu: ioapic: IR support for emulated IOAPIC

2016-04-12 Thread Peter Xu
On Tue, Apr 12, 2016 at 08:39:21PM -0700, Jan Kiszka wrote: > On 2016-04-12 20:33, Peter Xu wrote: > > On Tue, Apr 12, 2016 at 08:39:02AM -0700, Jan Kiszka wrote: > >> On 2016-04-12 02:02, Peter Xu wrote: > > > > [...] > > > >>> Yes, I should consider other x86 platforms like AMD. Thanks to point

Re: [Qemu-devel] [PATCH] docs/atomics.txt: Update pointer to linux macro

2016-04-12 Thread Pranith Kumar
On Tue, Apr 12, 2016 at 5:20 PM, Paolo Bonzini wrote: > FWIW I'll be mostly offline this week and on vacation starting from the > next, so it's probably best if you send the patch at the beginning of > May. It will be fixed _and_ act as a reminder. :) Sure, I will do so in May. -- Pranith

[Qemu-devel] [PATCH] qemu-iotests: 041: More robust assertion on quorum node

2016-04-12 Thread Fam Zheng
Block nodes are now assigned names automatically, therefore the test case is fragile in using fixed indices in result. Introduce a method in iotests.py and do the matching more sensibly. Signed-off-by: Fam Zheng --- tests/qemu-iotests/041| 12 tests/qemu-iotests/iotests.py |

Re: [Qemu-devel] [PATCH v2 12/13] intel_iommu: ioapic: IR support for emulated IOAPIC

2016-04-12 Thread Jan Kiszka
On 2016-04-12 20:33, Peter Xu wrote: > On Tue, Apr 12, 2016 at 08:39:02AM -0700, Jan Kiszka wrote: >> On 2016-04-12 02:02, Peter Xu wrote: > > [...] > >>> Yes, I should consider other x86 platforms like AMD. Thanks to point >>> out. It seems that there are many places in the patchset that lacks >

Re: [Qemu-devel] [PATCH v2 12/13] intel_iommu: ioapic: IR support for emulated IOAPIC

2016-04-12 Thread Peter Xu
On Tue, Apr 12, 2016 at 08:39:02AM -0700, Jan Kiszka wrote: > On 2016-04-12 02:02, Peter Xu wrote: [...] > > Yes, I should consider other x86 platforms like AMD. Thanks to point > > out. It seems that there are many places in the patchset that lacks > > thorough consideration about this. Will try

Re: [Qemu-devel] [PATCH 18/18] test: add shutdown support vubr test

2016-04-12 Thread Yuanhan Liu
On Fri, Apr 01, 2016 at 01:16:28PM +0200, marcandre.lur...@redhat.com wrote: > +static void > +vubr_handle_slave_reply(VhostUserMsg *vmsg) > +{ > +DPRINT( > +"== Vhost slave reply from QEMU > ==\n"); > +DPRINT("Request: %s (%d)\n", vubr_slave_req

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-04-12 Thread Yuanhan Liu
Hi Marc, First of all, sorry again for late response! Last time I tried with your first version, I found few issues related with reconnect, mainly on the acked_feautres lost. While checking your new code, I found that you've already solved that, which is great. So, I tried harder this time, your

Re: [Qemu-devel] post-copy is broken?

2016-04-12 Thread Li, Liang Z
> > > I used the latest qemu code (commit id: 4e71220387e88a22) and kernel > > (v4.5) to test the post-copy, and find the guest get crashed after > > live migration, no matter I did a local live migration or live > > migration between two hosts. I just ran the stress as the workload in > > guest. I

Re: [Qemu-devel] [PATCH V2 1/3] colo-compare: introduce colo compare initlization

2016-04-12 Thread Zhang Chen
+if (!size) { +return 0; +} + +ret = qemu_chr_fe_write_all(out, (uint8_t *)&len, sizeof(len)); +if (ret != sizeof(len)) { +goto err; +} + +ret = qemu_chr_fe_write_all(out, (uint8_t *)buf, size); +if (ret != size) { +goto err; +} + You can ma

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

2016-04-12 Thread Ryan Harper
Here's an update. The Xenial kernel doesn;t like the emulated POWER7 cpu that the command line being used generates by default. processor : 0 cpu : POWER7 (raw), altivec supported clock : 1000.00MHz revision: 2.3 (pvr 003f 0203) timebase: 51200

Re: [Qemu-devel] post-copy is broken?

2016-04-12 Thread Li, Liang Z
> > I used the latest qemu code (commit id: 4e71220387e88a22) and kernel > (v4.5) to test the post-copy, and find the guest get crashed after live > migration, no matter I did a local live migration or live migration between > two > hosts. I just ran the stress as the workload in guest. It seems t

[Qemu-devel] [PULL 1/4] xen: Fix IDE unplug

2016-04-12 Thread John Snow
From: Anthony PERARD After commit e5e7855 (blockdev: Separate BB name management), starting a guest with PVHVM support result in this assert: qemu-system-i386: block/block-backend.c:173: blk_delete: Assertion `!blk->name' failed. A backtrace show that a caller is pci_piix3_xen_ide_unplug(). Th

[Qemu-devel] [PULL 2/4] ide: don't lose pending dma state

2016-04-12 Thread John Snow
From: Pavel Butsykin If the migration occurs after the IDE DMA has been set up but before it has been initiated, the state gets lost upon save/restore. Specifically, ->dma_cb callback gets cleared, so, when the guest eventually starts bus mastering, the DMA never completes, causing the guest to t

[Qemu-devel] [PULL 4/4] ide: really restart pending and in-flight atapi dma

2016-04-12 Thread John Snow
From: Pavel Butsykin Restart of ATAPI DMA used to be unreachable, because the request to do so wasn't indicated in bus->error_status due to the lack of spare bits, and ide_restart_bh() would return early doing nothing. This patch makes use of the observation that not all bit combinations were po

[Qemu-devel] [PULL 3/4] ide: restart atapi dma by re-evaluating command packet

2016-04-12 Thread John Snow
From: Pavel Butsykin ide_atapi_dma_restart() used to just complete the DMA with an error, under the assumption that there isn't enough information to restart it. However, as the contents of the ->io_buffer is preserved, it looks safe to just re-evaluate it and dispatch the ATAPI command again.

[Qemu-devel] [PULL 0/4] Ide patches

2016-04-12 Thread John Snow
The following changes since commit d44122ecd0fa62d20762bdd8f214f077cb8e011b: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2016-04-12 17:47:15 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to f

Re: [Qemu-devel] [Bug 1450881] Re: qemu-system-sparc MUTEX_HELD assert and libC lock errors

2016-04-12 Thread jdery
re: diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 58572c3..7998ff5 100644 ... -tcg_gen_qemu_ld8s(cpu_val, cpu_addr, dc->mem_idx); +tcg_gen_qemu_ld8u(cpu_val, cpu_addr, dc->mem_idx); I confirmed this patch resolves MUTEX_HELD

Re: [Qemu-devel] [PATCH v2] exec.c: Ensure right alignment also for file backed ram

2016-04-12 Thread Paolo Bonzini
On 07/04/2016 23:31, Dominik Dingel wrote: > diff --git a/exec.c b/exec.c > index c4f9036..1ae98e4 100644 > --- a/exec.c > +++ b/exec.c > @@ -1241,6 +1241,7 @@ static void *file_ram_alloc(RAMBlock *block, > void *area; > int fd = -1; > int64_t page_size; > +int64_t alignment; >

Re: [Qemu-devel] work needed on QEMU 2.6 ChangeLog

2016-04-12 Thread Paolo Bonzini
On 12/04/2016 21:56, Andrew Baumann wrote: > * New partial Raspberry Pi 2 emulation with "raspi2" machine type. > For now, it can boot older releases of Windows and Raspbian, but > lacks a number of devices including USB. > > Basically, it has already bit-rotted with respect to the most recent >

Re: [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions that are named *_exit or *_exitfn in hw/char from int to void

2016-04-12 Thread Paolo Bonzini
On 12/04/2016 20:17, Nutan Shinde wrote: > > -static int console_exit(SCLPEvent *event) > +static console_exit(SCLPEvent *event) > { > -return 0; This patch doesn't even compile: CChw/char/sclpconsole.o /home/pbonzini/work/upstream/qemu/hw/char/sclpconsole.c:245:8: error: return ty

Re: [Qemu-devel] [PATCH] docs/atomics.txt: Update pointer to linux macro

2016-04-12 Thread Paolo Bonzini
On 12/04/2016 18:08, Pranith Kumar wrote: > On Tue, Apr 12, 2016 at 7:42 AM, Marc-André Lureau > wrote: >> Hi >> >> On Mon, Apr 11, 2016 at 7:30 PM, Pranith Kumar wrote: >>> Add a missing end brace and update doc to point to the latest access >>> macro. ACCESS_ONE() is deprecated. >> >> ONE/ONC

Re: [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header

2016-04-12 Thread Jan Vesely
On Sat, 2016-03-19 at 21:18 -0400, Jan Vesely wrote: > Fixes build with new linux headers. > > Signed-off-by: Jan Vesely > --- > linux-headers-4.5 and xfsprogs-3.2.4 in my case > >  configure | 18 ++ >  1 file changed, 18 insertions(+) > > diff --git a/configure b/configure > in

[Qemu-devel] [PATCH] qmp-commands.hx: document minimum speed for block jobs

2016-04-12 Thread Sascha Silbe
The current rate limit implementation for block jobs is ineffective below a certain minimum rate. It will permit writes at least once per time slice. The resulting minimum write speed (assuming source and sink are fast enough in the first place) is high enough that it may surprise some users, so do

Re: [Qemu-devel] [PATCH] correct comment of MemoryHotplugState

2016-04-12 Thread Eduardo Habkost
On Sat, Apr 09, 2016 at 05:18:01PM +0800, Cao jin wrote: > ping? I will add this to the machine queue for 2.7. > On 03/16/2016 04:00 AM, Eduardo Habkost wrote: > >On Mon, Mar 14, 2016 at 01:42:06PM +0800, Cao jin wrote: > >>Hi, > >> Is anyone gonna take this one? > > > >Not sure which tree th

[Qemu-devel] work needed on QEMU 2.6 ChangeLog

2016-04-12 Thread Paolo Bonzini
Hi all, if you are CCed there is a feature you wrote or maintain that needs further work in the ChangeLog (http://wiki.qemu.org/ChangeLog/2.6). In particular: Andrew/Peter: * New partial Raspberry Pi 1 and 2 emulation with "raspi" and "raspi2" machine types. For now the "raspi2" machine type can

Re: [Qemu-devel] [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit

2016-04-12 Thread Eduardo Habkost
On Tue, Apr 12, 2016 at 02:58:03PM +0200, Aleksandar Markovic wrote: [...] > 4) Updated code for all platforms to reflect changes in SoftFloat library. > This change is twofolds: it includes modifications of SoftFloat library > functions invocations, and an addition of invocation of fun

[Qemu-devel] Fwd: [PATCH v2 5/5] Change return type of functions that are named *_exit or *_exitfn in hw/usb from int to void

2016-04-12 Thread Nutan Shinde
This change is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/usb package. Signed-off-by: Nutan Shinde --- hw/usb/ccid-card-emulated.c | 3 +-- hw/usb/ccid.h | 2 +- hw/usb/dev-smartcard-reader.c | 11

[Qemu-devel] Fwd: [PATCH v2 4/5] Change return type of functions that are named *_exit or *_exitfn in hw/s390x from int to void

2016-04-12 Thread Nutan Shinde
This change is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/s390x package. Signed-off-by: Nutan Shinde --- hw/s390x/virtio-ccw.c | 7 +++ hw/s390x/virtio-ccw.h | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff

Re: [Qemu-devel] [PATCHv9] Improve documentation for TLS

2016-04-12 Thread Alex Bligh
Eric, Thanks for these - both in v10. On 12 Apr 2016, at 16:15, Eric Blake wrote: >> +There is a degenerate case of SELECTIVETLS where all >> +exports are TLS-only. This is permitted in part to make programming >> +of servers easier. Operation is a little different from FORCEDTLS, >> +as the cl

[Qemu-devel] Fwd: [PATCH v2 3/5] Change return type of functions that are named *_exit or *_exitfn in hw/core from int to void

2016-04-12 Thread Nutan Shinde
This change is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/core package. Signed-off-by: Nutan Shinde --- hw/core/qdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c i

[Qemu-devel] [PATCHv10] Improve documentation for TLS

2016-04-12 Thread Alex Bligh
* Call out TLS into a separate section * Add details of the TLS protocol itself * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can be initiated from either side (as required by the TLS standard I believe and as actually works in practice) * Clarify what is a requirem

[Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions that are named *_exit or *_exitfn in hw/char from int to void

2016-04-12 Thread Nutan Shinde
This change is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/char package. Signed-off-by: Nutan Shinde --- hw/char/sclpconsole-lm.c | 3 +-- hw/char/sclpconsole.c| 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) dif

[Qemu-devel] [Bug 1569491] [NEW] qemu system i386 poor performance on e5500 core

2016-04-12 Thread luigiburdo
Public bug reported: I had been tested with generic core net building or with mtune e5500 but i have the same result: performances are extremly low compared with other classes of powerpc cpu. The strange is the 5020 2ghz in all emulators been tested by me is comparable with a 970MP 2.7 ghz in s

[Qemu-devel] Fwd: [PATCH v2 1/5] Change return type of functions that are named *_exit or *_exitfn in hw/ from int to void

2016-04-12 Thread Nutan Shinde
This changes is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/audio package. Signed-off-by: Nutan Shinde --- hw/audio/hda-codec.c | 3 +-- hw/audio/intel-hda.c | 3 +-- hw/audio/intel-hda.h | 2 +- include/hw/qdev-core.h |

[Qemu-devel] [PATCH v2 1/5] Change return type of functions that are named *_exit or *_exitfn in hw/ from int to void

2016-04-12 Thread Nutan Shinde
This changes is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/audio package. Signed-off-by: Nutan Shinde --- hw/audio/hda-codec.c | 3 +-- hw/audio/intel-hda.c | 3 +-- hw/audio/intel-hda.h | 2 +- include/hw/qdev-core.h

Re: [Qemu-devel] [PATCH] Change return type of functions that are named *_exit or *_exitfn in hw/ from int to void

2016-04-12 Thread Nutan Shinde
Hi, Please ignore this patch, I have sent a new patch with version v2, in subject line, which has updated changes. Regards, Nutan. On Tue, Apr 12, 2016 at 11:24 PM, Nutan Shinde wrote: > This changes is required because the return type of exit(error) function > is not used. > This patch only h

[Qemu-devel] [PATCH v2 1/5] Change return type of functions that are named *_exit or *_exitfn in hw/ from int to void

2016-04-12 Thread Nutan Shinde
This changes is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/audio package. Signed-off-by: Nutan Shinde --- hw/audio/hda-codec.c | 3 +-- hw/audio/intel-hda.c | 3 +-- hw/audio/intel-hda.h | 2 +- include/hw/qdev-core.h

Re: [Qemu-devel] post-copy is broken?

2016-04-12 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > Hi David, > > I used the latest qemu code (commit id: 4e71220387e88a22) and kernel (v4.5) > to test the post-copy, and find the guest get crashed after live migration, > no matter I did a local live migration or live migration between two hosts. I >

[Qemu-devel] [PATCH] Change return type of functions that are named *_exit or *_exitfn in hw/ from int to void

2016-04-12 Thread Nutan Shinde
This changes is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/audio package. Signed-off-by: Nutan Shinde --- hw/audio/hda-codec.c | 3 +-- hw/audio/intel-hda.c | 3 +-- hw/audio/intel-hda.h | 2 +- include/hw/qdev-core.h

Re: [Qemu-devel] [PATCH v2 3/3] xenfb: remove out_cons in xenfb_handle_events

2016-04-12 Thread Stefano Stabellini
On Tue, 12 Apr 2016, Wei Liu wrote: > The variable out_cons was only used to temporarily hold the consumer > index. Use cons directly to simplify code a bit. > > No functional change introduced. > > Signed-off-by: Wei Liu Except for the fact that it is based on patch #2, which is wrong, this lo

Re: [Qemu-devel] [PATCH for-2.6 0/4] qemu-iotests: don't use /tmp

2016-04-12 Thread Max Reitz
On 12.04.2016 16:56, Sascha Silbe wrote: > During review of my other qemu-iotests fixes, Max Reitz noticed a > couple of additional places where qemu-iotests hardcode /tmp. This is > both a security issue and cumbersome when running multiple instances > of qemu-iotests (e.g. different users on a sh

Re: [Qemu-devel] [Xen-devel] [PATCH v2 2/3] xenfb: move xen_rmb to the correct location

2016-04-12 Thread Stefano Stabellini
On Tue, 12 Apr 2016, Wei Liu wrote: > On Tue, Apr 12, 2016 at 02:38:13PM +0100, Andrew Cooper wrote: > > On 12/04/16 13:57, David Vrabel wrote: > > > On 12/04/16 11:43, Wei Liu wrote: > > >> It should be placed before first time producer and consumer are used. > > > This change isn't necessary and

Re: [Qemu-devel] [PATCH 4/4] qemu-iotests: place valgrind log file in scratch dir

2016-04-12 Thread Max Reitz
On 12.04.2016 16:56, Sascha Silbe wrote: > Do not place the valgrind log file at a predictable path in a > world-writable location. Use the common scratch directory (${TEST_DIR}) > instead. > > Signed-off-by: Sascha Silbe > Reviewed-by: Bo Tu > --- > tests/qemu-iotests/common.config | 2 +- > 1

Re: [Qemu-devel] [PATCH 3/4] qemu-iotests: tests: do not set unused tmp variable

2016-04-12 Thread Max Reitz
On 12.04.2016 16:56, Sascha Silbe wrote: > The previous commit removed the last usage of ${tmp} inside the tests > themselves; the only remaining users are sourced by check. So we can now > drop this variable from the tests. > > Signed-off-by: Sascha Silbe > Reviewed-by: Bo Tu > --- > tests/qem

Re: [Qemu-devel] [PATCH] MAINTAINERS: update Xen mailing list address

2016-04-12 Thread Stefano Stabellini
On Tue, 12 Apr 2016, Stefano Stabellini wrote: > On Tue, 12 Apr 2016, Wei Liu wrote: > > Signed-off-by: Wei Liu > > Acked-by: Stefano Stabellini I need to update my scripts. I meant: Acked-by: Stefano Stabellini > > > Cc: Stefano Stabellini > > Cc: Anthony Perard > > > > This is the cano

Re: [Qemu-devel] [PATCH v2 1/3] xenfb: use the correct condition to avoid excessive looping

2016-04-12 Thread Stefano Stabellini
On Tue, 12 Apr 2016, Wei Liu wrote: > In commit ac0487e1 ("xenfb.c: avoid expensive loops when prod <= > out_cons"), ">=" was used. In fact, a full ring is a legit state. > Correct the test to use ">". > > Reported-by: "Hao, Xudong" > Signed-off-by: Wei Liu > Tested-by: "Hao, Xudong" > Acked-by

Re: [Qemu-devel] [PATCH 2/4] qemu-iotests: common.rc: drop unused _do()

2016-04-12 Thread Max Reitz
On 12.04.2016 16:56, Sascha Silbe wrote: > _do() was never used and possibly creates temporary files at > predictable, world-writable locations. Get rid of it. > > Signed-off-by: Sascha Silbe > Reviewed-by: Bo Tu > --- > tests/qemu-iotests/common.rc | 46 > -

Re: [Qemu-devel] [PATCH 1/4] qemu-iotests: drop unused _within_tolerance() filter

2016-04-12 Thread Max Reitz
On 12.04.2016 16:56, Sascha Silbe wrote: > _within_tolerance() isn't used anymore and possibly creates temporary > files at predictable, world-writable locations. Get rid of it. > > If it's needed again in the future it can be revived easily and fixed up > to use TEST_DIR and / or safely created t

Re: [Qemu-devel] [PATCH] MAINTAINERS: update Xen mailing list address

2016-04-12 Thread Stefano Stabellini
On Tue, 12 Apr 2016, Wei Liu wrote: > Signed-off-by: Wei Liu Acked-by: Stefano Stabellini > Cc: Stefano Stabellini > Cc: Anthony Perard > > This is the canonical address. It also seems that this is the most > reliable address. > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCHv9] Improve documentation for TLS

2016-04-12 Thread Eric Blake
On 04/12/2016 07:27 AM, Alex Bligh wrote: > * Call out TLS into a separate section > > * Add details of the TLS protocol itself > > * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can > be initiated from either side (as required by the TLS standard I believe > and as a

Re: [Qemu-devel] [PATCH 3/3] ide: really restart pending and in-flight atapi dma

2016-04-12 Thread John Snow
On 04/12/2016 08:17 AM, Pavel Butsykin wrote: > On 12.04.2016 01:18, Eric Blake wrote: >> On 04/06/2016 12:40 AM, Denis V. Lunev wrote: >>> From: Pavel Butsykin >>> >>> Restart of ATAPI DMA used to be unreachable, because the request to do >>> so wasn't indicated in bus->error_status due to the

[Qemu-devel] [PULL 13/13] qemu-iotests: iotests.py: get rid of __all__

2016-04-12 Thread Kevin Wolf
From: Sascha Silbe The __all__ list contained a typo for as long as the iotests module existed. That typo prevented "from iotests import *" (which is the only case where iotests.__all__ is used at all) from ever working. The names used by iotests are highly prone to name collisions, so importing

[Qemu-devel] [PULL 12/13] qemu-iotests: 068: don't require KVM

2016-04-12 Thread Kevin Wolf
From: Sascha Silbe None of the other test cases explicitly enable KVM and there's no obvious reason for 068 to require it. Drop this so all test cases can be executed in environments where KVM is not available (e.g. because the user doesn't have sufficient permissions to access /dev/kvm). Signed

[Qemu-devel] [PULL 08/13] qemu-iotests: check: don't place files with predictable names in /tmp

2016-04-12 Thread Kevin Wolf
From: Sascha Silbe Placing files with predictable or even hard-coded names in /tmp is a security risk and can prevent or disturb operation on a multi-user machine. Place them inside the "scratch" directory instead, as we already do for most other test-related files. Signed-off-by: Sascha Silbe

Re: [Qemu-devel] [PATCH for 2.6 v4 0/3] ide: fix loss of the dma/atapi state during migration

2016-04-12 Thread John Snow
On 04/12/2016 01:33 AM, Denis V. Lunev wrote: > On 04/12/2016 12:47 AM, John Snow wrote: >> >> On 04/11/2016 10:12 AM, Denis V. Lunev wrote: >>> On 04/06/2016 09:40 AM, Denis V. Lunev wrote: This patch set fixes bugs in the IDE DMA and the IDE ATAPI on operations to save/restore th

[Qemu-devel] [PULL 01/13] iotests: fix the broken 026.nocache output

2016-04-12 Thread Kevin Wolf
From: Pavel Butsykin This patch fixes longstanding issue with 026 iotest. Unfortunately, this test contains 2 versions of the correct output, one for cached writes and one for non-cached ones. People tends to fix only one version of output of the test and thus noncached version becomes broken. Un

[Qemu-devel] [PULL 06/13] qcow2: Prevent backing file names longer than 1023

2016-04-12 Thread Kevin Wolf
From: Max Reitz We reject backing file names with a length of more than 1023 characters when opening a qcow2 file, so we should not produce such files ourselves. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/qcow2.c | 4 1 file changed, 4 inserti

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-04-12 Thread Max Reitz
On 11.04.2016 07:18, Changlong Xie wrote: > On 03/30/2016 11:07 PM, Max Reitz wrote: >> On 30.03.2016 13:39, Alberto Garcia wrote: >>> On Tue 29 Mar 2016 05:51:22 PM CEST, Max Reitz wrote: > It sounds like the argument here, and in Max's thread on > query-block-node-tree, is that we DO have

[Qemu-devel] [PULL 09/13] qemu-iotests: fix 051 on non-PC architectures

2016-04-12 Thread Kevin Wolf
From: Sascha Silbe Commit 61de4c68 [block: Remove BDRV_O_CACHE_WB] updated the reference output for PCs, but neglected to do the same for the generic reference output file. Fix 051 on all non-PC architectures by applying the same change to the generic output file. Fixes: 61de4c68 ("block: Remove

[Qemu-devel] [PULL 10/13] qemu-iotests: iotests.VM: remove qtest socket on error

2016-04-12 Thread Kevin Wolf
From: Sascha Silbe On error, VM.launch() cleaned up the monitor unix socket, but left the qtest unix socket behind. This caused the remaining sub-tests to fail with EADDRINUSE: +== +ERROR: testQuorum (__main__.TestFifoQuorumEven

[Qemu-devel] [PULL 11/13] qemu-iotests: 148: properly skip test if quorum support is missing

2016-04-12 Thread Kevin Wolf
From: Sascha Silbe qemu-iotests test case 148 already had some code for skipping the test if quorum support is missing, but it didn't work in all cases. TestQuorumEvents.setUp() gets run before the actual test class (which contains the skipping code) and tries to start qemu with a drive using the

[Qemu-devel] [PULL 07/13] MAINTAINERS: Block layer core, qcow2 and blkdebug

2016-04-12 Thread Kevin Wolf
From: Max Reitz As agreed with Kevin and already practiced for a while, I am adding myself as co-maintainer of the block layer core, qcow2 and blkdebug. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAIN

[Qemu-devel] [PULL 03/13] block: initialize qcrypto API at startup

2016-04-12 Thread Kevin Wolf
From: "Daniel P. Berrange" Any programs which call the qcrypto APIs should ensure that qcrypto_init() has been called before anything else which can use crypto. Essentially this means right at the start of the main method before initializing anything else. This is important because some versions

[Qemu-devel] [PULL 04/13] iotests: Make 150 use qemu-img map instead of du

2016-04-12 Thread Kevin Wolf
From: Max Reitz The actual on-disk size of a file does not only depend on factors qemu can control. Thus, we should not depend on this to determine whether a file has indeed been fully allocated. Instead, use qemu-img map and hope that if an area is referenced, it is indeed allocated, too. Also,

[Qemu-devel] [PULL 02/13] qemu-img: fix formatting of error message

2016-04-12 Thread Kevin Wolf
From: "Daniel P. Berrange" The error_reportf_err() will not automatically append a ': ' before adding its suffix, so we must include that in the message we pass it, otherwise we get a badly formatted message lacking whitespace: qemu-img: Could not open 'driver=nbd,host=127.0.0.1,port=,tls-c

[Qemu-devel] [PULL 05/13] vpc: fix return value check for blk_pwrite

2016-04-12 Thread Kevin Wolf
From: Paolo Bonzini bdrv_pwrite_sync used to return zero or negative error, while blk_pwrite returns the number of written bytes when successful. This caused VPC image creation to fail spectacularly: it wrote the first 512 bytes, and then exited immediately because of the non-zero answer from bl

[Qemu-devel] [PULL 00/13] Block patches for 2.6

2016-04-12 Thread Kevin Wolf
The following changes since commit 42bb626f7ebc9197d2943b897a99e127315275ab: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2016-04-12 09:34:52 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you t

Re: [Qemu-devel] [PATCH] docs/atomics.txt: Update pointer to linux macro

2016-04-12 Thread Pranith Kumar
On Tue, Apr 12, 2016 at 7:42 AM, Marc-André Lureau wrote: > Hi > > On Mon, Apr 11, 2016 at 7:30 PM, Pranith Kumar wrote: >> Add a missing end brace and update doc to point to the latest access >> macro. ACCESS_ONE() is deprecated. > > ONE/ONCE Right, I missed this one. Should I fix and send a ne

Re: [Qemu-devel] [PATCH v2 12/13] intel_iommu: ioapic: IR support for emulated IOAPIC

2016-04-12 Thread Jan Kiszka
On 2016-04-12 02:02, Peter Xu wrote: > On Mon, Apr 11, 2016 at 10:22:18PM -0700, Jan Kiszka wrote: >> On 2016-04-11 02:19, Peter Xu wrote: >>> diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c >>> index 378e663..d963d45 100644 >>> --- a/hw/intc/ioapic.c >>> +++ b/hw/intc/ioapic.c >>> @@ -57,6 +57,8

Re: [Qemu-devel] [PATCHv9] Improve documentation for TLS

2016-04-12 Thread Eric Blake
On 04/12/2016 07:27 AM, Alex Bligh wrote: > * Call out TLS into a separate section > > * Add details of the TLS protocol itself > > * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can > be initiated from either side (as required by the TLS standard I believe > and as a

[Qemu-devel] [PATCHv2 for-2.6] ivshmem: fix ivshmem-{plain, doorbell} crash without arg

2016-04-12 Thread marcandre . lureau
From: Marc-André Lureau "qemu -device ivshmem-{plain,doorbell}" will crash, because the device doesn't check that the required argument is provided. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/hw/mis

[Qemu-devel] [PATCH 3/4] qemu-iotests: tests: do not set unused tmp variable

2016-04-12 Thread Sascha Silbe
The previous commit removed the last usage of ${tmp} inside the tests themselves; the only remaining users are sourced by check. So we can now drop this variable from the tests. Signed-off-by: Sascha Silbe Reviewed-by: Bo Tu --- tests/qemu-iotests/001 | 1 - tests/qemu-iotests/002 | 1 - tests/

[Qemu-devel] [PATCH] iSCSI: start moving options also for -drive

2016-04-12 Thread Pino Toscano
Hi, to overcome the limitations of the options handling [1], I'm planning to move more options for iSCSI also as block options, so it is possible to specify them with -drive. The only patch in this series is for initiator-target, as I want to be sure the approach is correct, and wanted. [1] http

[Qemu-devel] [PATCH for-2.6 0/4] qemu-iotests: don't use /tmp

2016-04-12 Thread Sascha Silbe
During review of my other qemu-iotests fixes, Max Reitz noticed a couple of additional places where qemu-iotests hardcode /tmp. This is both a security issue and cumbersome when running multiple instances of qemu-iotests (e.g. different users on a shared development machine like tuxmaker). Fix them

[Qemu-devel] [PATCH 4/4] qemu-iotests: place valgrind log file in scratch dir

2016-04-12 Thread Sascha Silbe
Do not place the valgrind log file at a predictable path in a world-writable location. Use the common scratch directory (${TEST_DIR}) instead. Signed-off-by: Sascha Silbe Reviewed-by: Bo Tu --- tests/qemu-iotests/common.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Qemu-devel] [PATCH] iscsi: allow "initiator-name" as block option

2016-04-12 Thread Pino Toscano
Allow the "initiator-name" for both the -iscsi and the block options: this way it is possible to set it directly as option in the -drive specification. The current way to specify the initiator name for a certain iSCSI target is: -iscsi id=TARGET,initiator-name=IQN which cannot be actually done wh

[Qemu-devel] [PATCH 1/4] qemu-iotests: drop unused _within_tolerance() filter

2016-04-12 Thread Sascha Silbe
_within_tolerance() isn't used anymore and possibly creates temporary files at predictable, world-writable locations. Get rid of it. If it's needed again in the future it can be revived easily and fixed up to use TEST_DIR and / or safely created temporary files. Signed-off-by: Sascha Silbe Revie

[Qemu-devel] [PATCH 2/4] qemu-iotests: common.rc: drop unused _do()

2016-04-12 Thread Sascha Silbe
_do() was never used and possibly creates temporary files at predictable, world-writable locations. Get rid of it. Signed-off-by: Sascha Silbe Reviewed-by: Bo Tu --- tests/qemu-iotests/common.rc | 46 1 file changed, 46 deletions(-) diff --git a/tes

Re: [Qemu-devel] [PATCH] move const_le{16, 23} to qemu/bswap.h, add comment

2016-04-12 Thread Eric Blake
On 04/12/2016 12:07 AM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > include/hw/virtio/virtio-input.h | 14 -- > include/qemu/bswap.h | 19 +++ > 2 files changed, 19 insertions(+), 14 deletions(-) Reviewed-by: Eric Blake -- Eric Blake e

Re: [Qemu-devel] [PATCH v2] virtio-input: add parenthesis to const_le{16, 32}

2016-04-12 Thread Eric Blake
On 04/11/2016 11:51 PM, Gerd Hoffmann wrote: > "_x" must be "(_x)" otherwise things fail if you pass in expressions. > > Signed-off-by: Gerd Hoffmann > --- > include/hw/virtio/virtio-input.h | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake -- Eric

Re: [Qemu-devel] [PATCH for-2.6] ivshmem: fix crash with ivshmem-plain

2016-04-12 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > "qemu -device ivshmem-plain" will crash, because it doesn't check that > 'memdev' was provided. > > Signed-off-by: Marc-André Lureau Oww! > --- > hw/misc/ivshmem.c | 19 ++- > 1 file changed, 18 insertions(+), 1

[Qemu-devel] windows displays an error msg each time i run qemu " qemu machine emulators and tools stop working "

2016-04-12 Thread Safa Hamza
hello i configure qemu on windows using mingw and msys , and im trying to run it so i use kernel zimage and a file system working perfectly on ubuntu this is the command export DTB="-dtb /vexpress-v2p-ca9.dtb" ./arm-softmmu/qemu-system-arm -M vexpress-a9 -kernel /zImage -initrd /rootfs_affiche.im

Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG

2016-04-12 Thread Alex Bennée
Sergey Fedorov writes: > On 05/04/16 18:32, Alex Bennée wrote: >> diff --git a/cpus.c b/cpus.c >> index 46732a5..8d27fb0 100644 >> --- a/cpus.c >> +++ b/cpus.c > > (snip) > >> @@ -146,6 +147,48 @@ typedef struct TimersState { >> } TimersState; >> >> static TimersState timers_state; >> +static

Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG

2016-04-12 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: mttcg-requ...@listserver.greensocs.com >> [mailto:mttcg-requ...@listserver.greensocs.com] >> On 12/04/16 15:50, KONRAD Frederic wrote: >> >> Yes, but users may like to have an option to disable MTTCG for some >> >> reason. I'm also concerned about icount mode: n

Re: [Qemu-devel] [Xen-devel] [PATCH v2 2/3] xenfb: move xen_rmb to the correct location

2016-04-12 Thread Wei Liu
On Tue, Apr 12, 2016 at 02:38:13PM +0100, Andrew Cooper wrote: > On 12/04/16 13:57, David Vrabel wrote: > > On 12/04/16 11:43, Wei Liu wrote: > >> It should be placed before first time producer and consumer are used. > > This change isn't necessary and is confusing as this is not what this > > barr

Re: [Qemu-devel] [Xen-devel] [PATCH v2 2/3] xenfb: move xen_rmb to the correct location

2016-04-12 Thread Andrew Cooper
On 12/04/16 13:57, David Vrabel wrote: > On 12/04/16 11:43, Wei Liu wrote: >> It should be placed before first time producer and consumer are used. > This change isn't necessary and is confusing as this is not what this > barrier is for. > > The barrier needs to be between the load of prod and the

[Qemu-devel] [PATCH v2 REPOST 1/2] Add dynamic module loading for block drivers

2016-04-12 Thread Richard W.M. Jones
From: Marc Marí Extend the current module interface to allow for block drivers to be loaded dynamically on request. The only block drivers that can be converted into modules are the drivers that don't perform any init operation except for registering themselves. This is why libiscsi has been dis

[Qemu-devel] [PATCH v2 REPOST 2/2] Add dynamic generation of module_block.h

2016-04-12 Thread Richard W.M. Jones
From: Marc Marí To simplify the addition of new block modules, add a script that generates include/qemu/module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí --- .gitignore |

[Qemu-devel] [PATCH v3 06/10] virtio: handle virtqueue_get_avail_bytes() errors

2016-04-12 Thread Stefan Hajnoczi
If the vring is invalid, tell the caller no bytes are available and mark the device broken. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 0c0d333..48f759e

[Qemu-devel] [PATCH v2 REPOST 0/2] Add dynamic module loading for block drivers

2016-04-12 Thread Richard W.M. Jones
This is a repost of the support for dynamically loaded block drivers. It is identical to how it was posted last summer, except that I have rebased it and checked that it still works. It was last posted here: https://lists.gnu.org/archive/html/qemu-devel/2015-09/threads.html#01995 Last time this

[Qemu-devel] [PATCH v3 07/10] virtio: use unsigned int for virtqueue_get_avail_bytes() index

2016-04-12 Thread Stefan Hajnoczi
The virtio code uses int, unsigned int, and uint16_t for virtqueue indices. The uint16_t is used for the low-level descriptor layout in virtio_ring.h while code that isn't concerned with descriptor layout can use unsigned int. Use of int is problematic because it can result in signed/unsigned com

[Qemu-devel] [PATCH for-2.6] ivshmem: fix crash with ivshmem-plain

2016-04-12 Thread marcandre . lureau
From: Marc-André Lureau "qemu -device ivshmem-plain" will crash, because it doesn't check that 'memdev' was provided. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshm

[Qemu-devel] [PATCH v3 09/10] virtio: handle virtqueue_num_heads() errors

2016-04-12 Thread Stefan Hajnoczi
If the avail ring index is bogus virtqueue_num_heads() must return -EINVAL. The only caller is virtqueue_get_avail_bytes(). Return saying no bytes are available when virtqueue_num_heads() fails. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 11 --- 1 file changed, 8 insertion

[Qemu-devel] [PATCH v3 05/10] virtio: handle virtqueue_map_desc() errors

2016-04-12 Thread Stefan Hajnoczi
Errors can occur during virtqueue_pop(), especially in virtqueue_map_desc(). In order to handle this we must unmap iov[] before returning NULL. The caller will consider the virtqueue empty and the virtio_error() call will have marked the device broken. Signed-off-by: Stefan Hajnoczi --- hw/vir

[Qemu-devel] [PATCH v3 08/10] virtio: handle virtqueue_read_next_desc() errors

2016-04-12 Thread Stefan Hajnoczi
Stop processing the vring if an avail ring index is invalid. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 45 - 1 file changed, 32 insertions(+), 13 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 493d6a7..58599cf 10

Re: [Qemu-devel] [Nbd] [PATCHv8] Improve documentation for TLS

2016-04-12 Thread Alex Bligh
Wouter, On 12 Apr 2016, at 14:01, Wouter Verhelst wrote: > It's not being applied because of this ;-) OK, I've sent a PATCHv9 with my suggested wording (so at least it doesn't make anything worse), but I really think we should avoid addressing further nits in the disconnection regime within a c

Re: [Qemu-devel] [PATCH 8/9] Add memfd based hostmem

2016-04-12 Thread Marc-André Lureau
- Original Message - > On Tue, 12 Apr 2016 13:55:28 +0200 > marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > Add a new memory backend, similar to hostmem-file, except that it > > doesn't need a file path, or hugepages directory permissions. It also > > try to en

[Qemu-devel] [PATCHv9] Improve documentation for TLS

2016-04-12 Thread Alex Bligh
* Call out TLS into a separate section * Add details of the TLS protocol itself * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can be initiated from either side (as required by the TLS standard I believe and as actually works in practice) * Clarify what is a requirem

  1   2   >