Re: [Qemu-devel] [libvirt-users] Sluggish performance with virtio and Win10

2016-02-18 Thread Martin Kletzander
On Fri, Feb 19, 2016 at 07:16:12AM +0100, John Obaterspok wrote: 2016-02-18 15:15 GMT+01:00 Martin Kletzander : On Thu, Feb 18, 2016 at 12:59:52PM +0100, John Obaterspok wrote: 2016-02-18 11:25 GMT+01:00 Martin Kletzander : On Thu, Feb 18, 2016 at 10:41:42AM +0100, John Obaterspok wrote: 2

Re: [Qemu-devel] [PATCH 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-02-18 Thread Peter Xu
Hi, Jan, On Fri, Feb 19, 2016 at 07:46:26AM +0100, Jan Kiszka wrote: > Hi Peter, > > On 2016-02-19 04:30, Peter Xu wrote: > > This patchset provide very basic functionalities for interrupt > > remapping (IR) support of the emulated Intel IOMMU device. > > Interesting. Some questions: > > - Were

Re: [Qemu-devel] [PATCH 0/8] virtio: allow migration with dataplane

2016-02-18 Thread Michael S. Tsirkin
On Sun, Feb 14, 2016 at 06:17:03PM +0100, Paolo Bonzini wrote: > Currently, dataplane threads are shut down during migration because > vring.c is not able to track dirty memory. However, all the relevant > parts of QEMU have been made thread-safe now, so we can drop vring.c > completely. With the

Re: [Qemu-devel] [PATCH 1/8] block-migration: acquire AioContext as necessary

2016-02-18 Thread Michael S. Tsirkin
ping Paolo - were you going to address these questions? Or did I miss it? On Tue, Feb 16, 2016 at 03:17:11PM +0800, Fam Zheng wrote: > On Sun, 02/14 18:17, Paolo Bonzini wrote: > > This is needed because dataplane will run during block migration as well. > > > > The block device migration code is

[Qemu-devel] [PATCH v3] usb: add pid check at the first of uhci_handle_td()

2016-02-18 Thread Gonglei
pid can be gotten from uhci device memory in uhci_handle_td(), so the guest can trigger assert qemu if we get an invalid pid. And the uhci spec 2.1.2 tells us The Host Controller sets Host Controller Process Error bit to 1 when it detects a fatal error and indicates that the Host Controller suffere

Re: [Qemu-devel] [PATCH v2] scripts/kvm/kvm_stat: Fix missing right parantheses and ".format(...)"

2016-02-18 Thread Janosch Frank
On 02/19/2016 03:20 AM, Fam Zheng wrote: > They seem to have snuck in when applying Janosch Frank > 's previous patch. > > Signed-off-by: Fam Zheng > > --- > v2: Also fix .format. [Janosch] > --- > scripts/kvm/kvm_stat | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] SUMMARY: Re: [RFC 1/1] nbd (specification): add NBD_CMD_WRITE_ZEROES command

2016-02-18 Thread Denis V. Lunev
On 02/18/2016 08:23 PM, Denis V. Lunev wrote: On 02/18/2016 07:35 PM, Eric Blake wrote: On 02/18/2016 02:18 AM, Roman Kagan wrote: On Wed, Feb 17, 2016 at 01:58:47PM -0700, Eric Blake wrote: On 02/17/2016 11:10 AM, Denis V. Lunev wrote: @@ -446,6 +448,11 @@ The following request types exist:

Re: [Qemu-devel] [PATCH] fw_cfg: unbreak migration compatibility for 2.4 and earlier machines

2016-02-18 Thread Gerd Hoffmann
On Do, 2016-02-18 at 20:31 +0100, Laszlo Ersek wrote: > When I reviewed Marc's fw_cfg DMA patches, I completely missed that the > way we set dma_enabled would break migration. Patch looks fine to me ... > Not tested: > * actual migration > * when board code doesn't request DMA support

Re: [Qemu-devel] [PATCH v8 0/5] add ACPI node for fw_cfg on pc and arm

2016-02-18 Thread Gerd Hoffmann
On Di, 2016-02-16 at 18:49 -0500, Gabriel L. Somlo wrote: > On Thu, Feb 11, 2016 at 05:06:00PM -0500, Gabriel L. Somlo wrote: > > Generate an ACPI DSDT node for fw_cfg on pc and arm guests. > > > > New since v7: > > > > - edited commit blurb on 3/5 to match updated content, i.e. that > >

Re: [Qemu-devel] [PATCH 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-02-18 Thread Jan Kiszka
Hi Peter, On 2016-02-19 04:30, Peter Xu wrote: > This patchset provide very basic functionalities for interrupt > remapping (IR) support of the emulated Intel IOMMU device. Interesting. Some questions: - Were you aware of http://git.kiszka.org/?p=qemu.git;a=shortlog;h=refs/heads/queues/vtd-intre

Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries

2016-02-18 Thread Greg Kurz
On Thu, 18 Feb 2016 21:00:38 +0100 Laurent Vivier wrote: > On 18/02/2016 12:32, Greg Kurz wrote: > > QEMU 2.4 broke the migration of old pseries machine with the addition > > of configuration sections, which are sent unconditionally. > > > > We assume that QEMU 2.3 is more deployed than any newe

Re: [Qemu-devel] [PATCH v2 7/9] i.MX: Add i.MX6 SOC implementation.

2016-02-18 Thread Jean-Christophe DUBOIS
Le 18/02/2016 22:46, Peter Maydell a écrit : On 18 February 2016 at 20:51, Jean-Christophe DUBOIS wrote: Le 16/02/2016 22:57, Peter Maydell a écrit : On 16 February 2016 at 21:47, Jean-Christophe DUBOIS wrote: In QEMU, other Cortex A9 (Versatilepb.c, Exynos, Zynq ...) are also setting has_el

Re: [Qemu-devel] flushing before updating pc.ram

2016-02-18 Thread TeLeMan
On Fri, Feb 19, 2016 at 12:53 AM, Egbert S. wrote: > I have here a case (over at GitHub unicorn-engine/unicorn > tests/unit/test_tb_x86.c) that is running a stack-based Alpha-Mixed sample > that contains an instruction that changed an operand of the next > instruction, the one that QEMU does not d

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-18 Thread David Gibson
On Thu, Feb 18, 2016 at 11:37:39AM +0100, Igor Mammedov wrote: > On Thu, 18 Feb 2016 14:39:52 +1100 > David Gibson wrote: > > > On Tue, Feb 16, 2016 at 11:36:55AM +0100, Igor Mammedov wrote: > > > On Mon, 15 Feb 2016 20:43:41 +0100 > > > Markus Armbruster wrote: > > > > > > > Igor Mammedov w

[Qemu-devel] [PATCH v5 5/6] s390/virtio-ccw: Add hotplug handler

2016-02-18 Thread Matthew Rosato
First consumer will be CPU hotplug, to update machine/cpu[n] links during cpu plug. Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio-ccw.c | 40 1 file changed, 40 insertions(+) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c i

[Qemu-devel] [PATCH v5 6/6] s390x/cpu: Allow hotplug of CPUs

2016-02-18 Thread Matthew Rosato
Implement cpu hotplug routine and add the machine hook. Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio-ccw.c | 1 + target-s390x/cpu.c | 45 + target-s390x/cpu.h | 1 + 3 files changed, 47 insertions(+) diff --git a/hw/s390x/

[Qemu-devel] [PATCH v5 4/6] s390x/cpu: Add CPU property links

2016-02-18 Thread Matthew Rosato
Link each CPUState as property machine/cpu[n] during initialization. Additionally, maintain an array of state pointers indexed by CPU id for fast lookup during interrupt handling. Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio.c | 26 +- 1 file changed, 17 inserti

[Qemu-devel] [PATCH v5 2/6] s390x/cpu: Set initial CPU state in common routine

2016-02-18 Thread Matthew Rosato
Both initial and hotplugged CPUs need to set the same initial state. Signed-off-by: Matthew Rosato Reviewed-by: David Hildenbrand --- hw/s390x/s390-virtio.c | 4 target-s390x/cpu.c | 2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/

[Qemu-devel] [PATCH v5 3/6] s390x/cpu: Move some CPU initialization into realize

2016-02-18 Thread Matthew Rosato
In preparation for hotplug, defer some CPU initialization until the device is actually being realized. Signed-off-by: Matthew Rosato --- target-s390x/cpu.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c index 603c2a1..8dfd063

[Qemu-devel] [PATCH v5 1/6] s390x/cpu: Cleanup init in preparation for hotplug

2016-02-18 Thread Matthew Rosato
Ensure a valid cpu_model is set upfront by setting the default value directly into the MachineState when none is specified. This is needed to ensure hotplugged CPUs share the same cpu_model. Signed-off-by: Matthew Rosato Reviewed-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 2 +- hw/

[Qemu-devel] [PATCH v5 0/6] Allow hotplug of s390 CPUs

2016-02-18 Thread Matthew Rosato
Changes from v4->v5: * Patch #3 - Drop static next_cpu_id (Igor) * Patch #4 - Drop register_cpustate in favor of machine hotplug handler. Re-write commit message as a result. (Igor) * Patch #5 - Revive hotplug handler code from previous patch set. Use plug callback to update property links in

[Qemu-devel] [PATCH 11/13] intel_iommu: add IR translation faults defines

2016-02-18 Thread Peter Xu
Adding translation fault definitions for interrupt remapping. Please refer to VT-d spec section 7.1. Signed-off-by: Peter Xu --- hw/i386/intel_iommu_internal.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h ind

[Qemu-devel] [PATCH 10/13] ioapic-common: add iommu for IOAPICCommonState

2016-02-18 Thread Peter Xu
When IR is enabled for IOMMU, each IOAPIC will belong to a specific intel IOMMU. This pointer will store the owner of current IOAPIC, which is always the default IOMMU device. Signed-off-by: Peter Xu --- hw/intc/ioapic_common.c | 2 ++ include/hw/i386/ioapic_internal.h | 3 +++ 2 files

[Qemu-devel] [PATCH 09/13] intel_iommu: provide helper function vtd_get_iommu

2016-02-18 Thread Peter Xu
Moves acpi_get_iommu() under VT-d to make it a public function. Signed-off-by: Peter Xu --- hw/i386/acpi-build.c | 17 ++--- hw/i386/intel_iommu.c | 13 + include/hw/i386/intel_iommu.h | 2 ++ 3 files changed, 17 insertions(+), 15 deletions(-) diff --gi

[Qemu-devel] [PATCH 08/13] intel_iommu: define several structs for IOMMU IR

2016-02-18 Thread Peter Xu
Several data structs are defined to better support the rest of the patches: IRTE to parse remapping table entries, and IOAPIC/MSI related structure bits to parse interrupt entries to be filled in by guest kernel. Signed-off-by: Peter Xu --- include/hw/i386/intel_iommu.h | 60

[Qemu-devel] [PATCH 06/13] intel_iommu: define interrupt remap table addr register

2016-02-18 Thread Peter Xu
Defined Interrupt Remap Table Address register to store IR table pointer. Also, do proper handling on global command register writes to store table pointer and its size. One more debug flag "DEBUG_IR" is added for interrupt remapping. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c |

[Qemu-devel] [PATCH 05/13] acpi: add DMAR scope definition for root IOAPIC

2016-02-18 Thread Peter Xu
To enable interrupt remapping for intel IOMMU device, each IOAPIC device in the system reported via ACPI MADT must be explicitly enumerated under one specific remapping hardware unit. This patch adds the root-complex IOAPIC into the default DMAR device. Please refer to VT-d spec 8.3.1.1 for more i

[Qemu-devel] [PATCH 13/13] intel_iommu: Add support for PCI MSI remap

2016-02-18 Thread Peter Xu
This patch enables interrupt remapping for PCI devices. To play the trick, one memory region "iommu_ir" is added as child region of the original iommu memory region, covering range 0xfeeX (which is the address range for APIC). All the writes to this range will be taken as MSI, and translation

[Qemu-devel] [PATCH 04/13] intel_iommu: set IR bit for ECAP register

2016-02-18 Thread Peter Xu
Enable IR in IOMMU Extended Capability register. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 4 hw/i386/intel_iommu_internal.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 4b0558e..79585d2 100644 --- a/hw/i386/in

[Qemu-devel] [PATCH 03/13] intel_iommu: allow queued invalidation for IR

2016-02-18 Thread Peter Xu
Queued invalidation is required for IR. This patch add basic support for interrupt cache invalidate requests. Since we currently have no IR cache implemented yet, we can just skip all interrupt cache invalidation requests for now. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 9 ++

[Qemu-devel] [PATCH 12/13] intel_iommu: ioapic: IR support for emulated IOAPIC

2016-02-18 Thread Peter Xu
This patch add the first device support for Intel IOMMU interrupt remapping, which is the default IOAPIC device created alongside with Q35 platform. This will be the first step along the way to fully enable IOMMU IR on x86 systems. Currently, only emluated IOAPIC is supported. This requires "kerne

[Qemu-devel] [PATCH 07/13] intel_iommu: handle interrupt remap enable

2016-02-18 Thread Peter Xu
Handle writting to IRE bit in global command register. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 62f0fa7..f1cb574 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386

[Qemu-devel] [PATCH 02/13] acpi: enable INTR for DMAR report structure

2016-02-18 Thread Peter Xu
In ACPI DMA remapping report structure, enable INTR flag when specified. Signed-off-by: Peter Xu --- hw/i386/acpi-build.c | 31 --- include/hw/i386/intel_iommu.h | 2 ++ 2 files changed, 26 insertions(+), 7 deletions(-) diff --git a/hw/i386/acpi-build.c b/h

[Qemu-devel] [PATCH 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-02-18 Thread Peter Xu
This patchset provide very basic functionalities for interrupt remapping (IR) support of the emulated Intel IOMMU device. By default, IR is disabled to be better compatible with current QEMU. To enable IR, we can using the following command to boot a IR-supported VM with basic network (still do no

[Qemu-devel] [PATCH 01/13] q35: add "int-remap" flag to enable intr

2016-02-18 Thread Peter Xu
One flag is added to specify whether to enable INTR for emulated IOMMU. By default, interrupt remapping is not supportted. To enable it, we should specify something like: $ qemu-system-x86_64 -M q35,iommu=on,int_remap=on To be more clear, the following command: $ qemu-system-x86_64 -M q35,iommu=

[Qemu-devel] [PATCH v2] scripts/kvm/kvm_stat: Fix missing right parantheses and ".format(...)"

2016-02-18 Thread Fam Zheng
They seem to have snuck in when applying Janosch Frank 's previous patch. Signed-off-by: Fam Zheng --- v2: Also fix .format. [Janosch] --- scripts/kvm/kvm_stat | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat index 3cf1181..769

Re: [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix missing right parantheses

2016-02-18 Thread Fam Zheng
On Thu, 02/18 12:42, Janosch Frank wrote: > On 02/17/2016 07:18 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > scripts/kvm/kvm_stat | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat > > index 3cf1181..517fbec

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-18 Thread Fam Zheng
On Thu, 02/18 16:41, Stefan Hajnoczi wrote: > On Thu, Feb 18, 2016 at 12:11:14PM +, Daniel P. Berrange wrote: > > On Wed, Feb 17, 2016 at 08:47:11PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > On 16.02.2016 20:09, Stefan Hajnoczi wrote: > > > >On Wed, Feb 10, 2016 at 10:10:04AM +,

Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-18 Thread Peter Xu
On Thu, Feb 18, 2016 at 06:10:21PM +0100, Andrea Bolognani wrote: > On Thu, 2016-02-18 at 17:52 +0100, Andrew Jones wrote: > > > Is this work on any of our todo list (or anyone has started the > > > prototyping)? > > >  > > > It seems reasonable to provide such a generic interface, rather than > >

[Qemu-devel] [RFC 0/1] riscv: Add full-system emulation support for the RISC-V Instruction Set Architecture (RV64G)

2016-02-18 Thread Sagar Karandikar
The patch in this RFC adds support for the RISC-V ISA [1] as a target. It has been tested booting Linux and FreeBSD, passes the RISC-V assembly test suite, and has had the riscv-torture tester running on it for a couple of weeks now without any issues arising. With this RFC, I mainly wanted to

[Qemu-devel] [PATCH v2 1/2] generic-loader: Add a generic loader

2016-02-18 Thread Alistair Francis
Add a generic loader to QEMU which can be used to load images or set memory values. This only supports ARM architectures at the moment. Signed-off-by: Alistair Francis --- V2: - Add maintainers entry - Perform bounds checking - Register and unregister the reset in the realise/unrealise Change

[Qemu-devel] [PATCH v2 2/2] docs: Add a generic loader explanation document

2016-02-18 Thread Alistair Francis
Signed-off-by: Alistair Francis --- docs/generic-loader.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 docs/generic-loader.txt diff --git a/docs/generic-loader.txt b/docs/generic-loader.txt new file mode 100644 index 000..69e262d --- /dev/null +++ b/doc

[Qemu-devel] [PATCH v2 0/2] Add a generic loader

2016-02-18 Thread Alistair Francis
This work is based on the original work by Li Guang with extra features added by Peter C and myself. The idea of this loader is to allow the user to load multiple images or values into QEMU at startup. Memory values can be loaded like this: -device loader,addr=0xfd1a0104,data=0x800e,data-len

Re: [Qemu-devel] [PATCHv7 4/9] slirp: Factorizing tcpiphdr structure with an union

2016-02-18 Thread Samuel Thibault
Hello, Just to make sure: we have not received comments on this patch. (that said, it's the most complex part of the series, so I'm not surprised if it takes more time :) ) Samuel Samuel Thibault, on Sun 14 Feb 2016 18:47:38 +0100, wrote: > From: Guillaume Subiron > > This patch factorizes th

Re: [Qemu-devel] [PATCHv7 9/9] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-02-18 Thread Samuel Thibault
Thomas Huth, on Wed 17 Feb 2016 12:59:04 +0100, wrote: > The IPv4 code seems to have a sanity check that the vhost address is > within the same net as specified with the "net=" parameter... maybe the > IPv6 part should have that, too? Or use the prefix from "ip6-net=" here > if ip6-host has not bee

Re: [Qemu-devel] [PATCH v4] hw/ppc/spapr: Implement the h_page_init hypercall

2016-02-18 Thread David Gibson
On Thu, Feb 18, 2016 at 10:15:54AM +0100, Thomas Huth wrote: > This hypercall either initializes a page with zeros, or copies > another page. > According to LoPAPR, the i-cache of the page should also be > flushed if using H_ICACHE_INVALIDATE or H_ICACHE_SYNCHRONIZE, > and the d-cache should be syn

Re: [Qemu-devel] [PATCH] spapr: initialize local Error pointer

2016-02-18 Thread David Gibson
On Thu, Feb 18, 2016 at 04:02:53PM +0100, Markus Armbruster wrote: > Greg Kurz writes: > > > This fixes a crash in the target QEMU during migration. > > > > Fixes: c5f54f3e31bf693f70a98d4d73ea5dbe05689857 > > Suggest to word that as "Broken in commit c5f54f3." > > > Signed-off-by: Greg Kurz >

Re: [Qemu-devel] [PATCH] ppc/kvm: Use error_report() instead of cpu_abort() for user-triggerable errors

2016-02-18 Thread David Gibson
On Thu, Feb 18, 2016 at 10:01:38PM +0100, Thomas Huth wrote: > Setting the KVM_CAP_PPC_PAPR capability can fail if either the KVM > kernel module does not support it, or if the specified vCPU type > is not a 64-bit Book3-S CPU type. For example, the user can trigger > it easily with "-M pseries -cp

Re: [Qemu-devel] [PATCH] ppc/kvm: Tell the user what might be wrong when using bad CPU types with kvm-hv

2016-02-18 Thread David Gibson
On Thu, Feb 18, 2016 at 03:13:52PM -0700, Eric Blake wrote: > On 02/18/2016 02:01 PM, Thomas Huth wrote: > > Using a CPU type that does not match the host is not possible when using > > the kvm-hv kernel module - the PVR is checked in the kernel function > > kvm_arch_vcpu_ioctl_set_sregs_hv() and r

Re: [Qemu-devel] [PATCHv7 8/9] slirp: Adding IPv6 address for DNS relay

2016-02-18 Thread Samuel Thibault
Samuel Thibault, on Wed 17 Feb 2016 10:36:35 +0100, wrote: > That's now like this in my tree: > > diff --git a/slirp/ip6.h b/slirp/ip6.h > index 9f7623f..9e4844e 100644 > --- a/slirp/ip6.h > +++ b/slirp/ip6.h > @@ -70,7 +70,11 @@ static inline bool in6_equal_mach(const struct in6_addr *a, >||

Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries

2016-02-18 Thread David Gibson
On Thu, Feb 18, 2016 at 12:32:11PM +0100, Greg Kurz wrote: > QEMU 2.4 broke the migration of old pseries machine with the addition > of configuration sections, which are sent unconditionally. > > We assume that QEMU 2.3 is more deployed than any newer release (based on > the versions currently shi

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-18 Thread Alistair Francis
On Thu, Feb 18, 2016 at 3:07 PM, Peter Crosthwaite wrote: > On Thu, Feb 18, 2016 at 1:47 PM, Paolo Bonzini wrote: >> >> >> On 18/02/2016 10:56, Markus Armbruster wrote: >>> Alistair Francis writes: >>> If the device being added when running qdev_device_add() has a reset function, regis

Re: [Qemu-devel] [RFC PATCH] tests/pxe-test: add pxe vhost user test

2016-02-18 Thread Michael S. Tsirkin
On Thu, Feb 18, 2016 at 07:05:47PM +0200, Victor Kaplansky wrote: > Add one more testcase to pxe-test for checking vhost-user > interface. The test is based on spawning vhost-user-bridge > process in addition to qemu under test. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Victor Kaplans

Re: [Qemu-devel] [PATCH v2 1/1] hyperv: cpu hotplug fix with HyperV enabled

2016-02-18 Thread Eduardo Habkost
On Thu, Feb 18, 2016 at 07:50:59PM +0300, Denis V. Lunev wrote: > On 02/17/2016 11:31 PM, Eduardo Habkost wrote: > >On Sat, Feb 13, 2016 at 03:00:15PM +0300, Denis V. Lunev wrote: > >>With Hyper-V enabled CPU hotplug stops working. The CPU appears in device > >>manager on Windows but does not appea

Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code

2016-02-18 Thread Eduardo Habkost
On Thu, Feb 18, 2016 at 01:39:39PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > This is another attempt to remove old q35 machine code. Now I am > > also removing unused compat code to demonstrate the benefit of > > throwing away the old code that nobody uses. > > > > Eduardo H

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-18 Thread Peter Crosthwaite
On Thu, Feb 18, 2016 at 1:47 PM, Paolo Bonzini wrote: > > > On 18/02/2016 10:56, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> If the device being added when running qdev_device_add() has >>> a reset function, register it so that it can be called. >>> >>> Signed-off-by: Alistair Fra

Re: [Qemu-devel] [PATCH] ppc/kvm: Tell the user what might be wrong when using bad CPU types with kvm-hv

2016-02-18 Thread Eric Blake
On 02/18/2016 02:01 PM, Thomas Huth wrote: > Using a CPU type that does not match the host is not possible when using > the kvm-hv kernel module - the PVR is checked in the kernel function > kvm_arch_vcpu_ioctl_set_sregs_hv() and rejected with -EINVAL if it > does not match the host. > However, whe

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-02-18 Thread Cole Mickens
Unfortunately, VHDX is not supported in Azure. I would be happy to help test out any patches. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1490611 Title: Using qemu >=2.2.1 to convert raw->VHD (f

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-18 Thread Paolo Bonzini
On 18/02/2016 10:56, Markus Armbruster wrote: > Alistair Francis writes: > >> If the device being added when running qdev_device_add() has >> a reset function, register it so that it can be called. >> >> Signed-off-by: Alistair Francis >> --- >> >> qdev-monitor.c | 2 ++ >> 1 file changed, 2

Re: [Qemu-devel] [PATCH v2 7/9] i.MX: Add i.MX6 SOC implementation.

2016-02-18 Thread Peter Maydell
On 18 February 2016 at 20:51, Jean-Christophe DUBOIS wrote: > Le 16/02/2016 22:57, Peter Maydell a écrit : > > On 16 February 2016 at 21:47, Jean-Christophe DUBOIS > wrote: > > In QEMU, other Cortex A9 (Versatilepb.c, Exynos, Zynq ...) are also setting > has_el3 to false ... > > So these generall

[Qemu-devel] [PATCH v2 0/3] add missing virtio aliases

2016-02-18 Thread Sascha Silbe
Split out from the series fixing qemu-iotest 140 on s390x [1]. This series makes crafting qemu command lines that work across multiple (virtio-supporting) platforms at lot easier. Changes since the original series: - included patch to improve the error message when the target device class of an

[Qemu-devel] [PATCH v2 2/3] qdev-monitor: sort alias table by typename

2016-02-18 Thread Sascha Silbe
Sort the alias table by typename so it's easier to see which aliases exist. Signed-off-by: Sascha Silbe --- v1->v2: Added comment asking devs to keep table sorted --- qdev-monitor.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.

[Qemu-devel] [PATCH v2 3/3] qdev-monitor: add missing aliases for virtio device classes

2016-02-18 Thread Sascha Silbe
virtio-{blk,balloon,net,serial} are aliases for their actual, architecture-dependent implementations (*-ccw on s390x, *-pci on other architectures supporting virtio). This makes it a lot easier to craft qemu invocations that work on all supported architectures. Complete the set to cover all existin

[Qemu-devel] [PATCH v2 1/3] qdev-monitor: improve error message when alias device is unavailable

2016-02-18 Thread Sascha Silbe
When trying to instantiate an alias that points to a device class that doesn't exist, the error message looks like qemu misunderstood the request: $ s390x-softmmu/qemu-system-s390x -device virtio-gpu qemu-system-s390x: -device virtio-gpu: 'virtio-gpu-ccw' is not a valid device model name Special-

Re: [Qemu-devel] [PATCH 2/3] qdev-monitor: add missing aliases for virtio-{9p, balloon, rng, scsi}

2016-02-18 Thread Sascha Silbe
Dear Conny, Cornelia Huck writes: [virtio-{gpu,input,input-hid,input-host,keyboard,mouse,tablet}] > [For laughs and giggles, I have wired up all of these devices for ccw. > Excluding input-host (for which I did not have a suitable evdev), I can > specify the various devices on the commandline an

[Qemu-devel] [PATCH] ppc/kvm: Tell the user what might be wrong when using bad CPU types with kvm-hv

2016-02-18 Thread Thomas Huth
Using a CPU type that does not match the host is not possible when using the kvm-hv kernel module - the PVR is checked in the kernel function kvm_arch_vcpu_ioctl_set_sregs_hv() and rejected with -EINVAL if it does not match the host. However, when the user tries to specify a non-matching CPU type,

[Qemu-devel] [PATCH] ppc/kvm: Use error_report() instead of cpu_abort() for user-triggerable errors

2016-02-18 Thread Thomas Huth
Setting the KVM_CAP_PPC_PAPR capability can fail if either the KVM kernel module does not support it, or if the specified vCPU type is not a 64-bit Book3-S CPU type. For example, the user can trigger it easily with "-M pseries -cpu G2leLS" when using the kvm-pr kernel module. So the error should no

Re: [Qemu-devel] [PATCH v2 7/9] i.MX: Add i.MX6 SOC implementation.

2016-02-18 Thread Jean-Christophe DUBOIS
Le 16/02/2016 22:57, Peter Maydell a écrit : On 16 February 2016 at 21:47, Jean-Christophe DUBOIS wrote: In QEMU, other Cortex A9 (Versatilepb.c, Exynos, Zynq ...) are also setting has_el3 to false ... So these generally are the "legacy" platforms which were added before we ever had EL3 suppor

[Qemu-devel] [PATCH v2 2/2] qemu-iotests: 140: make description slightly more verbose

2016-02-18 Thread Sascha Silbe
Describe in a little more detail what the test is supposed to achieve. Signed-off-by: Sascha Silbe --- Max, does this reflect your intentions well enough? I took the liberty of re-using some of your review comments to extend the description. v1->v2: new patch tests/qemu-iotests/140 | 6 +-

[Qemu-devel] [PATCH v2 0/2] qemu-iotests: fix 140 on s390x

2016-02-18 Thread Sascha Silbe
Yet another IDE-using test crept in (commit 16dee418). Fix it by disabling the implicit drive. v1->v2: - don't use any drive at all instead of replacing IDE with virtio-scsi - split off virtio alias patch into separate series (no longer needed in this one) - add patch to improve description of q

[Qemu-devel] [PATCH v2 1/2] qemu-iotests: 140: don't use IDE device

2016-02-18 Thread Sascha Silbe
IDE is only implemented by very few architectures (mostly PC). The test doesn't actually need a block device attached to the BlockBackend, so just drop it and adjust the reference output accordingly. Fixes: 16dee418 ("iotests: Add test for eject under NBD server") Signed-off-by: Sascha Silbe ---

Re: [Qemu-devel] [PATCH v11 00/15] prune some QAPI visitor cruft (was qapi cleanups subset E)

2016-02-18 Thread Eric Blake
On 02/18/2016 01:08 PM, Markus Armbruster wrote: > Eric Blake writes: > >> I'm still working on my documentation patches for QAPI visitors >> (https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg03504.html), >> but am finding it easier to nuke bad code up front than to document >> that it is

Re: [Qemu-devel] [PATCH v4 4/5] s390x/cpu: Add functions to register CPU state

2016-02-18 Thread Matthew Rosato
On 02/18/2016 04:36 AM, Igor Mammedov wrote: > On Wed, 17 Feb 2016 15:12:34 -0500 > Matthew Rosato wrote: > >> Introduce s390_register_cpustate, which will set the >> machine/cpu[n] link with the current CPU state. Additionally, >> maintain an array of state pointers indexed by CPU id for fast l

Re: [Qemu-devel] [PATCH v11 03/15] qapi: Forbid 'any' inside an alternate

2016-02-18 Thread Eric Blake
On 02/18/2016 10:03 AM, Markus Armbruster wrote: >>> Could use a test for alternate member of alternate type. >> >> One step ahead of you: commit 3d0c4829 added the test >> alternate-nested.json, and commits 44bd1276 and dd883c6f fixed the >> parser to reject it (first by a hard-coded check, then

Re: [Qemu-devel] [PATCH 7/8] all: Clean up includes

2016-02-18 Thread Peter Maydell
On 18 February 2016 at 19:16, Eric Blake wrote: > On 02/18/2016 11:05 AM, Peter Maydell wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes. >> >> Signed-off-by: Peter May

Re: [Qemu-devel] [PATCH 4/8] scripts/clean-includes: Enhance to handle header files

2016-02-18 Thread Peter Maydell
On 18 February 2016 at 19:04, Eric Blake wrote: > On 02/18/2016 11:05 AM, Peter Maydell wrote: >> Enhance clean-includes to handle header files as well as .c source >> files. For headers we merely remove all the redundant #include >> lines, including any includes of qemu/osdep.h itself. >> >> Ther

[Qemu-devel] [PULL 10/13] device_tree: qemu_fdt_getprop_cell converted to use the error API

2016-02-18 Thread Alex Williamson
From: Eric Auger This patch aligns the prototype with qemu_fdt_getprop. The caller can choose whether the function self-asserts on error (passing &error_fatal as Error ** argument, corresponding to the legacy behavior), or behaves differently such as simply output a message. In this later case t

Re: [Qemu-devel] [PATCH v11 00/15] prune some QAPI visitor cruft (was qapi cleanups subset E)

2016-02-18 Thread Markus Armbruster
Eric Blake writes: > I'm still working on my documentation patches for QAPI visitors > (https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg03504.html), > but am finding it easier to nuke bad code up front than to document > that it is bad only to later nuke it. So this pulls bits and pieces

Re: [Qemu-devel] [PATCH 8/8] include: Clean up includes

2016-02-18 Thread Peter Maydell
On 18 February 2016 at 19:54, Eric Blake wrote: > On 02/18/2016 11:05 AM, Peter Maydell wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes. >> >> NB: If this commit break

[Qemu-devel] [PULL 09/13] device_tree: qemu_fdt_getprop converted to use the error API

2016-02-18 Thread Alex Williamson
From: Eric Auger Current qemu_fdt_getprop exits if the property is not found. It is sometimes needed to read an optional property, in which case we do not wish to exit but simply returns a null value. This patch converts qemu_fdt_getprop to accept an Error **, and existing users are converted to

[Qemu-devel] [PULL 08/13] device_tree: introduce qemu_fdt_node_path

2016-02-18 Thread Alex Williamson
From: Eric Auger This new helper routine returns a NULL terminated array of node paths matching a node name and a compat string. Signed-off-by: Eric Auger Reviewed-by: Peter Maydell Signed-off-by: Alex Williamson --- device_tree.c| 51 +++

[Qemu-devel] [PULL 12/13] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation

2016-02-18 Thread Alex Williamson
From: Eric Auger This patch allows the instantiation of the vfio-amd-xgbe device from the QEMU command line (-device vfio-amd-xgbe,host=""). The guest is exposed with a device tree node that combines the description of both XGBE and PHY (representation supported from 4.2 onwards kernel): Documen

[Qemu-devel] [PULL 11/13] hw/arm/sysbus-fdt: helpers for clock node generation

2016-02-18 Thread Alex Williamson
From: Eric Auger Some passthrough'ed devices depend on clock nodes. Those need to be generated in the guest device tree. This patch introduces some helpers to build a clock node from information retrieved in the host device tree. - copy_properties_from_host copies properties from a host device t

[Qemu-devel] [PULL 07/13] device_tree: introduce load_device_tree_from_sysfs

2016-02-18 Thread Alex Williamson
From: Eric Auger This function returns the host device tree blob from sysfs (/proc/device-tree). It uses a recursive function inspired from dtc read_fstree. Signed-off-by: Eric Auger Reviewed-by: Peter Maydell Signed-off-by: Alex Williamson --- device_tree.c| 100 +++

[Qemu-devel] [PULL 06/13] hw/vfio/platform: amd-xgbe device

2016-02-18 Thread Alex Williamson
From: Eric Auger This patch introduces the amd-xgbe VFIO platform device. It allows the guest to do passthrough on a device exposing an "amd,xgbe-seattle-v1a" compat string. Signed-off-by: Eric Auger Reviewed-by: Alex Bennée Signed-off-by: Alex Williamson --- hw/vfio/Makefile.objs

[Qemu-devel] [PULL 04/13] pcie_aer: expose pcie_aer_msg() interface

2016-02-18 Thread Alex Williamson
From: Chen Fan For vfio device, we need to propagate the aer error to Guest OS. we use the pcie_aer_msg() to send aer error to guest. Signed-off-by: Chen Fan Reviewed-by: Michael S. Tsirkin Signed-off-by: Alex Williamson --- hw/pci/pcie_aer.c |2 +- include/hw/pci/pcie_aer.h |

[Qemu-devel] [PULL 03/13] aer: impove pcie_aer_init to support vfio device

2016-02-18 Thread Alex Williamson
From: Chen Fan pcie_aer_init was used to emulate an aer capability for pcie device, but for vfio device, the aer config space size is mutable and is not always equal to PCI_ERR_SIZEOF(0x48). it depends on where the TLP Prefix register required, so here we add a size argument. Signed-off-by: Chen

[Qemu-devel] [PULL 05/13] vfio/pci: replace 1 with PCI_CAP_LIST_NEXT to make code self-explain

2016-02-18 Thread Alex Williamson
From: Wei Yang Use the macro PCI_CAP_LIST_NEXT instead of 1, so that the code would be more self-explain. This patch makes this change and also fixs one typo in comment. Signed-off-by: Wei Yang Signed-off-by: Alex Williamson --- hw/vfio/pci.c |8 1 file changed, 4 insertions(+),

[Qemu-devel] [PULL 13/13] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check

2016-02-18 Thread Alex Williamson
From: Eric Auger qemu_fdt_setprop asserts in case of error hence no need to check the returned value. Signed-off-by: Eric Auger Reviewed-by: Peter Maydell Signed-off-by: Alex Williamson --- hw/arm/sysbus-fdt.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff

[Qemu-devel] [PULL 02/13] vfio: make the 4 bytes aligned for capability size

2016-02-18 Thread Alex Williamson
From: Chen Fan this function search the capability from the end, the last size should 0x100 - pos, not 0xff - pos. Signed-off-by: Chen Fan Reviewed-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Alex Williamson --- hw/vfio/pci.c |3 ++- 1 file changed, 2 insertions(

[Qemu-devel] [PULL 00/13] VFIO updates 2016-02-18

2016-02-18 Thread Alex Williamson
The following changes since commit dd5e38b19d7cb07d317e1285941d8245c01da540: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20160218-1' into staging (2016-02-18 15:20:35 +) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git

[Qemu-devel] [PULL 01/13] pcie: modify the capability size assert

2016-02-18 Thread Alex Williamson
From: Chen Fan Device's Offset and size can reach PCIE_CONFIG_SPACE_SIZE, fix the corresponding assert. Signed-off-by: Chen Fan Reviewed-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Alex Williamson --- hw/pci/pcie.c |2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [Qemu-devel] [PATCH 0/8] more include cleaning

2016-02-18 Thread Eric Blake
On 02/18/2016 11:05 AM, Peter Maydell wrote: > This patchset makes more progress with with cleaning our > include use and is hopefully the last of the big ones > (there are some other minor fixups that can be done after). > > Patch 1 is already in Andreas' QOM tree but I include it > for convenien

Re: [Qemu-devel] [PATCH v1 0/2] Add a generic loader

2016-02-18 Thread Peter Maydell
On 18 February 2016 at 19:02, Alistair Francis wrote: > On Thu, Feb 18, 2016 at 10:27 AM, Hollis Blanchard > wrote: >> I understand the part about loading multiple files, but why would I want to >> load a kernel with this loader, instead of the -kernel option? > > If you just want to load a kerne

Re: [Qemu-devel] [PATCH v11 12/15] qapi: Don't box struct branch of alternate

2016-02-18 Thread Eric Blake
On 02/18/2016 11:56 AM, Markus Armbruster wrote: > Better, but the sentence is long enough to confuse even a German. What > about: lol > > The corresponding spot in qapi-visit.c calls visit_type_FOO(), which > first calls visit_start_struct() to allocate or deallocate the member >

Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries

2016-02-18 Thread Laurent Vivier
On 18/02/2016 12:32, Greg Kurz wrote: > QEMU 2.4 broke the migration of old pseries machine with the addition > of configuration sections, which are sent unconditionally. > > We assume that QEMU 2.3 is more deployed than any newer release (based on > the versions currently shipped by most distro

Re: [Qemu-devel] [PATCH v3 2/2] migration: allow machine to enforce configuration section migration

2016-02-18 Thread Laurent Vivier
On 18/02/2016 12:32, Greg Kurz wrote: > Migration of pseries-2.3 doesn't have configuration section. Unfortunately, > QEMU 2.4/2.4.1/2.5 are buggy and always stream and expect the configuration > section, and break migration both ways. > > This patch introduces a property which allows to enforce

Re: [Qemu-devel] [PATCH v3 1/2] spapr: skip configuration section during migration of older machines

2016-02-18 Thread Laurent Vivier
On 18/02/2016 12:32, Greg Kurz wrote: > Since QEMU 2.4, we have a configuration section in the migration stream. > This must be skipped for older machines, like it is already done for x86. > > This patch fixes the migration of pseries-2.3 from/to QEMU 2.3, but it > breaks migration of the same m

Re: [Qemu-devel] [PATCH 8/8] include: Clean up includes

2016-02-18 Thread Eric Blake
On 02/18/2016 11:05 AM, Peter Maydell wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > NB: If this commit breaks compilation for your out-of-tree > patchseries or for

Re: [Qemu-devel] [PATCH] target-mips: Stop using uint_fast*_t types in r4k_tlb_t struct

2016-02-18 Thread Leon Alrae
On 18/02/16 11:51, Peter Maydell wrote: > On 2 February 2016 at 10:49, Leon Alrae wrote: >> On 25/01/16 17:40, Peter Maydell wrote: >>> The r4k_tlb_t structure uses the uint_fast*_t types. Most of these >>> uses are in bitfields and are thus pointless, because the bitfield >>> itself specifies the

  1   2   3   4   >