On Thu, Feb 18, 2016 at 01:39:39PM +0100, Markus Armbruster wrote: > Eduardo Habkost <ehabk...@redhat.com> writes: > > > This is another attempt to remove old q35 machine code. Now I am > > also removing unused compat code to demonstrate the benefit of > > throwing away the old code that nobody uses. > > > > Eduardo Habkost (5): > > q35: Remove old machine versions > > machine: Remove no_tco field > > ich9: Remove enable_tco arguments from init functions > > q35: Remove unused q35-acpi-dsdt.aml file > > q35: No need to check gigabyte_align > > Reviewed-by: Markus Armbruster <arm...@redhat.com> > > Followup questions: > > * Can pcmc->pci_enabled be false in pc_q35_init()?
No, but I am trying to keep pc_q35_init() code closer to pc_piix.c:pc_init1() to make future code unification easier. > > * Likewise, pcmc->smbios_defaults? Ditto. However, if other developers think otherwise and would like to make q35_init() simpler in the meantime, I won't object to patches removing the "if" lines. -- Eduardo
