Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files

2015-10-20 Thread Pavel Fedin
Hello! > -Original Message- > From: Shlomo Pongratz [mailto:shlomopongr...@gmail.com] > Sent: Wednesday, October 21, 2015 6:09 AM > To: qemu-devel@nongnu.org > Cc: p.fe...@samsung.com; peter.mayd...@linaro.org; eric.au...@linaro.org; > shannon.z...@linaro.org; imamm...@redhat.com; ash...@

Re: [Qemu-devel] [PATCH 1/1] vhost: set the correct queue index in case of migration with multiqueue

2015-10-20 Thread Jason Wang
On 10/20/2015 09:33 PM, Michael S. Tsirkin wrote: > On Mon, Oct 19, 2015 at 02:59:27PM +0200, Thibaut Collet wrote: >> When a live migration is started the log address to mark dirty pages is >> provided >> to the vhost backend through the vhost_dev_set_log function. >> This function is called fo

[Qemu-devel] [PATCH v5 08/12] block: Add "drained begin/end" for transactional blockdev-backup

2015-10-20 Thread Fam Zheng
Similar to the previous patch, make sure that external events are not dispatched during transaction operations. Signed-off-by: Fam Zheng --- blockdev.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 0a7848b..52f44b2 100644 --- a/blockdev

[Qemu-devel] [PATCH v5 10/12] block: Introduce BlockDriver.bdrv_drain callback

2015-10-20 Thread Fam Zheng
Drivers can have internal request sources that generate IO, like the need_check_timer in QED. Since we want quiesced periods that contain nested event loops in block layer, we need to have a way to disable such event sources. Block drivers must implement the "bdrv_drain" callback if it has any int

[Qemu-devel] [PATCH v5 07/12] block: Add "drained begin/end" for transactional backup

2015-10-20 Thread Fam Zheng
This ensures the atomicity of the transaction by avoiding processing of external requests such as those from ioeventfd. Move the assignment to state->bs up right after bdrv_drained_begin, so that we can use it in the clean callback. The abort callback will still check bs->job and state->job, so it

[Qemu-devel] [PATCH v5 09/12] block: Add "drained begin/end" for internal snapshot

2015-10-20 Thread Fam Zheng
This ensures the atomicity of the transaction by avoiding processing of external requests such as those from ioeventfd. state->bs is assigned right after bdrv_drained_begin. Because it was used as the flag for deletion or not in abort, now we need a separate flag - InternalSnapshotState.created.

[Qemu-devel] [PATCH v5 06/12] block: Add "drained begin/end" for transactional external snapshot

2015-10-20 Thread Fam Zheng
This ensures the atomicity of the transaction by avoiding processing of external requests such as those from ioeventfd. Signed-off-by: Fam Zheng --- blockdev.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 35e5719..e4a5eb4 100644 --

[Qemu-devel] [PATCH v5 05/12] block: Introduce "drained begin/end" API

2015-10-20 Thread Fam Zheng
The semantics is that after bdrv_drained_begin(bs), bs will not get new external requests until the matching bdrv_drained_end(bs). Signed-off-by: Fam Zheng --- block/io.c| 17 + include/block/block.h | 21 + include/block/block_int.h | 2 +

[Qemu-devel] [PATCH v5 12/12] tests: Add test case for aio_disable_external

2015-10-20 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/test-aio.c | 24 1 file changed, 24 insertions(+) diff --git a/tests/test-aio.c b/tests/test-aio.c index 03cd45d..1623803 100644 --- a/tests/test-aio.c +++ b/tests/test-aio.c @@ -374,6 +374,29 @@ static void test_flush_event_notifier(vo

[Qemu-devel] [PATCH v5 03/12] dataplane: Mark host notifiers' client type as "external"

2015-10-20 Thread Fam Zheng
They will be excluded by type in the nested event loops in block layer, so that unwanted events won't be processed there. Signed-off-by: Fam Zheng --- hw/block/dataplane/virtio-blk.c | 5 ++--- hw/scsi/virtio-scsi-dataplane.c | 18 -- 2 files changed, 10 insertions(+), 13 deleti

[Qemu-devel] [PATCH v5 04/12] aio: introduce aio_{disable, enable}_external

2015-10-20 Thread Fam Zheng
Signed-off-by: Fam Zheng --- aio-posix.c | 3 ++- aio-win32.c | 3 ++- include/block/aio.h | 37 + 3 files changed, 41 insertions(+), 2 deletions(-) diff --git a/aio-posix.c b/aio-posix.c index f0f9122..0467f23 100644 --- a/aio-posix.c +++ b/

[Qemu-devel] [PATCH v5 11/12] qed: Implement .bdrv_drain

2015-10-20 Thread Fam Zheng
The "need_check_timer" is used to clear the "NEED_CHECK" flag in the image header after a grace period once metadata update has finished. In compliance to the bdrv_drain semantics we should make sure it remains deleted once .bdrv_drain is called. Call the qed_need_check_timer_cb manually to update

[Qemu-devel] [PATCH v5 02/12] nbd: Mark fd handlers client type as "external"

2015-10-20 Thread Fam Zheng
So we could distinguish it from internal used fds, thus avoid handling unwanted events in nested aio polls. Signed-off-by: Fam Zheng --- nbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nbd.c b/nbd.c index fbc66be..dab1ebb 100644 --- a/nbd.c +++ b/nbd.c @@ -1446,7 +1

[Qemu-devel] [PATCH v5 01/12] aio: Add "is_external" flag for event handlers

2015-10-20 Thread Fam Zheng
All callers pass in false, and the real external ones will switch to true in coming patches. Signed-off-by: Fam Zheng --- aio-posix.c | 6 - aio-win32.c | 5 async.c | 3 ++- block/curl.c| 14 +---

[Qemu-devel] [PATCH v5 00/12] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end

2015-10-20 Thread Fam Zheng
v5: Rebase onto Kevin's block tree. v4: Rebase on to master so fix the "bdrv_move_feature_fields" issue. v3: Call bdrv_drain unconditionally in bdrv_drained_begin. Document the internal I/O implications between bdrv_drain_begin and end. The nested aio_poll()'s in block layer has a bug that n

Re: [Qemu-devel] [PATCH v1 0/6] PMA phase 2 - per CPU address spaces

2015-10-20 Thread Peter Crosthwaite
On Tue, Oct 20, 2015 at 1:46 PM, Peter Maydell wrote: > On 20 October 2015 at 19:46, Peter Crosthwaite > wrote: >> On Tue, Oct 20, 2015 at 7:59 AM, Peter Maydell >> wrote: >>> Just to let you know, I'm taking some of these patches into >>> a series I'm working on for multiple address-space supp

Re: [Qemu-devel] [PATCH v4 00/12] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end

2015-10-20 Thread Fam Zheng
On Tue, 10/20 16:17, Kevin Wolf wrote: > Am 20.10.2015 um 07:16 hat Fam Zheng geschrieben: > > v4: Rebase on to master so fix the "bdrv_move_feature_fields" issue. > > > > v3: Call bdrv_drain unconditionally in bdrv_drained_begin. > > Document the internal I/O implications between bdrv_drain_b

Re: [Qemu-devel] [PATCH v9 04/17] vnc: hoist allocation of VncBasicInfo to callers

2015-10-20 Thread Eric Blake
On 10/20/2015 01:38 AM, Markus Armbruster wrote: > Eric Blake writes: > >> A future qapi patch will rework generated structs with a base >> class to be unboxed. In preparation for that, change the code >> that allocates then populates an info struct to instead merely >> populate the fields of an

Re: [Qemu-devel] [PATCH 8/8] i.MX: Standardize i.MX GPT debug

2015-10-20 Thread Peter Crosthwaite
On Tue, Oct 20, 2015 at 2:20 PM, Jean-Christophe Dubois wrote: > The goal is to have debug code always compiled during build. > > Signed-off-by: Jean-Christophe Dubois > --- > hw/timer/imx_gpt.c | 40 +++- > 1 file changed, 15 insertions(+), 25 deletions(-) >

Re: [Qemu-devel] [PATCH 4/8] i.MX: Standardize i.MX AVIC debug

2015-10-20 Thread Peter Crosthwaite
On Tue, Oct 20, 2015 at 2:20 PM, Jean-Christophe Dubois wrote: > The goal is to have debug code always compiled during build. > > Signed-off-by: Jean-Christophe Dubois > --- > hw/intc/imx_avic.c | 40 > 1 file changed, 16 insertions(+), 24 deletions(-) >

Re: [Qemu-devel] [PATCH 3/8] i.MX: Standardize i.MX I2C debug

2015-10-20 Thread Peter Crosthwaite
On Tue, Oct 20, 2015 at 2:19 PM, Jean-Christophe Dubois wrote: > The goal is to have debug code always compiled during build. > > Signed-off-by: Jean-Christophe Dubois > --- > hw/i2c/imx_i2c.c | 25 + > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/hw

Re: [Qemu-devel] [PATCH 0/8] i.MX: Standardize debug code

2015-10-20 Thread Peter Crosthwaite
On Tue, Oct 20, 2015 at 2:19 PM, Jean-Christophe Dubois wrote: > We fix all i.MX driver files to use the same type of debug code. > > The goal is to have debug code always compiled during build. > It goes beyond that, it that the logs are now going to be way easier to read with a consistent forma

Re: [Qemu-devel] [PATCH 1/8] i.MX: Standardize i.MX serial debug.

2015-10-20 Thread Peter Crosthwaite
On Tue, Oct 20, 2015 at 2:19 PM, Jean-Christophe Dubois wrote: > The goal is to have debug code always compiled during build. > Elaborate message to indicate that you convert some messages to LOG_GUEST_ERROR and LOG_UNIMP as appropriate, obsoleting the need for IPRINTF. > Signed-off-by: Jean-Chr

Re: [Qemu-devel] [PATCH v9 04/17] vnc: hoist allocation of VncBasicInfo to callers

2015-10-20 Thread Eric Blake
On 10/20/2015 08:46 AM, Markus Armbruster wrote: > Gerd Hoffmann writes: > >> Hi, >> -static VncBasicInfo *vnc_basic_info_get(struct sockaddr_storage *sa, -socklen_t salen) +static void vnc_basic_info_get(struct sockaddr_storage *sa, +

Re: [Qemu-devel] [PATCH v9 03/17] qapi: Reserve 'u' and 'has[-_]*' member names

2015-10-20 Thread Eric Blake
On 10/19/2015 11:19 AM, Markus Armbruster wrote: > I'm not quite comfortable with reserving 'u' now, becaue I feel we > haven't fully explored the design space for avoiding branch - member > clashes. > > I still like the basic idea to give the unnamed union a name. It needs > to be a short one,

[Qemu-devel] [PATCH 8/8] i.MX: Standardize i.MX GPT debug

2015-10-20 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. Signed-off-by: Jean-Christophe Dubois --- hw/timer/imx_gpt.c | 40 +++- 1 file changed, 15 insertions(+), 25 deletions(-) diff --git a/hw/timer/imx_gpt.c b/hw/timer/imx_gpt.c index 4bac67d..b217d86

[Qemu-devel] [PATCH 6/8] i.MX: Standardize i.MX FEC debug

2015-10-20 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. Signed-off-by: Jean-Christophe Dubois --- hw/net/imx_fec.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index 725f3fa..b39fc8d 100644 -

[Qemu-devel] [PATCH 7/8] i.MX: Standardize i.MX EPIT debug

2015-10-20 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. Signed-off-by: Jean-Christophe Dubois --- hw/timer/imx_epit.c | 37 +++-- 1 file changed, 15 insertions(+), 22 deletions(-) diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c index 9649851..82792b1

[Qemu-devel] [PATCH 2/8] i.MX: Standardize i.MX GPIO debug

2015-10-20 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- hw/gpio/imx_gpio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gpio.c index d56ffcd..db6f22c 100644 --- a/hw/gpio/imx_gpio.c +++ b/hw/gpio/imx_gpio.c @@ -31,7 +31,8 @@ typedef enum IMXGPIOLevel {

[Qemu-devel] [PATCH 1/8] i.MX: Standardize i.MX serial debug.

2015-10-20 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. Signed-off-by: Jean-Christophe Dubois --- hw/char/imx_serial.c | 39 +-- 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/hw/char/imx_serial.c b/hw/char/imx_serial.c index f0c4c72..082

[Qemu-devel] [PATCH 5/8] i.MX: Standardize i.MX CCM debug

2015-10-20 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. Signed-off-by: Jean-Christophe Dubois --- hw/misc/imx_ccm.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/hw/misc/imx_ccm.c b/hw/misc/imx_ccm.c index 2e19dbb..f137de1 100644 --- a/

[Qemu-devel] [PATCH 4/8] i.MX: Standardize i.MX AVIC debug

2015-10-20 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. Signed-off-by: Jean-Christophe Dubois --- hw/intc/imx_avic.c | 40 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/hw/intc/imx_avic.c b/hw/intc/imx_avic.c index 96c376b..11960aa

[Qemu-devel] [PATCH 3/8] i.MX: Standardize i.MX I2C debug

2015-10-20 Thread Jean-Christophe Dubois
The goal is to have debug code always compiled during build. Signed-off-by: Jean-Christophe Dubois --- hw/i2c/imx_i2c.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c index 8474872..8926f7a 100644 --- a/hw/i2c/i

[Qemu-devel] [PATCH 0/8] i.MX: Standardize debug code

2015-10-20 Thread Jean-Christophe Dubois
We fix all i.MX driver files to use the same type of debug code. The goal is to have debug code always compiled during build. Jean-Christophe Dubois (8): i.MX: Standardize i.MX serial debug. i.MX: Standardize i.MX GPIO debug i.MX: Standardize i.MX I2C debug i.MX: Standardize i.MX AVIC deb

Re: [Qemu-devel] [PATCH v1 0/6] PMA phase 2 - per CPU address spaces

2015-10-20 Thread Peter Maydell
On 20 October 2015 at 19:46, Peter Crosthwaite wrote: > On Tue, Oct 20, 2015 at 7:59 AM, Peter Maydell > wrote: >> Just to let you know, I'm taking some of these patches into >> a series I'm working on for multiple address-space support >> (for ARM trustzone). Basically I'm taking patches 2 and

Re: [Qemu-devel] [RFC] transactions: add transaction-wide property

2015-10-20 Thread John Snow
A little bit of cross-talk with my "state of the union" reply and this review from Eric. Sorry, everyone! On 10/20/2015 04:12 PM, Eric Blake wrote: > On 09/24/2015 03:40 PM, John Snow wrote: >> This replaces the per-action property as in Fam's series. >> Instead, we have a transaction-wide proper

Re: [Qemu-devel] [PATCH v2 04/16] ui: convert VNC startup code to use SocketAddress

2015-10-20 Thread Peter Maydell
On 20 October 2015 at 19:50, Daniel P. Berrange wrote: > On Tue, Oct 20, 2015 at 06:01:37PM +0100, Peter Maydell wrote: >> On 20 October 2015 at 14:39, Daniel P. Berrange wrote: >> > On Mon, Oct 19, 2015 at 04:20:09PM -0600, Eric Blake wrote: >> >> On 10/12/2015 05:14 AM, Daniel P. Berrange wrote

Re: [Qemu-devel] [RFC] transactions: add transaction-wide property

2015-10-20 Thread John Snow
So here's the current status of this blob: - Markus supports the idea of a transaction-wide property, but hasn't reviewed this particular RFC. - Eric seemed supportive of a transaction-wide property, but hasn't chimed in to this thread yet. - Stefan was not sure what this patch was trying to accom

Re: [Qemu-devel] [RFC] transactions: add transaction-wide property

2015-10-20 Thread Eric Blake
On 09/24/2015 03:40 PM, John Snow wrote: > This replaces the per-action property as in Fam's series. > Instead, we have a transaction-wide property that is shared > with each action. > > At the action level, if a property supplied transaction-wide > is disagreeable, we return error and the transac

Re: [Qemu-devel] [PATCH COLO-Frame v9 08/32] COLO/migration: establish a new communication path from destination to source

2015-10-20 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/10/19 17:54, Dr. David Alan Gilbert wrote: > >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >>Add a new member 'to_src_file' to MigrationIncomingState and a > >>new member 'from_dst_file' to MigrationState. > >>They will

[Qemu-devel] [PATCH] tests: ignore test-qga

2015-10-20 Thread Eric Blake
Commit 62c39b30 added a new test, but did not mark it for exclusion in .gitignore. Signed-off-by: Eric Blake --- Yes, I know this only affects people doing in-tree builds, and that VPATH is recommended these days. But until we actually require VPATH, we might as well keep things clean. tests/.

Re: [Qemu-devel] [PATCH v3 0/5] virtio-9p: hotplug and migration support

2015-10-20 Thread Michael S. Tsirkin
On Tue, Oct 20, 2015 at 08:00:53PM +0200, Greg Kurz wrote: > On Tue, 20 Oct 2015 15:53:08 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Oct 20, 2015 at 11:16:40AM +0200, Greg Kurz wrote: > > > We already have a blocker to prevent migration of an active virtio-9p > > > device. > > > But in fa

Re: [Qemu-devel] [RFC] transactions: add transaction-wide property

2015-10-20 Thread John Snow
On 10/20/2015 03:26 AM, Fam Zheng wrote: > On Thu, 09/24 17:40, John Snow wrote: >> This replaces the per-action property as in Fam's series. >> Instead, we have a transaction-wide property that is shared >> with each action. >> >> At the action level, if a property supplied transaction-wide >> i

Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches

2015-10-20 Thread Christian Borntraeger
Am 20.10.2015 um 17:35 schrieb Peter Maydell: > On 20 October 2015 at 16:00, Cornelia Huck wrote: >> The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201: >> >> Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-1' >&

Re: [Qemu-devel] [PATCH v2 04/16] ui: convert VNC startup code to use SocketAddress

2015-10-20 Thread Daniel P. Berrange
On Tue, Oct 20, 2015 at 06:01:37PM +0100, Peter Maydell wrote: > On 20 October 2015 at 14:39, Daniel P. Berrange wrote: > > On Mon, Oct 19, 2015 at 04:20:09PM -0600, Eric Blake wrote: > >> On 10/12/2015 05:14 AM, Daniel P. Berrange wrote: > >> > The VNC code is currently using QemuOpts to configur

Re: [Qemu-devel] [PATCH v1 0/6] PMA phase 2 - per CPU address spaces

2015-10-20 Thread Peter Crosthwaite
On Tue, Oct 20, 2015 at 7:59 AM, Peter Maydell wrote: > On 26 August 2014 at 01:56, Peter Crosthwaite > wrote: >> This series sets up CPUs with configurable address spaces. This follows >> on from Edgars original work and moves towards removal of >> address_space_memory and support for arbitrary

Re: [Qemu-devel] Statically Compiling including SDL

2015-10-20 Thread Peter Maydell
On 20 October 2015 at 18:50, sai pavan wrote: > I also tried manually compiling sdl libraries and installing them. > Then making a static build, but even that did not help much. The > config.log show below error.. > > cc -m32 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE > -Wstrict-prot

[Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT

2015-10-20 Thread Laszlo Ersek
Commit 4d00636e97b7 ("ich9: Add the lpc chip", Nov 14 2012) added the ich9_apm_ctrl_changed() ioport write callback function such that it would inject the SMI, in response to a write to the APM_CNT register, on the first CPU, invariably. Since this register is used by guest code to trigger an SMI

Re: [Qemu-devel] [PATCH v9 02/17] qapi: Reserve '*List' type names for arrays

2015-10-20 Thread Eric Blake
On 10/19/2015 10:14 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We already reserved '*Kind' for implicit enums (since commit > > "We reserved '*Kind' since" sounds odd. Present tense? > >> 4dc2e69), but failed to reserve '*List' for array types. Since >> no QMP was yet using it, we

[Qemu-devel] [PATCH RFC V5 0/9] Implement GIC-500 from GICv3 family for arm64

2015-10-20 Thread Shlomo Pongratz
From: Shlomo Pongratz This patch is a first step multicores support for arm64. This implemntation was tested up to 100 cores. Things left to do: Support SPI, ITS and ITS CONTROL, note that this patch porpose is to enable running multi cores using the "virt" virtual machine and this goal is ach

Re: [Qemu-devel] [PATCH v3 0/5] virtio-9p: hotplug and migration support

2015-10-20 Thread Greg Kurz
On Tue, 20 Oct 2015 15:53:08 +0300 "Michael S. Tsirkin" wrote: > On Tue, Oct 20, 2015 at 11:16:40AM +0200, Greg Kurz wrote: > > We already have a blocker to prevent migration of an active virtio-9p > > device. > > But in fact, there is no migration support at all for 9p, even if the device > > i

Re: [Qemu-devel] Statically Compiling including SDL

2015-10-20 Thread sai pavan
Hi Peter, On Tue, Oct 20, 2015 at 2:05 PM, Peter Maydell wrote: > On 20 October 2015 at 07:59, sai pavan wrote: >> Hi , >> >> I am trying to compile QEMU with --enable-sdl and --static. And i have >> installed libsdl-dev. >> I get the following error >> >> ERROR: User requested feature sdl >>

[Qemu-devel] [PATCH RFC V5 3/9] hw/intc: arm_gicv3_cpu_interface

2015-10-20 Thread Shlomo Pongratz
From: Shlomo Pongratz This patch incudes the GIC functionality that is exposed to the CPU via system instructions. In GICv2 this functionality was exposed via memory mapped access. Signed-off-by: Shlomo Pongratz --- hw/intc/Makefile.objs | 1 + hw/intc/arm_gicv3_cpu_interface.c |

Re: [Qemu-devel] [PATCH v2 08/16] io: add abstract QIOChannel classes

2015-10-20 Thread Eric Blake
On 10/12/2015 05:15 AM, Daniel P. Berrange wrote: > Start the new generic I/O channel framework by defining a > QIOChannel abstract base class. This is designed to feel > similar to GLib's GIOChannel, but with the addition of > support for using iovecs, qemu error reporting, file > descriptor passi

[Qemu-devel] [PATCH RFC V5 2/9] hw/intc: arm_gicv3_interrupts

2015-10-20 Thread Shlomo Pongratz
From: Shlomo Pongratz This patch includes the part of the GIC's code that handles the interrupts. Signed-off-by: Shlomo Pongratz --- hw/intc/Makefile.objs | 1 + hw/intc/arm_gicv3_interrupts.c | 295 + hw/intc/arm_gicv3_interrupts.h | 11 ++

[Qemu-devel] [PATCH RFC V5 8/9] target-arm/cpu64 GICv3 system instructions support

2015-10-20 Thread Shlomo Pongratz
From: Shlomo Pongratz Add system instructions used by the Linux (kernel) GICv3 device driver Signed-off-by: Shlomo Pongratz --- target-arm/cpu-qom.h | 1 + target-arm/cpu.h | 12 ++ target-arm/cpu64.c | 118 +++ 3 files changed, 131

[Qemu-devel] [PATCH RFC V5 7/9] hw/intc: arm_gicv3

2015-10-20 Thread Shlomo Pongratz
From: Shlomo Pongratz This patch includes the code that binds together the codes of all the previous patches. Signed-off-by: Shlomo Pongratz --- hw/intc/Makefile.objs | 1 + hw/intc/arm_gicv3.c | 134 ++ 2 files changed, 135 insertions(+) cr

[Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500

2015-10-20 Thread Shlomo Pongratz
From: Shlomo Pongratz Add virt-v3 machine that uses GIC-500. Registers the CPU system instructions and bind them to the GIC. Pass the cores' affinity to the GIC. Signed-off-by: Shlomo Pongratz --- hw/arm/virt.c | 87 ++- include/hw/arm/fd

[Qemu-devel] [PATCH RFC V5 5/9] hw/intc arm_gicv3_redist

2015-10-20 Thread Shlomo Pongratz
From: Shlomo Pongratz This patch includes the code that implements the functionality of the redisributer, which is the main enhancment of GICv3 over GICv3 Signed-off-by: Shlomo Pongratz --- hw/intc/Makefile.objs | 1 + hw/intc/arm_gicv3_redist.c | 460 +++

[Qemu-devel] [PATCH RFC V5 6/9] hw/intc: arm_gicv3_spi_its

2015-10-20 Thread Shlomo Pongratz
From: Shlomo Pongratz This patch includes a placeholder code for future spi and its implementation. Signed-off-by: Shlomo Pongratz --- hw/intc/Makefile.objs | 1 + hw/intc/arm_gicv3_spi_its.c | 359 hw/intc/arm_gicv3_spi_its.h | 11 ++ 3 fi

[Qemu-devel] [PATCH RFC V5 4/9] hw/intc: arm_gicv3_dist

2015-10-20 Thread Shlomo Pongratz
From: Shlomo Pongratz Signed-off-by: Shlomo Pongratz --- hw/intc/Makefile.objs| 1 + hw/intc/arm_gicv3_dist.c | 655 +++ hw/intc/arm_gicv3_dist.h | 9 + hw/intc/gicv3_internal.h | 8 + 4 files changed, 673 insertions(+) create mode 100644 h

Re: [Qemu-devel] [PATCH v3 3/5] virtio-9p: block hot-unplug when device is active

2015-10-20 Thread Greg Kurz
On Tue, 20 Oct 2015 15:42:03 +0300 "Michael S. Tsirkin" wrote: > On Tue, Oct 20, 2015 at 11:17:00AM +0200, Greg Kurz wrote: > > Hot-unplug of an active virtio-9p device is not currently supported. Until > > we have that, let's block hot-unplugging when the 9p share is mounted in > > the guest. >

Re: [Qemu-devel] [PATCH v2 04/16] ui: convert VNC startup code to use SocketAddress

2015-10-20 Thread Peter Maydell
On 20 October 2015 at 14:39, Daniel P. Berrange wrote: > On Mon, Oct 19, 2015 at 04:20:09PM -0600, Eric Blake wrote: >> On 10/12/2015 05:14 AM, Daniel P. Berrange wrote: >> > The VNC code is currently using QemuOpts to configure the >> > sockets connections / listeners it needs. Convert it to >> >

Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches

2015-10-20 Thread Cornelia Huck
On Tue, 20 Oct 2015 16:35:44 +0100 Peter Maydell wrote: > On 20 October 2015 at 16:00, Cornelia Huck wrote: > > The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201: > > > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-

[Qemu-devel] [PATCH] tests: test-qga, loosen assumptions about host filesystems

2015-10-20 Thread Michael Roth
QGA skips pseudo-filesystems when querying filesystems via guest-get-fsinfo. On some hosts, such as travis-ci which uses containers which simfs filesystems, QGA might not reports *any* filesystems. Our test case assumes there would be at least one, leading to false error messages in these situation

Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function

2015-10-20 Thread Xiao Guangrong
On 10/21/2015 12:26 AM, Xiao Guangrong wrote: On 10/20/2015 11:51 PM, Stefan Hajnoczi wrote: On Mon, Oct 19, 2015 at 08:54:14AM +0800, Xiao Guangrong wrote: +exit: +/* Write our output result to dsm memory. */ +((dsm_out *)dsm_ram_addr)->len = out->len; Missing byteswap? I though

[Qemu-devel] [PULL 0/7] Misc refactoring to util codebase

2015-10-20 Thread Daniel P. Berrange
The following changes since commit c14e42d7a4495ecbad7bf8b3d603272e3a8992a1: Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20151020-1' into staging (2015-10-20 10:52:56 +0100) are available in the git repository at: https://github.com/berrange/qemu.git io-channel-3

[Qemu-devel] [PULL 7/9] s390x: machine reset function with new ipl cpu handling

2015-10-20 Thread Cornelia Huck
From: David Hildenbrand Current implementation depends on the order of resets getting triggered. If a cpu reset is triggered after the ipl device reset, the CPU is stopped and the VM will not run. In fact, that hinders us from converting the ipl device into a TYPE_DEVICE. Let's change that by ma

[Qemu-devel] [PULL 5/7] osdep: add qemu_fork() wrapper for safely handling signals

2015-10-20 Thread Daniel P. Berrange
When using regular fork() the child process of course inherits all the parents' signal handlers. If the child then proceeds to close() any open file descriptors, it may break some of those registered signal handlers. The child generally does not want to ever run any of the signal handlers that the

Re: [Qemu-devel] [PATCH 0/3] Add 'blockdev-del' command

2015-10-20 Thread Alberto Garcia
On Mon 19 Oct 2015 05:04:50 PM CEST, Kevin Wolf wrote: >> > So we seem to have two criteria to distinguish BDSes: >> > >> > 1. Does/Doesn't have a BlockBackend on top. >> >In the future, multiple BlockBackends are possible, too. >> >> One single BDS attached to multiple BlockBackends at the s

[Qemu-devel] [PULL 4/7] ui: convert VNC startup code to use SocketAddress

2015-10-20 Thread Daniel P. Berrange
The VNC code is currently using QemuOpts to configure the sockets connections / listeners it needs. Convert it to use SocketAddress to bring it in line with modern QAPI based code elsewhere in QEMU. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- ui/vnc.c | 160 +++

[Qemu-devel] [PULL 1/7] sockets: add helpers for creating SocketAddress from a socket

2015-10-20 Thread Daniel P. Berrange
Add two helper methods that, given a socket file descriptor, can return a populated SocketAddress struct containing either the local or remote address information. Signed-off-by: Daniel P. Berrange --- include/qemu/sockets.h | 30 ++ util/qemu-sockets.c| 110

Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function

2015-10-20 Thread Xiao Guangrong
On 10/20/2015 11:51 PM, Stefan Hajnoczi wrote: On Mon, Oct 19, 2015 at 08:54:14AM +0800, Xiao Guangrong wrote: +exit: +/* Write our output result to dsm memory. */ +((dsm_out *)dsm_ram_addr)->len = out->len; Missing byteswap? I thought you were going to remove this field because it

Re: [Qemu-devel] [PATCH v9 01/17] qapi: Add tests for reserved name abuse

2015-10-20 Thread Eric Blake
On 10/19/2015 10:05 AM, Markus Armbruster wrote: > Eric Blake writes: > >> A future patch wants to change qapi union representation from >> an anonymous C union over to a named C union 'u', so that the >> C names of tag values are in a separate namespace and thus >> cannot collide with the C name

[Qemu-devel] [PULL 9/9] s390x/cmma: clean up cmma reset

2015-10-20 Thread Cornelia Huck
From: David Hildenbrand The cmma reset is per VM, so we don't need a cpu object. We can directly make use of kvm_state, as it is already available when the reset is called. By moving the cmma reset in our machine reset function, we can avoid a manual reset handler. Acked-by: Christian Borntraege

Re: [Qemu-devel] [PULL 0/7] Misc refactoring to util codebase

2015-10-20 Thread Daniel P. Berrange
On Tue, Oct 20, 2015 at 04:33:55PM +0100, Daniel P. Berrange wrote: > The following changes since commit c14e42d7a4495ecbad7bf8b3d603272e3a8992a1: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20151020-1' into > staging (2015-10-20 10:52:56 +0100) > &

[Qemu-devel] [PULL 2/7] sockets: move qapi_copy_SocketAddress into qemu-sockets.c

2015-10-20 Thread Daniel P. Berrange
The qapi_copy_SocketAddress method is going to be useful in more places than just qemu-char.c, so move it into the qemu-sockets.c file to allow its reuse. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- include/qemu/sockets.h | 4 qemu-char.c| 25

Re: [Qemu-devel] [PATCH] xen-platform: Replace assert() with appropriate error reporting

2015-10-20 Thread Eduardo Habkost
On Tue, Oct 20, 2015 at 11:01:16AM +0100, Stefano Stabellini wrote: > On Mon, 19 Oct 2015, Paolo Bonzini wrote: > > On 19/10/2015 20:39, Eduardo Habkost wrote: > > > Commit dbb7405d8caad0814ceddd568cb49f163a847561 made it possible to > > > trigger an assert using "-device xen-platform". Replace it

Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function

2015-10-20 Thread Michael S. Tsirkin
On Tue, Oct 20, 2015 at 04:51:49PM +0100, Stefan Hajnoczi wrote: > On Mon, Oct 19, 2015 at 08:54:14AM +0800, Xiao Guangrong wrote: > > +exit: > > +/* Write our output result to dsm memory. */ > > +((dsm_out *)dsm_ram_addr)->len = out->len; > > Missing byteswap? That's why I'd prefer no s

[Qemu-devel] [PULL 3/7] sockets: allow port to be NULL when listening on IP address

2015-10-20 Thread Daniel P. Berrange
If the port in the SocketAddress struct is NULL, it can allow the kernel to automatically select a free port. This is useful in particular in unit tests to avoid a race trying to find a free port to run a test case on. Signed-off-by: Daniel P. Berrange --- qapi-schema.json| 6 -- util/q

Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches

2015-10-20 Thread Peter Maydell
On 20 October 2015 at 16:00, Cornelia Huck wrote: > The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-1' > into staging (2015-10-20 12:56:45 +0100) > > are availa

[Qemu-devel] [PULL 6/7] coroutine: move into libqemuutil.a library

2015-10-20 Thread Daniel P. Berrange
The coroutine files are currently referenced by the block-obj-y variable. The coroutine functionality though is already used by more than just the block code. eg migration code uses coroutine yield. In the future the I/O channel code will also use the coroutine yield functionality. Since the corout

[Qemu-devel] [PULL 3/9] s390x/kvm: Fix vector validity bit in device machine checks

2015-10-20 Thread Cornelia Huck
From: Christian Borntraeger Device hotplugs trigger a crw machine check. All machine checks have validity bits for certain register types. With vector support we also have to claim that vector registers are valid. This is a band-aid suitable for stable. Long term we should create the full mcic v

Re: [Qemu-devel] [PULL v4 00/14] qemu-ga patch queue

2015-10-20 Thread Michael Roth
Quoting Peter Maydell (2015-10-20 06:55:19) > On 20 October 2015 at 10:52, Peter Maydell wrote: > > On 20 October 2015 at 00:38, Michael Roth wrote: > >> > >> qemu-ga patch queue > >> > >> * add unit tests for qemu-ga > >> * add gue

[Qemu-devel] [PULL 1/9] util/qemu-config: fix missing machine command line options

2015-10-20 Thread Cornelia Huck
From: Tony Krowiak Commit 0a7cf217 ("util/qemu-config: fix regression of qmp_query_command_line_options") aimed to restore parsing of global machine options, but missed two: "aes-key-wrap" and "dea-key-wrap" (which were present in the initial version of that patch). Let's add them to the machine_

[Qemu-devel] [PULL 4/9] s390x: flagify mcic values

2015-10-20 Thread Cornelia Huck
Instead of using magic values when building the machine check interruption code, add some defines as by chapter 11-14 in the PoP. This should make it easier to catch problems like the missing vector register validity bit ("s390x/kvm: Fix vector validity bit in device machine checks"), and less has

Re: [Qemu-devel] [PULL 0/7] Misc refactoring to util codebase

2015-10-20 Thread Peter Maydell
On 20 October 2015 at 16:33, Daniel P. Berrange wrote: > The following changes since commit c14e42d7a4495ecbad7bf8b3d603272e3a8992a1: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20151020-1' into > staging (2015-10-20 10:52:56 +0100) > > are availa

Re: [Qemu-devel] [Qemu-block] [RFC] transactions: add transaction-wide property

2015-10-20 Thread John Snow
On 10/19/2015 03:27 AM, Markus Armbruster wrote: > John Snow writes: > >> On 10/16/2015 08:23 AM, Stefan Hajnoczi wrote: >>> On Mon, Oct 12, 2015 at 12:50:20PM -0400, John Snow wrote: Ping -- any consensus on how we should implement the "do-or-die" argument for transactions that start

[Qemu-devel] [PULL 7/7] util: pull Buffer code out of VNC module

2015-10-20 Thread Daniel P. Berrange
The Buffer code in the VNC server is useful for the IO channel code, so pull it out into a shared module, QIOBuffer. Signed-off-by: Daniel P. Berrange --- MAINTAINERS | 6 +++ include/qemu/buffer.h | 118 ++ ui/vnc.c | 43

[Qemu-devel] [PULL 8/9] s390x: reset crypto only on clear reset and QEMU reset

2015-10-20 Thread Cornelia Huck
From: David Hildenbrand Initializing VM crypto in initial cpu reset has multiple problems 1. We call the exact same function #VCPU times, although one time is enough 2. On SIGP initial cpu reset, we exchange the wrapping key while other VCPUs are running. Bad! 3. It is simply wrong. According

Re: [Qemu-devel] [PATCH v9 05/17] qapi: Unbox base members

2015-10-20 Thread Eric Blake
On 10/20/2015 06:09 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Rather than storing a base class as a pointer to a box, just >> store the fields of that base class in the same order, so that >> a child struct can be safely cast to its parent. >> Compare to the earlier commit 1e6

[Qemu-devel] [PATCH] target-tilegx: Implement prefetch instructions in pipe y2

2015-10-20 Thread Chen Gang
>From 14fe2a651b3f5729f1d402dfcd6eb5f7da0f42b1 Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Tue, 20 Oct 2015 23:19:02 +0800 Subject: [PATCH] target-tilegx: Implement prefetch instructions in pipe y2 Originally, tilegx qemu only implement prefetch instructions in pipe x1, did not implement them

Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function

2015-10-20 Thread Stefan Hajnoczi
On Mon, Oct 19, 2015 at 08:54:14AM +0800, Xiao Guangrong wrote: > +exit: > +/* Write our output result to dsm memory. */ > +((dsm_out *)dsm_ram_addr)->len = out->len; Missing byteswap? I thought you were going to remove this field because it wasn't needed by the guest.

[Qemu-devel] [PULL 5/9] s390x: unify device reset during subsystem_reset()

2015-10-20 Thread Cornelia Huck
From: David Hildenbrand We have to manually reset several devices that are not on a bus: Let's collect them in an array. Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Signed-off-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 31 +

[Qemu-devel] [PULL 2/9] s390x/virtio-ccw: fix 2.4 virtio compat

2015-10-20 Thread Cornelia Huck
Commit 542571d5 ("virtio-ccw: enable virtio-1") missed some virtio devices for the 2.4 compat handling. Add them. Fixes: 542571d5 ("virtio-ccw: enable virtio-1") Signed-off-by: Cornelia Huck Reviewed-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 12 1 file changed, 12

[Qemu-devel] [PULL 6/9] s390x/ipl: we always have an ipl device

2015-10-20 Thread Cornelia Huck
From: David Hildenbrand Both s390 machines unconditionally create an ipl device, so no need to handle the missing case. Now we can also change s390_ipl_update_diag308() to return void. Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Signed-off-by: David Hildenbrand Signed-off-by:

[Qemu-devel] [PULL 0/9] Next set of s390x patches

2015-10-20 Thread Cornelia Huck
The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201: Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-1' into staging (2015-10-20 12:56:45 +0100) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-2015102

Re: [Qemu-devel] [PATCH v1 0/6] PMA phase 2 - per CPU address spaces

2015-10-20 Thread Peter Maydell
On 26 August 2014 at 01:56, Peter Crosthwaite wrote: > This series sets up CPUs with configurable address spaces. This follows > on from Edgars original work and moves towards removal of > address_space_memory and support for arbitrary memory > heirachies/layouts. > > Fuller context in RFC: > > ht

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-20 Thread Stefano Stabellini
On Tue, 20 Oct 2015, Laszlo Ersek wrote: > On 10/20/15 13:59, Stefano Stabellini wrote: > > On Mon, 19 Oct 2015, Laszlo Ersek wrote: > >> Could that be related to the issue you are experiencing with OVMF? > >> Because, OVMF implies HVM (or PV-on-HVM), and your report ("empty > >> paravirt CD-ROM" o

Re: [Qemu-devel] [PATCH v9 04/17] vnc: hoist allocation of VncBasicInfo to callers

2015-10-20 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> > -static VncBasicInfo *vnc_basic_info_get(struct sockaddr_storage *sa, >> > -socklen_t salen) >> > +static void vnc_basic_info_get(struct sockaddr_storage *sa, >> > + socklen_t salen, >> > +

  1   2   3   >