Re: [Qemu-devel] [PATCH] gdbstub: Fix buffer overflows in gdb_handle_packet()

2015-10-13 Thread P J P
+-- On Tue, 13 Oct 2015, Kevin Wolf wrote --+ | diff --git a/gdbstub.c b/gdbstub.c | index d2c95b5..9c29aa0 100644 | --- a/gdbstub.c | +++ b/gdbstub.c | @@ -956,6 +956,13 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) | if (*p == ',') | p++; | len

Re: [Qemu-devel] [PATCH] Add mp-affinity property for ARM CPU class

2015-10-13 Thread Pavel Fedin
Hello! > Nothing wrong with this patch, but I'd rather add it as part of > the series which actually uses it. Ok, as you wish, i just tried to decrease amount of out-of-tree stuff. Additionally, i remember Andrew also wanted to do something with affinities, he thought about adding emulation o

Re: [Qemu-devel] [PATCH] Add mp-affinity property for ARM CPU class

2015-10-13 Thread Pavel Fedin
Hello! > Can we have separate props for each affinity level? Yes, we can, but i don't see any use for them in this form. Except merging back into full MPIDR value. :) > Are you assuming MPIDR format for this? Yes. This is convenient because everything else (KVM, GICv3, etc) also uses MPIDR

Re: [Qemu-devel] [PATCH] Limit memory r/w length to buffer size

2015-10-13 Thread P J P
+-- On Tue, 13 Oct 2015, Markus Armbruster wrote --+ | How is this related to Kevin's | [PATCH] gdbstub: Fix buffer overflows in gdb_handle_packet() | Message-Id: <1444721930-5121-1-git-send-email-kw...@redhat.com> ? Oh, didn't know there was already a patch. Yes it fixes the same issues; Also

[Qemu-devel] [PATCH 1/2] target-xtensa: implement depbits instruction

2015-10-13 Thread Max Filippov
This option provides an instruction for depositing a bit field from the least significant position of one register to an arbitrary position in another register. Signed-off-by: Max Filippov --- target-xtensa/cpu.h | 1 + target-xtensa/overlay_tool.h | 5 + target-xtensa/translate.c

[Qemu-devel] [PATCH 2/2] target-xtensa: implement S32NB

2015-10-13 Thread Max Filippov
S32NB provides the same functionality as S32I with two exceptions. First, when its operation leaves the processor, the external transaction is marked Non-Bufferable. Second, it may not be used to write to Instruction RAM. In QEMU S32NB is equivalent to S32I. Signed-off-by: Max Filippov --- targe

[Qemu-devel] [PATCH 0/2] target-xtensa: two new instructions

2015-10-13 Thread Max Filippov
Hi, this series adds two new xtensa instructions: - s32nb is a new core instruction; - depbits is enabled by dedicated option. Max Filippov (2): target-xtensa: implement depbits instruction target-xtensa: implement S32NB target-xtensa/cpu.h | 1 + target-xtensa/overlay_tool.h | 5

Re: [Qemu-devel] [PATCH v3 0/2] PCI-e device multi-function hot-add support

2015-10-13 Thread Cao jin
On 10/13/2015 09:10 PM, Michael S. Tsirkin wrote: On Tue, Oct 13, 2015 at 07:54:07PM +0800, Cao jin wrote: On 10/13/2015 04:49 PM, Michael S. Tsirkin wrote: On Tue, Oct 13, 2015 at 04:41:33PM +0800, Cao jin wrote: Support PCI-e device hot-add multi-function via device_add, just ensure add

Re: [Qemu-devel] [PATCH v3 2/2] remove function during multi-function hot-add

2015-10-13 Thread Cao jin
Hi, Alex On 10/13/2015 11:27 PM, Alex Williamson wrote: On Tue, 2015-10-13 at 16:41 +0800, Cao jin wrote: In case user regret when hot-adding multi-function, should roll back, device_del the function added but not exposed to the guest. As Michael suggests, this patch should come first, before

Re: [Qemu-devel] [PATCH v4 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-10-13 Thread Michael S. Tsirkin
On Tue, Oct 13, 2015 at 07:43:00PM -0300, Eduardo Habkost wrote: > On Wed, Oct 14, 2015 at 12:18:10AM +0300, Michael S. Tsirkin wrote: > > On Tue, Oct 13, 2015 at 04:10:03PM -0300, Eduardo Habkost wrote: > > > One of the things that may break if guest-visible bits of the machine > > > change is Win

Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM

2015-10-13 Thread Xiao Guangrong
On 10/13/2015 02:36 PM, Dan Williams wrote: On Mon, Oct 12, 2015 at 10:49 PM, Xiao Guangrong wrote: On 10/13/2015 11:38 AM, Dan Williams wrote: On Mon, Oct 12, 2015 at 8:14 PM, Xiao Guangrong wrote: On 10/13/2015 12:36 AM, Dan Williams wrote: Static namespaces can be emitted without

Re: [Qemu-devel] [PATCH v2 4/5] net/dump: Provide the dumping facility as a net-filter

2015-10-13 Thread Yang Hongyang
On 10/13/2015 06:40 PM, Thomas Huth wrote: Use the net-filter infrastructure to provide the dumping functions for netdev devices, too. Signed-off-by: Thomas Huth Reviewed-by: Yang Hongyang --- net/dump.c | 129 - vl.c

Re: [Qemu-devel] [PATCH v2 3/5] net/dump: Separate the NetClientState from the DumpState

2015-10-13 Thread Yang Hongyang
On 10/13/2015 06:40 PM, Thomas Huth wrote: With the upcoming dumping-via-netfilter patch, the DumpState should not be related to NetClientState anymore, so move the related information to a new struct called DumpNetClient. Signed-off-by: Thomas Huth Reviewed-by: Yang Hongyang --- net/d

Re: [Qemu-devel] [PATCH] net: cadence_gem: Set initial MAC address

2015-10-13 Thread Jason Wang
On 10/12/2015 04:25 PM, Sebastian Huber wrote: > Set initial MAC address to the one specified by the command line. > > Signed-off-by: Sebastian Huber > Reviewed-by: Jason Wang > Reviewed-by: Peter Crosthwaite > --- > hw/net/cadence_gem.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff

Re: [Qemu-devel] [PATCH v2 2/5] net/dump: Rework net-dump init functions

2015-10-13 Thread Yang Hongyang
On 10/13/2015 06:39 PM, Thomas Huth wrote: Move the creation of the dump client from net_dump_init() into net_init_dump(), so we can later use the former function for dump via netfilter, too. Also rename net_dump_init() to net_dump_state_init() to make it easier distinguishable from net_init_dum

Re: [Qemu-devel] [PATCH v2 1/5] net/dump: Add support for receive_iov function

2015-10-13 Thread Yang Hongyang
On 10/13/2015 06:39 PM, Thomas Huth wrote: Adding a proper receive_iov function to the net dump module. This will make it easier to support the dump filter feature for the -netdev option in later patches. Signed-off-by: Thomas Huth Reviewed-by: Yang Hongyang --- net/dump.c | 24 +++

[Qemu-devel] [Bug 893208] Re: qemu on ARM hosts can't boot i386 image

2015-10-13 Thread PeteVine
BTW, it seems the more expensive (but vastly less popular) odroids like the xu4 are built around kvm enabled processors which is why this bug doesn't affect them. The most popular C1/C1+'s processor doesn't support kvm though so any update would be appreciated. -- You received this bug notificat

Re: [Qemu-devel] [Qemu-block] [PATCH v10 08/10] Implement new driver for block replication

2015-10-13 Thread Wen Congyang
On 10/13/2015 06:12 PM, Fam Zheng wrote: > On Tue, 10/13 17:46, Wen Congyang wrote: >> On 10/13/2015 05:41 PM, Fam Zheng wrote: >>> On Tue, 10/13 16:59, Wen Congyang wrote: On 10/13/2015 12:25 AM, Stefan Hajnoczi wrote: > On Fri, Sep 25, 2015 at 02:17:36PM +0800, Wen Congyang wrote: >>

[Qemu-devel] [PATCH v5 2/2] arm_mptimer: Convert to use ptimer

2015-10-13 Thread Dmitry Osipenko
Current ARM MPTimer implementation uses QEMUTimer for the actual timer, this implementation isn't complete and mostly tries to duplicate of what generic ptimer is already doing fine. Conversion to ptimer brings the following benefits and fixes: - Simple timer pausing implementation

[Qemu-devel] [PATCH v5 1/2] hw/ptimer: Set delta to the original limit on reload in ptimer_set_limit()

2015-10-13 Thread Dmitry Osipenko
ptimer_get_count() returns incorrect value for the disabled timer after reloading the counter with a small value, because corrected limit value is used instead of the original. For instance: 1) ptimer_stop(t) 2) ptimer_set_period(t, 1) 3) ptimer_set_limit(t, 0, 1) 4) ptimer_get_cou

Re: [Qemu-devel] [PATCH v9 00/24] Generate ACPI v5.1 tables and expose them to guest over fw_cfg on ARM

2015-10-13 Thread liang yan
Hello, Laszlo, On 10/10/15 00:34, liang yan wrote: >/Hello, Shannon,/ >/> From: Shannon Zhao / >/>/ >/> This patch series generate seven ACPI tables for machine virt on ARM./ >/> The set of generated tables are:/ >/> - RSDP/ >/> - RSDT/ >/> - MADT/ >/> - GTDT/ >/> - FADT/ >/> - DSDT/ >/> - MCFG (

Re: [Qemu-devel] [Qemu-block] [PATCH v7 5/5] block: add tests for the 'blockdev-snapshot' command

2015-10-13 Thread Jeff Cody
On Mon, Oct 12, 2015 at 12:16:17PM +0300, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > Reviewed-by: Max Reitz > --- > tests/qemu-iotests/085 | 102 > ++--- > tests/qemu-iotests/085.out | 34 ++- > 2 files changed, 128 insertion

Re: [Qemu-devel] [Qemu-block] [PATCH v7 2/5] block: rename BlockdevSnapshot to BlockdevSnapshotSync

2015-10-13 Thread Jeff Cody
On Mon, Oct 12, 2015 at 12:16:14PM +0300, Alberto Garcia wrote: > We will introduce the 'blockdev-snapshot' command that will require > its own struct for the parameters, so we need to rename this one in > order to avoid name clashes. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake >

[Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-13 Thread Richard Henderson
Some targets already had this within their logic, but make sure it's present for all targets. Signed-off-by: Richard Henderson --- target-alpha/translate.c | 3 +++ target-cris/translate.c | 3 +++ target-i386/translate.c | 3 +++ target-lm32/translate.c | 3 +++ target-m6

Re: [Qemu-devel] [Qemu-block] [PATCH v7 3/5] block: support passing 'backing': '' to 'blockdev-add'

2015-10-13 Thread Jeff Cody
On Mon, Oct 12, 2015 at 12:16:15PM +0300, Alberto Garcia wrote: > Passing an empty string allows opening an image but not its backing > file. This was already described in the API documentation, only the > implementation was missing. > > This is useful for creating snapshots using images opened wi

Re: [Qemu-devel] [Qemu-block] [PATCH v7 1/5] block: check for existing device IDs in external_snapshot_prepare()

2015-10-13 Thread Jeff Cody
On Mon, Oct 12, 2015 at 12:16:13PM +0300, Alberto Garcia wrote: > The 'snapshot-node-name' parameter of blockdev-snapshot-sync allows > setting the node name of the image that is going to be created. > > Before creating the image, external_snapshot_prepare() checks that the > name is not already b

Re: [Qemu-devel] [PATCH v4 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-10-13 Thread Eduardo Habkost
On Wed, Oct 14, 2015 at 12:18:10AM +0300, Michael S. Tsirkin wrote: > On Tue, Oct 13, 2015 at 04:10:03PM -0300, Eduardo Habkost wrote: > > One of the things that may break if guest-visible bits of the machine > > change is Windows license activation, but the rules Windows use to > > trigger reactiv

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add real CDROM menu item

2015-10-13 Thread Programmingkid
On Oct 13, 2015, at 4:44 PM, Peter Maydell wrote: > On 26 September 2015 at 04:01, Programmingkid > wrote: >> Add a menu item to the Machine menu called "Use Real CDROM". It gives the >> user >> the ability to use a real CDROM disc with QEMU by simply selecting a menu >> item. >> >> Signed-o

Re: [Qemu-devel] [PATCH v4 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-10-13 Thread Michael S. Tsirkin
On Tue, Oct 13, 2015 at 04:10:03PM -0300, Eduardo Habkost wrote: > One of the things that may break if guest-visible bits of the machine > change is Windows license activation, but the rules Windows use to > trigger reactivation aren't very clear. They are easy to find on the internet. > -- > Ed

Re: [Qemu-devel] [PATCH] target-arm: Use common CPU cycle infrastructure

2015-10-13 Thread Peter Maydell
On 24 September 2015 at 20:43, Christopher Covington wrote: > cpu_get_ticks() provides a common interface across targets for > calculating CPU cycles. Using this fixes PMCCNTR reads when -icount > is specified (previously a non-increasing value was returned). > > Signed-off-by: Christopher Coving

Re: [Qemu-devel] [PATCH v4] arm_mptimer: Convert to use ptimer

2015-10-13 Thread Dmitry Osipenko
13.10.2015 18:38, Dmitry Osipenko пишет: 13.10.2015 17:11, Dmitry Osipenko пишет: +ptimer_set_limit(tb->timer, value, 0); +ptimer_set_count(tb->timer, value); Umm... looking more at these lines, I think it might put in a trouble in some corner case. It might worth trying to ma

Re: [Qemu-devel] [PULL 04/26] target-*: Introduce and use cpu_breakpoint_test

2015-10-13 Thread Richard Henderson
On 10/14/2015 12:40 AM, Sergey Fedorov wrote: Otherwise, "!(tb_end <= start || tb_start >= end)" condition check will fail ... So we either need to change the condition in tb_invalidate_phys_page_range() or do the PC advancement trick during translation, no matter can instructions cross a page

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add real CDROM menu item

2015-10-13 Thread Peter Maydell
On 26 September 2015 at 04:01, Programmingkid wrote: > Add a menu item to the Machine menu called "Use Real CDROM". It gives the user > the ability to use a real CDROM disc with QEMU by simply selecting a menu > item. > > Signed-off-by: John Arbuckle This feature is not present in any of our ot

Re: [Qemu-devel] [PATCH] ui/cocoa.m: fix help menus

2015-10-13 Thread Peter Maydell
On 27 September 2015 at 15:31, Programmingkid wrote: > Make the help menus actually work. > > Signed-off-by: John Arbuckle > > --- > ui/cocoa.m | 20 > 1 files changed, 16 insertions(+), 4 deletions(-) > > diff --git a/ui/cocoa.m b/ui/cocoa.m > index 334e6f6..2c81785 10064

Re: [Qemu-devel] [PATCH] target-arm: Provide model numbers for Sharp PDAs

2015-10-13 Thread Ryo ONODERA
Dear Peter Maydell, From: Peter Maydell , Date: Tue, 13 Oct 2015 18:17:57 +0100 > On 12 October 2015 at 12:36, Ryo ONODERA wrote: >> qemu-system-arm -M ? provides code names for Sharp Zaurus PDAs. >> The code names are difficult to identify what model is emulated. >> Please add model numbers to

Re: [Qemu-devel] [PATCH] ui/cocoa.m: blinky mouse cursor fix

2015-10-13 Thread Peter Maydell
On 27 September 2015 at 02:32, Programmingkid wrote: > The mouse cursor can become blinky when being moved a lot. This patch fixes > that > problem by issuing the redraw sooner. > > Signed-off-by: John Arbuckle > > --- > ui/cocoa.m |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >

Re: [Qemu-devel] [PATCH] ui/cocoa.m: addRemovableDevicesMenuItems() warning fix

2015-10-13 Thread Peter Maydell
On 25 September 2015 at 23:44, Programmingkid wrote: > Eliminate this warning associated with the addRemovableDevicesMenuItems() > function: > > ui/cocoa.m:1344:13: warning: function declaration isn't a prototype > [-Wstrict-prototypes] > static void addRemovableDevicesMenuItems() >

Re: [Qemu-devel] [PATCH] ui/cocoa.m: eliminate normalWindow warning

2015-10-13 Thread Peter Maydell
On 25 September 2015 at 23:34, Programmingkid wrote: > Eliminate this warning associated with the setting of the normalWindow's > title: > > ui/cocoa.m: In function '-[QemuCocoaAppController init]': > ui/cocoa.m:888:9: warning: format not a string literal and no format arguments > [-Wformat-secu

[Qemu-devel] [PULL v3 49/51] ivshmem: use kvm irqfd for msi notifications

2015-10-13 Thread marcandre . lureau
From: Marc-André Lureau Use irqfd for improving context switch when notifying the guest. If the host doesn't support kvm irqfd, regular msi notifications are still supported. Note: the ivshmem implementation doesn't allow switching between MSI and IO interrupts, this patch doesn't either. Signe

Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check()

2015-10-13 Thread Eric Blake
On 10/13/2015 02:17 PM, Eric Blake wrote: I can take PATCH 01-09,12 into my tree right away, with PATCH 07's two redundant is_implicit() methods dropped, and PATCH 12's comment touched up. >>> >>> Okay. >> >> Done & pushed to http://repo.or.cz/qemu/armbru.git branch qapi-next. > >

Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check()

2015-10-13 Thread Eric Blake
On 10/13/2015 12:32 PM, Markus Armbruster wrote: > Eric Blake writes: > >> On 10/13/2015 11:13 AM, Markus Armbruster wrote: >> > > I've come to the conclusion that we should get rid of the self-inflicted > pain before we attempt to detect all collisions. Then that sounds lik

Re: [Qemu-devel] [PATCH] Add mp-affinity property for ARM CPU class

2015-10-13 Thread Peter Crosthwaite
On Tue, Oct 13, 2015 at 10:54 AM, Peter Maydell wrote: > On 9 October 2015 at 10:52, Pavel Fedin wrote: >> This allows to override default affinity IDs on a per-machine basis, and >> possibility to retrieve IDs will be used by vGICv3 live migration code. >> >> Signed-off-by: Pavel Fedin >> --- >

Re: [Qemu-devel] [PATCH] target-arm: Provide model numbers for Sharp PDAs

2015-10-13 Thread Peter Maydell
On 12 October 2015 at 12:36, Ryo ONODERA wrote: > qemu-system-arm -M ? provides code names for Sharp Zaurus PDAs. > The code names are difficult to identify what model is emulated. > Please add model numbers to the output of qemu-system-arm -M ?. > > Ryo ONODERA (1): > target-arm: Provide model

[Qemu-devel] [PATCHv17/8] [trivial] Track when QEMU has finished initialization

2015-10-13 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile.objs|2 +- bsd-user/main.c |1 + include/qemu-common.h|3 +++ linux-user/main.c|1 + qemu-common.c| 14 ++ stubs/Makefile.objs |1 + stubs/qemu-common-stub.c | 21 +

Re: [Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE

2015-10-13 Thread Eduardo Habkost
On Tue, Oct 13, 2015 at 09:42:50PM +0200, Paolo Bonzini wrote: > > > On 13/10/2015 21:30, Eduardo Habkost wrote: > > Yeah, the shutdown behavior was never implemented before, so now we are > > just deviating from the documented Pentium & 486 behavior in a different > > (and less surprising?) way.

Re: [Qemu-devel] [PATCHv18/8] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property

2015-10-13 Thread Lluís Vilanova
Eric Blake writes: > On 10/13/2015 11:11 AM, Lluís Vilanova wrote: [...] >> +## >> +{ 'command': 'trace-event-get-cpu-state', >> + 'data': {'name': 'str', 'vcpu': 'int'}, >> + 'returns': ['TraceEventInfo'] } >> + >> +## >> +# @trace-event-set-cpu-state: >> +# >> +# Set the dynamic state of event

Re: [Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE

2015-10-13 Thread Paolo Bonzini
On 13/10/2015 21:30, Eduardo Habkost wrote: > Yeah, the shutdown behavior was never implemented before, so now we are > just deviating from the documented Pentium & 486 behavior in a different > (and less surprising?) way. > >> > >> > With the typo fix in the Cc tag: >> > >> > Reviewed-by: Las

Re: [Qemu-devel] [PATCH v8 17/18] qapi: Add test for alternate branch 'kind' clash

2015-10-13 Thread Eric Blake
On 10/13/2015 12:43 PM, Markus Armbruster wrote: > Eric Blake writes: > >> Rename alternate-clash to alternate-clash-members, and add a >> new test alternate-clash-type. While similar to the earlier >> addition of union-clash-type, we have one major difference: a >> future patch will be simplify

Re: [Qemu-devel] [PATCH v8 16/18] qapi: Move duplicate enum value checks to schema check()

2015-10-13 Thread Eric Blake
On 10/13/2015 12:35 PM, Markus Armbruster wrote: > Eric Blake writes: > >> Similar to the previous commit, move the detection of a collision >> in enum values from parse time to QAPISchemaEnumType.check(). >> This happens to also detect collisions in union branch names, >> so for a decent error m

Re: [Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE

2015-10-13 Thread Eduardo Habkost
On Mon, Oct 12, 2015 at 07:32:17PM +0200, Laszlo Ersek wrote: > On 10/12/15 18:25, Paolo Bonzini wrote: > > Processors up to the Pentium (says Bochs---I do not have old enough > > manuals) require a 32KiB alignment for the SMBASE, but newer processors > > do not need that, and Tiano Core will use n

Re: [Qemu-devel] [PATCH v3 1/4] util - add automated ID generation utility

2015-10-13 Thread Programmingkid
On Oct 13, 2015, at 11:26 AM, Markus Armbruster wrote: > Jeff Cody writes: > >> On Tue, Oct 13, 2015 at 09:37:29AM +0200, Markus Armbruster wrote: >>> Jeff Cody writes: >>> Multiple sub-systems in QEMU may find it useful to generate IDs for objects that a user may reference via QMP

Re: [Qemu-devel] [PATCH v4 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-10-13 Thread Eduardo Habkost
On Sat, Oct 10, 2015 at 12:00:16AM -0400, Gabriel L. Somlo wrote: > On Thu, Oct 01, 2015 at 01:33:50PM +0200, Igor Mammedov wrote: > > On Thu, 1 Oct 2015 10:27:15 +0200 > > Laszlo Ersek wrote: > > > > > On 10/01/15 09:02, Igor Mammedov wrote: > > > > On Sun, 27 Sep 2015 17:29:00 -0400 > > > > "Ga

Re: [Qemu-devel] [PATCH] Limit memory r/w length to buffer size

2015-10-13 Thread Markus Armbruster
P J P writes: >Hello, > > An OOB r/w access issue was reported by Mr Gerben Lubbe(CC'd here). > > The GDB(1) stub protocol supports commands 'm/M' to read & write 'len' > bytes from/to the stub memory area. In that, the 'len' parameter value > supplied by the host gdb(1) is not validated agai

Re: [Qemu-devel] [PATCHv13/8] trace: [tcg] Identify events with the 'vcpu' property

2015-10-13 Thread Markus Armbruster
Lluís Vilanova writes: > Eric Blake writes: > >> On 10/13/2015 11:10 AM, Lluís Vilanova wrote: >>> Signed-off-by: Lluís Vilanova > >> If you'd send with 'qemu format-patch/send-email -v1', then your subject >> line would be formatted [PATCH v1 3/8] instead of the confusing results >> you got by

Re: [Qemu-devel] [PATCHv17/8] [trivial] Track when QEMU has finished initialization

2015-10-13 Thread Markus Armbruster
Lluís Vilanova writes: > Signed-off-by: Lluís Vilanova Drive-by shooting: the commit message should explain *why* you need to track this.

Re: [Qemu-devel] [PATCH v8 06.5/18] qapi: Drop redundant args-member-array test

2015-10-13 Thread Markus Armbruster
Eric Blake writes: > qapi-schema-test already ensures that we can correctly compile > an array of enums (__org.qemu_x-command), an array of builtins > (UserDefNativeListUnion), and an array of structs (again > __org.qemu_x-command). That means args-member-array is not > adding any additional par

Re: [Qemu-devel] [PATCH v8 00/18] post-introspection cleanups, subset B

2015-10-13 Thread Markus Armbruster
Eric Blake writes: > Pending prerequisite: Markus' qapi-next branch (which has my > subset A patches): > git://repo.or.cz/qemu/armbru.git pull-qapi-2015-10-12 > https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg02796.html > > Also available as a tag at this location: > git fetch git://repo

Re: [Qemu-devel] [PATCH v8 17/18] qapi: Add test for alternate branch 'kind' clash

2015-10-13 Thread Markus Armbruster
Eric Blake writes: > Rename alternate-clash to alternate-clash-members, and add a > new test alternate-clash-type. While similar to the earlier > addition of union-clash-type, we have one major difference: a > future patch will be simplifying alternates to not need an > implict AlternateKind enu

Re: [Qemu-devel] [PATCH v8 16/18] qapi: Move duplicate enum value checks to schema check()

2015-10-13 Thread Markus Armbruster
Eric Blake writes: > Similar to the previous commit, move the detection of a collision > in enum values from parse time to QAPISchemaEnumType.check(). > This happens to also detect collisions in union branch names, > so for a decent error message, we have to determine if the enum > is implicit (a

Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check()

2015-10-13 Thread Markus Armbruster
Eric Blake writes: > On 10/13/2015 11:13 AM, Markus Armbruster wrote: > I've come to the conclusion that we should get rid of the self-inflicted pain before we attempt to detect all collisions. >>> >>> Then that sounds like I should try harder to get the kind/type naming, >>> the b

Re: [Qemu-devel] [PATCH] Limit memory r/w length to buffer size

2015-10-13 Thread P J P
Hello, +-- On Tue, 13 Oct 2015, P J P wrote --+ | Below is a proposed patch to fix this issue. | | === | > From 88edb457a66f8ff96209a1603914171eade0658b Mon Sep 17 00:00:00 2001 | From: Prasad J Pandit | Date: Mon, 12 Oct 2015 22:56:41 +0530 | Subject: Limit memory r/w length to buffer size |

Re: [Qemu-devel] [RFC 3/4] ahci: Add allwinner AHCI

2015-10-13 Thread Beniamino Galvani
On Sun, Oct 11, 2015 at 09:21:35AM -0700, Peter Crosthwaite wrote: > --- a/hw/ide/ahci.c > +++ b/hw/ide/ahci.c > @@ -1692,9 +1692,107 @@ static const TypeInfo sysbus_ahci_info = { > .class_init= sysbus_ahci_class_init, > }; > > +#define ALLWINNER_AHCI_MMIO_OFF 0x80 > +#define ALLWINNER

Re: [Qemu-devel] [PATCHv13/8] trace: [tcg] Identify events with the 'vcpu' property

2015-10-13 Thread Lluís Vilanova
Eric Blake writes: > On 10/13/2015 11:10 AM, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova > If you'd send with 'qemu format-patch/send-email -v1', then your subject > line would be formatted [PATCH v1 3/8] instead of the confusing results > you got by omitting spaces [PATCHv13/8] (this

[Qemu-devel] [PATCH v8 06.5/18] qapi: Drop redundant args-member-array test

2015-10-13 Thread Eric Blake
qapi-schema-test already ensures that we can correctly compile an array of enums (__org.qemu_x-command), an array of builtins (UserDefNativeListUnion), and an array of structs (again __org.qemu_x-command). That means args-member-array is not adding any additional parse-only test coverage, so drop

[Qemu-devel] [PATCHv15/8] exec: [ŧcg] Use multiple physical TB caches

2015-10-13 Thread Lluís Vilanova
The physical translation block cache is split into as many caches as wanted, and the virtual TB cache on each guest CPU uses a (potentially) different physical TB cache. This is later exploited to support different tracing event states on a per-vCPU basis. Signed-off-by: Lluís Vilanova --- cpu-

Re: [Qemu-devel] [PATCH v3 1/4] util - add automated ID generation utility

2015-10-13 Thread John Snow
On 10/13/2015 11:26 AM, Markus Armbruster wrote: > Jeff Cody writes: > >> On Tue, Oct 13, 2015 at 09:37:29AM +0200, Markus Armbruster wrote: >>> Jeff Cody writes: >>> Multiple sub-systems in QEMU may find it useful to generate IDs for objects that a user may reference via QMP or HMP.

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-13 Thread Stefano Stabellini
On Tue, 13 Oct 2015, John Snow wrote: > On 10/13/2015 11:55 AM, Fabio Fantoni wrote: > > I added ahci disk support in libxl and using it for week seems that was > > ok, after a reply of Stefano Stabellini seems that xen disk unplug > > support only ide disks: > > http://git.qemu.org/?p=qemu.git;a=c

Re: [Qemu-devel] [PATCH] Add mp-affinity property for ARM CPU class

2015-10-13 Thread Peter Maydell
On 9 October 2015 at 10:52, Pavel Fedin wrote: > This allows to override default affinity IDs on a per-machine basis, and > possibility to retrieve IDs will be used by vGICv3 live migration code. > > Signed-off-by: Pavel Fedin > --- > Since this popped up several times on the mailing list, i deci

Re: [Qemu-devel] [PULL v3 00/51] Ivshmem patches

2015-10-13 Thread John Snow
On 10/13/2015 01:16 PM, Marc-André Lureau wrote: > > > - Original Message - >> >> >> On 10/13/2015 12:10 PM, Marc-André Lureau wrote: >>> Hi >>> >>> - Original Message - On 13 October 2015 at 15:25, wrote: > From: Marc-André Lureau > > The following changes s

Re: [Qemu-devel] [PATCHv18/8] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property

2015-10-13 Thread Eric Blake
On 10/13/2015 11:11 AM, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- Interface review only. > +++ b/qapi/trace.json > @@ -64,3 +64,34 @@ > ## > { 'command': 'trace-event-set-state', >'data': {'name': 'str', 'enable': 'bool', '*ignore-unavailable': 'bool'} } > + > +## > +# @t

Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check()

2015-10-13 Thread Eric Blake
On 10/13/2015 11:13 AM, Markus Armbruster wrote: >>> >>> I've come to the conclusion that we should get rid of the self-inflicted >>> pain before we attempt to detect all collisions. >> >> Then that sounds like I should try harder to get the kind/type naming, >> the boxed base naming, and even the

Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check()

2015-10-13 Thread Markus Armbruster
First reply: commit message review only. Patch review to follow. Eric Blake writes: > With the previous commit, we have two different locations for > detecting member name clashes - one at parse time, and another > at QAPISchema*.check() time. Consolidate some of the checks > into a single pla

[Qemu-devel] [PATCHv16/8] exec: [tcg] Track which vCPU is performing translation and execution

2015-10-13 Thread Lluís Vilanova
Information is tracked inside the TCGContext structure. Signed-off-by: Lluís Vilanova --- target-alpha/translate.c |1 + target-arm/translate.c|1 + target-cris/translate.c |1 + target-cris/translate_v10.c |1 + target-i386/translate.c |1 + target

[Qemu-devel] [Bug 1505759] [NEW] Usb passthrough on q35 broken.

2015-10-13 Thread José Ramón Muñoz Pekkarinen
Public bug reported: I'm trying to setup a q35 vm with windows 7 guest for vga passthrough. The machine works well for this purpose, but the usb devices passed to the vm does not. I receive the following errors on screen: qemu-system-x86_64: libusb_release_interface: -4 [NO_DEVICE] libusb: error

[Qemu-devel] [PATCHv14/8] exec: [tcg] Refactor flush of per-CPU virtual TB cache

2015-10-13 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- cputlb.c|2 +- include/exec/exec-all.h |6 ++ translate-all.c |7 ++- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/cputlb.c b/cputlb.c index bf1d50a..74bf989 100644 --- a/cputlb.c +++ b/cputlb.c @@ -6

Re: [Qemu-devel] [PATCH v2] hw/arm/virt: Allow zero address for PCI IO space

2015-10-13 Thread Peter Maydell
On 13 October 2015 at 15:35, Alexander Gordeev wrote: > Currently PCI IO address 0 is not allowed even though > the IO space starts from 0. This update makes PCI IO > address 0 usable. > > CC: Peter Maydell > CC: Andrew Jones > Signed-off-by: Alexander Gordeev > --- > hw/arm/virt.c | 1 + > 1

Re: [Qemu-devel] [PATCHv13/8] trace: [tcg] Identify events with the 'vcpu' property

2015-10-13 Thread Eric Blake
On 10/13/2015 11:10 AM, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova If you'd send with 'qemu format-patch/send-email -v1', then your subject line would be formatted [PATCH v1 3/8] instead of the confusing results you got by omitting spaces [PATCHv13/8] (this is v13? out of 8?). Also, n

Re: [Qemu-devel] [PATCH v3 25/32] nvdimm: build ACPI nvdimm devices

2015-10-13 Thread Xiao Guangrong
On 10/13/2015 10:39 PM, Igor Mammedov wrote: On Sun, 11 Oct 2015 11:52:57 +0800 Xiao Guangrong wrote: NVDIMM devices is defined in ACPI 6.0 9.20 NVDIMM Devices There is a root device under \_SB and specified NVDIMM devices are under the root device. Each NVDIMM device has _ADR which returns

Re: [Qemu-devel] [PATCH v2] README: fill out some useful quickstart information

2015-10-13 Thread Eric Blake
On 10/12/2015 11:41 AM, Daniel P. Berrange wrote: > The README file is usually the first thing consulted when a user > or developer obtains a copy of the QEMU source. The current QEMU > README is lacking immediately useful information and so not very > friendly for first time encounters. It either

Re: [Qemu-devel] [PATCH v2] target-arm: Add MDCR_EL2

2015-10-13 Thread Peter Maydell
On 9 October 2015 at 10:43, Sergey Fedorov wrote: > Signed-off-by: Sergey Fedorov > --- > > Changes in v2: > * Reset value is simply made zero > > target-arm/cpu.h| 1 + > target-arm/helper.c | 11 +++ > 2 files changed, 12 insertions(+) > Applied to target-arm.next, thanks (I exp

Re: [Qemu-devel] [RFC][PATCHv10/8] trace: Per-vCPU tracing states

2015-10-13 Thread Lluís Vilanova
Sorry I messed the title format, but I guess this does not warrant a re-send. Cheers, Lluis -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom

Re: [Qemu-devel] [PATCH v2] README: fill out some useful quickstart information

2015-10-13 Thread Markus Armbruster
"Daniel P. Berrange" writes: > The README file is usually the first thing consulted when a user > or developer obtains a copy of the QEMU source. The current QEMU > README is lacking immediately useful information and so not very > friendly for first time encounters. It either redirects users to

Re: [Qemu-devel] [PATCH] misc: zynq_slcr: Fix MMIO writes

2015-10-13 Thread Peter Maydell
On 10 October 2015 at 03:53, Peter Crosthwaite wrote: > The /4 for offset calculation in MMIO writes was happening twice giving > wrong write offsets. Fix. > > While touching the code, change the if-else to be a short returning if > and convert the debug message to a GUEST_ERROR, which is more acc

Re: [Qemu-devel] [PATCH] arm: imx25-pdk: Fix machine name

2015-10-13 Thread Peter Maydell
On 10 October 2015 at 03:56, Peter Crosthwaite wrote: > ARM uses dashes instead of underscores for machine names. Fix imx25_pdk > which has not seen a release yet (so there is no legacy yet). > > Cc: Jean-Christophe Dubois > Signed-off-by: Peter Crosthwaite > --- > hw/arm/imx25_pdk.c | 2 +- >

Re: [Qemu-devel] [PULL v3 01/51] tests: Add ivshmem qtest

2015-10-13 Thread Andreas Färber
Am 13.10.2015 um 19:07 schrieb Marc-André Lureau: > On Tue, Oct 13, 2015 at 4:25 PM, wrote: >> +check-qtest-pci-$(CONFIG_IVSHMEM) += tests/ivshmem-test$(EXESUF) > > This is not being built. CONFIG_IVSHMEM nor CONFIG_KVM are available > here, but CONFIG_POSIX is. Correct, because this is for the

Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check()

2015-10-13 Thread Markus Armbruster
Eric Blake writes: > On 10/13/2015 09:06 AM, Markus Armbruster wrote: >> First reply: commit message review only. Patch review to follow. >> >> Eric Blake writes: >> >>> With the previous commit, we have two different locations for >>> detecting member name clashes - one at parse time, and an

[Qemu-devel] [PATCHv11/8] trace: Add support for vCPU pointers in trace events

2015-10-13 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/transform.py |9 - target-alpha/translate.c |2 +- target-arm/translate.c |2 +- target-arm/translate.h |2 +- target-cris/translate.c|2 +- target-i386/translate.c|2 +- targ

[Qemu-devel] [PATCHv18/8] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property

2015-10-13 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile.objs|1 include/qom/cpu.h|5 + qapi/trace.json | 31 +++ qmp-commands.hx | 27 ++ qom/cpu.c| 12 +

Re: [Qemu-devel] [PULL v3 00/51] Ivshmem patches

2015-10-13 Thread Marc-André Lureau
- Original Message - > > > On 10/13/2015 12:10 PM, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > >> On 13 October 2015 at 15:25, wrote: > >>> From: Marc-André Lureau > >>> > >>> The following changes since commit > >>> c49d3411faae8ffaab8f7e5db47405a008411c1

[Qemu-devel] [PATCHv13/8] trace: [tcg] Identify events with the 'vcpu' property

2015-10-13 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- qapi/trace.json |5 +++-- scripts/tracetool/format/events_c.py | 11 +-- scripts/tracetool/format/events_h.py | 12 +++- trace/control-internal.h |8 +++- trace/control.h |7

[Qemu-devel] [RFC][PATCHv10/8] trace: Per-vCPU tracing states

2015-10-13 Thread Lluís Vilanova
Adds the "vcpu" event property to identify events tied to a specific vCPU. In addition, it allows controlling the tracing state of such events on a per-vCPU basis. Events with the "vcpu" property are identified as being tied to a particular virtual CPU, like executing an instruction. The state of

[Qemu-devel] [Bug 1479717] Re: Auto resize VM doesn't work with windows 10 guest

2015-10-13 Thread Jean-Pierre van Riel
I've observed the same issue (in Ubuntu Gnome 15.04). In addition, when I select '' from the Virtual Machine Manager, View, Scale Display, Auto Resize VM with Window, the guest's screen starts flickering. On Windows 10 64bit, virtio drivers and QXL installed from ISO extracted out the RPM here: ht

[Qemu-devel] [PATCHv12/8] trace: Add 'vcpu' event property

2015-10-13 Thread Lluís Vilanova
This property identifies events that trace vCPU-specific information. It adds an implicit "CPUState*" argument that identifies the vCPU raising this event. TCG translation events have an additional "TCGv_cpu" implicit argument that is later used as the "CPUState*" argument at execution time. Sign

Re: [Qemu-devel] [PULL v3 01/51] tests: Add ivshmem qtest

2015-10-13 Thread Marc-André Lureau
On Tue, Oct 13, 2015 at 4:25 PM, wrote: > +check-qtest-pci-$(CONFIG_IVSHMEM) += tests/ivshmem-test$(EXESUF) This is not being built. CONFIG_IVSHMEM nor CONFIG_KVM are available here, but CONFIG_POSIX is. -- Marc-André Lureau

[Qemu-devel] [PULL v3 36/51] ivshmem-server: fix hugetlbfs support

2015-10-13 Thread marcandre . lureau
From: Marc-André Lureau As pointed out on the ML by Andrew Jones, glibc no longer permits creating POSIX shm on hugetlbfs directly. When given a hugetlbfs path, create a shareable file there. Signed-off-by: Marc-André Lureau Reviewed-by: Vladimir Sementsov-Ogievskiy --- contrib/ivshmem-server

Re: [Qemu-devel] [RFH PATCH 0/4] record/replay fixups and doubts

2015-10-13 Thread Paolo Bonzini
On 13/10/2015 10:10, Pavel Dovgaluk wrote: > Sometimes replay cannot continue after stopping/restarting of the virtual > machine. > This happens because warp on stopped machine and on running machine behaves > differently. > Timers deadline calculation depends on enabled flag of the virtual tim

Re: [Qemu-devel] [PULL v3 00/51] Ivshmem patches

2015-10-13 Thread John Snow
On 10/13/2015 12:10 PM, Marc-André Lureau wrote: > Hi > > - Original Message - >> On 13 October 2015 at 15:25, wrote: >>> From: Marc-André Lureau >>> >>> The following changes since commit >>> c49d3411faae8ffaab8f7e5db47405a008411c10: >>> >>> Merge remote-tracking branch 'remotes/ar

Re: [Qemu-devel] [PATCH v3 11/32] hostmem-file: use whole file size if possible

2015-10-13 Thread Xiao Guangrong
On 10/13/2015 07:50 PM, Vladimir Sementsov-Ogievskiy wrote: On 11.10.2015 06:52, Xiao Guangrong wrote: Use the whole file size if @size is not specified which is useful if we want to directly pass a file to guest Signed-off-by: Xiao Guangrong --- backends/hostmem-file.c | 47 ++

Re: [Qemu-devel] [PATCH v8 10/18] qapi: Move union tag quirks into subclass

2015-10-13 Thread Markus Armbruster
Eric Blake writes: > On 10/13/2015 06:10 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Right now, simple unions have a quirk of using 'kind' in the C >>> struct to match the QMP wire name 'type'. This has resulted in >>> messy clients each doing special cases. While we plan to >>>

Re: [Qemu-devel] [PATCH v3 04/32] acpi: add aml_mutex, aml_acquire, aml_release

2015-10-13 Thread Xiao Guangrong
On 10/13/2015 09:34 PM, Igor Mammedov wrote: On Sun, 11 Oct 2015 11:52:36 +0800 Xiao Guangrong wrote: Implement Mutex, Acquire and Release terms which are used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 32

  1   2   3   4   >