On 10/13/2015 11:11 AM, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu> > ---
Interface review only.
> +++ b/qapi/trace.json
> @@ -64,3 +64,34 @@
> ##
> { 'command': 'trace-event-set-state',
> 'data': {'name': 'str', 'enable': 'bool', '*ignore-unavailable': 'bool'} }
> +
> +##
> +# @trace-event-get-cpu-state:
> +#
> +# Query the state of events in a given vCPU.
> +#
> +# @name: Event name pattern.
> +# @vcpu: The vCPU to check.
> +#
> +# Returns: @TraceEventInfo of the matched events
> +#
> +# Since 2.2
2.5, not 2.2
> +##
> +{ 'command': 'trace-event-get-cpu-state',
> + 'data': {'name': 'str', 'vcpu': 'int'},
> + 'returns': ['TraceEventInfo'] }
> +
> +##
> +# @trace-event-set-cpu-state:
> +#
> +# Set the dynamic state of events in a given vCPU.
> +#
> +# @name: Event name pattern.
> +# @vcpu: The vCPU to act upon.
> +# @enable: Whether to enable tracing.
> +# @ignore-unavailable: #optional Do not match unavailable events with @name.
> +#
> +# Since 2.2
2.5, not 2.2
> +##
> +{ 'command': 'trace-event-set-cpu-state',
> + 'data': {'name': 'str', 'vcpu': 'int', 'enable': 'bool',
> '*ignore-unavailable': 'bool'} }
This looks identical to trace-event-set-state, except that it now has a
'vcpu':'int' argument. Would it be any simpler to just modify the
existing command:
##
# @trace-event-set-state:
...
# @vcpu: #optional If provided, limit the state change to the given vcpu
(default act on all vcpus) (since 2.5)
#
# Since 2.2
##
{ 'command': 'trace-event-set-state',
'data': {'name': 'str', 'enable': 'bool',
'*vcpu': 'int', '*ignore-unavailable': 'bool'} }
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
