Re: [Qemu-devel] [PATCH 13/16] block: Implement bdrv_append() without bdrv_swap()

2015-09-29 Thread Kevin Wolf
Am 23.09.2015 um 18:36 hat Max Reitz geschrieben: > On 17.09.2015 15:48, Kevin Wolf wrote: > > Remember all parent nodes and just change the pointers there instead of > > swapping the contents of the BlockDriverState. > > > > Handling of snapshot=on must be moved further down in bdrv_open() > > be

Re: [Qemu-devel] [PATCH v4 33/47] ivshmem-server: use a uint16 for client ID

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > In practice, the number of VM is limited to MAXUINT16 in ivshmem, so use > the same limit on the server (removes a theorical infinite loop) > > Signed-off-by: Marc-André Lureau > --- > contrib/ivshmem-server/

Re: [Qemu-devel] [PATCH v4 32/47] ivshmem-client: check the number of vectors

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Check the number of vectors received from the server, to avoid > out of bound array access. > > Signed-off-by: Marc-André Lureau > --- > contrib/ivshmem-client/ivshmem-client.c | 4 > 1 file changed, 4 i

Re: [Qemu-devel] [PATCH v6 10/16] qapi: Consistent generated code: prefer error 'err'

2015-09-29 Thread Markus Armbruster
Eric Blake writes: > We had some pointless differences in the generated code for visit, > command marshalling, and events; unifying them makes it easier for > future patches to consolidate to common helper functions. > > This is patch 1/4, focusing on naming the local error variable > 'err' rathe

Re: [Qemu-devel] [PATCH v4 30/47] ivshmem: reset mask on device reset

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The interrupt mask is a state value, it should be reset, like the > interrupt status. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/h

Re: [Qemu-devel] [PATCH v4 23/47] ivshmem: migrate with VMStateDescription

2015-09-29 Thread Marc-André Lureau
- Original Message - > On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > load_state_old() is used to keep compatibility with version 0. > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/misc/ivshmem.c | 141 > >

Re: [Qemu-devel] [PATCH v4 29/47] ivshmem: error on too many eventfd received

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The number of eventfd that can be handled per peer is limited by the > number of vectors. Return an error when receiving too many of them. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 8 ++

Re: [Qemu-devel] [PATCH v4 27/47] ivshmem: fix pci_ivshmem_exit()

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Free all objects owned by the device, making sure the device is free, > fixing hot-unplug. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 38 +++--- > 1 file

Re: [Qemu-devel] [PATCH v6 08/16] qapi: Test use of 'number' within alternates

2015-09-29 Thread Markus Armbruster
Eric Blake writes: > Add some testsuite exposure for use of a 'number' as part of > an alternate. The current state of the tree has a few bugs > exposed by this: our input parser depends on the ordering of > how the qapi schema declared the alternate, and the parser > does not accept integers fo

Re: [Qemu-devel] [PATCH 09/16] block: Split bdrv_move_feature_fields()

2015-09-29 Thread Kevin Wolf
Am 23.09.2015 um 18:36 hat Max Reitz geschrieben: > On 17.09.2015 15:48, Kevin Wolf wrote: > > After bdrv_swap(), some fields must be moved back to their original BDS > > to compensate for the effects that a swap of the contents of the objects > > has while keeping the old addresses. Other fields m

Re: [Qemu-devel] [PATCH v4 17/47] ivshmem: improve debug messages

2015-09-29 Thread Claudio Fontana
On 29.09.2015 15:24, Marc-André Lureau wrote: > Hi > >>> It helps to trace what's going on, at least it helped me. But if it's >>> superflous, we can remove it (though it's really only there to help >>> developers) >>> >> >> Ok lets be nice to them and say ivshmem_use_msix in there, so they find s

Re: [Qemu-devel] [PATCH v4 25/47] ivshmem: check shm isn't already initialized

2015-09-29 Thread Marc-André Lureau
Hi - Original Message - > On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > The server should not change the shm, and this isn't handled by qemu. > > "..., and we should verify this in QEMU?" ok, I'll add that > > > > > Signed-off-by: Marc-A

Re: [Qemu-devel] [PATCH v4 25/47] ivshmem: check shm isn't already initialized

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The server should not change the shm, and this isn't handled by qemu. "..., and we should verify this in QEMU?" > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 6 ++ > 1 file changed, 6

Re: [Qemu-devel] feature idea: allow user to run custom scripts

2015-09-29 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 29 September 2015 at 14:11, Dr. David Alan Gilbert > wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > >> On 28 September 2015 at 20:43, Programmingkid > >> wrote: > >> > > >> > On Sep 28, 2015, at 3:29 AM, Markus Armbruster wro

Re: [Qemu-devel] [PATCH V2] vnc: destroy server surface if no client is connected

2015-09-29 Thread Peter Lieven
> Am 29.09.2015 um 14:49 schrieb Gerd Hoffmann : > > On Di, 2015-09-29 at 14:41 +0200, Peter Lieven wrote: >>> Am 29.09.2015 um 12:28 schrieb Gerd Hoffmann : >>> >>> Hi, >>> -graphic_hw_update(vd->dcl.con); +if (first_client) { +/* set/restore the correct surface

[Qemu-devel] [PATCH V9 1/3] sd.h: Move sd.h to include/hw/sd/

2015-09-29 Thread Sai Pavan Boddu
Create a sd directory under include/hw/ and move sd.h to same. Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- Changes for V9: None. Changes for V8: None Changes for V7: None Changes for V6: Fix commit message. Changes for V5:

[Qemu-devel] [PATCH V9 2/3] sdhci: Split sdhci.h for public and internal device usage

2015-09-29 Thread Sai Pavan Boddu
Split sdhci.h into pubilc version (i.e include/hw/sd/sdhci.h) and internal version (i.e hw/sd/sdhci-interna.h) based on register declarations and object declaration. Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- Changes for V9: None Changes

[Qemu-devel] [PATCH V9 0/3] Move sdhci.h to include/hw/sd

2015-09-29 Thread Sai Pavan Boddu
Move sdhci.h splitting it into common and internal. Create a new directory for sd in include/hw/. Correct paths of sd.h in at every instance of #include. Add sdhci device to xlnx-zynqmp. Sai Pavan Boddu (3): sd.h: Move sd.h to include/hw/sd/ sdhci: Split sdhci.h for public and internal device

Re: [Qemu-devel] [PATCH v4 23/47] ivshmem: migrate with VMStateDescription

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > load_state_old() is used to keep compatibility with version 0. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 141 > ++ > 1 file changed,

Re: [Qemu-devel] feature idea: allow user to run custom scripts

2015-09-29 Thread Peter Maydell
On 29 September 2015 at 14:11, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 28 September 2015 at 20:43, Programmingkid >> wrote: >> > >> > On Sep 28, 2015, at 3:29 AM, Markus Armbruster wrote: >> >> You didn't mention you're talking about a *GUI* featur

Re: [Qemu-devel] [PATCH v4 17/47] ivshmem: improve debug messages

2015-09-29 Thread Marc-André Lureau
Hi > > It helps to trace what's going on, at least it helped me. But if it's > > superflous, we can remove it (though it's really only there to help > > developers) > > > > Ok lets be nice to them and say ivshmem_use_msix in there, so they find stuff > quickly? > > $ time fgrep -R "use msix" *

Re: [Qemu-devel] [migration PULL 0/9] Migration queue - for Juan

2015-09-29 Thread Peter Maydell
On 29 September 2015 at 14:05, Amit Shah wrote: > On (Tue) 29 Sep 2015 [13:50:10], Peter Maydell wrote: >> On 29 September 2015 at 07:32, Amit Shah wrote: >> > Hi Juan, >> > >> > Here are a few patches from the list that have been reviewed by at >> > least one person. >> > >> > Would be great to

Re: [Qemu-devel] feature idea: allow user to run custom scripts

2015-09-29 Thread Dr. David Alan Gilbert
* Programmingkid (programmingk...@gmail.com) wrote: > > On Sep 29, 2015, at 9:11 AM, Dr. David Alan Gilbert wrote: > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > >> On 28 September 2015 at 20:43, Programmingkid > >> wrote: > >>> > >>> On Sep 28, 2015, at 3:29 AM, Markus Armbruster w

Re: [Qemu-devel] [PATCH v4 17/47] ivshmem: improve debug messages

2015-09-29 Thread Claudio Fontana
On 29.09.2015 15:12, Marc-André Lureau wrote: > > > - Original Message - >> On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> Some misc improvements to ivshmem debug. >>> >>> Signed-off-by: Marc-André Lureau >>> --- >>> hw/misc/ivshmem.c | 10 +

Re: [Qemu-devel] [PATCH v6 07/16] qapi: Add tests for empty unions

2015-09-29 Thread Markus Armbruster
Eric Blake writes: > The documentation claims that alternates are useful for > allowing two types, although nothing enforces this. Meanwhile, "two or more" Can touch up on commit. > it is silent on whether empty unions are allowed. In practice, > the generated code will compile, in part beca

Re: [Qemu-devel] feature idea: allow user to run custom scripts

2015-09-29 Thread Programmingkid
On Sep 29, 2015, at 9:11 AM, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 28 September 2015 at 20:43, Programmingkid >> wrote: >>> >>> On Sep 28, 2015, at 3:29 AM, Markus Armbruster wrote: >>> Programmingkid writes: >

Re: [Qemu-devel] [PATCH v4 03/47] ivhsmem: read do not accept more than sizeof(long)

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > ivshmem_read() only reads sizeof(long) from the input buffer. Accepting > more could lead to fifo8 abort() on 32bit systems if fifo is not empty. > > A following patch will change the protocol to 64-bit little

Re: [Qemu-devel] [PATCH v4 02/47] msix: add VMSTATE_MSIX_TEST

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > ivshmem is going to use MSIX state conditionally. > > Signed-off-by: Marc-André Lureau > --- > include/hw/pci/msix.h | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a

Re: [Qemu-devel] [PATCH v2 04/11] virtio-gpu: move iov free to virtio_gpu_cleanup_mapping_iov

2015-09-29 Thread Michael S. Tsirkin
On Fri, Sep 25, 2015 at 03:14:59PM +0200, Gerd Hoffmann wrote: > On Do, 2015-09-24 at 13:16 +0300, Michael S. Tsirkin wrote: > > On Thu, Sep 24, 2015 at 11:04:55AM +0200, Gerd Hoffmann wrote: > > > Signed-off-by: Gerd Hoffmann > > > > It's easy to see this is what the patch does. But why? Some

Re: [Qemu-devel] [PATCH v4 01/47] char: add qemu_chr_free()

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > If a chardev is allowed to be created outside of QMP, then it must be > also possible to free it. This is useful for ivshmem that creates > chardev anonymously and must be able to free them. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v4 17/47] ivshmem: improve debug messages

2015-09-29 Thread Marc-André Lureau
- Original Message - > On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Some misc improvements to ivshmem debug. > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/misc/ivshmem.c | 10 +++--- > > 1 file changed, 7 insertions(+), 3 d

Re: [Qemu-devel] [PATCH v5 17/38] block: Add BlockBackendRootState

2015-09-29 Thread Kevin Wolf
Am 29.09.2015 um 14:30 hat Eric Blake geschrieben: > On 09/29/2015 05:17 AM, Alberto Garcia wrote: > > On Tue 22 Sep 2015 05:00:05 PM CEST, Max Reitz wrote: > > > >>> The correct way to solve this seems to be that each BB has its own > >>> I/O throttling filter. Actually, if we could lift the thro

Re: [Qemu-devel] feature idea: allow user to run custom scripts

2015-09-29 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 28 September 2015 at 20:43, Programmingkid > wrote: > > > > On Sep 28, 2015, at 3:29 AM, Markus Armbruster wrote: > > > >> Programmingkid writes: > >>> A menu item > >>> that displays a

Re: [Qemu-devel] [PATCH v4 20/47] ivshmem: simplify a bit the code

2015-09-29 Thread Marc-André Lureau
Hi - Original Message - > On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Use some more explicit variables to simplify the code. > > > > nth_eventfd variable is the current eventfd to be manipulated. > > "the new_eventfd variable is the new e

Re: [Qemu-devel] [migration PULL 0/9] Migration queue - for Juan

2015-09-29 Thread Amit Shah
On (Tue) 29 Sep 2015 [13:50:10], Peter Maydell wrote: > On 29 September 2015 at 07:32, Amit Shah wrote: > > Hi Juan, > > > > Here are a few patches from the list that have been reviewed by at > > least one person. > > > > Would be great to have your review and then a pull. > > Whoops, I just appl

Re: [Qemu-devel] [PATCH v4 20/47] ivshmem: simplify a bit the code

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Use some more explicit variables to simplify the code. > > nth_eventfd variable is the current eventfd to be manipulated. "the new_eventfd variable is the new eventfd to be manipulated". Although after the nam

Re: [Qemu-devel] [PATCH v4 18/47] ivshmem: improve error handling

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The test whether the chardev is an AF_UNIX socket rejects > "-chardev socket,id=chr0,path=/tmp/foo,server,nowait -device > ivshmem,chardev=chr0", but fails to explain why. > > Use an explicit error on why a cha

Re: [Qemu-devel] [PATCH v4 17/47] ivshmem: improve debug messages

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Some misc improvements to ivshmem debug. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/hw/misc/ivshmem.c b

Re: [Qemu-devel] [PATCH v6 04/16] qapi: Clean up qapi.py per pep8

2015-09-29 Thread Eric Blake
On 09/29/2015 04:58 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Silence pep8, and make pylint a bit happier. Just style cleanups, >> plus killing a useless comment in camel_to_upper(); no semantic >> changes. >> >> Signed-off-by: Eric Blake > [...] >> diff --git a/scripts/qapi.py b/s

Re: [Qemu-devel] [PATCH v4 13/47] ivshmem: allocate eventfds in resize_peers()

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > It simplifies a bit the code to allocate the array when setting the > number of peers instead of lazily when receiving the first vector. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 11 ++-

Re: [Qemu-devel] [migration PULL 0/9] Migration queue - for Juan

2015-09-29 Thread Peter Maydell
On 29 September 2015 at 07:32, Amit Shah wrote: > Hi Juan, > > Here are a few patches from the list that have been reviewed by at > least one person. > > Would be great to have your review and then a pull. Whoops, I just applied this to master because I didn't pay enough attention to the cover le

Re: [Qemu-devel] [PATCH] block: disable I/O limits at the beginning of bdrv_close()

2015-09-29 Thread Kevin Wolf
Am 25.09.2015 um 15:41 hat Alberto Garcia geschrieben: > Disabling I/O limits from a BDS also drains all pending throttled > requests, so it should be done at the beginning of bdrv_close() with > the rest of the bdrv_drain() calls before the BlockDriver is closed. > > Signed-off-by: Alberto Garcia

Re: [Qemu-devel] [PATCH V2] vnc: destroy server surface if no client is connected

2015-09-29 Thread Gerd Hoffmann
On Di, 2015-09-29 at 14:41 +0200, Peter Lieven wrote: > > Am 29.09.2015 um 12:28 schrieb Gerd Hoffmann : > > > > Hi, > > > >> -graphic_hw_update(vd->dcl.con); > >> +if (first_client) { > >> +/* set/restore the correct surface in the VNC server */ > >> +console_select(0);

Re: [Qemu-devel] [PATCH v4 16/47] ivshmem: remove max_peer field

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > max_peer isn't really useful, it tracks the maximum received VM id, but > that quickly matches nb_peers, the size of the peers array. Since VM > come and go, there might be sparse peers so it doesn't help much i

Re: [Qemu-devel] [PATCH v2 00/11] add virgl rendering support

2015-09-29 Thread Gerd Hoffmann
On Mo, 2015-09-28 at 18:07 +0200, Max Reitz wrote: > On 24.09.2015 19:09, Marc-André Lureau wrote: > > Hi Gerd > > > > On Thu, Sep 24, 2015 at 11:04 AM, Gerd Hoffmann wrote: > >> Hi, > >> > >> This patch series adds infrastructure for opengl rendering > >> (context management, define scanout te

Re: [Qemu-devel] [PATCH v4 5/7] qmp: Fix device-list-properties not to crash for abstract device

2015-09-29 Thread Markus Armbruster
Thomas Huth writes: > On 28/09/15 22:08, Markus Armbruster wrote: >> Broken in commit f4eb32b "qmp: show QOM properties in >> device-list-properties", v2.1. >> >> Cc: qemu-sta...@nongnu.org >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >> --- >> qmp.c

Re: [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init

2015-09-29 Thread Peter Maydell
On 29 September 2015 at 13:37, Paolo Bonzini wrote: > This causes the region to outlive the object, because it attaches the > region to /machine. This is not nice for the "realize" method, but > much worse for "instance_init" because it can cause dangling pointers > after a simple object_new/obje

Re: [Qemu-devel] [PATCH v4 09/47] ivshmem: more qdev conversion

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Use the latest qemu device modeling API, in particular, convert to > realize to fix the error handling; right now a botched device_add > ivhsmem command kills the VM. > > Signed-off-by: Marc-André Lureau > ---

Re: [Qemu-devel] [PATCH v4 10/47] ivshmem: remove last exit(1)

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Failing to create a chardev shouldn't be fatal. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/ivshmem.c b/hw/

Re: [Qemu-devel] [PATCH v4 07/47] ivshmem: remove superflous ivshmem_attr field

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 16 +++- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c > index fbeb731..7138

Re: [Qemu-devel] [PATCH v4 3/7] libqtest: New hmp() & friends

2015-09-29 Thread Markus Armbruster
Thomas Huth writes: > On 28/09/15 22:08, Markus Armbruster wrote: >> New convenience function hmp() to facilitate use of >> human-monitor-command in tests. Use it to simplify its existing uses. >> >> To blend into existing libqtest code, also add qtest_hmpv() and >> qtest_hmp(). That, and the

Re: [Qemu-devel] [PATCH v4 06/47] ivshmem: remove unnecessary dup()

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > qemu_chr_fe_get_msgfd() transfers ownership, there is no need to dup the > fd. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 21 ++--- > 1 file changed, 6 insertions(+), 15

Re: [Qemu-devel] [PATCH v4 05/47] ivshmem: factor out the incoming fifo handling

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Make a new function fifo_update_and_get() that can be reused by other > functions (in next commits). > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 59 >

Re: [Qemu-devel] [PATCH V2] vnc: destroy server surface if no client is connected

2015-09-29 Thread Peter Lieven
> Am 29.09.2015 um 12:28 schrieb Gerd Hoffmann : > > Hi, > >> -graphic_hw_update(vd->dcl.con); >> +if (first_client) { >> +/* set/restore the correct surface in the VNC server */ >> +console_select(0); > > Nah, that has unwanted side effects. okay, ill try to respin wi

Re: [Qemu-devel] [PATCH v4 04/47] ivshmem: fix number of bytes to push to fifo

2015-09-29 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > If the fifo has 0 bytes, and the read is of size 1, the call to > fifo8_push_all() will copy off boundary data. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 2 +- > 1 file changed, 1 inser

Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices

2015-09-29 Thread Paolo Bonzini
On 2/09/2015 10:05, Markus Armbruster wrote: > > > 1. I made device-introspection-test run "info qom-tree", which has a > > >lovely propensity to crash when a crappy device left dangling pointer > > >behind. This led me to "cgthree", "cuda", "integrator_debug", > > >"macio-oldworld", "

[Qemu-devel] [PATCH 3/3] macio: move DBDMA_init from instance_init to realize

2015-09-29 Thread Paolo Bonzini
DBDMA_init is not idempotent, and calling it from instance_init breaks a simple object_new/object_unref pair. Work around this, pending qdev-ification of DBDMA, by moving the call to realize. Reported-by: Markus Armbruster Signed-off-by: Paolo Bonzini --- hw/misc/macio/macio.c | 8 1

[Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init

2015-09-29 Thread Paolo Bonzini
This causes the region to outlive the object, because it attaches the region to /machine. This is not nice for the "realize" method, but much worse for "instance_init" because it can cause dangling pointers after a simple object_new/object_unref pair. Reported-by: Markus Armbruster Signed-off-by

[Qemu-devel] [PATCH 1/3] memory: allow destroying a non-empty MemoryRegion

2015-09-29 Thread Paolo Bonzini
This is legal; the MemoryRegion will simply unreference all the existing subregions and possibly bring them down with it as well. However, it requires a bit of care to avoid an infinite loop. Finalizing a memory region cannot trigger an address space update, but memory_region_del_subregion errs on

[Qemu-devel] [PATCH 0/3] Fix dangling pointers from memory_region_init_*

2015-09-29 Thread Paolo Bonzini
Some devices do not support a simple object_new/object_unref sequence because they leave dangling pointers under /machine. This series fixes this, for the case where the dangling pointers come from the memory API. Patch 1 avoids an assertion failure. Patches 2 and 3 fix the devices that Markus r

Re: [Qemu-devel] [PATCH v6 06/16] qapi: Avoid assertion failure on union 'type' collision

2015-09-29 Thread Markus Armbruster
Eric Blake writes: > The previous commit added two tests that triggered an assertion > failure. It's fairly straightforward to avoid the failure by > just outright forbidding the collision between a union's tag > values and its discriminator name (including the implicit name > 'kind' supplied for

Re: [Qemu-devel] [PATCH v6 05/16] qapi: Test for various name collisions

2015-09-29 Thread Markus Armbruster
Eric Blake writes: > Expose some weaknesses in the generator: we don't always forbid > the generation of structs that contain multiple members that map > to the same C name. C or QMP name, perhaps? > This has already been marked FIXME in > qapi.py in commit d90675f, but hav

Re: [Qemu-devel] [PATCH v5 17/38] block: Add BlockBackendRootState

2015-09-29 Thread Eric Blake
On 09/29/2015 05:17 AM, Alberto Garcia wrote: > On Tue 22 Sep 2015 05:00:05 PM CEST, Max Reitz wrote: > >>> The correct way to solve this seems to be that each BB has its own >>> I/O throttling filter. Actually, if we could lift the throttling code >>> to BlockBackend, that might solve the problem

Re: [Qemu-devel] [PATCH 10/16] block/io: Make bdrv_requests_pending() public

2015-09-29 Thread Kevin Wolf
Am 23.09.2015 um 17:40 hat Max Reitz geschrieben: > On 17.09.2015 15:48, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > block/io.c| 2 +- > > include/block/block_int.h | 1 + > > 2 files changed, 2 insertions(+), 1 deletion(-) > > Reviewed-by: Max Reitz > > In addi

Re: [Qemu-devel] [PATCH 12/16] block: Introduce parents list

2015-09-29 Thread Kevin Wolf
Am 28.09.2015 um 15:09 hat Alberto Garcia geschrieben: > On Thu 17 Sep 2015 03:48:16 PM CEST, Kevin Wolf wrote: > > > @@ -1090,6 +1090,7 @@ static BdrvChild *bdrv_attach_child(BlockDriverState > > *parent_bs, > > }; > > > > QLIST_INSERT_HEAD(&parent_bs->children, child, next); > > +

[Qemu-devel] [PATCH v2] vhost-user-test: do not reinvent glib-compat.h

2015-09-29 Thread Paolo Bonzini
glib-compat.h has the gunk to support both old-style and new-style gthread functions. Use it instead of reinventing it. Signed-off-by: Paolo Bonzini --- tests/vhost-user-test.c | 113 +++- 1 file changed, 16 insertions(+), 97 deletions(-) diff --git

[Qemu-devel] [PATCH] vhost-user-test: do not reinvent glib-compat.h

2015-09-29 Thread Paolo Bonzini
glib-compat.h has the gunk to support both old-style and new-style gthread functions. Use it instead of reinventing it. Signed-off-by: Paolo Bonzini --- memory.c| 12 - tests/vhost-user-test.c | 113 +++- 2 files changed, 26 inser

Re: [Qemu-devel] [PATCH] handle_aiocb_rw() can't distinguish between an error and 0 bytes transferred

2015-09-29 Thread Kevin Wolf
Hi, thanks for sending this patch. The actual change looks correct, but there are a few formal problems with your patch submission. I can fix these problems myself and apply the patch anyway, but I want to let you know so you can improve your future patches. If you were not a first time contribut

[Qemu-devel] [PATCH v2] virtio-9p: migrate virtio subsections

2015-09-29 Thread Greg Kurz
In a cross-endian setup, the virtio-9p device has state in @device_endian. It must be migrated. This patch just adds the minimal support to live migrate generic virtio subsections where @device_endian is handled. Please note that this is unrelated to the fact that we block migration when the 9p sh

[Qemu-devel] qemu 2.4 machine + kernel 4.2 + kvm : freeze & cpu 100% at start on some hardware (maybe KVM_CAP_X86_SMM related)

2015-09-29 Thread Alexandre DERUMIER
Hi, I'm currently implementing qemu 2.4 for proxmox hypervisors, and a lot of users have reported qemu freeze with cpu at 100% when starting. Connecting with vnc display : "qemu guest has not initialized the display yet" Similar bug report here : https://lacyc3.eu/qemu-guest-has-not-initialized-

Re: [Qemu-devel] Problems on vlan-based vnics!

2015-09-29 Thread cauchy-love
BTW: the virt-manager works well on the server. I don't know how to make the multiple NICs work using command line. 在 2015-09-29 11:19:41,"Jason Wang" 写道: On 09/28/2015 07:52 PM, cauchy-love wrote: > hi stefan. >I have setup a VM on a server with two NICs (eth0 and eth1). eth0 is > connec

Re: [Qemu-devel] [PULL 0/7] X86 queue, 2015-09-28

2015-09-29 Thread Peter Maydell
On 29 September 2015 at 12:28, Peter Maydell wrote: > On 28 September 2015 at 18:31, Eduardo Habkost wrote: >> The following changes since commit 9e071429e649346c14b2dc76902f84f8352d2333: >> >> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into >> staging (2015-09-25 21:52:3

Re: [Qemu-devel] [PULL 0/7] X86 queue, 2015-09-28

2015-09-29 Thread Peter Maydell
On 28 September 2015 at 18:31, Eduardo Habkost wrote: > The following changes since commit 9e071429e649346c14b2dc76902f84f8352d2333: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2015-09-25 21:52:30 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v5 17/38] block: Add BlockBackendRootState

2015-09-29 Thread Alberto Garcia
On Tue 22 Sep 2015 05:00:05 PM CEST, Max Reitz wrote: >> The correct way to solve this seems to be that each BB has its own >> I/O throttling filter. Actually, if we could lift the throttling code >> to BlockBackend, that might solve the problem. > > So yes, as long as we have throttling on the BD

[Qemu-devel] [Bug 893208] Re: qemu on ARM hosts can't boot i386 image

2015-09-29 Thread Paolo Bonzini
get_clock() sounds like a good idea. Anybody post the patch? :) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/893208 Title: qemu on ARM hosts can't boot i386 image Status in QEMU: New Status in

Re: [Qemu-devel] [PULL 0/3] cocoa queue

2015-09-29 Thread Peter Maydell
On 25 September 2015 at 23:18, Peter Maydell wrote: > Flushing the cocoa queue. > > The following changes since commit 9e071429e649346c14b2dc76902f84f8352d2333: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2015-09-25 21:52:30 +0100) > > are available in t

Re: [Qemu-devel] [PATCH v6 04/16] qapi: Clean up qapi.py per pep8

2015-09-29 Thread Markus Armbruster
Eric Blake writes: > Silence pep8, and make pylint a bit happier. Just style cleanups, > plus killing a useless comment in camel_to_upper(); no semantic > changes. > > Signed-off-by: Eric Blake [...] > diff --git a/scripts/qapi.py b/scripts/qapi.py > index a2d869e..7e8a99d 100644 > --- a/script

Re: [Qemu-devel] [PATCH] util/mmap-alloc: add comments, assertions

2015-09-29 Thread Paolo Bonzini
On 29/09/2015 12:51, Michael S. Tsirkin wrote: > Document RAM guard page logic within mmap-alloc. > > Signed-off-by: Michael S. Tsirkin > --- > > Paolo, can you pls confirm this is what you had in mind? > > util/mmap-alloc.c | 16 > 1 file changed, 16 insertions(+) > > diff

Re: [Qemu-devel] [PATCH 3/3] block: mirror - zero unallocated target sectors when zero init not present

2015-09-29 Thread Paolo Bonzini
On 29/09/2015 11:35, Kevin Wolf wrote: > The caller could be copying the backing file in the background and it > may not yet be finished. Yes, and this is permitted (the destination file of mirroring is opened with BDRV_O_NO_BACKING). Some more assumptions arise when block-job-complete is invok

[Qemu-devel] [PATCH] util/mmap-alloc: add comments, assertions

2015-09-29 Thread Michael S. Tsirkin
Document RAM guard page logic within mmap-alloc. Signed-off-by: Michael S. Tsirkin --- Paolo, can you pls confirm this is what you had in mind? util/mmap-alloc.c | 16 1 file changed, 16 insertions(+) diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c index 05c8b4b..d978399 1

Re: [Qemu-devel] [PATCH v5 08/38] block/raw_bsd: Drop raw_is_inserted()

2015-09-29 Thread Alberto Garcia
On Fri 18 Sep 2015 05:22:43 PM CEST, Max Reitz wrote: > With the new automatically-recursive implementation of > bdrv_is_inserted() checking by default whether all the children of a BDS > are inserted, we can drop raw's own implementation. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia

Re: [Qemu-devel] [PATCH v4 0/5] add ACPI node for fw_cfg on pc and arm

2015-09-29 Thread Laszlo Ersek
On 09/29/15 12:27, Michael S. Tsirkin wrote: > On Sun, Sep 27, 2015 at 05:28:57PM -0400, Gabriel L. Somlo wrote: >> New since v3: >> >> - rebased to work on top of 87e896ab (introducing pc-*-25 classes), >>inserting fw_cfg acpi node only for machines >= 2.5. >> >> - reintroduce _S

Re: [Qemu-devel] [PATCH v4 5/5] fw_cfg: document ACPI device node information

2015-09-29 Thread Laszlo Ersek
On 09/27/15 23:29, Gabriel L. Somlo wrote: > Signed-off-by: Gabriel Somlo > --- > docs/specs/fw_cfg.txt | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/docs/specs/fw_cfg.txt b/docs/specs/fw_cfg.txt > index bc95404..4d85701 100644 > --- a/docs/specs/fw_cfg.txt > +++ b/docs/specs

Re: [Qemu-devel] [PATCH v8 06/54] Rename mis->file to from_src_file

2015-09-29 Thread Amit Shah
On (Tue) 29 Sep 2015 [09:37:30], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > 'file' becomes confusing when you have flows in each direction; > rename to make it clear. > This leaves just the main forward direction ms->file, which is used > in a lot of places and is pr

Re: [Qemu-devel] [PATCH v4 4/5] acpi: arm: add fw_cfg device node to dsdt

2015-09-29 Thread Laszlo Ersek
On 09/27/15 23:29, Gabriel L. Somlo wrote: > Add a fw_cfg device node to the ACPI DSDT. This is mostly > informational, as the authoritative fw_cfg MMIO region(s) > are listed in the Device Tree. However, since we are building > ACPI tables, we might as well be thorough while at it... > > Signed-o

Re: [Qemu-devel] [PATCH 3/3] target-xtensa: xtfpga: support noMMU cores

2015-09-29 Thread Max Filippov
On Mon, Sep 28, 2015 at 12:59 AM, Peter Crosthwaite wrote: > On Sun, Sep 27, 2015 at 2:48 PM, Max Filippov wrote: >> On Mon, Sep 28, 2015 at 12:28 AM, Peter Crosthwaite >> wrote: >>> To clarify, can you tell me the QEMU command line difference between >>> MMU and noMMU? >> >> There is no differe

Re: [Qemu-devel] [PATCH v4 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-09-29 Thread Laszlo Ersek
On 09/27/15 23:29, Gabriel L. Somlo wrote: > Add a fw_cfg device node to the ACPI SSDT, on machine types > pc-*-2.5 and up. While the guest-side BIOS can't utilize > this information (since it has to access the hard-coded > fw_cfg device to extract ACPI tables to begin with), having > fw_cfg listed

Re: [Qemu-devel] [PATCH V2] vnc: destroy server surface if no client is connected

2015-09-29 Thread Gerd Hoffmann
Hi, > -graphic_hw_update(vd->dcl.con); > +if (first_client) { > +/* set/restore the correct surface in the VNC server */ > +console_select(0); Nah, that has unwanted side effects. Pushed some patches to git://git.kraxel.org/qemu rebase/ui-vnc-next, could you have a look

Re: [Qemu-devel] [PATCH v4 0/5] add ACPI node for fw_cfg on pc and arm

2015-09-29 Thread Michael S. Tsirkin
On Sun, Sep 27, 2015 at 05:28:57PM -0400, Gabriel L. Somlo wrote: > New since v3: > > - rebased to work on top of 87e896ab (introducing pc-*-25 classes), > inserting fw_cfg acpi node only for machines >= 2.5. > > - reintroduce _STA with value 0x0B (bit 2 for u/i visibility tur

Re: [Qemu-devel] [PATCH v4 2/5] pc: fw_cfg: move ioport base constant to pc.h

2015-09-29 Thread Laszlo Ersek
On 09/27/15 23:28, Gabriel L. Somlo wrote: > Move BIOS_CFG_IOPORT define from pc.c to pc.h, and rename > it to FW_CFG_IO_BASE. > > Signed-off-by: Gabriel Somlo > --- > hw/i386/pc.c | 5 ++--- > include/hw/i386/pc.h | 2 ++ > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --gi

Re: [Qemu-devel] [PATCH v4 1/5] fw_cfg: expose control register size in fw_cfg.h

2015-09-29 Thread Laszlo Ersek
On 09/27/15 23:28, Gabriel L. Somlo wrote: > Expose the size of the control register (FW_CFG_SIZE, renamed to > FW_CFG_CTL_SIZE) in fw_cfg.h. > Add comment to fw_cfg_io_realize() pointing out that since the > 8-bit data register is always subsumed by the 16-bit control > register in the port I/O ca

Re: [Qemu-devel] [Xen-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-29 Thread Stefano Stabellini
On Mon, 28 Sep 2015, Pasi Kärkkäinen wrote: > Hi, > > On Mon, Sep 28, 2015 at 11:01:11AM +0100, Stefano Stabellini wrote: > > No, unfortunately it is not possible at this stage of the release cycle. > > But users can still use QEMU 2.5 (as soon as it is released, which > > should be in a couple of

Re: [Qemu-devel] [PATCH v4 2/2] spapr: generate DT node names

2015-09-29 Thread Thomas Huth
On 29/09/15 10:37, Laurent Vivier wrote: > > > On 29/09/2015 07:18, David Gibson wrote: >> On Thu, Sep 24, 2015 at 12:27:39PM +0200, Laurent Vivier wrote: ... >>> -/* NOTE: this is normally generated by firmware via >>> path/unit name, - * but in our case we must set it manually >>> since

Re: [Qemu-devel] [PATCH 3/3] block: mirror - zero unallocated target sectors when zero init not present

2015-09-29 Thread Kevin Wolf
Am 29.09.2015 um 10:42 hat Paolo Bonzini geschrieben: > > > On 29/09/2015 10:10, Kevin Wolf wrote: > >> When mode == 'existing' for a shallow mirror (sync != 'full'), > >> that is the caller stating that the guest-visible contents of the > >> destination match the guest-visible contents of the ba

Re: [Qemu-devel] [PATCH] libseccomp: add cacheflush to whitelist

2015-09-29 Thread Eduardo Otubo
On Thu, Sep 24, 2015 at 03=50=04PM +0200, Andrew Jones wrote: > On Thu, Sep 24, 2015 at 11:31:19AM +0200, Eduardo Otubo wrote: > > On Wed, Jul 01, 2015 at 09=12=33AM -0400, Andrew Jones wrote: > > > cacheflush is an arm-specific syscall that qemu built for arm > > > uses. Add it to the whitelist. >

Re: [Qemu-devel] [PATCH] target-arm: Add MDCR_EL2

2015-09-29 Thread Peter Maydell
On 28 September 2015 at 11:37, Sergey Fedorov wrote: > Signed-off-by: Sergey Fedorov > --- > > This patch is a prerequisite for a debug exception routing patch: > https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg03542.html > > target-arm/cpu-qom.h | 1 + > target-arm/cpu.c | 1 + >

Re: [Qemu-devel] [PATCH] target-arm: Add MDCR_EL2

2015-09-29 Thread Peter Maydell
On 29 September 2015 at 07:00, Alex Bennée wrote: > > Sergey Fedorov writes: > >> Signed-off-by: Sergey Fedorov >> --- >> >> This patch is a prerequisite for a debug exception routing patch: >> https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg03542.html >> >> target-arm/cpu-qom.h | 1 +

Re: [Qemu-devel] ARM CPU affinities

2015-09-29 Thread Peter Maydell
On 29 September 2015 at 07:15, Andrew Jones wrote: > My current thinking is that we'll set MPIDR with KVM_SET_ONE_REG, which > will also set the cached value in struct kvm_vcpu. Reset will then use > that value. Yes, supporting SET_ONE_REG is definitely the way to go for the userspace API for thi

Re: [Qemu-devel] [PATCH v5 07/38] block: Make bdrv_is_inserted() recursive

2015-09-29 Thread Alberto Garcia
On Fri 18 Sep 2015 05:22:42 PM CEST, Max Reitz wrote: > If bdrv_is_inserted() is called on the top level BDS, it should make > sure all nodes in the BDS tree are actually inserted. > > Signed-off-by: Max Reitz > --- > block.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) >

[Qemu-devel] [PATCH v8 53/54] Disable mlock around incoming postcopy

2015-09-29 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Userfault doesn't work with mlock; mlock is designed to nail down pages so they don't move, userfault is designed to tell you when they're not there. munlock the pages we userfault protect before postcopy. mlock everything again at the end if mlock is enabled. Sig

  1   2   >