On 29 September 2015 at 13:37, Paolo Bonzini <pbonz...@redhat.com> wrote: > This causes the region to outlive the object, because it attaches the > region to /machine. This is not nice for the "realize" method, but > much worse for "instance_init" because it can cause dangling pointers > after a simple object_new/object_unref pair. > > Reported-by: Markus Armbruster <arm...@redhat.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > hw/arm/pxa2xx.c | 2 +- > hw/display/cg3.c | 4 ++-- > hw/display/tcx.c | 2 +- > hw/misc/arm_integrator_debug.c | 2 +- > hw/misc/macio/cuda.c | 2 +- > hw/misc/macio/macio.c | 6 +++--- > 6 files changed, 9 insertions(+), 9 deletions(-)
Some of the macio changes are realize function code rather than instance_init, but they're all bugs either way. Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
