Re: [Qemu-devel] [PATCH v3 10/12] netfilter: add a netbuffer filter

2015-08-03 Thread Jason Wang
On 08/04/2015 02:05 PM, Yang Hongyang wrote: > On 08/04/2015 01:03 PM, Jason Wang wrote: >> >> >> On 08/03/2015 04:30 PM, Yang Hongyang wrote: >>> This filter is to buffer/release packets, this feature can be used >>> when using MicroCheckpointing, or other Remus like VM FT solutions, you >>> can

Re: [Qemu-devel] [PATCH v5 2/2] vhost user: add rarp sending after live migration for legacy guest

2015-08-03 Thread Jason Wang
On 08/03/2015 05:22 PM, Thibaut Collet wrote: > A new vhost user message is added to allow QEMU to ask to vhost user backend > to > broadcast a fake RARP after live migration for guest without GUEST_ANNOUNCE > capability. > > This new message is sent only if the backend supports the new > VHOST_

Re: [Qemu-devel] [PATCH v3 10/12] netfilter: add a netbuffer filter

2015-08-03 Thread Yang Hongyang
On 08/04/2015 01:03 PM, Jason Wang wrote: On 08/03/2015 04:30 PM, Yang Hongyang wrote: This filter is to buffer/release packets, this feature can be used when using MicroCheckpointing, or other Remus like VM FT solutions, you can also use it to simulate the network delay. It has an interval op

Re: [Qemu-devel] Call Trace for QEMU functions

2015-08-03 Thread Naman patel
On Fri, Jul 31, 2015 at 3:32 PM, Peter Maydell wrote: > On 31 July 2015 at 10:29, Naman patel wrote: > > Can someone explain me what happens when a guest OS calls "invlpg" on say > > page swap out or a context switch? What exactly is the call flow and how > > QEMU handles this instruction? > > W

Re: [Qemu-devel] [PATCH v3 04/12] net: add/remove filters from network backend

2015-08-03 Thread Yang Hongyang
On 08/04/2015 01:53 PM, Jason Wang wrote: On 08/04/2015 01:39 PM, Yang Hongyang wrote: On 08/04/2015 12:56 PM, Jason Wang wrote: On 08/03/2015 04:30 PM, Yang Hongyang wrote: add/remove filters from network backend Signed-off-by: Yang Hongyang --- include/net/net.h | 8 net

Re: [Qemu-devel] [PATCH v3 04/12] net: add/remove filters from network backend

2015-08-03 Thread Jason Wang
On 08/04/2015 01:39 PM, Yang Hongyang wrote: > On 08/04/2015 12:56 PM, Jason Wang wrote: >> >> >> On 08/03/2015 04:30 PM, Yang Hongyang wrote: >>> add/remove filters from network backend >>> >>> Signed-off-by: Yang Hongyang >>> --- >>> include/net/net.h | 8 >>> net/filter.c |

Re: [Qemu-devel] [PATCH v3 07/12] netfilter: add an API to pass the packet to next filter

2015-08-03 Thread Yang Hongyang
On 08/04/2015 01:00 PM, Jason Wang wrote: On 08/03/2015 04:30 PM, Yang Hongyang wrote: add an API qemu_netfilter_pass_to_next_iov() to pass the packet to next filter, and a wrapper qemu_netfilter_pass_to_next(). Signed-off-by: Yang Hongyang --- include/net/filter.h | 12 in

Re: [Qemu-devel] [PATCH v7 35/42] Don't sync dirty bitmaps in postcopy

2015-08-03 Thread Amit Shah
On (Fri) 31 Jul 2015 [10:50:46], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: > > On (Tue) 16 Jun 2015 [11:26:48], Dr. David Alan Gilbert (git) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Once we're in postcopy the source processors are stopped and memory

Re: [Qemu-devel] [PATCH v3 04/12] net: add/remove filters from network backend

2015-08-03 Thread Yang Hongyang
On 08/04/2015 12:56 PM, Jason Wang wrote: On 08/03/2015 04:30 PM, Yang Hongyang wrote: add/remove filters from network backend Signed-off-by: Yang Hongyang --- include/net/net.h | 8 net/filter.c | 4 ++-- net/net.c | 33 + 3 files

Re: [Qemu-devel] [PATCH v7 21/42] postcopy: OS support test

2015-08-03 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:34], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Provide a check to see if the OS we're running on has all the bits > needed for postcopy. > > Creates postcopy-ram.c which will get most of the other helpers we need. > > Signed-off-by: Dr.

Re: [Qemu-devel] [PATCH v7 19/42] MIG_CMD_PACKAGED: Send a packaged chunk of migration stream

2015-08-03 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:32], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > MIG_CMD_PACKAGED is a migration command that wraps a chunk of migration > stream inside a package whose length can be determined purely by reading > its header. The destination guarantees th

Re: [Qemu-devel] [PATCH v7 03/42] Init page sizes in qtest

2015-08-03 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:16], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > One of my patches used a loop that was based on host page size; > it dies in qtest since qtest hadn't bothered init'ing it. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah

Re: [Qemu-devel] [PATCH v7 01/42] Start documenting how postcopy works.

2015-08-03 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:14], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah A few minor comments: > --- > docs/migration.txt | 167 > + > 1 file ch

Re: [Qemu-devel] [PATCH 0/3] rtl8139: cleanups

2015-08-03 Thread Jason Wang
On 08/03/2015 08:15 PM, Stefan Hajnoczi wrote: > After addressing CVE-2015-5165 there were several additional rtl8139 cleanups > that I'm sending separately since they are not security fixes. > > These patches eliminate duplicate eth.h structs/macros and fix unaligned > memory > accesses in tx o

Re: [Qemu-devel] [PATCH v3 10/12] netfilter: add a netbuffer filter

2015-08-03 Thread Jason Wang
On 08/03/2015 04:30 PM, Yang Hongyang wrote: > This filter is to buffer/release packets, this feature can be used > when using MicroCheckpointing, or other Remus like VM FT solutions, you > can also use it to simulate the network delay. > It has an interval option, if supplied, this filter will r

Re: [Qemu-devel] [PATCH v3 07/12] netfilter: add an API to pass the packet to next filter

2015-08-03 Thread Jason Wang
On 08/03/2015 04:30 PM, Yang Hongyang wrote: > add an API qemu_netfilter_pass_to_next_iov() to pass the packet > to next filter, and a wrapper qemu_netfilter_pass_to_next(). > > Signed-off-by: Yang Hongyang > --- > include/net/filter.h | 12 > include/net/net.h| 1 + > net/fil

Re: [Qemu-devel] [PATCH v3 04/12] net: add/remove filters from network backend

2015-08-03 Thread Jason Wang
On 08/03/2015 04:30 PM, Yang Hongyang wrote: > add/remove filters from network backend > > Signed-off-by: Yang Hongyang > --- > include/net/net.h | 8 > net/filter.c | 4 ++-- > net/net.c | 33 + > 3 files changed, 43 insertions(+), 2 dele

Re: [Qemu-devel] [PATCH RESEND v2 2/3] sPAPR: Support RTAS call ibm, {open, close}-errinjct

2015-08-03 Thread Alexey Kardashevskiy
On 08/03/2015 01:32 PM, Gavin Shan wrote: On Mon, Aug 03, 2015 at 12:51:09PM +1000, David Gibson wrote: On Mon, Aug 03, 2015 at 09:23:19AM +1000, Gavin Shan wrote: The patch supports RTAS calls "ibm,{open,close}-errinjct" to manupliate the token, which is passed to RTAS call "ibm,errinjct" to i

Re: [Qemu-devel] [Bug 821078] Re: virtio-serial-bus: Unexpected port id

2015-08-03 Thread Amit Shah
On (Tue) 28 Jul 2015 [09:17:25], Quwj wrote: > I met two bugs above.QEMU version is 2.1.3 and VM is Windows7. > QEMU Log is: > qemu-system-x86_64: virtio-serial-bus: Unexpected port id 15819934 for device > virtio-serial0.0 (snip) > Bug description: > With qemu-kvm-0.15.0-rc1 virtio-serial-bus

Re: [Qemu-devel] [RFC PATCH v0 4/5] spapr: Support hotplug by specifying DRC count

2015-08-03 Thread David Gibson
On Mon, Aug 03, 2015 at 05:32:43PM -0500, Michael Roth wrote: > Quoting Bharata B Rao (2015-08-03 02:53:02) > > On Mon, Aug 03, 2015 at 04:55:01PM +1000, David Gibson wrote: > > > On Mon, Aug 03, 2015 at 11:05:42AM +0530, Bharata B Rao wrote: > > > > Support hotplug identifier type RTAS_LOG_V6_HP_I

Re: [Qemu-devel] [PATCH] kvm_ppc: remove kvmppc_timer_hack

2015-08-03 Thread Alexander Graf
On 27.07.15 13:46, Paolo Bonzini wrote: > QEMU does have an I/O thread now, that can be interrupted at any time > because the VCPU thread runs outside the iothread mutex. > > Therefore, the kvmppc_timer_hack is obsolete. Remove it. > > Signed-off-by: Paolo Bonzini Thanks, applied to ppc-next

Re: [Qemu-devel] [RFC PATCH v0 4/5] spapr: Support hotplug by specifying DRC count

2015-08-03 Thread Michael Roth
Quoting Bharata B Rao (2015-08-03 02:53:02) > On Mon, Aug 03, 2015 at 04:55:01PM +1000, David Gibson wrote: > > On Mon, Aug 03, 2015 at 11:05:42AM +0530, Bharata B Rao wrote: > > > Support hotplug identifier type RTAS_LOG_V6_HP_ID_DRC_COUNT that allows > > > hotplugging of DRCs by specifying the DR

Re: [Qemu-devel] [PATCH v2 1/3] target-mips: Copy restrictions from ext/ins to dext/dins

2015-08-03 Thread Aurelien Jarno
On 2015-08-03 14:41, Richard Henderson wrote: > On 08/03/2015 02:31 PM, Aurelien Jarno wrote: > >On 2015-08-03 12:35, Richard Henderson wrote: > >> if (msb != 31) { > >>-tcg_gen_andi_tl(t0, t0, (1 << (msb + 1)) - 1); > >>+tcg_gen_andi_tl(t0, t0, (1U << (msb + 1)) -

Re: [Qemu-devel] [PATCH 2/3] target-mips: Stop translation after unconditional exceptions

2015-08-03 Thread Richard Henderson
On 08/03/2015 02:31 PM, Aurelien Jarno wrote: On 2015-08-03 11:49, Richard Henderson wrote: Since there are many more unconditional exceptions than conditional, introduce a new generate_exception_cond to mark conditionals. Also delete those few cases where we did attempt to stop translation aft

Re: [Qemu-devel] [PATCH v2 1/3] target-mips: Copy restrictions from ext/ins to dext/dins

2015-08-03 Thread Richard Henderson
On 08/03/2015 02:31 PM, Aurelien Jarno wrote: On 2015-08-03 12:35, Richard Henderson wrote: if (msb != 31) { -tcg_gen_andi_tl(t0, t0, (1 << (msb + 1)) - 1); +tcg_gen_andi_tl(t0, t0, (1U << (msb + 1)) - 1); Is this change really needed? msb == 30 means 1 << 3

Re: [Qemu-devel] [PATCH v2 1/3] target-mips: Copy restrictions from ext/ins to dext/dins

2015-08-03 Thread Aurelien Jarno
On 2015-08-03 12:35, Richard Henderson wrote: > The checks in dins is required to avoid triggering an assertion > in tcg_gen_deposit_tl. The check in dext is just for completeness. > Fold the other D cases in via fallthru. > > In this case the errant dins appears to be data, not code, as > transl

Re: [Qemu-devel] [PATCH 3/3] target-mips: Use CPU_LOG_INT for logging related to interrupts

2015-08-03 Thread Aurelien Jarno
On 2015-08-03 11:49, Richard Henderson wrote: > There are now no unconditional uses of qemu_log in the subdirectory. > > Signed-off-by: Richard Henderson > --- > target-mips/helper.c| 30 +++--- > target-mips/op_helper.c | 3 ++- > 2 files changed, 13 insertions(+),

Re: [Qemu-devel] [PATCH 2/3] target-mips: Stop translation after unconditional exceptions

2015-08-03 Thread Aurelien Jarno
On 2015-08-03 11:49, Richard Henderson wrote: > Since there are many more unconditional exceptions than conditional, > introduce a new generate_exception_cond to mark conditionals. Also > delete those few cases where we did attempt to stop translation after > an exception, as these are now subsume

Re: [Qemu-devel] [PATCH] target-mips: fix semihosting for microMIPS R6

2015-08-03 Thread Aurelien Jarno
On 2015-08-03 13:01, Leon Alrae wrote: > In semihosting mode the SDBBP 1 instructions should trigger UHI syscall, > but in QEMU this does not happen for recently added microMIPS R6. > Consequently bare metal microMIPS R6 programs supporting UHI will not run. > > Signed-off-by: Leon Alrae > --- >

Re: [Qemu-devel] [Consult] tilegx: About floating point instructions

2015-08-03 Thread Chen Gang
On 8/4/15 00:40, Richard Henderson wrote: > On 08/01/2015 02:47 AM, Chen Gang wrote: >> I am just adding floating point instructions (e.g. fsingle_add1), >> but for me, I can not find any details about them (the ISA >> documents only give a summary description, but not details), e.g. > > The tileg

Re: [Qemu-devel] [PATCH v3 4/4] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on MSI reinstall

2015-08-03 Thread Marc-André Lureau
Reviewed-by: Marc-André Lureau On Mon, Aug 3, 2015 at 7:54 PM, Leonid Bloch wrote: > Previously, running the .msi would unregister the QEMU GA VSS service if QEMU > GA was already installed on the machine, and then register it only if QEMU GA > was NOT previously installed. This behavior cause

Re: [Qemu-devel] [PATCH v3 3/4] qemu-ga: Created a separate component for each installed file in the MSI

2015-08-03 Thread Marc-André Lureau
You could just use generated GUID with * now, with that Reviewed-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region

2015-08-03 Thread Alexander Graf
> Am 03.08.2015 um 11:20 schrieb Pavel Fedin : > > Hello! > >>> In order to keep this guest working, we need a possibility to >>> disable the new MMIO region in qemu. At least to omit it from the >>> device tree. >> >> Yes, this is the workaround, which it sounds like we need. > > Ok. Just to

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-03 Thread Dennis Luehring
Am 03.08.2015 um 17:59 schrieb Karel Gardas: On Mon, Aug 3, 2015 at 4:51 PM, Dennis Luehring wrote: > ok - NetBSD 6.5.1 SPARC64 is blasting fast compare to Debian 7.8.0 SPARC64 - > i installed the complete system (without X) in a few minutes > Debian needs >1h I had the same experience with Ope

Re: [Qemu-devel] [PATCH] migration: Make events a capability

2015-08-03 Thread Eric Blake
On 07/07/2015 06:47 AM, Juan Quintela wrote: > Make check fails with events. THis is due to the parser/lexer that it > uses. Just in case that they are more broken parsers, just only send > events when there are capabilities. > > Signed-off-by: Juan Quintela > --- > include/migration/migration

[Qemu-devel] [PATCH v2 1/3] target-mips: Copy restrictions from ext/ins to dext/dins

2015-08-03 Thread Richard Henderson
The checks in dins is required to avoid triggering an assertion in tcg_gen_deposit_tl. The check in dext is just for completeness. Fold the other D cases in via fallthru. In this case the errant dins appears to be data, not code, as translation failed to stop after a break insn. Signed-off-by: R

Re: [Qemu-devel] [PATCH 1/3] target-mips: Copy restrictions from ext/ins to dext/dins

2015-08-03 Thread Richard Henderson
On 08/03/2015 11:49 AM, Richard Henderson wrote: > #if defined(TARGET_MIPS64) > -case OPC_DEXTM: > -tcg_gen_shri_tl(t0, t1, lsb); > -if (msb != 31) { > -tcg_gen_andi_tl(t0, t0, (1ULL << (msb + 1 + 32)) - 1); > -} > -break; > case OPC_DEXTU: > -

[Qemu-devel] [PATCH 3/3] target-mips: Use CPU_LOG_INT for logging related to interrupts

2015-08-03 Thread Richard Henderson
There are now no unconditional uses of qemu_log in the subdirectory. Signed-off-by: Richard Henderson --- target-mips/helper.c| 30 +++--- target-mips/op_helper.c | 3 ++- 2 files changed, 13 insertions(+), 20 deletions(-) diff --git a/target-mips/helper.c b/target-

[Qemu-devel] [PATCH 2/3] target-mips: Stop translation after unconditional exceptions

2015-08-03 Thread Richard Henderson
Since there are many more unconditional exceptions than conditional, introduce a new generate_exception_cond to mark conditionals. Also delete those few cases where we did attempt to stop translation after an exception, as these are now subsumed in the change. Signed-off-by: Richard Henderson --

[Qemu-devel] [PATCH 1/3] target-mips: Copy restrictions from ext/ins to dext/dins

2015-08-03 Thread Richard Henderson
The checks in dins is required to avoid triggering an assertion in tcg_gen_deposit_tl. The check in dext is just for completeness. Fold the other D cases in via fallthru. In this case the errant dins appears to be data, not code, as translation failed to stop after a break insn. Signed-off-by: R

[Qemu-devel] [PATCH 0/3] target-mips fixes

2015-08-03 Thread Richard Henderson
The first patch fixes an abort that I see when booting a mips64 kernel with the 2.4 branch with --enable-tcg-debug. The second patch eliminates the observed symptom of the first patch, partially confirming the diagnosis that the errant insn is in fact data and not an instruction at all. The third

Re: [Qemu-devel] [PATCH v4 14/14] tests: add BlockJobTxn unit test

2015-08-03 Thread Max Reitz
On 30.07.2015 08:39, Fam Zheng wrote: From: Stefan Hajnoczi The BlockJobTxn unit test verifies that both single jobs and pairs of jobs behave as a transaction group. Either all jobs complete successfully or the group is cancelled. Signed-off-by: Stefan Hajnoczi Signed-off-by: Fam Zheng ---

Re: [Qemu-devel] [PATCH v4 11/14] block/backup: support block job transactions

2015-08-03 Thread Max Reitz
On 30.07.2015 08:39, Fam Zheng wrote: From: Stefan Hajnoczi Join the transaction when the 'transactional-cancel' QMP argument is true. This ensures that the sync bitmap is not thrown away if another block job in the transaction is cancelled or fails. This is critical so incremental backup wit

Re: [Qemu-devel] [PATCH v4 10/14] blockdev: make BlockJobTxn available to qmp 'transaction'

2015-08-03 Thread Max Reitz
On 30.07.2015 08:39, Fam Zheng wrote: From: Stefan Hajnoczi Provide a BlockJobTxn to actions executed in a qmp 'transaction' command. This allows actions to make their block jobs either complete as a group or fail/cancel together. The next patch adds the first user. Signed-off-by: Stefan Haj

Re: [Qemu-devel] [PATCH v4 09/14] block: add block job transactions

2015-08-03 Thread Max Reitz
On 30.07.2015 08:39, Fam Zheng wrote: Sometimes block jobs must execute as a transaction group. Finishing jobs wait until all other jobs are ready to complete successfully. Failure or cancellation of one job cancels the other jobs in the group. Signed-off-by: Stefan Hajnoczi [Rewrite the imple

[Qemu-devel] [PATCH v3 2/4] qemu-ga: Minor cosmetic changes to the WXS file

2015-08-03 Thread Leonid Bloch
Signed-off-by: Leonid Bloch --- qga/installer/qemu-ga.wxs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs index d0a3a38..dac1df0 100644 --- a/qga/installer/qemu-ga.wxs +++ b/qga/installer/qemu-ga.wxs @@ -111,9 +111,9

[Qemu-devel] [PATCH v3 3/4] qemu-ga: Created a separate component for each installed file in the MSI

2015-08-03 Thread Leonid Bloch
This is done to follow the recommendations given here: https://msdn.microsoft.com/en-us/library/aa368269%28VS.85%29.aspx Signed-off-by: Leonid Bloch --- qga/installer/qemu-ga.wxs | 47 --- 1 file changed, 36 insertions(+), 11 deletions(-) diff --git

[Qemu-devel] [PATCH v3 1/4] qemu-ga: Fixed GUID capitalization

2015-08-03 Thread Leonid Bloch
For compatibility, all the letters in GUID should be capital. Signed-off-by: Leonid Bloch --- qga/installer/qemu-ga.wxs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs index 2c43f1b..d0a3a38 100644 --- a/qga/installe

[Qemu-devel] [PATCH v3 4/4] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on MSI reinstall

2015-08-03 Thread Leonid Bloch
Previously, running the .msi would unregister the QEMU GA VSS service if QEMU GA was already installed on the machine, and then register it only if QEMU GA was NOT previously installed. This behavior caused the service to be registered only after the INITIAL installation, and any subsequent run

[Qemu-devel] [PATCH v3 0/4] qemu-ga: Fixes to the QEMU GA MSI installer

2015-08-03 Thread Leonid Bloch
The main purpose here is to fix a bug that caused the QEMU GA VSS service to be unregistered on reinstallation using the .msi file. Also, two fixes are introduced to the .wxs file, which is used to create the MSI with Wixl: GUID capitalization and introduction of a separate component for each of

Re: [Qemu-devel] [PULL for-2.4 0/2] Fix migration on Xen

2015-08-03 Thread Peter Maydell
On 3 August 2015 at 17:19, Stefano Stabellini wrote: > The following changes since commit f60c87154ac722c528fd5582f7137914a93c5eec: > > configure: Drop vnc-ws feature from help text (2015-08-03 15:32:17 +0100) > > are available in the git repository at: > > git://xenbits.xen.org/people/sstabel

Re: [Qemu-devel] [PATCH v2] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on reinstall

2015-08-03 Thread Marc-André Lureau
Hi On Mon, Aug 3, 2015 at 6:55 PM, Leonid Bloch wrote: > I understand your concerns. I have made a separate Component for each > file, but REINSTALLMODE still needs to be set to "amus" for the files > to be copied correctly. This is because all the files are removed > during RemoveExistingProduct

Re: [Qemu-devel] [PATCH v4 08/14] blockjob: Simplify block_job_finish_sync

2015-08-03 Thread Max Reitz
On 30.07.2015 08:39, Fam Zheng wrote: With job->completed and job->ret to replace BlockFinishData. Signed-off-by: Fam Zheng --- blockjob.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH v4 07/14] blockjob: Add "completed" and "ret" in BlockJob

2015-08-03 Thread Max Reitz
On 30.07.2015 08:39, Fam Zheng wrote: They are set when block_job_completed is called. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- blockjob.c | 3 +++ include/block/blockjob.h | 9 + 2 files changed, 12 insertions(+) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH v4 06/14] blockjob: Add .commit and .abort block job actions

2015-08-03 Thread Max Reitz
On 30.07.2015 08:39, Fam Zheng wrote: Signed-off-by: Fam Zheng --- include/block/blockjob.h | 18 ++ 1 file changed, 18 insertions(+) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH v4 05/14] blockjob: Introduce reference count

2015-08-03 Thread Max Reitz
On 30.07.2015 08:39, Fam Zheng wrote: So that block_job_complete_sync can be simplified. Signed-off-by: Fam Zheng --- block/mirror.c | 2 +- blockjob.c | 22 ++ include/block/blockjob.h | 18 +++--- 3 files changed, 30 insertions(+),

Re: [Qemu-devel] [PATCH v4 04/14] backup: Extract dirty bitmap handling as a separate function

2015-08-03 Thread Max Reitz
On 30.07.2015 08:39, Fam Zheng wrote: This will be reused by the coming new transactional completion code. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block/backup.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCHv2] macio: handle non-block ATAPI DMA transfers the same as block DMA transfers

2015-08-03 Thread John Snow
On 08/01/2015 02:54 PM, Mark Cave-Ayland wrote: > On 01/08/15 19:33, Aurelien Jarno wrote: > >> On 2015-08-01 17:54, Mark Cave-Ayland wrote: >>> The existing code incorrectly changes the dma_active flag when a non-block >>> transfer has completed leading to a hang on newer versions of Linux beca

Re: [Qemu-devel] [PATCH v2] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on reinstall

2015-08-03 Thread Leonid Bloch
Hi, On Mon, Aug 3, 2015 at 6:30 PM, Marc-André Lureau wrote: >>> I think the root of the problem is that the wxs doesn't follow the >>> "component rules": "qemu_ga" shouldn't contain various libs and >>> executable. Instead, each file should have its own component. Then I >>> think RemoveExisting

Re: [Qemu-devel] [PATCH v4 01/14] qapi: Add transaction support to block-dirty-bitmap operations

2015-08-03 Thread Max Reitz
On 30.07.2015 08:39, Fam Zheng wrote: From: John Snow This adds two qmp commands to transactions. block-dirty-bitmap-add allows you to create a bitmap simultaneously alongside a new full backup to accomplish a clean synchronization point. block-dirty-bitmap-clear allows you to reset a bitmap

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 11/11] new: arm/barrier-test for memory barriers

2015-08-03 Thread alvise rigo
On Mon, Aug 3, 2015 at 6:06 PM, Alex Bennée wrote: > > alvise rigo writes: > > > On Mon, Aug 3, 2015 at 12:30 PM, Alex Bennée > wrote: > >> > >> alvise rigo writes: > >> > >>> Hi Alex, > >>> > >>> Nice set of tests, they are proving to be helpful. > >>> One question below. > >>> > > >>> > >>>

Re: [Qemu-devel] [Consult] tilegx: About floating point instructions

2015-08-03 Thread Richard Henderson
On 08/01/2015 02:47 AM, Chen Gang wrote: > I am just adding floating point instructions (e.g. fsingle_add1), but > for me, I can not find any details about them (the ISA documents only > give a summary description, but not details), e.g. The tilegx splits the four/six cycle arithmetic into multipl

Re: [Qemu-devel] [PATCH RFC 03/10] maint: remove / fix many doubled words

2015-08-03 Thread Max Reitz
On 31.07.2015 18:30, Daniel P. Berrange wrote: Many source files have doubled words (eg "the the", "to to", and so on). Most of these can simply be removed, but a couple were actual mis-spellings (eg "to to" instead of "to do"). There was even one triple word score "to to to" :-) Signed-off-by:

Re: [Qemu-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Anthony PERARD
On Mon, Aug 03, 2015 at 09:37:07PM +0530, Amit Shah wrote: > On (Mon) 03 Aug 2015 [15:29:18], Anthony PERARD wrote: > > Hi, > > > > We've spotted several regression which prevent migration with Xen using the > > same version of QEMU or from a previous version of QEMU (tryied with 2.2). > > > > Re

[Qemu-devel] [PULL for-2.4 2/2] migration: Fix regression for xenfv and pc, accel=xen machine.

2015-08-03 Thread Stefano Stabellini
From: Anthony PERARD This fix migration from the same QEMU version and from previous QEMU version. >From the global state section, we don't need runstate with Xen. Right now, the way the Xen toolstack knows when QEMU is ready is when QEMU reach "running" runstate. The configuration section and

[Qemu-devel] [PULL for-2.4 1/2] migration: Fix global state with Xen.

2015-08-03 Thread Stefano Stabellini
From: Anthony PERARD When doing migration via the QMP command xen_save_devices_state, the current runstate is not store into the global state section. Also the current runstate is not the one we want on the receiver side. During migration, the Xen toolstack paused QEMU before save the devices st

[Qemu-devel] [PULL for-2.4 0/2] Fix migration on Xen

2015-08-03 Thread Stefano Stabellini
The following changes since commit f60c87154ac722c528fd5582f7137914a93c5eec: configure: Drop vnc-ws feature from help text (2015-08-03 15:32:17 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-migration-2.4-tag for you to fetch ch

Re: [Qemu-devel] [Xen-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Stefano Stabellini
On Mon, 3 Aug 2015, Amit Shah wrote: > On (Mon) 03 Aug 2015 [15:29:18], Anthony PERARD wrote: > > Hi, > > > > We've spotted several regression which prevent migration with Xen using the > > same version of QEMU or from a previous version of QEMU (tryied with 2.2). > > > > Regression have been int

Re: [Qemu-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Amit Shah
On (Mon) 03 Aug 2015 [15:29:18], Anthony PERARD wrote: > Hi, > > We've spotted several regression which prevent migration with Xen using the > same version of QEMU or from a previous version of QEMU (tryied with 2.2). > > Regression have been introduce by at least: > - df4b1024526cae3479da3492d63

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 11/11] new: arm/barrier-test for memory barriers

2015-08-03 Thread Alex Bennée
alvise rigo writes: > On Mon, Aug 3, 2015 at 12:30 PM, Alex Bennée wrote: >> >> alvise rigo writes: >> >>> Hi Alex, >>> >>> Nice set of tests, they are proving to be helpful. >>> One question below. >>> >>> >>> Why are we calling these last two instructions with the 'eq' suffix? >>> Shouldn't

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Paolo Bonzini
On 03/08/2015 17:35, Laurent Vivier wrote: > > I guess you mean tests/rtl8139-test.c > > What is the "in_Timer()" function ? There's some awful macro magic: #define PORT(name, len, val) \ static unsigned __attribute__((unused)) in_##name(void) \ { \ unsigned res = qpci_io_read##len(dev, d

Re: [Qemu-devel] [PATCH for-2.4 v3 1/3] migration: Fix global state with Xen.

2015-08-03 Thread Amit Shah
On (Mon) 03 Aug 2015 [15:53:57], Stefano Stabellini wrote: > On Mon, 3 Aug 2015, Anthony PERARD wrote: > > When doing migration via the QMP command xen_save_devices_state, the > > current runstate is not store into the global state section. Also the > > current runstate is not the one we want on th

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-03 Thread Karel Gardas
On Mon, Aug 3, 2015 at 4:51 PM, Dennis Luehring wrote: > ok - NetBSD 6.5.1 SPARC64 is blasting fast compare to Debian 7.8.0 SPARC64 - > i installed the complete system (without X) in a few minutes > Debian needs >1h I had the same experience with OpenBSD for sparc64, also fast to install. The pro

Re: [Qemu-devel] [PATCH for-2.4] configure: Drop vnc-ws feature from help text

2015-08-03 Thread Peter Maydell
On 24 July 2015 at 15:47, Andreas Färber wrote: > Commit 8e9b0d2 (ui: convert VNC websockets to use crypto APIs) dropped > the --enable-vnc-ws option but forgot to update the help text. Fix this. > > Cc: Daniel P. Berrange > Cc: Paolo Bonzini > Signed-off-by: Andreas Färber > --- > configure |

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Laurent Vivier
On 03/08/2015 17:18, Paolo Bonzini wrote: > > > On 03/08/2015 17:13, Laurent Vivier wrote: >> it says "33 MHz clock (30 ns clock ticks)" which is contradictory. I found that the spec allows for any speed up to Hz (30 ns cycle), so both are okay. However, at least hw

Re: [Qemu-devel] [PATCH v2] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on reinstall

2015-08-03 Thread Marc-André Lureau
Hi On Mon, Aug 3, 2015 at 4:33 PM, Leonid Bloch wrote: >> I think the root of the problem is that the wxs doesn't follow the >> "component rules": "qemu_ga" shouldn't contain various libs and >> executable. Instead, each file should have its own component. Then I >> think RemoveExistingProducts w

Re: [Qemu-devel] [PATCH v7 5/6] Initial implementation of vGICv3

2015-08-03 Thread Pavel Fedin
Hello! > > obj-$(CONFIG_APIC) += apic.o apic_common.o > > obj-$(CONFIG_ARM_GIC_KVM) += arm_gic_kvm.o > > +ifeq ($(ARCH), aarch64) # Only 64-bit KVM can use these > > +obj-$(CONFIG_ARM_GIC_KVM) += arm_gicv3_kvm.o > > Does it actually fail to compile in a 32-bit KVM config? I forgot to reply t

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Paolo Bonzini
On 03/08/2015 17:13, Laurent Vivier wrote: >>> >> it says "33 MHz clock (30 ns clock ticks)" which is contradictory. >> > >> > I found that the spec allows for any speed up to Hz (30 ns >> > cycle), so both are okay. However, at least hw/net/rtl8139.c assumes >> > it's 3300 Hz, so

Re: [Qemu-devel] [PATCH RFC v2 45/47] qapi: New QMP command query-schema for QMP schema introspection

2015-08-03 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 07/29/2015 03:19 AM, Markus Armbruster wrote: > Longest line is a bit over 4KiB for me. > If we break up string literals, at least use some indentation to make it obvious that multiple lines merge to a single array ent

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Laurent Vivier
On 03/08/2015 17:02, Paolo Bonzini wrote: > > > On 03/08/2015 16:46, Richard W.M. Jones wrote: I'm wondering if a 33 Mhz clock is 3300 Hz or Hz ? >> From the datasheet (chapter 16): >> >> https://www-ssl.intel.com/content/www/us/en/chipsets/6300esb-io-controller-hub-datasheet.

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Laurent Vivier
On 03/08/2015 16:46, Richard W.M. Jones wrote: > On Mon, Aug 03, 2015 at 04:28:14PM +0200, Laurent Vivier wrote: >> >> >> On 03/08/2015 15:52, Laurent Vivier wrote: >>> Originally, qemu_mod_timer() was using ticks to count time. >>> And i6300esb was converting internal clock ticks (33 MHz) to >>>

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Paolo Bonzini
On 03/08/2015 16:46, Richard W.M. Jones wrote: >> > I'm wondering if a 33 Mhz clock is 3300 Hz or Hz ? > From the datasheet (chapter 16): > > https://www-ssl.intel.com/content/www/us/en/chipsets/6300esb-io-controller-hub-datasheet.html > > it says "33 MHz clock (30 ns clock ticks)"

Re: [Qemu-devel] [PATCH for-2.4 v3 1/3] migration: Fix global state with Xen.

2015-08-03 Thread Stefano Stabellini
On Mon, 3 Aug 2015, Anthony PERARD wrote: > When doing migration via the QMP command xen_save_devices_state, the > current runstate is not store into the global state section. Also the > current runstate is not the one we want on the receiver side. > > During migration, the Xen toolstack paused QE

Re: [Qemu-devel] [PATCH for-2.4 v3 3/3] migration: Fix regression for xenfv and pc, accel=xen machine.

2015-08-03 Thread Stefano Stabellini
On Mon, 3 Aug 2015, Anthony PERARD wrote: > This fix migration from the same QEMU version and from previous QEMU > version. > > >From the global state section, we don't need runstate with Xen. Right now, > the way the Xen toolstack knows when QEMU is ready is when QEMU reach > "running" runstate.

Re: [Qemu-devel] [PATCH for-2.4 v3 2/3] migration: Add configuration section to vmstate with xen.

2015-08-03 Thread Anthony PERARD
On Mon, Aug 03, 2015 at 03:48:18PM +0100, Stefano Stabellini wrote: > On Mon, 3 Aug 2015, Anthony PERARD wrote: > > This adds the configuration section in the vmstate saved by > > xen_save_devices_state. > > > > Signed-off-by: Anthony PERARD > > It doesn't seem to me that this patch is actually

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-03 Thread Dennis Luehring
Am 30.07.2015 um 10:55 schrieb Aurelien Jarno: Note that when you say SPARC64 here, it's actually only the kernel, you are using a 32-bit userland. ok - NetBSD 6.5.1 SPARC64 is blasting fast compare to Debian 7.8.0 SPARC64 - i installed the complete system (without X) in a few minutes Debian

Re: [Qemu-devel] [PATCH for-2.4 v3 2/3] migration: Add configuration section to vmstate with xen.

2015-08-03 Thread Stefano Stabellini
On Mon, 3 Aug 2015, Anthony PERARD wrote: > This adds the configuration section in the vmstate saved by > xen_save_devices_state. > > Signed-off-by: Anthony PERARD It doesn't seem to me that this patch is actually necessary to fix the issue, is that right? If that is the case, I would rather s

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Richard W.M. Jones
On Mon, Aug 03, 2015 at 04:28:14PM +0200, Laurent Vivier wrote: > > > On 03/08/2015 15:52, Laurent Vivier wrote: > > Originally, qemu_mod_timer() was using ticks to count time. > > And i6300esb was converting internal clock ticks (33 MHz) to > > QEMU timer ticks. > > > > The timer has been chang

[Qemu-devel] [PULL for-2.4 1/1] Fix release_drive on unplugged devices (pci_piix3_xen_ide_unplug)

2015-08-03 Thread Stefano Stabellini
pci_piix3_xen_ide_unplug should completely unhook the unplugged IDEDevice from the corresponding BlockBackend, otherwise the next call to release_drive will try to detach the drive again. Suggested-by: Kevin Wolf Signed-off-by: Stefano Stabellini --- hw/ide/piix.c |7 +++ 1 file changed

[Qemu-devel] [PATCH for-2.4 v3 3/3] migration: Fix regression for xenfv and pc, accel=xen machine.

2015-08-03 Thread Anthony PERARD
This fix migration from the same QEMU version and from previous QEMU version. >From the global state section, we don't need runstate with Xen. Right now, the way the Xen toolstack knows when QEMU is ready is when QEMU reach "running" runstate. The configuration section and the section footers are

[Qemu-devel] [PULL for-2.4 0/1] cve-2015-5166-tag

2015-08-03 Thread Stefano Stabellini
The following changes since commit 2a3612ccc1fa9cea77bd193afbfe21c77e7e91ef: Merge remote-tracking branch 'remotes/stefanha/tags/rtl8139-cplus-tx-input-validation-pull-request' into staging (2015-08-03 13:09:10 +0100) are available in the git repository at: git://xenbits.xen.org/people/ss

Re: [Qemu-devel] [PATCH v2] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on reinstall

2015-08-03 Thread Leonid Bloch
Hi, On Mon, Aug 3, 2015 at 4:19 PM, Marc-André Lureau wrote: > Hi > > On Mon, Aug 3, 2015 at 3:00 PM, Leonid Bloch wrote: >>> >>> yes, but if you remove that RemoveExistingProducts too, then what fails? >> Only the manual call for RemoveExistingProducts is removed. >> MajorUpgrade places it autom

[Qemu-devel] [PATCH for-2.4 v3 1/3] migration: Fix global state with Xen.

2015-08-03 Thread Anthony PERARD
When doing migration via the QMP command xen_save_devices_state, the current runstate is not store into the global state section. Also the current runstate is not the one we want on the receiver side. During migration, the Xen toolstack paused QEMU before save the devices state. Also, the toolstac

[Qemu-devel] [PATCH for-2.4 v3 2/3] migration: Add configuration section to vmstate with xen.

2015-08-03 Thread Anthony PERARD
This adds the configuration section in the vmstate saved by xen_save_devices_state. Signed-off-by: Anthony PERARD --- migration/savevm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/migration/savevm.c b/migration/savevm.c index 6071215..b3f605c 100644 --- a/migration/savevm.c +++ b/m

[Qemu-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Anthony PERARD
Hi, We've spotted several regression which prevent migration with Xen using the same version of QEMU or from a previous version of QEMU (tryied with 2.2). Regression have been introduce by at least: - df4b1024526cae3479da3492d6371fd4a7324a03 migration: create new section to store global state -

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Laurent Vivier
On 03/08/2015 15:52, Laurent Vivier wrote: > Originally, qemu_mod_timer() was using ticks to count time. > And i6300esb was converting internal clock ticks (33 MHz) to > QEMU timer ticks. > > The timer has been changed by a script to use nanoseconds: > > 7447545 change all other clock refer

Re: [Qemu-devel] [Bug 1480562] [NEW] register values in sp804 timer

2015-08-03 Thread Peter Maydell
On 1 August 2015 at 15:46, T-T Yu wrote: > Public bug reported: > > In the arm_timer.c, when first reading the load register, I got 0. > > ... > case 0: /* TimerLoad */ > ... > > According to the specification at > http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0271d/index.html,

[Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Laurent Vivier
Originally, qemu_mod_timer() was using ticks to count time. And i6300esb was converting internal clock ticks (33 MHz) to QEMU timer ticks. The timer has been changed by a script to use nanoseconds: 7447545 change all other clock references to use nanosecond resolution accessors A

Re: [Qemu-devel] [PATCH v4 01/11] tcg: add ability to dump /tmp/perf-.map files

2015-08-03 Thread Paolo Bonzini
On 03/08/2015 11:14, Alex Bennée wrote: > This allows the perf tool to map samples to each individual translation > block. This could be expanded for user space but currently it gives > enough information to find any hotblocks by other means. > > Signed-off-by: Alex Bennée What happens if you

Re: [Qemu-devel] [PULL for-2.4 0/3] Regression fix for migration on Xen

2015-08-03 Thread Anthony PERARD
On Mon, Aug 3, 2015 at 1:44 PM, Amit Shah wrote: > The following changes since commit cb48f67ad8c7b33c617d4f8144a27706e69fd688: > > bsd-user: Fix operand to cpu_x86_exec (2015-07-30 12:38:49 +0100) > > are available in the git repository at: > > https://git.kernel.org/pub/scm/qemu/amit/migrati

  1   2   3   >