On 03/08/2015 17:13, Laurent Vivier wrote: >>> >> it says "33 MHz clock (30 ns clock ticks)" which is contradictory. >> > >> > I found that the spec allows for any speed up to 33333333 Hz (30 ns >> > cycle), so both are okay. However, at least hw/net/rtl8139.c assumes >> > it's 33000000 Hz, so it's nice to be consistent. > So, do you want I resend a patch with "1000 / 33" instead ? > > We can also update hw/net/rtl8139.c to replace "muldiv64(X, > get_ticks_per_sec(), 33000000)" by "X * 30" ?
Either would do. If you modify hw/net/rtl8139.c you have to modify CLK in tests/test-rtl8139.c as well. Paolo
