Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] mirror: Fix guest responsiveness during bitmap scan

2015-07-09 Thread Alexandre DERUMIER
>>Thinking about this again, I doubt >>that lengthening the duration with a hardcoded value benifits everyone; and >>before Alexandre's reply on old server/slow disks With 1ms sleep, I can reproduce the hang 100% with a fast cpu (xeon e5 v3 3,1ghz) and source raw file on nfs. - Mail origina

Re: [Qemu-devel] [PATCH 05/10] target-i386: Access segs via TCG registers

2015-07-09 Thread Richard Henderson
On 07/09/2015 02:30 PM, Paolo Bonzini wrote: On 09/07/2015 09:15, Richard Henderson wrote: Having segs[].base as a register significantly improves code generation for real and protected modes, particularly for TBs that have multiple memory references where the segment base can be held in a har

Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] mirror: Fix guest responsiveness during bitmap scan

2015-07-09 Thread Fam Zheng
On Thu, 07/09 14:02, Stefan Hajnoczi wrote: > This patch only converts the mirror block job to use the new relax > function. The other block jobs (stream, backup, commit) are still using > a 0 ns delay and are therefore broken. They should probably be > converted in the same series. That's becau

Re: [Qemu-devel] [RFC v2 04/34] cpu-exec: Migrate some generic fns to cpus.c

2015-07-09 Thread Peter Crosthwaite
On Mon, Jun 1, 2015 at 12:45 AM, Paolo Bonzini wrote: > > > On 31/05/2015 08:11, Peter Crosthwaite wrote: >> The goal is to split the functions such that cpu-exec is CPU specific >> content, while cpus.c is generic code only. The function interface to >> cpu-exec needs to be virtualised to prepare

Re: [Qemu-devel] [PATCH for-2.5 v2 0/4] block: replace IOV_MAX with BlockLimits.max_iov

2015-07-09 Thread Fam Zheng
On Thu, 07/09 10:56, Stefan Hajnoczi wrote: > v2: > * Default to IOV_MAX instead of INT_MAX [Peter Lieven] > > This series depends on "[PATCH] block/mirror: limit qiov to IOV_MAX elements". > > IOV_MAX has been hardcoded in several places since preadv()/pwritev()/etc > refuse to take more iovecs

Re: [Qemu-devel] [PATCH] target-ppc: Add POWER8E_v2.1 CPU model.

2015-07-09 Thread Alexey Kardashevskiy
On 07/09/2015 08:03 PM, Andrea Bolognani wrote: On Thu, 2015-07-09 at 12:35 +1000, Alexey Kardashevskiy wrote: Does "all versions of POWER8" include things like POWER8E, POWER8NVL and "POWER8 DD1", as one of the variations is known in the kernel source? Can we safely migrate guests eg. from a

[Qemu-devel] [PATCH v3 15/15] tests: add BlockJobTxn unit test

2015-07-09 Thread Fam Zheng
From: Stefan Hajnoczi The BlockJobTxn unit test verifies that both single jobs and pairs of jobs behave as a transaction group. Either all jobs complete successfully or the group is cancelled. Signed-off-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- tests/Makefile| 3 + test

[Qemu-devel] [PATCH v3 13/15] iotests: 124 - transactional failure test

2015-07-09 Thread Fam Zheng
From: John Snow Use a transaction to request an incremental backup across two drives. Coerce one of the jobs to fail, and then re-run the transaction. Verify that no bitmap data was lost due to the partial transaction failure. To support the 'transactional-cancel' QMP argument name it's necessa

[Qemu-devel] [PATCH v3 14/15] qmp-commands.hx: Update the supported 'transaction' operations

2015-07-09 Thread Fam Zheng
From: Kashyap Chamarthy Although the canonical source of reference for QMP commands is qapi-schema.json, for consistency's sake, update qmp-commands.hx to state the list of supported transactionable operations, namely: drive-backup blockdev-backup blockdev-snapshot-internal-sync

[Qemu-devel] [PATCH v3 11/15] blockdev: make BlockJobTxn available to qmp 'transaction'

2015-07-09 Thread Fam Zheng
From: Stefan Hajnoczi Provide a BlockJobTxn to actions executed in a qmp 'transaction' command. This allows actions to make their block jobs either complete as a group or fail/cancel together. The next patch adds the first user. Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Reviewed-

[Qemu-devel] [PATCH v3 12/15] block/backup: support block job transactions

2015-07-09 Thread Fam Zheng
From: Stefan Hajnoczi Join the transaction when the 'transactional-cancel' QMP argument is true. This ensures that the sync bitmap is not thrown away if another block job in the transaction is cancelled or fails. This is critical so incremental backup with multiple disks can be retried in case

[Qemu-devel] [PATCH v3 08/15] blockjob: Simplify block_job_finish_sync

2015-07-09 Thread Fam Zheng
With job->completed and job->ret to replace BlockFinishData. Signed-off-by: Fam Zheng --- blockjob.c | 23 ++- 1 file changed, 2 insertions(+), 21 deletions(-) diff --git a/blockjob.c b/blockjob.c index fb1d9e7..11b48f5 100644 --- a/blockjob.c +++ b/blockjob.c @@ -179,43 +17

[Qemu-devel] [PATCH v3 07/15] blockjob: Add "completed" and "ret" in BlockJob

2015-07-09 Thread Fam Zheng
They are set when block_job_completed is called. Signed-off-by: Fam Zheng --- blockjob.c | 3 +++ include/block/blockjob.h | 9 + 2 files changed, 12 insertions(+) diff --git a/blockjob.c b/blockjob.c index 62bb906..fb1d9e7 100644 --- a/blockjob.c +++ b/blockjob.c @@ -89,6

[Qemu-devel] [PATCH v3 10/15] block: add block job transactions

2015-07-09 Thread Fam Zheng
From: Stefan Hajnoczi Sometimes block jobs must execute as a transaction group. Finishing jobs wait until all other jobs are ready to complete successfully. Failure or cancellation of one job cancels the other jobs in the group. Signed-off-by: Stefan Hajnoczi [Rewrite the implementation which

[Qemu-devel] [PATCH v3 06/15] blockjob: Add .txn_commit and .txn_abort transaction actions

2015-07-09 Thread Fam Zheng
They will be called if the job is part of a transaction, after all jobs in a transaction are completed or cancelled, before calling job->cb(). Signed-off-by: Fam Zheng --- include/block/blockjob.h | 12 1 file changed, 12 insertions(+) diff --git a/include/block/blockjob.h b/includ

[Qemu-devel] [PATCH v3 09/15] blockjob: Move BlockJobDeferToMainLoopData into BlockJob

2015-07-09 Thread Fam Zheng
This will bind the BH data to block job data and is therefore easier to manage, for example during cancellation. Signed-off-by: Fam Zheng --- blockjob.c | 34 +++--- include/block/blockjob.h | 16 ++-- 2 files changed, 29 insertions(+), 21 de

[Qemu-devel] [PATCH v3 04/15] block: keep bitmap if incremental backup job is cancelled

2015-07-09 Thread Fam Zheng
From: Stefan Hajnoczi Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret variable may be 0 when the job is cancelled so it's not enough to check ret < 0. Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Signed-off-by: Fam Zheng --- block/backup.c | 2 +-

[Qemu-devel] [PATCH v3 05/15] backup: Extract dirty bitmap handling as a separate function

2015-07-09 Thread Fam Zheng
This will be reused by the coming new transactional completion code. Signed-off-by: Fam Zheng --- block/backup.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/block/backup.c b/block/backup.c index 965654d..6e24384 100644 --- a/block/backup.c +++

[Qemu-devel] [PATCH v3 00/15] block: incremental backup transactions using BlockJobTxn

2015-07-09 Thread Fam Zheng
v3: Simplify the code a bit to implement the idea as discussed in v2 thread: https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg02130.html Unchanged: [01/15] qapi: Add transaction support to block-dirty-bitmap operations [02/15] iotests: add transactional incremental backup t

[Qemu-devel] [PATCH v3 02/15] iotests: add transactional incremental backup test

2015-07-09 Thread Fam Zheng
From: John Snow Test simple usage cases for using transactions to create and synchronize incremental backups. Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Signed-off-by: Fam Zheng --- tests/qemu-iotests/

[Qemu-devel] [PATCH v3 03/15] block: rename BlkTransactionState and BdrvActionOps

2015-07-09 Thread Fam Zheng
From: John Snow These structures are misnomers, somewhat. (1) BlockTransactionState is not state for a transaction, but is rather state for a single transaction action. Rename it "BlkActionState" to be more accurate. (2) The BdrvActionOps describes operations for the BlkActionState,

[Qemu-devel] [PATCH v3 01/15] qapi: Add transaction support to block-dirty-bitmap operations

2015-07-09 Thread Fam Zheng
From: John Snow This adds two qmp commands to transactions. block-dirty-bitmap-add allows you to create a bitmap simultaneously alongside a new full backup to accomplish a clean synchronization point. block-dirty-bitmap-clear allows you to reset a bitmap back to as-if it were new, which can als

Re: [Qemu-devel] [Qemu-block] [PATCH 1/3] blockjob: Introduce block_job_relax_cpu

2015-07-09 Thread Alexandre DERUMIER
Hi Stefan, >>By the way, why did you choose 10 milliseconds? That is quite long. >> >>If this function is called once per 10 ms disk I/O operations then we >>lose 50% utilization. 1 ms or less would be reasonable. >From my tests, 1ms is not enough, It still hanging in guest or qmp queries. 10ms

Re: [Qemu-devel] [PATCH] KVM: x86: Add host physical address width capability

2015-07-09 Thread Bandan Das
Bandan Das writes: > Laszlo Ersek writes: > ... >> Yes. >> >>> Without EPT, you don't >>> hit the processor limitation with your setup, but the user should >>> nevertheless >>> still be notified. >> >> I disagree. >> >>> In fact, I think shadow paging code should also emulate >>> this behavior

[Qemu-devel] [PATCH 3/4] arm/xlnx-zynqmp: fix memory leak

2015-07-09 Thread arei.gonglei
From: Gonglei fix CID 1311372. Signed-off-by: Gonglei --- hw/arm/xlnx-zynqmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 5e72078..00c5943 100644 --- a/hw/arm/xlnx-zynqmp.c +++ b/hw/arm/xlnx-zynqmp.c @@ -144,7 +144,

[Qemu-devel] [PATCH 0/4] fix memory leak

2015-07-09 Thread arei.gonglei
From: Gonglei Spotted by Coverity. Gonglei (4): cpu: fix memory leak ppc/spapr_drc: fix memory leak arm/xlnx-zynqmp: fix memory leak vl.c: fix memory leak hw/arm/xlnx-zynqmp.c | 4 ++-- hw/ppc/spapr_drc.c | 1 + target-i386/cpu.c| 2 +- vl.c | 5 - 4 files cha

[Qemu-devel] [PATCH 2/4] ppc/spapr_drc: fix memory leak

2015-07-09 Thread arei.gonglei
From: Gonglei fix CID 1311373. Signed-off-by: Gonglei --- hw/ppc/spapr_drc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index ef98538..ee87432 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -422,6 +422,7 @@ static void realize(Devic

[Qemu-devel] [PATCH 1/4] cpu: fix memory leak

2015-07-09 Thread arei.gonglei
From: Gonglei Failing to save or free storage allocated by "g_strdup(names[0])" leaks it. Actually, we can pass names[0] directly. Signed-off-by: Gonglei --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f9b178

[Qemu-devel] [PATCH 4/4] vl.c: fix memory leak

2015-07-09 Thread arei.gonglei
From: Gonglei Failing to save or free storage allocated by "g_strdup(cmd)" leaks it. Let's use a variable to storage it. Signed-off-by: Gonglei --- vl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 3f269dc..399e816 100644 --- a/vl.c +++ b/vl.c @@ -1

Re: [Qemu-devel] [PATCH RFC 4/4] aio-posix: Use epoll in aio_poll

2015-07-09 Thread Fam Zheng
On Wed, 07/08 11:58, Stefan Hajnoczi wrote: > On Wed, Jul 08, 2015 at 09:01:27AM +0800, Fam Zheng wrote: > > On Tue, 07/07 16:08, Stefan Hajnoczi wrote: > > > > +#define EPOLL_BATCH 128 > > > > +static bool aio_poll_epoll(AioContext *ctx, bool blocking) > > > > +{ > > > > +AioHandler *node; > >

[Qemu-devel] [PATCH v2] ich9: initialise RCBA register through LPC interface

2015-07-09 Thread Paulo Alcantara
This patch initialises root complex register block BAR in order to support TCO watchdog emulation features on QEMU. Cc: Kevin O'Connor Cc: Gerd Hofmann Cc: Paolo Bonzini Signed-off-by: Paulo Alcantara --- v1 -> v2: - reserve RCBA address via e820 map --- src/fw/dev-q35.h | 3 +++ src/fw/pci

[Qemu-devel] 2.4.0-rc0 iotest 068 failure

2015-07-09 Thread John Snow
Fedora 21, 4.1.1, qemu 2.4.0-rc0 > ../../configure --target-list="x86_64-softmmu" 068 2s ... - output mismatch (see 068.out.bad) --- /home/bos/jhuston/src/qemu/tests/qemu-iotests/068.out 2015-07-08 17:56:18.588164979 -0400 +++ 068.out.bad 2015-07-09 17:39:58.636651317 -0400 @@ -6,6 +6,8 @@

Re: [Qemu-devel] [PULL 05/16] tap: Drop tap_can_send

2015-07-09 Thread Aurelien Jarno
On 2015-06-12 13:57, Stefan Hajnoczi wrote: > From: Fam Zheng > > This callback is called by main loop before polling s->fd, if it returns > false, the fd will not be polled in this iteration. > > This is redundant with checks inside read callback. After this patch, > the data will be sent to pe

[Qemu-devel] [ANNOUNCE] QEMU 2.4.0-rc0 is now available

2015-07-09 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 2.4 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.4.0-rc0.tar.bz2 You can help impr

[Qemu-devel] [PATCH for-2.4] pc: fix machine options for pc-i440fx-2.3 and below

2015-07-09 Thread Michael Roth
Commit fddd179 introduced a mechanical change that initialized default machine options using functions instead of macros. Prior to the change options for pc-i440fx-2.3 were defined as: #define PC_I440FX_MACHINE_OPTIONS \ PC_DEFAULT_MACHINE_OPTIONS, \ .family = "pc_piix", \ .des

Re: [Qemu-devel] [PATCH] KVM: x86: Add host physical address width capability

2015-07-09 Thread Laszlo Ersek
On 07/09/15 22:02, Bandan Das wrote: > Laszlo Ersek writes: > ... >> Yes. >> >>> Without EPT, you don't >>> hit the processor limitation with your setup, but the user should >>> nevertheless >>> still be notified. >> >> I disagree. >> >>> In fact, I think shadow paging code should also emulate >>

Re: [Qemu-devel] [PATCH] KVM: x86: Add host physical address width capability

2015-07-09 Thread Bandan Das
Laszlo Ersek writes: ... > Yes. > >> Without EPT, you don't >> hit the processor limitation with your setup, but the user should >> nevertheless >> still be notified. > > I disagree. > >> In fact, I think shadow paging code should also emulate >> this behavior if the gpa is out of range. > > I di

Re: [Qemu-devel] [PATCH] target-i386: Sanity check host processor physical address width

2015-07-09 Thread Laszlo Ersek
On 07/09/15 21:11, Bandan Das wrote: > Laszlo Ersek writes: > ... First, see my comments on the KVM patch. Second, ram_size is not the right thing to compare. What should be checked is whether the highest guest-physical address that maps to RAM can be represented in t

Re: [Qemu-devel] [PATCH] target-i386: Sanity check host processor physical address width

2015-07-09 Thread Bandan Das
Igor Mammedov writes: > On Wed, 08 Jul 2015 18:42:01 -0400 > Bandan Das wrote: > >> >> If a Linux guest is assigned more memory than is supported >> by the host processor, the guest is unable to boot. That >> is expected, however, there's no message indicating the user >> what went wrong. This

Re: [Qemu-devel] [PATCH] target-i386: Sanity check host processor physical address width

2015-07-09 Thread Bandan Das
Paolo Bonzini writes: > On 09/07/2015 10:26, Laszlo Ersek wrote: >>> > >>> > Perhaps KVM could simply hide memory above the limit (i.e. treat it as >>> > MMIO), and the BIOS could remove RAM above the limit from the e820 >>> > memory map? >> I'd prefer to leave the guest firmware*s* out of this.

Re: [Qemu-devel] [PATCH] target-i386: Sanity check host processor physical address width

2015-07-09 Thread Bandan Das
Laszlo Ersek writes: ... >>> >>> First, see my comments on the KVM patch. >>> >>> Second, ram_size is not the right thing to compare. What should be >>> checked is whether the highest guest-physical address that maps to RAM >>> can be represented in the address width of the host processor (and onl

[Qemu-devel] [PATCH build-fix] target-i386: emulate CPUID level of real hardware

2015-07-09 Thread Radim Krčmář
W10 insider has a bug where it ignores CPUID level and interprets CPUID.(EAX=07H, ECX=0H) incorrectly, because CPUID in fact returned CPUID.(EAX=04H, ECX=0H); this resulted in execution of unsupported instructions. While it's a Windows bug, there is no reason to emulate incorrect level. I used h

Re: [Qemu-devel] Virtualising qmp_query_cpus() arch specifics

2015-07-09 Thread Peter Crosthwaite
On Thu, Jul 9, 2015 at 5:31 AM, Andreas Färber wrote: > Am 09.07.2015 um 08:36 schrieb Peter Crosthwaite: >> Hi All, >> >> So for my multi-arch work, one of the eventual requirements is to >> remove all #define TARGET_FOO from core code. I came across this in >> cpus.c/qmp_query_cpus(): >> >> #if

Re: [Qemu-devel] [PULL 0/3] X86 queue, 2015-07-03

2015-07-09 Thread Radim Krčmář
2015-07-06 10:39-0300, Eduardo Habkost: > On Sun, Jul 05, 2015 at 07:33:31PM +0100, Peter Maydell wrote: > > On 3 July 2015 at 21:47, Eduardo Habkost wrote: > > > The following changes since commit > > > 35360642d043c2a5366e8a04a10e5545e7353bd5: > > > > > > Merge remote-tracking branch > > > '

Re: [Qemu-devel] [PATCH] KVM: x86: Add host physical address width capability

2015-07-09 Thread Laszlo Ersek
On 07/09/15 20:32, Bandan Das wrote: > Paolo Bonzini writes: > >> On 09/07/2015 08:43, Laszlo Ersek wrote: >>> On 07/09/15 08:09, Paolo Bonzini wrote: On 09/07/2015 00:36, Bandan Das wrote: > Let userspace inquire the maximum physical address width > of the host processors;

Re: [Qemu-devel] [PATCH] tci: Fix compile failure by including qemu-common.h

2015-07-09 Thread Peter Crosthwaite
On Thu, Jul 9, 2015 at 9:58 AM, Peter Maydell wrote: > On 9 July 2015 at 17:49, Peter Maydell wrote: >> Compilation of TCI was accidentally broken by the recent disassembler >> changes: >> >> CCx86_64-softmmu/arch_init.o >> In file included from target-i386/cpu-qom.h:23:0, >>

Re: [Qemu-devel] [PATCH v4 3/4] target-arm: Extend the gic node properties

2015-07-09 Thread Christoffer Dall
On Thu, Jul 9, 2015 at 6:28 PM, Peter Maydell wrote: > On 9 July 2015 at 17:03, Christoffer Dall wrote: >> [whoops, re-adding qemu-devel] >> >> On Thu, Jul 9, 2015 at 5:07 PM, Alexander Graf wrote: >>> On 07/09/15 16:44, Christoffer Dall wrote: I'll be honest and say that I don't fully unde

Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices

2015-07-09 Thread Peter Crosthwaite
On Thu, Jul 9, 2015 at 9:59 AM, Andreas Färber wrote: > Am 09.07.2015 um 18:51 schrieb Cornelia Huck: >> Devices that don't live on a bus aren't caught by the normal device >> reset logic. Let's register a reset handler for those devices during >> device realization that calls the reset handler fo

[Qemu-devel] [PATCH for-2.5] tcg/i386: use softmmu fast path for unaligned accesses

2015-07-09 Thread Aurelien Jarno
Softmmu unaligned load/stores currently goes through through the slow path for two reasons: - to support unaligned access on host with strict alignement - to correctly handle accesses crossing pages x86 is only concerned by the second reason. Unaligned accesses are avoided by compilers, but ar

Re: [Qemu-devel] [PATCH] KVM: x86: Add host physical address width capability

2015-07-09 Thread Bandan Das
Paolo Bonzini writes: > On 09/07/2015 08:43, Laszlo Ersek wrote: >> On 07/09/15 08:09, Paolo Bonzini wrote: >>> >>> >>> On 09/07/2015 00:36, Bandan Das wrote: Let userspace inquire the maximum physical address width of the host processors; this can be used to identify maximum memor

Re: [Qemu-devel] Asking about QEMU's process in memory address space of host

2015-07-09 Thread Christopher Covington
On 07/08/2015 07:14 AM, Piyawath Boukom wrote: > Dear peoples in mailing-list, > > My name is Piyawath Boukom, I’m a student from Tokyo Tech. > I hope you can enlighten me about this. > > Below are things that those I would like to perform. > > - I want to identify where guest kernel lives in QE

Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-09 Thread Andrey Korolyov
On Wed, Jul 8, 2015 at 6:46 PM, Igor Mammedov wrote: > On Wed, 8 Jul 2015 13:01:05 +0300 > "Michael S. Tsirkin" wrote: > > [...] >> - this fixes qemu on current kernels, so it's a bugfix >> >> - this changes the semantics of memory hot unplug slightly >> so I think it's important to merge in 2.

Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices

2015-07-09 Thread Andreas Färber
Am 09.07.2015 um 18:51 schrieb Cornelia Huck: > Devices that don't live on a bus aren't caught by the normal device > reset logic. Let's register a reset handler for those devices during > device realization that calls the reset handler for the associated > device class. > > Suggested-by: Peter Cr

Re: [Qemu-devel] [PATCH] tci: Fix compile failure by including qemu-common.h

2015-07-09 Thread Peter Maydell
On 9 July 2015 at 17:49, Peter Maydell wrote: > Compilation of TCI was accidentally broken by the recent disassembler > changes: > > CCx86_64-softmmu/arch_init.o > In file included from target-i386/cpu-qom.h:23:0, > from target-i386/cpu.h:986, > from include

Re: [Qemu-devel] [PATCH v3 2/5] Extract some reusable vGIC code

2015-07-09 Thread Eric Auger
Pavel, On 07/07/2015 03:54 PM, Pavel Fedin wrote: > These functions are useful also for vGICv3 implementation. Make them > accessible > from within other modules. > > Actually kvm_dist_get() and kvm_dist_put() could also be made reusable, but > they would require two extra parameters (s->dev_fd a

[Qemu-devel] [PATCH for-2.4 2/2] watchdog/diag288: handle subsystem resets correctly

2015-07-09 Thread Cornelia Huck
From: Xu Wang Remember to reset the watchdog on subsystem resets that don't trigger a full system reset. [CH: adapted to resets of bus-less devices now being handled in core] Signed-off-by: Xu Wang Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 6 +- 1 file changed, 5 inser

[Qemu-devel] [PATCH for-2.4 0/2] reset for bus-less devices

2015-07-09 Thread Cornelia Huck
We currently don't trigger resets for devices that don't have a bus. Rather than having to remember to register a reset handler for each of these devices, this should be handled by the core; there's probably a better way to do this long-term but this fixes reset problems we're having right now. I'

[Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices

2015-07-09 Thread Cornelia Huck
Devices that don't live on a bus aren't caught by the normal device reset logic. Let's register a reset handler for those devices during device realization that calls the reset handler for the associated device class. Suggested-by: Peter Crosthwaite Signed-off-by: Cornelia Huck --- hw/core/qdev

[Qemu-devel] [PATCH] tci: Fix compile failure by including qemu-common.h

2015-07-09 Thread Peter Maydell
Compilation of TCI was accidentally broken by the recent disassembler changes: CCx86_64-softmmu/arch_init.o In file included from target-i386/cpu-qom.h:23:0, from target-i386/cpu.h:986, from include/qemu-common.h:122, from include/disas/bfd.

Re: [Qemu-devel] [PULL v3 00/22] QOM CPUState patch queue 2015-07-09

2015-07-09 Thread Peter Maydell
On 9 July 2015 at 16:22, Peter Maydell wrote: > On 9 July 2015 at 14:23, Andreas Färber wrote: >> Hello Peter, >> >> This is my QOM CPU patch queue. Please pull. >> >> v3 fixes ppc and linux-user related bugs. >> >> Regards, >> Andreas >> >> Cc: Peter Maydell >> >> Cc: Eduardo Habkost >> Cc: Pe

Re: [Qemu-devel] [PATCH pic32 2/7] Stop simulation when processor is suspended forever by WAIT instruction with interrupts disabled.

2015-07-09 Thread Christopher Covington
On 06/30/2015 09:57 PM, Serge Vakulenko wrote: > Hi Peter and Leon, > > With a bit of thinking, I agree, that the question of session > termination on WAIT instruction is quite complicated in case of > multi-core system, background i/o activity, mipsR6 core etc. So I'm > going to find another solu

Re: [Qemu-devel] [PULL for-2.4-rc0 0/2] Urgent fixes for 2.4

2015-07-09 Thread Peter Maydell
On 9 July 2015 at 15:57, Paolo Bonzini wrote: > The following changes since commit acf7b7fdf31fa76b53803790917c8acf23a2badb: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2015-07-08 20:46:35 +0100) > > are available in the git repository at: > > git://gi

Re: [Qemu-devel] [PATCH v4 3/4] target-arm: Extend the gic node properties

2015-07-09 Thread Peter Maydell
On 9 July 2015 at 17:03, Christoffer Dall wrote: > [whoops, re-adding qemu-devel] > > On Thu, Jul 9, 2015 at 5:07 PM, Alexander Graf wrote: >> On 07/09/15 16:44, Christoffer Dall wrote: >>> I'll be honest and say that I don't fully understand the details of the >>> interrupt-map specification, an

Re: [Qemu-devel] [PATCH for-2.4] watchdog/diag288: correctly register for system reset requests

2015-07-09 Thread Peter Crosthwaite
On Thu, Jul 9, 2015 at 5:41 AM, Cornelia Huck wrote: > On Wed, 8 Jul 2015 12:31:40 +0200 > Cornelia Huck wrote: > >> On Wed, 8 Jul 2015 09:45:05 +0200 >> Cornelia Huck wrote: >> >> > On Tue, 7 Jul 2015 14:11:18 -0700 >> > Peter Crosthwaite wrote: >> >> > > Yes I see. I think it is a core code b

Re: [Qemu-devel] Monitoring write to memory

2015-07-09 Thread Christopher Covington
On 07/01/2015 08:23 AM, Jun Koi wrote: > Hello, > > I am trying to monitor all the memory writing events inside Qemu by > instrumenting tcg_gen_qemu_st8, tcg_gen_qemu_st16, tcg_gen_qemu_st32, > tcg_gen_qemu_st64, as followings: > > > // in tcg-op.h > > void helper_checkmem(int64_t data, int64_t

Re: [Qemu-devel] [PATCH v3 3/5] Introduce irqchip type specification for KVM

2015-07-09 Thread Eric Auger
Hi Pavel, On 07/07/2015 03:54 PM, Pavel Fedin wrote: > This patch introduces kernel_irqchip_type member in Machine class, which > it passed to kvm_arch_irqchip_create. It allows machine models to specify s/it/is > correct GIC type during KVM capability verification. The variable is > defined as int

Re: [Qemu-devel] [PATCH v4 3/4] target-arm: Extend the gic node properties

2015-07-09 Thread Christoffer Dall
[whoops, re-adding qemu-devel] On Thu, Jul 9, 2015 at 5:07 PM, Alexander Graf wrote: > On 07/09/15 16:44, Christoffer Dall wrote: >> >> On Thu, Jul 09, 2015 at 04:02:14PM +0200, Claudio Fontana wrote: >>> >>> Hello Christoffer, >>> >>> just one question: >>> In preparation for adding the GIC

Re: [Qemu-devel] [PATCH] target-i386: Don't strdup() alias property name

2015-07-09 Thread Eduardo Habkost
On Thu, Jul 09, 2015 at 12:32:56PM -0300, Eduardo Habkost wrote: > Now object_property_add_alias() calls g_strdup() on the target property > name, so we don't need to call g_strdup() ourselves. > > Signed-off-by: Eduardo Habkost Applied to the x86 tree. -- Eduardo

Re: [Qemu-devel] [FIX PATCH] numa: Fix memory leak in numa_set_mem_node_id()

2015-07-09 Thread Eduardo Habkost
On Thu, Jul 09, 2015 at 08:57:36PM +0530, Bharata B Rao wrote: > Fix a memory leak in numa_set_mem_node_id(). > > Signed-off-by: Bharata B Rao Reviewed-by: Eduardo Habkost Applied to the NUMA tree. Thanks! -- Eduardo

[Qemu-devel] [PATCH] target-i386: Don't strdup() alias property name

2015-07-09 Thread Eduardo Habkost
Now object_property_add_alias() calls g_strdup() on the target property name, so we don't need to call g_strdup() ourselves. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b4f946

Re: [Qemu-devel] [PATCH v6 01/10] softmmu: add helper function to pass through retaddr

2015-07-09 Thread Aurelien Jarno
On 2015-07-07 16:31, Pavel Dovgalyuk wrote: > This patch introduces several helpers to pass return address > which points to the TB. Correct return address allows correct > restoring of the guest PC and icount. These functions should be used when > helpers embedded into TB invoke memory operations.

[Qemu-devel] [FIX PATCH] numa: Fix memory leak in numa_set_mem_node_id()

2015-07-09 Thread Bharata B Rao
Fix a memory leak in numa_set_mem_node_id(). Signed-off-by: Bharata B Rao --- numa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/numa.c b/numa.c index 3c80059..402804b 100644 --- a/numa.c +++ b/numa.c @@ -54,7 +54,7 @@ NodeInfo numa_info[MAX_NODES]; void numa_set_mem

Re: [Qemu-devel] [PULL v3 00/22] QOM CPUState patch queue 2015-07-09

2015-07-09 Thread Peter Maydell
On 9 July 2015 at 14:23, Andreas Färber wrote: > Hello Peter, > > This is my QOM CPU patch queue. Please pull. > > v3 fixes ppc and linux-user related bugs. > > Regards, > Andreas > > Cc: Peter Maydell > > Cc: Eduardo Habkost > Cc: Peter Crosthwaite > > The following changes since commit acf7b7

Re: [Qemu-devel] [PULL for-2.4-rc0 0/2] Urgent fixes for 2.4

2015-07-09 Thread Peter Maydell
On 9 July 2015 at 16:19, Christian Borntraeger wrote: > Am 09.07.2015 um 16:57 schrieb Paolo Bonzini: >> The following changes since commit acf7b7fdf31fa76b53803790917c8acf23a2badb: >> >> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into >> staging (2015-07-08 20:46:35 +0100

Re: [Qemu-devel] [PULL for-2.4-rc0 0/2] Urgent fixes for 2.4

2015-07-09 Thread Christian Borntraeger
Am 09.07.2015 um 16:57 schrieb Paolo Bonzini: > The following changes since commit acf7b7fdf31fa76b53803790917c8acf23a2badb: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2015-07-08 20:46:35 +0100) > > are available in the git repository at: > > git://

Re: [Qemu-devel] [PULL 5/6] numa: Store boot memory address range in node_info

2015-07-09 Thread Paolo Bonzini
On 09/07/2015 17:10, Bharata B Rao wrote: > On Thu, Jul 09, 2015 at 04:12:09PM +0200, Paolo Bonzini wrote: >> >> >> On 03/07/2015 22:50, Eduardo Habkost wrote: >>> From: Bharata B Rao >>> >>> Store memory address range information of boot memory in address >>> range list of numa_info. >>> >>> T

Re: [Qemu-devel] [PATCH 39/39] tests: Add ivshmem qtest

2015-07-09 Thread Andreas Färber
Hi Marc-André, Am 09.07.2015 um 16:37 schrieb Marc-André Lureau: > On Fri, Jun 26, 2015 at 6:02 PM, Marc-André Lureau > wrote: >>> Also, see the discussion on my RFC: CONFIG_LINUX is wrong here. It would >>> need to depend on KVM/eventfd, and for that there is no easy config >>> option available

Re: [Qemu-devel] [PULL 5/6] numa: Store boot memory address range in node_info

2015-07-09 Thread Bharata B Rao
On Thu, Jul 09, 2015 at 04:12:09PM +0200, Paolo Bonzini wrote: > > > On 03/07/2015 22:50, Eduardo Habkost wrote: > > From: Bharata B Rao > > > > Store memory address range information of boot memory in address > > range list of numa_info. > > > > This helps to have a common NUMA node lookup b

Re: [Qemu-devel] [RFC] target-arm: do not change CNTVOFF_EL2

2015-07-09 Thread Peter Maydell
On 9 July 2015 at 15:38, wrote: > From: Claudio Fontana > > after a vm is created, the cntvoff_el2 is already calculated > for us by kvm, do not attempt to change it. > > Signed-off-by: Claudio Fontana > --- > target-arm/kvm.c | 5 + > 1 file changed, 5 insertions(+) > > This is just an RF

Re: [Qemu-devel] [PULL 2/2] crypto: fix builtin qcrypto_cipher_free

2015-07-09 Thread Aurelien Jarno
On 2015-07-09 16:57, Paolo Bonzini wrote: > This was dereferencing a pointer before checking if it was NULL. > > Reported-by: Christian Borntraeger > Reported-by: Aurelien Jarno > Signed-off-by: Paolo Bonzini > --- > crypto/cipher-builtin.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deleti

Re: [Qemu-devel] [PATCH v2] cpu_defs: Simplify CPUTLB padding logic

2015-07-09 Thread Paolo Bonzini
On 09/07/2015 05:26, Peter Crosthwaite wrote: > There was a complicated subtractive arithmetic for determining the > padding on the CPUTLBEntry structure. Simplify this with a union. > > Signed-off-by: Peter Crosthwaite > --- > Changed since v1: > Remove un-needed anonymous union (Paolo review)

[Qemu-devel] [PULL 1/2] migration: fix RCU deadlock

2015-07-09 Thread Paolo Bonzini
migration_end calls synchronize_rcu() within a critical section. That causes a deadlock; move the call after rcu_read_unlock(). Signed-off-by: Paolo Bonzini --- migration/ram.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index c696814..

[Qemu-devel] [PULL 2/2] crypto: fix builtin qcrypto_cipher_free

2015-07-09 Thread Paolo Bonzini
This was dereferencing a pointer before checking if it was NULL. Reported-by: Christian Borntraeger Reported-by: Aurelien Jarno Signed-off-by: Paolo Bonzini --- crypto/cipher-builtin.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crypto/cipher-builtin.c b/crypto/ciphe

[Qemu-devel] [PULL for-2.4-rc0 0/2] Urgent fixes for 2.4

2015-07-09 Thread Paolo Bonzini
The following changes since commit acf7b7fdf31fa76b53803790917c8acf23a2badb: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2015-07-08 20:46:35 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetc

Re: [Qemu-devel] [PATCH v5] target-i386: Register QOM properties for feature flags

2015-07-09 Thread Eduardo Habkost
On Thu, Jul 09, 2015 at 04:15:19PM +0200, Paolo Bonzini wrote: > > > On 14/04/2015 17:28, Eduardo Habkost wrote: > > +for (i = 1; names[i]; i++) { > > +feat2prop(names[i]); > > +object_property_add_alias(obj, names[i], obj, names[0], > > &error_abort); > > The version you co

Re: [Qemu-devel] qcow crypto changes crash on migration (was: [PULL 10/12] block: convert qcow/qcow2 to use generic cipher API)

2015-07-09 Thread Aurelien Jarno
On 2015-07-09 12:53, Christian Borntraeger wrote: > Forgot some CCs (patch author and migration folks) > > > Am 09.07.2015 um 12:17 schrieb Christian Borntraeger: > > Am 07.07.2015 um 16:12 schrieb Paolo Bonzini: > >> From: "Daniel P. Berrange" > >> > >> Switch the qcow/qcow2 block driver over t

Re: [Qemu-devel] [PULL 10/28] Sanity check RDMA remote data

2015-07-09 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 07/07/2015 15:08, Juan Quintela wrote: > > From: "Dr. David Alan Gilbert" > > > > Perform some basic (but probably not complete) sanity checking on > > requests from the RDMA source. > > > > Signed-off-by: Dr. David Alan Gilbert > > Review

Re: [Qemu-devel] [PATCH 39/39] tests: Add ivshmem qtest

2015-07-09 Thread Marc-André Lureau
Hi Andreas On Fri, Jun 26, 2015 at 6:02 PM, Marc-André Lureau wrote: >> Also, see the discussion on my RFC: CONFIG_LINUX is wrong here. It would >> need to depend on KVM/eventfd, and for that there is no easy config >> option available here, which stopped my patch at the time. > > > Right, I don'

[Qemu-devel] [RFC] target-arm: do not change CNTVOFF_EL2

2015-07-09 Thread hw . claudio
From: Claudio Fontana after a vm is created, the cntvoff_el2 is already calculated for us by kvm, do not attempt to change it. Signed-off-by: Claudio Fontana --- target-arm/kvm.c | 5 + 1 file changed, 5 insertions(+) This is just an RFC to show where QEMU is causing the change of CNTVOFF

Re: [Qemu-devel] [PATCH for 2.4 0/2] MIPS build fixes for v2.4

2015-07-09 Thread James Hogan
On 09/07/15 14:59, Peter Maydell wrote: > On 9 July 2015 at 12:52, Leon Alrae wrote: >> On 09/07/2015 10:17, James Hogan wrote: >>> These two patches fix build errors for the MIPS TCG backend and MIPS >>> KVM. >>> >>> Please could they be applied for v2.4. >>> >>> James Hogan (2): >>> tcg/mips:

[Qemu-devel] [PULL v3 11/22] cpu-exec: Purge all uses of ENV_GET_CPU()

2015-07-09 Thread Andreas Färber
From: Peter Crosthwaite Remove un-needed usages of ENV_GET_CPU() by converting the APIs to use CPUState pointers and retrieving the env_ptr as minimally needed. Scripted conversion for target-* change: for I in target-*/cpu.h; do sed -i \ 's/\(^int cpu_[^_]*_exec(\)[^ ][^ ]* \*s);$/\1CP

Re: [Qemu-devel] [PATCH v3 0/7] cpu: add i386 cpu hot remove support

2015-07-09 Thread Eduardo Otubo
On Fri, Jun 26, 2015 at 11=37=43AM +0800, Zhu Guihua wrote: > Hi, > On 06/24/2015 09:28 PM, Eduardo Otubo wrote: > >Hello Zhu, > > > >Are you still working on this feature? Could you provide a rebased > >version of this series? > > Sorry for late reply. > > Yes, we are still working on this featu

Re: [Qemu-devel] mem1 is in use, can not be deleted

2015-07-09 Thread Eduardo Otubo
On Tue, Jun 30, 2015 at 05=56=02PM +0200, Igor Mammedov wrote: > On Tue, 30 Jun 2015 15:56:13 +0200 > Eduardo Otubo wrote: > > > On Tue, Jun 30, 2015 at 11=18=21AM +0200, Igor Mammedov wrote: > > > On Tue, 30 Jun 2015 10:07:52 +0200 > > > Eduardo Otubo wrote: > > > > > > > Hello all, > > > > >

Re: [Qemu-devel] [PULL 10/12] arm: xlnx-zynqmp: Add 2xCortexR5 CPUs

2015-07-09 Thread Paolo Bonzini
On 19/06/2015 15:47, Peter Maydell wrote: > } > > +for (i = 0; i < XLNX_ZYNQMP_NUM_RPU_CPUS; i++) { > +char *name; > + > +name = object_get_canonical_path_component(OBJECT(&s->rpu_cpu[i])); > +if (strcmp(name, boot_cpu)) { This leaks "name", which has to be fre

Re: [Qemu-devel] [PULL 20/40] spapr_drc: initial implementation of sPAPRDRConnector device

2015-07-09 Thread Paolo Bonzini
On 03/06/2015 23:45, Alexander Graf wrote: > +child_name = object_get_canonical_path_component(OBJECT(drc)); > +DPRINTFN("drc child name: %s", child_name); > +object_property_add_alias(root_container, link_name, > + drc->owner, child_name, &err); child_na

Re: [Qemu-devel] [PATCH v5] target-i386: Register QOM properties for feature flags

2015-07-09 Thread Paolo Bonzini
On 14/04/2015 17:28, Eduardo Habkost wrote: > +for (i = 1; names[i]; i++) { > +feat2prop(names[i]); > +object_property_add_alias(obj, names[i], obj, names[0], > &error_abort); The version you committed has a strdup(names[0]) here, but object_property_add_alias already does a

[Qemu-devel] [PULL v3 18/22] disas: arm-a64: Make printfer and stream variable

2015-07-09 Thread Andreas Färber
From: Peter Crosthwaite In a normal disassembly flow, the printf() and stream being used varies from disas job to job. In particular it varies if mixing monitor_disas and target_disas. Make both the printf() function and target stream settable in the QEMUDisassmbler class. Reviewed-by: Claudio

Re: [Qemu-devel] [PULL 5/6] numa: Store boot memory address range in node_info

2015-07-09 Thread Paolo Bonzini
On 03/07/2015 22:50, Eduardo Habkost wrote: > From: Bharata B Rao > > Store memory address range information of boot memory in address > range list of numa_info. > > This helps to have a common NUMA node lookup by address function that > works for both boot-time memory and hotplugged memory.

Re: [Qemu-devel] [PULL 32/35] ahci: ncq migration

2015-07-09 Thread Paolo Bonzini
On 04/07/2015 08:07, John Snow wrote: > Migrate the NCQ queue. This is solely for the benefit of halted commands, > since anything else should have completed and had any relevant status > flushed to the HBA registers already. > > Signed-off-by: John Snow > Reviewed-by: Stefan Hajnoczi > Messag

Re: [Qemu-devel] [PULL 05/12] crypto: introduce generic cipher API & built-in implementation

2015-07-09 Thread Aurelien Jarno
On 2015-07-07 16:12, Paolo Bonzini wrote: > From: "Daniel P. Berrange" > > Introduce a generic cipher API and an implementation of it that > supports only the built-in AES and DES-RFB algorithms. > > The test suite checks the supported algorithms + modes to > validate that every backend implemen

  1   2   3   >