On 2015-06-12 13:57, Stefan Hajnoczi wrote: > From: Fam Zheng <f...@redhat.com> > > This callback is called by main loop before polling s->fd, if it returns > false, the fd will not be polled in this iteration. > > This is redundant with checks inside read callback. After this patch, > the data will be sent to peer when it arrives. If the device can't > receive, it will be queued to incoming_queue, and when the device status > changes, this queue will be flushed. > > Signed-off-by: Fam Zheng <f...@redhat.com> > Message-id: 1433400324-7358-7-git-send-email-f...@redhat.com > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > net/tap.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-)
I just gave a try to QEMU 2.4.0-rc0 with an s390x target, and it seems this patch breaks virtio-net with a tap device (it works well with the user mode network stack). The guest correctly sends out packets, but it seems to not get incoming packets. This is with TCG, I don't know if KVM is also affected. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net http://www.aurel32.net
