Re: [Qemu-devel] [PATCH] configure: Add support for jemalloc

2015-06-19 Thread Alexandre DERUMIER
@cc Fam Zheng , as he's the author of tcmalloc support patch - Mail original - De: "aderumier" À: "qemu-devel" Cc: "aderumier" Envoyé: Vendredi 19 Juin 2015 12:56:58 Objet: [PATCH] configure: Add support for jemalloc This adds "--enable-jemalloc" and "--disable-jemalloc" to allow link

Re: [Qemu-devel] [PATCH v2 0/3] m68k: fix ColdFire support

2015-06-19 Thread Greg Ungerer
Hi Laurent, On 20/06/15 05:39, Laurent Vivier wrote: Le 19/06/2015 15:43, g...@uclinux.org a écrit : Some small issues are causing problems with running modern versions of Linux on the m68k/ColdFire 5208 target. These 3 patches fix those problems. They are all due to use of more advanced arch

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-19 Thread Wen Congyang
At 2015/6/19 18:49, Stefan Hajnoczi Wrote: On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: At 2015/6/18 20:55, Stefan Hajnoczi Wrote: On Thu, Jun 18, 2015 at 04:49:12PM +

[Qemu-devel] [RFC 1/2] hw/i386/pc: factor out pc_cmos_init_floppy()

2015-06-19 Thread Laszlo Ersek
Extract the pc_cmos_init_floppy() function from pc_cmos_init(). The function sets two RTC registers: floppy drive types (0x10), overwriting the earlier value in there), and REG_EQUIPMENT_BYTE (0x14), setting bits in the prior value. Cc: Jan Tomko Cc: John Snow Cc: Markus Armbruster Cc: Paolo Bo

[Qemu-devel] [RFC 2/2] hw/i386/pc: reflect an explicitly created, sole FDC in the CMOS

2015-06-19 Thread Laszlo Ersek
With the pc-q35-2.4 machine type, if the user creates an ISA FDC manually: -device isa-fdc,driveA=drive-fdc0-0-0 \ -drive file=...,if=none,id=drive-fdc0-0-0,format=raw then the board-default FDC will be skipped, and only the explicitly requested FDC will exist. qtree-wise, this is correct; ho

[Qemu-devel] [RFC 0/2] update CMOS for single hand-created ISA-FDC

2015-06-19 Thread Laszlo Ersek
This is for the other pc-q35-2.4 ISA-FDC problem reported by Jan. Jan, can you give it a try pls? Cc: Jan Tomko Cc: John Snow Cc: Markus Armbruster Cc: Paolo Bonzini Laszlo Ersek (2): hw/i386/pc: factor out pc_cmos_init_floppy() hw/i386/pc: reflect an explicitly created, sole FDC in the

Re: [Qemu-devel] [PATCH 16/16] qtest/ahci: ncq migration test

2015-06-19 Thread John Snow
On 06/19/2015 09:50 PM, John Snow wrote: > Signed-off-by: John Snow > --- > tests/ahci-test.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/tests/ahci-test.c b/tests/ahci-test.c > index 941e0dd..206e6bb 100644 > --- a/tests/ahci-test.c > +++ b/tests/

[Qemu-devel] [PATCH 16/16] qtest/ahci: ncq migration test

2015-06-19 Thread John Snow
Signed-off-by: John Snow --- tests/ahci-test.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index 941e0dd..206e6bb 100644 --- a/tests/ahci-test.c +++ b/tests/ahci-test.c @@ -1140,9 +1140,9 @@ static void test_migrate_sa

[Qemu-devel] [PATCH 14/16] libqos/ahci: Force all NCQ commands to be LBA48

2015-06-19 Thread John Snow
NCQ commands are LBA48 by definition. See SATA 3.2 13.6.4.1 "READ FPDMA QUEUED", or SATA 3.2 13.6.5.1 "WRITE FPDMA QUEUED." Signed-off-by: John Snow --- tests/libqos/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c index 7c

[Qemu-devel] [PATCH 12/16] libqos/ahci: adjust expected NCQ interrupts

2015-06-19 Thread John Snow
NCQ commands will expect the SDBS interrupt, and in the normative case, do not expect to see a D2H Register FIS unless something went wrong. Signed-off-by: John Snow --- tests/libqos/ahci.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/libqos/ahci.c b/tests/l

[Qemu-devel] [PATCH 10/16] libqos/ahci: add NCQ frame support

2015-06-19 Thread John Snow
NCQ frames are generated a little differently than their non-NCQ cousins. Add support for them. Signed-off-by: John Snow --- tests/libqos/ahci.c | 44 +++- tests/libqos/ahci.h | 29 - 2 files changed, 63 insertions(+), 10 deleti

[Qemu-devel] [PATCH 13/16] libqos/ahci: set the NCQ tag on command_commit

2015-06-19 Thread John Snow
NCQ commands have the concept of a "TAG" that they need to set, but in the AHCI world, it is mandated that the TAG always match the command slot that you executed the NCQ from. See AHCI 9.3.1.1.5.2 "Native Queued Commands". Signed-off-by: John Snow --- tests/libqos/ahci.c | 5 + 1 file chan

[Qemu-devel] [PATCH 08/16] ahci: clear error register before NCQ cmd

2015-06-19 Thread John Snow
The legacy ide command execution layer will clear any errors outstanding before execution, but the NCQ layer doesn't. Even on success, this register will remain clogged. Clear it out before each NCQ command so the guest can tell if the error code produced after completion is meaningful or not. Si

[Qemu-devel] [PATCH 15/16] qtest/ahci: simple ncq data test

2015-06-19 Thread John Snow
Test the NCQ pathways for a simple IO RW test. Also, test that libqos doesn't explode when running NCQ commands :) Signed-off-by: John Snow --- tests/ahci-test.c | 13 + tests/libqos/ahci.c | 46 +- tests/libqos/ahci.h | 27 ++

[Qemu-devel] [PATCH 05/16] ahci: separate prdtl from opts

2015-06-19 Thread John Snow
There's no real reason to have it bundled together, and this way is a little nicer to follow if you have the AHCI spec pulled up. Signed-off-by: John Snow --- hw/ide/ahci.c | 23 --- hw/ide/ahci.h | 3 ++- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/hw/i

[Qemu-devel] [PATCH 07/16] ahci: ncq sector count correction

2015-06-19 Thread John Snow
This value should not be size-corrected, 0 sectors does not imply 1 sector(s). This is just debug information, but it's misleading! Signed-off-by: John Snow --- hw/ide/ahci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 8fcea18..6b

[Qemu-devel] [PATCH 11/16] libqos/ahci: edit wait to be ncq aware

2015-06-19 Thread John Snow
The wait command should check to make sure SACT is clear as well as the Command Issue register. Signed-off-by: John Snow --- tests/libqos/ahci.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c index 9a4d510..da02e2e 100644

[Qemu-devel] [PATCH 02/16] ahci: use shorter variables

2015-06-19 Thread John Snow
Trivial cleanup that I didn't want to tack-on to anything else. Signed-off-by: John Snow --- hw/ide/ahci.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 26df2ca..14eccb8 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @

[Qemu-devel] [PATCH 04/16] ahci: check for ncq prdtl overflow

2015-06-19 Thread John Snow
Don't attempt the NCQ transfer if the PRDT we were given is not big enough to perform the entire transfer. Signed-off-by: John Snow --- hw/ide/ahci.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 375aa44..24c4832 100

[Qemu-devel] [PATCH 06/16] ahci: add ncq debug checks

2015-06-19 Thread John Snow
Most of the time, these bits can be safely ignored. For the purposes of debugging however, it's nice to know that they're not being used. Signed-off-by: John Snow --- hw/ide/ahci.c | 25 + 1 file changed, 25 insertions(+) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index

[Qemu-devel] [PATCH 01/16] ahci: Rename NCQFIS structure fields

2015-06-19 Thread John Snow
Several fields of the NCQFIS structure are ambiguously named. This patch clarifies the intended (if unsupported) usage of the NCQ fields to aid in creating more meaningful debug messages through the NCQ codepaths. Signed-off-by: John Snow --- hw/ide/ahci.h | 35 +-

[Qemu-devel] [PATCH 03/16] ahci: add ncq_err helper

2015-06-19 Thread John Snow
Set some appropriate error bits for NCQ for us. Signed-off-by: John Snow --- hw/ide/ahci.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 14eccb8..375aa44 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -922,6 +922,15 @@

[Qemu-devel] [PATCH 00/16] ahci: ncq cleanup, part 1

2015-06-19 Thread John Snow
requires: 1434470575-21625-1-git-send-email-js...@redhat.com [PATCH v2 0/4] ahci: misc fixes/tests for 2.4 This series adds a couple of tests to exercise the NCQ pathways and establish a baseline for us. Most of these patches are fairly short and should be relatively trivial to review.

[Qemu-devel] [PATCH 09/16] libqos/ahci: fix cmd_sanity for ncq

2015-06-19 Thread John Snow
NCQ commands should not / do not update the byte count in the command header post command, so this field is meaningless for NCQ tests. Signed-off-by: John Snow --- tests/libqos/ahci.c | 46 -- tests/libqos/ahci.h | 3 +-- 2 files changed, 25 insertion

Re: [Qemu-devel] [PATCH 1/1] Add support for PCI Enhanced Allocation "BARs"

2015-06-19 Thread Stalley, Sean
Hi Michael, Have you had a chance to look at this? There's no hurry, im just curious. Thanks, Sean > -Original Message- > From: Sean O. Stalley [mailto:sean.stal...@intel.com] > Sent: Monday, June 01, 2015 9:38 AM > To: Michael S. Tsirkin > Cc: qemu-devel@nongnu.org > Subject: Re: [PATCH

Re: [Qemu-devel] [PATCH 5/8] hmp: added local apic dump state

2015-06-19 Thread Pavel
On 19.06.2015 18:45, Andreas Färber wrote: Am 19.06.2015 um 16:48 schrieb Denis V. Lunev: From: Pavel Butsykin Added the hmp command to query local apic registers state, may be usefull after guest crashes to understand IRQ routing in guest. For command name uses "apic-local" because it has

Re: [Qemu-devel] [PATCH 7/8] hmp: added io apic dump state

2015-06-19 Thread Pavel
On 19.06.2015 19:08, Peter Maydell wrote: On 19 June 2015 at 15:48, Denis V. Lunev wrote: From: Pavel Butsykin Added the hmp command to query io apic state, may be usefull after guest crashes to understand IRQ routing in guest. Implementation is only for kvm here. The dump will look like (

Re: [Qemu-devel] [PATCH 7/8] hmp: added io apic dump state

2015-06-19 Thread Pavel
On 19.06.2015 18:53, Andreas Färber wrote: Am 19.06.2015 um 16:48 schrieb Denis V. Lunev: From: Pavel Butsykin Added the hmp command to query io apic state, may be usefull after guest crashes to understand IRQ routing in guest. Implementation is only for kvm here. The dump will look like (q

Re: [Qemu-devel] [PATCH v5] mirror: correct buf_size

2015-06-19 Thread Jeff Cody
On Fri, May 15, 2015 at 03:51:36PM +0800, Wen Congyang wrote: > If bus_size is less than 0, the command fails. > If buf_size is 0, use DEFAULT_MIRROR_BUF_SIZE. > If buf_size % granularity is not 0, mirror_free_init() will > do dangerous things. > > Signed-off-by: Wen Congyang > Reviewed-by: Fam Z

Re: [Qemu-devel] Runtime-modified DIMMs and live migration issue

2015-06-19 Thread Andrey Korolyov
On Fri, Jun 19, 2015 at 7:57 PM, Andrey Korolyov wrote: >> I don`t think that it could be ACPI-related in any way, instead, it >> looks like race in vhost or simular mm-touching mechanism. The >> repeated hits you mentioned should be fixed as well indeed, but they >> can be barely the reason for t

Re: [Qemu-devel] [PATCH v2 0/3] m68k: fix ColdFire support

2015-06-19 Thread Laurent Vivier
Le 19/06/2015 15:43, g...@uclinux.org a écrit : > Some small issues are causing problems with running modern versions of > Linux on the m68k/ColdFire 5208 target. These 3 patches fix those problems. > > They are all due to use of more advanced architecture features not used > in older Linux kern

Re: [Qemu-devel] [PATCH v2 3/3] m68k: fix usp processing on interrupt entry and exception exit

2015-06-19 Thread Laurent Vivier
Le 19/06/2015 15:43, g...@uclinux.org a écrit : > From: Greg Ungerer > > The action to potentially switch sp register is not occurring at the correct > point in the interrupt entry or exception exit sequences. > > For the interrupt entry case the sp on entry is used to create the stack > excep

Re: [Qemu-devel] [PATCH v2 2/3] m68k: implement move to/from usp register instruction

2015-06-19 Thread Laurent Vivier
Le 19/06/2015 15:43, g...@uclinux.org a écrit : > From: Greg Ungerer > > Fill out the code support for the move to/from usp instructions. They are > being decoded, but there is no code to support there actions. So add it. > > Current versions of Linux running on the ColdFire 5208 use these ins

Re: [Qemu-devel] another isa-fdc problem...

2015-06-19 Thread John Snow
On 06/19/2015 03:10 PM, Laszlo Ersek wrote: > On 06/19/15 20:48, John Snow wrote: >> >> >> On 06/19/2015 02:17 PM, Laszlo Ersek wrote: >>> With Eduardo's recent patch (473a49460db0a90bfda046b8f3662b49f94098eb), >>> q35 machtypes earlier than 2.4 work as expected. Also, pc-q35-2.4 works >>> fine i

Re: [Qemu-devel] another isa-fdc problem...

2015-06-19 Thread Laszlo Ersek
On 06/19/15 20:48, John Snow wrote: > > > On 06/19/2015 02:17 PM, Laszlo Ersek wrote: >> With Eduardo's recent patch (473a49460db0a90bfda046b8f3662b49f94098eb), >> q35 machtypes earlier than 2.4 work as expected. Also, pc-q35-2.4 works >> fine in the default case (no board-default FDC, which is w

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix table revision and some comments

2015-06-19 Thread Andrew Jones
On Fri, Jun 19, 2015 at 02:59:32PM -0400, Andrew Jones wrote: > > > - Original Message - > > From: Shannon Zhao > > > > The table revision is not the ACPI spec version. Fix the wrong revision > > and also some comments. > > > > Signed-off-by: Shannon Zhao > > --- > > hw/arm/virt-acpi

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix table revision and some comments

2015-06-19 Thread Andrew Jones
- Original Message - > From: Shannon Zhao > > The table revision is not the ACPI spec version. Fix the wrong revision > and also some comments. > > Signed-off-by: Shannon Zhao > --- > hw/arm/virt-acpi-build.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > di

Re: [Qemu-devel] another isa-fdc problem...

2015-06-19 Thread John Snow
On 06/19/2015 02:17 PM, Laszlo Ersek wrote: > With Eduardo's recent patch (473a49460db0a90bfda046b8f3662b49f94098eb), > q35 machtypes earlier than 2.4 work as expected. Also, pc-q35-2.4 works > fine in the default case (no board-default FDC, which is what we want), > and the traditional option "-

Re: [Qemu-devel] [PATCH v7 14/42] Return path: Send responses from destination to source

2015-06-19 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Add migrate_send_rp_message to send a message from destination to source > > along the return path. > > (It uses a mutex to let it be called from multiple threads) >

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi-build: Add GICv2m description in ACPI MADT table

2015-06-19 Thread Andrew Jones
- Original Message - > From: Shannon Zhao > > Add GICv2m description in ACPI MADT table, so guest can use MSI when > booting with ACPI. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Tested-by: Andrew Jones Reviewed-by: Andrew Jones > --- > Fix endianness [Pe

Re: [Qemu-devel] [PATCH v2 11/11] Include monitor/monitor.h exactly where needed

2015-06-19 Thread Markus Armbruster
Breaks the Windows build. Squashing in this fix: diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index c8ee203..22c9abc 100644 --- a/ui/vnc-jobs.c +++ b/ui/vnc-jobs.c @@ -29,6 +29,7 @@ #include "vnc.h" #include "vnc-jobs.h" #include "qemu/sockets.h" +#include "block/aio.h" /* * Locking:

[Qemu-devel] another isa-fdc problem...

2015-06-19 Thread Laszlo Ersek
With Eduardo's recent patch (473a49460db0a90bfda046b8f3662b49f94098eb), q35 machtypes earlier than 2.4 work as expected. Also, pc-q35-2.4 works fine in the default case (no board-default FDC, which is what we want), and the traditional option "-drive if=floppy,..." also works as expected. However,

Re: [Qemu-devel] [PATCH] [RfC] fw_cfg file sort

2015-06-19 Thread Gabriel L. Somlo
On Fri, Jun 19, 2015 at 12:13:36PM +0200, Gerd Hoffmann wrote: > This is what it takes to have a sorted fw_cfg file directory. > Entries are inserted at the correct place instead of being > appended to the end in case sorting is enabled. On Mon, Jun 08, 2015 at 05:53:48PM +0200, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH v2 09/11] qerror: Move #include out of qerror.h

2015-06-19 Thread Markus Armbruster
Breaks the Windows build. Squashing in this fix: diff --git a/block/raw-win32.c b/block/raw-win32.c index dae5d2f..68f2338 100644 --- a/block/raw-win32.c +++ b/block/raw-win32.c @@ -29,6 +29,7 @@ #include "trace.h" #include "block/thread-pool.h" #include "qemu/iov.h" +#include "qapi/qmp/qstrin

Re: [Qemu-devel] [PATCH 02/10] qga: implement guest-pipe-open command

2015-06-19 Thread Denis V. Lunev
On 19/06/15 20:30, Eric Blake wrote: On 06/19/2015 10:57 AM, Denis V. Lunev wrote: From: Olga Krishtal The command creates FIFO pair that can be used with existing file read/write interfaces to communicate with processes spawned via the forthcoming guest-file-exec interface. Signed-off-by: Ol

Re: [Qemu-devel] [PATCH 09/10] qga: added bus type and disk location path

2015-06-19 Thread Denis V. Lunev
On 19/06/15 20:10, Eric Blake wrote: On 06/19/2015 10:57 AM, Denis V. Lunev wrote: From: Olga Krishtal According to Microsoft disk location path can be obtained via IOCTL_SCSI_GET_ADDRESS. Unfortunately this ioctl can not be used for all devices. There are certain bus types which could be obta

Re: [Qemu-devel] [PATCH 02/10] qga: implement guest-pipe-open command

2015-06-19 Thread Denis V. Lunev
On 19/06/15 20:34, Eric Blake wrote: On 06/19/2015 10:57 AM, Denis V. Lunev wrote: From: Olga Krishtal The command creates FIFO pair that can be used with existing file read/write interfaces to communicate with processes spawned via the forthcoming guest-file-exec interface. Signed-off-by: Ol

Re: [Qemu-devel] [PATCH v7 01/42] Start documenting how postcopy works.

2015-06-19 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 18/06/2015 09:50, Li, Liang Z wrote: > > Do you have any idea or plan to deal with the failure happened during > > the postcopy phase? > > > > Lost the guest is too frightening for a cloud provider, we have a > > discussion with Alibaba, the

Re: [Qemu-devel] [PATCH v7 12/42] Migration commands

2015-06-19 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Create QEMU_VM_COMMAND section type for sending commands from > > source to destination. These commands are not intended to convey > > guest state but to control the mi

Re: [Qemu-devel] [PATCH v5 00/12] Dirty bitmaps migration

2015-06-19 Thread John Snow
On 06/19/2015 12:57 PM, Denis V. Lunev wrote: > On 13/06/15 01:16, John Snow wrote: >> Ping for maintainer reviews -- I've given it a first pass and it should >> hopefully be close. >> >> Thanks, >> --js > do we need to respin? I do not see much attention from maintainers here. > > Den > Not s

Re: [Qemu-devel] [PULL 00/12] target-arm queue

2015-06-19 Thread Peter Maydell
board ACPI tables" patch also > to go in for 2.4, but it needs a little more review time. Other than that > I think we should be down to bugfix patches. > > -- PMM > > The following changes since commit ffdb1409a79c9cc91afd9f58df625fdca16bf8b9: > > Merge remote-tracki

Re: [Qemu-devel] [PATCH 02/10] qga: implement guest-pipe-open command

2015-06-19 Thread Eric Blake
On 06/19/2015 10:57 AM, Denis V. Lunev wrote: > From: Olga Krishtal > > The command creates FIFO pair that can be used with existing file > read/write interfaces to communicate with processes spawned via the > forthcoming guest-file-exec interface. > > Signed-off-by: Olga Krishtal > Signed-off-

[Qemu-devel] [PULL v3 10/14] qom: Make enum string tables const-correct

2015-06-19 Thread Andreas Färber
From: "Daniel P. Berrange" The enum string table parameters in various QOM/QAPI methods are declared 'const char *strings[]'. This results in const warnings if passed a variable that was declared as static const char * const strings[] = { }; Add the extra const annotation to the paramet

Re: [Qemu-devel] QEMU ARM SMP: IPI delivery delayed until next main loop event // how to improve IPI latency?

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 17:57, Paolo Bonzini wrote: > > > On 12/06/2015 18:38, Alex Züpke wrote: >> CPU #0 CPU #1 >> == == >> ... other stuff ... WFI (wait for interrupt, like x86 "HLT") >> send SGI in MPCore >> polls for completene

[Qemu-devel] [PULL v3 04/14] scripts: Add support for path as argument of qom-tree

2015-06-19 Thread Andreas Färber
From: Martin Cerveny Add processing of optional argument path as "tree base". Signed-off-by: Martin Cerveny Signed-off-by: Andreas Färber --- scripts/qmp/qom-tree | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/qmp/qom-tree b/scripts/qmp/qom-tree index aea

Re: [Qemu-devel] [PATCH 02/10] qga: implement guest-pipe-open command

2015-06-19 Thread Eric Blake
On 06/19/2015 10:57 AM, Denis V. Lunev wrote: > From: Olga Krishtal > > The command creates FIFO pair that can be used with existing file > read/write interfaces to communicate with processes spawned via the > forthcoming guest-file-exec interface. > > Signed-off-by: Olga Krishtal > Signed-off-

[Qemu-devel] [PULL v3 08/14] qom: Add helper function for getting user objects root

2015-06-19 Thread Andreas Färber
From: "Daniel P. Berrange" Add object_get_objects_root() function which is a convenience for obtaining the Object * located at /objects in the object composition tree. Convert existing code over to use the new API where appropriate. Signed-off-by: Daniel P. Berrange Reviewed-by: Eric Blake Sig

[Qemu-devel] [PULL v3 03/14] tests: Use qtest_add_data_func() consistently

2015-06-19 Thread Andreas Färber
Replace uses of g_test_add_data_func() for QTest test cases. It is still valid to use it for any non-QTest test cases, which are not run for multiple target binaries. Suggested-by: John Snow Reviewed-by: John Snow Signed-off-by: Andreas Färber --- tests/ahci-test.c | 9 ++--- tests

[Qemu-devel] [PULL v3 06/14] doc: Document user creatable object types in help text

2015-06-19 Thread Andreas Färber
From: "Daniel P. Berrange" The QEMU help for -object is essentially useless, just giving users the generic syntax. Move it down into its own section and introduce a nested table where each user creatable object can be documented. The existing memory-backend-file, rng-random and rng-egd object typ

[Qemu-devel] [PULL v3 07/14] vl: Create (most) objects before creating chardev backends

2015-06-19 Thread Andreas Färber
From: "Daniel P. Berrange" Some types of object must be created before chardevs, other types of object must be created after chardevs. As such there is no option but to create objects in two phases. This takes the decision to create as many object types as possible right away before anyother bac

[Qemu-devel] [PULL v3 09/14] qom: Add object_new_with_props() / object_new_withpropv() helpers

2015-06-19 Thread Andreas Färber
From: "Daniel P. Berrange" It is reasonably common to want to create an object, set a number of properties, register it in the hierarchy and then mark it as complete (if a user creatable type). This requires quite a lot of error prone, verbose, boilerplate code to achieve. First a pair of functi

[Qemu-devel] [PULL v3 12/14] qom: Don't pass string table to object_get_enum() function

2015-06-19 Thread Andreas Färber
From: "Daniel P. Berrange" Now that properties can be explicitly registered as an enum type, there is no need to pass the string table to the object_get_enum() function. The object property registration already has a pointer to the string table. In changing this method signature, the hostmem bac

[Qemu-devel] [PULL v2 00/14] QOM devices patch queue 2015-06-19

2015-06-19 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. v3 reverts use of GLib macros in v2 and adds three commits. Regards, Andreas Cc: Peter Maydell Cc: Eduardo Habkost Cc: Paolo Bonzini Cc: Daniel P. Berrange Cc: Markus Armbruster The following changes since commit 8ffe756da048

[Qemu-devel] [PULL v3 02/14] qdev: Free property names after registering gpio aliases

2015-06-19 Thread Andreas Färber
From: Eduardo Habkost Now that object_property_add_alias() strdup()s target_name, we can free the property names in qdev_pass_gpios(). Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- hw/core/qdev.c | 2 ++ 1 file chang

[Qemu-devel] [PULL v3 11/14] qom: Add an object_property_add_enum() helper function

2015-06-19 Thread Andreas Färber
From: "Daniel P. Berrange" A QOM property can be parsed as enum using the visit_type_enum() helper function, but this forces callers to use the more complex generic object_property_add() method when registering it. It also requires that users of that object have access to the string map when they

[Qemu-devel] [PULL v3 01/14] qom: strdup() target property name on object_property_add_alias()

2015-06-19 Thread Andreas Färber
From: Eduardo Habkost With this, object_property_add_alias() callers can safely free the target property name, like what already happens with the 'name' argument to all object_property_add*() functions. Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Sig

[Qemu-devel] [PULL v3 05/14] backends: Fix typename of 'policy' enum property in hostmem obj

2015-06-19 Thread Andreas Färber
From: "Daniel P. Berrange" The 'policy' property was being registered with a typename of 'str', but it is in fact an enum of the 'HostMemPolicy' type. Signed-off-by: Daniel P. Berrange Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Andreas Färber --- backends/hostmem.c |

[Qemu-devel] [PULL v3 14/14] qdev: Un-deprecate qdev_init_nofail()

2015-06-19 Thread Andreas Färber
From: Markus Armbruster It's a perfectly sensible helper function. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Andreas Färber --- include/hw/qdev-core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/qdev-core.h b/include/hw/qde

[Qemu-devel] [PULL v3 13/14] qdev: Deprecated qdev_init() is finally unused, drop

2015-06-19 Thread Andreas Färber
From: Markus Armbruster qdev_init() is a wrapper around setting property "realized" to true, plus error handling that passes errors to qerror_report_err(). qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere.

Re: [Qemu-devel] [PATCH v7 11/42] Return path: socket_writev_buffer: Block even on non-blocking fd's

2015-06-19 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > The destination sets the fd to non-blocking on incoming migrations; > > this also affects the return path from the destination, and thus we > > need to make sure we can

[Qemu-devel] Serial Console bug

2015-06-19 Thread Programmingkid
I have noticed a bug with the serial console. If text is printed to it that is longer than the window size, the text is cut off instead of being wrapped around. I have noticed this issue on QEMU 2.3.50 (just git pull'ed today). My host operating system is Mac OS 10.6.8. Has anyone noticed this i

Re: [Qemu-devel] [PATCH v3 0/7] qdev: Mostly wean off QError

2015-06-19 Thread Andreas Färber
Am 19.06.2015 um 16:17 schrieb Markus Armbruster: > Only the calls in do_device_add() remain, because QMP's command > handler interface requires them. They'll go away when I wean QMP off > QError. > > Bonus: a few error reporting improvements. > > Casualty: some explanatory messages, see PATCH 5

Re: [Qemu-devel] [PATCH 09/10] qga: added bus type and disk location path

2015-06-19 Thread Eric Blake
On 06/19/2015 10:57 AM, Denis V. Lunev wrote: > From: Olga Krishtal > > According to Microsoft disk location path can be obtained via > IOCTL_SCSI_GET_ADDRESS. Unfortunately this ioctl can not be used for all > devices. There are certain bus types which could be obtained with this > API. Please r

Re: [Qemu-devel] [PATCH v7 07/42] ram_debug_dump_bitmap: Dump a migration bitmap as text

2015-06-19 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Useful for debugging the migration bitmap and other bitmaps > > of the same format (including the sentmap in postcopy). > > > > The bitmap is printed to stderr. > > Line

Re: [Qemu-devel] QEMU ARM SMP: IPI delivery delayed until next main loop event // how to improve IPI latency?

2015-06-19 Thread Paolo Bonzini
On 12/06/2015 18:38, Alex Züpke wrote: > CPU #0 CPU #1 > == == > ... other stuff ... WFI (wait for interrupt, like x86 "HLT") > send SGI in MPCore > polls for completeness > > polls ... > <

[Qemu-devel] [PATCH 08/10] qga: added mountpoint and filesystem type for single volume

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal We should use GetVolumeXXX api to work with volumes. This will help us to resolve the situation with volumes without drive letter, i.e. when the volume is mounted as a folder. Such volume is called mounted folder. This volume is a regular mounted volume from all other points o

Re: [Qemu-devel] [PATCH v5 00/12] Dirty bitmaps migration

2015-06-19 Thread Denis V. Lunev
On 13/06/15 01:16, John Snow wrote: Ping for maintainer reviews -- I've given it a first pass and it should hopefully be close. Thanks, --js do we need to respin? I do not see much attention from maintainers here. Den On 05/13/2015 11:29 AM, Vladimir Sementsov-Ogievskiy wrote: These patche

[Qemu-devel] [PATCH 10/10] qga: added GuestPCIAddress information

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal PCIAddress inforfation is obtained via SetupApi, which provides the information about address, bus, etc. We look throught entire device tree in the system and try to find device object for given volume. For this PDO SetupDiGetDeviceRegistryProperty is called, which reads PCI c

[Qemu-devel] [PATCH 07/10] qga: added empty qmp_quest_get_fsinfo functionality.

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal We need qmp_quest_get_fsinfo togather with vss-provider, which works with volumes. The call to this function is implemented via FindFirst/NextVolumes. Moreover volumes in Windows OS are filesystem unit, so it will be more effective to work with them rather with devices. Signe

[Qemu-devel] [PATCH 05/10] qga: guest-pipe-open for Windows guest

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal The patch creates anonymous pipe that can be passed as stdin/stdout/stderr handle to a child process spawned using forthcoming guest-file-exec command. Working with a pipe is done using the existing guest-file-* API. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev

[Qemu-devel] [PATCH 03/10] qga: guest exec functionality for Unix guests

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal Child process' stdin/stdout/stderr can be associated with handles for communication via read/write interfaces. The workflow should be something like this: * Open an anonymous pipe through guest-pipe-open * Execute a binary or a script in the guest. Arbitrary arguments and e

Re: [Qemu-devel] Runtime-modified DIMMs and live migration issue

2015-06-19 Thread Andrey Korolyov
> I don`t think that it could be ACPI-related in any way, instead, it > looks like race in vhost or simular mm-touching mechanism. The > repeated hits you mentioned should be fixed as well indeed, but they > can be barely the reason for this problem. Please find a trace from a single dimm plugging

[Qemu-devel] [PATCH 09/10] qga: added bus type and disk location path

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal According to Microsoft disk location path can be obtained via IOCTL_SCSI_GET_ADDRESS. Unfortunately this ioctl can not be used for all devices. There are certain bus types which could be obtained with this API. Please refer to the following link for more details https://techne

[Qemu-devel] [PATCH 04/10] qga: handle possible SIGPIPE in guest-file-write

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal qemu-ga should not exit on guest-file-write to pipe without read end but proper error code should be returned. The behavior of the spawned process should be default thus SIGPIPE processing should be reset to default after fork() but before exec(). Signed-off-by: Olga Krishtal

[Qemu-devel] [PATCH 02/10] qga: implement guest-pipe-open command

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal The command creates FIFO pair that can be used with existing file read/write interfaces to communicate with processes spawned via the forthcoming guest-file-exec interface. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev Acked-by: Roman Kagan CC: Eric Blake CC:

[Qemu-devel] [PATCH 01/10] util, qga: drop guest_file_toggle_flags

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal guest_file_toggle_flags is a copy from semi-portable qemu_set_nonblock. The latter is not working properly for Windows due to reduced Windows Posix implementation. On Windows OS there is a separate API for changing flags of file, pipes and sockets. Portable way to change file

[Qemu-devel] [PATCH 06/10] qga: guest exec functionality for Windows guests

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal Child process' stdin/stdout/stderr can be associated with handles for communication via read/write interfaces. The workflow should be something like this: * Open an anonymous pipe through guest-pipe-open * Execute a binary or a script in the guest. Arbitrary arguments and e

[Qemu-devel] [PATCH v5 0/10] QGA: disk and volume info for Windows & guest exec

2015-06-19 Thread Denis V. Lunev
Implementation of qmp_quest_get_fsinfo. This functionality will be used together with vss-provider in order to do freeze/unfreeze per volume (single mounted fs). These patches for guest-agent add the functionality to execute commands on a guest UNIX and Windows machines. These patches add the fol

[Qemu-devel] [PATCH 09/10] qga: added bus type and disk location path

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal According to Microsoft disk location path can be obtained via IOCTL_SCSI_GET_ADDRESS. Unfortunately this ioctl can not be used for all devices. There are certain bus types which could be obtained with this API. Please refer to the following link for more details https://techne

[Qemu-devel] [PATCH 06/10] qga: guest exec functionality for Windows guests

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal Child process' stdin/stdout/stderr can be associated with handles for communication via read/write interfaces. The workflow should be something like this: * Open an anonymous pipe through guest-pipe-open * Execute a binary or a script in the guest. Arbitrary arguments and e

[Qemu-devel] [PATCH 08/10] qga: added mountpoint and filesystem type for single volume

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal We should use GetVolumeXXX api to work with volumes. This will help us to resolve the situation with volumes without drive letter, i.e. when the volume is mounted as a folder. Such volume is called mounted folder. This volume is a regular mounted volume from all other points o

[Qemu-devel] [PATCH v4 0/10] QGA: disk and volume info for Windows & guest exec

2015-06-19 Thread Denis V. Lunev
Implementation of qmp_quest_get_fsinfo. This functionality will be used together with vss-provider in order to do freeze/unfreeze per volume (single mounted fs). These patches for guest-agent add the functionality to execute commands on a guest UNIX and Windows machines. These patches add the fol

[Qemu-devel] [PATCH 03/10] qga: guest exec functionality for Unix guests

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal Child process' stdin/stdout/stderr can be associated with handles for communication via read/write interfaces. The workflow should be something like this: * Open an anonymous pipe through guest-pipe-open * Execute a binary or a script in the guest. Arbitrary arguments and e

[Qemu-devel] [PATCH 02/10] qga: implement guest-pipe-open command

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal The command creates FIFO pair that can be used with existing file read/write interfaces to communicate with processes spawned via the forthcoming guest-file-exec interface. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev Acked-by: Roman Kagan CC: Eric Blake CC:

[Qemu-devel] [PATCH 10/10] qga: added GuestPCIAddress information

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal PCIAddress inforfation is obtained via SetupApi, which provides the information about address, bus, etc. We look throught entire device tree in the system and try to find device object for given volume. For this PDO SetupDiGetDeviceRegistryProperty is called, which reads PCI c

[Qemu-devel] [PATCH 07/10] qga: added empty qmp_quest_get_fsinfo functionality.

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal We need qmp_quest_get_fsinfo togather with vss-provider, which works with volumes. The call to this function is implemented via FindFirst/NextVolumes. Moreover volumes in Windows OS are filesystem unit, so it will be more effective to work with them rather with devices. Signe

[Qemu-devel] [PATCH 04/10] qga: handle possible SIGPIPE in guest-file-write

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal qemu-ga should not exit on guest-file-write to pipe without read end but proper error code should be returned. The behavior of the spawned process should be default thus SIGPIPE processing should be reset to default after fork() but before exec(). Signed-off-by: Olga Krishtal

[Qemu-devel] [PATCH 05/10] qga: guest-pipe-open for Windows guest

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal The patch creates anonymous pipe that can be passed as stdin/stdout/stderr handle to a child process spawned using forthcoming guest-file-exec command. Working with a pipe is done using the existing guest-file-* API. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev

[Qemu-devel] [PATCH 01/10] util, qga: drop guest_file_toggle_flags

2015-06-19 Thread Denis V. Lunev
From: Olga Krishtal guest_file_toggle_flags is a copy from semi-portable qemu_set_nonblock. The latter is not working properly for Windows due to reduced Windows Posix implementation. On Windows OS there is a separate API for changing flags of file, pipes and sockets. Portable way to change file

Re: [Qemu-devel] [PATCH v5 7/8] qom: add a object_property_add_enum helper method

2015-06-19 Thread Andreas Färber
Am 19.06.2015 um 18:38 schrieb Eric Blake: > On 05/27/2015 09:07 AM, Daniel P. Berrange wrote: >> A QOM property can be parsed as enum using the visit_type_enum() >> helper method, but this forces callers to use the more complex >> generic object_property_add() method when registering it. It >> als

  1   2   3   4   >