Am 19.06.2015 um 16:17 schrieb Markus Armbruster: > Only the calls in do_device_add() remain, because QMP's command > handler interface requires them. They'll go away when I wean QMP off > QError. > > Bonus: a few error reporting improvements. > > Casualty: some explanatory messages, see PATCH 5. > > v3: > * Trivially rebased, R-bys retained > * PATCH 1: Add rationale to commit message [Andreas] > * PATCH 2: Don't drop the comment outright, update it [Andreas] > * PATCH 3: Comment and commit message typos [Andreas] > v2: > * Trivially rebased > * PATCH 5+7: Error and commit message polish [Eric] > > Markus Armbruster (7): > qdev: Deprecated qdev_init() is finally unused, drop > qdev: Un-deprecate qdev_init_nofail()
Thanks, I applied these two to qom-next: https://github.com/afaerber/qemu-cpu/commits/qom-next > qdev-monitor: Stop error avalanche in qbus_find_recursive() > qdev-monitor: Fix check for full bus > qdev-monitor: Convert qbus_find() to Error > qdev-monitor: Propagate errors through set_property() > qdev-monitor: Propagate errors through qdev_device_add() Only 7/7 touches qdev.h again and should apply independently, so should be fine to go through your monitor queue. Thanks, Andreas > > hw/core/qdev.c | 47 ++++++--------- > include/hw/qdev-core.h | 5 +- > include/monitor/qdev.h | 2 +- > include/qapi/qmp/qerror.h | 3 - > qdev-monitor.c | 143 > ++++++++++++++++++++++++++-------------------- > vl.c | 7 ++- > 6 files changed, 106 insertions(+), 101 deletions(-) -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)
