Re: [Qemu-devel] [PATCH v2 2/7] STM32F2xx: Display PWM duty cycle from timer

2015-05-29 Thread Peter Crosthwaite
On Fri, May 29, 2015 at 10:45 PM, Alistair Francis wrote: > If correctly configured allow the STM32F2xx timer to print > out the PWM duty cycle information. > > Signed-off-by: Alistair Francis > --- > V2: > - Fix up if statement braces > - Remove stm32f2xx_timer_set_alarm() call > > hw/timer/s

[Qemu-devel] [PATCH v2 7/7] MAINTAINERS: Add Alistair to the maintainers list

2015-05-29 Thread Alistair Francis
Add Alistair Francis as the maintainer for the Netduino 2 and SMM32F205 SoC. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- MAINTAINERS | 15 +++ 1 file changed, 15 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0463696..4af3b24 100644 --- a/MAINTAI

[Qemu-devel] [PATCH v2 3/7] STM32F2xx: Add the ADC device

2015-05-29 Thread Alistair Francis
Add the STM32F2xx ADC device. This device randomly generates values on each read. This also includes creating a hw/adc directory. Signed-off-by: Alistair Francis --- V2: - Address Peter C's comments - Create a ADC folder and move the file in there - Move some of the registers into arrays de

[Qemu-devel] [PATCH v2 4/7] STM32F2xx: Add the SPI device

2015-05-29 Thread Alistair Francis
Add the STM32F2xx SPI device. Signed-off-by: Alistair Francis --- V2: - Address Peter C's comments default-configs/arm-softmmu.mak | 1 + hw/ssi/Makefile.objs| 1 + hw/ssi/stm32f2xx_spi.c | 205 include/hw/ssi/stm32f2xx_spi.h |

[Qemu-devel] [PATCH v2 1/7] STM32F205: Remove the individual device variables

2015-05-29 Thread Alistair Francis
Cleanup the individual DeviceState and SysBusDevice variables to re-use the same variable for each device. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- hw/arm/stm32f205_soc.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --gi

[Qemu-devel] [PATCH v2 2/7] STM32F2xx: Display PWM duty cycle from timer

2015-05-29 Thread Alistair Francis
If correctly configured allow the STM32F2xx timer to print out the PWM duty cycle information. Signed-off-by: Alistair Francis --- V2: - Fix up if statement braces - Remove stm32f2xx_timer_set_alarm() call hw/timer/stm32f2xx_timer.c | 9 + 1 file changed, 9 insertions(+) diff --git a

[Qemu-devel] [PATCH v2 0/7] Update the Netduino 2 Machine

2015-05-29 Thread Alistair Francis
This patchset continues with the Netduino 2 and STM32F205 SoC work. This patch series makes a small change to the STM32F2xx SoC to tidy up the code. Next a feature is added to the STM32F2xx timer to display the PWM duty cycle, when debugging is enabled. Then the STM32F2xx SPI and ADC devices are

Re: [Qemu-devel] STM32F205 SysTick emulation

2015-05-29 Thread Alistair Francis
On Fri, May 29, 2015 at 5:12 PM, Liviu Ionescu wrote: > I did some tests and comparisons between my new Cortex-M implementation and > the existing lm3s6965evb and netduino2 boards, and it seems the stm32f205 > does not enable the SysTick device, since my simple seconds counting > application ha

Re: [Qemu-devel] [PATCH] Use Aff1 with mpidr

2015-05-29 Thread Shannon Zhao
On 2015/5/30 1:37, Pavel Fedin wrote: > Hi! > >> Well KVM side should be fixed instead of driving us along wrong route. > > I have studied the question a bit more, and i discovered that MPIDR access > on ARM is not > trapped by KVM. And guest would always get the same value as host would. >

[Qemu-devel] [PATCH] linux-user: add signalfd/signalfd4 syscalls

2015-05-29 Thread Laurent Vivier
This patch introduces a system very similar to the one used in the kernel to attach specific functions to a given file descriptor. In this case, we attach a specific "read()" to the fd returned by signalfd() to be able to byte-swap the signalfd_siginfo structure provided by read(). This system co

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-05-29 Thread Liviu Ionescu
> On 30 May 2015, at 00:40, Peter Maydell wrote: > > ... Whether you call it > an SoC or an MCU, the key point is that there's a level of > abstraction, a container, between the CPU itself and the board. > That's where the RAM and flash usually live and that's where > the properties to control t

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 21:26, Liviu Ionescu wrote: >> On 29 May 2015, at 22:32, Peter Maydell wrote: >> RAM and flash size is not a property of the CPU -- the M3 itself >> has no builtin memory. RAM and flash are external to the CPU and >> are part of the SoC, so the CPU would be the wrong place to sp

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-05-29 Thread Liviu Ionescu
> On 29 May 2015, at 23:15, Paolo Bonzini wrote: > >> ... But then in the common case I suspect you want your flash to be >> non-zero at startup? nope. I just want a method to adjust the size of the internal ram & flash, existing inside the MCU, sizes currently hard-wired in the QEMU definit

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-05-29 Thread Liviu Ionescu
> On 29 May 2015, at 22:32, Peter Maydell wrote: > > On 29 May 2015 at 20:22, Liviu Ionescu wrote: >> -machine? in other words board? the ram-size is not a characteristic >> of the board, Cortex-M MCUs have both RAM & flash internally, so if >> --memory is not ok, probably ram & flash should be

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-05-29 Thread Paolo Bonzini
On 29/05/2015 22:13, Liviu Ionescu wrote: >>> You can use -drive >>> if=mtd,snapshot=on,file=null-co://,file.size=128K to start QEMU >>> with a zero 128K NOR flash. > did someone else have a faint thought that: > > - the above syntax might be a bit too complicated or non intuitive? Sure, this c

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-05-29 Thread Liviu Ionescu
> On 29 May 2015, at 22:33, Paolo Bonzini wrote: > > On 29/05/2015 21:27, Liviu Ionescu wrote: >>> If the flash is persistent, it should be tied to either "-pflash" >>> (NOR) or "-mtd" (NAND). Just using a different image then >>> results in resizing the flash. >> >> I did not try the resizing

[Qemu-devel] [PATCH] target-i386: Fix signedness of MSR_IA32_APICBASE_BASE

2015-05-29 Thread Eduardo Habkost
Existing definition triggers the following when using clang -fsanitize=undefined: hw/intc/apic_common.c:314:55: runtime error: left shift of 1048575 by 12 places cannot be represented in type 'int' Fix it so we won't try to shift a 1 to the sign bit of a signed integer. Suggested-by:

[Qemu-devel] [PATCH v2] pc: acpi: fix pvpanic for buggy guests

2015-05-29 Thread Radim Krčmář
In the old times, we always had pvpanic in ACPI and a _STA method told the guest not to use it. Automatic generation dropped the _STA method as the specification says that missing _STA means enabled and working. Some guests (Linux) had buggy drivers and this change made them unable to utilize pvpa

Re: [Qemu-devel] [PULL 0/5] X86 patch queue, 2015-05-29

2015-05-29 Thread Eduardo Habkost
On Fri, May 29, 2015 at 07:57:16PM +0100, Peter Maydell wrote: > On 29 May 2015 at 19:04, Eduardo Habkost wrote: > > The following changes since commit 2cc3bdbe2d3908f7a813d1c2d774cc2bf07746cd: > > > > Merge remote-tracking branch 'remotes/armbru/tags/pull-block-2015-05-29' > > into staging (20

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-05-29 Thread Paolo Bonzini
On 29/05/2015 21:27, Liviu Ionescu wrote: >> If the flash is persistent, it should be tied to either "-pflash" >> (NOR) or "-mtd" (NAND). Just using a different image then >> results in resizing the flash. > > I did not try the resizing mechanism, but I don't think it is > appropriate, one of my

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 20:22, Liviu Ionescu wrote: > -machine? in other words board? the ram-size is not a characteristic > of the board, Cortex-M MCUs have both RAM & flash internally, so if > --memory is not ok, probably ram & flash should be an extensions > of --cpu? RAM and flash size is not a pro

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 20:16, Martin Galvan wrote: > On Fri, May 29, 2015 at 4:15 PM, Liviu Ionescu wrote: >> this is fine with me. >> >> unfortunately I cannot review your patch, since I have not enough experience >> with that part of qemu. > > I think Peter M is the maintainer for Target-ARM. > > P

Re: [Qemu-devel] [PATCH 09/10 v10] target-tilegx: Generate tcg instructions to execute to _init_malloc in glib

2015-05-29 Thread Chen Gang
On 5/12/15 00:55, Richard Henderson wrote: >> +static void gen_v1cmpeqi(struct DisasContext *dc, >> > + uint8_t rdst, uint8_t rsrc, uint8_t imm8) >> > +{ >> > +int count; >> > +TCGv vdst = dest_gr(dc, rdst); >> > +TCGv tmp = tcg_temp_new_i64(); >> > + >> > +q

Re: [Qemu-devel] [PULL 2/5] apic: map APIC's MMIO region at each CPU's address space

2015-05-29 Thread Paolo Bonzini
On 29/05/2015 20:04, Eduardo Habkost wrote: > static int apic_no; > -static bool mmio_registered; > +CPUState *cpu = CPU(s->cpu); > +MemoryRegion *root; > > if (apic_no >= MAX_APICS) { > error_setg(errp, "%s initialization failed.", > @@ -307,11 +308,12 @@ static

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-05-29 Thread Liviu Ionescu
> On 29 May 2015, at 14:08, Paolo Bonzini wrote: > > > > On 29/05/2015 00:11, Liviu Ionescu wrote: >> for more flexibility, in the new Cortex-M implementation I'm working on, I >> can overwrite the vendor defined MCU internal SRAM size by using: >> >> -m sizeK >> >> I'm trying to find

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-05-29 Thread Liviu Ionescu
> On 29 May 2015, at 12:11, Igor Mammedov wrote: > > On Fri, 29 May 2015 01:11:30 +0300 > Liviu Ionescu wrote: > >> for more flexibility, in the new Cortex-M implementation I'm working on, I >> can overwrite the vendor defined MCU internal SRAM size by using: >> >> -m sizeK >> >> I'm

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-29 Thread Martin Galvan
On Fri, May 29, 2015 at 4:15 PM, Liviu Ionescu wrote: > this is fine with me. > > unfortunately I cannot review your patch, since I have not enough experience > with that part of qemu. I think Peter M is the maintainer for Target-ARM. Peter, is this OK to commit? -- Martin Galvan Software

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-29 Thread Liviu Ionescu
> On 29 May 2015, at 15:55, aurelio remonda wrote: > > 2015-05-28 18:22 GMT-03:00 Liviu Ionescu : >>> On 29 May 2015, at 00:09, Aurelio C. Remonda >>> wrote: >>> The optional FPU in the M4 could be added in the future as a "Cortex-M4F" >>> CPU. >> >> in my implementation I had a single name

Re: [Qemu-devel] [PULL 0/5] X86 patch queue, 2015-05-29

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 19:04, Eduardo Habkost wrote: > The following changes since commit 2cc3bdbe2d3908f7a813d1c2d774cc2bf07746cd: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-block-2015-05-29' > into staging (2015-05-29 15:32:15 +0100) > > are available in the git repository at: > >

[Qemu-devel] [PATCH 1/1] Add -incoming help text

2015-05-29 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The help/man text for -incoming defer didn't make it through the merge of the code that implemented it. Signed-off-by: Dr. David Alan Gilbert --- qemu-options.hx | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-opt

Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals

2015-05-29 Thread Eduardo Habkost
On Tue, May 26, 2015 at 01:49:56PM +0200, Paolo Bonzini wrote: > On 26/05/2015 10:33, Alexander Graf wrote: > > How about we have the KVM call today and calmly talk about maintainer > > responsibility borders? > > I'd be happy to attend the call today, yes. Was there a call? Any conclusions? --

Re: [Qemu-devel] Qemu uses C++ ??

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 19:23, Jun Koi wrote: > Oh, exactly which code is the AArch64 disassembler? > I looked at target-arm/*.c, but did not seem to find C++ code there. I must > missed it ... The disassemblers live in disas/. target-* is the TCG frontends (translators). -- PMM

Re: [Qemu-devel] Qemu uses C++ ??

2015-05-29 Thread Jun Koi
On Sat, May 30, 2015 at 1:09 AM, Peter Maydell wrote: > On 29 May 2015 at 19:01, Jun Koi wrote: > > I always thought that Qemu never has C++ code inside, but I am surprise > to > > see this when Aarch64 emulator is linked, as following (excerpt) > > The AArch64 disassembler is written in C++ (th

Re: [Qemu-devel] Qemu uses C++ ??

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 19:01, Jun Koi wrote: > I always thought that Qemu never has C++ code inside, but I am surprise to > see this when Aarch64 emulator is linked, as following (excerpt) The AArch64 disassembler is written in C++ (this is a third party bit of code which we include in QEMU). C++ is o

[Qemu-devel] [PULL 3/5] apic: convert ->busdev.qdev casts to C casts

2015-05-29 Thread Eduardo Habkost
From: Zhu Guihua Use C casts to avoid accessing ICCDevice's qdev field directly. Signed-off-by: Zhu Guihua Reviewed-by: Igor Mammedov Reviewed-by: Andreas Färber Acked-by: Andreas Färber Signed-off-by: Eduardo Habkost --- hw/intc/apic.c | 9 ++--- 1 file changed, 6 insertions(+), 3 del

[Qemu-devel] [PULL 2/5] apic: map APIC's MMIO region at each CPU's address space

2015-05-29 Thread Eduardo Habkost
From: Chen Fan Replace mapping APIC at global system address space with mapping it at per-CPU address spaces. Signed-off-by: Chen Fan Signed-off-by: Zhu Guihua Reviewed-by: Igor Mammedov Acked-by: Andreas Färber Signed-off-by: Eduardo Habkost --- exec.c| 5 + hw/i386/p

[Qemu-devel] [PULL 5/5] arch_init: Drop target-x86_64.conf

2015-05-29 Thread Eduardo Habkost
From: Ikey Doherty The target-x86_64.conf sysconfig file has been empty and essentially ignored now for several years. This change removes the unused file to enable moving towards a stateless configuration. Signed-off-by: Ikey Doherty Acked-by: Paolo Bonzini Reviewed-by: Eduardo Habkost Signe

[Qemu-devel] [PULL 0/5] X86 patch queue, 2015-05-29

2015-05-29 Thread Eduardo Habkost
The following changes since commit 2cc3bdbe2d3908f7a813d1c2d774cc2bf07746cd: Merge remote-tracking branch 'remotes/armbru/tags/pull-block-2015-05-29' into staging (2015-05-29 15:32:15 +0100) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/x86-pull-request fo

[Qemu-devel] [PULL 4/5] target-i386: Register QOM properties for feature flags

2015-05-29 Thread Eduardo Habkost
This uses the feature name arrays to register QOM properties for feature flags. This simply adds properties that can be configured using -global, but doesn't change x86_cpu_parse_featurestr() to use them yet. Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 122

[Qemu-devel] [PULL 1/5] pc: Ensure non-zero CPU ref count after attaching to ICC bus

2015-05-29 Thread Eduardo Habkost
From: Andreas Färber Setting the parent bus of a device increases its ref count, which we ultimately want to level out. However it is only safe to do so after the last reference to the device in local code, as qom-set or similar operations might decrease the ref count. Therefore move the object_

[Qemu-devel] Qemu uses C++ ??

2015-05-29 Thread Jun Koi
Hi, I always thought that Qemu never has C++ code inside, but I am surprise to see this when Aarch64 emulator is linked, as following (excerpt) c++ -I/usr/include/pixman-1 -I/home/me/projects/qemu-2.3.0/dtc/libfdt -fPIE -DPIE -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstri

Re: [Qemu-devel] [PULL 00/39] target-arm queue

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 14:10, Peter Maydell wrote: > Main thing here is the ACPI patchset landing... > > -- PMM > > The following changes since commit ba7c388963e099c0d2cedb7f048e3074725d: > > Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20150529-1'

Re: [Qemu-devel] where is crc32() function?

2015-05-29 Thread Jun Koi
On Fri, May 29, 2015 at 11:43 PM, Peter Maydell wrote: > On 29 May 2015 at 17:41, Jun Koi wrote: > > In target-arm/helper-a64.c, there is a call to crc32(). > > > > I searched everywhere in the source, but still cannot find this function > > anywhere (only crc32c() is available) > > > > Any hint

Re: [Qemu-devel] VirtIO windows driver: viostor.sys not post-installable

2015-05-29 Thread Cole Robinson
On 05/29/2015 10:43 AM, Philipp Hahn wrote: > Hello, > > we tried to migrate some Windows 2008 and 2012 VMs from Xen to KVM, but > installing the VirtIO viostor.sys driver fails, because the signature of > the driver doesn't seem to match what's stored in the corresponding .cat > file. > > On the

Re: [Qemu-devel] [PATCH] Use Aff1 with mpidr

2015-05-29 Thread Pavel Fedin
Hi! > Well KVM side should be fixed instead of driving us along wrong route. I have studied the question a bit more, and i discovered that MPIDR access on ARM is not trapped by KVM. And guest would always get the same value as host would. Theoretically you could modify the kernel so that PSCI

[Qemu-devel] [PATCH] tcg: Mask TCGMemOp appropriately for indexing

2015-05-29 Thread Richard Henderson
The addition of MO_AMASK means that places that used inverted masks need to be changed to use positive masks, and places that failed to mask the intended bits need updating. Cc: Yongbok Kim Signed-off-by: Richard Henderson --- This should fix the problem you found while testing the mipsr6 unali

Re: [Qemu-devel] [RFC PATCH 02/12] block: Introduce bdrv_lock and bdrv_unlock API

2015-05-29 Thread Eric Blake
On 05/29/2015 04:53 AM, Fam Zheng wrote: > For various purposes, BDS users call bdrv_drain or bdrv_drain_all to make sure > there are no pending requests duringA a series of operations on the BDS. But > in s/duringA/during/ > the middle of operations, the caller may 1) yield from a coroutine >

Re: [Qemu-devel] [Qemu-block] [PATCH v2] virtio: make features 64bit wide

2015-05-29 Thread Eric Blake
On 05/29/2015 01:51 AM, Gerd Hoffmann wrote: > Make features 64bit wide everywhere. Exception: command line flags > remain 32bit and are copyed into the lower 32 host_features at s/copyed/copied/ > initialization time. > > On migration a full 64bit guest_features field is sent if one of the > h

Re: [Qemu-devel] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign

2015-05-29 Thread Paolo Bonzini
On 13/05/2015 18:46, Denis V. Lunev wrote: > I agree with this. Kernel guys are aware and may be we will have > the fix after a while... I have heard (not tested) that performance > loss over multi-queue SSD is around 30%. I came up with this patch... can you test it with your test case (and old

Re: [Qemu-devel] where is crc32() function?

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 17:41, Jun Koi wrote: > In target-arm/helper-a64.c, there is a call to crc32(). > > I searched everywhere in the source, but still cannot find this function > anywhere (only crc32c() is available) > > Any hint where this function is, please? helper-a64.c has the hint you are loo

Re: [Qemu-devel] [PATCH v3 1/2] qga: add additional win32 cflags and libraries

2015-05-29 Thread Kirk Allan
>>> > On 05/28/2015 12:41 PM, Kirk Allan wrote: >> Use *extra-cflags to set cflags to such as _WIN32_WINVER and WINVER to > > That Unicode mdash looks suspicious; did you mean for it to be two ASCII > -- instead? Your right, it is --extra-clfags. I'll fix that. > >> add additional functionali

[Qemu-devel] where is crc32() function?

2015-05-29 Thread Jun Koi
Hi, In target-arm/helper-a64.c, there is a call to crc32(). I searched everywhere in the source, but still cannot find this function anywhere (only crc32c() is available) Any hint where this function is, please? Thanks.

Re: [Qemu-devel] [PATCH v2 3/3] icount: print a warning if there is no more deadline in sleep=no mode

2015-05-29 Thread Paolo Bonzini
On 29/05/2015 17:14, Victor CLEMENT wrote: > While qemu is running in sleep=no mode, a warning will be printed > when no timer deadline is set. > As this mode is intended for getting deterministic virtual time, if no > timer is set on the virtual clock this determinism is broken. > > Signed-off-

Re: [Qemu-devel] [PATCH] configure: don't apply -O2 if extra-cflags sets -O

2015-05-29 Thread Paolo Bonzini
On 29/05/2015 16:14, Alex Bennée wrote: > You mean just do: > > diff --git a/configure b/configure > index b707429..f13831a 100755 > --- a/configure > +++ b/configure > @@ -353,7 +353,7 @@ for opt do >;; >--cpu=*) cpu="$optarg" >;; > - --extra-cflags=*) QEMU_CFLAGS="$optarg $QEMU_CF

Re: [Qemu-devel] [PULL 0/1] Block QAPI, monitor, command line patches

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 12:07, Markus Armbruster wrote: > The following changes since commit ba7c388963e099c0d2cedb7f048e3074725d: > > Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20150529-1' > into staging (2015-05-29 10:17:49 +0100) > > are availa

Re: [Qemu-devel] [PATCH v6 3/3] target-mips: Misaligned memory accesses for MSA

2015-05-29 Thread Leon Alrae
On 27/05/2015 14:29, Yongbok Kim wrote: > MIPS SIMD Architecture vector loads and stores require misalignment support. > MSA Memory access should work as an atomic operation. Therefore, it has to > check validity of all addresses for a vector store access if it is spanning > into two pages. > > Se

Re: [Qemu-devel] [PATCH v6 3/3] target-mips: Misaligned memory accesses for MSA

2015-05-29 Thread Leon Alrae
On 27/05/2015 14:29, Yongbok Kim wrote: > MIPS SIMD Architecture vector loads and stores require misalignment support. > MSA Memory access should work as an atomic operation. Therefore, it has to > check validity of all addresses for a vector store access if it is spanning > into two pages. > > Se

Re: [Qemu-devel] [PATCH 2/2] Compile time checks for newer glib

2015-05-29 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 29 May 2015 at 16:01, Dr. David Alan Gilbert (git) > wrote: > > --- a/include/glib-compat.h > > +++ b/include/glib-compat.h > > @@ -16,6 +16,12 @@ > > #ifndef QEMU_GLIB_COMPAT_H > > #define QEMU_GLIB_COMPAT_H > > > > +/* > > + * The source f

Re: [Qemu-devel] [PATCH 2/2] Compile time checks for newer glib

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 16:01, Dr. David Alan Gilbert (git) wrote: > --- a/include/glib-compat.h > +++ b/include/glib-compat.h > @@ -16,6 +16,12 @@ > #ifndef QEMU_GLIB_COMPAT_H > #define QEMU_GLIB_COMPAT_H > > +/* > + * The source file including this compat header knows it's using newer glib > + * fun

Re: [Qemu-devel] [PATCH 2/2] Compile time checks for newer glib

2015-05-29 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 29/05/2015 17:01, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Newer glib has support for checking that applications aren't > > using newer glib calls than they should be. > > > > The support for the check

Re: [Qemu-devel] [PATCH 2/2] Compile time checks for newer glib

2015-05-29 Thread Paolo Bonzini
On 29/05/2015 17:01, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Newer glib has support for checking that applications aren't > using newer glib calls than they should be. > > The support for the check only went into glib 2.32 and it only > has macros for version 2

[Qemu-devel] [PATCH v5 3/6] target-arm: kvm - implement software breakpoints

2015-05-29 Thread Alex Bennée
These don't involve messing around with debug registers, just setting the breakpoint instruction in memory. GDB will not use this mechanism if it can't access the memory to write the breakpoint. All the kernel has to do is ensure the hypervisor traps the breakpoint exceptions and returns to usersp

[Qemu-devel] [PATCH v5 1/6] linux-headers: sync from my kernel tree (DEV)

2015-05-29 Thread Alex Bennée
I assume I'll properly merge the KVM Headers direct from Linux when the kernel side is upstream. These headers came from: https://git.linaro.org/people/alex.bennee/linux.git/shortlog/refs/heads/guest-debug/4.1-rc5-v5 Signed-off-by: Alex Bennée --- v2 - update ABI to include ->far v3 - updat

Re: [Qemu-devel] [PATCH] hw/display/exynos4210_fimd: Fix bit-swapping code

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 16:16, Peter Maydell wrote: > fimd_swap_data() includes code to reverse the bits in a > 64-bit integer, but an off-by-one error meant that it would > try to shift off the top of the integer. Correct the bug > (spotted by Coverity). > > Signed-off-by: Peter Maydell > --- > Compil

[Qemu-devel] [PATCH v5 0/6] QEMU support for KVM Guest Debug on arm64

2015-05-29 Thread Alex Bennée
Hi, You may be wondering what happened to v3 and v4. They do exist but they didn't change much from the the original patches as I've been mostly looking the kernel side of the equation. So in summary the changes are: - updates to the kernel ABI - don't fall over on kernels without debug suppo

[Qemu-devel] [PATCH v5 6/6] target-arm: kvm - re-inject guest debug exceptions

2015-05-29 Thread Alex Bennée
From: Alex Bennée If we can't find details for the debug exception in our debug state then we can assume the exception is due to debugging inside the guest. To inject the exception into the guest state we re-use the TCG exception code (do_interupt). However while guest debugging is in effect we

[Qemu-devel] [PATCH v5 4/6] target-arm: kvm - support for single step

2015-05-29 Thread Alex Bennée
This adds support for single-step. There isn't much to do on the QEMU side as after we set-up the request for single step via the debug ioctl it is all handled within the kernel. Signed-off-by: Alex Bennée --- v2 - convert to using HSR_EC v3 - use internals.h definitions --- target-arm/kvm.

[Qemu-devel] [PATCH v5 2/6] target-arm: kvm64: introduce kvm_arm_init_debug()

2015-05-29 Thread Alex Bennée
As we haven't always had guest debug support we need to probe for it. Additionally we don't do this in the start-up capability code so we don't fall over on old kernels. Signed-off-by: Alex Bennée --- target-arm/kvm64.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/targ

[Qemu-devel] [PATCH v5 5/6] target-arm: kvm - add support for HW assisted debug

2015-05-29 Thread Alex Bennée
This adds basic support for HW assisted debug. The ioctl interface to KVM allows us to pass an implementation defined number of break and watch point registers. When KVM_GUESTDBG_USE_HW_BP is specified these debug registers will be installed in place on the world switch into the guest. The hardwar

[Qemu-devel] [PATCH] hw/display/exynos4210_fimd: Fix bit-swapping code

2015-05-29 Thread Peter Maydell
fimd_swap_data() includes code to reverse the bits in a 64-bit integer, but an off-by-one error meant that it would try to shift off the top of the integer. Correct the bug (spotted by Coverity). Signed-off-by: Peter Maydell --- Compile-tested only, I have no exynos images to test with. hw/disp

[Qemu-devel] [PATCH v2 2/3] icount: add sleep parameter to the icount option to set icount_sleep mode

2015-05-29 Thread Victor CLEMENT
The 'sleep' parameter sets the icount_sleep mode, which is enabled by default. To disable it, add the 'sleep=no' parameter (or 'nosleep') to the qemu -icount option. Signed-off-by: Victor CLEMENT --- cpus.c | 9 + qemu-options.hx | 12 ++-- vl.c| 3 +++ 3 f

[Qemu-devel] [PATCH v2 3/3] icount: print a warning if there is no more deadline in sleep=no mode

2015-05-29 Thread Victor CLEMENT
While qemu is running in sleep=no mode, a warning will be printed when no timer deadline is set. As this mode is intended for getting deterministic virtual time, if no timer is set on the virtual clock this determinism is broken. Signed-off-by: Victor CLEMENT --- cpus.c | 6 ++ 1 file change

[Qemu-devel] [PATCH v2 0/3] implement a new icount sleep=no mode

2015-05-29 Thread Victor CLEMENT
This patch adds a new icount_sleep mode set by the new 'sleep' parameter of the icount option. When using sleep=no mode, the QEMU_VIRTUAL_CLOCK will be running at the maximal possible speed by warping the CPU sleep times to the soonest virtual clock deadline. The goal is to get deterministic execut

[Qemu-devel] [PATCH v2 1/3] icount: implement a new icount_sleep mode toggleing real-time cpu sleep

2015-05-29 Thread Victor CLEMENT
When the icount_sleep mode is disabled, the QEMU_VIRTUAL_CLOCK runs at the maximum possible speed by warping the sleep times of the virtual cpu to the soonest clock deadline. The virtual clock will be updated only according the instruction counter. Signed-off-by: Victor CLEMENT --- cpus.c | 70 +

Re: [Qemu-devel] [PATCH COLO-Frame v5 00/29] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-05-29 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 05/29/2015 04:42 PM, Dr. David Alan Gilbert wrote: > > * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >> On 2015/5/29 9:29, Wen Congyang wrote: > >>> On 05/29/2015 12:24 AM, Dr. David Alan Gilbert wrote: > * zhanghailiang (zhang.zhan

Re: [Qemu-devel] [PATCH 0/3] implement a new icount_no_rt mode

2015-05-29 Thread Victor Clement
- Mail original - > De: "Paolo Bonzini" > À: "Victor Clement" , qemu-devel@nongnu.org > Cc: "françois Guerret" , "Julien Viard de > Galbert" > Envoyé: Vendredi 29 Mai 2015 13:14:38 > Objet: Re: [Qemu-devel] [PATCH 0/3] implement a new icount_no_rt mode > > > > On 29/05/2015 10:54, Vic

[Qemu-devel] [PATCH 2/2] Compile time checks for newer glib

2015-05-29 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Newer glib has support for checking that applications aren't using newer glib calls than they should be. The support for the check only went into glib 2.32 and it only has macros for version 2.26 upwards; although we only insist on 2.22 at the moment, I set the gli

[Qemu-devel] [PATCH 1/2] Fix glib_subprocess test

2015-05-29 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" A typo means that the tests dependent on glib with subprocess support are never run. Fixes: 9d41401b90fa10b335d2e739149d36437cfbf622 Signed-off-by: Dr. David Alan Gilbert --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure

[Qemu-devel] [PATCH 0/2] Use glib's checks for use of too-new functions

2015-05-29 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Glib 2.32 adds a checking mechanism to warn of use of functions that are available in glib versions newer than a particular version. This series enables that check (via a -D added during configure); with it you get warnings like: /home/dgilbert/git/qemu-world3/vl.

Re: [Qemu-devel] [PATCH v2] virtio: make features 64bit wide

2015-05-29 Thread Michael S. Tsirkin
On Fri, May 29, 2015 at 09:51:20AM +0200, Gerd Hoffmann wrote: > Make features 64bit wide everywhere. Exception: command line flags > remain 32bit and are copyed into the lower 32 host_features at > initialization time. > > On migration a full 64bit guest_features field is sent if one of the > hi

[Qemu-devel] VirtIO windows driver: viostor.sys not post-installable

2015-05-29 Thread Philipp Hahn
Hello, we tried to migrate some Windows 2008 and 2012 VMs from Xen to KVM, but installing the VirtIO viostor.sys driver fails, because the signature of the driver doesn't seem to match what's stored in the corresponding .cat file. On the other hand installing the drivers during a fresh install fr

Re: [Qemu-devel] [PULL 0/5] gtk: add opengl rendering support.

2015-05-29 Thread Peter Maydell
in system emulation mode" (2015-05-28 > 16:57:35 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-gtk-20150529-1 > > for you to fetch changes up to 63c67b6d4462b6589b371d55e3740e9f0dba3281: &

Re: [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop

2015-05-29 Thread Thibaut Collet
Hi, I agree that virtio-net NIC never enqueues packet to vhost-user but qemu_announce_self function (savevm.c file) can do it through the qemu_announce_self_iter / qemu_send_packet_raw sequence. Regards Thibaut. On Fri, May 29, 2015 at 3:12 PM, Stefan Hajnoczi wrote: > On Thu, May 28, 2015 at

Re: [Qemu-devel] [PATCH v3 14/21] monitor: Limit QError use to command handlers

2015-05-29 Thread Luiz Capitulino
On Fri, 29 May 2015 16:23:55 +0200 Markus Armbruster wrote: > The following hunk needs to be squashed in: > > diff --git a/monitor.c b/monitor.c > index 16bd567..888d771 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -5005,7 +5005,6 @@ static void handle_qmp_command(JSONMessageParser > *parser

Re: [Qemu-devel] [PATCH v3 11/21] monitor: Propagate errors through invalid_qmp_mode()

2015-05-29 Thread Luiz Capitulino
On Fri, 29 May 2015 16:19:28 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Fri, 29 May 2015 11:56:50 +0200 > > Markus Armbruster wrote: > > > >> Signed-off-by: Markus Armbruster > >> --- > >> monitor.c | 18 ++ > >> 1 file changed, 10 insertions(+), 8 dele

Re: [Qemu-devel] [PATCH v3 14/21] monitor: Limit QError use to command handlers

2015-05-29 Thread Markus Armbruster
The following hunk needs to be squashed in: diff --git a/monitor.c b/monitor.c index 16bd567..888d771 100644 --- a/monitor.c +++ b/monitor.c @@ -5005,7 +5005,6 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens) goto err_out; } if (invalid_qmp_mode(mon,

Re: [Qemu-devel] [PATCH 1/1] Fix device listener interface for PCI to PCI bridges

2015-05-29 Thread Paul Durrant
> -Original Message- > From: Don Slutz [mailto:don.sl...@gmail.com] > Sent: 29 May 2015 14:23 > To: Michael S. Tsirkin; Paul Durrant > Cc: Don Slutz; qemu-devel@nongnu.org; Stefano Stabellini; xen-devel > Subject: Re: [Qemu-devel] [PATCH 1/1] Fix device listener interface for PCI to > PCI b

Re: [Qemu-devel] [PATCH v3 11/21] monitor: Propagate errors through invalid_qmp_mode()

2015-05-29 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 29 May 2015 11:56:50 +0200 > Markus Armbruster wrote: > >> Signed-off-by: Markus Armbruster >> --- >> monitor.c | 18 ++ >> 1 file changed, 10 insertions(+), 8 deletions(-) >> >> diff --git a/monitor.c b/monitor.c >> index 61ea346..d336b8f 100

Re: [Qemu-devel] [PULL 00/12] QOM devices patch queue 2015-05-20

2015-05-29 Thread Peter Maydell
[apologies for getting David G's email address wrong first time round] On 29 May 2015 at 15:08, Daniel P. Berrange wrote: > On Fri, May 29, 2015 at 02:57:12PM +0100, Peter Maydell wrote: >> On 29 May 2015 at 14:51, Daniel P. Berrange wrote: >> > Since that caused failure with glib 2.22 could you

Re: [Qemu-devel] [PATCH] configure: don't apply -O2 if extra-cflags sets -O

2015-05-29 Thread Alex Bennée
Paolo Bonzini writes: > On 29/05/2015 12:56, Alex Bennée wrote: >> If your trying to debug and want to force -O0 then don't allow the >> configure script to try and set -O2. You can use --enable-debug but that >> enables a lot more stuff by default. >> >> Signed-off-by: Alex Bennée >> --- >>

[Qemu-devel] [PATCH V1] cadence_gem: Fix Rx buffer size field mask

2015-05-29 Thread Sai Pavan Boddu
This patch corrects the Rx buffer size field mask to mask bits 23 to 16 Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis --- hw/net/cadence_gem.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index dafe914..494a

Re: [Qemu-devel] [PULL 00/12] QOM devices patch queue 2015-05-20

2015-05-29 Thread Daniel P. Berrange
On Fri, May 29, 2015 at 02:57:12PM +0100, Peter Maydell wrote: > On 29 May 2015 at 14:51, Daniel P. Berrange wrote: > > Since that caused failure with glib 2.22 could you revert that switch > > to g_assert_null/nonnull. > > BTW, David Gilbert is looking at whether we can use the glib support > to

Re: [Qemu-devel] [PATCH v3 11/21] monitor: Propagate errors through invalid_qmp_mode()

2015-05-29 Thread Eric Blake
On 05/29/2015 03:56 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > monitor.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://

[Qemu-devel] [PATCH] docs/writing-qmp-commands: fix a typo

2015-05-29 Thread Chen Hanxiao
s/interation/iteration Signed-off-by: Chen Hanxiao --- docs/writing-qmp-commands.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/writing-qmp-commands.txt b/docs/writing-qmp-commands.txt index f3df206..ab1fdd3 100644 --- a/docs/writing-qmp-commands.txt +++ b/docs/writ

[Qemu-devel] [PATCH v3 3/4] rocker: bring link up/down on PHY enable/disable

2015-05-29 Thread sfeldma
From: Scott Feldman When the OS driver enables/disables the port, go ahead and set the port's link status to up/down in response to the change. This more closely emulates real hardware when the PHY for the port is brought up/down and the PHY negotiates carrier (link status) with link partner. I

Re: [Qemu-devel] [PATCH 0/9] Miscellaneous error reporting improvements

2015-05-29 Thread Eric Blake
On 05/29/2015 05:22 AM, Markus Armbruster wrote: > Kevin Wolf writes: > >> Am 28.05.2015 um 14:21 hat Markus Armbruster geschrieben: >>> Touches vl.c, which gives me pretext to ask Paolo: would you be >>> willing to take this through your tree? Or should I take it through >>> mine? >> >> After t

[Qemu-devel] [PATCH v3 4/4] qmp/hmp: add rocker device support

2015-05-29 Thread sfeldma
From: Scott Feldman v3: Address review comments from Stefan Hajnoczi: - Add missing hw/net/rocker/qmp-norocker.c file. - Add missing curly brackets to a for loop v2: Address review comments from Stefan Hajnoczi: - Add missing qapi/rocker.json file. - Use PRIx64 for print uint64 value -

[Qemu-devel] [PATCH v3 2/4] rocker: update tests using hw-derived interface names

2015-05-29 Thread sfeldma
From: Scott Feldman With previous patch to support phy name attribute for each port, the OS can name port interfaces using the hw-derived name. So update rocker tests to use the new hw-derived interface names. Signed-off-by: Scott Feldman Reviewed-by: Stefan Hajnoczi --- tests/rocker/bridge

[Qemu-devel] [PATCH v3 0/4] rocker device updates

2015-05-29 Thread sfeldma
From: Scott Feldman v3: Address review comments from Stefan Hajnoczi: - Add missing hw/net/rocker/qmp-norocker.c file. - Add missing curly brackets to a for loop v2: Address some review comments by Stefan Hajnoczi: see individual patches for v1->v2 changes. v1: Some rocker device updates

[Qemu-devel] [PATCH v3 1/4] rocker: Add support for phys name

2015-05-29 Thread sfeldma
From: David Ahern v2: Review comment from Stefan Hajnoczi: - use private ROCKER_IFNAMSIZ = 16 to avoid breaking Windows build as Windows does not include v1: Add ROCKER_TLV_CMD_PORT_SETTINGS_PHYS_NAME to port settings. This attribute exports the port name to the guest OS allowing it to n

  1   2   3   >