[apologies for getting David G's email address wrong first time round] On 29 May 2015 at 15:08, Daniel P. Berrange <berra...@redhat.com> wrote: > On Fri, May 29, 2015 at 02:57:12PM +0100, Peter Maydell wrote: >> On 29 May 2015 at 14:51, Daniel P. Berrange <berra...@redhat.com> wrote: >> > Since that caused failure with glib 2.22 could you revert that switch >> > to g_assert_null/nonnull. >> >> BTW, David Gilbert is looking at whether we can use the glib support >> to make use of "newer than version X" APIs a compile error everywhere >> rather than just on boxes with the older glib, which should help >> cut down on this kind of problem in future. > > It seem these g_assert_nonnull/null functions are in fact just trivial > macros, so we could alternatively add them to our glib-compat.h file
Well, we could, but I don't really see the point compared to just using g_assert()... -- PMM
