> On 29 May 2015, at 15:55, aurelio remonda <aurelioremo...@gmail.com> wrote: > > 2015-05-28 18:22 GMT-03:00 Liviu Ionescu <i...@livius.net>: >>> On 29 May 2015, at 00:09, Aurelio C. Remonda <aurelioremo...@gmail.com> >>> wrote: >>> The optional FPU in the M4 could be added in the future as a "Cortex-M4F" >>> CPU. >> >> in my implementation I had a single name ("cortex-m4") and some flags, but a >> separate name is probably better. can we reserve >> >> { .name = "cortex-m4f", ... } >> >> for this purpose? > > Thanks for the feedback! Yes, we could but I think its outside of the > scope of this particular contribution.
ok, I already updated my code to use cortex-m4 or cortex-m4f. > >>> All we'd have to do is add the ARM_FEATURE_VFP4 to the initfn. >> >> if it is that simple, why don't we add it in for now? > > As Peter said, it may not actually be that simple. > > Perhaps we could commit this now and add the VFP in the future? this is fine with me. unfortunately I cannot review your patch, since I have not enough experience with that part of qemu. regards, Liviu