Re: [Qemu-devel] [PATCH v3 5/6] target-microblaze: Convert use-fpu to a CPU property

On Fri, May 29, 2015 at 04:31:58PM +1000, Alistair Francis wrote: > Originally the use-fpu PVR bits were manually set for each machine. This > is a hassle and difficult to read, instead set them based on the CPU > properties. The dt bindings for use-fpu are a bit non-intuivie unfortunately... Anyw

Re: [Qemu-devel] [PATCH 08/10] ui: convert VNC websockets to use crypto APIs

On 2015/5/21 18:56, Daniel P. Berrange wrote: > Remove the direct use of gnutls for hash processing in the > websockets code, in favour of using the crypto APIs. This > allows the websockets code to be built unconditionally > removing countless conditional checks from the VNC code. > > Signed-off-

Re: [Qemu-devel] [PATCH v3 6/6] target-microblaze: Disable stack protection by default

On Fri, May 29, 2015 at 04:32:35PM +1000, Alistair Francis wrote: > Stack protection is not available when the MMU is enabled. > As the MMU is enabled by default, disable stack protection > by default. > > Signed-off-by: Alistair Francis Reviewed-by: Edgar E. Iglesias > --- > > target-micr

[Qemu-devel] [PATCH v3 10/15] target-arm: Add TLBI_VAE2{IS}

From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index bf198e9..a5c0363 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2651,6 +2651,14 @@ stati

[Qemu-devel] [PATCH v3 13/15] target-arm: Pass timeridx as argument to various timer functions

From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 98 + 1 file changed, 76 insertions(+), 22 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 1be3aff..c49605e 100644 --- a/target-arm

[Qemu-devel] [PATCH v3 09/15] target-arm: Add TLBI_ALLE2

From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 4 1 file changed, 4 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 826df50..bf198e9 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2647,6 +2647,10 @@ static co

[Qemu-devel] [PATCH v3 12/15] target-arm: Add CNTHCTL_EL2

From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h| 1 + target-arm/helper.c | 30 -- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 1a66aa4..f39c32b 100644 --- a/target-arm/

[Qemu-devel] [PATCH v3 11/15] target-arm: Add CNTVOFF_EL2

From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h| 1 + target-arm/helper.c | 47 +-- 2 files changed, 42 insertions(+), 6 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 21b5b8e..1a66aa4 100644

[Qemu-devel] [PATCH v3 07/15] target-arm: Add TTBR0_EL2

From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index df07a6a..193750b 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2533,6 +2533,12

[Qemu-devel] [PATCH v3 08/15] target-arm: Add TLBI_ALLE1{IS}

From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 193750b..826df50 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2368,6 +2368,14 @@ stati

[Qemu-devel] [PATCH v3 06/15] target-arm: Add TPIDR_EL2

From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 334e008..df07a6a 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2530,6 +2530,9 @@ static

Re: [Qemu-devel] [PATCH v3 3/6] target-microblaze: Allow the stack protection to be disabled

On Fri, May 29, 2015 at 04:30:43PM +1000, Alistair Francis wrote: > Microblaze stack protection is configurable and isn't always enabled. > This patch allows the stack protection to be disabled from the > CPU properties. > > Signed-off-by: Alistair Francis Reviewed-by: Edgar E. Iglesias > ---

[Qemu-devel] [PATCH v3 05/15] target-arm: Add SCTLR_EL2

From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 7dadc8a..334e008 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2527,6 +2527,9 @@ static

[Qemu-devel] [PATCH v3 04/15] target-arm: Add TCR_EL2

From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 427cfab..7dadc8a 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2524,6 +2524,9 @@ static

Re: [Qemu-devel] [PATCH 07/10] block: convert quorum blockdrv to use crypto APIs

On 2015/5/21 18:56, Daniel P. Berrange wrote: > Get rid of direct use of gnutls APIs in quorum blockdrv in > favour of using the crypto APIs. This avoids the need to > do conditional compilation of the quorum driver. It can > simply report an error at file open file instead if the > required hash a

[Qemu-devel] [PATCH v3 03/15] target-arm: Add MAIR_EL2

From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index a0b414c..427cfab 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2517,6 +2517,13

[Qemu-devel] [PATCH v3 02/15] target-arm: Break down TLB_LOCKDOWN

From: "Edgar E. Iglesias" Break down the overly broad wildcard definition of TLB_LOCKDOWN down to v7 level. Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/target-arm/helper.c b/target

[Qemu-devel] [PATCH v3 01/15] target-arm: Correct check for non-EL3

From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c index 3f5b9ab..7583ae7 100644 --- a/target-arm/op_helper.c +++ b/target-arm/op_helper.c @@ -4

[Qemu-devel] [PATCH v3 00/15] arm: Steps towards EL2 support round 3

From: "Edgar E. Iglesias" Hi, This is round 3 of our series towards support for EL2 for AArch64. This series depends on Peters target-arm.next. While adding the AArch32 versions of some of these regs I ran into issues with the overly broad definition of TLB_LOCKDOWN. I broke it down somewhat to

Re: [Qemu-devel] [PATCH] Use Aff1 with mpidr

Hi! > I see that you added mpidr to ARMCpu and initialized it in virt.c then you > use it in mpidr_read. > Thus you must fix all other virtual machines in hw/arm not just virt.c as it > is not initialized for > them. The only change in virt.c is: --- cut --- diff --git a/hw/arm/virt.c b/hw/ar

Re: [Qemu-devel] [PATCH 06/10] crypto: add a nettle cipher implementation

On 2015/5/22 3:35, Richard Henderson wrote: > On 05/21/2015 03:56 AM, Daniel P. Berrange wrote: >> #ifdef CONFIG_GNUTLS_GCRYPT >> #include "crypto/cipher-gcrypt.c" >> #else >> +#ifdef CONFIG_GNUTLS_NETTLE >> +#include "crypto/cipher-nettle.c" >> +#else >> #include "crypto/cipher-builtin.c" >>

[Qemu-devel] [PATCH v3 4/6] target-microblaze: Tidy up the base-vectors property

Rename the "xlnx.base-vectors" string to "base-vectors" and move the base_vectors variable into the cfg struct. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- target-microblaze/cpu-qom.h |3 ++- target-microblaze/cpu.c |4 ++-- target-microblaze/helper.c |8

[Qemu-devel] [PATCH v3 6/6] target-microblaze: Disable stack protection by default

Stack protection is not available when the MMU is enabled. As the MMU is enabled by default, disable stack protection by default. Signed-off-by: Alistair Francis --- target-microblaze/cpu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-microblaze/cpu.c b/targe

[Qemu-devel] [PATCH v3 5/6] target-microblaze: Convert use-fpu to a CPU property

Originally the use-fpu PVR bits were manually set for each machine. This is a hassle and difficult to read, instead set them based on the CPU properties. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- V3: - Add comments explaing the FPU levels V2: - Remove unnecessary decla

[Qemu-devel] [PATCH v3 3/6] target-microblaze: Allow the stack protection to be disabled

Microblaze stack protection is configurable and isn't always enabled. This patch allows the stack protection to be disabled from the CPU properties. Signed-off-by: Alistair Francis --- V3: - Enable stack protection by default V2: - Change the variable name to stackprot - Include protection for

[Qemu-devel] [PATCH v3 2/6] target-microblaze: Preserve the pvr registers during reset

Move the Microblaze PVR registers to the end of the CPUMBState and preserve them during reset. This is similar to what the QEMU ARM model does with some of it's registers. This allows the Microblaze PVR registers to only be set once at realise instead of constantly at reset. Signed-off-by: Alista

[Qemu-devel] [PATCH v3 1/6] target-microblaze: Fix up indentation

Fix up the incorrect indentation level in the helper_stackprot() function. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite Reviewed-by: Edgar E. Iglesias --- target-microblaze/op_helper.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target-m

[Qemu-devel] [PATCH v3 0/6] Add Microblaze configuration options

Firstly this patch series tidies up some code and removes a "xlnx." prefix. Then it moves the Microblaze PVR registers to the end of the CPUMBState to preserve them during reset. This allows most of the operations on them to be moved from the reset to the realise. Except for the machine specific o

Re: [Qemu-devel] [PATCH] floppy: fix I/O ranges in both portio and acpi dsdt

On Do, 2015-05-28 at 18:36 +0200, Kevin Wolf wrote: > Am 28.05.2015 um 17:37 hat Gerd Hoffmann geschrieben: > > Signed-off-by: Gerd Hoffmann > > --- > > hw/block/fdc.c| 2 +- > > hw/i386/acpi-dsdt-isa.dsl | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > The commit mes

[Qemu-devel] [PATCH V8 6/9] virtio-s390: introduce virito s390 queue limit

Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Jason Wang --- hw/s390x/s390-virtio-bus.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c index 0e35ac9..3801c73 100644 --- a/hw/s390x/s390-virtio-bus.c +++

Re: [Qemu-devel] [PATCH 4/4] hw/display/tcx.c: Fix memory leak spotted by valgrind

28.05.2015 15:19, Mark Cave-Ayland wrote: [] > The FCode ROMs supplied for CG3/TCX are used to both initialise various > DT entries for the graphic adapters and also provide a minimal driver to > allow OpenBIOS (or Sun PROM) to initialise and use the adapter at boot. > > I'd say at the moment the

[Qemu-devel] [PATCH V8 3/9] virtio: introduce virtio_get_num_queues()

This patch introduces virtio_get_num_queues() which iterates the vqs array and return the number of virtqueues used by device. Signed-off-by: Jason Wang --- hw/virtio/virtio.c | 13 + include/hw/virtio/virtio.h | 1 + 2 files changed, 14 insertions(+) diff --git a/hw/virtio

[Qemu-devel] [PATCH V8 2/9] virtio: device_plugged() can fail

This patch passes error pointer to transport specific device_plugged() callback. Through this way, device_plugged() can do some transport specific check and fail. This will be uesd by following patches that check the number of virtqueues against the transport limitation. Cc: Cornelia Huck Cc: Chr

[Qemu-devel] [PATCH V8 8/9] virtio: rename VIRTIO_PCI_QUEUE_MAX to VIRTIO_QUEUE_MAX

VIRTIO_PCI_QUEUE_MAX is not only used for pci, so rename it be generic. Cc: Amit Shah Cc: Paolo Bonzini Signed-off-by: Jason Wang --- hw/char/virtio-serial-bus.c | 2 +- hw/net/virtio-net.c | 4 ++-- hw/scsi/virtio-scsi.c | 4 ++-- hw/virtio/virtio-mmio.c | 4 ++-- hw/vir

[Qemu-devel] [PATCH V8 9/9] virtio: increase the queue limit to 1024

Increase the queue limit to 1024. But virtio-ccw and s390-virtio won't support this, this is done through failing device_plugged() for those two transports if the number of virtqueues is greater than 64. Signed-off-by: Jason Wang --- include/hw/virtio/virtio.h | 2 +- 1 file changed, 1 insertion

[Qemu-devel] [PATCH V8 4/9] virtio-ccw: introduce ccw specific queue limit

Cc: Alexander Graf Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Richard Henderson Signed-off-by: Jason Wang --- hw/s390x/s390-virtio-ccw.c | 2 +- hw/s390x/virtio-ccw.c| 12 ++-- include/hw/s390x/s390_flic.h | 5 - 3 files changed, 11 insertions(+), 8 deletions(-)

[Qemu-devel] [PATCH V8 5/9] virtio-ccw: validate the number of queues against bus limitation

Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Richard Henderson Cc: Alexander Graf Signed-off-by: Jason Wang --- hw/s390x/virtio-ccw.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index aaa9833..18fc697 100644 --- a/hw/s390x/virt

[Qemu-devel] [PATCH V8 1/9] virtio-net: adding all queues in .realize()

Instead of adding queues for multiqueue during feature set. This patch did this in .realize(), this will help the following patches that count the number of virtqueues used in .device_plugged() callback. Signed-off-by: Jason Wang --- hw/net/virtio-net.c | 59 +++--

[Qemu-devel] [PATCH V8 0/9] Support more virtio queues

We current limit the max virtio queues to 64. This is not sufficient to support multiqueue devices (e.g recent Linux support up to 256 tap queues). So this series tries to let virtio to support more queues. No much works need to be done except: - Increase the limit from 64 to 1024 - Let device_pl

[Qemu-devel] [PATCH V8 7/9] virtio-s390: introduce virtio_s390_device_plugged()

This patch introduce a virtio-s390 specific device_plugged() function and doing the number of virtqueue validation inside. Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Jason Wang --- hw/s390x/s390-virtio-bus.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/s3

[Qemu-devel] [PATCH] vhost: correctly pass error to caller in vhost_dev_enable_notifiers()

We override the error value r in fail_vq, this will cause the caller can't detect the failure which may cause the caller may disable the notifiers twice if vhost is failed to start. Fix this by using another variable to keep track the return value of set_host_notifier(). Fixes b0b3db79559e57db340b

Re: [Qemu-devel] [PATCH v2 3/5] target-microblaze: Allow the stack protection to be disabled/enabled

On Fri, May 29, 2015 at 3:42 PM, Edgar E. Iglesias wrote: > On Fri, May 29, 2015 at 03:39:32PM +1000, Alistair Francis wrote: >> On Fri, May 29, 2015 at 3:35 PM, Alistair Francis >> wrote: >> > On Thu, May 28, 2015 at 4:17 PM, Edgar E. Iglesias >> > wrote: >> >> On Thu, May 28, 2015 at 03:37:42P

Re: [Qemu-devel] [PATCH v2 5/5] target-microblaze: Convert use-fpu to a CPU property

On Thu, May 28, 2015 at 4:25 PM, Edgar E. Iglesias wrote: > On Thu, May 28, 2015 at 03:38:59PM +1000, Alistair Francis wrote: >> Originally the use-fpu PVR bits were manually set for each machine. This >> is a hassle and difficult to read, instead set them based on the CPU >> properties. >> >> Sig

Re: [Qemu-devel] [PATCH v2 3/5] target-microblaze: Allow the stack protection to be disabled/enabled

On Fri, May 29, 2015 at 03:39:32PM +1000, Alistair Francis wrote: > On Fri, May 29, 2015 at 3:35 PM, Alistair Francis > wrote: > > On Thu, May 28, 2015 at 4:17 PM, Edgar E. Iglesias > > wrote: > >> On Thu, May 28, 2015 at 03:37:42PM +1000, Alistair Francis wrote: > >>> Microblaze stack protection

Re: [Qemu-devel] [PATCH v2 3/5] target-microblaze: Allow the stack protection to be disabled/enabled

On Fri, May 29, 2015 at 3:35 PM, Alistair Francis wrote: > On Thu, May 28, 2015 at 4:17 PM, Edgar E. Iglesias > wrote: >> On Thu, May 28, 2015 at 03:37:42PM +1000, Alistair Francis wrote: >>> Microblaze stack protection is configurable and isn't always enabled. >>> This patch allows the stack pro

[Qemu-devel] [PATCH v2] hw/arm/omap_sx1.c: Fix memory leak spotted by valgrind

From: Shannon Zhao valgrind complains about: ==19440== 248 bytes in 1 blocks are definitely lost in loss record 2,340 of 2,934 ==19440==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==19440==by 0x354793: malloc_and_trace (vl.c:2556) ==19440==by 0x64

Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals

On Tue, May 26, 2015 at 1:05 AM, Paolo Bonzini wrote: > > > On 26/05/2015 08:00, Peter Crosthwaite wrote: >> Eduardo flagged a conflict with on-list work. Do you want me to handle it? > > I don't know, but I'll dequeue these patches. > Alright, So I'll wait for the enqueue of Bharata's patches a

[Qemu-devel] [PATCH v2 13/13] hw/display/tc6393xb.c: Fix misusing qemu_allocate_irqs for single irq

From: Shannon Zhao valgrind complains about: ==3169== 8 bytes in 1 blocks are definitely lost in loss record 424 of 2,779 ==3169==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==3169==by 0x3547D3: malloc_and_trace (vl.c:2556) ==3169==by 0x64C770E: g_

Re: [Qemu-devel] [PATCH v2 3/5] target-microblaze: Allow the stack protection to be disabled/enabled

On Thu, May 28, 2015 at 4:17 PM, Edgar E. Iglesias wrote: > On Thu, May 28, 2015 at 03:37:42PM +1000, Alistair Francis wrote: >> Microblaze stack protection is configurable and isn't always enabled. >> This patch allows the stack protection to be disabled/enabled from the >> CPU properties. >> >>

[Qemu-devel] [PATCH v2 12/13] hw/arm/nseries.c: Fix misusing qemu_allocate_irqs for single irq

From: Shannon Zhao valgrind complains about: ==4835== 8 bytes in 1 blocks are definitely lost in loss record 509 of 3,278 ==4835==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==4835==by 0x354793: malloc_and_trace (vl.c:2556) ==4835==by 0x64C770E: g_

[Qemu-devel] [PATCH v2 06/13] hw/sparc/sun4m.c: Fix misusing qemu_allocate_irqs for single irq

From: Shannon Zhao valgrind complains about: ==23693== 8 bytes in 1 blocks are definitely lost in loss record 424 of 2,014 ==23693==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==23693==by 0x21B93F: malloc_and_trace (vl.c:2556) ==23693==by 0x64C770E

[Qemu-devel] [PATCH v2 07/13] hw/ppc/prep.c: Fix misusing qemu_allocate_irqs for single irq

From: Shannon Zhao valgrind complains about: ==22156== 8 bytes in 1 blocks are definitely lost in loss record 469 of 3,966 ==22156==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==22156==by 0x337033: malloc_and_trace (vl.c:2556) ==22156==by 0x64C770E

[Qemu-devel] [PATCH v2 04/13] hw/timer/arm_timer.c: Fix misusing qemu_allocate_irqs for single irq

From: Shannon Zhao valgrind complains about: ==16356== 32 bytes in 2 blocks are definitely lost in loss record 1,689 of 2,802 ==16356==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==16356==by 0x35478F: malloc_and_trace (vl.c:2556) ==16356==by 0x64C7

[Qemu-devel] [PATCH v2 09/13] hw/lm32/milkymist.c: Fix misusing qemu_allocate_irqs for single irq

From: Shannon Zhao valgrind complains about: ==20652== 8 bytes in 1 blocks are definitely lost in loss record 252 of 1,314 ==20652==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==20652==by 0x1E77E7: malloc_and_trace (vl.c:2556) ==20652==by 0x64C770E

[Qemu-devel] [PATCH v2 10/13] hw/unicore32/puv3.c: Fix misusing qemu_allocate_irqs for single irq

From: Shannon Zhao valgrind complains about: ==26001== 8 bytes in 1 blocks are definitely lost in loss record 234 of 1,038 ==26001==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==26001==by 0x1E1483: malloc_and_trace (vl.c:2556) ==26001==by 0x64C770E

[Qemu-devel] [PATCH v2 05/13] hw/intc/exynos4210_gic.c: Fix memory leak by adjusting order

From: Shannon Zhao valgrind complains about: ==17211== 784 (288 direct, 496 indirect) bytes in 4 blocks are definitely lost in loss record 3,018 of 3,201 ==17211==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==17211==by 0x35478F: malloc_and_trace (vl.c

[Qemu-devel] [PATCH v2 01/13] hw/i386/pc: Fix misusing qemu_allocate_irqs for single irq

From: Shannon Zhao valgrind complains about: ==20308== 8 bytes in 1 blocks are definitely lost in loss record 622 of 3,474 ==20308==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==20308==by 0x2EB687: malloc_and_trace (vl.c:2556) ==20308==by 0x64C770E

[Qemu-devel] [PATCH v2 03/13] hw/isa/i82378.c: Fix misusing qemu_allocate_irqs for single irq

From: Shannon Zhao valgrind complains about: ==32654== 8 bytes in 1 blocks are definitely lost in loss record 476 of 4,036 ==32654==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==32654==by 0x336F47: malloc_and_trace (vl.c:2556) ==32654==by 0x64C770E

[Qemu-devel] [PATCH v2 08/13] hw/lm32/lm32_boards.c: Fix misusing qemu_allocate_irqs for single irq

From: Shannon Zhao valgrind complains about: ==8662== 8 bytes in 1 blocks are definitely lost in loss record 228 of 1,108 ==8662==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==8662==by 0x1E77EB: malloc_and_trace (vl.c:2556) ==8662==by 0x64C770E: g_

[Qemu-devel] [PATCH v2 11/13] hw/alpha/typhoon.c: Fix misusing qemu_allocate_irqs for single irq

From: Shannon Zhao valgrind complains about: ==7055== 8 bytes in 1 blocks are definitely lost in loss record 403 of 2,192 ==7055==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==7055==by 0x24410F: malloc_and_trace (vl.c:2556) ==7055==by 0x64C770E: g_

[Qemu-devel] [PATCH v2 02/13] hw/isa/lpc_ich9.c: Fix misusing qemu_allocate_irqs for single irq

From: Shannon Zhao valgrind complains about: ==25058== 8 bytes in 1 blocks are definitely lost in loss record 623 of 3,473 ==25058==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==25058==by 0x2EB657: malloc_and_trace (vl.c:2556) ==25058==by 0x64C770E

[Qemu-devel] [PATCH v2 00/13] use qemu_allocate_irq not _irqs for single irq

From: Shannon Zhao These are relevant to misusing qemu_allocate_irqs for requesting single irq and they cause memory leak. So these patches use qemu_allocate_irq for single irq to fix these memory leaks. PS: These patches are split from my previous patchset [1] since they are relevant to misusin

Re: [Qemu-devel] [PATCH v3 7/7] disas: cris: QOMify target specific disas setup

On Sun, May 24, 2015 at 03:47:20PM -0700, Peter Crosthwaite wrote: > Move the target_disas() cris specifics to the QOM disas_set_info hook > and delete the cris specific code in disas.c. > > This also now adds support for monitor disas to cris. > > E.g. > (qemu) xp 0x40004000 > 40004000:

Re: [Qemu-devel] [PATCH v3 6/7] disas: cris: Fix 0 buffer length case

On Sun, May 24, 2015 at 03:47:19PM -0700, Peter Crosthwaite wrote: > Cris has the complication of variable length instructions and has > a check in place to clamp memory reads in case the disas request > doesn't have enough bytes for the instruction being disas'd. This > breaks down in the case whe

Re: [Qemu-devel] [PATCH v3 3/3] ppc: Move cpu_exec_init() call to realize function

On Wed, May 20, 2015 at 10:02 PM, Bharata B Rao wrote: > Move cpu_exec_init() call from instance_init to realize. This allows > any failures from cpu_exec_init() to be handled appropriately. > Also add corresponding cpu_exec_exit() call from unrealize. > > Signed-off-by: Bharata B Rao > Reviewed-

Re: [Qemu-devel] [PATCH v3 2/3] cpus: Convert cpu_index into a bitmap

On Wed, May 20, 2015 at 10:02 PM, Bharata B Rao wrote: > Currently CPUState.cpu_index is monotonically increasing and a newly > created CPU always gets the next higher index. The next available > index is calculated by counting the existing number of CPUs. This is > fine as long as we only add CPU

Re: [Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic

Hi, * Dimitris Aragiorgis [2015-05-20 12:57:34 +0300]: > Hi all, > > These four patches make slight changes to the way QEMU handles SCSI > generic devices to fix a number of small problems. > > I am sending them against the master branch, since I don't know if they > can be considered bugfixes

Re: [Qemu-devel] [PATCH v3 1/3] cpus: Add Error argument to cpu_exec_init()

On Wed, May 20, 2015 at 10:02 PM, Bharata B Rao wrote: > Add an Error argument to cpu_exec_init() to let users collect the > error. This is in preparation to change the CPU enumeration logic > in cpu_exec_init(). With the new enumeration logic, cpu_exec_init() > can fail if cpu_index values corres

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

> > > > Ping. > > > > Can I get any suggestions on this patch. > > > > Best regards, > > Pankaj > > > > > > > > > vhostforce was added to enable vhost when > > > guest don't have MSI-X support. > > > Now, we have scenarios like DPDK in Guest which dont use > > > interrupts and still use

Re: [Qemu-devel] [PATCH v3 0/3] Bitmap based CPU enumeration

On Thu, May 28, 2015 at 7:27 PM, Bharata B Rao wrote: > All the comments have been addressed and the series has been reviewed > by David, Eduardo and Igor. Can this series be taken in now ? > Andreas' comment on P3 looks unaddressed. I think it can be handled by just putting that one sentance exp

Re: [Qemu-devel] [PATCH v3 5/7] disas: microblaze: QOMify target specific disas setup

Looks good: Reviewed-by: Edgar E. Iglesias On Sun, May 24, 2015 at 03:47:18PM -0700, Peter Crosthwaite wrote: > Move the target_disas() MB specifics to the QOM disas_set_info hook > and delete the MB specific code in disas.c. > > This also now adds support for monitor disas to Microblaze. > >

Re: [Qemu-devel] [PATCHv2 4/4] spapr: Add sPAPRMachineClass

On Tue, May 26, 2015 at 10:19:24AM +0200, Thomas Huth wrote: > On Tue, 26 May 2015 12:22:59 +1000 > David Gibson wrote: > > > Currently although we have an sPAPRMachineState descended from MachineState > > we don't have an sPAPRMAchineClass descended from MachineClass. So far it > > hasn't been

Re: [Qemu-devel] [PATCHv2 2/4] spapr: Remove obsolete ram_limit field from sPAPRMachineState

On Tue, May 26, 2015 at 10:00:31AM +0200, Thomas Huth wrote: > On Tue, 26 May 2015 12:22:57 +1000 > David Gibson wrote: > > > The ram_limit field was imported from sPAPREnvironment where it predates > > the machine's ram size being available generically from machine->ram_size. > > > > Worse, the

Re: [Qemu-devel] [PATCH v3 5/7] disas: microblaze: QOMify target specific disas setup

Ping! On Sun, May 24, 2015 at 3:47 PM, Peter Crosthwaite wrote: > Move the target_disas() MB specifics to the QOM disas_set_info hook > and delete the MB specific code in disas.c. > > This also now adds support for monitor disas to Microblaze. > > E.g. > (qemu) xp 0x9000 > 9000: 0

[Qemu-devel] [PATCH v1 4/4] vhost-user: Add new option to specify vhost-user backend features

This patch adds below '-net' options to let QEMU know which features vhost-user backend will support. [,backend_csum=on|off] [,backend_guest_csum=on|off] [,backend_gso=on|off] [,backend_guest_tso4=on|off] [,backend_guest_tso6=on|off] [,backend_guest_ecn=on|off] [,backend_guest_ufo=on|off]

[Qemu-devel] [PATCH v1 3/4] vhost-user: Enable 'nowait' and 'reconnect' option

The patch enables 'nowait' option for server mode, and 'reconnect' option for client mode. Signed-off-by: Tetsuya Mukawa --- net/vhost-user.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/vhost-user.c b/net/vhost-user.c index 1967ff4..f823d78 100644 --- a/net/vhost-user.c +++ b/n

[Qemu-devel] [PATCH v1 1/4] vhost-user: Add ability to know vhost-user backend disconnection

Current QEMU cannot detect vhost-user backend disconnection. The patch adds ability to know it. To know disconnection, add watcher to detect G_IO_HUP event. When G_IO_HUP event is detected, the disconnected socket will be read to cause a CHR_EVENT_CLOSED. Signed-off-by: Tetsuya Mukawa --- net/vh

[Qemu-devel] [PATCH v1 0/4] Add feature to start QEMU without vhost-user backend

Hi guys, Here are patches to add feature to start QEMU without vhost-user backend. Currently, if we want to use vhost-user backend, the backend must start before QEMU. Also, if QEMU or the backend is closed unexpectedly, there is no way to recover without restarting both applications. Practically,

[Qemu-devel] [PATCH v1 2/4] vhost-user: Shutdown vhost-user connection when wrong messages are passed

When wrong vhost-user message are passed, the connection should be shutdown. Signed-off-by: Tetsuya Mukawa --- hw/virtio/vhost-user.c | 17 ++--- include/sysemu/char.h | 7 +++ qemu-char.c| 15 +++ 3 files changed, 32 insertions(+), 7 deletions(-) diff

Re: [Qemu-devel] [RFC PATCH 4/4] vhost-user: Add new option to specify vhost-user backend supports

On 2015/05/28 10:25, Tetsuya Mukawa wrote: > On 2015/05/26 21:52, Eric Blake wrote: >> On 05/25/2015 10:29 PM, Tetsuya Mukawa wrote: >> >> { 'struct': 'NetdevTapOptions', >> @@ -2259,7 +2261,8 @@ >> '*vhostfd':'str', >> '*vhostfds': 'str', >> '*vhostforce':

Re: [Qemu-devel] [PATCH 05/10] crypto: add a gcrypt cipher implementation

On 2015/5/21 18:56, Daniel P. Berrange wrote: > If we are linking to gnutls already and gnutls is built against > gcrypt, then we should use gcrypt as a cipher backend in > preference to our built-in backend. > > This will be used when linking against GNUTLS 1.x and many > GNUTLS 2.x versions. >

[Qemu-devel] [PATCH v10 7/7] qemu-iotests: s390x: fix test 130

The default device id of hard disk on the s390 platform is "virtio0" which differs to the "ide0-hd0" for the x86 platform. Setting id in the drive definition, ie:"qemu -drive id=testdisk", will be the same on all platforms. Reviewed-by: Max Reitz Signed-off-by: Bo Tu --- tests/qemu-iotests/130

[Qemu-devel] [PATCH v10 0/7] Update tests/qemu-iotests failing cases for the s390 platform

v10. 1. Add Reviewed-by statements for test 049 2. Removed the backslash in qemu-option.c 3. Please apply the series if there are no further objections v9. 1.Fix issue of line over 80 characters for test 049 2.Add Reviewed-by statements for test 051,130 v8. 1.Modify error message in qemu-option.c

[Qemu-devel] [PATCH v10 4/7] qemu-iotests: s390x: fix test 055

From: Xiao Guang Chen There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Reviewed-by: Max Reitz Reviewed-by: Michael Mueller Signed-off-by: Xiao Guang Chen --- tests/qemu-iotests/055 | 9 + 1 file changed, 9 insertions(+) diff --

[Qemu-devel] [PATCH v10 3/7] qemu-iotests: s390x: fix test 041

From: Xiao Guang Chen There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Reviewed-by: Max Reitz Reviewed-by: Michael Mueller Signed-off-by: Xiao Guang Chen --- tests/qemu-iotests/041 | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Qemu-devel] [PATCH v10 6/7] qemu-iotests: s390x: fix test 051

The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "virtio0" set for the s390 platform. A x86 platform specific output file is also needed.

[Qemu-devel] [PATCH v10 2/7] qemu-iotests: run qemu with -nodefaults and fix 067, 071, 081 and 087

From: Xiao Guang Chen This patch fixes an io test suite issue that was introduced with the commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only a single "stdio" character device'. The option supresses the creation of default devices such as the floopy and cdrom. Output files fo

[Qemu-devel] [PATCH v10 5/7] qemu-iotests: s390x: fix test 049

when creating an image qemu-img enable us specifying the size of the image using -o size=xx options. But when we specify an invalid size such as a negtive size then different platform gives different result. parse_option_size() function in util/qemu-option.c will be called to parse the size, a cas

[Qemu-devel] [PATCH v10 1/7] qemu-iotests: qemu machine type support

From: Xiao Guang Chen This patch adds qemu machine type support to the io test suite. Based on the qemu default machine type and alias of the default machine type the reference output file can now vary from the default to a machine specific output file if necessary. When using a machine specific

Re: [Qemu-devel] [PATCH 04/10] crypto: introduce generic cipher API & built-in implementation

On 2015/5/22 17:10, Daniel P. Berrange wrote: > On Thu, May 21, 2015 at 12:52:43PM -0700, Richard Henderson wrote: >> On 05/21/2015 03:56 AM, Daniel P. Berrange wrote: >>> +QCryptoCipher *qcrypto_cipher_new(QCryptoCipherAlgorithm alg, >>> + QCryptoCipherMode mode, >

Re: [Qemu-devel] [PATCH v3 0/3] Bitmap based CPU enumeration

All the comments have been addressed and the series has been reviewed by David, Eduardo and Igor. Can this series be taken in now ? Regards, Bharata. On Thu, May 21, 2015 at 10:32:05AM +0530, Bharata B Rao wrote: > This patch changes the way cpu_index is handed out to newly created > CPUs by trac

Re: [Qemu-devel] [PATCH 00/29] Fix memory leak relevant to calling qemu_allocate_irqs

On 2015/5/28 20:34, Michael Tokarev wrote: > 28.05.2015 15:08, Shannon Zhao wrote: >> From: Shannon Zhao >> >> Before I sent some patches to fix memory leak spotted by valgrind and >> those are relevant to qemu_allocate_irqs. Then I find all the places >> calling this function through code searc

[Qemu-devel] [PATCH] mirror: Skip block_job_defer_to_main_loop if already in the main context

mirror_exit does the replacing, which requires source and target to be in sync, unfortunately we can't guarantee that before we have a complete block pause mechanism. So for non-dataplane block jobs, let's do the old thing as pre commit 5a7e7a0ba (block: let mirror blockjob run in BDS AioContext) -

Re: [Qemu-devel] [PATCH 21/29] hw/sh4/r2d.c: Fix memory leak spotted by valgrind

On 2015/5/28 20:46, Peter Maydell wrote: > On 28 May 2015 at 13:08, Shannon Zhao wrote: >> > From: Shannon Zhao >> > >> > valgrind complains about: >> > ==29844== 1,364 (104 direct, 1,260 indirect) bytes in 1 blocks are >> > definitely lost in loss record 2,143 of 2,205 >> > ==29844==at 0x

Re: [Qemu-devel] [PATCH] blockdev: no need to drain+flush in hmp_drive_del

- Original Message - > bdrv_close already does that, and in fact hmp_drive_del would need > another drain after the flush (which bdrv_close does). So remove > the duplication. > > Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng > --- > blockdev.c | 3 --- > 1 file changed, 3 de

Re: [Qemu-devel] [PATCH] blockdev: no need to drain in qmp_block_commit

- Original Message - > Draining is not necessary, I/O can happen as soon as the > commit coroutine yields. Draining can be necessary before > reopening the file for read/write, or while modifying the > backing file chain, but that is done separately in > bdrv_reopen_multiple or bdrv_clos

Re: [Qemu-devel] [PATCH COLO-Frame v5 00/29] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

On 05/29/2015 12:24 AM, Dr. David Alan Gilbert wrote: > * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: >> This is the 5th version of COLO, here is only COLO frame part, include: VM >> checkpoint, >> failover, proxy API, block replication API, not include block replication. >> The block pa

Re: [Qemu-devel] [PATCH v2 0/4] tighten conditions for board-implied FDC in pc-q35-2.4+

On 05/29/15 01:53, Gabriel L. Somlo wrote: > On Thu, May 28, 2015 at 11:50:28PM +0200, Laszlo Ersek wrote: >>> ... >>> >>> I have no idea how big of a deal this is (i.e. how "wrong" it is for >>> this stuff to still be showing up when no FDC is provisioned on the >>> guest). >> >> The _STA

Re: [Qemu-devel] [PATCH v2 0/4] tighten conditions for board-implied FDC in pc-q35-2.4+

On Thu, May 28, 2015 at 11:50:28PM +0200, Laszlo Ersek wrote: > > ... > > > > I have no idea how big of a deal this is (i.e. how "wrong" it is for > > this stuff to still be showing up when no FDC is provisioned on the > > guest). > > The _STA method will return 0 if the FDEN field is zer

Re: [Qemu-devel] [PATCH v3 2/2] qga: win32 implementation of qmp_guest_network_get_interfaces

On 05/28/2015 12:41 PM, Kirk Allan wrote: > By default, IP addresses and prefixes will be derived from information > obtained by various calls and structures. IPv4 prefixes can be found > by matching the address to those returned by GetAdaptersInfo. IPv6 > prefixes can not be matched this way due

  1   2   3   4   >