----- Original Message ----- > bdrv_close already does that, and in fact hmp_drive_del would need > another drain after the flush (which bdrv_close does). So remove > the duplication. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Fam Zheng <f...@redhat.com> > --- > blockdev.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/blockdev.c b/blockdev.c > index 5eaf77e..d506a70 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -2143,9 +2143,6 @@ int hmp_drive_del(Monitor *mon, const QDict *qdict, > QObject **ret_data) > return -1; > } > > - /* quiesce block driver; prevent further io */ > - bdrv_drain_all(); > - bdrv_flush(bs); > bdrv_close(bs); > > /* if we have a device attached to this BlockDriverState > -- > 2.4.1 > > >
