[Qemu-devel] [PATCH V7 14/16] virtio-pci: speedup MSI-X masking and unmasking

2015-04-22 Thread Jason Wang
This patch tries to speed up the MSI-X masking and unmasking through the mapping between vector and queues. With this patch it will there's no need to go through all possible virtqueues, which may help to reduce the time spent when doing MSI-X masking/unmasking a single vector when more than hundre

[Qemu-devel] [PATCH V7 15/16] virtio-pci: increase the maximum number of virtqueues to 513

2015-04-22 Thread Jason Wang
This patch increases the maximum number of virtqueues for pci from 64 to 513. This will allow booting a virtio-net-pci device with 256 queue pairs on recent Linux host (which supports up to 256 tuntap queue pairs). To keep migration compatibility, 64 was kept for legacy machine types. This is beca

[Qemu-devel] [PATCH V7 13/16] virtio: introduce vector to virtqueues mapping

2015-04-22 Thread Jason Wang
Currently we will try to traverse all virtqueues to find a subset that using a specific vector. This is sub optimal when we will support hundreds or even thousands of virtqueues. So this patch introduces a method which could be used by transport to get all virtqueues that using a same vector. This

[Qemu-devel] [PATCH V7 12/16] virtio-pci: switch to use bus specific queue limit

2015-04-22 Thread Jason Wang
Instead of depending on a macro, switch to use a bus specific queue limit. Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 12 +++- include/hw/virtio/virtio.h | 2 -- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/virtio/virtio-pci.c

[Qemu-devel] [PATCH V7 09/16] virtio-ccw: introduce ccw specific queue limit

2015-04-22 Thread Jason Wang
Instead of depending on marco, using a bus specific limit. Also make it clear that the number of gsis per I/O adapter is not directly depending on the number of virtio queues, but rather the other way around. Cc: Alexander Graf Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Richard Henderson

[Qemu-devel] [PATCH V7 10/16] virtio-s390: switch to bus specific queue limit

2015-04-22 Thread Jason Wang
Instead of depending on macro, switch to use a bus specific queue limit. Cc: Alexander Graf Cc: Richard Henderson Cc: Christian Borntraeger Cc: Cornelia Huck Signed-off-by: Jason Wang Reviewed-by: Cornelia Huck --- hw/s390x/s390-virtio-bus.c | 8 +--- 1 file changed, 5 insertions(+), 3

[Qemu-devel] [PATCH V7 11/16] virtio-mmio: switch to bus specific queue limit

2015-04-22 Thread Jason Wang
Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio-mmio.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index 2ae6942..dbd44b6 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio-mmio.c @@

[Qemu-devel] [PATCH V7 06/16] monitor: check return value of qemu_find_net_clients_except()

2015-04-22 Thread Jason Wang
qemu_find_net_clients_except() may return a value which is greater than the size of array we provided. So we should check this value before using it, otherwise this may cause unexpected memory access. This patch fixes the net related command completion when we have a virtio-net nic with more than

[Qemu-devel] [PATCH V7 07/16] virtio-ccw: using VIRTIO_NO_VECTOR instead of 0 for invalid virtqueue

2015-04-22 Thread Jason Wang
It's a bad idea to need to use vector 0 for invalid virtqueue. So this patch changes to using VIRTIO_NO_VECTOR instead. Cc: Michael S. Tsirkin Cc: Cornelia Huck CC: Christian Borntraeger Cc: Richard Henderson Cc: Alexander Graf Signed-off-by: Jason Wang Acked-by: Cornelia Huck --- hw/s390x

[Qemu-devel] [PATCH V7 16/16] pci: remove hard-coded bar size in msix_init_exclusive_bar()

2015-04-22 Thread Jason Wang
This patch lets msix_init_exclusive_bar() can calculate the bar and pba size based on the number of MSI-X vectors other than using a hard-coded limit 4096. This is needed to allow device to have more than 128 MSI_X vectors. To keep migration compatibility, keep using 4096 as bar size and 2048 for p

[Qemu-devel] [PATCH V7 08/16] virtio: introduce bus specific queue limit

2015-04-22 Thread Jason Wang
This patch introduces a bus specific queue limitation. It will be useful for increasing the limit for one of the bus without disturbing other buses. Cc: Michael S. Tsirkin Cc: Alexander Graf Cc: Richard Henderson Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Paolo Bonzini Signed-off-by: Ja

[Qemu-devel] [PATCH V7 05/16] monitor: replace the magic number 255 with MAX_QUEUE_NUM

2015-04-22 Thread Jason Wang
This patch replace the magic number 255, and increase it to MAX_QUEUE_NUM which is maximum number of queues supported by a nic. Cc: Luiz Capitulino Signed-off-by: Jason Wang --- monitor.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/monitor.c b/monitor.

[Qemu-devel] [PATCH V7 02/16] pc: add 2.4 machine types

2015-04-22 Thread Jason Wang
The following patches will limit the following things to legacy machine type: - maximum number of virtqueues for virtio-pci were limited to 64 - auto msix bar size for virtio-net-pci were disabled by default Cc: Paolo Bonzini Cc: Richard Henderson Cc: Michael S. Tsirkin Signed-off-by: Jason Wa

[Qemu-devel] [PATCH V7 03/16] spapr: add machine type specific instance init function

2015-04-22 Thread Jason Wang
This patches adds machine type specific instance initialization functions. Those functions will be used by following patches to compat class properties for legacy machine types. Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Jason Wang --- hw/ppc/spapr.c | 23 +++

[Qemu-devel] [PATCH V7 00/16] Support more virtio queues

2015-04-22 Thread Jason Wang
We current limit the max virtio queues to 64. This is not sufficient to support multiqueue devices (e.g recent Linux support up to 256 tap queues). So this series tries to let virtio to support more queues. No much works need to be done except: - Introducing transport specific queue limitation. T

[Qemu-devel] [PATCH V7 01/16] virtio-net: fix the upper bound when trying to delete queues

2015-04-22 Thread Jason Wang
Virtqueue were indexed from zero, so don't delete virtqueue whose index is n->max_queues * 2 + 1. Cc: Michael S. Tsirkin Cc: qemu-stable Signed-off-by: Jason Wang --- hw/net/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net

[Qemu-devel] [PATCH V7 04/16] ppc: spapr: add 2.4 machine type

2015-04-22 Thread Jason Wang
The following patches will limit the following things to legacy machine type: - maximum number of virtqueues for virtio-pci were limited to 64 Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Jason Wang --- hw/ppc/spapr.c | 31 +-- 1 file changed, 29 inser

Re: [Qemu-devel] [PATCH] vhost-user: Add ability to know vhost-user backend disconnection

2015-04-22 Thread Tetsuya Mukawa
On 2015/04/22 5:19, Nikolay Nikolaev wrote: > On Tue, Apr 21, 2015 at 9:36 AM, Tetsuya Mukawa wrote: >> Current QEMU cannot detect vhost-user backend disconnection. The >> patch adds ability to know it. >> To know disconnection, add watcher to detect G_IO_HUP event. When >> G_IO_HUP event is detec

Re: [Qemu-devel] [RFC PATCH 0/2] spapr: move pci device creation to Qemu

2015-04-22 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > The patch series creates PCI DT nodes in QEMU. The new > hotplug code needs the device node creation in Qemu. While during > boot, nodes were created in SLOF. It makes more sense to consolidate > the code to one place for better maintainability. Based on sPAPR PCI Ho

Re: [Qemu-devel] [PATCH v2 0/9] target-arm: EL3 trap support

2015-04-22 Thread Edgar E. Iglesias
On Wed, Apr 22, 2015 at 12:09:12PM -0500, Greg Bellows wrote: > Initial patchset adding support for trapping to an EL other than EL1. Support > includes changes to interfaces to allow specification of the target EL. Also > includes the addition of the ARMv8 CPTR system registers used for controll

Re: [Qemu-devel] [PATCH v2 9/9] target-arm: Add WFx instruction trap support

2015-04-22 Thread Edgar E. Iglesias
On Wed, Apr 22, 2015 at 12:09:21PM -0500, Greg Bellows wrote: > Add support for trapping WFI and WFE instructions to the proper EL when > SCTLR/SCR/HCR settings apply. > > Signed-off-by: Greg Bellows > > --- > > v1 -> v2 > - Replace check loop with simpler if checks. > - Changed WFx syncdrome f

[Qemu-devel] [PATCH RFC v7 6/7] qemu-iotests: s390x: fix test 051

2015-04-22 Thread Xiao Guang Chen
The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "virtio0" set for the s390 platform. A x86 platform specific output file is also needed.

[Qemu-devel] [PATCH RFC v7 4/7] qemu-iotests: s390x: fix test 055

2015-04-22 Thread Xiao Guang Chen
There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Reviewed-by: Max Reitz Reviewed-by: Michael Mueller Signed-off-by: Xiao Guang Chen --- tests/qemu-iotests/055 | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/qemu-iotests

[Qemu-devel] [PATCH RFC v7 2/7] qemu-iotests: run qemu with -nodefaults and fix 067, 071, 081 and 087

2015-04-22 Thread Xiao Guang Chen
This patch fixes an io test suite issue that was introduced with the commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only a single "stdio" character device'. The option supresses the creation of default devices such as the floopy and cdrom. Output files for test case 067, 071, 08

[Qemu-devel] [PATCH RFC v7 5/7] qemu-iotests: s390x: fix test 049

2015-04-22 Thread Xiao Guang Chen
From: Bo Tu when creating an image qemu-img enable us specifying the size of the image using -o size=xx options. But when we specify an invalid size such as a negtive size then different platform gives different result. parse_option_size() function in util/qemu-option.c will be called to parse t

[Qemu-devel] [PATCH RFC v7 0/7] Update tests/qemu-iotests failing cases for the s390 platform

2015-04-22 Thread Xiao Guang Chen
From: Bo Tu v7. 1. Add a pc specific output file for test 130. 2. A new variable device_id is defined in test 130 to support multiplatform. 3. Update the output file for test 051 based on it's current output. 4. test 049 failed in s390x platform while specifying a negtive size using -o option wh

[Qemu-devel] [PATCH RFC v7 7/7] qemu-iotests-s390x-fix-test-130

2015-04-22 Thread Xiao Guang Chen
From: Bo Tu The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "virtio0" set for the s390 platform. A x86 platform specific output file i

[Qemu-devel] [PATCH RFC v7 1/7] qemu-iotests: qemu machine type support

2015-04-22 Thread Xiao Guang Chen
This patch adds qemu machine type support to the io test suite. Based on the qemu default machine type and alias of the default machine type the reference output file can now vary from the default to a machine specific output file if necessary. When using a machine specific reference file if the de

[Qemu-devel] [PATCH RFC v7 3/7] qemu-iotests: s390x: fix test 041

2015-04-22 Thread Xiao Guang Chen
There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Reviewed-by: Max Reitz Reviewed-by: Michael Mueller Signed-off-by: Xiao Guang Chen --- tests/qemu-iotests/041 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/04

Re: [Qemu-devel] [PATCH v3 01/10] qapi: Add transaction support to block-dirty-bitmap operations

2015-04-22 Thread Eric Blake
On 04/22/2015 06:04 PM, John Snow wrote: > This adds two qmp commands to transactions. > > block-dirty-bitmap-add allows you to create a bitmap simultaneously > alongside a new full backup to accomplish a clean synchronization > point. > > block-dirty-bitmap-clear allows you to reset a bitmap bac

Re: [Qemu-devel] [PATCH v3 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-22 Thread Shannon Zhao
On 2015/4/22 22:24, Cornelia Huck wrote: > On Tue, 21 Apr 2015 18:51:10 +0800 > shannon.z...@linaro.org wrote: > > I'd drop the leading "hw/net/" from the subject. > Ok, thanks. >> From: Shannon Zhao >> >> Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. >> The transports just sync t

[Qemu-devel] [PATCH v3 08/10] qmp: Add an implementation wrapper for qmp_drive_backup

2015-04-22 Thread John Snow
We'd like to be able to specify the callback given to backup_start manually in the case of transactions, so split apart qmp_drive_backup into an implementation and a wrapper. Switch drive_backup_prepare to use the new wrapper, but don't overload the callback and closure yet. Signed-off-by: John S

[Qemu-devel] [PATCH v3 10/10] iotests: 124 - transactional failure test

2015-04-22 Thread John Snow
Use a transaction to request an incremental backup across two drives. Coerce one of the jobs to fail, and then re-run the transaction. Verify that no bitmap data was lost due to the partial transaction failure. Signed-off-by: John Snow --- tests/qemu-iotests/124 | 120 ++

[Qemu-devel] [PATCH v3 05/10] block: add transactional callbacks feature

2015-04-22 Thread John Snow
The goal here is to add a new method to transactions that allows developers to specify a callback that will get invoked only once all jobs spawned by a transaction are completed, allowing developers the chance to perform actions conditionally pending complete success, partial failure, or complete f

[Qemu-devel] [PATCH v3 01/10] qapi: Add transaction support to block-dirty-bitmap operations

2015-04-22 Thread John Snow
This adds two qmp commands to transactions. block-dirty-bitmap-add allows you to create a bitmap simultaneously alongside a new full backup to accomplish a clean synchronization point. block-dirty-bitmap-clear allows you to reset a bitmap back to as-if it were new, which can also be used alongsid

[Qemu-devel] [PATCH v3 07/10] block: add delayed bitmap successor cleanup

2015-04-22 Thread John Snow
Allow bitmap successors to carry reference counts. We can in a later patch use this ability to clean up the dirty bitmap according to both the individual job's success and the success of all jobs in the transaction group. The code for cleaning up a bitmap is also moved from backup_run to backup_c

[Qemu-devel] [PATCH v3 06/10] block: add refcount to Job object

2015-04-22 Thread John Snow
If we want to get at the job after the life of the job, we'll need a refcount for this object. This may occur for example if we wish to inspect the actions taken by a particular job after a transactional group of jobs runs, and further actions are required. Signed-off-by: John Snow Reviewed-by:

[Qemu-devel] [PATCH v3 03/10] block: rename BlkTransactionState and BdrvActionOps

2015-04-22 Thread John Snow
These structures are misnomers, somewhat. (1) BlockTransactionState is not state for a transaction, but is rather state for a single transaction action. Rename it "BlkActionState" to be more accurate. (2) The BdrvActionOps describes operations for the BlkActionState, above. This name

[Qemu-devel] [PATCH v3 09/10] block: drive_backup transaction callback support

2015-04-22 Thread John Snow
This patch actually implements the transactional callback system for the drive_backup action. (1) We manually pick up a reference to the bitmap if present to allow its cleanup to be delayed until after all drive_backup jobs launched by the transaction have fully completed. (2) We create a

[Qemu-devel] [PATCH v3 00/10] block: incremental backup transactions

2015-04-22 Thread John Snow
requires: 1429314609-29776-1-git-send-email-js...@redhat.com "[PATCH v6 00/21] block: transactionless incremental backup series" This series adds support for incremental backup primitives in QMP transactions. It requires my transactionless incremental backup series, currently at v6. Pat

[Qemu-devel] [PATCH v3 02/10] iotests: add transactional incremental backup test

2015-04-22 Thread John Snow
Test simple usage cases for using transactions to create and synchronize incremental backups. Signed-off-by: John Snow --- tests/qemu-iotests/124 | 54 ++ tests/qemu-iotests/124.out | 4 ++-- 2 files changed, 56 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH v3 04/10] block: re-add BlkTransactionState

2015-04-22 Thread John Snow
Now that the structure formerly known as BlkTransactionState has been renamed to something sensible (BlkActionState), re-introduce an actual BlkTransactionState that actually manages state for the entire Transaction. In the process, convert the old QSIMPLEQ list of actions into a QTAILQ, to let us

Re: [Qemu-devel] Add an IPMI device to qemu

2015-04-22 Thread Noel Burton-Krahn
Thanks a lot, Corey. I'll check them out. On Wed, Apr 22, 2015 at 3:46 PM, Corey Minyard wrote: > Sure, it's available on https://github.com/cminyard/qemu.git, the > stable-2.2-ipmi branch for now. > > I'm currently reworking these patches based upon feedback from the qemu > maintainers. > > -c

[Qemu-devel] Add an IPMI device to qemu

2015-04-22 Thread Noel Burton-Krahn
Hi Corey, I saw your patches for getting IPMI into qemu, but they don't appear to be in the qemu git repo yet. Do you have a github branch I could cherry-pick to try them out? We've been looking at getting IPMI on VMs for a while. Thanks for your work! [1] [Qemu-devel] [PATCH 00/16] Add an IPM

Re: [Qemu-devel] Add an IPMI device to qemu

2015-04-22 Thread Corey Minyard
Sure, it's available on https://github.com/cminyard/qemu.git, the stable-2.2-ipmi branch for now. I'm currently reworking these patches based upon feedback from the qemu maintainers. -corey On 04/22/2015 04:30 PM, Noel Burton-Krahn wrote: > Hi Corey, > > I saw your patches for getting IPMI into

Re: [Qemu-devel] [PATCH v6 12/21] qmp: Add dirty bitmap status field in query-block

2015-04-22 Thread John Snow
On 04/22/2015 06:18 PM, Eric Blake wrote: On 04/17/2015 05:50 PM, John Snow wrote: Add the "frozen" status booleans, to inform clients when a bitmap is occupied doing a task. Signed-off-by: Fam Zheng Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi Reviewed-by:

Re: [Qemu-devel] [PATCH v6 12/21] qmp: Add dirty bitmap status field in query-block

2015-04-22 Thread Eric Blake
On 04/17/2015 05:50 PM, John Snow wrote: > Add the "frozen" status booleans, to inform clients > when a bitmap is occupied doing a task. > > Signed-off-by: Fam Zheng > Signed-off-by: John Snow > Reviewed-by: Max Reitz > Reviewed-by: Stefan Hajnoczi > Reviewed-by: Eric Blake > --- > block.c

Re: [Qemu-devel] [PATCH v6 10/21] qmp: Add support of "dirty-bitmap" sync mode for drive-backup

2015-04-22 Thread Eric Blake
On 04/17/2015 05:49 PM, John Snow wrote: > For "dirty-bitmap" sync mode, the block job will iterate through the > given dirty bitmap to decide if a sector needs backup (backup all the > dirty clusters and skip clean ones), just as allocation conditions of > "top" sync mode. > > Signed-off-by: Fam

Re: [Qemu-devel] [PATCH v6 07/21] hbitmap: add hbitmap_merge

2015-04-22 Thread Eric Blake
On 04/17/2015 05:49 PM, John Snow wrote: > We add a bitmap merge operation to assist in error cases > where we wish to combine two bitmaps together. > > This is algorithmically O(bits) provided HBITMAP_LEVELS remains > constant. For a full bitmap on a 64bit machine: > sum(bits/64^k, k, 0, HBITMAP_

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-22 Thread Laszlo Ersek
another point: On 04/22/15 23:41, Laszlo Ersek wrote: > On 04/21/15 17:04, Gerd Hoffmann wrote: >>> - can the guest somehow use this facility to detect, dynamically, the >>> presence of this feature? (For now I'm thinking about a static build >>> flag for OVMF that would enable SMM support, but I

[Qemu-devel] [PATCH v3] translate-all: use bitmap helpers for PageDesc's bitmap

2015-04-22 Thread Emilio G. Cota
Here we have an open-coded byte-based bitmap implementation. Get rid of it since there's a ulong-based implementation to be used by all code. Signed-off-by: Emilio G. Cota --- translate-all.c | 42 +- 1 file changed, 9 insertions(+), 33 deletions(-) diff

Re: [Qemu-devel] [PATCH v2] translate-all: use bitmap helpers for PageDesc's bitmap

2015-04-22 Thread Emilio G. Cota
On Wed, Apr 22, 2015 at 22:30:23 +0200, Paolo Bonzini wrote: > On 22/04/2015 18:53, Emilio G. Cota wrote: > > @@ -1221,8 +1194,9 @@ void tb_invalidate_phys_page_fast(tb_page_addr_t > > start, int len) > > return; > > } > > if (p->code_bitmap) { > > -offset = start & ~TAR

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-22 Thread Laszlo Ersek
On 04/21/15 17:04, Gerd Hoffmann wrote: >>> +static const MemoryRegionOps tseg_blackhole_ops = { >>> +.read = tseg_blackhole_read, >>> +.write = tseg_blackhole_write, >>> +.endianness = DEVICE_NATIVE_ENDIAN, >>> +.valid.min_access_size = 1, >>> +.valid.max_access_size = 4, >>> +

Re: [Qemu-devel] [PATCH v2] translate-all: use bitmap helpers for PageDesc's bitmap

2015-04-22 Thread Paolo Bonzini
On 22/04/2015 18:53, Emilio G. Cota wrote: > Here we have an open-coded byte-based bitmap implementation. > Get rid of it since there's a ulong-based implementation to be > used by all code. > > Signed-off-by: Emilio G. Cota > --- > translate-all.c | 40 +++-

Re: [Qemu-devel] [PATCH 5/8] block: Add QMP support for streaming to an intermediate layer

2015-04-22 Thread Eric Blake
On 04/16/2015 09:12 AM, Alberto Garcia wrote: > This patch makes the 'device' paramater of the 'block-stream' command s/paramater/parameter/ > accept a node name as well as a device name. > > In addition to that, operation blockers will be checked in all > intermediate nodes between the top and

Re: [Qemu-devel] [PATCH 2/8] block: allow block jobs in any arbitrary node

2015-04-22 Thread Eric Blake
On 04/16/2015 09:12 AM, Alberto Garcia wrote: > Currently, block jobs can only be owned by root nodes. This patch > allows block jobs to be in any arbitrary node, by making the following > changes: > > - Block jobs can now be identified by the node name of their > BlockDriverState in addition to

Re: [Qemu-devel] [PATCH 1/8] block: keep a list of block jobs

2015-04-22 Thread Eric Blake
On 04/16/2015 09:12 AM, Alberto Garcia wrote: > The current way to obtain the list of existing block jobs is to > iterate over all root nodes and check which ones own a job. > > Since we want to be able to support block jobs in other nodes as well, > this patch keeps a list of jobs that is updated

Re: [Qemu-devel] [PATCH 8/8] qemu-iotests: test streaming to an intermediate layer

2015-04-22 Thread Eric Blake
On 04/16/2015 09:12 AM, Alberto Garcia wrote: > This adds test_stream_intermediate(), similar to test_stream() but > streams to the intermediate image instead. > > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/030 | 18 +- > tests/qemu-iotests/030.out | 4 ++-- >

Re: [Qemu-devel] [PATCH 7/8] qemu-iotests: fix test_stream_partial()

2015-04-22 Thread Alberto Garcia
On Wed 22 Apr 2015 09:38:40 PM CEST, Eric Blake wrote: > You know, we should _also_ test a no-op stream, to prove that we > handle it correctly (we've had bugs in the past where 0-length active > commit behaved differently in the events it generated than non-zero > length), and your change is drop

Re: [Qemu-devel] [PATCH 7/8] qemu-iotests: fix test_stream_partial()

2015-04-22 Thread Eric Blake
On 04/16/2015 09:12 AM, Alberto Garcia wrote: > This test is streaming to the top layer using the intermediate image > as the base. This is a mistake since block-stream never copies data > from the base image and its backing chain, so this is effectively a > no-op. > > In addition to fixing the ba

Re: [Qemu-devel] [PATCH 6/8] docs: Document how to stream to an intermediate layer

2015-04-22 Thread Eric Blake
On 04/16/2015 09:12 AM, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > docs/live-block-ops.txt | 30 +++--- > 1 file changed, 19 insertions(+), 11 deletions(-) > > diff --git a/docs/live-block-ops.txt b/docs/live-block-ops.txt > index a257087..3bf86be 10064

Re: [Qemu-devel] [PATCH v2 0/4] scripts: qmp-shell: add transaction support

2015-04-22 Thread John Snow
On 04/22/2015 12:21 PM, John Snow wrote: The qmp-shell is a little rudimentary, but it can be hacked to give us some transactional support without too much difficulty. (1) Prep. (2) Add support for serializing json arrays (3) Allow users to use 'single quotes' instead of "double quotes" (4) Ad

Re: [Qemu-devel] [PATCH v6 01/21] docs: incremental backup documentation

2015-04-22 Thread Eric Blake
On 04/17/2015 05:49 PM, John Snow wrote: > Signed-off-by: John Snow > --- > docs/bitmaps.md | 352 > > 1 file changed, 352 insertions(+) > create mode 100644 docs/bitmaps.md > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com

Re: [Qemu-devel] [PATCH v2 6/9] target-arm: Add TTBR regime function and use

2015-04-22 Thread Greg Bellows
On Wed, Apr 22, 2015 at 1:16 PM, Sergey Fedorov wrote: > On 22.04.2015 10:09, Greg Bellows wrote: > > Add a utility function for choosing the correct TTBR system register > based on > > the specified MMU index. Add use of function on physical address lookup. > > > > Signed-off-by: Greg Bellows >

Re: [Qemu-devel] [PATCH 0/5] Extend TPM support with a QEMU-external TPM

2015-04-22 Thread Stefan Berger
On 04/22/2015 03:00 AM, Igor Mammedov wrote: On Thu, 16 Apr 2015 10:05:35 -0400 Stefan Berger wrote: On 04/16/2015 09:35 AM, Igor Mammedov wrote: On Wed, 15 Apr 2015 18:38:43 -0400 Stefan Berger wrote: The following series of patches extends TPM support with an external TPM that offers a L

Re: [Qemu-devel] [PATCH v2 6/9] target-arm: Add TTBR regime function and use

2015-04-22 Thread Sergey Fedorov
On 22.04.2015 10:09, Greg Bellows wrote: > Add a utility function for choosing the correct TTBR system register based on > the specified MMU index. Add use of function on physical address lookup. > > Signed-off-by: Greg Bellows > --- > target-arm/helper.c | 24 +++- > 1 file c

Re: [Qemu-devel] [PATCH 2/2] x86: Fix Opteron xlevels

2015-04-22 Thread Eduardo Habkost
On Wed, Apr 22, 2015 at 07:19:22PM +0200, Alexander Graf wrote: > > > > Am 22.04.2015 um 17:53 schrieb Eduardo Habkost : > > > >> On Wed, Apr 22, 2015 at 12:38:11AM +0200, Alexander Graf wrote: > >> The AMD Opteron family has different xlevel levels depending on the > >> generation. I looked up

Re: [Qemu-devel] [PATCH 8/8] qemu-iotests: test streaming to an intermediate layer

2015-04-22 Thread Max Reitz
On 16.04.2015 17:12, Alberto Garcia wrote: This adds test_stream_intermediate(), similar to test_stream() but streams to the intermediate image instead. Signed-off-by: Alberto Garcia --- tests/qemu-iotests/030 | 18 +- tests/qemu-iotests/030.out | 4 ++-- 2 files change

Re: [Qemu-devel] [PATCH 7/8] qemu-iotests: fix test_stream_partial()

2015-04-22 Thread Max Reitz
On 16.04.2015 17:12, Alberto Garcia wrote: This test is streaming to the top layer using the intermediate image as the base. This is a mistake since block-stream never copies data from the base image and its backing chain, so this is effectively a no-op. In addition to fixing the base parameter,

Re: [Qemu-devel] [PATCH 6/8] docs: Document how to stream to an intermediate layer

2015-04-22 Thread Max Reitz
On 16.04.2015 17:12, Alberto Garcia wrote: Signed-off-by: Alberto Garcia --- docs/live-block-ops.txt | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH v2 2/4] scripts: qmp-shell: Expand support for QMP expressions

2015-04-22 Thread John Snow
On 04/22/2015 01:18 PM, Eric Blake wrote: On 04/22/2015 10:21 AM, John Snow wrote: This includes support for [] expressions, single-quotes in QMP expressions (which is not strictly a part of JSON), and the ability to use "True" or "False" literals instead of JSON's lowercased 'true' and 'false

Re: [Qemu-devel] [PATCH v6 15/21] block: Resize bitmaps on bdrv_truncate

2015-04-22 Thread Max Reitz
On 18.04.2015 01:50, John Snow wrote: Signed-off-by: John Snow --- block.c| 18 ++ include/qemu/hbitmap.h | 10 ++ util/hbitmap.c | 48 3 files changed, 76 insertions(+) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 5/8] block: Add QMP support for streaming to an intermediate layer

2015-04-22 Thread Max Reitz
On 16.04.2015 17:12, Alberto Garcia wrote: This patch makes the 'device' paramater of the 'block-stream' command accept a node name as well as a device name. In addition to that, operation blockers will be checked in all intermediate nodes between the top and the base node. Since qmp_block_stre

Re: [Qemu-devel] [PATCH v2 2/4] scripts: qmp-shell: Expand support for QMP expressions

2015-04-22 Thread Eric Blake
On 04/22/2015 11:18 AM, Eric Blake wrote: > On 04/22/2015 10:21 AM, John Snow wrote: >> This includes support for [] expressions, single-quotes in >> QMP expressions (which is not strictly a part of JSON), and >> the ability to use "True" or "False" literals instead of >> JSON's lowercased 'true' a

Re: [Qemu-devel] [PATCH 4/8] block: Support streaming to an intermediate layer

2015-04-22 Thread Max Reitz
On 16.04.2015 17:12, Alberto Garcia wrote: This makes sure that the image we are steaming into is open in read-write mode during the operation. Operation blockers are also set in all intermediate nodes, since they will be removed from the chain afterwards. Finally, this also unblocks the stream

Re: [Qemu-devel] [RFC 0/7] Live Migration with Pass-through Devices proposal

2015-04-22 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Wed, Apr 22, 2015 at 06:12:25PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Wed, Apr 22, 2015 at 06:01:56PM +0100, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrange (berra...@redh

Re: [Qemu-devel] [PATCH 2/2] x86: Fix Opteron xlevels

2015-04-22 Thread Alexander Graf
> Am 22.04.2015 um 17:53 schrieb Eduardo Habkost : > >> On Wed, Apr 22, 2015 at 12:38:11AM +0200, Alexander Graf wrote: >> The AMD Opteron family has different xlevel levels depending on the >> generation. I looked up Gen1, Gen2 and Gen3 hardware and adapted the >> levels according to real silic

Re: [Qemu-devel] [PATCH v2 2/4] scripts: qmp-shell: Expand support for QMP expressions

2015-04-22 Thread Eric Blake
On 04/22/2015 10:21 AM, John Snow wrote: > This includes support for [] expressions, single-quotes in > QMP expressions (which is not strictly a part of JSON), and > the ability to use "True" or "False" literals instead of > JSON's lowercased 'true' and 'false' literals. > > qmp-shell currently al

Re: [Qemu-devel] [PATCH 2/8] block: allow block jobs in any arbitrary node

2015-04-22 Thread Max Reitz
On 16.04.2015 17:12, Alberto Garcia wrote: Currently, block jobs can only be owned by root nodes. This patch allows block jobs to be in any arbitrary node, by making the following changes: - Block jobs can now be identified by the node name of their BlockDriverState in addition to the device

Re: [Qemu-devel] [RFC 0/7] Live Migration with Pass-through Devices proposal

2015-04-22 Thread Daniel P. Berrange
On Wed, Apr 22, 2015 at 06:12:25PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Wed, Apr 22, 2015 at 06:01:56PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > On Fri, Apr 17, 2015 at 04:53:02PM

Re: [Qemu-devel] [RFC 0/7] Live Migration with Pass-through Devices proposal

2015-04-22 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Wed, Apr 22, 2015 at 06:01:56PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Fri, Apr 17, 2015 at 04:53:02PM +0800, Chen Fan wrote: > > > > backgrond: > > > > Live migration is one of the m

[Qemu-devel] [PATCH v2 9/9] target-arm: Add WFx instruction trap support

2015-04-22 Thread Greg Bellows
Add support for trapping WFI and WFE instructions to the proper EL when SCTLR/SCR/HCR settings apply. Signed-off-by: Greg Bellows --- v1 -> v2 - Replace check loop with simpler if checks. - Changed WFx syncdrome function to take bool - Changed return of uint32_t to int - Added cdditional commen

[Qemu-devel] [PATCH v2 8/9] target-arm: Add WFx syndrome function

2015-04-22 Thread Greg Bellows
Adds a utility function for creating a WFx exception syndrome Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- target-arm/internals.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target-arm/internals.h b/target-arm/internals.h index 2cc3017..de0a9c1 100644 --- a/target-ar

[Qemu-devel] [PATCH v2 6/9] target-arm: Add TTBR regime function and use

2015-04-22 Thread Greg Bellows
Add a utility function for choosing the correct TTBR system register based on the specified MMU index. Add use of function on physical address lookup. Signed-off-by: Greg Bellows --- target-arm/helper.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a

[Qemu-devel] [PATCH v2 7/9] target-arm: Add EL3 and EL2 TCR checking

2015-04-22 Thread Greg Bellows
Updated get_phys_addr_lpae to check the appropriate TTBCR/TCR depending on the current EL. Support includes using the different TCR format as well as checks to insure TTBR1 is not used when in EL2 or EL3. Signed-off-by: Greg Bellows --- target-arm/helper.c | 45 --

[Qemu-devel] [PATCH v2 3/9] target-arm: Update interrupt handling to use target EL

2015-04-22 Thread Greg Bellows
Updated the interrupt handling to utilize and report through the target EL exception field. This includes consolidating and cleaning up code where needed. Target EL is now calculated once in arm_cpu_exec_interrupt() and do_interrupt was updated to use the target_el exception field. The necessary

[Qemu-devel] [PATCH v2 5/9] target-arm: Extend FP checks to use an EL

2015-04-22 Thread Greg Bellows
Extend the ARM disassemble context to take a target exception EL instead of a boolean enable. This change reverses the polarity of the check making a value of 0 indicate floating point enabled (no exception). Signed-off-by: Greg Bellows --- target-arm/cpu.h | 63 +++

[Qemu-devel] [PATCH v2 1/9] target-arm: Add exception target el infrastructure

2015-04-22 Thread Greg Bellows
Add a CPU state exception target EL field that will be used for communicating the EL to which an exception should be routed. Add a disassembly context field for tracking the EL3 architecture needed for determining the target exception EL. Add a target EL argument to the generic exception helper f

[Qemu-devel] [PATCH v2 2/9] target-arm: Extend helpers to route exceptions

2015-04-22 Thread Greg Bellows
Updated the various helper routines to set the target EL as needed using a dedicated function. Signed-off-by: Greg Bellows --- v1 -> v2 - Add utility function for determining the target exception EL. - Replaced uses of MAX with the above function when setting the target EL. --- target-arm/op_h

[Qemu-devel] [PATCH v2 4/9] target-arm: Add AArch64 CPTR registers

2015-04-22 Thread Greg Bellows
Adds CPTR_EL2/3 system registers definitions and access function. Signed-off-by: Greg Bellows --- v2 -> v3 - Broke out cptr and cpacr access functions - Added HCPTR register entry as alias of CPTR_EL2 - Added HCPTR and CPTR_EL2 no_el2 register entries. - Fixed cptr_access comment --- target-ar

[Qemu-devel] [PATCH v2 0/9] target-arm: EL3 trap support

2015-04-22 Thread Greg Bellows
Initial patchset adding support for trapping to an EL other than EL1. Support includes changes to interfaces to allow specification of the target EL. Also includes the addition of the ARMv8 CPTR system registers used for controlling the trapping of features. --- v1 -> v2 - Removed use of MAX th

Re: [Qemu-devel] [RFC 0/7] Live Migration with Pass-through Devices proposal

2015-04-22 Thread Daniel P. Berrange
On Wed, Apr 22, 2015 at 06:01:56PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Fri, Apr 17, 2015 at 04:53:02PM +0800, Chen Fan wrote: > > > backgrond: > > > Live migration is one of the most important features of virtualization > > > technology.

Re: [Qemu-devel] [RFC 0/7] Live Migration with Pass-through Devices proposal

2015-04-22 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, Apr 17, 2015 at 04:53:02PM +0800, Chen Fan wrote: > > backgrond: > > Live migration is one of the most important features of virtualization > > technology. > > With regard to recent virtualization techniques, performance of network I/O >

Re: [Qemu-devel] [PATCH 2/2] x86: Fix Opteron xlevels

2015-04-22 Thread Eduardo Habkost
On Wed, Apr 22, 2015 at 12:38:11AM +0200, Alexander Graf wrote: > The AMD Opteron family has different xlevel levels depending on the > generation. I looked up Gen1, Gen2 and Gen3 hardware and adapted the > levels according to real silicon. > > The reason this came up is that there is a sanity che

[Qemu-devel] [PATCH v2] translate-all: use bitmap helpers for PageDesc's bitmap

2015-04-22 Thread Emilio G. Cota
Here we have an open-coded byte-based bitmap implementation. Get rid of it since there's a ulong-based implementation to be used by all code. Signed-off-by: Emilio G. Cota --- translate-all.c | 40 +++- 1 file changed, 7 insertions(+), 33 deletions(-) diff --

Re: [Qemu-devel] [PATCH v6 18/21] iotests: add QMP event waiting queue

2015-04-22 Thread Max Reitz
On 18.04.2015 01:50, John Snow wrote: A filter is added to allow callers to request very specific events to be pulled from the event queue, while leaving undesired events still in the stream. This allows us to poll for completion data for multiple asynchronous events in any arbitrary order. A n

Re: [Qemu-devel] using scsi megasas causes Windows 8 bluescreen

2015-04-22 Thread Alex Fishman
Hannes, megasas-gen2 crashes as well -Alex On Wed, Apr 22, 2015 at 1:23 PM, Hannes Reinecke wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/22/2015 12:19 PM, Stefan Hajnoczi wrote: > > On Tue, Apr 21, 2015 at 10:49:48AM +0300, Alex Fishman wrote: > >> I'm trying to install W

Re: [Qemu-devel] [PATCH] translate-all: use bitmap helpers for PageDesc's bitmap

2015-04-22 Thread Emilio G. Cota
On Wed, Apr 22, 2015 at 15:13:05 +0200, Paolo Bonzini wrote: > On 21/03/2015 07:25, Emilio G. Cota wrote: > > Note that this test > > if (b & ((1 << len) - 1)) > > can be simplified to > > if (b & 1) > > , since we know that iff the first bit of a tb is set, > > all other bits from that tb

Re: [Qemu-devel] [PATCH v2 2/4] scripts: qmp-shell: Expand support for QMP expressions

2015-04-22 Thread John Snow
On 04/22/2015 12:21 PM, John Snow wrote: This includes support for [] expressions, single-quotes in QMP expressions (which is not strictly a part of JSON), and the ability to use "True" or "False" literals instead of JSON's lowercased 'true' and 'false' literals. qmp-shell currently allows you

Re: [Qemu-devel] [PATCH] x86: Fix Opteron xlevels

2015-04-22 Thread Eduardo Habkost
On Wed, Apr 22, 2015 at 04:59:49PM +0200, Alexander Graf wrote: > On 04/22/2015 04:23 PM, Eduardo Habkost wrote: > >On Tue, Apr 21, 2015 at 04:15:14PM +0200, Alexander Graf wrote: > >>On 04/21/2015 04:16 PM, Eduardo Habkost wrote: > >>>On Tue, Apr 21, 2015 at 04:04:21PM +0200, Alexander Graf wrote:

  1   2   3   >