On 04/22/2015 12:21 PM, John Snow wrote:
The qmp-shell is a little rudimentary, but it can be hacked
to give us some transactional support without too much difficulty.
(1) Prep.
(2) Add support for serializing json arrays
(3) Allow users to use 'single quotes' instead of "double quotes"
(4) Add a special transaction( ... ) syntax that lets users
build up transactional commands using the existing qmp shell
syntax to define each action.
(5) Add a verbose flag to display generated QMP commands.
The parsing is not as robust as one would like, but this suffices
without adding a proper parser.
Design considerations:
(1) Try not to disrupt the existing design of the qmp-shell. The existing
API is not disturbed.
(2) Pick a "magic token" such that it could not be confused for legitimate
QMP/JSON syntax. Parentheses are used for this purpose.
===
v2:
===
- Squash patches 2 & 3:
- Remove wholesale replacement of single quotes, in favor of try blocks
that attempt to parse as pure JSON, then as Python.
- Factored out the value parser block to accomplish the above.
- Allow both true/True and false/False for values.
- Fix typo in patch 3 cover letter. (was patch 4.)
John Snow (4):
scripts: qmp-shell: refactor helpers
scripts: qmp-shell: Expand support for QMP expressions
scripts: qmp-shell: add transaction subshell
scripts: qmp-shell: Add verbose flag
scripts/qmp/qmp-shell | 125 ++++++++++++++++++++++++++++++++++++++------------
1 file changed, 95 insertions(+), 30 deletions(-)
Version "2+" with the hotfix added, with R-B's added:
https://github.com/jnsnow/qemu/commits/qmp-shell-plus
To whomever would pull this into their tree: Let me know if you prefer I
send a "v3" instead.
Thanks,
--John
