On 2015/4/22 22:24, Cornelia Huck wrote: > On Tue, 21 Apr 2015 18:51:10 +0800 > shannon.z...@linaro.org wrote: > > I'd drop the leading "hw/net/" from the subject. >
Ok, thanks. >> From: Shannon Zhao <shannon.z...@linaro.org> >> >> Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. >> The transports just sync the host features from backend. >> Meanwhile move virtio_net_set_config_size to virtio-net. > > Could you elaborate on why this makes sense? > Ok, will add. >> >> Signed-off-by: Shannon Zhao <zhaoshengl...@huawei.com> >> Signed-off-by: Shannon Zhao <shannon.z...@linaro.org> >> --- >> hw/net/virtio-net.c | 5 +++++ >> hw/s390x/s390-virtio-bus.c | 2 -- >> hw/s390x/virtio-ccw.c | 2 -- >> hw/virtio/virtio-pci.c | 2 -- >> include/hw/virtio/virtio-net.h | 1 + >> 5 files changed, 6 insertions(+), 6 deletions(-) > > FWIW, this survives basic sanity checks on virtio-ccw - also in > combination with my realization sequence reordering patches I sent > yesterday. > > Haven't gotten around to s390-virtio or virtio-scsi yet. > -- Shannon