[Qemu-devel] [PATCH v4] block/null: Latency simulation by adding new option "latency-ns"

2015-03-17 Thread Fam Zheng
Aio context switch should just work because the requests will be drained, so the scheduled timer(s) on the old context will be freed. Signed-off-by: Fam Zheng --- v4: If errp is not null, return -EINVAL. [Kevin] --- block/null.c | 59 ++--

Re: [Qemu-devel] [RFC v0 PATCH] cpus: Convert cpu_index into a bitmap

2015-03-17 Thread Bharata B Rao
On Wed, Mar 18, 2015 at 11:49:59AM +1100, David Gibson wrote: > On Fri, Mar 13, 2015 at 05:26:36PM +0530, Bharata B Rao wrote: > > From: Bharata B Rao > > > > Currently CPUState.cpu_index is monotonically increasing and a newly > > created CPU always gets the next higher index. The next available

Re: [Qemu-devel] [RFC v0 PATCH] cpus: Convert cpu_index into a bitmap

2015-03-17 Thread Bharata B Rao
On Tue, Mar 17, 2015 at 11:51:36AM +0100, Andreas Färber wrote: > Am 13.03.2015 um 12:56 schrieb Bharata B Rao: > > From: Bharata B Rao > > > > Currently CPUState.cpu_index is monotonically increasing and a newly > > created CPU always gets the next higher index. The next available > > index is c

Re: [Qemu-devel] [RFC v0 PATCH] cpus: Convert cpu_index into a bitmap

2015-03-17 Thread Bharata B Rao
On Tue, Mar 17, 2015 at 11:56:04AM +0100, Andreas Färber wrote: > Am 17.03.2015 um 09:39 schrieb Bharata B Rao: > > On Tue, Mar 17, 2015 at 07:56:41AM +0100, Alexander Graf wrote: > >> > >> > >> On 13.03.15 12:56, Bharata B Rao wrote: > >>> From: Bharata B Rao > >>> > >>> Currently CPUState.cpu_in

Re: [Qemu-devel] [RFC PATCH 03/14] quorum: ignore 0-length child

2015-03-17 Thread Wen Congyang
On 02/24/2015 04:43 AM, Max Reitz wrote: > On 2015-02-11 at 22:07, Wen Congyang wrote: >> We connect to NBD server when starting block replication, so >> the length is 0 before starting block replication. >> >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH target-arm v3 12/15] arm: Add xlnx-ep108 machine

2015-03-17 Thread Alistair Francis
On Mon, Mar 16, 2015 at 10:12 PM, Peter Crosthwaite wrote: > Add a machine model for the Xilinx ZynqMP SoC EP108 board. > > Signed-off-by: Peter Crosthwaite > --- > Chaned since v1: > Change board name to ep108 > > hw/arm/Makefile.objs | 2 +- > hw/arm/xlnx-ep108.c | 52 >

Re: [Qemu-devel] [PATCH v5 0/2] Introduce default ram size in MachineClass

2015-03-17 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > Current DEFAULT_RAM_SIZE(128MB) enforced by QEMU would not work for > all machines. Introduce a default_ram_size as part of MachineClass. > > The below patches has following behaviour: > > 1) If the user does not provide "-m" option, machine's default ram >size wil

Re: [Qemu-devel] [PATCH target-arm v3 15/15] arm: xlnx-zynqmp: Add PSCI setup

2015-03-17 Thread Alistair Francis
On Mon, Mar 16, 2015 at 10:12 PM, Peter Crosthwaite wrote: > Use SMC PSCI, with the standard policy of secondaries starting in > power-off. > > Signed-off-by: Peter Crosthwaite Looks good, Reviewed-by: Alistair Francis Thanks, Alistair > --- > changed since v1: > Add &error_abort to propert

Re: [Qemu-devel] [PATCH target-arm v3 04/15] arm: xlnx-zynqmp: Add GIC

2015-03-17 Thread Alistair Francis
On Mon, Mar 16, 2015 at 10:12 PM, Peter Crosthwaite wrote: > And connect IRQ outputs to the CPUs. > > Reviewed-by: Alistair Francis > Signed-off-by: Peter Crosthwaite > --- > hw/arm/xlnx-zynqmp.c | 19 +++ > include/hw/arm/xlnx-zynqmp.h | 2 ++ > 2 files changed, 21 ins

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/3] VFIO: Disable INTx interrupt on EEH reset

2015-03-17 Thread Gavin Shan
On Tue, Mar 17, 2015 at 03:16:46PM -0600, Alex Williamson wrote: >On Tue, 2015-03-17 at 03:31 +1100, Gavin Shan wrote: >> When Linux guest recovers from EEH error on the following Emulex >> adapter, the MSIx interrupts are disabled and the INTx emulation >> is enabled. One INTx interrupt is injecte

Re: [Qemu-devel] [Qemu-Dev-QUERY] Related to Live Migration source Code or API for NUMA Node specific

2015-03-17 Thread Arkajit Ghosh
Hi Team, I didn't get any response on the below query. Can anyone please provide their inputs on my below query related to access the dirty pages in NUMA aware processor during Live Migration. Thanks & Regards Arkajit Ghosh -Arkajit Ghosh/DEL/T

Re: [Qemu-devel] [PATCH] migration: flush the bdrv before stopping VM

2015-03-17 Thread Li, Liang Z
> This needs further review/changes on the block layer. > > First explanation, why I think this don't fix the full problem. > Whith this patch, we fix the problem where we have a dirty block layer but > basically nothing dirtying the memory on the guest (we are moving the 20 > seconds from max_dow

[Qemu-devel] [PATCH qemu] target-ppc: Remove never existed POWER5+ v0.0

2015-03-17 Thread Alexey Kardashevskiy
IBM uses low 16bits to specify a chip version of a POWER CPU. So there has never been an actual silicon with PVR = 0x003B. The first silicon would have PVR 0x003B0100 but it is very unlikely to find it in any machine shipped to any customer as it is was too raw. This removes CPU_POWERPC_POWER5

Re: [Qemu-devel] [PATCH] virtio-scsi-dataplane: fix memory leak in virtio_scsi_vring_init

2015-03-17 Thread Gonglei
On 2015/3/18 17:42, Bo Su wrote: > if k->set_host_notifier failed, VirtIOSCSIVring *r will leak > > Signed-off-by: Bo Su > --- > hw/scsi/virtio-scsi-dataplane.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Gonglei

[Qemu-devel] [PATCH v3 1/3] uhci: fix segfault when hot-unplugging uhci controller

2015-03-17 Thread arei.gonglei
From: Gonglei When hot-unplugging the usb controllers (ehci/uhci), we have to clean all resouce of these devices, involved registered reset handler. Otherwise, it may cause NULL pointer access and/or segmentation fault if we reboot the guest os after hot-unplugging. Let's hook up reset via Devic

[Qemu-devel] [PATCH v3 0/3] usb: fix segfault when hot-unplugging usb host adapter

2015-03-17 Thread arei.gonglei
From: Gonglei When hot-unplugging the usb controllers (ehci/uhci), we have to clean all resouce of these devices, involved registered reset handler. Otherwise, it may cause NULL pointer access and/or segmentation fault if we reboot the guest os after hot-unplugging. Let's hook up reset via D

[Qemu-devel] [PATCH v3 2/3] ehci: fix segfault when hot-unplugging ehci controller

2015-03-17 Thread arei.gonglei
From: Gonglei When hot-unplugging the usb controllers (ehci/uhci), we have to clean all resouce of these devices, involved registered reset handler. Otherwise, it may cause NULL pointer access and/or segmentation fault if we reboot the guest os after hot-unplugging. Let's hook up reset via Devic

[Qemu-devel] [PATCH v3 3/3] ohci: fix resource cleanup leak

2015-03-17 Thread arei.gonglei
From: Gonglei When hot-unplugging the usb controllers (ehci/uhci), we have to clean all resouce of these devices, involved registered reset handler. Otherwise, it may cause NULL pointer access and/or segmentation fault if we reboot the guest os after hot-unplugging. Let's hook up reset via Devic

Re: [Qemu-devel] [PATCH] virtio-scsi-dataplane: fix memory leak in virtio_scsi_vring_init

2015-03-17 Thread Fam Zheng
On Wed, 03/18 09:42, Bo Su wrote: > if k->set_host_notifier failed, VirtIOSCSIVring *r will leak > > Signed-off-by: Bo Su > --- > hw/scsi/virtio-scsi-dataplane.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dat

Re: [Qemu-devel] [PATCH v2 0/3] usb: fix segfault when hot-unplugging usb host adapter

2015-03-17 Thread Gonglei
On 2015/3/18 9:36, arei.gong...@huawei.com wrote: > Gonglei (3): > uhci: using DeviceClasss->reset qemu_register_reset() call > ehci: using DeviceClasss->reset qemu_register_reset() call > ohci: using DeviceClasss->reset qemu_register_reset() call Sorry, typos in the patches' title. :( Rega

[Qemu-devel] [PATCH] virtio-scsi-dataplane: fix memory leak in virtio_scsi_vring_init

2015-03-17 Thread Bo Su
if k->set_host_notifier failed, VirtIOSCSIVring *r will leak Signed-off-by: Bo Su --- hw/scsi/virtio-scsi-dataplane.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c index 3f40ff0..c069cd7 100644 --- a/hw/sc

[Qemu-devel] [PATCH v2 0/3] usb: fix segfault when hot-unplugging usb host adapter

2015-03-17 Thread arei.gonglei
From: Gonglei When hot-unplugging the usb controllers (ehci/uhci), we have to clean all resouce of these devices, involved registered reset handler. Otherwise, it may cause NULL pointer access and/or segmentation fault if we reboot the guest os after hot-unplugging. Let's hook up reset via D

[Qemu-devel] [PATCH v2 2/3] ehci: using DeviceClasss->reset qemu_register_reset() call

2015-03-17 Thread arei.gonglei
From: Gonglei When hot-unplugging the usb controllers (ehci/uhci), we have to clean all resouce of these devices, involved registered reset handler. Otherwise, it may cause NULL pointer access and/or segmentation fault if we reboot the guest os after hot-unplugging. Let's hook up reset via Devic

[Qemu-devel] [PATCH v2 1/3] uhci: using DeviceClasss->reset qemu_register_reset() call

2015-03-17 Thread arei.gonglei
From: Gonglei When hot-unplugging the usb controllers (ehci/uhci), we have to clean all resouce of these devices, involved registered reset handler. Otherwise, it may cause NULL pointer access and/or segmentation fault if we reboot the guest os after hot-unplugging. Let's hook up reset via Devic

[Qemu-devel] [PATCH v2 3/3] ohci: using DeviceClasss->reset qemu_register_reset() call

2015-03-17 Thread arei.gonglei
From: Gonglei When hot-unplugging the usb controllers (ehci/uhci), we have to clean all resouce of these devices, involved registered reset handler. Otherwise, it may cause NULL pointer access and/or segmentation fault if we reboot the guest os after hot-unplugging. Let's hook up reset via Devic

Re: [Qemu-devel] [PATCH] hw/net/e1000: fix integer endianness

2015-03-17 Thread Shannon Zhao
On 2015/3/18 1:05, Stefan Hajnoczi wrote: > On Fri, Mar 13, 2015 at 01:21:59PM +0800, Shannon Zhao wrote: >> It's detected by coverity.In is_vlan_packet s->mac_reg[VET] is >> unsigned int but is dereferenced as a narrower unsigned short. >> This may lead to unexpected results depending on machine >

Re: [Qemu-devel] [PATCH 1/2] cpu/apic: drop icc bus/bridge/

2015-03-17 Thread Chen Fan
On 03/17/2015 06:39 PM, Andreas Färber wrote: Am 17.03.2015 um 10:08 schrieb Chen Fan: ICC bus was invented only to provide hotplug capability to CPU and APIC because at the time being hotplug was available only for BUS attached devices. Now this patch is to drop ICC bus impl, and switch to bu

Re: [Qemu-devel] [RFC v0 PATCH] cpus: Convert cpu_index into a bitmap

2015-03-17 Thread David Gibson
On Fri, Mar 13, 2015 at 05:26:36PM +0530, Bharata B Rao wrote: > From: Bharata B Rao > > Currently CPUState.cpu_index is monotonically increasing and a newly > created CPU always gets the next higher index. The next available > index is calculated by counting the existing number of CPUs. This is

Re: [Qemu-devel] [PATCH 10/11] iotests: 124 - backup_prepare refactoring

2015-03-17 Thread John Snow
On 03/17/2015 04:50 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: Allow tests to call just the backup preparation routine without invoking a backup. Useful for transactions where we want to prepare, but don't wish to issue the QMP command. Signed-off-by: John Snow --- tests

Re: [Qemu-devel] [PATCH 09/11] iotests: test 124 - drive object refactoring

2015-03-17 Thread John Snow
On 03/17/2015 04:44 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: The original test was not particularly good about keeping the relationships between bitmaps, drives, and images very explicit, so this patch adds an explicit 'drive' dict that is used to keep these relationships

Re: [Qemu-devel] [PATCH v2 1/3] VFIO: Clear stale MSIx table during EEH reset

2015-03-17 Thread Gavin Shan
On Tue, Mar 17, 2015 at 03:09:52PM -0600, Alex Williamson wrote: >On Tue, 2015-03-17 at 03:31 +1100, Gavin Shan wrote: >> The PCI device MSIx table is cleaned out in hardware after EEH PE >> reset. However, we still hold the stale MSIx entries in QEMU, which >> should be cleared accordingly. Otherw

Re: [Qemu-devel] [PATCH 07/11] block: drive_backup transaction callback support

2015-03-17 Thread John Snow
On 03/17/2015 03:49 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: This patch actually implements the transactional callback system for the drive_backup transaction. (1) We manually pick up a reference to the bitmap if present to allow its cleanup to be delayed until after

Re: [Qemu-devel] clang 3.5.0 errors

2015-03-17 Thread Peter Maydell
On 17 March 2015 at 19:59, John Snow wrote: > On 03/17/2015 03:34 PM, Peter Maydell wrote: >> On 17 March 2015 at 19:30, John Snow wrote: >>> -Wunused-command-line-argument currently complains about the >>> many include flags passed to each CC incantation >> Do you see this with really just --cc

Re: [Qemu-devel] [PATCH v3] Execute _start and reach to the first function call successfully

2015-03-17 Thread Chen Gang
On 3/16/15 23:37, Richard Henderson wrote: > On 03/15/2015 04:57 PM, Chen Gang wrote: >> OK, thanks. And next, I shall try to send the whole tilegx patches again >> (it is about 6-8 patches), within 2015-03-18. > > When you do so, make sure it's against the *current* master tree. > > Your patch s

Re: [Qemu-devel] [PATCH v3] Execute _start and reach to the first function call successfully

2015-03-17 Thread Chen Gang
On 3/16/15 23:31, Richard Henderson wrote: > On 03/13/2015 11:03 PM, Chen Gang wrote: >> +static void decode_rrr_1_opcode_y0(struct DisasContext *dc, >> + tilegx_bundle_bits bundle) >> +{ >> +switch (get_RRROpcodeExtension_Y0(bundle)) { >> +case UNARY_RRR_

Re: [Qemu-devel] [PATCH 05/11] block: add delayed bitmap successor cleanup

2015-03-17 Thread John Snow
On 03/17/2015 02:44 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: Allow bitmap successors to carry reference counts. We can in a later patch use this ability to clean up the dirty bitmap according to both the individual job's success and the success of all jobs in the transact

[Qemu-devel] [ANNOUNCE] QEMU 2.3.0-rc0 is now available

2015-03-17 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 2.3 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.3.0-rc0.tar.bz2 You can help impr

[Qemu-devel] Duplicate definition of 'qemu_time' building git master

2015-03-17 Thread B Cran
When trying to build the latest git master on openSUSE 13.2, it failed with: vl.c:711:15: error: ‘qemu_time’ redeclared as different kind of symbol static time_t qemu_time(void) ^ In file included from qemu/include/block/aio.h:23:0, from qemu/include/hw/hw.h:13,

[Qemu-devel] Google SoC 2015 Idea - Extracting Virtual Device Implementation from QEMU

2015-03-17 Thread Guodong Zhu
Hi, I'm currently a Ph.D. student of the University of Georgia. My area of interest is virtualization and security. The security vulnerabilities of the virtual devices of QEMU are usually hard to find because generating specific inputs that can trigger the vulnerabilities for a vulnerable virtual

Re: [Qemu-devel] [PATCH v2 2/3] VFIO: Disable INTx interrupt on EEH reset

2015-03-17 Thread Alex Williamson
On Tue, 2015-03-17 at 03:31 +1100, Gavin Shan wrote: > When Linux guest recovers from EEH error on the following Emulex > adapter, the MSIx interrupts are disabled and the INTx emulation > is enabled. One INTx interrupt is injected to the guest by host > because of detected pending INTx interrupts

Re: [Qemu-devel] [PATCH v2 1/3] VFIO: Clear stale MSIx table during EEH reset

2015-03-17 Thread Alex Williamson
On Tue, 2015-03-17 at 03:31 +1100, Gavin Shan wrote: > The PCI device MSIx table is cleaned out in hardware after EEH PE > reset. However, we still hold the stale MSIx entries in QEMU, which > should be cleared accordingly. Otherwise, we will run into another > (recursive) EEH error and the PCI dev

Re: [Qemu-devel] [PATCH 11/11] iotests: 124 - transactional failure test

2015-03-17 Thread John Snow
On 03/17/2015 04:59 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: Use a transaction to request an incremental backup across two drives. Coerce one of the jobs to fail, and then re-run the transaction. Verify that no bitmap data was lost due to the partial transaction failure.

Re: [Qemu-devel] [PATCH v2 0/5] block/vpc optimizations

2015-03-17 Thread Max Reitz
On 2015-03-03 at 16:03, Max Reitz wrote: On 2015-03-03 at 05:41, Peter Lieven wrote: This series covers VPC format changes discussed during the last weeks. Peter v1->v2: Patch 1: added comment why we can exit after the first allocated sector [Max] Patch 2: Fixed gemotry in commit msg [

Re: [Qemu-devel] [PATCH 11/11] iotests: 124 - transactional failure test

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: Use a transaction to request an incremental backup across two drives. Coerce one of the jobs to fail, and then re-run the transaction. Verify that no bitmap data was lost due to the partial transaction failure. Signed-off-by: John Snow --- tests/qemu-

[Qemu-devel] [PATCH] qtest/ahci: Fix clang 3.5.0 error

2015-03-17 Thread John Snow
A thinko that clang 3.5.0 caught. Thankfully does not introduce any new failures. Signed-off-by: John Snow --- tests/ahci-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index cf0b98b..169e83b 100644 --- a/tests/ahci-test.c +++ b/t

Re: [Qemu-devel] [PATCH 10/11] iotests: 124 - backup_prepare refactoring

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: Allow tests to call just the backup preparation routine without invoking a backup. Useful for transactions where we want to prepare, but don't wish to issue the QMP command. Signed-off-by: John Snow --- tests/qemu-iotests/124 | 17 - 1

Re: [Qemu-devel] [PATCH 09/11] iotests: test 124 - drive object refactoring

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: The original test was not particularly good about keeping the relationships between bitmaps, drives, and images very explicit, so this patch adds an explicit 'drive' dict that is used to keep these relationships explicit. This is necessary in order to tes

Re: [Qemu-devel] [PATCH 08/11] iotests: add QMP event waiting queue

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: A filter is added to allow callers to request very specific events to be pulled from the event queue, while leaving undesired events still in the stream. This allows to poll for completion data for multiple asynchronous events in any arbitrary order. Sig

Re: [Qemu-devel] [PATCH 06/11] qmp: Add an implementation wrapper for qmp_drive_backup

2015-03-17 Thread Eric Blake
On 03/17/2015 01:16 PM, John Snow wrote: >> Other than that, I'm okay with a forward-declaration; if you want to >> move it, but I'd be fine with moving the code, too. >> >> With _drive_backup() being called do_drive_backup(): >> >> Reviewed-by: Max Reitz >> > > Moving the code around might be b

[Qemu-devel] [Bug 1433081] Re: kvm hardware error 0xffffffff with vfio-pci VGA passthrough

2015-03-17 Thread Alex Williamson
Your kernel is tainted with virtual box drivers, which are potentially incompatible with KVM. Remove and try again. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1433081 Title: kvm hardware error

Re: [Qemu-devel] clang 3.5.0 errors

2015-03-17 Thread John Snow
On 03/17/2015 03:34 PM, Peter Maydell wrote: On 17 March 2015 at 19:30, John Snow wrote: -Wunused-command-line-argument currently complains about the many include flags passed to each CC incantation -- presumably this is not really fixable, because we'd have to fix our Makefile to be a lot sm

[Qemu-devel] [Bug 1433081] Re: kvm hardware error 0xffffffff with vfio-pci VGA passthrough

2015-03-17 Thread v2min
** Description changed: - Please delete this bug report - it's conclusions are incorrect. While - the iso boots with raw but not qcow2, attempting to install using the - iso causes the same hardware error. Changing smp and cores to 1 allows - both qcow2 and raw to move forward with installs. + Hi,

Re: [Qemu-devel] [PATCH 07/11] block: drive_backup transaction callback support

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: This patch actually implements the transactional callback system for the drive_backup transaction. (1) We manually pick up a reference to the bitmap if present to allow its cleanup to be delayed until after all drive_backup jobs launched by the

Re: [Qemu-devel] [PATCH v2] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc)

2015-03-17 Thread Peter Maydell
On 17 March 2015 at 19:38, Christoffer Dall wrote: > On Tue, Mar 17, 2015 at 07:32:15PM +, Peter Maydell wrote: >> The AArch64 SPSR_EL1 register is architecturally mandated to >> be mapped to the AArch32 SPSR_svc register. This means its >> state should live in QEMU's env->banked_spsr[1] field

Re: [Qemu-devel] [PATCH v2] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc)

2015-03-17 Thread Christoffer Dall
On Tue, Mar 17, 2015 at 07:32:15PM +, Peter Maydell wrote: > The AArch64 SPSR_EL1 register is architecturally mandated to > be mapped to the AArch32 SPSR_svc register. This means its > state should live in QEMU's env->banked_spsr[1] field. > Correct the various places in the code that incorrect

Re: [Qemu-devel] clang 3.5.0 errors

2015-03-17 Thread Peter Maydell
On 17 March 2015 at 19:30, John Snow wrote: > -Wunused-command-line-argument currently complains about the many include > flags passed to each CC incantation -- presumably this is not really > fixable, because we'd have to fix our Makefile to be a lot smarter than it > is. We probably need to stif

Re: [Qemu-devel] [PATCH 06/11] qmp: Add an implementation wrapper for qmp_drive_backup

2015-03-17 Thread Max Reitz
On 2015-03-17 at 15:16, John Snow wrote: On 03/17/2015 02:51 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: We'd like to be able to specify the callback given to backup_start manually in the case of transactions, so split apart qmp_drive_backup into an implementation and a wrap

[Qemu-devel] [PATCH v2] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc)

2015-03-17 Thread Peter Maydell
The AArch64 SPSR_EL1 register is architecturally mandated to be mapped to the AArch32 SPSR_svc register. This means its state should live in QEMU's env->banked_spsr[1] field. Correct the various places in the code that incorrectly put it in banked_spsr[0]. Signed-off-by: Peter Maydell --- v1->v2:

[Qemu-devel] clang 3.5.0 errors

2015-03-17 Thread John Snow
Since we seem to be rejecting patches that introduce clang warnings on Peter Maydell's OSX configuration, I felt like I should detail the long list of errors we currently have that prevent me from thoroughly testing with clang in 3.5.0. There are five classes of errors that currently plague ou

[Qemu-devel] [Bug 1433081] Re: qcow2 causing kvm hardware error 0xffffffff with vfio-pci VGA passthrough

2015-03-17 Thread v2min
** Description changed: - Hi, - - Using qcow2 format for an ide-hd device is causing "KVM: entry failed, - hardware error 0x". When this error occurs, qemu-monitor shows - the guest has stopped. The error did not occur immediately, but at the - point that the boot, running from an attache

Re: [Qemu-devel] [PATCH qemu] profiler: Reenable built-in profiler

2015-03-17 Thread Paolo Bonzini
On 16/03/2015 04:57, Alexey Kardashevskiy wrote: > 2ed1ebcf6 "timer: replace time() with QEMU_CLOCK_HOST" broke compile > when configured with --enable-profiler. Turned out the profiler has been > broken for a while. > > This does s/qemu_time/tcg_time/ as the profiler only works in a TCG mode. >

[Qemu-devel] [Bug 1433081] Re: qcow2 causing kvm hardware error 0xffffffff with vfio-pci VGA passthrough

2015-03-17 Thread v2min
** Tags removed: gpu hardware kvm passthrough vfio-pci ** Attachment removed: "qcow2_dmesg_report.txt" https://bugs.launchpad.net/qemu/+bug/1433081/+attachment/4347843/+files/qcow2_dmesg_report.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is sub

Re: [Qemu-devel] [PATCH] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc)

2015-03-17 Thread Peter Maydell
On 17 March 2015 at 19:22, Christoffer Dall wrote: > On Tue, Mar 17, 2015 at 07:19:35PM +, Peter Maydell wrote: >> The AArch64 SPSR_EL1 register is architecturally mandated to >> be mapped to the AArch32 SPSR_svc register. This means its >> state should live in QEMU's env->banked_spsr[1] field

Re: [Qemu-devel] [PATCH] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc)

2015-03-17 Thread Christoffer Dall
On Tue, Mar 17, 2015 at 07:19:35PM +, Peter Maydell wrote: > The AArch64 SPSR_EL1 register is architecturally mandated to > be mapped to the AArch32 SPSR_svc register. This means its > state should live in QEMU's env->banked_spsr[1] field. > Correct the buggy regdef that put it in banked_spsr[0

Re: [Qemu-devel] [PATCH] add pci-bridge-seat

2015-03-17 Thread Michael S. Tsirkin
On Tue, Mar 17, 2015 at 08:16:45AM +0100, Gerd Hoffmann wrote: > On Mo, 2015-03-16 at 13:20 +0100, Michael S. Tsirkin wrote: > > On Mon, Mar 16, 2015 at 11:36:43AM +0100, Gerd Hoffmann wrote: > > > Simplifies multiseat configuration, see > > > docs/multiseat.txt update for details. > > > > > > Sig

[Qemu-devel] [PATCH] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc)

2015-03-17 Thread Peter Maydell
The AArch64 SPSR_EL1 register is architecturally mandated to be mapped to the AArch32 SPSR_svc register. This means its state should live in QEMU's env->banked_spsr[1] field. Correct the buggy regdef that put it in banked_spsr[0] instead. Signed-off-by: Peter Maydell --- target-arm/helper.c | 2

Re: [Qemu-devel] [PATCH 06/11] qmp: Add an implementation wrapper for qmp_drive_backup

2015-03-17 Thread John Snow
On 03/17/2015 02:51 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: We'd like to be able to specify the callback given to backup_start manually in the case of transactions, so split apart qmp_drive_backup into an implementation and a wrapper. Switch drive_backup_prepare to use t

Re: [Qemu-devel] [PATCH 05/11] block: add delayed bitmap successor cleanup

2015-03-17 Thread John Snow
On 03/17/2015 02:44 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: Allow bitmap successors to carry reference counts. We can in a later patch use this ability to clean up the dirty bitmap according to both the individual job's success and the success of all jobs in the transact

Re: [Qemu-devel] [PATCH v4 4/5] target-arm: kvm64 fix save/restore of SPSR regs

2015-03-17 Thread Peter Maydell
On 17 March 2015 at 19:04, Christoffer Dall wrote: > On Tue, Mar 17, 2015 at 04:18:16PM +, Peter Maydell wrote: >> Note that this code is implicitly relying on the >> ordering of register banks defined by the bank_number() >> function, which is a bit icky. > > right, I thought you wrote this c

[Qemu-devel] RFC: -object vs -chardev creation order

2015-03-17 Thread Daniel P. Berrange
The current QEMU startup code will create -chardev backends first, then create -object backends, then -fsdev backends and so on, in some pretty arbitrary order of types. There is already a dependancy from the rng-egd object type, which has a link to a chardev, which requires -chardev options be pr

Re: [Qemu-devel] [PATCH v4 4/5] target-arm: kvm64 fix save/restore of SPSR regs

2015-03-17 Thread Christoffer Dall
On Tue, Mar 17, 2015 at 04:18:16PM +, Peter Maydell wrote: > On 16 March 2015 at 11:01, Alex Bennée wrote: > > From: Christoffer Dall > > > > The current code was negatively indexing the cpu state array and not > > synchronizing banked spsr register state with the current mode's spsr > > stat

Re: [Qemu-devel] [PATCH 03/11] block: add transactional callbacks feature

2015-03-17 Thread John Snow
On 03/17/2015 02:18 PM, Eric Blake wrote: On 03/17/2015 12:04 PM, John Snow wrote: +typedef void (CallbackFn)(void *opaque, int ret); + +/* Temporary. Removed in the next patch. */ Actually, no. :-) (remove in patch 7) Why are you making them non-static in the first place? I see both func

Re: [Qemu-devel] [PULL 00/13] migration pull queue

2015-03-17 Thread Peter Maydell
available in the git repository at: > > git://github.com/juanquintela/qemu.git tags/migration/20150317 > > for you to fetch changes up to cde63fbed86e20dda98bf35025faedd994918f00: > > migration: Expose '

Re: [Qemu-devel] [PATCH 06/11] qmp: Add an implementation wrapper for qmp_drive_backup

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: We'd like to be able to specify the callback given to backup_start manually in the case of transactions, so split apart qmp_drive_backup into an implementation and a wrapper. Switch drive_backup_prepare to use the new wrapper, but don't overload the callb

Re: [Qemu-devel] Fedora Virt preview and qemu 2.2.1 update

2015-03-17 Thread Gerhard Wiesinger
On 17.03.2015 14:59, Cole Robinson wrote: On 03/16/2015 06:20 PM, Gerhard Wiesinger wrote: On 16.03.2015 19:49, Cole Robinson wrote: Since 2.3 rc0 should be out tomorrow, I'll just wait for that to be released and build it for rawhide/f22 and virt-preview Shouldn't we have a 2.2.1 version, to

Re: [Qemu-devel] [PATCH 03/11] block: add transactional callbacks feature

2015-03-17 Thread Eric Blake
On 03/17/2015 12:04 PM, John Snow wrote: >>> +typedef void (CallbackFn)(void *opaque, int ret); >>> + >>> +/* Temporary. Removed in the next patch. */ >> >> Actually, no. :-) >> >> (remove in patch 7) >> >> Why are you making them non-static in the first place? I see both >> functions mentioned in

Re: [Qemu-devel] [PATCH 05/11] block: add delayed bitmap successor cleanup

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: Allow bitmap successors to carry reference counts. We can in a later patch use this ability to clean up the dirty bitmap according to both the individual job's success and the success of all jobs in the transaction group. The code for cleaning up a bitma

Re: [Qemu-devel] [PATCH 03/11] block: add transactional callbacks feature

2015-03-17 Thread Max Reitz
On 2015-03-17 at 14:04, John Snow wrote: On 03/17/2015 01:47 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: The goal here is to add a new method to transactions that allows developers to specify a callback that will get invoked only once all jobs spawned by a transaction are co

Re: [Qemu-devel] Fedora Virt preview and qemu 2.2.1 update

2015-03-17 Thread Eric Blake
On 03/17/2015 12:28 PM, Gerhard Wiesinger wrote: > Yes, but shouldn't be there a difference between rawhide (e.g. 2.3-rc0) > and fedora virt preview library (e.g. currently 2.2.1)? > Or is rawhide everything and fedora-virt-preview.repo only the virt part > of rawhide? > https://fedoraproject.org/

Re: [Qemu-devel] [PATCH 03/11] block: add transactional callbacks feature

2015-03-17 Thread John Snow
On 03/17/2015 01:47 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: The goal here is to add a new method to transactions that allows developers to specify a callback that will get invoked only once all jobs spawned by a transaction are completed, allowing developers the chance to

Re: [Qemu-devel] [PATCH 04/11] block: add refcount to Job object

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: If we want to get at the job after the life of the job, we'll need a refcount for this object. This may occur for example if we wish to inspect the actions taken by a particular job after a transactional group of jobs runs, and further actions are require

Re: [Qemu-devel] [PATCH 03/11] block: add transactional callbacks feature

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: The goal here is to add a new method to transactions that allows developers to specify a callback that will get invoked only once all jobs spawned by a transaction are completed, allowing developers the chance to perform actions conditionally pending compl

Re: [Qemu-devel] [2.4 PATCH v3 16/19] hbitmap: truncate tests

2015-03-17 Thread Max Reitz
On 2015-03-17 at 13:44, John Snow wrote: On 03/17/2015 01:28 PM, Max Reitz wrote: On 2015-03-17 at 13:21, John Snow wrote: On 03/17/2015 10:53 AM, Max Reitz wrote: On 2015-03-13 at 14:30, John Snow wrote: The general approach is to set bits close to the boundaries of where we are truncati

Re: [Qemu-devel] [2.4 PATCH v3 16/19] hbitmap: truncate tests

2015-03-17 Thread John Snow
On 03/17/2015 01:28 PM, Max Reitz wrote: On 2015-03-17 at 13:21, John Snow wrote: On 03/17/2015 10:53 AM, Max Reitz wrote: On 2015-03-13 at 14:30, John Snow wrote: The general approach is to set bits close to the boundaries of where we are truncating and ensure that everything appears to h

Re: [Qemu-devel] [PATCH] target-arm: Fix handling of STM (user) with r15 in register list

2015-03-17 Thread Peter Maydell
On 17 March 2015 at 17:28, Greg Bellows wrote: > Oh missed that and I checked the archive and did not see any review-by > and figured you wanted to get it in... No problem; even belated review is worthwhile, because if you'd spotted a problem we could have fixed it. -- PMM

Re: [Qemu-devel] [PATCH v4 4/5] target-arm: kvm64 fix save/restore of SPSR regs

2015-03-17 Thread Peter Maydell
On 16 March 2015 at 11:01, Alex Bennée wrote: > From: Christoffer Dall > > The current code was negatively indexing the cpu state array and not > synchronizing banked spsr register state with the current mode's spsr > state, causing occasional failures with migration. > > Some munging is done to

Re: [Qemu-devel] [PATCH] target-arm: Fix handling of STM (user) with r15 in register list

2015-03-17 Thread Greg Bellows
On Tue, Mar 17, 2015 at 10:26 AM, Peter Maydell wrote: > On 17 March 2015 at 17:24, Greg Bellows wrote: >> On Tue, Mar 10, 2015 at 12:18 PM, Peter Maydell >> wrote: >>> The A32 encoding of LDM distinguishes LDM (user) from LDM (exception >>> return) based on whether r15 is in the register list.

Re: [Qemu-devel] [PATCH] raw-posix: Deprecate host floppy passthrough

2015-03-17 Thread Eric Blake
On 03/17/2015 10:02 AM, Markus Armbruster wrote: > Raise your hand if you have a physical floppy drive in a computer > you've powered on in 2015. Okay, I see we got a few weirdos in the > audience. That's okay, weirdos are welcome here. > > Kidding aside, media change detection doesn't fully wor

Re: [Qemu-devel] [2.4 PATCH v3 16/19] hbitmap: truncate tests

2015-03-17 Thread Max Reitz
On 2015-03-17 at 13:21, John Snow wrote: On 03/17/2015 10:53 AM, Max Reitz wrote: On 2015-03-13 at 14:30, John Snow wrote: The general approach is to set bits close to the boundaries of where we are truncating and ensure that everything appears to have gone OK. We test growing and shrinking

Re: [Qemu-devel] [PATCH for-next] pc: Ensure non-zero CPU ref count after attaching to ICC bus

2015-03-17 Thread Andreas Färber
Am 17.03.2015 um 18:04 schrieb Eduardo Habkost: > On Tue, Mar 17, 2015 at 05:46:36PM +0100, Andreas Färber wrote: > [...] >> @@ -1054,7 +1055,12 @@ void pc_hot_add_cpu(const int64_t id, Error **errp) >> >> icc_bridge = DEVICE(object_resolve_path_type("icc-bridge", >>

Re: [Qemu-devel] KVM emulation failure with recent kernel and QEMU Seabios

2015-03-17 Thread Bandan Das
Gerd Hoffmann writes: > On Mo, 2015-03-16 at 14:16 -0400, Bandan Das wrote: >> Jan Kiszka writes: >> >> > Am 2015-03-12 um 09:11 schrieb Gerd Hoffmann: >> >> On Do, 2015-03-12 at 09:09 +0100, Jan Kiszka wrote: >> >>> Hi, >> >>> >> >>> apparently since the latest QEMU updates I'm getting this on

Re: [Qemu-devel] [PATCH] raw-posix: Deprecate host floppy passthrough

2015-03-17 Thread John Snow
On 03/17/2015 12:02 PM, Markus Armbruster wrote: Raise your hand if you have a physical floppy drive in a computer you've powered on in 2015. Okay, I see we got a few weirdos in the audience. That's okay, weirdos are welcome here. May I introduce to you my reference Q35 machine: http://i.i

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add myself as the maintainer of the Quorum driver

2015-03-17 Thread Stefan Hajnoczi
On Mon, Mar 16, 2015 at 06:22:05PM +0200, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d7e9ba2..1fcf1e0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1176,3 +1176,8

Re: [Qemu-devel] [PATCH] target-arm: Fix handling of STM (user) with r15 in register list

2015-03-17 Thread Peter Maydell
On 17 March 2015 at 17:24, Greg Bellows wrote: > On Tue, Mar 10, 2015 at 12:18 PM, Peter Maydell > wrote: >> The A32 encoding of LDM distinguishes LDM (user) from LDM (exception >> return) based on whether r15 is in the register list. However for >> STM (user) there is no equivalent distinction.

Re: [Qemu-devel] [2.4 PATCH v3 15/19] block: Resize bitmaps on bdrv_truncate

2015-03-17 Thread John Snow
On 03/17/2015 09:50 AM, Max Reitz wrote: On 2015-03-13 at 14:30, John Snow wrote: Signed-off-by: John Snow --- block.c| 18 + include/qemu/hbitmap.h | 10 ++ util/hbitmap.c | 52 ++ 3 files ch

Re: [Qemu-devel] [PATCH] target-arm: Fix handling of STM (user) with r15 in register list

2015-03-17 Thread Greg Bellows
On Tue, Mar 10, 2015 at 12:18 PM, Peter Maydell wrote: > The A32 encoding of LDM distinguishes LDM (user) from LDM (exception > return) based on whether r15 is in the register list. However for > STM (user) there is no equivalent distinction. We were incorrectly > treating "r15 in list" as indicat

Re: [Qemu-devel] [2.4 PATCH v3 16/19] hbitmap: truncate tests

2015-03-17 Thread John Snow
On 03/17/2015 10:53 AM, Max Reitz wrote: On 2015-03-13 at 14:30, John Snow wrote: The general approach is to set bits close to the boundaries of where we are truncating and ensure that everything appears to have gone OK. We test growing and shrinking by different amounts: - Less than the gran

Re: [Qemu-devel] [2.4 PATCH v3 15/19] block: Resize bitmaps on bdrv_truncate

2015-03-17 Thread Max Reitz
On 2015-03-17 at 13:13, John Snow wrote: On 03/17/2015 09:50 AM, Max Reitz wrote: On 2015-03-13 at 14:30, John Snow wrote: Signed-off-by: John Snow --- block.c| 18 + include/qemu/hbitmap.h | 10 ++ util/hbitmap.c | 52 +

Re: [Qemu-devel] [PATCH] raw-posix: Deprecate host floppy passthrough

2015-03-17 Thread Max Reitz
On 2015-03-17 at 12:02, Markus Armbruster wrote: Raise your hand if you have a physical floppy drive in a computer you've powered on in 2015. Okay, I see we got a few weirdos in the audience. That's okay, weirdos are welcome here. I do have a USB floppy drive. If I stuff that into my case, do

Re: [Qemu-devel] [PULL 0/3] QOM CPUState patch queue 2015-03-17

2015-03-17 Thread Peter Maydell
On 17 March 2015 at 15:30, Andreas Färber wrote: > Hello Peter, > > This is my QOM CPU patch queue. Please pull. > > I'm taking the liberty to also include a trivial x86 patch by Eduardo. > > Regards, > Andreas > > Cc: Peter Maydell > > Cc: Eduardo Habkost > > The following changes since commit

  1   2   3   >